@opensip-cli/checks-universal 0.1.0

package/dist/checks/quality/observability/pino-serializer-coverage.js

@@ -0,0 +1,209 @@
+/**
+ * @fileoverview Pino Serializer Coverage Check
+ *
+ * Validates that complex objects logged with Pino have serializers:
+ * - Objects without registered serializers break structured logging
+ * - Circular references cause logging failures
+ * - Large objects need truncation
+ */
+import { defineCheck } from '@opensip-cli/fitness';
+/**
+ * Pre-compiled patterns for complex objects that need serializers.
+ * These patterns are intentional and safe for static code analysis.
+ * They detect object references in log statements, not user input.
+ */
+const REQUEST_PATTERN = new RegExp(String.raw `\breq\s*[,}]`);
+const QUERY_RUNNER_PATTERN = new RegExp(String.raw `queryRunner\s*[,}]`, 'i');
+const ENTITY_PATTERN = new RegExp(String.raw `\bentity\s*[,}]`, 'i');
+/**
+ * Known complex objects that need serializers
+ */
+const COMPLEX_OBJECTS = [
+    { pattern: REQUEST_PATTERN, name: 'Request' },
+    { pattern: QUERY_RUNNER_PATTERN, name: 'QueryRunner' },
+    { pattern: ENTITY_PATTERN, name: 'Entity' },
+];
+/**
+ * Pre-compiled patterns for safe serialization indicators.
+ * These patterns are intentional and safe for static code analysis.
+ * Using escaped dot (\\.) instead of character class [.] per sonarjs/single-char-in-character-classes.
+ */
+const SAFE_ID_PATTERN = /\.id\s{0,10}[,}]/;
+const SAFE_NAME_PATTERN = /\.name\s{0,10}[,}]/;
+const SAFE_TO_STRING_PATTERN = /\.toString\s{0,10}\(\)/;
+const SAFE_JSON_STRINGIFY_PATTERN = /JSON\.stringify/;
+const SAFE_TO_JSON_PATTERN = /\.toJSON\s{0,10}\(\)/;
+/**
+ * Safe patterns that indicate proper serialization
+ */
+const SAFE_PATTERNS = [
+    SAFE_ID_PATTERN,
+    SAFE_NAME_PATTERN,
+    SAFE_TO_STRING_PATTERN,
+    SAFE_JSON_STRINGIFY_PATTERN,
+    SAFE_TO_JSON_PATTERN,
+];
+/**
+ * Pre-compiled pattern for detecting logger calls with objects.
+ * This pattern is intentional and safe for static code analysis.
+ * Using bounded quantifiers for safety.
+ */
+const LOG_CALL_PATTERN = /logger\.(info|warn|error|debug|trace)\s{0,10}\(\s{0,10}\{/;
+/**
+ * Pre-compiled pattern for detecting circular reference issues.
+ * This pattern is intentional and safe for static code analysis.
+ * Using bounded quantifiers for safety.
+ */
+const THIS_PATTERN = /:\s{0,10}this\s{0,10}[,}]/;
+/**
+ * Counts brackets in a line
+ * @param line - The line to count brackets in
+ * @returns The net bracket count (open minus close)
+ */
+function countBrackets(line) {
+    let openCount = 0;
+    let closeCount = 0;
+    for (const char of line) {
+        if (char === '{')
+            openCount++;
+        if (char === '}')
+            closeCount++;
+    }
+    return openCount - closeCount;
+}
+/**
+ * Builds the complete log statement from multiple lines
+ * @param lines - All lines in the file
+ * @param startIndex - Starting line index
+ * @returns The complete log statement
+ */
+function buildLogStatement(lines, startIndex) {
+    const firstLine = lines[startIndex];
+    if (!firstLine)
+        return '';
+    let logStatement = firstLine;
+    let bracketCount = countBrackets(firstLine);
+    let j = startIndex + 1;
+    while (bracketCount > 0 && j < lines.length) {
+        const nextLine = lines[j];
+        if (nextLine) {
+            logStatement += '\n' + nextLine;
+            bracketCount += countBrackets(nextLine);
+        }
+        j++;
+    }
+    return logStatement;
+}
+/**
+ * Creates complex object violation info
+ */
+function createComplexObjectViolation(lineNum, objectName, match) {
+    const lowerName = objectName.toLowerCase();
+    return {
+        lineNum,
+        message: `Logging ${objectName} object without serializer`,
+        suggestion: `Register a Pino serializer for ${objectName} objects, or extract specific fields: { ${lowerName}Id: ${lowerName}.id, ${lowerName}Name: ${lowerName}.name }`,
+        match,
+    };
+}
+/**
+ * Creates circular reference violation info
+ */
+function createCircularReferenceViolation(lineNum, match) {
+    return {
+        lineNum,
+        message: 'Logging "this" directly may cause circular reference',
+        suggestion: 'Extract specific properties from "this" instead of logging the entire object: { className: this.constructor.name, id: this.id }',
+        match,
+    };
+}
+/**
+ * Checks for complex object violations in log statement
+ */
+function checkComplexObjects(logStatement, lineNum, match, violationInfos) {
+    for (const { pattern, name } of COMPLEX_OBJECTS) {
+        if (pattern.test(logStatement)) {
+            violationInfos.push(createComplexObjectViolation(lineNum, name, match));
+        }
+    }
+}
+/**
+ * Checks for circular reference violations in log statement
+ */
+function checkCircularReferences(logStatement, lineNum, match, violationInfos) {
+    if (THIS_PATTERN.test(logStatement)) {
+        violationInfos.push(createCircularReferenceViolation(lineNum, match));
+    }
+}
+/**
+ * Analyze a file for Pino serializer coverage issues
+ */
+function analyzeFile(content, _filePath) {
+    const violations = [];
+    // Quick filter: skip files without logger patterns
+    if (!content.includes('logger.info') &&
+        !content.includes('logger.warn') &&
+        !content.includes('logger.error') &&
+        !content.includes('logger.debug')) {
+        return violations;
+    }
+    const lines = content.split('\n');
+    for (let i = 0; i < lines.length; i++) {
+        const line = lines[i];
+        if (!line)
+            continue;
+        // Check for logger calls with objects
+        if (!LOG_CALL_PATTERN.test(line))
+            continue;
+        // Get the full log statement (may span multiple lines)
+        const logStatement = buildLogStatement(lines, i);
+        // Check if any safe patterns are used
+        const isSafe = SAFE_PATTERNS.some((p) => p.test(logStatement));
+        if (isSafe)
+            continue;
+        const lineNum = i + 1;
+        const violationInfos = [];
+        checkComplexObjects(logStatement, lineNum, line, violationInfos);
+        checkCircularReferences(logStatement, lineNum, line, violationInfos);
+        for (const info of violationInfos) {
+            violations.push({
+                line: info.lineNum,
+                column: 0,
+                message: info.message,
+                severity: 'warning',
+                suggestion: info.suggestion,
+                match: info.match,
+            });
+        }
+    }
+    return violations;
+}
+/**
+ * Check: quality/pino-serializer-coverage
+ *
+ * Validates that complex objects logged have proper Pino serializers.
+ */
+export const pinoSerializerCoverage = defineCheck({
+    id: 'e54a6ff0-332e-4848-bc62-d7df37b4795a',
+    slug: 'pino-serializer-coverage',
+    scope: { languages: ['typescript'], concerns: ['backend', 'server'] },
+    contentFilter: 'strip-strings-and-comments',
+    confidence: 'medium',
+    description: 'Validates that complex objects logged have proper Pino serializers',
+    longDescription: `**Purpose:** Validates that complex objects passed to Pino logger calls have proper serializers registered, preventing structured logging failures from circular references or oversized objects.
+
+**Detects:**
+- \`logger.(info|warn|error|debug|trace)\` calls containing complex object references: \`req\` (Request), \`queryRunner\` (QueryRunner), \`entity\` (Entity) without safe serialization
+- Logging \`this\` directly (matched via \`:\\s*this\\s*[,}]\`), which risks circular reference errors
+- Skips log statements that use safe patterns: \`.id\`, \`.name\`, \`.toString()\`, \`JSON.stringify\`, or \`.toJSON()\`
+
+**Why it matters:** Logging unserialized complex objects causes Pino to fail silently, produce truncated output, or throw circular reference errors -- all of which degrade observability in production.
+
+**Scope:** General best practice. Analyzes each file individually using regex-based log statement scanning.`,
+    tags: ['logging', 'quality'],
+    fileTypes: ['ts'],
+    // @fitness-ignore-next-line no-hardcoded-timeouts -- framework default for fitness check execution
+    timeout: 180_000, // 3 minutes - scans log statements across codebase
+    analyze: analyzeFile,
+});
+//# sourceMappingURL=pino-serializer-coverage.js.map

package/dist/checks/quality/observability/pino-serializer-coverage.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"pino-serializer-coverage.js","sourceRoot":"","sources":["../../../../src/checks/quality/observability/pino-serializer-coverage.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,OAAO,EAAE,WAAW,EAAuB,MAAM,sBAAsB,CAAC;AAExE;;;;GAIG;AACH,MAAM,eAAe,GAAG,IAAI,MAAM,CAAC,MAAM,CAAC,GAAG,CAAA,cAAc,CAAC,CAAC;AAC7D,MAAM,oBAAoB,GAAG,IAAI,MAAM,CAAC,MAAM,CAAC,GAAG,CAAA,oBAAoB,EAAE,GAAG,CAAC,CAAC;AAC7E,MAAM,cAAc,GAAG,IAAI,MAAM,CAAC,MAAM,CAAC,GAAG,CAAA,iBAAiB,EAAE,GAAG,CAAC,CAAC;AAEpE;;GAEG;AACH,MAAM,eAAe,GAAG;IACtB,EAAE,OAAO,EAAE,eAAe,EAAE,IAAI,EAAE,SAAS,EAAE;IAC7C,EAAE,OAAO,EAAE,oBAAoB,EAAE,IAAI,EAAE,aAAa,EAAE;IACtD,EAAE,OAAO,EAAE,cAAc,EAAE,IAAI,EAAE,QAAQ,EAAE;CAC5C,CAAC;AAEF;;;;GAIG;AACH,MAAM,eAAe,GAAG,kBAAkB,CAAC;AAC3C,MAAM,iBAAiB,GAAG,oBAAoB,CAAC;AAC/C,MAAM,sBAAsB,GAAG,wBAAwB,CAAC;AACxD,MAAM,2BAA2B,GAAG,iBAAiB,CAAC;AACtD,MAAM,oBAAoB,GAAG,sBAAsB,CAAC;AAEpD;;GAEG;AACH,MAAM,aAAa,GAAG;IACpB,eAAe;IACf,iBAAiB;IACjB,sBAAsB;IACtB,2BAA2B;IAC3B,oBAAoB;CACrB,CAAC;AAEF;;;;GAIG;AACH,MAAM,gBAAgB,GAAG,2DAA2D,CAAC;AAErF;;;;GAIG;AACH,MAAM,YAAY,GAAG,2BAA2B,CAAC;AAEjD;;;;GAIG;AACH,SAAS,aAAa,CAAC,IAAY;IACjC,IAAI,SAAS,GAAG,CAAC,CAAC;IAClB,IAAI,UAAU,GAAG,CAAC,CAAC;IACnB,KAAK,MAAM,IAAI,IAAI,IAAI,EAAE,CAAC;QACxB,IAAI,IAAI,KAAK,GAAG;YAAE,SAAS,EAAE,CAAC;QAC9B,IAAI,IAAI,KAAK,GAAG;YAAE,UAAU,EAAE,CAAC;IACjC,CAAC;IACD,OAAO,SAAS,GAAG,UAAU,CAAC;AAChC,CAAC;AAED;;;;;GAKG;AACH,SAAS,iBAAiB,CAAC,KAAe,EAAE,UAAkB;IAC5D,MAAM,SAAS,GAAG,KAAK,CAAC,UAAU,CAAC,CAAC;IACpC,IAAI,CAAC,SAAS;QAAE,OAAO,EAAE,CAAC;IAE1B,IAAI,YAAY,GAAG,SAAS,CAAC;IAC7B,IAAI,YAAY,GAAG,aAAa,CAAC,SAAS,CAAC,CAAC;IAC5C,IAAI,CAAC,GAAG,UAAU,GAAG,CAAC,CAAC;IAEvB,OAAO,YAAY,GAAG,CAAC,IAAI,CAAC,GAAG,KAAK,CAAC,MAAM,EAAE,CAAC;QAC5C,MAAM,QAAQ,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;QAC1B,IAAI,QAAQ,EAAE,CAAC;YACb,YAAY,IAAI,IAAI,GAAG,QAAQ,CAAC;YAChC,YAAY,IAAI,aAAa,CAAC,QAAQ,CAAC,CAAC;QAC1C,CAAC;QACD,CAAC,EAAE,CAAC;IACN,CAAC;IAED,OAAO,YAAY,CAAC;AACtB,CAAC;AASD;;GAEG;AACH,SAAS,4BAA4B,CACnC,OAAe,EACf,UAAkB,EAClB,KAAa;IAEb,MAAM,SAAS,GAAG,UAAU,CAAC,WAAW,EAAE,CAAC;IAC3C,OAAO;QACL,OAAO;QACP,OAAO,EAAE,WAAW,UAAU,4BAA4B;QAC1D,UAAU,EAAE,kCAAkC,UAAU,2CAA2C,SAAS,OAAO,SAAS,QAAQ,SAAS,SAAS,SAAS,SAAS;QACxK,KAAK;KACN,CAAC;AACJ,CAAC;AAED;;GAEG;AACH,SAAS,gCAAgC,CAAC,OAAe,EAAE,KAAa;IACtE,OAAO;QACL,OAAO;QACP,OAAO,EAAE,sDAAsD;QAC/D,UAAU,EACR,iIAAiI;QACnI,KAAK;KACN,CAAC;AACJ,CAAC;AAED;;GAEG;AACH,SAAS,mBAAmB,CAC1B,YAAoB,EACpB,OAAe,EACf,KAAa,EACb,cAA+B;IAE/B,KAAK,MAAM,EAAE,OAAO,EAAE,IAAI,EAAE,IAAI,eAAe,EAAE,CAAC;QAChD,IAAI,OAAO,CAAC,IAAI,CAAC,YAAY,CAAC,EAAE,CAAC;YAC/B,cAAc,CAAC,IAAI,CAAC,4BAA4B,CAAC,OAAO,EAAE,IAAI,EAAE,KAAK,CAAC,CAAC,CAAC;QAC1E,CAAC;IACH,CAAC;AACH,CAAC;AAED;;GAEG;AACH,SAAS,uBAAuB,CAC9B,YAAoB,EACpB,OAAe,EACf,KAAa,EACb,cAA+B;IAE/B,IAAI,YAAY,CAAC,IAAI,CAAC,YAAY,CAAC,EAAE,CAAC;QACpC,cAAc,CAAC,IAAI,CAAC,gCAAgC,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC,CAAC;IACxE,CAAC;AACH,CAAC;AAED;;GAEG;AACH,SAAS,WAAW,CAAC,OAAe,EAAE,SAAiB;IACrD,MAAM,UAAU,GAAqB,EAAE,CAAC;IAExC,mDAAmD;IACnD,IACE,CAAC,OAAO,CAAC,QAAQ,CAAC,aAAa,CAAC;QAChC,CAAC,OAAO,CAAC,QAAQ,CAAC,aAAa,CAAC;QAChC,CAAC,OAAO,CAAC,QAAQ,CAAC,cAAc,CAAC;QACjC,CAAC,OAAO,CAAC,QAAQ,CAAC,cAAc,CAAC,EACjC,CAAC;QACD,OAAO,UAAU,CAAC;IACpB,CAAC;IAED,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAElC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;QACtC,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;QACtB,IAAI,CAAC,IAAI;YAAE,SAAS;QAEpB,sCAAsC;QACtC,IAAI,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,CAAC;YAAE,SAAS;QAE3C,uDAAuD;QACvD,MAAM,YAAY,GAAG,iBAAiB,CAAC,KAAK,EAAE,CAAC,CAAC,CAAC;QAEjD,sCAAsC;QACtC,MAAM,MAAM,GAAG,aAAa,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC,CAAC;QAC/D,IAAI,MAAM;YAAE,SAAS;QAErB,MAAM,OAAO,GAAG,CAAC,GAAG,CAAC,CAAC;QACtB,MAAM,cAAc,GAAoB,EAAE,CAAC;QAE3C,mBAAmB,CAAC,YAAY,EAAE,OAAO,EAAE,IAAI,EAAE,cAAc,CAAC,CAAC;QACjE,uBAAuB,CAAC,YAAY,EAAE,OAAO,EAAE,IAAI,EAAE,cAAc,CAAC,CAAC;QAErE,KAAK,MAAM,IAAI,IAAI,cAAc,EAAE,CAAC;YAClC,UAAU,CAAC,IAAI,CAAC;gBACd,IAAI,EAAE,IAAI,CAAC,OAAO;gBAClB,MAAM,EAAE,CAAC;gBACT,OAAO,EAAE,IAAI,CAAC,OAAO;gBACrB,QAAQ,EAAE,SAAS;gBACnB,UAAU,EAAE,IAAI,CAAC,UAAU;gBAC3B,KAAK,EAAE,IAAI,CAAC,KAAK;aAClB,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED;;;;GAIG;AACH,MAAM,CAAC,MAAM,sBAAsB,GAAG,WAAW,CAAC;IAChD,EAAE,EAAE,sCAAsC;IAC1C,IAAI,EAAE,0BAA0B;IAChC,KAAK,EAAE,EAAE,SAAS,EAAE,CAAC,YAAY,CAAC,EAAE,QAAQ,EAAE,CAAC,SAAS,EAAE,QAAQ,CAAC,EAAE;IACrE,aAAa,EAAE,4BAA4B;IAE3C,UAAU,EAAE,QAAQ;IACpB,WAAW,EAAE,oEAAoE;IACjF,eAAe,EAAE;;;;;;;;;4GASyF;IAC1G,IAAI,EAAE,CAAC,SAAS,EAAE,SAAS,CAAC;IAC5B,SAAS,EAAE,CAAC,IAAI,CAAC;IACjB,mGAAmG;IACnG,OAAO,EAAE,OAAO,EAAE,mDAAmD;IAErE,OAAO,EAAE,WAAW;CACrB,CAAC,CAAC"}

package/dist/checks/quality/patterns/async-state-pattern.d.ts

@@ -0,0 +1,14 @@
+/**
+ * @fileoverview Async State Pattern Check
+ *
+ * Enforces that data-driven screens are wrapped in the AsyncState pattern.
+ * Screens using TanStack Query should use AsyncState for consistent loading/error handling.
+ */
+/**
+ * Check: quality/async-state-pattern
+ *
+ * Ensures data-driven screens use AsyncState pattern for consistent
+ * loading and error state handling with TanStack Query.
+ */
+export declare const asyncStatePattern: import("@opensip-cli/fitness").Check;
+//# sourceMappingURL=async-state-pattern.d.ts.map

package/dist/checks/quality/patterns/async-state-pattern.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"async-state-pattern.d.ts","sourceRoot":"","sources":["../../../../src/checks/quality/patterns/async-state-pattern.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAiBH;;;;;GAKG;AACH,eAAO,MAAM,iBAAiB,sCAgE5B,CAAC"}

package/dist/checks/quality/patterns/async-state-pattern.js

@@ -0,0 +1,80 @@
+/**
+ * @fileoverview Async State Pattern Check
+ *
+ * Enforces that data-driven screens are wrapped in the AsyncState pattern.
+ * Screens using TanStack Query should use AsyncState for consistent loading/error handling.
+ */
+// @fitness-ignore-next-line no-markdown-references -- rule provenance reference for developer context
+// Rule source: .augment/rules/ui-patterns.md
+import { defineCheck, extractSnippet } from '@opensip-cli/fitness';
+/**
+ * Paths to exclude from checking
+ */
+const NON_SCREEN_PATTERNS = [
+    /node_modules/,
+    /__tests__/,
+    /\.test\./,
+    /\.spec\./,
+    /components\/patterns\//, // The pattern components themselves
+];
+/**
+ * Check: quality/async-state-pattern
+ *
+ * Ensures data-driven screens use AsyncState pattern for consistent
+ * loading and error state handling with TanStack Query.
+ */
+export const asyncStatePattern = defineCheck({
+    id: '3bc0cb23-7354-4f85-b39f-d21813e6394c',
+    slug: 'async-state-pattern',
+    disabled: true,
+    scope: { languages: ['typescript'], concerns: ['backend', 'server'] },
+    contentFilter: 'strip-strings',
+    confidence: 'medium',
+    description: 'Ensure data-driven screens use AsyncState pattern',
+    longDescription: `**Purpose:** Enforces that data-driven screens wrap TanStack Query results in the AsyncState component for consistent loading/error handling.
+
+**Detects:** Analyzes each file individually. Screen files in \`/screens/\` that import \`useQuery\`, \`useMutation\`, or \`useInfiniteQuery\` but do not reference \`AsyncState\` or \`<AsyncState\`.
+
+**Why it matters:** Without AsyncState, each screen implements its own loading/error UI, leading to inconsistent user experience and duplicated boilerplate.
+
+**Scope:** Codebase-specific convention (rule source: .augment/rules/ui-patterns.md)`,
+    tags: ['quality', 'frontend', 'patterns', 'tanstack-query', 'consistency'],
+    fileTypes: ['ts', 'tsx'],
+    analyze(content, filePath) {
+        // Only check screen files
+        if (!filePath.includes('/screens/') ||
+            (!filePath.endsWith('.ts') && !filePath.endsWith('.tsx'))) {
+            return [];
+        }
+        // Skip excluded paths
+        if (NON_SCREEN_PATTERNS.some((pattern) => pattern.test(filePath))) {
+            return [];
+        }
+        const violations = [];
+        // Check if file uses TanStack Query (useQuery, useMutation)
+        const usesQuery = /use(Query|Mutation|InfiniteQuery)\s*\(/.test(content);
+        if (!usesQuery) {
+            return violations; // Not a data-driven screen
+        }
+        // Check if file imports or uses AsyncState pattern
+        const hasAsyncState = /AsyncState|<AsyncState/.test(content);
+        if (!hasAsyncState) {
+            // Find the useQuery line for better context
+            const queryMatch = /use(Query|Mutation|InfiniteQuery)\s*\(/.exec(content);
+            const queryLine = queryMatch ? content.slice(0, queryMatch.index).split('\n').length : 1;
+            extractSnippet(content, queryLine, 3);
+            const matchText = queryMatch?.[0] ?? 'useQuery';
+            violations.push({
+                line: queryLine,
+                column: 0,
+                message: 'Data-driven screen uses TanStack Query but not AsyncState pattern',
+                severity: 'warning',
+                suggestion: "Import AsyncState from 'components/patterns/' and wrap data display: <AsyncState isLoading={isLoading} error={error} data={data}>{...}</AsyncState>",
+                type: 'missing-async-state',
+                match: matchText,
+            });
+        }
+        return violations;
+    },
+});
+//# sourceMappingURL=async-state-pattern.js.map

package/dist/checks/quality/patterns/async-state-pattern.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"async-state-pattern.js","sourceRoot":"","sources":["../../../../src/checks/quality/patterns/async-state-pattern.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AACH,sGAAsG;AACtG,6CAA6C;AAE7C,OAAO,EAAE,WAAW,EAAuB,cAAc,EAAE,MAAM,sBAAsB,CAAC;AAExF;;GAEG;AACH,MAAM,mBAAmB,GAAG;IAC1B,cAAc;IACd,WAAW;IACX,UAAU;IACV,UAAU;IACV,wBAAwB,EAAE,oCAAoC;CAC/D,CAAC;AAEF;;;;;GAKG;AACH,MAAM,CAAC,MAAM,iBAAiB,GAAG,WAAW,CAAC;IAC3C,EAAE,EAAE,sCAAsC;IAC1C,IAAI,EAAE,qBAAqB;IAC3B,QAAQ,EAAE,IAAI;IACd,KAAK,EAAE,EAAE,SAAS,EAAE,CAAC,YAAY,CAAC,EAAE,QAAQ,EAAE,CAAC,SAAS,EAAE,QAAQ,CAAC,EAAE;IACrE,aAAa,EAAE,eAAe;IAE9B,UAAU,EAAE,QAAQ;IACpB,WAAW,EAAE,mDAAmD;IAChE,eAAe,EAAE;;;;;;qFAMkE;IACnF,IAAI,EAAE,CAAC,SAAS,EAAE,UAAU,EAAE,UAAU,EAAE,gBAAgB,EAAE,aAAa,CAAC;IAC1E,SAAS,EAAE,CAAC,IAAI,EAAE,KAAK,CAAC;IAExB,OAAO,CAAC,OAAO,EAAE,QAAQ;QACvB,0BAA0B;QAC1B,IACE,CAAC,QAAQ,CAAC,QAAQ,CAAC,WAAW,CAAC;YAC/B,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,KAAK,CAAC,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,EACzD,CAAC;YACD,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,sBAAsB;QACtB,IAAI,mBAAmB,CAAC,IAAI,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,EAAE,CAAC;YAClE,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,MAAM,UAAU,GAAqB,EAAE,CAAC;QAExC,4DAA4D;QAC5D,MAAM,SAAS,GAAG,wCAAwC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QACzE,IAAI,CAAC,SAAS,EAAE,CAAC;YACf,OAAO,UAAU,CAAC,CAAC,2BAA2B;QAChD,CAAC;QAED,mDAAmD;QACnD,MAAM,aAAa,GAAG,wBAAwB,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QAC7D,IAAI,CAAC,aAAa,EAAE,CAAC;YACnB,4CAA4C;YAC5C,MAAM,UAAU,GAAG,wCAAwC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;YAC1E,MAAM,SAAS,GAAG,UAAU,CAAC,CAAC,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,UAAU,CAAC,KAAK,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC;YACzF,cAAc,CAAC,OAAO,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;YACtC,MAAM,SAAS,GAAG,UAAU,EAAE,CAAC,CAAC,CAAC,IAAI,UAAU,CAAC;YAEhD,UAAU,CAAC,IAAI,CAAC;gBACd,IAAI,EAAE,SAAS;gBACf,MAAM,EAAE,CAAC;gBACT,OAAO,EAAE,mEAAmE;gBAC5E,QAAQ,EAAE,SAAS;gBACnB,UAAU,EACR,qJAAqJ;gBACvJ,IAAI,EAAE,qBAAqB;gBAC3B,KAAK,EAAE,SAAS;aACjB,CAAC,CAAC;QACL,CAAC;QAED,OAAO,UAAU,CAAC;IACpB,CAAC;CACF,CAAC,CAAC"}

package/dist/checks/quality/patterns/index.d.ts

@@ -0,0 +1,4 @@
+export * from './async-state-pattern.js';
+export * from './no-non-null-assertions.js';
+export * from './performance-anti-patterns.js';
+//# sourceMappingURL=index.d.ts.map

package/dist/checks/quality/patterns/index.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../../src/checks/quality/patterns/index.ts"],"names":[],"mappings":"AAAA,cAAc,0BAA0B,CAAC;AACzC,cAAc,6BAA6B,CAAC;AAC5C,cAAc,gCAAgC,CAAC"}

package/dist/checks/quality/patterns/index.js

@@ -0,0 +1,4 @@
+export * from './async-state-pattern.js';
+export * from './no-non-null-assertions.js';
+export * from './performance-anti-patterns.js';
+//# sourceMappingURL=index.js.map

package/dist/checks/quality/patterns/index.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../../src/checks/quality/patterns/index.ts"],"names":[],"mappings":"AAAA,cAAc,0BAA0B,CAAC;AACzC,cAAc,6BAA6B,CAAC;AAC5C,cAAc,gCAAgC,CAAC"}

package/dist/checks/quality/patterns/no-non-null-assertions.d.ts

@@ -0,0 +1,10 @@
+/**
+ * @fileoverview No non-null assertions check
+ */
+/**
+ * Check: quality/no-non-null-assertions
+ *
+ * Detects TypeScript non-null assertion operator (!) usage in production code.
+ */
+export declare const noNonNullAssertions: import("@opensip-cli/fitness").Check;
+//# sourceMappingURL=no-non-null-assertions.d.ts.map

package/dist/checks/quality/patterns/no-non-null-assertions.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"no-non-null-assertions.d.ts","sourceRoot":"","sources":["../../../../src/checks/quality/patterns/no-non-null-assertions.ts"],"names":[],"mappings":"AAAA;;GAEG;AA0EH;;;;GAIG;AACH,eAAO,MAAM,mBAAmB,sCA0B9B,CAAC"}

package/dist/checks/quality/patterns/no-non-null-assertions.js

@@ -0,0 +1,97 @@
+/**
+ * @fileoverview No non-null assertions check
+ */
+import { defineCheck, isTestFile } from '@opensip-cli/fitness';
+/**
+ * Regex to detect non-null assertion operator usage.
+ * Matches patterns like: expr!. or expr![ or expr!) where expr is an identifier.
+ * Avoids matching !== and != comparisons.
+ */
+// eslint-disable-next-line sonarjs/slow-regex -- character class has no overlap; '!' acts as fixed delimiter
+const NON_NULL_ASSERTION_REGEX = /([\w.[\]]+)!\s*[.[;,)]/g;
+/**
+ * Analyze a file for non-null assertion operator usage
+ */
+// eslint-disable-next-line sonarjs/cognitive-complexity -- Inherent complexity: template literal tracking + regex matching + multiple skip conditions
+function analyzeNonNullAssertions(content, _filePath) {
+    const violations = [];
+    const lines = content.split('\n');
+    // Track template literal nesting to skip lines inside multi-line template literals
+    let inTemplateLiteral = false;
+    for (const [i, line_] of lines.entries()) {
+        const line = line_ ?? '';
+        const trimmed = line.trim();
+        // Track template literal boundaries (count unescaped backticks)
+        let backtickCount = 0;
+        for (let c = 0; c < line.length; c++) {
+            if (line[c] === '`' && (c === 0 || line[c - 1] !== '\\'))
+                backtickCount++;
+        }
+        if (backtickCount % 2 === 1)
+            inTemplateLiteral = !inTemplateLiteral;
+        // Skip lines inside multi-line template literals (e.g., longDescription text)
+        if (inTemplateLiteral && backtickCount % 2 === 0)
+            continue;
+        // Skip comments, imports, and type declarations
+        if (trimmed.startsWith('//') || trimmed.startsWith('*') || trimmed.startsWith('import '))
+            continue;
+        if (trimmed.startsWith('type ') ||
+            trimmed.startsWith('interface ') ||
+            trimmed.startsWith('export type ') ||
+            trimmed.startsWith('export interface '))
+            continue;
+        // Skip lines that are string literals (rough heuristic)
+        if (trimmed.startsWith("'") || trimmed.startsWith('"') || trimmed.startsWith('`'))
+            continue;
+        NON_NULL_ASSERTION_REGEX.lastIndex = 0;
+        let match;
+        while ((match = NON_NULL_ASSERTION_REGEX.exec(line)) !== null) {
+            // Make sure this isn't part of !== or !=
+            const bangPos = match.index + (match[1]?.length ?? 0);
+            const nextChar = line[bangPos + 1];
+            if (nextChar === '=')
+                continue;
+            violations.push({
+                line: i + 1,
+                message: `Non-null assertion operator (\`!\`) used on '${match[1]}' — this bypasses TypeScript null checking`,
+                severity: 'warning',
+                suggestion: 'Use optional chaining (?.), nullish coalescing (??), or a proper null guard instead of the ! operator',
+                type: 'non-null-assertion',
+                match: trimmed.slice(0, 120),
+            });
+        }
+    }
+    return violations;
+}
+/**
+ * Check: quality/no-non-null-assertions
+ *
+ * Detects TypeScript non-null assertion operator (!) usage in production code.
+ */
+export const noNonNullAssertions = defineCheck({
+    id: 'd1e51952-5758-40f3-999b-b83f57db9a42',
+    slug: 'no-non-null-assertions',
+    scope: { languages: ['typescript'], concerns: ['backend', 'server'] },
+    contentFilter: 'strip-strings',
+    confidence: 'medium',
+    description: 'Detects TypeScript non-null assertion operator (!) usage in production code — prefer proper null handling',
+    longDescription: `**Purpose:** Detects uses of the TypeScript non-null assertion operator (\`!\`) which bypasses null checking and can mask real null/undefined bugs at runtime.
+
+**Detects:**
+- \`expr!.property\` — non-null assertion before property access
+- \`expr![index]\` — non-null assertion before index access
+- Excludes \`!==\` and \`!=\` comparisons (not assertions)
+
+**Why it matters:** Non-null assertions are type-safety escape hatches. They tell TypeScript "trust me, this is not null" without any runtime check. When wrong, they cause runtime errors.
+
+**Scope:** Production code. Analyzes each file individually via regex.`,
+    tags: ['type-safety', 'quality', 'typescript'],
+    fileTypes: ['ts', 'tsx'],
+    analyze(content, filePath) {
+        // Skip test files — non-null assertions in tests are low-risk due to controlled inputs
+        if (isTestFile(filePath))
+            return [];
+        return analyzeNonNullAssertions(content, filePath);
+    },
+});
+//# sourceMappingURL=no-non-null-assertions.js.map

package/dist/checks/quality/patterns/no-non-null-assertions.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"no-non-null-assertions.js","sourceRoot":"","sources":["../../../../src/checks/quality/patterns/no-non-null-assertions.ts"],"names":[],"mappings":"AAAA;;GAEG;AAEH,OAAO,EAAE,WAAW,EAAE,UAAU,EAAuB,MAAM,sBAAsB,CAAC;AAEpF;;;;GAIG;AACH,6GAA6G;AAC7G,MAAM,wBAAwB,GAAG,yBAAyB,CAAC;AAE3D;;GAEG;AACH,sJAAsJ;AACtJ,SAAS,wBAAwB,CAAC,OAAe,EAAE,SAAiB;IAClE,MAAM,UAAU,GAAqB,EAAE,CAAC;IACxC,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAElC,mFAAmF;IACnF,IAAI,iBAAiB,GAAG,KAAK,CAAC;IAE9B,KAAK,MAAM,CAAC,CAAC,EAAE,KAAK,CAAC,IAAI,KAAK,CAAC,OAAO,EAAE,EAAE,CAAC;QACzC,MAAM,IAAI,GAAG,KAAK,IAAI,EAAE,CAAC;QACzB,MAAM,OAAO,GAAG,IAAI,CAAC,IAAI,EAAE,CAAC;QAE5B,gEAAgE;QAChE,IAAI,aAAa,GAAG,CAAC,CAAC;QACtB,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,IAAI,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;YACrC,IAAI,IAAI,CAAC,CAAC,CAAC,KAAK,GAAG,IAAI,CAAC,CAAC,KAAK,CAAC,IAAI,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC,KAAK,IAAI,CAAC;gBAAE,aAAa,EAAE,CAAC;QAC5E,CAAC;QACD,IAAI,aAAa,GAAG,CAAC,KAAK,CAAC;YAAE,iBAAiB,GAAG,CAAC,iBAAiB,CAAC;QAEpE,8EAA8E;QAC9E,IAAI,iBAAiB,IAAI,aAAa,GAAG,CAAC,KAAK,CAAC;YAAE,SAAS;QAE3D,gDAAgD;QAChD,IAAI,OAAO,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,OAAO,CAAC,UAAU,CAAC,SAAS,CAAC;YACtF,SAAS;QACX,IACE,OAAO,CAAC,UAAU,CAAC,OAAO,CAAC;YAC3B,OAAO,CAAC,UAAU,CAAC,YAAY,CAAC;YAChC,OAAO,CAAC,UAAU,CAAC,cAAc,CAAC;YAClC,OAAO,CAAC,UAAU,CAAC,mBAAmB,CAAC;YAEvC,SAAS;QAEX,wDAAwD;QACxD,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC;YAAE,SAAS;QAE5F,wBAAwB,CAAC,SAAS,GAAG,CAAC,CAAC;QACvC,IAAI,KAAK,CAAC;QACV,OAAO,CAAC,KAAK,GAAG,wBAAwB,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;YAC9D,yCAAyC;YACzC,MAAM,OAAO,GAAG,KAAK,CAAC,KAAK,GAAG,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,MAAM,IAAI,CAAC,CAAC,CAAC;YACtD,MAAM,QAAQ,GAAG,IAAI,CAAC,OAAO,GAAG,CAAC,CAAC,CAAC;YACnC,IAAI,QAAQ,KAAK,GAAG;gBAAE,SAAS;YAE/B,UAAU,CAAC,IAAI,CAAC;gBACd,IAAI,EAAE,CAAC,GAAG,CAAC;gBACX,OAAO,EAAE,gDAAgD,KAAK,CAAC,CAAC,CAAC,4CAA4C;gBAC7G,QAAQ,EAAE,SAAS;gBACnB,UAAU,EACR,uGAAuG;gBACzG,IAAI,EAAE,oBAAoB;gBAC1B,KAAK,EAAE,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC;aAC7B,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED;;;;GAIG;AACH,MAAM,CAAC,MAAM,mBAAmB,GAAG,WAAW,CAAC;IAC7C,EAAE,EAAE,sCAAsC;IAC1C,IAAI,EAAE,wBAAwB;IAC9B,KAAK,EAAE,EAAE,SAAS,EAAE,CAAC,YAAY,CAAC,EAAE,QAAQ,EAAE,CAAC,SAAS,EAAE,QAAQ,CAAC,EAAE;IACrE,aAAa,EAAE,eAAe;IAE9B,UAAU,EAAE,QAAQ;IACpB,WAAW,EACT,2GAA2G;IAC7G,eAAe,EAAE;;;;;;;;;uEASoD;IACrE,IAAI,EAAE,CAAC,aAAa,EAAE,SAAS,EAAE,YAAY,CAAC;IAC9C,SAAS,EAAE,CAAC,IAAI,EAAE,KAAK,CAAC;IACxB,OAAO,CAAC,OAAe,EAAE,QAAgB;QACvC,uFAAuF;QACvF,IAAI,UAAU,CAAC,QAAQ,CAAC;YAAE,OAAO,EAAE,CAAC;QACpC,OAAO,wBAAwB,CAAC,OAAO,EAAE,QAAQ,CAAC,CAAC;IACrD,CAAC;CACF,CAAC,CAAC"}

package/dist/checks/quality/patterns/performance-anti-patterns.d.ts

@@ -0,0 +1,16 @@
+/**
+ * @fileoverview Performance Anti-Patterns Check
+ *
+ * Detects common performance anti-patterns:
+ * - Sequential awaits in loops
+ * - Spread operators in loops
+ * - String concatenation in loops
+ * - Nested O(n^2) loops
+ */
+/**
+ * Check: quality/performance-anti-patterns
+ *
+ * Detects common performance anti-patterns in code.
+ */
+export declare const performanceAntiPatterns: import("@opensip-cli/fitness").Check;
+//# sourceMappingURL=performance-anti-patterns.d.ts.map

package/dist/checks/quality/patterns/performance-anti-patterns.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"performance-anti-patterns.d.ts","sourceRoot":"","sources":["../../../../src/checks/quality/patterns/performance-anti-patterns.ts"],"names":[],"mappings":"AAEA;;;;;;;;GAQG;AA4NH;;;;GAIG;AACH,eAAO,MAAM,uBAAuB,sCAuDlC,CAAC"}