@opensip-cli/checks-typescript 0.1.0

package/dist/checks/quality/patterns/dispose-pattern-completeness.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"dispose-pattern-completeness.js","sourceRoot":"","sources":["../../../../src/checks/quality/patterns/dispose-pattern-completeness.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAEH,OAAO,EAAE,WAAW,EAAuB,MAAM,sBAAsB,CAAC;AACxE,OAAO,EAAE,mBAAmB,EAAE,MAAM,8BAA8B,CAAC;AACnE,OAAO,KAAK,EAAE,MAAM,YAAY,CAAC;AAWjC;;;;GAIG;AACH,SAAS,yBAAyB,CAAC,IAAyB;IAC1D,IAAI,CAAC,IAAI,CAAC,eAAe,EAAE,CAAC;QAC1B,OAAO,KAAK,CAAC;IACf,CAAC;IAED,OAAO,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,EAAE;QAC1C,8HAA8H;QAC9H,IAAI,MAAM,CAAC,KAAK,KAAK,EAAE,CAAC,UAAU,CAAC,iBAAiB,EAAE,CAAC;YACrD,OAAO,KAAK,CAAC;QACf,CAAC;QACD,OAAO,MAAM,CAAC,KAAK,CAAC,IAAI,CACtB,CAAC,IAAI,EAAE,EAAE,CACP,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC;YAChC,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,aAAa,IAAI,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,YAAY,CAAC,CACpF,CAAC;IACJ,CAAC,CAAC,CAAC;AACL,CAAC;AAED;;;;GAIG;AACH,SAAS,iBAAiB,CAAC,IAAyB;IAClD,MAAM,MAAM,GAAG,IAAI,CAAC,OAAO,CAAC,IAAI,CAC9B,CAAC,CAAC,EAAE,EAAE,CAAC,EAAE,CAAC,mBAAmB,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,IAAI,KAAK,SAAS,CACzF,CAAC;IACF,OAAO,MAA0C,CAAC;AACpD,CAAC;AAED;;;;;;GAMG;AACH,SAAS,6BAA6B,CACpC,GAAqB,EACrB,IAAyB,EACzB,SAAiB;IAEjB,MAAM,EAAE,IAAI,EAAE,OAAO,EAAE,SAAS,EAAE,GAAG,GAAG,CAAC,UAAU,CAAC,6BAA6B,CAC/E,IAAI,CAAC,QAAQ,EAAE,CAChB,CAAC;IACF,MAAM,IAAI,GAAG,OAAO,GAAG,CAAC,CAAC;IAEzB,OAAO;QACL,IAAI;QACJ,MAAM,EAAE,SAAS,GAAG,CAAC;QACrB,OAAO,EAAE,UAAU,SAAS,oDAAoD;QAChF,QAAQ,EAAE,OAAO;QACjB,UAAU,EAAE,wFAAwF,SAAS,EAAE;QAC/G,IAAI,EAAE,iBAAiB;QACvB,KAAK,EAAE,SAAS;KACjB,CAAC;AACJ,CAAC;AAED;;;;;;GAMG;AACH,SAAS,2BAA2B,CAClC,GAAqB,EACrB,aAAmC,EACnC,SAAiB;IAEjB,MAAM,EAAE,IAAI,EAAE,OAAO,EAAE,SAAS,EAAE,GAAG,GAAG,CAAC,UAAU,CAAC,6BAA6B,CAC/E,aAAa,CAAC,QAAQ,EAAE,CACzB,CAAC;IACF,MAAM,IAAI,GAAG,OAAO,GAAG,CAAC,CAAC;IAEzB,OAAO;QACL,IAAI;QACJ,MAAM,EAAE,SAAS,GAAG,CAAC;QACrB,OAAO,EAAE,UAAU,SAAS,4BAA4B;QACxD,QAAQ,EAAE,SAAS;QACnB,UAAU,EAAE,iGAAiG;QAC7G,IAAI,EAAE,eAAe;QACrB,KAAK,EAAE,GAAG,SAAS,UAAU;KAC9B,CAAC;AACJ,CAAC;AAED;;;;GAIG;AACH,SAAS,oBAAoB,CAAC,aAAmC;IAC/D,MAAM,UAAU,GAAG,aAAa,CAAC,IAAI,CAAC;IACtC,OAAO,OAAO,CAAC,UAAU,IAAI,EAAE,CAAC,OAAO,CAAC,UAAU,CAAC,IAAI,UAAU,CAAC,UAAU,CAAC,MAAM,KAAK,CAAC,CAAC,CAAC;AAC7F,CAAC;AAED;;;;GAIG;AACH,SAAS,mBAAmB,CAAC,MAAuB;IAClD,IAAI,CAAC,EAAE,CAAC,qBAAqB,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC;QACvE,OAAO,KAAK,CAAC;IACf,CAAC;IACD,MAAM,SAAS,GAAG,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,CAAC;IACjD,OAAO,SAAS,CAAC,QAAQ,CAAC,cAAc,CAAC,IAAI,SAAS,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAC;AAC9E,CAAC;AAED;;;;;;GAMG;AACH,SAAS,oCAAoC,CAC3C,GAAqB,EACrB,KAA6B,EAC7B,SAAiB;IAEjB,MAAM,EAAE,IAAI,EAAE,OAAO,EAAE,SAAS,EAAE,GAAG,GAAG,CAAC,UAAU,CAAC,6BAA6B,CAC/E,KAAK,CAAC,QAAQ,EAAE,CACjB,CAAC;IACF,MAAM,IAAI,GAAG,OAAO,GAAG,CAAC,CAAC;IAEzB,OAAO;QACL,IAAI;QACJ,MAAM,EAAE,SAAS,GAAG,CAAC;QACrB,OAAO,EAAE,iBAAiB,SAAS,+BAA+B;QAClE,QAAQ,EAAE,SAAS;QACnB,UAAU,EAAE,aAAa,SAAS,8BAA8B,SAAS,mCAAmC;QAC5G,IAAI,EAAE,wBAAwB;QAC9B,KAAK,EAAE,SAAS;KACjB,CAAC;AACJ,CAAC;AAED;;;;;;GAMG;AACH,SAAS,uBAAuB,CAC9B,GAAqB,EACrB,IAAyB,EACzB,aAAmC;IAEnC,MAAM,UAAU,GAAqB,EAAE,CAAC;IACxC,kDAAkD;IAClD,MAAM,WAAW,GAAG,aAAa,CAAC,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,UAAU,CAAC,IAAI,EAAE,CAAC;IAEtE,KAAK,MAAM,MAAM,IAAI,IAAI,CAAC,OAAO,EAAE,CAAC;QAClC,IAAI,CAAC,mBAAmB,CAAC,MAAM,CAAC,EAAE,CAAC;YACjC,SAAS;QACX,CAAC;QAED,MAAM,SAAS,GAAI,MAAM,CAAC,IAAsB,CAAC,IAAI,CAAC;QACtD,IAAI,CAAC,WAAW,CAAC,QAAQ,CAAC,SAAS,CAAC,EAAE,CAAC;YACrC,UAAU,CAAC,IAAI,CAAC,oCAAoC,CAAC,GAAG,EAAE,MAAM,EAAE,SAAS,CAAC,CAAC,CAAC;QAChF,CAAC;IACH,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED;;;;;GAKG;AACH,SAAS,uBAAuB,CAC9B,GAAqB,EACrB,IAAyB;IAEzB,MAAM,UAAU,GAAqB,EAAE,CAAC;IAExC,IAAI,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,yBAAyB,CAAC,IAAI,CAAC,EAAE,CAAC;QACnD,OAAO,UAAU,CAAC;IACpB,CAAC;IAED,MAAM,SAAS,GAAG,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC;IACjC,MAAM,aAAa,GAAG,iBAAiB,CAAC,IAAI,CAAC,CAAC;IAE9C,IAAI,CAAC,aAAa,EAAE,CAAC;QACnB,UAAU,CAAC,IAAI,CAAC,6BAA6B,CAAC,GAAG,EAAE,IAAI,EAAE,SAAS,CAAC,CAAC,CAAC;QACrE,OAAO,UAAU,CAAC;IACpB,CAAC;IAED,IAAI,oBAAoB,CAAC,aAAa,CAAC,EAAE,CAAC;QACxC,UAAU,CAAC,IAAI,CAAC,2BAA2B,CAAC,GAAG,EAAE,aAAa,EAAE,SAAS,CAAC,CAAC,CAAC;IAC9E,CAAC;IAED,UAAU,CAAC,IAAI,CAAC,GAAG,uBAAuB,CAAC,GAAG,EAAE,IAAI,EAAE,aAAa,CAAC,CAAC,CAAC;IAEtE,OAAO,UAAU,CAAC;AACpB,CAAC;AAED;;;;;GAKG;AACH,SAAS,WAAW,CAAC,YAAoB,EAAE,OAAe;IACxD,MAAM,UAAU,GAAqB,EAAE,CAAC;IAExC,MAAM,UAAU,GAAG,mBAAmB,CAAC,YAAY,EAAE,OAAO,CAAC,CAAC;IAC9D,uCAAuC;IACvC,IAAI,CAAC,UAAU;QAAE,OAAO,EAAE,CAAC;IAE3B,MAAM,GAAG,GAAqB,EAAE,YAAY,EAAE,OAAO,EAAE,UAAU,EAAE,CAAC;IAEpE,MAAM,KAAK,GAAG,CAAC,IAAa,EAAE,EAAE;QAC9B,IAAI,EAAE,CAAC,kBAAkB,CAAC,IAAI,CAAC,EAAE,CAAC;YAChC,UAAU,CAAC,IAAI,CAAC,GAAG,uBAAuB,CAAC,GAAG,EAAE,IAAI,CAAC,CAAC,CAAC;QACzD,CAAC;QACD,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;IAC/B,CAAC,CAAC;IAEF,KAAK,CAAC,UAAU,CAAC,CAAC;IAClB,OAAO,UAAU,CAAC;AACpB,CAAC;AAED;;;;GAIG;AACH,MAAM,CAAC,MAAM,0BAA0B,GAAG,WAAW,CAAC;IACpD,EAAE,EAAE,sCAAsC;IAC1C,IAAI,EAAE,8BAA8B;IACpC,KAAK,EAAE,EAAE,SAAS,EAAE,CAAC,YAAY,CAAC,EAAE,QAAQ,EAAE,CAAC,SAAS,EAAE,QAAQ,CAAC,EAAE;IAErE,UAAU,EAAE,MAAM;IAClB,WAAW,EAAE,6DAA6D;IAC1E,eAAe,EAAE;;;;;;;;;iCASc;IAC/B,IAAI,EAAE,CAAC,SAAS,EAAE,WAAW,EAAE,QAAQ,EAAE,SAAS,EAAE,SAAS,CAAC;IAC9D,SAAS,EAAE,CAAC,IAAI,CAAC;IAEjB,OAAO,CAAC,OAAO,EAAE,QAAQ;QACvB,4DAA4D;QAC5D,MAAM,kBAAkB,GACtB,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAC;YAC3B,OAAO,CAAC,QAAQ,CAAC,YAAY,CAAC;YAC9B,OAAO,CAAC,QAAQ,CAAC,cAAc,CAAC;YAChC,OAAO,CAAC,QAAQ,CAAC,aAAa,CAAC,CAAC;QAClC,IAAI,CAAC,kBAAkB,EAAE,CAAC;YACxB,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,OAAO,WAAW,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;IACxC,CAAC;CACF,CAAC,CAAC"}

package/dist/checks/quality/patterns/error-handling-quality.d.ts

@@ -0,0 +1,17 @@
+/**
+ * @fileoverview Unified Error Handling Quality Check
+ *
+ * Detects silent error handling in both try/catch and Result patterns.
+ * Replaces: resilience/no-empty-catch, quality/error-swallowing-boolean
+ */
+/**
+ * Check: quality/error-handling-quality
+ *
+ * Detects silent error handling in both try/catch and Result patterns.
+ * This is a unified check that replaces:
+ * - resilience/no-empty-catch
+ * - quality/error-swallowing-boolean
+ *
+ */
+export declare const errorHandlingQuality: import("@opensip-cli/fitness").Check;
+//# sourceMappingURL=error-handling-quality.d.ts.map

package/dist/checks/quality/patterns/error-handling-quality.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"error-handling-quality.d.ts","sourceRoot":"","sources":["../../../../src/checks/quality/patterns/error-handling-quality.ts"],"names":[],"mappings":"AAGA;;;;;GAKG;AAkSH;;;;;;;;GAQG;AACH,eAAO,MAAM,oBAAoB,sCAwD/B,CAAC"}

package/dist/checks/quality/patterns/error-handling-quality.js

@@ -0,0 +1,335 @@
+// @fitness-ignore-file canonical-result-usage -- References Result pattern in comments/JSDoc for pattern detection documentation, not actual Result usage
+// @fitness-ignore-file logging-standards -- String literals in suggestion text reference logger calls, not actual logger usage
+// @fitness-ignore-file error-handling-quality -- Fitness check implementation: catch blocks in AST analysis intentionally return empty results to skip unreadable files
+/**
+ * @fileoverview Unified Error Handling Quality Check
+ *
+ * Detects silent error handling in both try/catch and Result patterns.
+ * Replaces: resilience/no-empty-catch, quality/error-swallowing-boolean
+ */
+import { defineCheck, isTestFile } from '@opensip-cli/fitness';
+import { getSharedSourceFile } from '@opensip-cli/lang-typescript';
+import * as ts from 'typescript';
+// =============================================================================
+// WHITELIST PATTERNS
+// =============================================================================
+/**
+ * Patterns that indicate proper error handling (logging)
+ */
+const LOGGING_PATTERNS = [
+    /logger\.(error|warn|debug|info)\s*\(/,
+    /safeLogger\.(error|warn|debug|info)\s*\(/,
+    /console\.(error|warn)\s*\(/,
+    /\.log\s*\(/,
+    /unwrapOrLog\s*\(/,
+    /matchLog\s*\(/,
+    /handleErr\s*\(/,
+];
+/**
+ * Patterns that indicate intentional silent handling
+ */
+const MARKER_PATTERNS = [
+    /@swallow-ok/,
+    /@handles/,
+    /\/\/\s*intentionally/i,
+    /\/\/\s*expected/i,
+    /graceful/i,
+];
+/**
+ * Patterns that indicate error propagation
+ */
+const PROPAGATION_PATTERNS = [
+    /\berr\s*\(/,
+    /Result\.err\s*\(/,
+    /new\s+Failure\s*\(/,
+    /return\s+\S[^\n]*\.error\b/,
+];
+/**
+ * Pattern for rethrow
+ */
+const RETHROW_PATTERN = /\bthrow\b/;
+/**
+ * Sentinel return values that indicate silent error handling
+ */
+const SENTINEL_VALUES = new Set(['false', 'null', 'undefined', '[]', '{}']);
+// =============================================================================
+// HELPER FUNCTIONS
+// =============================================================================
+/**
+ * Check if text contains acceptable error handling
+ * @param text - Text to check
+ * @returns True if acceptable pattern found
+ */
+function hasAcceptablePattern(text) {
+    if (LOGGING_PATTERNS.some((p) => p.test(text)))
+        return true;
+    if (MARKER_PATTERNS.some((p) => p.test(text)))
+        return true;
+    /* v8 ignore next -- defensive AST/type guard */
+    if (PROPAGATION_PATTERNS.some((p) => p.test(text)))
+        return true;
+    if (RETHROW_PATTERN.test(text))
+        return true;
+    return false;
+}
+/**
+ * Get return value type from expression
+ * @param expr - TypeScript expression
+ * @param sourceFile - Source file for getting text
+ * @returns String representation or null if not a sentinel
+ */
+function getReturnValue(expr, sourceFile) {
+    /* v8 ignore next -- defensive AST/type guard */
+    if (!expr)
+        return 'undefined';
+    if (expr.kind === ts.SyntaxKind.FalseKeyword)
+        return 'false';
+    if (expr.kind === ts.SyntaxKind.NullKeyword)
+        return 'null';
+    if (ts.isIdentifier(expr) && expr.getText(sourceFile) === 'undefined')
+        return 'undefined';
+    if (ts.isArrayLiteralExpression(expr) && expr.elements.length === 0)
+        return '[]';
+    if (ts.isObjectLiteralExpression(expr) && expr.properties.length === 0)
+        return '{}';
+    return null;
+}
+// =============================================================================
+// CHECK FUNCTIONS
+// =============================================================================
+/**
+ * Check a catch clause for violations
+ */
+function checkCatchClause(node, sourceFile) {
+    const violations = [];
+    const catchText = node.block.getText(sourceFile);
+    // Skip if has acceptable pattern
+    if (hasAcceptablePattern(catchText))
+        return violations;
+    const trimmed = catchText.replaceAll(/[{}]/g, '').trim();
+    // Strip leading single-line comments (`// ...` lines, including
+    // multi-line stacks) and block comments before testing for empty.
+    // The original regex `/^\/[/*]/` only checked the first character,
+    // which falsely flags `} catch { // comment\n actualHandler() }`
+    // patterns as empty even though real code follows the comment.
+    let codeOnly = trimmed;
+    while (true) {
+        if (codeOnly.startsWith('//')) {
+            const eol = codeOnly.indexOf('\n');
+            codeOnly = (eol === -1 ? '' : codeOnly.slice(eol + 1)).trim();
+            continue;
+        }
+        if (codeOnly.startsWith('/*')) {
+            const close = codeOnly.indexOf('*/');
+            codeOnly = (close === -1 ? '' : codeOnly.slice(close + 2)).trim();
+            continue;
+        }
+        break;
+    }
+    // Empty catch - SEVERITY: ERROR
+    if (trimmed === '' || codeOnly === '') {
+        const { line } = sourceFile.getLineAndCharacterOfPosition(node.getStart());
+        violations.push({
+            line: line + 1,
+            column: 0,
+            message: 'Empty catch block silently swallows errors',
+            severity: 'error',
+            suggestion: "Add logging: `logger.error({ evt: 'operation.failed', err })` or add `// @swallow-ok reason`",
+            match: 'catch',
+        });
+        return violations;
+    }
+    // Check for sentinel returns without logging
+    const visitReturn = (n) => {
+        if (ts.isReturnStatement(n)) {
+            const val = getReturnValue(n.expression, sourceFile);
+            if (val && SENTINEL_VALUES.has(val)) {
+                const { line } = sourceFile.getLineAndCharacterOfPosition(n.getStart());
+                violations.push({
+                    line: line + 1,
+                    column: 0,
+                    message: `Catch returns ${val} without logging`,
+                    severity: 'error',
+                    suggestion: `Add logging before return: \`logger.warn({ evt: 'operation.failed', err })\``,
+                    match: `return ${val}`,
+                });
+            }
+        }
+        ts.forEachChild(n, visitReturn);
+    };
+    visitReturn(node.block);
+    return violations;
+}
+/**
+ * Check Result.isErr() usage for violations
+ */
+function checkResultIsErr(node, sourceFile) {
+    const violations = [];
+    const cond = node.expression.getText(sourceFile);
+    // @fitness-ignore-next-line error-handling-quality -- String literal check for '.isErr()', not actual Result error handling
+    if (!cond.includes('.isErr()'))
+        return violations;
+    const thenText = node.thenStatement.getText(sourceFile);
+    /* v8 ignore next -- defensive AST/type guard */
+    if (hasAcceptablePattern(thenText))
+        return violations;
+    // Check for silent sentinel returns
+    const visitReturn = (n) => {
+        if (ts.isReturnStatement(n)) {
+            const val = getReturnValue(n.expression, sourceFile);
+            if (val && SENTINEL_VALUES.has(val)) {
+                const { line } = sourceFile.getLineAndCharacterOfPosition(node.getStart());
+                violations.push({
+                    line: line + 1,
+                    column: 0,
+                    message: `Result error silently discarded - returns ${val}`,
+                    severity: 'error',
+                    suggestion: `Use: \`result.unwrapOrLog(${val}, { evt: 'operation.failed' })\``,
+                    match: 'isErr()',
+                });
+            }
+        }
+    };
+    if (ts.isBlock(node.thenStatement)) {
+        node.thenStatement.statements.forEach(visitReturn);
+    }
+    else {
+        visitReturn(node.thenStatement);
+    }
+    return violations;
+}
+/**
+ * Check Result methods for violations
+ */
+function checkResultMethods(node, sourceFile) {
+    const violations = [];
+    if (!ts.isPropertyAccessExpression(node.expression))
+        return violations;
+    const method = node.expression.name.getText(sourceFile);
+    // mapErr without logging - SEVERITY: ERROR
+    if (method === 'mapErr' && node.arguments.length > 0) {
+        const firstArg = node.arguments[0];
+        /* v8 ignore next -- defensive AST/type guard */
+        if (!firstArg)
+            return violations;
+        const callback = firstArg.getText(sourceFile);
+        if (!hasAcceptablePattern(callback)) {
+            const { line } = sourceFile.getLineAndCharacterOfPosition(node.getStart());
+            violations.push({
+                line: line + 1,
+                column: 0,
+                message: 'mapErr() discards error without logging',
+                severity: 'error',
+                suggestion: 'Add logging: `mapErr(err => { logger.warn({ err }); return default; })`',
+                match: 'mapErr',
+            });
+        }
+    }
+    // match() error handler without logging - SEVERITY: ERROR
+    if (method === 'match' && node.arguments.length >= 2) {
+        const secondArg = node.arguments[1];
+        /* v8 ignore next -- defensive AST/type guard */
+        if (!secondArg)
+            return violations;
+        const errHandler = secondArg.getText(sourceFile);
+        if (!hasAcceptablePattern(errHandler)) {
+            const { line } = sourceFile.getLineAndCharacterOfPosition(node.getStart());
+            violations.push({
+                line: line + 1,
+                column: 0,
+                message: "match() error handler doesn't log",
+                severity: 'error',
+                suggestion: 'Use matchLog() instead, or add logging to error handler',
+                match: 'match',
+            });
+        }
+    }
+    return violations;
+}
+/**
+ * Check a catch clause for unsafe `as Error` casts
+ */
+function checkCatchClauseAsErrorCast(node, sourceFile) {
+    const violations = [];
+    const catchText = node.block.getText(sourceFile);
+    // Skip if the catch block contains an instanceof Error guard
+    if (catchText.includes('instanceof Error'))
+        return violations;
+    // Check for `as Error` casts
+    if (catchText.includes('as Error')) {
+        const { line } = sourceFile.getLineAndCharacterOfPosition(node.getStart());
+        const catchParam = node.variableDeclaration?.name.getText(sourceFile) ?? 'error';
+        violations.push({
+            line: line + 1,
+            column: 0,
+            message: 'Unsafe `as Error` cast in catch block without `instanceof Error` guard',
+            severity: 'warning',
+            suggestion: `Use \`if (${catchParam} instanceof Error)\` guard or normalize the error with a typed error utility`,
+            match: 'as Error',
+        });
+    }
+    return violations;
+}
+// =============================================================================
+// CHECK IMPLEMENTATION
+// =============================================================================
+/**
+ * Check: quality/error-handling-quality
+ *
+ * Detects silent error handling in both try/catch and Result patterns.
+ * This is a unified check that replaces:
+ * - resilience/no-empty-catch
+ * - quality/error-swallowing-boolean
+ *
+ */
+export const errorHandlingQuality = defineCheck({
+    id: '6bae5be9-87f4-499e-a886-ca78a233cfb7',
+    slug: 'error-handling-quality',
+    scope: { languages: ['typescript'], concerns: ['backend', 'server'] },
+    contentFilter: 'strip-strings',
+    confidence: 'high',
+    description: 'Detect silent error handling in try/catch and Result patterns',
+    longDescription: `**Purpose:** Detects silent error handling in both try/catch blocks and Result pattern usage, ensuring errors are always logged or propagated.
+
+**Detects:** Analyzes each file individually using TypeScript AST. Checks for:
+- Empty catch blocks (no logging, no rethrow, no \`@swallow-ok\` marker)
+- Catch blocks that return sentinel values (\`false\`, \`null\`, \`undefined\`, \`[]\`, \`{}\`) without logging
+- \`result.isErr()\` branches that silently return sentinel values
+- \`mapErr()\` callbacks without logging
+- \`match()\` error handlers without logging (suggests \`matchLog()\` instead)
+
+**Why it matters:** Silent error handling hides failures, making production debugging nearly impossible and allowing cascading failures to go undetected.
+
+**Scope:** General best practice`,
+    tags: ['quality', 'resilience', 'error-handling', 'observability', 'result-pattern'],
+    fileTypes: ['ts'],
+    analyze(content, filePath) {
+        // Skip test files — as Error casts, match()/mapErr() calls are exercising APIs, not production error handling
+        if (isTestFile(filePath))
+            return [];
+        // Quick filter: must have catch or Result patterns
+        if (!content.includes('catch') && !content.includes('isErr') && !content.includes('.match(')) {
+            return [];
+        }
+        const violations = [];
+        const sourceFile = getSharedSourceFile(filePath, content);
+        /* v8 ignore next -- defensive guard */
+        if (!sourceFile)
+            return [];
+        const visit = (node) => {
+            if (ts.isCatchClause(node)) {
+                violations.push(...checkCatchClause(node, sourceFile), ...checkCatchClauseAsErrorCast(node, sourceFile));
+            }
+            if (ts.isIfStatement(node)) {
+                violations.push(...checkResultIsErr(node, sourceFile));
+            }
+            if (ts.isCallExpression(node)) {
+                violations.push(...checkResultMethods(node, sourceFile));
+            }
+            ts.forEachChild(node, visit);
+        };
+        visit(sourceFile);
+        return violations;
+    },
+});
+//# sourceMappingURL=error-handling-quality.js.map

package/dist/checks/quality/patterns/error-handling-quality.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"error-handling-quality.js","sourceRoot":"","sources":["../../../../src/checks/quality/patterns/error-handling-quality.ts"],"names":[],"mappings":"AAAA,0JAA0J;AAC1J,+HAA+H;AAC/H,wKAAwK;AACxK;;;;;GAKG;AAEH,OAAO,EAAE,WAAW,EAAE,UAAU,EAAuB,MAAM,sBAAsB,CAAC;AACpF,OAAO,EAAE,mBAAmB,EAAE,MAAM,8BAA8B,CAAC;AACnE,OAAO,KAAK,EAAE,MAAM,YAAY,CAAC;AAEjC,gFAAgF;AAChF,qBAAqB;AACrB,gFAAgF;AAEhF;;GAEG;AACH,MAAM,gBAAgB,GAAG;IACvB,sCAAsC;IACtC,0CAA0C;IAC1C,4BAA4B;IAC5B,YAAY;IACZ,kBAAkB;IAClB,eAAe;IACf,gBAAgB;CACjB,CAAC;AAEF;;GAEG;AACH,MAAM,eAAe,GAAG;IACtB,aAAa;IACb,UAAU;IACV,uBAAuB;IACvB,kBAAkB;IAClB,WAAW;CACZ,CAAC;AAEF;;GAEG;AACH,MAAM,oBAAoB,GAAG;IAC3B,YAAY;IACZ,kBAAkB;IAClB,oBAAoB;IACpB,4BAA4B;CAC7B,CAAC;AAEF;;GAEG;AACH,MAAM,eAAe,GAAG,WAAW,CAAC;AAEpC;;GAEG;AACH,MAAM,eAAe,GAAG,IAAI,GAAG,CAAC,CAAC,OAAO,EAAE,MAAM,EAAE,WAAW,EAAE,IAAI,EAAE,IAAI,CAAC,CAAC,CAAC;AAE5E,gFAAgF;AAChF,mBAAmB;AACnB,gFAAgF;AAEhF;;;;GAIG;AACH,SAAS,oBAAoB,CAAC,IAAY;IACxC,IAAI,gBAAgB,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAAE,OAAO,IAAI,CAAC;IAC5D,IAAI,eAAe,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAAE,OAAO,IAAI,CAAC;IAC3D,gDAAgD;IAChD,IAAI,oBAAoB,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAAE,OAAO,IAAI,CAAC;IAChE,IAAI,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC;QAAE,OAAO,IAAI,CAAC;IAC5C,OAAO,KAAK,CAAC;AACf,CAAC;AAED;;;;;GAKG;AACH,SAAS,cAAc,CAAC,IAA+B,EAAE,UAAyB;IAChF,gDAAgD;IAChD,IAAI,CAAC,IAAI;QAAE,OAAO,WAAW,CAAC;IAC9B,IAAI,IAAI,CAAC,IAAI,KAAK,EAAE,CAAC,UAAU,CAAC,YAAY;QAAE,OAAO,OAAO,CAAC;IAC7D,IAAI,IAAI,CAAC,IAAI,KAAK,EAAE,CAAC,UAAU,CAAC,WAAW;QAAE,OAAO,MAAM,CAAC;IAC3D,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,KAAK,WAAW;QAAE,OAAO,WAAW,CAAC;IAC1F,IAAI,EAAE,CAAC,wBAAwB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,IAAI,CAAC;IACjF,IAAI,EAAE,CAAC,yBAAyB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,UAAU,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,IAAI,CAAC;IACpF,OAAO,IAAI,CAAC;AACd,CAAC;AAED,gFAAgF;AAChF,kBAAkB;AAClB,gFAAgF;AAEhF;;GAEG;AACH,SAAS,gBAAgB,CAAC,IAAoB,EAAE,UAAyB;IACvE,MAAM,UAAU,GAAqB,EAAE,CAAC;IACxC,MAAM,SAAS,GAAG,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;IAEjD,iCAAiC;IACjC,IAAI,oBAAoB,CAAC,SAAS,CAAC;QAAE,OAAO,UAAU,CAAC;IAEvD,MAAM,OAAO,GAAG,SAAS,CAAC,UAAU,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC;IAEzD,gEAAgE;IAChE,kEAAkE;IAClE,mEAAmE;IACnE,iEAAiE;IACjE,+DAA+D;IAC/D,IAAI,QAAQ,GAAG,OAAO,CAAC;IACvB,OAAO,IAAI,EAAE,CAAC;QACZ,IAAI,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,EAAE,CAAC;YAC9B,MAAM,GAAG,GAAG,QAAQ,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC;YACnC,QAAQ,GAAG,CAAC,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,GAAG,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;YAC9D,SAAS;QACX,CAAC;QACD,IAAI,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,EAAE,CAAC;YAC9B,MAAM,KAAK,GAAG,QAAQ,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC;YACrC,QAAQ,GAAG,CAAC,KAAK,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,KAAK,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;YAClE,SAAS;QACX,CAAC;QACD,MAAM;IACR,CAAC;IAED,gCAAgC;IAChC,IAAI,OAAO,KAAK,EAAE,IAAI,QAAQ,KAAK,EAAE,EAAE,CAAC;QACtC,MAAM,EAAE,IAAI,EAAE,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;QAC3E,UAAU,CAAC,IAAI,CAAC;YACd,IAAI,EAAE,IAAI,GAAG,CAAC;YACd,MAAM,EAAE,CAAC;YACT,OAAO,EAAE,4CAA4C;YACrD,QAAQ,EAAE,OAAO;YACjB,UAAU,EACR,8FAA8F;YAChG,KAAK,EAAE,OAAO;SACf,CAAC,CAAC;QACH,OAAO,UAAU,CAAC;IACpB,CAAC;IAED,6CAA6C;IAC7C,MAAM,WAAW,GAAG,CAAC,CAAU,EAAQ,EAAE;QACvC,IAAI,EAAE,CAAC,iBAAiB,CAAC,CAAC,CAAC,EAAE,CAAC;YAC5B,MAAM,GAAG,GAAG,cAAc,CAAC,CAAC,CAAC,UAAU,EAAE,UAAU,CAAC,CAAC;YACrD,IAAI,GAAG,IAAI,eAAe,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC;gBACpC,MAAM,EAAE,IAAI,EAAE,GAAG,UAAU,CAAC,6BAA6B,CAAC,CAAC,CAAC,QAAQ,EAAE,CAAC,CAAC;gBACxE,UAAU,CAAC,IAAI,CAAC;oBACd,IAAI,EAAE,IAAI,GAAG,CAAC;oBACd,MAAM,EAAE,CAAC;oBACT,OAAO,EAAE,iBAAiB,GAAG,kBAAkB;oBAC/C,QAAQ,EAAE,OAAO;oBAEjB,UAAU,EAAE,8EAA8E;oBAC1F,KAAK,EAAE,UAAU,GAAG,EAAE;iBACvB,CAAC,CAAC;YACL,CAAC;QACH,CAAC;QACD,EAAE,CAAC,YAAY,CAAC,CAAC,EAAE,WAAW,CAAC,CAAC;IAClC,CAAC,CAAC;IACF,WAAW,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAExB,OAAO,UAAU,CAAC;AACpB,CAAC;AAED;;GAEG;AACH,SAAS,gBAAgB,CAAC,IAAoB,EAAE,UAAyB;IACvE,MAAM,UAAU,GAAqB,EAAE,CAAC;IACxC,MAAM,IAAI,GAAG,IAAI,CAAC,UAAU,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;IACjD,4HAA4H;IAC5H,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,UAAU,CAAC;QAAE,OAAO,UAAU,CAAC;IAElD,MAAM,QAAQ,GAAG,IAAI,CAAC,aAAa,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;IACxD,gDAAgD;IAChD,IAAI,oBAAoB,CAAC,QAAQ,CAAC;QAAE,OAAO,UAAU,CAAC;IAEtD,oCAAoC;IACpC,MAAM,WAAW,GAAG,CAAC,CAAU,EAAQ,EAAE;QACvC,IAAI,EAAE,CAAC,iBAAiB,CAAC,CAAC,CAAC,EAAE,CAAC;YAC5B,MAAM,GAAG,GAAG,cAAc,CAAC,CAAC,CAAC,UAAU,EAAE,UAAU,CAAC,CAAC;YACrD,IAAI,GAAG,IAAI,eAAe,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC;gBACpC,MAAM,EAAE,IAAI,EAAE,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;gBAC3E,UAAU,CAAC,IAAI,CAAC;oBACd,IAAI,EAAE,IAAI,GAAG,CAAC;oBACd,MAAM,EAAE,CAAC;oBACT,OAAO,EAAE,6CAA6C,GAAG,EAAE;oBAC3D,QAAQ,EAAE,OAAO;oBACjB,UAAU,EAAE,6BAA6B,GAAG,kCAAkC;oBAC9E,KAAK,EAAE,SAAS;iBACjB,CAAC,CAAC;YACL,CAAC;QACH,CAAC;IACH,CAAC,CAAC;IAEF,IAAI,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,aAAa,CAAC,EAAE,CAAC;QACnC,IAAI,CAAC,aAAa,CAAC,UAAU,CAAC,OAAO,CAAC,WAAW,CAAC,CAAC;IACrD,CAAC;SAAM,CAAC;QACN,WAAW,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC;IAClC,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED;;GAEG;AACH,SAAS,kBAAkB,CAAC,IAAuB,EAAE,UAAyB;IAC5E,MAAM,UAAU,GAAqB,EAAE,CAAC;IAExC,IAAI,CAAC,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC,UAAU,CAAC;QAAE,OAAO,UAAU,CAAC;IAEvE,MAAM,MAAM,GAAG,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;IAExD,2CAA2C;IAC3C,IAAI,MAAM,KAAK,QAAQ,IAAI,IAAI,CAAC,SAAS,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACrD,MAAM,QAAQ,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;QACnC,gDAAgD;QAChD,IAAI,CAAC,QAAQ;YAAE,OAAO,UAAU,CAAC;QACjC,MAAM,QAAQ,GAAG,QAAQ,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;QAC9C,IAAI,CAAC,oBAAoB,CAAC,QAAQ,CAAC,EAAE,CAAC;YACpC,MAAM,EAAE,IAAI,EAAE,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;YAC3E,UAAU,CAAC,IAAI,CAAC;gBACd,IAAI,EAAE,IAAI,GAAG,CAAC;gBACd,MAAM,EAAE,CAAC;gBACT,OAAO,EAAE,yCAAyC;gBAClD,QAAQ,EAAE,OAAO;gBAEjB,UAAU,EAAE,yEAAyE;gBACrF,KAAK,EAAE,QAAQ;aAChB,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IAED,0DAA0D;IAC1D,IAAI,MAAM,KAAK,OAAO,IAAI,IAAI,CAAC,SAAS,CAAC,MAAM,IAAI,CAAC,EAAE,CAAC;QACrD,MAAM,SAAS,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;QACpC,gDAAgD;QAChD,IAAI,CAAC,SAAS;YAAE,OAAO,UAAU,CAAC;QAClC,MAAM,UAAU,GAAG,SAAS,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;QACjD,IAAI,CAAC,oBAAoB,CAAC,UAAU,CAAC,EAAE,CAAC;YACtC,MAAM,EAAE,IAAI,EAAE,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;YAC3E,UAAU,CAAC,IAAI,CAAC;gBACd,IAAI,EAAE,IAAI,GAAG,CAAC;gBACd,MAAM,EAAE,CAAC;gBACT,OAAO,EAAE,mCAAmC;gBAC5C,QAAQ,EAAE,OAAO;gBACjB,UAAU,EAAE,yDAAyD;gBACrE,KAAK,EAAE,OAAO;aACf,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED;;GAEG;AACH,SAAS,2BAA2B,CAClC,IAAoB,EACpB,UAAyB;IAEzB,MAAM,UAAU,GAAqB,EAAE,CAAC;IACxC,MAAM,SAAS,GAAG,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;IAEjD,6DAA6D;IAC7D,IAAI,SAAS,CAAC,QAAQ,CAAC,kBAAkB,CAAC;QAAE,OAAO,UAAU,CAAC;IAE9D,6BAA6B;IAC7B,IAAI,SAAS,CAAC,QAAQ,CAAC,UAAU,CAAC,EAAE,CAAC;QACnC,MAAM,EAAE,IAAI,EAAE,GAAG,UAAU,CAAC,6BAA6B,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAC;QAC3E,MAAM,UAAU,GAAG,IAAI,CAAC,mBAAmB,EAAE,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,IAAI,OAAO,CAAC;QACjF,UAAU,CAAC,IAAI,CAAC;YACd,IAAI,EAAE,IAAI,GAAG,CAAC;YACd,MAAM,EAAE,CAAC;YACT,OAAO,EAAE,wEAAwE;YACjF,QAAQ,EAAE,SAAS;YACnB,UAAU,EAAE,aAAa,UAAU,8EAA8E;YACjH,KAAK,EAAE,UAAU;SAClB,CAAC,CAAC;IACL,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED,gFAAgF;AAChF,uBAAuB;AACvB,gFAAgF;AAEhF;;;;;;;;GAQG;AACH,MAAM,CAAC,MAAM,oBAAoB,GAAG,WAAW,CAAC;IAC9C,EAAE,EAAE,sCAAsC;IAC1C,IAAI,EAAE,wBAAwB;IAC9B,KAAK,EAAE,EAAE,SAAS,EAAE,CAAC,YAAY,CAAC,EAAE,QAAQ,EAAE,CAAC,SAAS,EAAE,QAAQ,CAAC,EAAE;IACrE,aAAa,EAAE,eAAe;IAC9B,UAAU,EAAE,MAAM;IAClB,WAAW,EAAE,+DAA+D;IAC5E,eAAe,EAAE;;;;;;;;;;;iCAWc;IAC/B,IAAI,EAAE,CAAC,SAAS,EAAE,YAAY,EAAE,gBAAgB,EAAE,eAAe,EAAE,gBAAgB,CAAC;IACpF,SAAS,EAAE,CAAC,IAAI,CAAC;IAEjB,OAAO,CAAC,OAAO,EAAE,QAAQ;QACvB,8GAA8G;QAC9G,IAAI,UAAU,CAAC,QAAQ,CAAC;YAAE,OAAO,EAAE,CAAC;QAEpC,mDAAmD;QACnD,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,OAAO,CAAC,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,OAAO,CAAC,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAC,EAAE,CAAC;YAC7F,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,MAAM,UAAU,GAAqB,EAAE,CAAC;QAExC,MAAM,UAAU,GAAG,mBAAmB,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;QAC1D,uCAAuC;QACvC,IAAI,CAAC,UAAU;YAAE,OAAO,EAAE,CAAC;QAE3B,MAAM,KAAK,GAAG,CAAC,IAAa,EAAQ,EAAE;YACpC,IAAI,EAAE,CAAC,aAAa,CAAC,IAAI,CAAC,EAAE,CAAC;gBAC3B,UAAU,CAAC,IAAI,CACb,GAAG,gBAAgB,CAAC,IAAI,EAAE,UAAU,CAAC,EACrC,GAAG,2BAA2B,CAAC,IAAI,EAAE,UAAU,CAAC,CACjD,CAAC;YACJ,CAAC;YACD,IAAI,EAAE,CAAC,aAAa,CAAC,IAAI,CAAC,EAAE,CAAC;gBAC3B,UAAU,CAAC,IAAI,CAAC,GAAG,gBAAgB,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC,CAAC;YACzD,CAAC;YACD,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;gBAC9B,UAAU,CAAC,IAAI,CAAC,GAAG,kBAAkB,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC,CAAC;YAC3D,CAAC;YACD,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;QAC/B,CAAC,CAAC;QAEF,KAAK,CAAC,UAAU,CAAC,CAAC;QAClB,OAAO,UAAU,CAAC;IACpB,CAAC;CACF,CAAC,CAAC"}

package/dist/checks/quality/patterns/index.d.ts

@@ -0,0 +1,10 @@
+export * from './async-waterfall-detection.js';
+export * from './dispose-pattern-completeness.js';
+export * from './error-handling-quality.js';
+export * from './lifecycle-cleanup-enforcement.js';
+export * from './result-pattern-consistency.js';
+export * from './silent-early-returns.js';
+export * from './stream-buffer-size-limits.js';
+export * from './throws-documentation.js';
+export * from './toctou-race-condition.js';
+//# sourceMappingURL=index.d.ts.map

package/dist/checks/quality/patterns/index.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../../../src/checks/quality/patterns/index.ts"],"names":[],"mappings":"AAAA,cAAc,gCAAgC,CAAC;AAC/C,cAAc,mCAAmC,CAAC;AAClD,cAAc,6BAA6B,CAAC;AAC5C,cAAc,oCAAoC,CAAC;AACnD,cAAc,iCAAiC,CAAC;AAChD,cAAc,2BAA2B,CAAC;AAC1C,cAAc,gCAAgC,CAAC;AAC/C,cAAc,2BAA2B,CAAC;AAC1C,cAAc,4BAA4B,CAAC"}

package/dist/checks/quality/patterns/index.js

@@ -0,0 +1,10 @@
+export * from './async-waterfall-detection.js';
+export * from './dispose-pattern-completeness.js';
+export * from './error-handling-quality.js';
+export * from './lifecycle-cleanup-enforcement.js';
+export * from './result-pattern-consistency.js';
+export * from './silent-early-returns.js';
+export * from './stream-buffer-size-limits.js';
+export * from './throws-documentation.js';
+export * from './toctou-race-condition.js';
+//# sourceMappingURL=index.js.map

package/dist/checks/quality/patterns/index.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../../src/checks/quality/patterns/index.ts"],"names":[],"mappings":"AAAA,cAAc,gCAAgC,CAAC;AAC/C,cAAc,mCAAmC,CAAC;AAClD,cAAc,6BAA6B,CAAC;AAC5C,cAAc,oCAAoC,CAAC;AACnD,cAAc,iCAAiC,CAAC;AAChD,cAAc,2BAA2B,CAAC;AAC1C,cAAc,gCAAgC,CAAC;AAC/C,cAAc,2BAA2B,CAAC;AAC1C,cAAc,4BAA4B,CAAC"}

package/dist/checks/quality/patterns/lifecycle-cleanup-enforcement.d.ts

@@ -0,0 +1,16 @@
+/**
+ * @fileoverview Lifecycle Cleanup Enforcement check
+ *
+ * Detects resources with lifecycle methods (destroy, close, shutdown, stop, disconnect)
+ * that are created but never have their cleanup method called in the same scope.
+ * Unlike dispose-pattern-completeness (which checks IDisposable implementations),
+ * this check analyzes call-sites for proper resource cleanup.
+ */
+/**
+ * Check: quality/lifecycle-cleanup-enforcement
+ *
+ * Detects resources with lifecycle methods (destroy, close, shutdown, stop, disconnect)
+ * created without cleanup. Uses a hardcoded registry of known lifecycle types.
+ */
+export declare const lifecycleCleanupEnforcement: import("@opensip-cli/fitness").Check;
+//# sourceMappingURL=lifecycle-cleanup-enforcement.d.ts.map

package/dist/checks/quality/patterns/lifecycle-cleanup-enforcement.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"lifecycle-cleanup-enforcement.d.ts","sourceRoot":"","sources":["../../../../src/checks/quality/patterns/lifecycle-cleanup-enforcement.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAmPH;;;;;GAKG;AACH,eAAO,MAAM,2BAA2B,sCA2BtC,CAAC"}

package/dist/checks/quality/patterns/lifecycle-cleanup-enforcement.js

@@ -0,0 +1,205 @@
+/**
+ * @fileoverview Lifecycle Cleanup Enforcement check
+ *
+ * Detects resources with lifecycle methods (destroy, close, shutdown, stop, disconnect)
+ * that are created but never have their cleanup method called in the same scope.
+ * Unlike dispose-pattern-completeness (which checks IDisposable implementations),
+ * this check analyzes call-sites for proper resource cleanup.
+ */
+import { defineCheck } from '@opensip-cli/fitness';
+import { findEnclosingScope, getSharedSourceFile } from '@opensip-cli/lang-typescript';
+import * as ts from 'typescript';
+/**
+ * Hardcoded registry of known types with lifecycle methods.
+ * Extend this list as new lifecycle types are identified.
+ */
+const KNOWN_LIFECYCLE_TYPES = [
+    { name: 'SipDataClient', methods: ['destroy'] },
+];
+/**
+ * Set of all known type names for quick filtering.
+ */
+const KNOWN_TYPE_NAMES = new Set(KNOWN_LIFECYCLE_TYPES.map((t) => t.name));
+/**
+ * Check if a node is a `new KnownType(...)` expression.
+ * @param node - The AST node to check
+ * @returns The matching LifecycleType or undefined
+ */
+function getLifecycleTypeFromNewExpression(node) {
+    /* v8 ignore next -- defensive AST/type guard */
+    if (!ts.isNewExpression(node)) {
+        return undefined;
+    }
+    const expression = node.expression;
+    /* v8 ignore next -- defensive AST/type guard */
+    if (!ts.isIdentifier(expression)) {
+        return undefined;
+    }
+    const typeName = expression.text;
+    return KNOWN_LIFECYCLE_TYPES.find((t) => t.name === typeName);
+}
+/**
+ * Check if a scope contains a cleanup call for the given variable and method.
+ * Searches for patterns like: `variableName.method()`, `await variableName.method()`,
+ * or references within try/finally blocks.
+ * @param scope - The enclosing scope to search
+ * @param variableName - The variable name to check
+ * @param method - The lifecycle method to look for
+ * @param sourceFile - The source file for text extraction
+ * @returns True if a cleanup call was found
+ */
+function hasCleanupCallInScope(scope, variableName, method, sourceFile) {
+    let found = false;
+    const visit = (node) => {
+        if (found) {
+            return;
+        }
+        // Check for direct call: variableName.method()
+        if (ts.isCallExpression(node)) {
+            const expr = node.expression;
+            if (ts.isPropertyAccessExpression(expr) &&
+                ts.isIdentifier(expr.expression) &&
+                expr.expression.text === variableName &&
+                expr.name.text === method) {
+                found = true;
+                return;
+            }
+        }
+        // Check for optional chaining: variableName?.method()
+        /* v8 ignore next -- defensive AST/type guard */
+        if (ts.isCallExpression(node)) {
+            const nodeText = node.getText(sourceFile);
+            if (nodeText.includes(`${variableName}?.${method}(`) ||
+                nodeText.includes(`${variableName}.${method}(`)) {
+                found = true;
+                return;
+            }
+        }
+        ts.forEachChild(node, visit);
+    };
+    ts.forEachChild(scope, visit);
+    return found;
+}
+/**
+ * Check if the file defines (contains the class declaration for) any known lifecycle type.
+ * These files are the implementations, not consumers, and should be skipped.
+ * @param content - The file content
+ * @returns True if the file contains a class definition for a known type
+ */
+function isClassDefinitionFile(content) {
+    for (const typeName of KNOWN_TYPE_NAMES) {
+        if (content.includes(`class ${typeName}`)) {
+            return true;
+        }
+    }
+    return false;
+}
+/**
+ * Find all resource creation sites in the AST.
+ * Looks for variable declarations where the initializer is `new KnownType(...)`.
+ * @param sourceFile - The parsed TypeScript source file
+ * @returns Array of resource creation records
+ */
+function findResourceCreations(sourceFile) {
+    const creations = [];
+    const visit = (node) => {
+        if (ts.isVariableDeclaration(node) && node.initializer) {
+            const lifecycleType = getLifecycleTypeFromNewExpression(node.initializer);
+            if (lifecycleType && ts.isIdentifier(node.name)) {
+                creations.push({
+                    variableName: node.name.text,
+                    lifecycleType,
+                    node,
+                    scope: findEnclosingScope(node),
+                });
+            }
+        }
+        ts.forEachChild(node, visit);
+    };
+    visit(sourceFile);
+    return creations;
+}
+/**
+ * Create a violation for a resource that is missing cleanup.
+ * @param ctx - Violation context
+ * @param creation - The resource creation record
+ * @param missingMethods - The lifecycle methods that were not called
+ * @returns CheckViolation object
+ */
+function createMissingCleanupViolation(ctx, creation, missingMethods) {
+    const { line: lineIdx, character } = ctx.sourceFile.getLineAndCharacterOfPosition(creation.node.getStart());
+    const line = lineIdx + 1;
+    const methodList = missingMethods.join(', ');
+    return {
+        line,
+        column: character + 1,
+        message: `Resource '${creation.variableName}' (${creation.lifecycleType.name}) is created but never cleaned up. Missing call to: ${methodList}`,
+        severity: 'warning',
+        suggestion: `Add '${creation.variableName}.${missingMethods[0]}()' in a finally block or cleanup handler to prevent resource leaks`,
+        type: 'missing-lifecycle-cleanup',
+        match: `new ${creation.lifecycleType.name}`,
+    };
+}
+/**
+ * Analyze a file for lifecycle cleanup coverage.
+ * Walks the AST to find resource creations and checks that cleanup methods are called.
+ * @param absolutePath - The file path
+ * @param content - The file content
+ * @returns Array of violations for uncleaned resources
+ */
+function analyzeCleanupCoverage(absolutePath, content) {
+    const violations = [];
+    // Skip files that define the lifecycle types themselves
+    if (isClassDefinitionFile(content)) {
+        return violations;
+    }
+    const sourceFile = getSharedSourceFile(absolutePath, content);
+    /* v8 ignore next -- defensive guard */
+    if (!sourceFile)
+        return [];
+    const ctx = { absolutePath, content, sourceFile };
+    const creations = findResourceCreations(sourceFile);
+    for (const creation of creations) {
+        const missingMethods = [];
+        for (const method of creation.lifecycleType.methods) {
+            if (!hasCleanupCallInScope(creation.scope, creation.variableName, method, sourceFile)) {
+                missingMethods.push(method);
+            }
+        }
+        if (missingMethods.length > 0) {
+            violations.push(createMissingCleanupViolation(ctx, creation, missingMethods));
+        }
+    }
+    return violations;
+}
+/**
+ * Check: quality/lifecycle-cleanup-enforcement
+ *
+ * Detects resources with lifecycle methods (destroy, close, shutdown, stop, disconnect)
+ * created without cleanup. Uses a hardcoded registry of known lifecycle types.
+ */
+export const lifecycleCleanupEnforcement = defineCheck({
+    id: '6350ce24-8ccc-4607-a962-8b067633547c',
+    slug: 'lifecycle-cleanup-enforcement',
+    scope: { languages: ['typescript'], concerns: ['backend', 'server'] },
+    confidence: 'high',
+    description: 'Detect resources with lifecycle methods (destroy/close/shutdown) created without cleanup',
+    longDescription: `**Purpose:** Detects resources with lifecycle methods that are created but never have their cleanup method called in the same scope.
+
+**Detects:** Analyzes each file individually using TypeScript AST. Looks for \`new KnownType()\` variable declarations (currently: \`SipDataClient\`) and verifies that the required cleanup method (\`destroy()\`) is called on the variable within the enclosing function scope.
+
+**Why it matters:** Resources without cleanup calls cause connection leaks, file descriptor exhaustion, and memory leaks that accumulate over the application lifetime.
+
+**Scope:** Codebase-specific convention (hardcoded registry of known lifecycle types)`,
+    tags: ['quality', 'resources', 'memory', 'cleanup', 'lifecycle'],
+    fileTypes: ['ts'],
+    analyze(content, filePath) {
+        // Quick filter: skip files that do not reference any known lifecycle type
+        const hasKnownType = [...KNOWN_TYPE_NAMES].some((name) => content.includes(name));
+        if (!hasKnownType) {
+            return [];
+        }
+        return analyzeCleanupCoverage(filePath, content);
+    },
+});
+//# sourceMappingURL=lifecycle-cleanup-enforcement.js.map

package/dist/checks/quality/patterns/lifecycle-cleanup-enforcement.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"lifecycle-cleanup-enforcement.js","sourceRoot":"","sources":["../../../../src/checks/quality/patterns/lifecycle-cleanup-enforcement.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,OAAO,EAAE,WAAW,EAAuB,MAAM,sBAAsB,CAAC;AACxE,OAAO,EAAE,kBAAkB,EAAE,mBAAmB,EAAE,MAAM,8BAA8B,CAAC;AACvF,OAAO,KAAK,EAAE,MAAM,YAAY,CAAC;AAYjC;;;GAGG;AACH,MAAM,qBAAqB,GAA6B;IACtD,EAAE,IAAI,EAAE,eAAe,EAAE,OAAO,EAAE,CAAC,SAAS,CAAC,EAAE;CAChD,CAAC;AAEF;;GAEG;AACH,MAAM,gBAAgB,GAAG,IAAI,GAAG,CAAC,qBAAqB,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC;AAyB3E;;;;GAIG;AACH,SAAS,iCAAiC,CAAC,IAAmB;IAC5D,gDAAgD;IAChD,IAAI,CAAC,EAAE,CAAC,eAAe,CAAC,IAAI,CAAC,EAAE,CAAC;QAC9B,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,MAAM,UAAU,GAAG,IAAI,CAAC,UAAU,CAAC;IACnC,gDAAgD;IAChD,IAAI,CAAC,EAAE,CAAC,YAAY,CAAC,UAAU,CAAC,EAAE,CAAC;QACjC,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,MAAM,QAAQ,GAAG,UAAU,CAAC,IAAI,CAAC;IACjC,OAAO,qBAAqB,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,QAAQ,CAAC,CAAC;AAChE,CAAC;AAED;;;;;;;;;GASG;AACH,SAAS,qBAAqB,CAC5B,KAAc,EACd,YAAoB,EACpB,MAAc,EACd,UAAyB;IAEzB,IAAI,KAAK,GAAG,KAAK,CAAC;IAElB,MAAM,KAAK,GAAG,CAAC,IAAa,EAAQ,EAAE;QACpC,IAAI,KAAK,EAAE,CAAC;YACV,OAAO;QACT,CAAC;QAED,+CAA+C;QAC/C,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;YAC9B,MAAM,IAAI,GAAG,IAAI,CAAC,UAAU,CAAC;YAC7B,IACE,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC;gBACnC,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC;gBAChC,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,YAAY;gBACrC,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,MAAM,EACzB,CAAC;gBACD,KAAK,GAAG,IAAI,CAAC;gBACb,OAAO;YACT,CAAC;QACH,CAAC;QAED,sDAAsD;QACtD,gDAAgD;QAChD,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;YAC9B,MAAM,QAAQ,GAAG,IAAI,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;YAC1C,IACE,QAAQ,CAAC,QAAQ,CAAC,GAAG,YAAY,KAAK,MAAM,GAAG,CAAC;gBAChD,QAAQ,CAAC,QAAQ,CAAC,GAAG,YAAY,IAAI,MAAM,GAAG,CAAC,EAC/C,CAAC;gBACD,KAAK,GAAG,IAAI,CAAC;gBACb,OAAO;YACT,CAAC;QACH,CAAC;QAED,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;IAC/B,CAAC,CAAC;IAEF,EAAE,CAAC,YAAY,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;IAC9B,OAAO,KAAK,CAAC;AACf,CAAC;AAED;;;;;GAKG;AACH,SAAS,qBAAqB,CAAC,OAAe;IAC5C,KAAK,MAAM,QAAQ,IAAI,gBAAgB,EAAE,CAAC;QACxC,IAAI,OAAO,CAAC,QAAQ,CAAC,SAAS,QAAQ,EAAE,CAAC,EAAE,CAAC;YAC1C,OAAO,IAAI,CAAC;QACd,CAAC;IACH,CAAC;IACD,OAAO,KAAK,CAAC;AACf,CAAC;AAED;;;;;GAKG;AACH,SAAS,qBAAqB,CAAC,UAAyB;IACtD,MAAM,SAAS,GAAuB,EAAE,CAAC;IAEzC,MAAM,KAAK,GAAG,CAAC,IAAa,EAAQ,EAAE;QACpC,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,WAAW,EAAE,CAAC;YACvD,MAAM,aAAa,GAAG,iCAAiC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;YAC1E,IAAI,aAAa,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;gBAChD,SAAS,CAAC,IAAI,CAAC;oBACb,YAAY,EAAE,IAAI,CAAC,IAAI,CAAC,IAAI;oBAC5B,aAAa;oBACb,IAAI;oBACJ,KAAK,EAAE,kBAAkB,CAAC,IAAI,CAAC;iBAChC,CAAC,CAAC;YACL,CAAC;QACH,CAAC;QAED,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;IAC/B,CAAC,CAAC;IAEF,KAAK,CAAC,UAAU,CAAC,CAAC;IAClB,OAAO,SAAS,CAAC;AACnB,CAAC;AAED;;;;;;GAMG;AACH,SAAS,6BAA6B,CACpC,GAAqB,EACrB,QAA0B,EAC1B,cAAiC;IAEjC,MAAM,EAAE,IAAI,EAAE,OAAO,EAAE,SAAS,EAAE,GAAG,GAAG,CAAC,UAAU,CAAC,6BAA6B,CAC/E,QAAQ,CAAC,IAAI,CAAC,QAAQ,EAAE,CACzB,CAAC;IACF,MAAM,IAAI,GAAG,OAAO,GAAG,CAAC,CAAC;IACzB,MAAM,UAAU,GAAG,cAAc,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAE7C,OAAO;QACL,IAAI;QACJ,MAAM,EAAE,SAAS,GAAG,CAAC;QACrB,OAAO,EAAE,aAAa,QAAQ,CAAC,YAAY,MAAM,QAAQ,CAAC,aAAa,CAAC,IAAI,uDAAuD,UAAU,EAAE;QAC/I,QAAQ,EAAE,SAAS;QACnB,UAAU,EAAE,QAAQ,QAAQ,CAAC,YAAY,IAAI,cAAc,CAAC,CAAC,CAAC,qEAAqE;QACnI,IAAI,EAAE,2BAA2B;QACjC,KAAK,EAAE,OAAO,QAAQ,CAAC,aAAa,CAAC,IAAI,EAAE;KAC5C,CAAC;AACJ,CAAC;AAED;;;;;;GAMG;AACH,SAAS,sBAAsB,CAAC,YAAoB,EAAE,OAAe;IACnE,MAAM,UAAU,GAAqB,EAAE,CAAC;IAExC,wDAAwD;IACxD,IAAI,qBAAqB,CAAC,OAAO,CAAC,EAAE,CAAC;QACnC,OAAO,UAAU,CAAC;IACpB,CAAC;IAED,MAAM,UAAU,GAAG,mBAAmB,CAAC,YAAY,EAAE,OAAO,CAAC,CAAC;IAC9D,uCAAuC;IACvC,IAAI,CAAC,UAAU;QAAE,OAAO,EAAE,CAAC;IAE3B,MAAM,GAAG,GAAqB,EAAE,YAAY,EAAE,OAAO,EAAE,UAAU,EAAE,CAAC;IAEpE,MAAM,SAAS,GAAG,qBAAqB,CAAC,UAAU,CAAC,CAAC;IAEpD,KAAK,MAAM,QAAQ,IAAI,SAAS,EAAE,CAAC;QACjC,MAAM,cAAc,GAAa,EAAE,CAAC;QAEpC,KAAK,MAAM,MAAM,IAAI,QAAQ,CAAC,aAAa,CAAC,OAAO,EAAE,CAAC;YACpD,IAAI,CAAC,qBAAqB,CAAC,QAAQ,CAAC,KAAK,EAAE,QAAQ,CAAC,YAAY,EAAE,MAAM,EAAE,UAAU,CAAC,EAAE,CAAC;gBACtF,cAAc,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;YAC9B,CAAC;QACH,CAAC;QAED,IAAI,cAAc,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAC9B,UAAU,CAAC,IAAI,CAAC,6BAA6B,CAAC,GAAG,EAAE,QAAQ,EAAE,cAAc,CAAC,CAAC,CAAC;QAChF,CAAC;IACH,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED;;;;;GAKG;AACH,MAAM,CAAC,MAAM,2BAA2B,GAAG,WAAW,CAAC;IACrD,EAAE,EAAE,sCAAsC;IAC1C,IAAI,EAAE,+BAA+B;IACrC,KAAK,EAAE,EAAE,SAAS,EAAE,CAAC,YAAY,CAAC,EAAE,QAAQ,EAAE,CAAC,SAAS,EAAE,QAAQ,CAAC,EAAE;IAErE,UAAU,EAAE,MAAM;IAClB,WAAW,EACT,0FAA0F;IAC5F,eAAe,EAAE;;;;;;sFAMmE;IACpF,IAAI,EAAE,CAAC,SAAS,EAAE,WAAW,EAAE,QAAQ,EAAE,SAAS,EAAE,WAAW,CAAC;IAChE,SAAS,EAAE,CAAC,IAAI,CAAC;IAEjB,OAAO,CAAC,OAAO,EAAE,QAAQ;QACvB,0EAA0E;QAC1E,MAAM,YAAY,GAAG,CAAC,GAAG,gBAAgB,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,OAAO,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC;QAClF,IAAI,CAAC,YAAY,EAAE,CAAC;YAClB,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,OAAO,sBAAsB,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;IACnD,CAAC;CACF,CAAC,CAAC"}