@openshift-migration-advisor/shared-components 0.25.0 → 0.27.0

package/src/report/WarningsTable.tsx

@@ -0,0 +1,75 @@
+import {
+  Card,
+  CardBody,
+  CardTitle,
+  Flex,
+  FlexItem,
+  Icon,
+} from "@patternfly/react-core";
+import { ExclamationTriangleIcon } from "@patternfly/react-icons";
+import type React from "react";
+import { CardEmptyState } from "./CardEmptyState.js";
+import { ChartHeaderActions } from "./ChartDownloadButton.js";
+import { ChartExportSurface } from "./ChartExportSurface.js";
+import { REPORT_CARD_EMPTY_STATE_TITLES } from "./constants.js";
+import { dashboardStyles } from "./dashboardStyles.js";
+import type { MigrationIssueLike } from "./ErrorTable.js";
+import { ReportTable } from "./ReportTable.js";
+
+export interface WarningsTableProps {
+  warnings: MigrationIssueLike[];
+  /** Optional drill-down callback invoked with an issue's `label`. */
+  onConcernClick?: (concernLabel: string) => void;
+}
+
+export const WarningsTable: React.FC<WarningsTableProps> = ({
+  warnings,
+  onConcernClick,
+}) => {
+  const handleRowClick = (issue: MigrationIssueLike) => {
+    if (issue.label && onConcernClick) {
+      onConcernClick(issue.label);
+    }
+  };
+
+  const chartId = "warnings-table";
+  const chartTitle = "Warnings";
+
+  return (
+    <ChartExportSurface id={chartId} title={chartTitle}>
+      <Card className={dashboardStyles.card}>
+        <CardTitle>
+          <Flex
+            justifyContent={{ default: "justifyContentSpaceBetween" }}
+            alignItems={{ default: "alignItemsCenter" }}
+          >
+            <FlexItem>
+              <Icon status="warning">
+                <ExclamationTriangleIcon />
+              </Icon>{" "}
+              Warnings
+            </FlexItem>
+            <ChartHeaderActions chartId={chartId} title={chartTitle} />
+          </Flex>
+        </CardTitle>
+        <CardBody className={dashboardStyles.cardBodyScrollable}>
+          {warnings.length === 0 ? (
+            <CardEmptyState title={REPORT_CARD_EMPTY_STATE_TITLES.warnings} />
+          ) : (
+            <div>
+              <ReportTable<MigrationIssueLike>
+                data={warnings}
+                columns={["Description", "Total VMs"]}
+                fields={["assessment", "count"]}
+                onRowClick={onConcernClick ? handleRowClick : undefined}
+                clickableFields={onConcernClick ? ["assessment"] : []}
+              />
+            </div>
+          )}
+        </CardBody>
+      </Card>
+    </ChartExportSurface>
+  );
+};
+
+WarningsTable.displayName = "WarningsTable";

package/src/report/__tests__/ChartExportProvider.test.tsx

@@ -0,0 +1,474 @@
+import "@testing-library/jest-dom";
+import { cleanup, render, screen, waitFor } from "@testing-library/react";
+import userEvent from "@testing-library/user-event";
+import { useState } from "react";
+import { afterEach, describe, expect, it, vi } from "vitest";
+import { ChartExportProvider, useChartExport } from "../ChartExportProvider.js";
+import { ChartExportSurface } from "../ChartExportSurface.js";
+import {
+  CHART_EXPORT_HIDE_ATTR,
+  chartPngFilename,
+  shouldIgnoreChartExportElement,
+  slugifyExportName,
+} from "../chartExport.js";
+import { useRegisterChart } from "../chartExportContext.js";
+import { HostPowerStates } from "../HostPowerStates.js";
+import { ExportReportButton, ReportExportMenu } from "../ReportExportMenu.js";
+import { standardReportExportOptions } from "../reportExportOptions.js";
+
+vi.mock("../../charts/MigrationDonutChart.js", () => ({
+  MigrationDonutChart: ({
+    title,
+    subTitle,
+  }: {
+    title?: string;
+    subTitle?: string;
+  }): JSX.Element => (
+    <div data-testid="power-donut">
+      {title} {subTitle}
+    </div>
+  ),
+}));
+
+afterEach(() => cleanup());
+
+function RegisteredChart({
+  id,
+  title,
+}: {
+  id: string;
+  title: string;
+}): JSX.Element {
+  const ref = useRegisterChart({ id, title });
+  return (
+    <div ref={ref} data-testid={`chart-${id}`}>
+      {title}
+    </div>
+  );
+}
+
+function DownloadAllButton(): JSX.Element {
+  const exportApi = useChartExport();
+  return (
+    <button type="button" onClick={() => void exportApi?.downloadAll()}>
+      Download all
+    </button>
+  );
+}
+
+describe("chart export names", () => {
+  it("slugifies titles for PNG filenames", () => {
+    expect(slugifyExportName("CPU & memory")).toBe("cpu-memory");
+    expect(chartPngFilename("CPU & memory", "cpu")).toBe("cpu-memory.png");
+  });
+});
+
+describe("shouldIgnoreChartExportElement", () => {
+  it("keeps the capture root and skips sibling cards", () => {
+    const page = document.createElement("div");
+    const card = document.createElement("div");
+    const sibling = document.createElement("div");
+    page.append(card, sibling);
+
+    expect(shouldIgnoreChartExportElement(card, card)).toBe(false);
+    expect(shouldIgnoreChartExportElement(sibling, card)).toBe(true);
+    expect(shouldIgnoreChartExportElement(page, card)).toBe(false);
+  });
+
+  it("skips chrome marked for export hide inside the card", () => {
+    const card = document.createElement("div");
+    const hide = document.createElement("button");
+    hide.setAttribute(CHART_EXPORT_HIDE_ATTR, "");
+    card.append(hide);
+
+    expect(shouldIgnoreChartExportElement(hide, card)).toBe(true);
+  });
+});
+
+function fakeCanvas(): HTMLCanvasElement {
+  const canvas = document.createElement("canvas");
+  canvas.width = 10;
+  canvas.height = 10;
+  return canvas;
+}
+
+function DownloadChartButton({ id }: { id: string }): JSX.Element {
+  const exportApi = useChartExport();
+  return (
+    <button type="button" onClick={() => void exportApi?.downloadChart(id)}>
+      Download {id}
+    </button>
+  );
+}
+
+function DownloadPdfButton(): JSX.Element {
+  const exportApi = useChartExport();
+  return (
+    <button
+      type="button"
+      onClick={() => void exportApi?.downloadPdf("Overview")}
+    >
+      Download pdf
+    </button>
+  );
+}
+
+function DownloadHtmlButton(): JSX.Element {
+  const exportApi = useChartExport();
+  return (
+    <button
+      type="button"
+      onClick={() => void exportApi?.downloadHtml("Overview")}
+    >
+      Download html
+    </button>
+  );
+}
+
+describe("ChartExportProvider", () => {
+  it("snapshots registered live nodes instead of a second chart tree", async () => {
+    const user = userEvent.setup();
+    const capture = vi.fn(async () => fakeCanvas());
+    const encodePng = vi.fn(async () => new Blob(["png"]));
+    const zipFiles = vi.fn(
+      async (files: { filename: string; blob: Blob }[]) => {
+        return new Blob([files.map((file) => file.filename).join(",")]);
+      },
+    );
+    const downloadFile = vi.fn();
+
+    render(
+      <ChartExportProvider
+        capture={capture}
+        encodePng={encodePng}
+        zipFiles={zipFiles}
+        downloadFile={downloadFile}
+        getZipFilename={() => "charts.zip"}
+      >
+        <RegisteredChart id="cpu-memory" title="CPU and memory" />
+        <RegisteredChart id="storage" title="Disks" />
+        <DownloadAllButton />
+      </ChartExportProvider>,
+    );
+
+    await user.click(screen.getByRole("button", { name: "Download all" }));
+
+    expect(zipFiles).toHaveBeenCalledTimes(1);
+    expect(downloadFile).toHaveBeenCalledWith(expect.any(Blob), "charts.zip");
+  });
+
+  it("downloads one registered node as a PNG", async () => {
+    const user = userEvent.setup();
+    const capture = vi.fn(async () => fakeCanvas());
+    const encodePng = vi.fn(async () => new Blob(["png"]));
+    const downloadFile = vi.fn();
+
+    render(
+      <ChartExportProvider
+        capture={capture}
+        encodePng={encodePng}
+        zipFiles={vi.fn()}
+        downloadFile={downloadFile}
+      >
+        <RegisteredChart id="storage" title="Disks" />
+        <DownloadChartButton id="storage" />
+      </ChartExportProvider>,
+    );
+
+    await user.click(screen.getByRole("button", { name: "Download storage" }));
+
+    expect(capture).toHaveBeenCalledTimes(1);
+    expect(downloadFile).toHaveBeenCalledWith(expect.any(Blob), "disks.png");
+  });
+
+  it("re-registers charts after React Strict Mode's extra effect cycle", async () => {
+    const user = userEvent.setup();
+    const capture = vi.fn(async () => fakeCanvas());
+    const encodePng = vi.fn(async () => new Blob(["png"]));
+    const downloadFile = vi.fn();
+
+    render(
+      <ChartExportProvider
+        capture={capture}
+        encodePng={encodePng}
+        zipFiles={vi.fn()}
+        downloadFile={downloadFile}
+      >
+        <RegisteredChart id="storage" title="Disks" />
+        <DownloadChartButton id="storage" />
+      </ChartExportProvider>,
+      { reactStrictMode: true },
+    );
+
+    await user.click(screen.getByRole("button", { name: "Download storage" }));
+
+    expect(capture).toHaveBeenCalledTimes(1);
+    expect(downloadFile).toHaveBeenCalledWith(expect.any(Blob), "disks.png");
+  });
+
+  it("builds a PDF from the same captured canvases", async () => {
+    const user = userEvent.setup();
+    const capture = vi.fn(async () => fakeCanvas());
+    const buildPdf = vi.fn(async () => new Blob(["pdf"]));
+    const downloadFile = vi.fn();
+
+    render(
+      <ChartExportProvider
+        capture={capture}
+        zipFiles={vi.fn()}
+        buildPdf={buildPdf}
+        downloadFile={downloadFile}
+        getPdfFilename={() => "report.pdf"}
+      >
+        <RegisteredChart id="storage" title="Disks" />
+        <DownloadPdfButton />
+      </ChartExportProvider>,
+    );
+
+    await user.click(screen.getByRole("button", { name: "Download pdf" }));
+
+    expect(buildPdf).toHaveBeenCalledTimes(1);
+    expect(buildPdf.mock.calls[0]?.[1]).toBe("Overview");
+    expect(buildPdf.mock.calls[0]?.[0][0]).toMatchObject({
+      id: "storage",
+      title: "Disks",
+    });
+    expect(downloadFile).toHaveBeenCalledWith(expect.any(Blob), "report.pdf");
+  });
+
+  it("builds HTML from the same captured canvases", async () => {
+    const user = userEvent.setup();
+    const capture = vi.fn(async () => fakeCanvas());
+    const buildHtml = vi.fn(async () => new Blob(["html"]));
+    const downloadFile = vi.fn();
+
+    render(
+      <ChartExportProvider
+        capture={capture}
+        zipFiles={vi.fn()}
+        buildHtml={buildHtml}
+        downloadFile={downloadFile}
+        getHtmlFilename={() => "report.html"}
+      >
+        <RegisteredChart id="storage" title="Disks" />
+        <DownloadHtmlButton />
+      </ChartExportProvider>,
+    );
+
+    await user.click(screen.getByRole("button", { name: "Download html" }));
+
+    expect(buildHtml).toHaveBeenCalledTimes(1);
+    expect(buildHtml.mock.calls[0]?.[1]).toBe("Overview");
+    expect(downloadFile).toHaveBeenCalledWith(expect.any(Blob), "report.html");
+  });
+
+  it("captures every dropdown view for PDF, HTML, and zip exports", async () => {
+    const user = userEvent.setup();
+    const seenViews: string[] = [];
+    const capture = vi.fn(async (element: HTMLElement) => {
+      seenViews.push(
+        element.querySelector("[data-testid='active-view']")?.textContent ?? "",
+      );
+      return fakeCanvas();
+    });
+    const encodePng = vi.fn(async () => new Blob(["png"]));
+    const zipFiles = vi.fn(
+      async (files: { filename: string; blob: Blob }[]) => {
+        return new Blob([files.map((file) => file.filename).join(",")]);
+      },
+    );
+    const buildPdf = vi.fn(
+      async (
+        sources: { title: string; capture: () => Promise<HTMLCanvasElement> }[],
+      ) => {
+        for (const source of sources) {
+          await source.capture();
+        }
+        return new Blob(["pdf"]);
+      },
+    );
+    const downloadFile = vi.fn();
+
+    function DropdownChart(): JSX.Element {
+      const [view, setView] = useState("a");
+      return (
+        <ChartExportSurface
+          id="vm"
+          title={view === "a" ? "View A" : "View B"}
+          exportViews={[
+            { id: "a", title: "View A" },
+            { id: "b", title: "View B" },
+          ]}
+          activeExportViewId={view}
+          onExportViewChange={setView}
+        >
+          <div data-testid="active-view">{view}</div>
+        </ChartExportSurface>
+      );
+    }
+
+    render(
+      <ChartExportProvider
+        capture={capture}
+        encodePng={encodePng}
+        zipFiles={zipFiles}
+        buildPdf={buildPdf}
+        downloadFile={downloadFile}
+        getZipFilename={() => "charts.zip"}
+        getPdfFilename={() => "report.pdf"}
+      >
+        <DropdownChart />
+        <DownloadAllButton />
+        <DownloadPdfButton />
+      </ChartExportProvider>,
+    );
+
+    await user.click(screen.getByRole("button", { name: "Download all" }));
+    await waitFor(() => expect(zipFiles).toHaveBeenCalledTimes(1));
+    expect(seenViews).toEqual(["a", "b"]);
+    expect(zipFiles.mock.calls[0]?.[0].map((file) => file.filename)).toEqual([
+      "01-view-a.png",
+      "02-view-b.png",
+    ]);
+    expect(screen.getByTestId("active-view")).toHaveTextContent("a");
+
+    seenViews.length = 0;
+    await user.click(screen.getByRole("button", { name: "Download pdf" }));
+    await waitFor(() =>
+      expect(downloadFile).toHaveBeenCalledWith(expect.any(Blob), "report.pdf"),
+    );
+    expect(buildPdf.mock.calls[0]?.[0].map((source) => source.title)).toEqual([
+      "View A",
+      "View B",
+    ]);
+    expect(seenViews).toEqual(["a", "b"]);
+    expect(screen.getByTestId("active-view")).toHaveTextContent("a");
+  });
+
+  it("warns when two live charts share an id", () => {
+    const warn = vi.spyOn(console, "warn").mockImplementation(() => undefined);
+
+    render(
+      <ChartExportProvider capture={vi.fn()} zipFiles={vi.fn()}>
+        <RegisteredChart id="storage" title="Disks" />
+        <RegisteredChart id="storage" title="Disks copy" />
+      </ChartExportProvider>,
+    );
+
+    expect(warn).toHaveBeenCalledWith(
+      expect.stringContaining('Duplicate chart export id "storage"'),
+    );
+    warn.mockRestore();
+  });
+
+  it("shows a generic error when capture fails", async () => {
+    const user = userEvent.setup();
+    vi.spyOn(console, "error").mockImplementation(() => undefined);
+
+    function ErrorText(): JSX.Element {
+      const exportApi = useChartExport();
+      return <div>{exportApi?.exportError}</div>;
+    }
+
+    render(
+      <ChartExportProvider
+        capture={vi.fn(async () => {
+          throw new Error("canvas tainted");
+        })}
+        zipFiles={vi.fn()}
+      >
+        <RegisteredChart id="storage" title="Disks" />
+        <DownloadChartButton id="storage" />
+        <ErrorText />
+      </ChartExportProvider>,
+    );
+
+    await user.click(screen.getByRole("button", { name: "Download storage" }));
+
+    expect(
+      await screen.findByText("Failed to export PNG. Please try again."),
+    ).toBeInTheDocument();
+    expect(screen.queryByText("canvas tainted")).not.toBeInTheDocument();
+    vi.mocked(console.error).mockRestore();
+  });
+
+  it("hides per-chart download when no provider is present", () => {
+    render(<HostPowerStates hostPowerStates={{ green: 3 }} />);
+
+    expect(
+      screen.queryByRole("button", { name: /download/i }),
+    ).not.toBeInTheDocument();
+  });
+
+  it("shows a per-chart download button when the provider is present", () => {
+    render(
+      <ChartExportProvider capture={vi.fn()} zipFiles={vi.fn()}>
+        <HostPowerStates hostPowerStates={{ green: 3 }} />
+      </ChartExportProvider>,
+    );
+
+    expect(
+      screen.getByRole("button", {
+        name: "Download ESXi host power states as PNG",
+      }),
+    ).toBeInTheDocument();
+  });
+});
+
+describe("standardReportExportOptions", () => {
+  it("omits formats whose handlers are missing", () => {
+    const onExportPng = vi.fn();
+    expect(
+      standardReportExportOptions({ onExportPng }).map((option) => option.key),
+    ).toEqual(["png"]);
+  });
+});
+
+describe("ReportExportMenu", () => {
+  it("renders nothing without options", () => {
+    const { container } = render(<ReportExportMenu options={[]} />);
+    expect(container).toBeEmptyDOMElement();
+  });
+
+  it("invokes the PNG handler from the menu", async () => {
+    const user = userEvent.setup();
+    const onExportPng = vi.fn();
+
+    render(<ExportReportButton onExportPng={onExportPng} />);
+
+    await user.click(
+      screen.getByRole("button", { name: "Export report options" }),
+    );
+    await user.click(screen.getByRole("menuitem", { name: /png/i }));
+
+    expect(onExportPng).toHaveBeenCalledTimes(1);
+  });
+
+  it("places the loading spinner in the toggle icon slot", () => {
+    render(
+      <ReportExportMenu
+        isLoading
+        loadingLabel="Generating PNG..."
+        options={[
+          {
+            key: "png",
+            label: "PNG",
+            description: "Download all charts as PNG files",
+            onSelect: vi.fn(),
+          },
+        ]}
+      />,
+    );
+
+    const toggle = screen.getByRole("button", {
+      name: "Export report options",
+    });
+    expect(toggle).toHaveTextContent("Generating PNG...");
+    const iconSlot = toggle.querySelector(".pf-v6-c-menu-toggle__icon");
+    expect(iconSlot).not.toBeNull();
+    expect(iconSlot?.querySelector('[role="progressbar"]')).not.toBeNull();
+    expect(
+      toggle.querySelector(".pf-v6-c-menu-toggle__text")?.textContent,
+    ).toBe("Generating PNG...");
+  });
+});

package/src/report/__tests__/HostsOverview.test.tsx

@@ -0,0 +1,145 @@
+import "@testing-library/jest-dom";
+import {
+  chart_color_blue_300,
+  chart_color_green_300,
+  chart_color_purple_100,
+  chart_color_purple_300,
+  chart_color_teal_200,
+  chart_color_yellow_400,
+} from "@patternfly/react-tokens";
+import { cleanup, render, screen } from "@testing-library/react";
+import { afterEach, describe, expect, it, vi } from "vitest";
+import type { MigrationDonutChartProps } from "../../charts/MigrationDonutChart.js";
+import { HostsOverview } from "../HostsOverview.js";
+
+const donutProps = vi.hoisted(() => ({
+  current: null as MigrationDonutChartProps | null,
+}));
+
+vi.mock("../../charts/MigrationDonutChart.js", () => ({
+  MigrationDonutChart: (props: MigrationDonutChartProps): JSX.Element => {
+    donutProps.current = props;
+    return (
+      <div data-testid="hosts-donut">
+        {props.title} {props.subTitle}
+      </div>
+    );
+  },
+}));
+
+afterEach(() => {
+  donutProps.current = null;
+  cleanup();
+});
+
+const renderedDonut = (): MigrationDonutChartProps => {
+  const props = donutProps.current;
+  if (!props) {
+    throw new Error("expected the host model donut to render");
+  }
+  return props;
+};
+
+describe("HostsOverview", () => {
+  it("shows the shared empty state when no hosts are available", () => {
+    render(<HostsOverview />);
+
+    expect(screen.getByText("Host distribution by model")).toBeInTheDocument();
+    expect(screen.getByText("Top 5 models")).toBeInTheDocument();
+    expect(screen.getByText("Host data not collected")).toBeInTheDocument();
+    expect(screen.queryByTestId("hosts-donut")).not.toBeInTheDocument();
+  });
+
+  it("buckets host counts into the top 5 models plus Other models", () => {
+    render(
+      <HostsOverview
+        hosts={[
+          { model: "M1" },
+          { model: "M1" },
+          { model: "M1" },
+          { model: "M1" },
+          { model: "M1" },
+          { model: "M1" },
+          { model: "M2" },
+          { model: "M2" },
+          { model: "M2" },
+          { model: "M2" },
+          { model: "M2" },
+          { model: "M3" },
+          { model: "M3" },
+          { model: "M3" },
+          { model: "M3" },
+          { model: "M4" },
+          { model: "M4" },
+          { model: "M4" },
+          { model: "M5" },
+          { model: "M5" },
+          { model: "M6" },
+          { model: "M7" },
+        ]}
+      />,
+    );
+
+    expect(screen.getByTestId("hosts-donut")).toHaveTextContent("22 Hosts");
+
+    const props = renderedDonut();
+    expect(props.data.map((slice) => [slice.name, slice.count])).toEqual([
+      ["M1", 6],
+      ["M2", 5],
+      ["M3", 4],
+      ["M4", 3],
+      ["M5", 2],
+      ["Other models", 2],
+    ]);
+    expect(props.data[5]?.countDisplay).toBe("2 hosts");
+    expect(props.legend).toEqual({
+      M1: chart_color_blue_300.value,
+      M2: chart_color_purple_300.value,
+      M3: chart_color_purple_100.value,
+      M4: chart_color_teal_200.value,
+      M5: chart_color_yellow_400.value,
+      "Other models": chart_color_green_300.value,
+    });
+    expect(props.legendVariant).toBe("html");
+    expect(props.height).toBe(300);
+    expect(props.width).toBe(420);
+    expect(props.donutThickness).toBe(18);
+    expect(props.titleFontSize).toBe(34);
+    expect(props.legendWidth).toBe(680);
+    expect(props.itemsPerRow).toBe(2);
+    expect(props.labelFontSize).toBe(16);
+    expect(props.marginLeft).toBe("0%");
+    expect(props.subTitleColor).toBe(
+      "var(--pf-t--global--text--color--subtle)",
+    );
+    expect(
+      props.tooltipLabelFormatter?.({
+        datum: {
+          x: "M1",
+          y: 6,
+          countDisplay: "6 hosts",
+          legendCategory: "M1",
+        },
+        percent: 27.2727,
+        total: 22,
+      }),
+    ).toBe("6 hosts\n27.3%");
+  });
+
+  it("treats numeric models as labels and blank models as unknown", () => {
+    render(
+      <HostsOverview
+        legendVariant="chart"
+        hosts={[{ model: 42 }, { model: "   " }, { model: "  R640  " }]}
+      />,
+    );
+
+    expect(renderedDonut().data.map((slice) => slice.name)).toEqual([
+      "42",
+      "Unknown model",
+      "R640",
+    ]);
+    expect(renderedDonut().legendVariant).toBe("chart");
+    expect(renderedDonut().title).toBe("3");
+  });
+});