@openshift-assisted/ui-lib 2.9.13-cim → 2.9.15-cim

package/lib/cim/components/Agent/tableUtils.tsx

@@ -16,17 +16,24 @@ import { AgentTableActions, ClusterDeploymentWizardStepsType } from '../ClusterD
 import { hostActionResolver } from '../../../common/components/hosts/tableUtils';
 import { getAgentClusterInstallOfAgent, getAIHosts, getInfraEnvNameOfAgent } from '../helpers';
 import { isInstallationInProgress } from '../ClusterDeployment/helpers';
-import { AGENT_BMH_NAME_LABEL_KEY } from '../common';
+import { AGENT_BMH_NAME_LABEL_KEY, INFRAENV_GENERATED_AI_FLOW } from '../common';
 import { BareMetalHostK8sResource } from '../../types/k8s/bare-metal-host';
 import BMHStatus from './BMHStatus';
-import { getAgentStatus, getBMHStatus, getWizardStepAgentStatus } from '../helpers/status';
+import {
+  getAgentStatus,
+  getAgentStatusKey,
+  getBMHStatus,
+  getBMHStatusKey,
+  getWizardStepAgentStatus,
+} from '../helpers/status';
 import { filterByHostname } from '../../../common/components/hosts/utils';
-import { agentStatus, bmhStatus } from '../helpers/agentStatus';
+import { agentStatus } from '../helpers/agentStatus';
 import noop from 'lodash-es/noop.js';
 import { useTranslation } from '../../../common/hooks/use-translation-wrapper';
 import { TFunction } from 'i18next';
 import { AgentMachineK8sResource } from '../Hypershift/types';
 import { Host } from '@openshift-assisted/types/assisted-installer-service';
+import { HostStatus } from '../../../common/components/hosts/types';
 
 export const agentHostnameColumn = (
   t: TFunction,
@@ -117,7 +124,9 @@ export const discoveryTypeColumn = (
 
 type AgentStatusColumnProps = {
   agents: AgentK8sResource[];
+  agentStatuses: HostStatus<string>;
   bareMetalHosts?: BareMetalHostK8sResource[];
+  bmhStatuses?: HostStatus<string>;
   onEditHostname?: AgentTableActions['onEditHost'];
   onApprove?: AgentTableActions['onApprove'];
   wizardStepId?: ClusterDeploymentWizardStepsType;
@@ -127,7 +136,9 @@ type AgentStatusColumnProps = {
 
 export const agentStatusColumn = ({
   agents,
+  agentStatuses,
   bareMetalHosts,
+  bmhStatuses,
   onEditHostname,
   onApprove,
   wizardStepId,
@@ -158,8 +169,8 @@ export const agentStatusColumn = ({
             isDay2={isDay2}
           />
         );
-      } else if (bmh) {
-        bmhStatus = getBMHStatus(bmh);
+      } else if (bmh && bmhStatuses) {
+        bmhStatus = getBMHStatus(bmh, bmhStatuses);
         title = <BMHStatus bmhStatus={bmhStatus} />;
       }
 
@@ -169,7 +180,7 @@ export const agentStatusColumn = ({
         sortableValue: agent
           ? wizardStepId
             ? getWizardStepAgentStatus(agent, wizardStepId, t).status.title
-            : getAgentStatus(agent).status.title
+            : getAgentStatus(agent, agentStatuses).status.title
           : bmhStatus?.state.title || '',
       };
     },
@@ -254,11 +265,7 @@ export const infraEnvColumn = (agents: AgentK8sResource[], t: TFunction): TableR
 };
 
 export const canEditBMH = (bmh: BareMetalHostK8sResource, t: TFunction): ActionCheck => {
-  const canEdit = [
-    bmhStatus.deprovisioning.key,
-    bmhStatus.pending.key,
-    bmhStatus.registering.key,
-  ].includes(getBMHStatus(bmh).state.key);
+  const canEdit = ['deprovisioning', 'pending', 'registering'].includes(getBMHStatusKey(bmh) || '');
 
   return [
     canEdit,
@@ -270,8 +277,12 @@ export const canEditBMH = (bmh: BareMetalHostK8sResource, t: TFunction): ActionC
   ];
 };
 
-export const canEditAgent = (agent: AgentK8sResource, t: TFunction): ActionCheck => {
-  const enabled = getAgentStatus(agent).status.category !== 'Installation related';
+export const canEditAgent = (
+  agent: AgentK8sResource,
+  agentStatuses: HostStatus<string>,
+  t: TFunction,
+): ActionCheck => {
+  const enabled = getAgentStatus(agent, agentStatuses).status.category !== 'Installation related';
   return [
     enabled,
     enabled
@@ -283,13 +294,14 @@ export const canEditAgent = (agent: AgentK8sResource, t: TFunction): ActionCheck
 export const canChangeHostname =
   (
     agents: AgentK8sResource[],
+    agentStatuses: HostStatus<string>,
     bareMetalHosts: BareMetalHostK8sResource[],
     t: TFunction,
   ): ((h: Host) => ActionCheck) =>
   (h: Host) => {
     const agent = agents.find((a) => a.metadata?.uid === h.id);
     if (agent) {
-      return canEditAgent(agent, t);
+      return canEditAgent(agent, agentStatuses, t);
     }
     const bmh = bareMetalHosts.find((bmh) => bmh.metadata?.uid === h.id);
     if (bmh) {
@@ -307,7 +319,7 @@ export const canUnbindAgent = (
     return [false, t('ai:The agent is not bound to a cluster.')];
   }
 
-  const { status } = getAgentStatus(agent);
+  const statusKey = getAgentStatusKey(agent);
   if (
     [
       'preparing-for-installation',
@@ -315,13 +327,13 @@ export const canUnbindAgent = (
       'installing-in-progress',
       'installing-pending-user-action',
       'resetting-pending-user-action',
-    ].includes(status.key)
+    ].includes(statusKey)
   ) {
     return [false, t('ai:It is not possible to remove a host which is being installed.')];
   }
 
   if (
-    ['installed', 'error', 'cancelled'].includes(status.key) &&
+    ['installed', 'error', 'cancelled'].includes(statusKey) &&
     (agent.status?.role === 'master' || agent.status?.role === 'bootstrap')
   ) {
     return [
@@ -343,11 +355,23 @@ export const canUnbindAgent = (
     }
   }
 
+  if (
+    !agent.metadata?.labels?.hasOwnProperty(AGENT_BMH_NAME_LABEL_KEY) &&
+    agent.metadata?.labels?.hasOwnProperty(INFRAENV_GENERATED_AI_FLOW) &&
+    !!agent.spec.clusterDeploymentName
+  ) {
+    return [false, t('ai:It is not possible to remove this node from the cluster.')];
+  }
+
   return [true, undefined];
 };
 
-const canDeleteAgent = (agent: AgentK8sResource, t: TFunction): ActionCheck => {
-  const enabled = getAgentStatus(agent).status.category !== 'Installation related';
+const canDeleteAgent = (
+  agent: AgentK8sResource,
+  agentStatuses: HostStatus<string>,
+  t: TFunction,
+): ActionCheck => {
+  const enabled = getAgentStatus(agent, agentStatuses).status.category !== 'Installation related';
 
   return [
     enabled,
@@ -378,6 +402,7 @@ export const useAgentsTable = (
     onSetInstallationDiskId,
   } = tableActions || {};
   const { t } = useTranslation();
+  const agentStatuses = agentStatus(t);
   const [hosts, actions] = React.useMemo(
     (): [Host[], HostsTableActions] => [
       getAIHosts(agents, bmhs, infraEnv),
@@ -400,7 +425,7 @@ export const useAgentsTable = (
           if (!agent) {
             return false;
           }
-          return canEditAgent(agent, t);
+          return canEditAgent(agent, agentStatuses, t);
         },
         onDeleteHost: onDeleteHost
           ? (host: Host) => {
@@ -414,7 +439,7 @@ export const useAgentsTable = (
           const bmh = bmhs?.find((a) => a.metadata?.uid === host.id);
 
           if (agent) {
-            return canDeleteAgent(agent, t);
+            return canDeleteAgent(agent, agentStatuses, t);
           } else if (bmh) {
             return [true, undefined];
           }
@@ -480,6 +505,7 @@ export const useAgentsTable = (
     ],
     [
       agents,
+      t,
       bmhs,
       infraEnv,
       onEditHost,
@@ -489,7 +515,7 @@ export const useAgentsTable = (
       onSelect,
       onEditBMH,
       onUnbindHost,
-      t,
+      agentStatuses,
       agentClusterInstalls,
     ],
   );
@@ -500,14 +526,15 @@ export const useAgentsTable = (
 const filterByStatus = (
   hosts: Host[],
   agents: AgentK8sResource[],
+  agentStatuses: HostStatus<string>,
   bareMetalHosts: BareMetalHostK8sResource[],
   statusFilter: string[],
 ) => {
   if (!statusFilter?.length) {
     return hosts;
   }
-  const statusKeys = Object.keys(agentStatus).filter((k) =>
-    statusFilter.includes(agentStatus[k].title),
+  const statusKeys = Object.keys(agentStatuses).filter((k) =>
+    statusFilter.includes(agentStatuses[k].title),
   );
   return hosts.filter((h) => {
     const agent = agents.find((a) => a.metadata?.uid === h.id);
@@ -516,10 +543,9 @@ const filterByStatus = (
       if (!bmh) {
         return false;
       }
-      const bmhStatus = getBMHStatus(bmh);
-      return statusKeys.includes(bmhStatus.state.key);
+      return statusKeys.includes(getBMHStatusKey(bmh) || '');
     }
-    const { status } = getAgentStatus(agent);
+    const { status } = getAgentStatus(agent, agentStatuses);
     return statusKeys.includes(status.key);
   });
 };
@@ -527,44 +553,60 @@ const filterByStatus = (
 export const filterHosts = (
   hosts: Host[],
   agents: AgentK8sResource[],
+  agentStatuses: HostStatus<string>,
   bareMetalHosts: BareMetalHostK8sResource[],
   hostnameFilter: string | undefined,
   statusFilter: string[],
 ) => {
   const byHostname = filterByHostname(hosts, hostnameFilter);
-  const byStatus = filterByStatus(byHostname, agents, bareMetalHosts, statusFilter);
+  const byStatus = filterByStatus(byHostname, agents, agentStatuses, bareMetalHosts, statusFilter);
 
   return byStatus;
 };
 
 type UseAgentsFilterArgs = {
   agents: AgentK8sResource[];
+  agentStatuses: HostStatus<string>;
   bmhs: BareMetalHostK8sResource[];
+  bmhStatuses: HostStatus<string>;
   hosts: Host[];
 };
 
 export type StatusCount = Record<string, number>;
 
-export const useAgentsFilter = ({ agents, bmhs, hosts }: UseAgentsFilterArgs) => {
+export const useAgentsFilter = ({
+  agents,
+  agentStatuses,
+  bmhs,
+  bmhStatuses,
+  hosts,
+}: UseAgentsFilterArgs) => {
   const [hostnameFilter, setHostnameFilter] = React.useState<string>();
   const [statusFilter, setStatusFilter] = React.useState<string[]>([]);
   const statusCount = Object.keys(agentStatus).reduce((acc, curr) => {
-    acc[agentStatus[curr].title] = 0;
+    acc[agentStatuses[curr].title] = 0;
     return acc;
   }, {} as StatusCount);
   hosts.forEach((host) => {
     const agent = agents.find((a) => a.metadata?.uid === host.id);
     const bmh = bmhs.find((bmh) => bmh.metadata?.uid === host.id);
     if (agent) {
-      const { status } = getAgentStatus(agent);
+      const { status } = getAgentStatus(agent, agentStatuses);
       statusCount[status.title]++;
     } else if (bmh) {
-      const { state } = getBMHStatus(bmh);
+      const { state } = getBMHStatus(bmh, bmhStatuses);
       statusCount[state.title]++;
     }
   });
 
-  const filteredHosts = filterHosts(hosts, agents, bmhs, hostnameFilter, statusFilter);
+  const filteredHosts = filterHosts(
+    hosts,
+    agents,
+    agentStatuses,
+    bmhs,
+    hostnameFilter,
+    statusFilter,
+  );
 
   return {
     statusCount,

package/lib/cim/components/ClusterDeployment/ClusterDeploymentDetailsTable.tsx

@@ -13,6 +13,7 @@ import {
 import HostsTable, { DefaultExpandComponent } from '../../../common/components/hosts/HostsTable';
 import { usePagination } from '../../../common/components/hosts/usePagination';
 import { useTranslation } from '../../../common/hooks/use-translation-wrapper';
+import { agentStatus } from '../helpers/agentStatus';
 
 export const getAgentId = (agent: AgentK8sResource) => agent.metadata?.uid as string;
 
@@ -39,12 +40,14 @@ const ClusterDeploymentDetailsTable: React.FC<ClusterDeploymentDetailsTableProps
   const agentClusterInstalls = React.useMemo(() => [agentClusterInstall], [agentClusterInstall]);
   const [hosts, , actionResolver] = useAgentsTable({ agents, agentClusterInstalls });
   const { t } = useTranslation();
+  const agentStatuses = agentStatus(t);
   const content = React.useMemo(
     () => [
       hostnameColumn(t),
       roleColumn(t),
       agentStatusColumn({
         agents,
+        agentStatuses,
         t,
       }),
       infraEnvColumn(agents, t),
@@ -52,7 +55,7 @@ const ClusterDeploymentDetailsTable: React.FC<ClusterDeploymentDetailsTableProps
       memoryColumn(t),
       disksColumn(t),
     ],
-    [agents, t],
+    [agentStatuses, agents, t],
   );
 
   const paginationProps = usePagination(agents.length);

package/lib/cim/components/ClusterDeployment/ClusterDeploymentHostDiscoveryTable.tsx

@@ -34,6 +34,7 @@ import { usePagination } from '../../../common/components/hosts/usePagination';
 import { useTranslation } from '../../../common/hooks/use-translation-wrapper';
 import { ExpandComponent } from '../Agent/AgentsSelectionTable';
 import { HostsTableDetailContextProvider } from '../../../common/components/hosts/HostsTableDetailContext';
+import { agentStatus, bmhStatus } from '../helpers/agentStatus';
 
 const ClusterDeploymentHostDiscoveryTable: React.FC<ClusterDeploymentHostDiscoveryTableProps> = ({
   agents,
@@ -53,7 +54,11 @@ const ClusterDeploymentHostDiscoveryTable: React.FC<ClusterDeploymentHostDiscove
   const [isMassChangeHostOpen, setMassChangeHostOpen] = React.useState(false);
   const [isMassApproveOpen, setMassApproveOpen] = React.useState(false);
   const [selectedHostIDs, setSelectedHostIDs] = React.useState<string[]>([]);
+
   const { t } = useTranslation();
+  const agentStatuses = agentStatus(t);
+  const bmhStatuses = bmhStatus(t);
+
   const onSelect = (host: Host, isSelected: boolean) => {
     if (isSelected) {
       setSelectedHostIDs([...selectedHostIDs, host.id]);
@@ -79,7 +84,9 @@ const ClusterDeploymentHostDiscoveryTable: React.FC<ClusterDeploymentHostDiscove
       ...(addAll ? [discoveryTypeColumn(agents, bareMetalHosts, t)] : []),
       agentStatusColumn({
         agents,
+        agentStatuses,
         bareMetalHosts,
+        bmhStatuses,
         onEditHostname: onEditHost,
         onApprove,
         wizardStepId: 'hosts-discovery',
@@ -90,7 +97,19 @@ const ClusterDeploymentHostDiscoveryTable: React.FC<ClusterDeploymentHostDiscove
         ? [discoveredAtColumn(t), cpuCoresColumn(t), memoryColumn(t), disksColumn(t)]
         : []),
     ],
-    [agents, hostActions, bareMetalHosts, onApprove, onEditHost, addAll, t],
+    [
+      t,
+      hostActions.onEditHost,
+      hostActions.canEditRole,
+      hostActions.onEditRole,
+      addAll,
+      agents,
+      bareMetalHosts,
+      agentStatuses,
+      bmhStatuses,
+      onEditHost,
+      onApprove,
+    ],
   );
 
   const selectedAgents = agents.filter((a) => selectedHostIDs.includes(a.metadata?.uid || ''));
@@ -168,7 +187,7 @@ const ClusterDeploymentHostDiscoveryTable: React.FC<ClusterDeploymentHostDiscove
           selectedHostIDs={selectedHostIDs}
           onChangeHostname={onAgentChangeHostname}
           onClose={() => setMassChangeHostOpen(false)}
-          canChangeHostname={canChangeHostname(agents, bareMetalHosts, t)}
+          canChangeHostname={canChangeHostname(agents, agentStatuses, bareMetalHosts, t)}
         />
       )}
       {isMassApproveOpen && (

package/lib/cim/components/ClusterDeployment/ClusterDeploymentHostsNetworkTable.tsx

@@ -20,6 +20,7 @@ import {
 import { usePagination } from '../../../common/components/hosts/usePagination';
 import { useTranslation } from '../../../common/hooks/use-translation-wrapper';
 import { Host } from '@openshift-assisted/types/assisted-installer-service';
+import { agentStatus } from '../helpers/agentStatus';
 
 type ExpandComponentContextType = {
   onSetInstallationDiskId?: ClusterDeploymentHostsNetworkTableProps['onSetInstallationDiskId'];
@@ -79,6 +80,7 @@ const ClusterDeploymentHostsNetworkTable: React.FC<ClusterDeploymentHostsNetwork
       onSetInstallationDiskId,
     }) => {
       const { t } = useTranslation();
+      const agentStatuses = agentStatus(t);
       const cluster = React.useMemo(
         () => getAICluster({ clusterDeployment, agentClusterInstall, agents }),
         [clusterDeployment, agentClusterInstall, agents],
@@ -100,24 +102,37 @@ const ClusterDeploymentHostsNetworkTable: React.FC<ClusterDeploymentHostsNetwork
                 hostnameColumn(t, hostActions.onEditHost, hosts),
                 agentStatusColumn({
                   agents,
+                  agentStatuses,
                   onEditHostname: onEditHost,
                   wizardStepId: 'networking',
                   t,
                 }),
-                activeNICColumn(cluster),
+                activeNICColumn(cluster, t),
               ]
             : [
                 hostnameColumn(t, hostActions.onEditHost, hosts),
                 roleColumn(t, hostActions.canEditRole, hostActions.onEditRole),
                 agentStatusColumn({
                   agents,
+                  agentStatuses,
                   onEditHostname: onEditHost,
                   wizardStepId: 'networking',
                   t,
                 }),
-                activeNICColumn(cluster),
+                activeNICColumn(cluster, t),
               ],
-        [isSNOCluster, onEditHost, hosts, agents, hostActions, cluster, t],
+        [
+          isSNOCluster,
+          t,
+          hostActions.onEditHost,
+          hostActions.canEditRole,
+          hostActions.onEditRole,
+          hosts,
+          agents,
+          agentStatuses,
+          onEditHost,
+          cluster,
+        ],
       );
 
       const paginationProps = usePagination(hosts.length);

package/lib/cim/components/Hypershift/HostedClusterWizard/HostsStep/HostsForm.tsx

@@ -1,10 +1,10 @@
 import * as React from 'react';
 import { FieldArray, useFormikContext } from 'formik';
 import { PlusCircleIcon } from '@patternfly/react-icons';
-import { Alert, Button, Form, Grid, GridItem } from '@patternfly/react-core';
+import { Alert, Button, Form, FormGroup, Grid, GridItem } from '@patternfly/react-core';
 
 import { useTranslation } from '../../../../../common/hooks/use-translation-wrapper';
-import { PopoverIcon, SelectField } from '../../../../../common';
+import { PopoverIcon, RadioField, SelectField } from '../../../../../common';
 import { getRandomString } from '../../../../../common/utils';
 import { useTemptiflySync } from '../../hooks/useTemptiflySync';
 
@@ -42,6 +42,39 @@ const HostsForm: React.FC<HostsFormProps> = ({
   return (
     <Form>
       <Grid hasGutter>
+        <GridItem>
+          <FormGroup isInline label={<>{t('ai:Controller availability policy')}</>} isRequired>
+            <RadioField
+              name={'controllerAvailabilityPolicy'}
+              label={
+                <>
+                  {t('ai:Highly available')}{' '}
+                  <PopoverIcon
+                    bodyContent={t(
+                      'ai:Highly available means components should be resilient to problems across fault boundaries as defined by the component to which the policy is attached. This usually means running critical workloads with 3 replicas and with little or no toleration of disruption of the component.',
+                    )}
+                  />
+                </>
+              }
+              value={'HighlyAvailable'}
+            />
+            <RadioField
+              name={'controllerAvailabilityPolicy'}
+              label={
+                <>
+                  {t('ai:Single replica')}{' '}
+                  <PopoverIcon
+                    bodyContent={t(
+                      'ai:Single replica means components are not expected to be resilient to problems across most fault boundaries associated with high availability. This usually means running critical workloads with just 1 replica and with toleration of full disruption of the component.',
+                    )}
+                  />
+                </>
+              }
+              value={'SingleReplica'}
+            />
+          </FormGroup>
+        </GridItem>
+
         <GridItem>
           <SelectField
             label={t('ai:Namespace')}

package/lib/cim/components/Hypershift/HostedClusterWizard/HostsStep/HostsStep.tsx

@@ -51,6 +51,7 @@ const HostsStep: React.FC<HostsStepProps> = ({
   initNodePools,
   initReleaseImage,
   nodePools,
+  controllerAvailabilityPolicy,
 }) => {
   const { t } = useTranslation();
   const availableAgents = getAgentsForSelection(agents);
@@ -73,6 +74,7 @@ const HostsStep: React.FC<HostsStepProps> = ({
       <StackItem>
         <Formik<HostsFormValues>
           initialValues={{
+            controllerAvailabilityPolicy: controllerAvailabilityPolicy || 'HighlyAvailable',
             agentNamespace: initInfraEnv || infraEnvsWithAgents[0]?.metadata?.namespace || '',
             nodePools: initNodePools || [
               {

package/lib/cim/components/Hypershift/HostedClusterWizard/HostsStep/types.ts

@@ -14,6 +14,7 @@ export type NodePoolFormValue = {
 };
 
 export type HostsFormValues = {
+  controllerAvailabilityPolicy: string;
   agentNamespace: string;
   nodePools: NodePoolFormValue[];
 };
@@ -33,4 +34,5 @@ export type HostsStepProps = {
   initInfraEnv?: string;
   initNodePools?: NodePoolFormValue[];
   nodePools: NodePoolK8sResource[];
+  controllerAvailabilityPolicy: string;
 };

package/lib/cim/components/Hypershift/utils/status.tsx

@@ -9,6 +9,7 @@ import { AgentK8sResource } from '../../../types';
 import { getAgentStatus } from '../../helpers';
 import { NodePoolK8sResource } from '../types';
 import { TFunction } from 'i18next';
+import { agentStatus } from '../../helpers/agentStatus';
 
 export type NodePoolStatus = {
   type: 'error' | 'pending' | 'ok' | 'warning';
@@ -31,7 +32,8 @@ export const getNodePoolStatus = (
     };
   }
 
-  const agentStatuses = agents.map((a) => getAgentStatus(a));
+  const allAgentStatuses = agentStatus(t);
+  const agentStatuses = agents.map((a) => getAgentStatus(a, allAgentStatuses));
 
   const hasErrorAgents = agentStatuses.some(({ status }) => status.key === 'error');
 

package/lib/cim/components/InfraEnv/InfraEnvAgentTable.tsx

@@ -37,6 +37,7 @@ import MassApproveAction from '../modals/MassApproveAction';
 import { usePagination } from '../../../common/components/hosts/usePagination';
 import InfraTableToolbar from './InfraTableToolbar';
 import { useTranslation } from '../../../common/hooks/use-translation-wrapper';
+import { agentStatus, bmhStatus } from '../helpers/agentStatus';
 
 type NoFilterMatchStateProps = {
   onClearFilters: VoidFunction;
@@ -107,6 +108,8 @@ const InfraEnvAgentTable: React.FC<InfraEnvAgentTableProps> = ({
     },
   );
   const { t } = useTranslation();
+  const agentStatuses = agentStatus(t);
+  const bmhStatuses = bmhStatus(t);
   const {
     statusCount,
     hostnameFilter,
@@ -114,7 +117,13 @@ const InfraEnvAgentTable: React.FC<InfraEnvAgentTableProps> = ({
     setStatusFilter,
     statusFilter,
     filteredHosts: hosts,
-  } = useAgentsFilter({ agents, bmhs: bareMetalHosts, hosts: allHosts });
+  } = useAgentsFilter({
+    agents,
+    agentStatuses,
+    bmhs: bareMetalHosts,
+    bmhStatuses,
+    hosts: allHosts,
+  });
 
   const content = React.useMemo(
     () =>
@@ -131,6 +140,7 @@ const InfraEnvAgentTable: React.FC<InfraEnvAgentTableProps> = ({
         discoveryTypeColumn(agents, bareMetalHosts, t),
         agentStatusColumn({
           agents,
+          agentStatuses,
           bareMetalHosts,
           onEditHostname: onEditHost,
           onApprove: onApprove,
@@ -143,15 +153,18 @@ const InfraEnvAgentTable: React.FC<InfraEnvAgentTableProps> = ({
         disksColumn(t),
       ].filter(Boolean),
     [
+      t,
       hosts,
       agents,
-      agentMachines,
+      bareMetalHosts,
+      hostActions.onEditHost,
+      hostActions.canEditHostname,
+      hostActions.canEditBMH,
+      agentStatuses,
       onEditHost,
       onApprove,
+      agentMachines,
       getClusterDeploymentLink,
-      hostActions,
-      bareMetalHosts,
-      t,
     ],
   );
 
@@ -162,7 +175,7 @@ const InfraEnvAgentTable: React.FC<InfraEnvAgentTableProps> = ({
 
   const canEditHostname =
     selectedBMHs.some((bmh) => canEditBMH(bmh, t)[0]) ||
-    selectedAgents.some((a) => canEditAgent(a, t)[0]);
+    selectedAgents.some((a) => canEditAgent(a, agentStatuses, t)[0]);
 
   const massActions = [
     <DropdownItem
@@ -252,7 +265,7 @@ const InfraEnvAgentTable: React.FC<InfraEnvAgentTableProps> = ({
           selectedHostIDs={selectedHostIDs}
           onChangeHostname={onAgentChangeHostname}
           onClose={() => setMassChangeHostOpen(false)}
-          canChangeHostname={canChangeHostname(agents, bareMetalHosts, t)}
+          canChangeHostname={canChangeHostname(agents, agentStatuses, bareMetalHosts, t)}
         />
       )}
       {isMassDeleteOpen && (

package/lib/cim/components/InfraEnv/InfraEnvHostsTabAgentsWarning.tsx

@@ -6,6 +6,7 @@ import { AgentK8sResource, BareMetalHostK8sResource } from '../../types';
 import { AGENT_BMH_NAME_LABEL_KEY } from '../common';
 import { Tooltip } from '@patternfly/react-core';
 import { useTranslation } from '../../../common/hooks/use-translation-wrapper';
+import { agentStatus, bmhStatus } from '../helpers/agentStatus';
 
 export type InfraEnvHostsTabAgentsWarning = {
   infraAgents: AgentK8sResource[];
@@ -26,9 +27,11 @@ const InfraEnvHostsTabAgentsWarning: React.FC<InfraEnvHostsTabAgentsWarning> = (
   const bmhsWithoutAgents = infraBMHs.filter((bmh) =>
     agentsBMHNames.includes(bmh.metadata?.name || ''),
   );
+  const agentStatuses = agentStatus(t);
+  const bmhStatuses = bmhStatus(t);
 
-  const agentStates = infraAgents.map((agent) => getAgentStatus(agent, true).status);
-  const bmhStates = bmhsWithoutAgents.map((bmh) => getBMHStatus(bmh).state);
+  const agentStates = infraAgents.map((agent) => getAgentStatus(agent, agentStatuses, true).status);
+  const bmhStates = bmhsWithoutAgents.map((bmh) => getBMHStatus(bmh, bmhStatuses).state);
 
   const hostStates = [...agentStates, ...bmhStates];