@openshift-assisted/ui-lib 2.17.4-cim → 2.18.1-cim

package/lib/cim/components/modals/CimConfiguration/persist.ts

@@ -4,8 +4,8 @@ import {
   k8sListItems,
   k8sPatch,
   K8sResourceCommon,
+  Patch,
 } from '@openshift-console/dynamic-plugin-sdk';
-import { AlertVariant } from '@patternfly/react-core';
 import { TFunction } from 'i18next';
 import { getErrorMessage } from '../../../../common/utils';
 
@@ -13,42 +13,21 @@ import {
   AgentServiceConfigK8sResource,
   AgentServiceConfigModel,
   IngressControllerModel,
-  K8sPatch,
   ProvisioningModel,
   RouteK8sResource,
   RouteModel,
 } from '../../../types';
-import { LOCAL_STORAGE_ID_LAST_UPDATE_TIMESTAMP } from './utils';
 import { appendPatch } from '../../../utils';
-
-export type SetErrorFuncType = ({
-  title,
-  message,
-  variant,
-}: {
-  title: string;
-  message?: string;
-  variant?: AlertVariant;
-}) => void;
+import { CimConfigurationValues } from './types';
 
 const ASSISTED_IMAGE_SERVICE_ROUTE_PREFIX = 'assisted-image-service-multicluster-engine';
 
-// Since we do not know MCE's namespace, query all routes,
-// Find assisted-image-service's one and parse domain from there.
-const getAssistedImageServiceRoute = async (
-  t: TFunction,
-  setError: SetErrorFuncType,
-): Promise<RouteK8sResource | undefined> => {
+const getAssistedImageServiceRoute = async (t: TFunction): Promise<RouteK8sResource> => {
   let allRoutes: RouteK8sResource[] = [];
   try {
     allRoutes = await k8sListItems({ model: RouteModel, queryParams: {} });
   } catch (e) {
-    // console.error('Failed to read all routes: ', allRoutes);
-    setError({
-      title: t('ai:Failed to save configuration'),
-      message: t('ai:Can not query routes.'),
-    });
-    return undefined;
+    throw new Error(`${t('ai:Failed to save configuration')}: ${getErrorMessage(e)}`);
   }
 
   const assistedImageServiceRoute = allRoutes?.find(
@@ -56,54 +35,41 @@ const getAssistedImageServiceRoute = async (
   );
 
   if (!assistedImageServiceRoute?.spec?.host) {
-    setError({
-      title: t('ai:Failed to save configuration'),
-      message: t('ai:Can not find host of the assisted-image-service route'),
-    });
-    return undefined;
+    throw new Error(
+      `${t('ai:Failed to save configuration')}: ${t(
+        'ai:Can not find host of the assisted-image-service route',
+      )}`,
+    );
   }
 
   return assistedImageServiceRoute;
 };
 
-// There are many ways how to get the domain name, let's follow the documentation.
-const getClusterDomain = (
-  t: TFunction,
-  setError: SetErrorFuncType,
-  assistedImageServiceRoute: RouteK8sResource,
-): string | undefined => {
+const getClusterDomain = (t: TFunction, assistedImageServiceRoute: RouteK8sResource) => {
   const prefix = `${ASSISTED_IMAGE_SERVICE_ROUTE_PREFIX}.`;
   const host: string = assistedImageServiceRoute.spec?.host || '';
   const appsDomain = host.substring(host.indexOf(prefix) + prefix.length);
 
-  // the appsDomain can be prefixed either by "apps." or "nlb-apps." so search for first dot
   const domain = appsDomain.substring(appsDomain.indexOf('.') + 1);
 
   if (!domain) {
-    // It must be present
-    // console.error('Can not find domain in assistedImageServiceRoute: ', assistedImageServiceRoute);
-    setError({
-      title: t('ai:Can not find cluster domain.'),
-    });
+    throw new Error(t('ai:Can not find cluster domain.'));
   }
 
   return domain;
 };
 
-// Keep this function in sync with getClusterDomain()
 const patchAssistedImageServiceRoute = async (
   t: TFunction,
-  setError: SetErrorFuncType,
-
   assistedImageServiceRoute: RouteK8sResource,
   domain: string,
-): Promise<boolean> => {
+) => {
   const newHost = `${ASSISTED_IMAGE_SERVICE_ROUTE_PREFIX}.nlb-apps.${domain}`;
 
   const labels = assistedImageServiceRoute.metadata?.labels || {};
   labels['router-type'] = 'nlb';
 
-  const patches = [
+  const patches: Patch[] = [
     {
       op: 'replace',
       path: '/spec/host',
@@ -123,38 +89,28 @@ const patchAssistedImageServiceRoute = async (
       data: patches,
     });
   } catch (e) {
-    // console.error('Failed to patch assisted-image-service route: ', e, patches);
-    setError({
-      title: t('ai:Failed to patch assisted-image-service route for new domain.'),
-    });
-    return false;
+    throw new Error(
+      `${t('ai:Failed to patch assisted-image-service route for new domain.')}: ${getErrorMessage(
+        e,
+      )}`,
+    );
   }
-
-  return true;
 };
 
-export const isIngressController = async (): Promise<boolean> => {
+export async function isIngressController() {
   try {
     await k8sGet({
       name: 'ingress-controller-with-nlb',
       ns: 'openshift-ingress-operator',
       model: IngressControllerModel,
     });
-
     return true;
   } catch {
     return false;
   }
-};
-
-const createIngressController = async (
-  t: TFunction,
-  setError: SetErrorFuncType,
-
-  domain: string,
-): Promise<boolean> => {
-  // Assumption: the IngressController resource is not present - ensured at higher level
+}
 
+const createIngressController = async (t: TFunction, domain: string) => {
   const ingressController = {
     apiVersion: 'operator.openshift.io/v1',
     kind: 'IngressController',
@@ -186,71 +142,45 @@ const createIngressController = async (
 
   try {
     await k8sCreate({ model: IngressControllerModel, data: ingressController });
-    return true;
   } catch (e) {
-    // console.error('Create IngressController error: ', e);
-    setError({
-      title: t('ai:Failed to create IngressController'),
-    });
+    throw new Error(`${t('ai:Failed to create IngressController')}: ${getErrorMessage(e)}`);
   }
-
-  return false;
 };
 
-const patchProvisioningConfiguration = async ({
-  t,
-  setError,
-}: {
-  t: TFunction;
-  setError: SetErrorFuncType;
-}) => {
-  try {
-    const provisioning = await k8sGet<
-      K8sResourceCommon & { spec?: { watchAllNamespaces?: boolean } }
-    >({
-      model: ProvisioningModel,
-      name: 'provisioning-configuration',
-    });
-
-    const patches = [
-      {
-        op: provisioning.spec?.watchAllNamespaces ? 'replace' : 'add',
-        path: '/spec/watchAllNamespaces',
-        value: true,
-      },
-    ];
+export const patchProvisioning = async () => {
+  const provisioning = await k8sGet<
+    K8sResourceCommon & { spec?: { watchAllNamespaces?: boolean } }
+  >({
+    model: ProvisioningModel,
+    name: 'provisioning-configuration',
+  });
 
-    await k8sPatch({
-      model: ProvisioningModel,
-      resource: provisioning,
-      data: patches,
-    });
-  } catch (e) {
-    // console.error('Failed to patch provisioning-configuration: ', e);
-    setError({
-      title: t('ai:Failed to configure provisioning to enable registering hosts via BMC.'),
-      message: getErrorMessage(e),
-      variant: AlertVariant.warning,
-    });
+  if (provisioning.spec?.watchAllNamespaces) {
+    return;
   }
+
+  const patches = [
+    {
+      op: provisioning.spec?.watchAllNamespaces === false ? 'replace' : 'add',
+      path: '/spec/watchAllNamespaces',
+      value: true,
+    },
+  ];
+
+  await k8sPatch({
+    model: ProvisioningModel,
+    resource: provisioning,
+    data: patches,
+  });
 };
 
-const createAgentServiceConfig = async ({
+export const createAgentServiceConfig = async ({
   t,
-  setError,
-  dbVolSizeGiB,
-  fsVolSizeGiB,
-  imgVolSizeGiB,
-  ciscoIntersightURL,
+  values,
 }: {
   t: TFunction;
-  setError: SetErrorFuncType;
-
-  dbVolSizeGiB: number;
-  fsVolSizeGiB: number;
-  imgVolSizeGiB: number;
-  ciscoIntersightURL?: string;
-}): Promise<boolean> => {
+  values: CimConfigurationValues;
+}) => {
   try {
     const agentServiceConfig = {
       apiVersion: 'agent-install.openshift.io/v1beta1',
@@ -264,7 +194,7 @@ const createAgentServiceConfig = async ({
           accessModes: ['ReadWriteOnce'],
           resources: {
             requests: {
-              storage: `${dbVolSizeGiB}Gi`,
+              storage: `${values.dbVolSize}Gi`,
             },
           },
         },
@@ -272,7 +202,7 @@ const createAgentServiceConfig = async ({
           accessModes: ['ReadWriteOnce'],
           resources: {
             requests: {
-              storage: `${fsVolSizeGiB}Gi`,
+              storage: `${values.fsVolSize}Gi`,
             },
           },
         },
@@ -280,17 +210,17 @@ const createAgentServiceConfig = async ({
           accessModes: ['ReadWriteOnce'],
           resources: {
             requests: {
-              storage: `${imgVolSizeGiB}Gi`,
+              storage: `${values.imgVolSize}Gi`,
             },
           },
         },
       },
     };
 
-    if (ciscoIntersightURL) {
+    if (values.ciscoIntersightURL) {
       agentServiceConfig.metadata = {
         ...agentServiceConfig.metadata,
-        annotations: { ciscoIntersightURL },
+        annotations: { ciscoIntersightURL: values.ciscoIntersightURL },
       };
     }
 
@@ -298,99 +228,67 @@ const createAgentServiceConfig = async ({
       model: AgentServiceConfigModel,
       data: agentServiceConfig,
     });
-
-    return true;
   } catch (e) {
-    setError({
-      title: t('ai:Failed to create AgentServiceConfig'),
-      message: getErrorMessage(e),
-    });
-    return false;
+    throw new Error(`${t('ai:Failed to create AgentServiceConfig')}: ${getErrorMessage(e)}`);
   }
 };
 
-// https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes/2.6/html/multicluster_engine/multicluster_engine_overview#enable-cim
-export const onEnableCIM = async ({
+export const editAgentServiceConfig = async ({
   t,
-  setError,
-
   agentServiceConfig,
-  platform,
-
-  dbVolSizeGiB,
-  fsVolSizeGiB,
-  imgVolSizeGiB,
-
-  configureLoadBalancer,
-  ciscoIntersightURL,
+  values,
 }: {
   t: TFunction;
-  setError: SetErrorFuncType;
-
-  agentServiceConfig?: AgentServiceConfigK8sResource;
-  platform: string;
-
-  dbVolSizeGiB: number;
-  fsVolSizeGiB: number;
-  imgVolSizeGiB: number;
-
-  configureLoadBalancer: boolean;
-  ciscoIntersightURL?: string;
+  agentServiceConfig: AgentServiceConfigK8sResource;
+  values: CimConfigurationValues;
 }) => {
-  if (['none', 'baremetal', 'openstack', 'vsphere'].includes(platform.toLocaleLowerCase())) {
-    await patchProvisioningConfiguration({ t, setError });
-  }
-
-  if (!agentServiceConfig) {
-    if (
-      !(await createAgentServiceConfig({
-        t,
-        setError,
-        dbVolSizeGiB,
-        fsVolSizeGiB,
-        imgVolSizeGiB,
-        ciscoIntersightURL,
-      }))
-    ) {
-      return false;
-    }
-  } else {
-    const patches = [] as K8sPatch;
+  const patches: Patch[] = [];
+
+  if (
+    agentServiceConfig.metadata?.annotations?.['ciscoIntersightURL'] &&
+    !values.ciscoIntersightURL
+  ) {
+    patches.push({
+      op: 'remove',
+      path: '/metadata/annotations/ciscoIntersightURL',
+    });
+  } else if (!agentServiceConfig.metadata?.annotations && values.ciscoIntersightURL) {
+    patches.push({
+      op: 'add',
+      path: '/metadata/annotations',
+      value: { ciscoIntersightURL: values.ciscoIntersightURL },
+    });
+  } else if (values.ciscoIntersightURL) {
     appendPatch(
       patches,
       '/metadata/annotations/ciscoIntersightURL',
-      ciscoIntersightURL,
+      values.ciscoIntersightURL,
       agentServiceConfig.metadata?.annotations?.['ciscoIntersightURL'],
     );
-    await k8sPatch({ model: AgentServiceConfigModel, resource: agentServiceConfig, data: patches });
   }
 
-  // see isCIMConfigProgressing()
-  window.localStorage.setItem(LOCAL_STORAGE_ID_LAST_UPDATE_TIMESTAMP, new Date().toISOString());
-
-  if (configureLoadBalancer) {
-    // Recently No to Yes only (since we do not delete the ingress controller)
-    if (await isIngressController()) {
-      return true /* Not an error */;
-    }
-
-    const assistedImageServiceRoute = await getAssistedImageServiceRoute(t, setError);
-    if (!assistedImageServiceRoute) {
-      return false;
-    }
+  if (patches.length === 0) {
+    return;
+  }
 
-    const domain = getClusterDomain(t, setError, assistedImageServiceRoute);
-    if (!domain) {
-      return false;
-    }
+  try {
+    await k8sPatch({
+      model: AgentServiceConfigModel,
+      resource: agentServiceConfig,
+      data: patches,
+    });
+  } catch (e) {
+    throw new Error(`${t('ai:Failed to save configuration')}: ${getErrorMessage(e)}`);
+  }
+};
 
-    if (
-      !(await createIngressController(t, setError, domain)) ||
-      !(await patchAssistedImageServiceRoute(t, setError, assistedImageServiceRoute, domain))
-    ) {
-      return false;
-    }
+export const configureIngressLoadBalancer = async ({ t }: { t: TFunction }) => {
+  if (await isIngressController()) {
+    return;
   }
 
-  return true;
+  const assistedImageServiceRoute = await getAssistedImageServiceRoute(t);
+  const domain = getClusterDomain(t, assistedImageServiceRoute);
+  await createIngressController(t, domain);
+  await patchAssistedImageServiceRoute(t, assistedImageServiceRoute, domain);
 };

package/lib/cim/components/modals/MassApproveAgentModal.tsx

@@ -27,14 +27,15 @@ type ApproveTableRowProps = {
   agent?: AgentK8sResource;
 };
 
-const ApproveTableRow: React.FC<ApproveTableRowProps> = ({ agent, children }) => (
-  <div className={agent?.spec.approved ? 'pf-v6-u-color-200' : undefined}>{children}</div>
-);
+const ApproveTableRow: React.FC<React.PropsWithChildren<ApproveTableRowProps>> = ({
+  agent,
+  children,
+}) => <div className={agent?.spec.approved ? 'pf-v6-u-color-200' : undefined}>{children}</div>;
 
 const hostnameColumn = (agents: AgentK8sResource[], t: TFunction): TableRow<Host> => {
   return {
     header: {
-      title: t('ai:Hostname'),
+      title: t<string>('ai:Hostname'),
       props: {
         id: 'col-header-hostname', // ACM jest tests require id over testId
       },
@@ -59,7 +60,7 @@ const statusColumn = (
 ): TableRow<Host> => {
   return {
     header: {
-      title: t('ai:Status'),
+      title: t<string>('ai:Status'),
       props: {
         id: 'col-header-status', // ACM jest tests require id over testId
       },

package/lib/cim/components/modals/MassDeleteAgentModal.tsx

@@ -30,7 +30,7 @@ import { agentStatus, bmhStatus } from '../helpers/agentStatus';
 const hostnameColumn = (agents: AgentK8sResource[], t: TFunction): TableRow<Host> => {
   return {
     header: {
-      title: t('ai:Hostname'),
+      title: t<string>('ai:Hostname'),
       props: {
         id: 'col-header-hostname', // ACM jest tests require id over testId
       },
@@ -63,7 +63,7 @@ const statusColumn = (
   const bmhStatuses = bmhStatus(t);
   return {
     header: {
-      title: t('ai:Status'),
+      title: t<string>('ai:Status'),
       props: {
         id: 'col-header-status',
       },
@@ -85,17 +85,17 @@ const statusColumn = (
             <FlexItem align={{ default: 'alignRight' }}>
               <Popover
                 aria-label={t('ai:Cluster popover')}
-                headerContent={<div>{t('ai:Cannot be deleted')}</div>}
+                headerContent={<div>{t<string>('ai:Cannot be deleted')}</div>}
                 bodyContent={
                   <div>
-                    {t(
+                    {t<string>(
                       'ai:Hosts that are bound to a cluster cannot be deleted. Remove the host from the cluster and try again.',
                     )}
                   </div>
                 }
                 footerContent={
                   <Link to={`/multicloud/infrastructure/clusters/details/${clusterName}/`}>
-                    {t('ai:Go to cluster {{clusterName}}', { clusterName })}
+                    {t<string>('ai:Go to cluster {{clusterName}}', { clusterName })}
                   </Link>
                 }
               >
@@ -107,7 +107,7 @@ const statusColumn = (
                     </Icon>
                   }
                 >
-                  {t('ai:Cannot be deleted')}
+                  {t<string>('ai:Cannot be deleted')}
                 </Button>
               </Popover>
             </FlexItem>

package/lib/common/api/assisted-service/ClustersAPI.ts

@@ -245,12 +245,6 @@ const ClustersAPI = {
       headers: { 'Content-Type': 'application/json' },
     });
   },
-  registerDisconnected(params: { name: string; openshiftVersion: string }) {
-    return client.post<Cluster, AxiosResponse<Cluster>, { name: string; openshiftVersion: string }>(
-      `${ClustersAPI.makeBaseURI()}disconnected`,
-      params,
-    );
-  },
 };
 
 export default ClustersAPI;

package/lib/common/components/AddHosts/AddHostsContext.tsx

@@ -10,7 +10,7 @@ export type AddHostsContextType = {
 
 export const AddHostsContext = React.createContext<AddHostsContextType>({});
 
-export const AddHostsContextProvider: React.FC<AddHostsContextType> = ({
+export const AddHostsContextProvider: React.FC<React.PropsWithChildren<AddHostsContextType>> = ({
   cluster,
   resetCluster,
   ocpConsoleUrl,

package/lib/common/components/AlertsContextProvider.tsx

@@ -18,7 +18,7 @@ export type AlertsContextType = {
 
 const AlertsContext = React.createContext<AlertsContextType | null>(null);
 
-export const AlertsContextProvider: React.FC = ({ children }) => {
+export const AlertsContextProvider: React.FC<React.PropsWithChildren> = ({ children }) => {
   const [alerts, dispatch] = React.useReducer(alertsReducer, []);
   const context = {
     alerts,

package/lib/common/components/clusterConfiguration/ProxyFields.tsx

@@ -16,6 +16,9 @@ export const ProxyInputFields = () => {
     }
   };
   const { t } = useTranslation();
+  const hasHttp = !!values.httpProxy?.trim();
+  const hasHttps = !!values.httpsProxy?.trim();
+
   return (
     <Grid hasGutter>
       <InputField
@@ -31,6 +34,7 @@ export const ProxyInputFields = () => {
         }
         name="httpProxy"
         placeholder="http://<user>:<password>@<ipaddr>:<port>"
+        isRequired={values.enableProxy && !hasHttps}
         helperText={
           <div>
             <Trans
@@ -54,6 +58,7 @@ export const ProxyInputFields = () => {
         }
         name="httpsProxy"
         placeholder="http://<user>:<password>@<ipaddr>:<port>"
+        isRequired={values.enableProxy && !hasHttp}
         helperText={
           <div>
             <Trans

package/lib/common/components/clusterConfiguration/SecurityFields.tsx

@@ -16,7 +16,7 @@ export const SshPublicKeyHelperText: React.FC<{
   const { t } = useTranslation();
   return (
     <HelperText id={fieldId}>
-      <HelperTextItem data-testid="ssh-public-key-helper-text">
+      <HelperTextItem>
         {allowMultipleKeys
           ? t(
               'ai:Paste the content of public SSH keys you want to use to connect to the hosts into this field. Multiple keys can be separated by newlines.',

package/lib/common/components/clusterWizard/ClusterWizardStepHeader.tsx

@@ -1,8 +1,10 @@
 import React from 'react';
 import { Content } from '@patternfly/react-core';
 
-const ClusterWizardStepHeader: React.FC = ({ children }) => (
-  <Content component="h2">{children}</Content>
+const ClusterWizardStepHeader: React.FC<React.PropsWithChildren> = ({ children }) => (
+  <Content data-testid="step-header" component="h2">
+    {children}
+  </Content>
 );
 
 export default ClusterWizardStepHeader;

package/lib/common/components/clusterWizard/networkingSteps/AvailableSubnetsControl.tsx

@@ -59,6 +59,7 @@ export interface AvailableSubnetsControlProps {
   isViewerMode?: boolean;
   hosts?: Host[];
   isMultiNodeCluster?: boolean;
+  allowSingleStackIPv6?: boolean;
 }
 
 export const AvailableSubnetsControl = ({
@@ -70,6 +71,7 @@ export const AvailableSubnetsControl = ({
   isViewerMode = false,
   hosts,
   isMultiNodeCluster = true,
+  allowSingleStackIPv6 = false,
 }: AvailableSubnetsControlProps) => {
   const { t } = useTranslation();
   const { values, errors, setFieldValue } = useFormikContext<NetworkConfigurationValues>();
@@ -207,7 +209,12 @@ export const AvailableSubnetsControl = ({
     isDualStack && values.machineNetworks && values.machineNetworks.length > 1;
 
   // Determine available subnets for primary dropdown
-  const primaryMachineSubnets = isDualStack && supportsIPv6Primary ? allSubnets : IPv4Subnets;
+  let primaryMachineSubnets: HostSubnet[];
+  if ((isDualStack && supportsIPv6Primary) || (!isDualStack && allowSingleStackIPv6)) {
+    primaryMachineSubnets = allSubnets;
+  } else {
+    primaryMachineSubnets = IPv4Subnets;
+  }
 
   // Determine available subnets for secondary dropdown
   const secondaryMachineSubnets = React.useMemo(() => {

package/lib/common/components/clusterWizard/networkingSteps/NetworkTypeControlGroup.tsx

@@ -2,7 +2,7 @@ import React from 'react';
 import { Split, SplitItem, Tooltip, FormGroup } from '@patternfly/react-core';
 import { RadioField } from '../../ui/formik';
 import { PopoverIcon } from '../../../components/ui';
-import { NETWORK_TYPE_OVN, NETWORK_TYPE_SDN } from '../../../config';
+import { NETWORK_TYPE_OVN, NETWORK_TYPE_SDN } from '../../../types/networkType';
 import { useTranslation } from '../../../hooks/use-translation-wrapper';
 
 const GROUP_NAME = 'networkType';