@opensaas/stack-auth 0.30.0 → 0.31.0

package/.turbo/turbo-build.log

@@ -1,4 +1,4 @@
 
-> @opensaas/stack-auth@0.30.0 build /home/runner/work/stack/stack/packages/auth
+> @opensaas/stack-auth@0.31.0 build /home/runner/work/stack/stack/packages/auth
 > tsc
 

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @opensaas/stack-auth
 
+## 0.31.0
+
+### Patch Changes
+
+- [#772](https://github.com/OpenSaasAU/stack/pull/772) [`be5772b`](https://github.com/OpenSaasAU/stack/commit/be5772be231d5be6a77d80c4f7eff5adc15da2fa) Thanks [@borisno2](https://github.com/borisno2)! - Add a regression test locking the generated Session/Account user FK shape (no `@@index([userId])`, `onDelete: Cascade`) so future drift from better-auth parity is caught.
+
 ## 0.30.0
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@opensaas/stack-auth",
-  "version": "0.30.0",
+  "version": "0.31.0",
   "description": "Better-auth integration for OpenSaas Stack",
   "type": "module",
   "main": "./dist/index.js",
@@ -65,7 +65,8 @@
     "react": "^19.2.4",
     "typescript": "npm:@typescript/typescript6@^6.0.2",
     "vitest": "^4.1.10",
-    "@opensaas/stack-core": "0.30.0"
+    "@opensaas/stack-cli": "0.31.0",
+    "@opensaas/stack-core": "0.31.0"
   },
   "scripts": {
     "build": "tsc",

package/tests/generated-fk-shape.test.ts

@@ -0,0 +1,81 @@
+import { describe, it, expect } from 'vitest'
+import { config, list } from '@opensaas/stack-core'
+import { text, relationship } from '@opensaas/stack-core/fields'
+import type { OpenSaasConfig } from '@opensaas/stack-core'
+import type { Plugin } from '@opensaas/stack-core/extend'
+import { generatePrismaSchema } from '@opensaas/stack-cli/generator/prisma'
+import { authPlugin } from '../src/config/plugin.js'
+
+/**
+ * Resolve a config through plugin `init` (via `config()`) and each plugin's
+ * `beforeGenerate` hook — the same sequence the CLI generate pipeline runs —
+ * then hand the result to the Prisma generator. Unlike the config-level
+ * assertions in `derive-auth-lists.test.ts` and `plugin-schema-placement.test.ts`,
+ * this exercises the *assembled generated schema text* so the auth FK shape is
+ * locked end-to-end (issue #753).
+ */
+async function generateSchema(userConfig: OpenSaasConfig): Promise<string> {
+  let current = await config(userConfig)
+  const plugins: Plugin[] = current.plugins ?? []
+  for (const plugin of plugins) {
+    if (plugin.beforeGenerate) {
+      current = await plugin.beforeGenerate(current)
+    }
+  }
+  return generatePrismaSchema(current)
+}
+
+/** Slice out a single `model X { ... }` block from generated schema text. */
+function modelBlock(schema: string, modelName: string): string {
+  const start = schema.indexOf(`model ${modelName} {`)
+  if (start === -1) throw new Error(`model ${modelName} not found in generated schema`)
+  const end = schema.indexOf('\n}', start)
+  return schema.slice(start, end === -1 ? undefined : end + 2)
+}
+
+describe('generated auth schema — Session/Account user FK mirrors better-auth (issue #679/#753)', () => {
+  it('emits onDelete: Cascade and omits @@index on Session.user and Account.user', async () => {
+    const schema = await generateSchema({
+      db: { provider: 'sqlite' },
+      plugins: [authPlugin({ emailAndPassword: { enabled: true } })],
+      lists: {},
+    })
+
+    for (const model of ['Session', 'Account']) {
+      const block = modelBlock(schema, model)
+
+      // (a) The user relation carries the cascade referential action. Match on
+      // the whitespace-stable attribute substring rather than the padded line,
+      // since raw generator output and prisma-formatted output differ only in
+      // column alignment.
+      expect(block).toContain('@relation(onDelete: Cascade, fields: [userId], references: [id])')
+
+      // (b) No separate FK index is emitted — parity with better-auth, which
+      // ships no @@index([userId]). This is deliberate (ADR-0007), not a
+      // regression; catching a re-introduced index here flags drift.
+      expect(block).not.toContain('@@index([userId])')
+      expect(block).not.toContain('@@index([user])')
+    }
+  })
+
+  it('still emits the default @@index for a non-auth relationship FK', async () => {
+    // Contrast case: the generic FK-index path is untouched. Only the auth
+    // user relations opt out (via isIndexed: false); an ordinary app
+    // relationship keeps the default Keystone-parity @@index.
+    const schema = await generateSchema({
+      db: { provider: 'sqlite' },
+      plugins: [authPlugin({ emailAndPassword: { enabled: true } })],
+      lists: {
+        Widget: list({
+          fields: {
+            title: text({ validation: { isRequired: true } }),
+            owner: relationship({ ref: 'User' }),
+          },
+        }),
+      },
+    })
+
+    const widget = modelBlock(schema, 'Widget')
+    expect(widget).toContain('@@index([ownerId])')
+  })
+})