@openrewrite/recipes-nodejs 0.35.0-20251120-170459 → 0.35.0-20251121-142457

package/dist/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAEA,OAAO,EAAC,cAAc,EAAC,MAAM,sBAAsB,CAAC;AAUpD,wBAAgB,QAAQ,CAAC,QAAQ,EAAE,cAAc,QAUhD"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAEA,OAAO,EAAC,cAAc,EAAC,MAAM,sBAAsB,CAAC;AAWpD,wBAAgB,QAAQ,CAAC,QAAQ,EAAE,cAAc,QAWhD"}

package/dist/index.js

@@ -10,6 +10,7 @@ const util_extend_1 = require("./migrate/util-extend");
 const crypto_fips_1 = require("./migrate/crypto-fips");
 const slow_buffer_1 = require("./migrate/slow-buffer");
 const fs_access_constants_1 = require("./migrate/fs-access-constants");
+const promisify_on_promise_1 = require("./migrate/promisify-on-promise");
 function activate(registry) {
     registry.register(util_type_checking_1.UseNativeTypeCheckingMethods);
     registry.register(buffer_slice_1.ReplaceDeprecatedBufferSlice);
@@ -20,5 +21,6 @@ function activate(registry) {
     registry.register(crypto_fips_1.ReplaceCryptoFips);
     registry.register(slow_buffer_1.ReplaceSlowBuffer);
     registry.register(fs_access_constants_1.ReplaceFsAccessConstants);
+    registry.register(promisify_on_promise_1.RemovePromisifyOnPromise);
 }
 //# sourceMappingURL=index.js.map

package/dist/index.js.map

@@ -1 +1 @@
-{"version":3,"file":"index.js","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":";;AAYA,4BAUC;AAtBD,qEAA0E;AAC1E,yDAAoE;AAEpE,yEAAwF;AACxF,uEAAwE;AACxE,iDAAkD;AAClD,uDAAwD;AACxD,uDAAwD;AACxD,uDAAwD;AACxD,uEAAuE;AAGvE,SAAgB,QAAQ,CAAC,QAAwB;IAC7C,QAAQ,CAAC,QAAQ,CAAC,iDAA4B,CAAC,CAAC;IAChD,QAAQ,CAAC,QAAQ,CAAC,2CAA4B,CAAC,CAAC;IAChD,QAAQ,CAAC,QAAQ,CAAC,+DAAwC,CAAC,CAAC;IAC5D,QAAQ,CAAC,QAAQ,CAAC,+CAAyB,CAAC,CAAC;IAC7C,QAAQ,CAAC,QAAQ,CAAC,yBAAc,CAAC,CAAC;IAClC,QAAQ,CAAC,QAAQ,CAAC,+BAAiB,CAAC,CAAC;IACrC,QAAQ,CAAC,QAAQ,CAAC,+BAAiB,CAAC,CAAC;IACrC,QAAQ,CAAC,QAAQ,CAAC,+BAAiB,CAAC,CAAC;IACrC,QAAQ,CAAC,QAAQ,CAAC,8CAAwB,CAAC,CAAC;AAChD,CAAC"}
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":";;AAaA,4BAWC;AAxBD,qEAA0E;AAC1E,yDAAoE;AAEpE,yEAAwF;AACxF,uEAAwE;AACxE,iDAAkD;AAClD,uDAAwD;AACxD,uDAAwD;AACxD,uDAAwD;AACxD,uEAAuE;AACvE,yEAAwE;AAGxE,SAAgB,QAAQ,CAAC,QAAwB;IAC7C,QAAQ,CAAC,QAAQ,CAAC,iDAA4B,CAAC,CAAC;IAChD,QAAQ,CAAC,QAAQ,CAAC,2CAA4B,CAAC,CAAC;IAChD,QAAQ,CAAC,QAAQ,CAAC,+DAAwC,CAAC,CAAC;IAC5D,QAAQ,CAAC,QAAQ,CAAC,+CAAyB,CAAC,CAAC;IAC7C,QAAQ,CAAC,QAAQ,CAAC,yBAAc,CAAC,CAAC;IAClC,QAAQ,CAAC,QAAQ,CAAC,+BAAiB,CAAC,CAAC;IACrC,QAAQ,CAAC,QAAQ,CAAC,+BAAiB,CAAC,CAAC;IACrC,QAAQ,CAAC,QAAQ,CAAC,+BAAiB,CAAC,CAAC;IACrC,QAAQ,CAAC,QAAQ,CAAC,8CAAwB,CAAC,CAAC;IAC5C,QAAQ,CAAC,QAAQ,CAAC,+CAAwB,CAAC,CAAC;AAChD,CAAC"}

package/dist/migrate/promisify-on-promise.d.ts

@@ -0,0 +1,9 @@
+import { ExecutionContext, Recipe, TreeVisitor } from "@openrewrite/rewrite";
+export declare class RemovePromisifyOnPromise extends Recipe {
+    readonly name = "org.openrewrite.node.migrate.util.remove-promisify-on-promise";
+    readonly displayName: string;
+    readonly description: string;
+    readonly tags: string[];
+    editor(): Promise<TreeVisitor<any, ExecutionContext>>;
+}
+//# sourceMappingURL=promisify-on-promise.d.ts.map

package/dist/migrate/promisify-on-promise.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"promisify-on-promise.d.ts","sourceRoot":"","sources":["../../src/migrate/promisify-on-promise.ts"],"names":[],"mappings":"AAAA,OAAO,EAAQ,gBAAgB,EAAE,MAAM,EAAE,WAAW,EAAC,MAAM,sBAAsB,CAAC;AAOlF,qBAAa,wBAAyB,SAAQ,MAAM;IAChD,QAAQ,CAAC,IAAI,mEAAkE;IAC/E,QAAQ,CAAC,WAAW,EAAE,MAAM,CAA0E;IACtG,QAAQ,CAAC,WAAW,EAAE,MAAM,CACuG;IACnI,QAAQ,CAAC,IAAI,EAAE,MAAM,EAAE,CAAe;IAEhC,MAAM,IAAI,OAAO,CAAC,WAAW,CAAC,GAAG,EAAE,gBAAgB,CAAC,CAAC;CAoF9D"}

package/dist/migrate/promisify-on-promise.js

@@ -0,0 +1,107 @@
+"use strict";
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RemovePromisifyOnPromise = void 0;
+const rewrite_1 = require("@openrewrite/rewrite");
+const javascript_1 = require("@openrewrite/rewrite/javascript");
+const java_1 = require("@openrewrite/rewrite/java");
+class RemovePromisifyOnPromise extends rewrite_1.Recipe {
+    constructor() {
+        super(...arguments);
+        this.name = "org.openrewrite.node.migrate.util.remove-promisify-on-promise";
+        this.displayName = "Remove unnecessary `util.promisify()` on Promise-returning functions";
+        this.description = "Removes `util.promisify()` calls on functions that already return a Promise. " +
+            "Since Node.js v17.0.0, calling promisify on a function that returns a Promise emits a runtime deprecation warning (DEP0174).";
+        this.tags = ["DEP0174"];
+    }
+    editor() {
+        return __awaiter(this, void 0, void 0, function* () {
+            return (0, rewrite_1.check)((0, javascript_1.usesMethod)("util promisify(..)"), new class extends javascript_1.JavaScriptVisitor {
+                constructor() {
+                    super(...arguments);
+                    this.promisifyMatcher = new javascript_1.MethodMatcher("util promisify(..)");
+                }
+                visitMethodInvocation(m, p) {
+                    const _super = Object.create(null, {
+                        visitMethodInvocation: { get: () => super.visitMethodInvocation }
+                    });
+                    return __awaiter(this, void 0, void 0, function* () {
+                        const method = yield _super.visitMethodInvocation.call(this, m, p);
+                        if (this.promisifyMatcher.matches(method.methodType)) {
+                            const args = method.arguments.elements;
+                            if (args.length === 1) {
+                                const arg = args[0].element;
+                                if (this.isAsyncOrPromiseReturning(arg)) {
+                                    (0, javascript_1.maybeRemoveImport)(this, "util");
+                                    (0, javascript_1.maybeRemoveImport)(this, "util", "promisify");
+                                    return Object.assign(Object.assign({}, arg), { prefix: method.prefix });
+                                }
+                            }
+                        }
+                        return method;
+                    });
+                }
+                isAsyncOrPromiseReturning(expr) {
+                    if (expr.kind === javascript_1.JS.Kind.ArrowFunction) {
+                        const arrowFunc = expr;
+                        if (this.hasAsyncModifier(arrowFunc.modifiers)) {
+                            return true;
+                        }
+                        if (arrowFunc.returnTypeExpression && this.isPromiseTyped(arrowFunc.returnTypeExpression)) {
+                            return true;
+                        }
+                    }
+                    if (expr.kind === javascript_1.JS.Kind.StatementExpression) {
+                        const stmtExpr = expr;
+                        return this.isAsyncOrPromiseReturning(stmtExpr.statement);
+                    }
+                    if (expr.kind === java_1.J.Kind.MethodDeclaration) {
+                        const methodDecl = expr;
+                        if (this.hasAsyncModifier(methodDecl.modifiers)) {
+                            return true;
+                        }
+                    }
+                    if ('type' in expr && expr.type) {
+                        const type = expr.type;
+                        if (type.kind === java_1.Type.Kind.Method) {
+                            const methodType = type;
+                            if (this.isPromiseTyped(methodType.returnType)) {
+                                return true;
+                            }
+                        }
+                        else if (type.kind === java_1.Type.Kind.Class) {
+                            const clazz = type;
+                            if (clazz.fullyQualifiedName == "𝑓" && clazz.methods.length == 1 && this.isPromiseTyped(clazz.methods[0].returnType)) {
+                                return true;
+                            }
+                        }
+                    }
+                    return false;
+                }
+                hasAsyncModifier(modifiers) {
+                    return modifiers.some(mod => mod.type === "Async" ||
+                        (mod.type === "LanguageExtension" && mod.keyword === "async"));
+                }
+                isPromiseTyped(type) {
+                    if (type && type.kind === java_1.Type.Kind.Parameterized) {
+                        const paramType = type;
+                        if (paramType.type.kind == java_1.Type.Kind.Class && paramType.type.fullyQualifiedName == "Promise") {
+                            return true;
+                        }
+                    }
+                    return false;
+                }
+            });
+        });
+    }
+}
+exports.RemovePromisifyOnPromise = RemovePromisifyOnPromise;
+//# sourceMappingURL=promisify-on-promise.js.map

package/dist/migrate/promisify-on-promise.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"promisify-on-promise.js","sourceRoot":"","sources":["../../src/migrate/promisify-on-promise.ts"],"names":[],"mappings":";;;;;;;;;;;;AAAA,kDAAkF;AAClF,gEAAoH;AACpH,oDAAkD;AAKlD,MAAa,wBAAyB,SAAQ,gBAAM;IAApD;;QACa,SAAI,GAAG,+DAA+D,CAAA;QACtE,gBAAW,GAAW,sEAAsE,CAAC;QAC7F,gBAAW,GAAW,+EAA+E;YAC1G,8HAA8H,CAAC;QAC1H,SAAI,GAAa,CAAC,SAAS,CAAC,CAAC;IAsF1C,CAAC;IApFS,MAAM;;YACR,OAAO,IAAA,eAAK,EAAC,IAAA,uBAAU,EAAC,oBAAoB,CAAC,EAAE,IAAI,KAAM,SAAQ,8BAAmC;gBAAjD;;oBAC/C,qBAAgB,GAAG,IAAI,0BAAa,CAAC,oBAAoB,CAAC,CAAC;gBAgF/D,CAAC;gBA9EmB,qBAAqB,CAAC,CAAqB,EAAE,CAAmB;;;;;wBAC5E,MAAM,MAAM,GAAG,MAAM,OAAM,qBAAqB,YAAC,CAAC,EAAE,CAAC,CAAuB,CAAC;wBAC7E,IAAI,IAAI,CAAC,gBAAgB,CAAC,OAAO,CAAC,MAAM,CAAC,UAAU,CAAC,EAAE,CAAC;4BACnD,MAAM,IAAI,GAAG,MAAM,CAAC,SAAS,CAAC,QAAQ,CAAC;4BACvC,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;gCACpB,MAAM,GAAG,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC;gCAC5B,IAAI,IAAI,CAAC,yBAAyB,CAAC,GAAG,CAAC,EAAE,CAAC;oCACtC,IAAA,8BAAiB,EAAC,IAAI,EAAE,MAAM,CAAC,CAAC;oCAChC,IAAA,8BAAiB,EAAC,IAAI,EAAE,MAAM,EAAE,WAAW,CAAC,CAAC;oCAC7C,OAAO,gCACA,GAAG,KACN,MAAM,EAAE,MAAM,CAAC,MAAM,GACnB,CAAC;gCACX,CAAC;4BACL,CAAC;wBACL,CAAC;wBACD,OAAO,MAAM,CAAC;oBAClB,CAAC;iBAAA;gBAEO,yBAAyB,CAAC,IAAO;oBACrC,IAAI,IAAI,CAAC,IAAI,KAAK,eAAE,CAAC,IAAI,CAAC,aAAa,EAAE,CAAC;wBACtC,MAAM,SAAS,GAAG,IAAwB,CAAC;wBAC3C,IAAI,IAAI,CAAC,gBAAgB,CAAC,SAAS,CAAC,SAAS,CAAC,EAAE,CAAC;4BAC7C,OAAO,IAAI,CAAC;wBAChB,CAAC;wBACD,IAAI,SAAS,CAAC,oBAAoB,IAAI,IAAI,CAAC,cAAc,CAAC,SAAS,CAAC,oBAAoB,CAAC,EAAE,CAAC;4BACxF,OAAO,IAAI,CAAC;wBAChB,CAAC;oBACL,CAAC;oBAED,IAAI,IAAI,CAAC,IAAI,KAAK,eAAE,CAAC,IAAI,CAAC,mBAAmB,EAAE,CAAC;wBAC5C,MAAM,QAAQ,GAAG,IAA8B,CAAC;wBAChD,OAAO,IAAI,CAAC,yBAAyB,CAAC,QAAQ,CAAC,SAAc,CAAC,CAAC;oBACnE,CAAC;oBAED,IAAI,IAAI,CAAC,IAAI,KAAK,QAAC,CAAC,IAAI,CAAC,iBAAiB,EAAE,CAAC;wBACzC,MAAM,UAAU,GAAG,IAA2B,CAAC;wBAC/C,IAAI,IAAI,CAAC,gBAAgB,CAAC,UAAU,CAAC,SAAS,CAAC,EAAE,CAAC;4BAC9C,OAAO,IAAI,CAAC;wBAChB,CAAC;oBACL,CAAC;oBAID,IAAI,MAAM,IAAI,IAAI,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC;wBAC9B,MAAM,IAAI,GAAG,IAAI,CAAC,IAAY,CAAC;wBAC/B,IAAI,IAAI,CAAC,IAAI,KAAK,WAAI,CAAC,IAAI,CAAC,MAAM,EAAE,CAAC;4BACjC,MAAM,UAAU,GAAG,IAAmB,CAAC;4BACvC,IAAI,IAAI,CAAC,cAAc,CAAC,UAAU,CAAC,UAAU,CAAC,EAAE,CAAC;gCAC7C,OAAO,IAAI,CAAC;4BAChB,CAAC;wBACL,CAAC;6BAAM,IAAI,IAAI,CAAC,IAAI,KAAK,WAAI,CAAC,IAAI,CAAC,KAAK,EAAE,CAAC;4BACvC,MAAM,KAAK,GAAG,IAAkB,CAAC;4BACjC,IAAI,KAAK,CAAC,kBAAkB,IAAI,IAAI,IAAI,KAAK,CAAC,OAAO,CAAC,MAAM,IAAI,CAAC,IAAI,IAAI,CAAC,cAAc,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,EAAE,CAAC;gCACpH,OAAO,IAAI,CAAC;4BAChB,CAAC;wBACL,CAAC;oBACL,CAAC;oBAED,OAAO,KAAK,CAAC;gBACjB,CAAC;gBAEO,gBAAgB,CAAC,SAAuB;oBAC5C,OAAO,SAAS,CAAC,IAAI,CAAC,GAAG,CAAC,EAAE,CACxB,GAAG,CAAC,IAAI,YAAyB;wBACjC,CAAC,GAAG,CAAC,IAAI,wBAAqC,IAAI,GAAG,CAAC,OAAO,KAAK,OAAO,CAAC,CAC7E,CAAC;gBACN,CAAC;gBAEO,cAAc,CAAC,IAAU;oBAC7B,IAAI,IAAI,IAAI,IAAI,CAAC,IAAI,KAAK,WAAI,CAAC,IAAI,CAAC,aAAa,EAAE,CAAC;wBAChD,MAAM,SAAS,GAAG,IAA0B,CAAC;wBAC7C,IAAI,SAAS,CAAC,IAAI,CAAC,IAAI,IAAI,WAAI,CAAC,IAAI,CAAC,KAAK,IAAK,SAAS,CAAC,IAAmB,CAAC,kBAAkB,IAAI,SAAS,EAAE,CAAC;4BAC3G,OAAO,IAAI,CAAC;wBAChB,CAAC;oBACL,CAAC;oBACD,OAAO,KAAK,CAAC;gBACjB,CAAC;aACJ,CAAC,CAAC;QACP,CAAC;KAAA;CACJ;AA3FD,4DA2FC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openrewrite/recipes-nodejs",
-  "version": "0.35.0-20251120-170459",
+  "version": "0.35.0-20251121-142457",
   "license": "Moderne Source Available License",
   "description": "OpenRewrite recipes for Node.js library migrations.",
   "homepage": "https://github.com/moderneinc/rewrite-node",

package/src/index.ts

@@ -8,6 +8,7 @@ import {ReplaceUtilExtend} from "./migrate/util-extend";
 import {ReplaceCryptoFips} from "./migrate/crypto-fips";
 import {ReplaceSlowBuffer} from "./migrate/slow-buffer";
 import {ReplaceFsAccessConstants} from "./migrate/fs-access-constants";
+import {RemovePromisifyOnPromise} from "./migrate/promisify-on-promise";
 
 
 export function activate(registry: RecipeRegistry) {
@@ -20,4 +21,5 @@ export function activate(registry: RecipeRegistry) {
     registry.register(ReplaceCryptoFips);
     registry.register(ReplaceSlowBuffer);
     registry.register(ReplaceFsAccessConstants);
+    registry.register(RemovePromisifyOnPromise);
 }

package/src/migrate/promisify-on-promise.ts

@@ -0,0 +1,99 @@
+import {check, ExecutionContext, Recipe, TreeVisitor} from "@openrewrite/rewrite";
+import {JavaScriptVisitor, JS, maybeRemoveImport, MethodMatcher, usesMethod} from "@openrewrite/rewrite/javascript";
+import {J, Type} from "@openrewrite/rewrite/java";
+
+/**
+ * Removes unnecessary util.promisify() calls on functions that already return a Promise.
+ */
+export class RemovePromisifyOnPromise extends Recipe {
+    readonly name = "org.openrewrite.node.migrate.util.remove-promisify-on-promise"
+    readonly displayName: string = "Remove unnecessary `util.promisify()` on Promise-returning functions";
+    readonly description: string = "Removes `util.promisify()` calls on functions that already return a Promise. " +
+        "Since Node.js v17.0.0, calling promisify on a function that returns a Promise emits a runtime deprecation warning (DEP0174).";
+    readonly tags: string[] = ["DEP0174"];
+
+    async editor(): Promise<TreeVisitor<any, ExecutionContext>> {
+        return check(usesMethod("util promisify(..)"), new class extends JavaScriptVisitor<ExecutionContext> {
+            promisifyMatcher = new MethodMatcher("util promisify(..)");
+
+            protected async visitMethodInvocation(m: J.MethodInvocation, p: ExecutionContext): Promise<J | undefined> {
+                const method = await super.visitMethodInvocation(m, p) as J.MethodInvocation;
+                if (this.promisifyMatcher.matches(method.methodType)) {
+                    const args = method.arguments.elements;
+                    if (args.length === 1) {
+                        const arg = args[0].element;
+                        if (this.isAsyncOrPromiseReturning(arg)) {
+                            maybeRemoveImport(this, "util");
+                            maybeRemoveImport(this, "util", "promisify");
+                            return {
+                                ...arg,
+                                prefix: method.prefix
+                            } as J;
+                        }
+                    }
+                }
+                return method;
+            }
+
+            private isAsyncOrPromiseReturning(expr: J): boolean {
+                if (expr.kind === JS.Kind.ArrowFunction) {
+                    const arrowFunc = expr as JS.ArrowFunction;
+                    if (this.hasAsyncModifier(arrowFunc.modifiers)) {
+                        return true;
+                    }
+                    if (arrowFunc.returnTypeExpression && this.isPromiseTyped(arrowFunc.returnTypeExpression)) {
+                        return true;
+                    }
+                }
+
+                if (expr.kind === JS.Kind.StatementExpression) {
+                    const stmtExpr = expr as JS.StatementExpression;
+                    return this.isAsyncOrPromiseReturning(stmtExpr.statement as J);
+                }
+
+                if (expr.kind === J.Kind.MethodDeclaration) {
+                    const methodDecl = expr as J.MethodDeclaration;
+                    if (this.hasAsyncModifier(methodDecl.modifiers)) {
+                        return true;
+                    }
+                }
+
+                // Looks pretty ugly to check the `type` property. We know upfront for what subclasses we define a `type` property,
+                // the problem is it's like ~50 of them.
+                if ('type' in expr && expr.type) {
+                    const type = expr.type as Type;
+                    if (type.kind === Type.Kind.Method) {
+                        const methodType = type as Type.Method;
+                        if (this.isPromiseTyped(methodType.returnType)) {
+                            return true;
+                        }
+                    } else if (type.kind === Type.Kind.Class) {
+                        const clazz = type as Type.Class;
+                        if (clazz.fullyQualifiedName == "𝑓" && clazz.methods.length == 1 && this.isPromiseTyped(clazz.methods[0].returnType)) {
+                            return true;
+                        }
+                    }
+                }
+
+                return false;
+            }
+
+            private hasAsyncModifier(modifiers: J.Modifier[]): boolean {
+                return modifiers.some(mod =>
+                    mod.type === J.ModifierType.Async ||
+                    (mod.type === J.ModifierType.LanguageExtension && mod.keyword === "async")
+                );
+            }
+
+            private isPromiseTyped(type: Type): boolean {
+                if (type && type.kind === Type.Kind.Parameterized) {
+                    const paramType = type as Type.Parameterized;
+                    if (paramType.type.kind == Type.Kind.Class && (paramType.type as Type.Class).fullyQualifiedName == "Promise") {
+                        return true;
+                    }
+                }
+                return false;
+            }
+        });
+    }
+}