@openrewrite/recipes-angular 1.1.4 → 1.1.5

package/src/libraries/primeng/18/mark-drawer-size.ts

@@ -0,0 +1,85 @@
+/*
+ * Copyright 2026 the original author or authors.
+ *
+ * Moderne Proprietary. Only for use by Moderne customers under the terms of a commercial contract.
+ */
+
+import {DataTable, ExecutionContext, Recipe, TreeVisitor} from "@openrewrite/rewrite";
+import {PlainText, PlainTextVisitor} from "@openrewrite/rewrite/text";
+import {
+    ManualMigrationStep,
+    MANUAL_MIGRATION_STEPS_DESCRIPTION,
+    MANUAL_MIGRATION_STEPS_DISPLAY_NAME,
+    MANUAL_MIGRATION_STEPS_NAME,
+} from "./manual-migration-steps";
+
+const TARGET_TAGS = ['p-drawer', 'p-sidebar'];
+const TODO_TEXT = "PrimeNG 18 removed the `size` input on `<p-drawer>`/`<p-sidebar>`. Replace `[size]=\"...\"` / `size=\"...\"` with a responsive CSS utility on the `[style]` input or `styleClass`.";
+
+/**
+ * Mark `<p-drawer>` and `<p-sidebar>` elements that bind the removed `size` input in
+ * templates. Adds an HTML TODO comment immediately before the element and writes a row
+ * to the `ManualMigrationSteps` data table. The attribute itself is left in place because
+ * the right replacement is template-context-dependent (responsive style class, fixed
+ * width, etc.).
+ */
+export class MarkDrawerSize extends Recipe {
+    readonly name = "org.openrewrite.primeng.MarkDrawerSize";
+    readonly displayName = "Mark `<p-drawer>` / `<p-sidebar>` `size` usages with TODO comments";
+    readonly description = "Inserts an HTML `<!-- TODO: ... -->` comment before any `<p-drawer>` or " +
+        "`<p-sidebar>` element that binds the removed `size` input, and records the site in the " +
+        "`ManualMigrationSteps` data table. Both `[size]=\"...\"` and `size=\"...\"` attribute forms are " +
+        "matched. The attribute is left untouched — the v18 replacement (responsive CSS via `[style]` / " +
+        "`styleClass`) depends on the desired layout and needs manual review.";
+
+    private dataTable = new DataTable<ManualMigrationStep>(
+        MANUAL_MIGRATION_STEPS_NAME,
+        MANUAL_MIGRATION_STEPS_DISPLAY_NAME,
+        MANUAL_MIGRATION_STEPS_DESCRIPTION,
+        ManualMigrationStep,
+    );
+
+    async editor(): Promise<TreeVisitor<any, ExecutionContext>> {
+        const recipeName = this.name;
+        const dataTable = this.dataTable;
+        return new class extends PlainTextVisitor<ExecutionContext> {
+            override async visitText(text: PlainText, p: ExecutionContext): Promise<PlainText | undefined> {
+                const t = await super.visitText(text, p) as PlainText;
+                if (!t) return t;
+                if (!t.sourcePath.endsWith('.html')) return t;
+
+                let updated = t.text;
+                let modified = false;
+
+                for (const tag of TARGET_TAGS) {
+                    // Match opening tags of the target component that include a [size]="…" or
+                    // size="…" attribute. We only mark — the attribute stays in place.
+                    const re = new RegExp(`(^|\\n)([ \\t]*)(<${tag}\\b[^>]*?(?:\\[size\\]|\\bsize)\\s*=\\s*["'][^"']*["'][^>]*>)`, 'g');
+                    const todoMarker = `<!-- TODO: PrimeNG 18 — ${TODO_TEXT} -->`;
+                    updated = updated.replace(re, (match, lead, indent, fullTag) => {
+                        const before = updated.slice(0, updated.indexOf(match));
+                        if (before.endsWith(todoMarker + '\n' + indent) || before.endsWith(todoMarker + indent)) {
+                            return match;
+                        }
+                        modified = true;
+                        dataTable.insertRow(p, {
+                            sourcePath: t.sourcePath,
+                            recipe: recipeName,
+                            subject: `<${tag} ... size="...">`,
+                            reason: "`size` input removed in PrimeNG 18.",
+                            action: TODO_TEXT,
+                        });
+                        return `${lead}${indent}${todoMarker}\n${indent}${fullTag}`;
+                    });
+                }
+
+                if (!modified) return t;
+                return {
+                    ...t,
+                    text: updated,
+                    snippets: [],
+                };
+            }
+        }();
+    }
+}

package/src/libraries/primeng/18/mark-removed-primeng-modules.ts

@@ -0,0 +1,198 @@
+/*
+ * Copyright 2026 the original author or authors.
+ *
+ * Moderne Proprietary. Only for use by Moderne customers under the terms of a commercial contract.
+ */
+
+import {DataTable, ExecutionContext, Recipe, TreeVisitor} from "@openrewrite/rewrite";
+import {JavaScriptVisitor, JS, Template} from "@openrewrite/rewrite/javascript";
+import {J, isIdentifier} from "@openrewrite/rewrite/java";
+import {create} from "mutative";
+import {
+    ManualMigrationStep,
+    MANUAL_MIGRATION_STEPS_DESCRIPTION,
+    MANUAL_MIGRATION_STEPS_DISPLAY_NAME,
+    MANUAL_MIGRATION_STEPS_NAME,
+} from "./manual-migration-steps";
+
+interface RemovedModule {
+    members: string[];
+    todo: string;
+}
+
+// Modules removed entirely in PrimeNG 18 — their packages no longer exist on disk.
+const REMOVED_MODULES: Record<string, RemovedModule> = {
+    'primeng/chips': {
+        members: ['ChipsModule', 'Chips'],
+        todo: "PrimeNG 18 — `Chips` was removed. Replace `<p-chips>` with `<p-autoComplete [multiple]=\"true\" [typeahead]=\"false\">`.",
+    },
+    'primeng/tristatecheckbox': {
+        members: ['TriStateCheckboxModule', 'TriStateCheckbox'],
+        todo: "PrimeNG 18 — `TriStateCheckbox` was removed. Replace `<p-triStateCheckbox>` with `<p-checkbox [indeterminate]=\"true\">`.",
+    },
+    'primeng/messages': {
+        members: ['MessagesModule', 'Messages'],
+        todo: "PrimeNG 18 — `Messages` was removed. Replace `<p-messages [value]=\"X\">` with `@for (m of X; track m) { <p-message [severity]=\"m.severity\" [text]=\"m.detail\"></p-message> }` and import `MessageModule` from `primeng/message`.",
+    },
+    'primeng/dataviewlayoutoptions': {
+        members: ['DataViewLayoutOptions'],
+        todo: "PrimeNG 18 — `DataViewLayoutOptions` was removed. Replace `<p-dataViewLayoutOptions>` with `<p-selectButton>` bound to a layout `'list'|'grid'` value.",
+    },
+    'primeng/animate': {
+        members: ['AnimateModule', 'Animate'],
+        todo: "PrimeNG 18 — the `pAnimate` directive was removed. Replace `pAnimate` usages with `pAnimateOnScroll` and import from `primeng/animateonscroll`.",
+    },
+};
+
+// All identifiers that should be stripped from @NgModule imports / declarations / exports arrays
+// because they refer to components / modules that no longer exist as runtime values.
+const REMOVED_IDENTIFIERS = new Set<string>(
+    Object.values(REMOVED_MODULES).flatMap(m => m.members)
+);
+
+export class MarkRemovedPrimengModules extends Recipe {
+    readonly name = "org.openrewrite.primeng.MarkRemovedPrimengModules";
+    readonly displayName = "Mark imports of removed PrimeNG modules with TODO stubs";
+    readonly description = "For each `import` of a PrimeNG module that no longer exists in v18 " +
+        "(`primeng/chips`, `primeng/tristatecheckbox`, `primeng/messages`, `primeng/dataviewlayoutoptions`), " +
+        "replaces the broken import statement with a `const <Name>: any = null;` stub annotated by a TODO " +
+        "comment that describes the v18 replacement. Also strips the corresponding entries from `@NgModule` " +
+        "`imports`, `declarations`, and `exports` arrays since Angular's compiler rejects `null` values there. " +
+        "Each flagged site is also recorded in the `ManualMigrationSteps` data table so downstream tooling " +
+        "can enumerate the remaining work.";
+
+    private dataTable = new DataTable<ManualMigrationStep>(
+        MANUAL_MIGRATION_STEPS_NAME,
+        MANUAL_MIGRATION_STEPS_DISPLAY_NAME,
+        MANUAL_MIGRATION_STEPS_DESCRIPTION,
+        ManualMigrationStep,
+    );
+
+    async editor(): Promise<TreeVisitor<any, ExecutionContext>> {
+        const recipeName = this.name;
+        const dataTable = this.dataTable;
+        return new class extends JavaScriptVisitor<ExecutionContext> {
+            protected async visitImportDeclaration(jsImport: JS.Import, p: ExecutionContext): Promise<J | undefined> {
+                const imp = await super.visitImportDeclaration(jsImport, p) as JS.Import;
+                if (!imp?.moduleSpecifier) return imp;
+
+                const moduleSpec = imp.moduleSpecifier.element;
+                if (moduleSpec.kind !== J.Kind.Literal) return imp;
+
+                const moduleName = (moduleSpec as J.Literal).value as string;
+                const removed = REMOVED_MODULES[moduleName];
+                if (!removed) return imp;
+
+                const importedNames: string[] = [];
+                const namedBindings = imp.importClause?.namedBindings;
+                if (namedBindings?.kind === JS.Kind.NamedImports) {
+                    for (const specifier of (namedBindings as JS.NamedImports).elements.elements) {
+                        const spec = specifier.element as JS.ImportSpecifier;
+                        if (isIdentifier(spec.specifier)) {
+                            importedNames.push((spec.specifier as J.Identifier).simpleName);
+                        }
+                    }
+                }
+                if (importedNames.length === 0) return imp;
+
+                const replacementCode = importedNames
+                    .map(name => `const ${name}: any = null;`)
+                    .join('\n');
+
+                const replacement = await Template.builder()
+                    .code(replacementCode)
+                    .build()
+                    .apply(imp, this.cursor) as any;
+
+                const sourcePath = (this.cursor.firstEnclosing<any>((o: any): o is any => !!o?.sourcePath)?.sourcePath) ?? '';
+                for (const name of importedNames) {
+                    dataTable.insertRow(p, {
+                        sourcePath,
+                        recipe: recipeName,
+                        subject: `${name} (${moduleName})`,
+                        reason: "Module removed in PrimeNG 18; package no longer exists.",
+                        action: removed.todo,
+                    });
+                }
+
+                const todoComment = {
+                    kind: J.Kind.TextComment,
+                    multiline: true,
+                    text: ` TODO: ${removed.todo} (was \`import { ${importedNames.join(', ')} } from '${moduleName}'\`) `,
+                    suffix: '\n',
+                    markers: {kind: 'org.openrewrite.marker.Markers', id: imp.id, markers: []},
+                };
+
+                const originalPrefix = imp.prefix ?? {kind: J.Kind.Space, whitespace: '', comments: []};
+
+                return {
+                    ...replacement,
+                    prefix: {
+                        ...originalPrefix,
+                        comments: [...(originalPrefix.comments ?? []), todoComment],
+                    },
+                } as J;
+            }
+
+            override async visitAnnotation(annotation: J.Annotation, p: ExecutionContext): Promise<J | undefined> {
+                const a = await super.visitAnnotation(annotation, p) as J.Annotation;
+                if (!a) return a;
+
+                const annotType = a.annotationType;
+                if (!isIdentifier(annotType)) return a;
+                if (annotType.simpleName !== 'NgModule' && annotType.simpleName !== 'Component') return a;
+
+                if (!a.arguments?.elements?.length) return a;
+                const firstArg = a.arguments.elements[0].element;
+                if (firstArg.kind !== J.Kind.NewClass) return a;
+
+                const newClass = firstArg as J.NewClass;
+                if (!newClass.body) return a;
+
+                let modified = false;
+                const newStatements = newClass.body.statements.map(stmtEl => {
+                    const stmt = stmtEl.element;
+                    if (stmt.kind !== JS.Kind.PropertyAssignment) return stmtEl;
+                    const prop = stmt as JS.PropertyAssignment;
+                    const nameExpr = prop.name.element;
+                    if (!isIdentifier(nameExpr)) return stmtEl;
+                    if (!['imports', 'declarations', 'exports'].includes(nameExpr.simpleName)) return stmtEl;
+
+                    const initializer = prop.initializer as any;
+                    const arr = initializer;
+                    if (!arr?.initializer?.elements?.length) return stmtEl;
+
+                    const filteredElems = arr.initializer.elements.filter((el: any) => {
+                        const expr = el.element;
+                        if (!isIdentifier(expr)) return true;
+                        return !REMOVED_IDENTIFIERS.has((expr as J.Identifier).simpleName);
+                    });
+
+                    if (filteredElems.length === arr.initializer.elements.length) return stmtEl;
+
+                    modified = true;
+                    return {
+                        ...stmtEl,
+                        element: {
+                            ...prop,
+                            initializer: {
+                                ...arr,
+                                initializer: {
+                                    ...arr.initializer,
+                                    elements: filteredElems
+                                }
+                            }
+                        }
+                    };
+                });
+
+                if (!modified) return a;
+
+                return create(a, draft => {
+                    const body = (draft.arguments!.elements[0].element as any).body!;
+                    body.statements = newStatements;
+                }) as J.Annotation;
+            }
+        }();
+    }
+}

package/src/libraries/primeng/18/migrate-messages-to-message-loop.ts

@@ -0,0 +1,72 @@
+/*
+ * Copyright 2026 the original author or authors.
+ *
+ * Moderne Proprietary. Only for use by Moderne customers under the terms of a commercial contract.
+ */
+
+import {DataTable, ExecutionContext, Recipe, TreeVisitor} from "@openrewrite/rewrite";
+import {PlainText, PlainTextVisitor} from "@openrewrite/rewrite/text";
+import {
+    ManualMigrationStep,
+    MANUAL_MIGRATION_STEPS_DESCRIPTION,
+    MANUAL_MIGRATION_STEPS_DISPLAY_NAME,
+    MANUAL_MIGRATION_STEPS_NAME,
+} from "./manual-migration-steps";
+
+/**
+ * Rewrite `<p-messages [value]="X"...></p-messages>` to a `@for` loop over `<p-message>`,
+ * matching the v18 replacement pattern. Handles both self-closing and paired tags, single-
+ * or double-quoted bound values, and any other attributes (which are dropped — they don't
+ * apply to the new component).
+ */
+export class MigrateMessagesToMessageLoop extends Recipe {
+    readonly name = "org.openrewrite.primeng.MigrateMessagesToMessageLoop";
+    readonly displayName = "Migrate `<p-messages>` to `<p-message>` with `@for` loop";
+    readonly description = "Rewrites `<p-messages [value]=\"expr\">…</p-messages>` to " +
+        "`@for (msg of expr; track msg) { <p-message [severity]=\"msg.severity\" [text]=\"msg.detail\"></p-message> }`. " +
+        "The `Messages` component was removed in PrimeNG 18 in favor of looping over the new `Message` component. " +
+        "Each rewritten site is recorded in the `ManualMigrationSteps` data table for follow-up review.";
+
+    private dataTable = new DataTable<ManualMigrationStep>(
+        MANUAL_MIGRATION_STEPS_NAME,
+        MANUAL_MIGRATION_STEPS_DISPLAY_NAME,
+        MANUAL_MIGRATION_STEPS_DESCRIPTION,
+        ManualMigrationStep,
+    );
+
+    async editor(): Promise<TreeVisitor<any, ExecutionContext>> {
+        const recipeName = this.name;
+        const dataTable = this.dataTable;
+        return new class extends PlainTextVisitor<ExecutionContext> {
+            override async visitText(text: PlainText, p: ExecutionContext): Promise<PlainText | undefined> {
+                const t = await super.visitText(text, p) as PlainText;
+                if (!t) return t;
+                if (!t.sourcePath.endsWith('.html')) return t;
+                if (!t.text.includes('<p-messages')) return t;
+
+                const re = /<p-messages\b([^>]*?)\[value\]=["']([^"']+)["']([^>]*)>(?:\s*<\/p-messages>)?/g;
+
+                let modified = false;
+                const updated = t.text.replace(re, (_match, _before, expr, _after) => {
+                    modified = true;
+                    dataTable.insertRow(p, {
+                        sourcePath: t.sourcePath,
+                        recipe: recipeName,
+                        subject: `<p-messages [value]="${expr}">`,
+                        reason: "Messages component removed in PrimeNG 18; replaced by automated rewrite to <p-message> + @for loop.",
+                        action: "Review the generated severity/text bindings against the original message shape (closable, life, etc. no longer apply). Confirm the iterable shape matches `{ severity, summary, detail }`.",
+                    });
+                    return `<!-- TODO: PrimeNG 18 — \`Messages\` was removed. The block below is an automated rewrite to the new \`Message\` + \`@for\` pattern; review severity/text/closable bindings against the original message shape. -->\n@for (msg of ${expr}; track msg) {\n  <p-message [severity]="msg.severity" [text]="msg.detail"></p-message>\n}`;
+                });
+
+                if (!modified) return t;
+
+                return {
+                    ...t,
+                    text: updated,
+                    snippets: [],
+                };
+            }
+        }();
+    }
+}