@openparachute/vault 0.7.3-rc.13 → 0.7.3-rc.2

package/src/transcription-worker.test.ts

@@ -1627,154 +1627,3 @@ describe("transcription worker — legacy in-body memo content safety (finding F
     expect(note!.content).toContain("retry text with $& and $0 and $$ literal");
   });
 });
-
-// ---------------------------------------------------------------------------
-// voice W2 — segmented recordings. The app slices a long recording into
-// ~10-min segments, each linked as its own attachment on ONE note carrying a
-// client-set `segment_index` (0-based). The legacy in-body path targets that
-// part's markers — `_Transcript pending (part N)._` / `_Transcription
-// unavailable (part N)._`, N = segment_index + 1 — so each transcript lands in
-// its own pre-allocated slot regardless of completion order. Marker strings
-// are a BYTE-EXACT cross-door + cross-repo contract (the cloud worker ships
-// the identical text), so these assertions pin the exact bytes.
-// ---------------------------------------------------------------------------
-
-describe("transcription worker — segmented recordings (voice W2)", () => {
-  test("three parts completing OUT OF ORDER (2 ok, 0 fails, 1 ok) each land in their own slot", async () => {
-    // One note, three pre-allocated part slots + the shared stub opt-in.
-    const body =
-      "# 🎙️ Voice memo\n\n" +
-      "_Transcript pending (part 1)._\n\n" +
-      "_Transcript pending (part 2)._\n\n" +
-      "_Transcript pending (part 3)._\n";
-    await store.createNote(body, { id: "seg-note", metadata: { transcribe_stub: true } });
-
-    seedAudio("memos/seg0.webm");
-    seedAudio("memos/seg1.webm");
-    seedAudio("memos/seg2.webm");
-    const seg0 = await store.addAttachment("seg-note", "memos/seg0.webm", "audio/webm", {
-      transcribe_status: "pending",
-      segment_index: 0,
-    });
-    const seg1 = await store.addAttachment("seg-note", "memos/seg1.webm", "audio/webm", {
-      transcribe_status: "pending",
-      segment_index: 1,
-    });
-    const seg2 = await store.addAttachment("seg-note", "memos/seg2.webm", "audio/webm", {
-      transcribe_status: "pending",
-      segment_index: 2,
-    });
-
-    // Complete part 3 (segment_index 2) FIRST — success.
-    const w2 = makeWorker({ fetchImpl: mkFetchMock([{ text: "part three text" }]) });
-    try { await w2.kick("default", seg2); } finally { await w2.stop(); }
-
-    // Then part 1 (segment_index 0) — terminal failure (maxAttempts=1).
-    const w0 = makeWorker({
-      fetchImpl: mkFetchMock([{ error: "scribe down", status: 500 }]),
-      maxAttempts: 1,
-    });
-    try { await w0.kick("default", seg0); } finally { await w0.stop(); }
-
-    // Finally part 2 (segment_index 1) — success.
-    const w1 = makeWorker({ fetchImpl: mkFetchMock([{ text: "part two text" }]) });
-    try { await w1.kick("default", seg1); } finally { await w1.stop(); }
-
-    const note = await store.getNote("seg-note");
-    // Each part landed in its own slot: part 1 → failure marker, part 2/3 →
-    // their transcripts, despite completing 3 → 1 → 2.
-    expect(note!.content).toBe(
-      "# 🎙️ Voice memo\n\n" +
-      "_Transcription unavailable (part 1)._\n\n" +
-      "part two text\n\n" +
-      "part three text\n",
-    );
-    // Shared stub SURVIVES — sibling parts each needed the gate open; a
-    // per-part clear (the un-segmented behavior) would have blocked parts 2 & 3.
-    expect((note!.metadata as any)?.transcribe_stub).toBe(true);
-
-    // Attachment rows reflect their individual outcomes.
-    const atts = await store.getAttachments("seg-note");
-    const byIndex = Object.fromEntries(atts.map((a) => [a.metadata?.segment_index, a]));
-    expect(byIndex[0]!.metadata?.transcribe_status).toBe("failed");
-    expect(byIndex[1]!.metadata?.transcribe_status).toBe("done");
-    expect(byIndex[1]!.metadata?.transcript).toBe("part two text");
-    expect(byIndex[2]!.metadata?.transcribe_status).toBe("done");
-    expect(byIndex[2]!.metadata?.transcript).toBe("part three text");
-  });
-
-  test("un-segmented attachment → BARE markers, one-shot stub cleared (regression pin)", async () => {
-    // No `segment_index` → byte-for-byte the pre-W2 behavior: replace the bare
-    // placeholder, clear the stub. A stray `(part N)` marker in the body is
-    // left untouched (the bare path never targets part markers).
-    await store.createNote(
-      "# 🎙️ Voice memo\n\n_Transcript pending._\n\n_Transcript pending (part 2)._\n",
-      { id: "unseg-note", metadata: { transcribe_stub: true } },
-    );
-    seedAudio("memos/unseg.webm");
-    const att = await store.addAttachment("unseg-note", "memos/unseg.webm", "audio/webm", {
-      transcribe_status: "pending",
-    });
-
-    const worker = makeWorker({ fetchImpl: mkFetchMock([{ text: "bare transcript" }]) });
-    try { await worker.kick("default", att); } finally { await worker.stop(); }
-
-    const note = await store.getNote("unseg-note");
-    // Bare marker replaced; the part-2 marker is NOT touched by the bare path.
-    expect(note!.content).toBe(
-      "# 🎙️ Voice memo\n\nbare transcript\n\n_Transcript pending (part 2)._\n",
-    );
-    // One-shot stub cleared, exactly as today.
-    expect((note!.metadata as any)?.transcribe_stub).toBeUndefined();
-  });
-
-  test("malformed segment_index falls back to bare markers (contract: integer ≥ 0)", async () => {
-    // A non-integer / negative `segment_index` must NOT fabricate a `(part N)`
-    // marker — it degrades to the bare path (fully backward compatible).
-    await store.createNote(
-      "# 🎙️ Voice memo\n\n_Transcript pending._\n",
-      { id: "seg-bad", metadata: { transcribe_stub: true } },
-    );
-    seedAudio("memos/segbad.webm");
-    const att = await store.addAttachment("seg-bad", "memos/segbad.webm", "audio/webm", {
-      transcribe_status: "pending",
-      segment_index: -1, // invalid → bare path
-    });
-
-    const worker = makeWorker({ fetchImpl: mkFetchMock([{ text: "fallback transcript" }]) });
-    try { await worker.kick("default", att); } finally { await worker.stop(); }
-
-    const note = await store.getNote("seg-bad");
-    expect(note!.content).toBe("# 🎙️ Voice memo\n\nfallback transcript\n");
-    expect((note!.metadata as any)?.transcribe_stub).toBeUndefined();
-  });
-
-  test("segmented part whose marker was edited away → transcript appended (graceful fallback)", async () => {
-    // The user rewrote part 2's slot by hand, removing its pending marker.
-    // Mirror the un-segmented replace-or-append policy scoped to the part:
-    // with neither of part 2's markers present, append the transcript
-    // (no `(part N)` prefix) rather than destroying the user's edit.
-    const editedBody =
-      "# 🎙️ Voice memo\n\n" +
-      "_Transcript pending (part 1)._\n\n" +
-      "User rewrote part two by hand.\n";
-    await store.createNote(editedBody, { id: "seg-edit", metadata: { transcribe_stub: true } });
-    seedAudio("memos/segedit.webm");
-    const seg1 = await store.addAttachment("seg-edit", "memos/segedit.webm", "audio/webm", {
-      transcribe_status: "pending",
-      segment_index: 1, // part 2
-    });
-
-    const worker = makeWorker({ fetchImpl: mkFetchMock([{ text: "the real part two" }]) });
-    try { await worker.kick("default", seg1); } finally { await worker.stop(); }
-
-    const note = await store.getNote("seg-edit");
-    // Part 2's transcript appended; the user's edit + part 1's pending slot
-    // both survive untouched.
-    expect(note!.content).toBe(`${editedBody}\n\nthe real part two`);
-    expect(note!.content).toContain("User rewrote part two by hand.");
-    expect(note!.content).toContain("_Transcript pending (part 1)._");
-    // Segmented → shared stub preserved (part 1 still needs the gate open).
-    expect((note!.metadata as any)?.transcribe_stub).toBe(true);
-  });
-});

package/src/transcription-worker.ts

@@ -64,57 +64,41 @@ import {
 } from "../core/src/transcription/provider.ts";
 import { ScribeHttpProvider } from "./transcription/providers/scribe-http.ts";
 
+/** Placeholder pattern written by the voice-memo capture stub. */
+const TRANSCRIPT_PLACEHOLDER = /_Transcript pending\._/;
+
 /**
- * The in-body transcription markers.
- *
- * The BARE markers are the un-segmented default; voice W2 (segmented
- * recordings) targets per-part variants built by `markersFor`. Both are a
- * BYTE-EXACT cross-door + cross-repo contract — the cloud Workers-AI
- * transcription path ships the identical strings, and the notes-ui status
- * chip (parachute-surface TranscriptionStatus.tsx) keys off the failure
- * marker's exact copy. Don't change any of this text without a coordinated
- * change in both places. A friendlier "retry available" copy + chip
- * affordance is a tracked parachute-surface follow-up.
+ * Body written when transcription reaches a terminal failure (maxAttempts
+ * exhausted, or the audio file is missing). This used to be written by
+ * Lens's now-removed scribe client; owning it here means a failed upload
+ * stops reading "Transcript pending" forever regardless of which client
+ * uploaded the audio.
  *
- * Owning the failure marker here (it used to be written by Lens's now-removed
- * scribe client) means a failed upload stops reading "Transcript pending"
- * forever regardless of which client uploaded the audio.
+ * NOTE: the notes-ui status chip (parachute-surface TranscriptionStatus.tsx)
+ * keys off this exact string, so don't change the copy without a coordinated
+ * change there. A friendlier "retry available" copy + chip affordance is a
+ * tracked parachute-surface follow-up.
  */
-const BARE_PENDING = "_Transcript pending._";
-const BARE_UNAVAILABLE = "_Transcription unavailable._";
-
-/** Escape a literal string for safe embedding in a `RegExp`. */
-function escapeRegExp(literal: string): string {
-  return literal.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
-}
+const TRANSCRIPT_UNAVAILABLE = "_Transcription unavailable._";
 
 /**
- * The pending + terminal-failure markers for an attachment, honoring
- * `segment_index` (voice W2 — segmented recordings). `undefined` yields the
- * bare markers (fully backward compatible — un-segmented flows are byte-
- * unchanged). An integer ≥ 0 yields this part's markers, with the human-
- * facing part number N = segment_index + 1 (1-based, decimal):
- *   `_Transcript pending (part N)._` / `_Transcription unavailable (part N)._`
- */
-function markersFor(segmentIndex: number | undefined): { pending: string; unavailable: string } {
-  if (segmentIndex === undefined) return { pending: BARE_PENDING, unavailable: BARE_UNAVAILABLE };
-  const n = segmentIndex + 1;
-  return {
-    pending: `_Transcript pending (part ${n})._`,
-    unavailable: `_Transcription unavailable (part ${n})._`,
-  };
-}
-
-/**
- * A valid segment index (integer ≥ 0) off attachment metadata, else
- * `undefined` — the un-segmented path. Client-set at link time; anything that
- * isn't a non-negative integer falls back to the bare markers rather than
- * fabricating a `(part N)`.
+ * On a successful (re)transcription of a legacy in-body memo, the transcript
+ * replaces whichever marker is currently in the body — the original
+ * `_Transcript pending._` on a first-try success, OR `_Transcription
+ * unavailable._` if a prior attempt failed and we're now retrying. Matching
+ * both means a retried success lands in the same spot a first-try success
+ * would, preserving the surrounding capture body (the `![[memo]]` embed,
+ * the `_Recorded …_` line, the header).
+ *
+ * Deliberately NO `/g` flag — `.replace` swaps only the FIRST match. A
+ * canonical capture body holds exactly one marker, so first-match is the
+ * correct target. `applyFailureMarker`'s includes-guard (no-op when the
+ * marker is already present) prevents markers accumulating across repeated
+ * terminal failures, so the body never carries two of the same marker. A
+ * hand-edited body that somehow contains both markers patches only the
+ * first — accepted (degenerate, operator-induced).
  */
-function segmentIndexOf(meta: { segment_index?: unknown }): number | undefined {
-  const raw = meta.segment_index;
-  return typeof raw === "number" && Number.isInteger(raw) && raw >= 0 ? raw : undefined;
-}
+const TRANSCRIPT_SUCCESS_TARGET = /_Transcript pending\._|_Transcription unavailable\._/;
 
 /**
  * Default sweep cadence (ms). The sweep is the safety net for backoff-
@@ -211,14 +195,6 @@ interface PendingMeta {
    * worker preserves the original stub-patching behavior (Lens flow).
    */
   transcribe_origin?: "auto" | "legacy";
-  /**
-   * Voice W2 (segmented recordings): a client-set 0-based index marking this
-   * attachment as one segment of a longer recording sliced into ~10-min parts,
-   * all linked on ONE note. When present, the legacy in-body path targets this
-   * part's markers (`… (part N)._`, N = segment_index + 1) rather than the bare
-   * ones — making per-part ordering structurally guaranteed. See `markersFor`.
-   */
-  segment_index?: number;
   [k: string]: unknown;
 }
 
@@ -381,28 +357,17 @@ export function startTranscriptionWorker(opts: TranscriptionWorkerOpts): Transcr
    * attachment failure we're trying to record.
    *
    * Body policy (finding F — never destroy content):
-   *   - Pending marker PRESENT → surgical replace of the pending marker with
-   *     the failure marker. The `![[memo]]` embed + any surrounding text
-   *     survive. For a segmented attachment (`segment_index` set) this is the
-   *     per-part `_Transcript pending (part N)._`; otherwise the bare marker.
-   *   - Failure marker ALREADY PRESENT → no-op (idempotent; a double-terminal-
-   *     failure must not stack markers).
-   *   - Otherwise (pending marker absent — the user edited the note while it
-   *     was pending) → APPEND `\n\n` + failure marker to the existing content.
-   *     The old code full-replaced the body here, destroying the embed AND the
-   *     user's edits. We append instead so nothing is lost. If the content is
-   *     empty, the marker alone becomes the body (avoids a leading blank line).
+   *   - Placeholder PRESENT → surgical replace of `_Transcript pending._`
+   *     with the marker. The `![[memo]]` embed + any surrounding text survive.
+   *   - Marker ALREADY PRESENT → no-op (idempotent; a double-terminal-failure
+   *     must not stack markers).
+   *   - Otherwise (placeholder absent — the user edited the note while it was
+   *     pending) → APPEND `\n\n` + marker to the existing content. The old
+   *     code full-replaced the body here, destroying the embed AND the user's
+   *     edits. We append instead so nothing is lost. If the content is empty,
+   *     the marker alone becomes the body (avoids a leading blank line).
    */
-  async function applyFailureMarker(
-    store: Store,
-    noteId: string,
-    segmentIndex: number | undefined,
-  ): Promise<void> {
-    // Bare markers by default; this segment's `(part N)` markers when the
-    // attachment carries a `segment_index` (voice W2). String-search replace
-    // targets the FIRST occurrence (a canonical body holds exactly one), and
-    // the includes-guard below keeps a repeated terminal failure from stacking.
-    const { pending, unavailable } = markersFor(segmentIndex);
+  async function applyFailureMarker(store: Store, noteId: string): Promise<void> {
     // OC-guarded (vault#435): the read-transform-write below is re-run against
     // fresh content on a conflict so a concurrent user edit isn't clobbered.
     // The transform is pure w.r.t. the note it's handed; the stub-set and
@@ -416,24 +381,17 @@ export function startTranscriptionWorker(opts: TranscriptionWorkerOpts): Transcr
         if (noteMeta.transcribe_stub !== true) return null;
 
         let body: string;
-        if (note.content.includes(pending)) {
-          // Function replacer so the search string is treated literally and the
-          // (fixed) failure marker is inserted verbatim.
-          body = note.content.replace(pending, () => unavailable);
-        } else if (note.content.includes(unavailable)) {
+        if (TRANSCRIPT_PLACEHOLDER.test(note.content)) {
+          body = note.content.replace(TRANSCRIPT_PLACEHOLDER, TRANSCRIPT_UNAVAILABLE);
+        } else if (note.content.includes(TRANSCRIPT_UNAVAILABLE)) {
           // Marker already present — nothing to do. Clear the stub and
           // return without rewriting the body so we don't stack markers.
           body = note.content;
         } else {
           body = note.content.length > 0
-            ? `${note.content}\n\n${unavailable}`
-            : unavailable;
+            ? `${note.content}\n\n${TRANSCRIPT_UNAVAILABLE}`
+            : TRANSCRIPT_UNAVAILABLE;
         }
-        // Segmented: the stub is SHARED across this note's parts — keep it set
-        // so sibling parts still resolve their own slots. Return content only
-        // (leave note metadata untouched). Un-segmented: clear the one-shot
-        // stub as before (byte-unchanged).
-        if (segmentIndex !== undefined) return { content: body };
         const { transcribe_stub: _drop, ...restMeta } = noteMeta;
         return { content: body, metadata: restMeta };
       },
@@ -491,12 +449,6 @@ export function startTranscriptionWorker(opts: TranscriptionWorkerOpts): Transcr
     // vs. the legacy stub-patching path (Lens flow). Auto-write notes also
     // surface failures so the user can retry from the transcript note.
     const isAutoOrigin = meta.transcribe_origin === "auto";
-    // Voice W2: when this attachment is one segment of a longer recording
-    // (client-set `segment_index`), the legacy in-body path targets this
-    // part's markers instead of the bare ones. Undefined for un-segmented
-    // attachments — byte-unchanged behavior. Only the legacy path consults it;
-    // the auto/transcript-note path is untouched (segments are a memo concern).
-    const segmentIndex = segmentIndexOf(meta);
 
     // Honor backoff — we re-check here in case another tick queued this
     // attachment between the listing and now.
@@ -517,7 +469,7 @@ export function startTranscriptionWorker(opts: TranscriptionWorkerOpts): Transcr
       if (isAutoOrigin) {
         await writeFailureTranscriptNote(store, attachment, "audio file not found", undefined, undefined);
       } else {
-        await applyFailureMarker(store, attachment.noteId, segmentIndex);
+        await applyFailureMarker(store, attachment.noteId);
       }
       return;
     }
@@ -575,7 +527,7 @@ export function startTranscriptionWorker(opts: TranscriptionWorkerOpts): Transcr
         if (isAutoOrigin) {
           await writeFailureTranscriptNote(store, attachment, errMsg, apiErr?.code, undefined);
         } else {
-          await applyFailureMarker(store, attachment.noteId, segmentIndex);
+          await applyFailureMarker(store, attachment.noteId);
         }
         // retention=never drops the audio on any terminal state, including
         // failure. The user opted in to "I don't want the audio kept around
@@ -626,16 +578,6 @@ export function startTranscriptionWorker(opts: TranscriptionWorkerOpts): Transcr
       // before the transcript arrives opts out of the overwrite. OC-guarded
       // (vault#435): re-applied against fresh content on a conflict so a
       // concurrent user edit isn't clobbered.
-      //
-      // Success replaces whichever of THIS part's markers is present (bare, or
-      // `(part N)` when segmented). Built with no `/g` flag so `.replace`
-      // swaps only the FIRST match — a canonical capture body holds exactly
-      // one marker per part; alternation preserves positional-first semantics
-      // (a retried success replaces the failure marker where a first-try
-      // success replaced the pending one) so byte-for-byte matching today's
-      // un-segmented behavior.
-      const { pending, unavailable } = markersFor(segmentIndex);
-      const successTarget = new RegExp(`${escapeRegExp(pending)}|${escapeRegExp(unavailable)}`);
       await applyNoteTransformWithOC(
         store,
         attachment.noteId,
@@ -644,31 +586,28 @@ export function startTranscriptionWorker(opts: TranscriptionWorkerOpts): Transcr
           const noteMeta = (note.metadata as Record<string, unknown> | undefined) ?? {};
           if (noteMeta.transcribe_stub !== true) return null;
           // Body policy (finding F — never destroy content):
-          //   - pending OR failure marker present → surgical replace in place.
-          //     The embed + surrounding capture body survive.
+          //   - placeholder OR failure-marker present → surgical replace in
+          //     place (a retried success replaces the `_Transcription
+          //     unavailable._` marker, landing exactly where a first-try
+          //     success would). The embed + surrounding capture body survive.
           //   - neither present (user edited the note while pending) → APPEND
           //     the transcript instead of full-replacing the body, so the
           //     user's edits + the `![[memo]]` embed are preserved. The old
           //     code full-replaced here, which destroyed both.
           let body: string;
-          if (successTarget.test(note.content)) {
+          if (TRANSCRIPT_SUCCESS_TARGET.test(note.content)) {
             // Function replacer, NOT a string — speech-to-text is arbitrary
             // user content, and String.replace treats `$&`, `$\``, `$'`,
             // `$1`-`$9` as special patterns in a string replacement. A
             // transcript containing `$&` would otherwise inject the matched
             // marker text into the body. `() => transcript` returns the text
             // verbatim.
-            body = note.content.replace(successTarget, () => transcript);
+            body = note.content.replace(TRANSCRIPT_SUCCESS_TARGET, () => transcript);
           } else {
             body = note.content.length > 0
               ? `${note.content}\n\n${transcript}`
               : transcript;
           }
-          // Segmented: the stub is SHARED across this note's parts — keep it
-          // set so sibling parts still resolve their own slots. Return content
-          // only (leave note metadata untouched). Un-segmented: clear the
-          // one-shot stub as before (byte-unchanged).
-          if (segmentIndex !== undefined) return { content: body };
           const { transcribe_stub: _drop, ...restMeta } = noteMeta;
           return { content: body, metadata: restMeta };
         },

package/src/vault.test.ts

@@ -2139,22 +2139,6 @@ describe("HTTP /notes", async () => {
     expect(body[0]).not.toHaveProperty("content");
     expect(body[0]).toHaveProperty("byteSize");
     expect(body[0]).toHaveProperty("preview");
-    expect(body[0]).toHaveProperty("displayTitle");
-  });
-
-  // Title axis (ratified 2026-07-17) — displayTitle on the REST lean shape.
-  test("GET /notes lean shape carries the computed displayTitle", async () => {
-    await store.createNote("# Meeting Notes\nagenda: budget", { path: "meeting" });
-    const res = await handleNotes(mkReq("GET", "/notes"), store, "");
-    const body = await res.json() as any[];
-    expect(body[0].displayTitle).toBe("Meeting Notes");
-  });
-
-  test("GET /notes lean shape reports null displayTitle for an empty note", async () => {
-    await store.createNote("", { path: "empty" });
-    const res = await handleNotes(mkReq("GET", "/notes"), store, "");
-    const body = await res.json() as any[];
-    expect(body[0].displayTitle).toBeNull();
   });
 
   test("GET /notes?include_content=true returns full notes", async () => {
@@ -6625,15 +6609,8 @@ describe("stateless MCP transport", async () => {
     expect(toolNames).not.toContain("merge-tags");
     // Admin tools (vault#376) are hidden too
     expect(toolNames).not.toContain("manage-token");
-    // request-attachment-download and read-attachment are read-tier
-    // (upload is write-tier).
-    expect(toolNames).toContain("request-attachment-download");
-    expect(toolNames).not.toContain("request-attachment-upload");
-    expect(toolNames).toContain("read-attachment");
-    // Read tier is exactly 7 tools (doctor added by the re-tier;
-    // request-attachment-download by the attachment-tickets design;
-    // read-attachment by Wave 2).
-    expect(toolNames.length).toBe(7);
+    // Read tier is exactly 5 tools (doctor added by the re-tier).
+    expect(toolNames.length).toBe(5);
 
     closeAllStores();
   });
@@ -6914,23 +6891,15 @@ describe("MCP tools/list scope tiers (vault#376)", () => {
     return names;
   }
 
-  test("vault:read sees exactly the 7 read tools (doctor moved admin → read; read-attachment and request-attachment-download are read-tier)", async () => {
+  test("vault:read sees exactly the 5 read tools (doctor moved admin → read)", async () => {
     const names = await listToolNames(["vault:read"]);
     expect(new Set(names)).toEqual(
-      new Set([
-        "query-notes",
-        "list-tags",
-        "find-path",
-        "vault-info",
-        "doctor",
-        "request-attachment-download",
-        "read-attachment",
-      ]),
+      new Set(["query-notes", "list-tags", "find-path", "vault-info", "doctor"]),
     );
-    expect(names.length).toBe(7);
+    expect(names.length).toBe(5);
   });
 
-  test("vault:read + vault:write sees the 11 read+write tools (tag-schema tools moved write → admin; request-attachment-upload is write-tier)", async () => {
+  test("vault:read + vault:write sees the 8 read+write tools (tag-schema tools moved write → admin)", async () => {
     const names = await listToolNames(["vault:read", "vault:write"]);
     expect(new Set(names)).toEqual(
       new Set([
@@ -6942,12 +6911,9 @@ describe("MCP tools/list scope tiers (vault#376)", () => {
         "create-note",
         "update-note",
         "delete-note",
-        "request-attachment-upload",
-        "request-attachment-download",
-        "read-attachment",
       ]),
     );
-    expect(names.length).toBe(11);
+    expect(names.length).toBe(8);
     expect(names).not.toContain("manage-token");
     // Re-tier (this PR): update-tag/delete-tag/rename-tag/merge-tags are now
     // admin-tier — structure/taxonomy curation, not content authorship.
@@ -6959,7 +6925,7 @@ describe("MCP tools/list scope tiers (vault#376)", () => {
     expect(names).toContain("delete-note");
   });
 
-  test("vault:admin sees all 17 tools including manage-token + prune-schema + the tag-schema tools + all three attachment tools", async () => {
+  test("vault:admin sees all 14 tools including manage-token + prune-schema + the tag-schema tools", async () => {
     const names = await listToolNames(["vault:read", "vault:write", "vault:admin"]);
     expect(names).toContain("manage-token");
     expect(names).toContain("prune-schema");
@@ -6968,13 +6934,10 @@ describe("MCP tools/list scope tiers (vault#376)", () => {
     expect(names).toContain("delete-tag");
     expect(names).toContain("rename-tag");
     expect(names).toContain("merge-tags");
-    expect(names).toContain("request-attachment-upload");
-    expect(names).toContain("request-attachment-download");
-    expect(names).toContain("read-attachment");
-    expect(names.length).toBe(17);
+    expect(names.length).toBe(14);
   });
 
-  test("legacy-derived full token sees all 17 tools (back-compat)", async () => {
+  test("legacy-derived full token sees all 14 tools (back-compat)", async () => {
     const { handleScopedMcp } = await import("./mcp-http.ts");
     const { writeVaultConfig } = await import("./config.ts");
     const { closeAllStores } = await import("./vault-store.ts");
@@ -7007,7 +6970,7 @@ describe("MCP tools/list scope tiers (vault#376)", () => {
     } as any);
     const body = await res.json() as any;
     const names: string[] = body.result.tools.map((t: any) => t.name);
-    expect(names.length).toBe(17);
+    expect(names.length).toBe(14);
     expect(names).toContain("manage-token");
     expect(names).toContain("prune-schema");
     expect(names).toContain("doctor");

package/core/src/attachment/bytes-provider.ts

@@ -1,65 +0,0 @@
-/**
- * `AttachmentBytesProvider` — the model-lane (Wave 2) byte-access seam.
- * Mirrors `AttachmentTicketProvider` (`./tickets.ts`): a per-door
- * implementation binds this to its own storage (bun: local fs, see
- * `src/attachment-bytes.ts`; a future cloud implementation: ranged R2 GETs
- * through the vault DO). Core stays storage-unaware — the `read-attachment`
- * tool (`core/src/mcp.ts`) calls only through this interface, so bun and a
- * future cloud implementation can never drift on the read contract.
- *
- * Deliberately narrow: stat + a bounded positional read, plus one optional
- * hook for the audio transcript pointer. All POLICY (mime-family dispatch,
- * size caps, range validation, tag-scope) lives in the `read-attachment`
- * tool itself — same division as the ticket seam (`GenerateMcpToolsOpts`'s
- * doc comment in `core/src/mcp.ts`).
- *
- * D10 (attachments-for-agents design): "tools omitted when unwired" — a
- * door that hasn't wired this seam simply never passes `attachmentBytes` to
- * `generateMcpTools`, so `read-attachment` is absent from `tools/list`
- * entirely, not merely erroring on call.
- */
-
-import type { Attachment } from "../types.js";
-
-/**
- * 4 MiB raw-bytes cap on the image branch of `read-attachment` (D3): the
- * largest honest budget under Claude's ~5 MB image API limit, with room for
- * base64 blow-up (~5.6 MiB on the wire) and DO-transient headroom on a
- * future cloud implementation. Enforced BEFORE a read is attempted — the
- * tool calls `stat()` first and refuses over-cap without ever calling
- * `readRange()`.
- */
-export const MAX_ATTACHMENT_IMAGE_BYTES = 4 * 1024 * 1024;
-
-export interface AttachmentBytesProvider {
-  /**
-   * Byte size of the attachment's stored bytes, or `null` when the row
-   * exists but its bytes don't — e.g. an `audio_retention` eviction after a
-   * successful transcription (`src/transcription-worker.ts` unlinks the
-   * file on `until_transcribed` / `never` retention), or any other
-   * out-of-band loss. Drives the `attachment_binary_missing` refusal.
-   */
-  stat(attachment: Attachment): Promise<{ size: number } | null>;
-  /**
-   * Read the half-open byte range `[start, end)`. Bounded by construction —
-   * callers never ask for the whole file when only a window is needed (the
-   * text path); the image path DOES read start-to-end, but only after
-   * `stat()` has already confirmed the file is under
-   * {@link MAX_ATTACHMENT_IMAGE_BYTES}. `start`/`end` are always within
-   * `[0, size]` as reported by a prior `stat()` call on the same attachment
-   * — implementations don't need to re-clamp defensively, though doing so
-   * costs nothing.
-   */
-  readRange(attachment: Attachment, start: number, end: number): Promise<Uint8Array>;
-  /**
-   * OPTIONAL: resolve the sibling transcript note for a completed
-   * audio/video transcription (bun: `<attachment-path>.transcript`, see
-   * `transcriptPathFor` in `src/transcript-note.ts`). Omitted by a door
-   * whose transcript instead lives in the owning note's body (the design's
-   * cloud path, D... — no separate sibling note to point at) — the
-   * `read-attachment` audio branch falls back to `note_id` alone (the
-   * owning note) in that case, per the design's "on cloud the transcript
-   * lives in the owning note's body, so `note_id` is the pointer."
-   */
-  resolveTranscriptNote?(attachment: Attachment): Promise<{ id: string; path: string } | null>;
-}