@openparachute/vault 0.6.4-rc.6 → 0.6.4-rc.7

package/README.md

@@ -586,16 +586,12 @@ Range params require content in the response — with `include_content=false` (o
 
 ### Incremental rebuilds: "what changed since X"
 
-The SSG / sync pattern. Two equivalent forms — bracket-style is canonical going forward; the flat form is the same shape that ships through the REST/MCP date filter today.
+The SSG / sync pattern. Bracket-style is the query-string date filter. (The flat `date_field` / `date_from` / `date_to` params were removed in 0.6.4 — vault#288 — and are now ignored.)
 
 ```bash
-# Bracket-style (canonical)
+# Bracket-style (the query-string date filter)
 curl -H "Authorization: Bearer $VAULT_TOKEN" \
   "http://localhost:1940/vault/default/api/notes?meta[updated_at][gte]=2026-04-01T00:00:00Z"
-
-# Flat form (DEPRECATED in 0.4.3; planned removal in a later 0.x per vault#288)
-curl -H "Authorization: Bearer $VAULT_TOKEN" \
-  "http://localhost:1940/vault/default/api/notes?date_field=updated_at&date_from=2026-04-01T00:00:00Z"
 ```
 
 ```jsonc

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openparachute/vault",
-  "version": "0.6.4-rc.6",
+  "version": "0.6.4-rc.7",
   "description": "Agent-native knowledge graph. Notes, tags, links over MCP.",
   "module": "src/cli.ts",
   "type": "module",

package/src/routes.ts

@@ -328,7 +328,7 @@ function parseMetaBrackets(url: URL): {
         return {
           error: json(
             {
-              error: `bracket-date filter on \`${field}\` supports only \`gte\` (inclusive lower bound) and \`lt\` (exclusive upper bound). Got: \`${op}\`. The dateFilter contract uses these two ops because the equivalent flat shape (\`date_field=${field}&date_from=…&date_to=…\`) is half-open by design.`,
+              error: `bracket-date filter on \`${field}\` supports only \`gte\` (inclusive lower bound) and \`lt\` (exclusive upper bound). Got: \`${op}\`. The dateFilter contract is half-open by design.`,
               code: "INVALID_QUERY",
             },
             400,
@@ -623,20 +623,13 @@ export function parseNotesQueryOpts(url: URL): {
     lastUpdatedBy: parseQuery(url, "last_updated_by") ?? undefined,
     createdVia: parseQuery(url, "created_via") ?? undefined,
     lastUpdatedVia: parseQuery(url, "last_updated_via") ?? undefined,
-    ...(bracket.dateFilter
-      ? { dateFilter: bracket.dateFilter }
-      : parseQuery(url, "date_field")
-        ? {
-            dateFilter: {
-              field: parseQuery(url, "date_field")!,
-              from: parseQuery(url, "date_from") ?? undefined,
-              to: parseQuery(url, "date_to") ?? undefined,
-            },
-          }
-        : {
-            dateFrom: parseQuery(url, "date_from") ?? undefined,
-            dateTo: parseQuery(url, "date_to") ?? undefined,
-          }),
+    // Date-range filtering on the query string is bracket-style only:
+    // `?meta[created_at][gte]=…&meta[created_at][lt]=…` (see
+    // `parseMetaBrackets`). The flat `date_field` / `date_from` / `date_to`
+    // params were removed in 0.6.4 (vault#288, breaking) — they are now
+    // ignored. The MCP `date_from` / `date_to` shorthand is a separate,
+    // supported convenience and is unaffected.
+    ...(bracket.dateFilter ? { dateFilter: bracket.dateFilter } : {}),
     sort: (parseQuery(url, "sort") as "asc" | "desc") ?? undefined,
     orderBy: parseQuery(url, "order_by") ?? undefined,
     limit: parseInt10(parseQuery(url, "limit")) ?? 50,
@@ -907,7 +900,7 @@ async function handleNotesInner(
 
       // Structured query
       //
-      // Two filter syntaxes coexist on this endpoint:
+      // Date-range filtering on the query string uses one syntax:
       //
       //   - **Bracket-style** (canonical, vault#285 friction point 1.3):
       //     `?meta[field][op]=value` / `?meta[created_at][gte]=…`. Exposes
@@ -915,21 +908,18 @@ async function handleNotesInner(
       //     not_in/exists) and the dateFilter bridge through one consistent
       //     shape. See `parseMetaBrackets` for the grammar.
       //
-      //   - **Flat date params** (DEPRECATED): `?date_field=created_at&
-      //     date_from=…&date_to=…` and the legacy `?date_from=…&date_to=…`.
-      //     Still functional through 0.5.x; planned removal in a later 0.x
-      //     (vault#288). New consumers should use bracket-style.
-      //
-      // Precedence on overlap: bracket-style wins. If a caller passes both
-      // `meta[created_at][gte]=X` and `date_field=created_at&date_from=Y`,
-      // the bracket form is the dateFilter the engine sees; the flat
-      // params are silently dropped. We don't error — the bracket form is
-      // documented as canonical, and rejecting the overlap would block a
-      // realistic migration path where a caller half-converted their code.
+      // The flat date params (`?date_field=created_at&date_from=…&date_to=…`
+      // and the legacy bare `?date_from=…&date_to=…`) were REMOVED in 0.6.4
+      // (vault#288, breaking change). They are now silently ignored — a
+      // request that passes only flat date params comes back unfiltered.
+      // Bracket-style is functionally complete (full operator set), so no
+      // capability was lost. Migrate `date_field=created_at&date_from=X` to
+      // `meta[created_at][gte]=X` (and `date_to=Y` to `meta[created_at][lt]=Y`).
       //
       // Surface asymmetry: REST flattens to a query string; MCP takes a
-      // nested `date_filter: { field, from, to }` object directly. Both
-      // lower to the same store-level `dateFilter` shape.
+      // nested `date_filter: { field, from, to }` object directly (plus a
+      // top-level `date_from` / `date_to` shorthand, which is unaffected by
+      // this removal). Both lower to the same store-level `dateFilter` shape.
       // Structured-query parsing is shared with the live `/subscribe` route
       // (see `parseNotesQueryOpts`) so both endpoints lower an identical query
       // string to the same `QueryOpts` — predicate parity by construction.

package/src/subscribe.test.ts

@@ -416,9 +416,12 @@ describe("handleSubscribe — rejected query shapes", () => {
     expect(body.error).toContain("has_links");
   });
 
-  it("date filter → 400 (M1) — legacy date_from", async () => {
+  it("date filter → 400 (M1) — bracket date_filter on created_at", async () => {
+    // The flat `date_from` param was removed in 0.6.4 (vault#288) and is now
+    // ignored, so it no longer reaches the M1 date guard. Bracket-style is the
+    // only query-string date filter; assert it's still rejected for live subs.
     const res = await handleSubscribe(
-      subscribeReq("date_from=2026-01-01"),
+      subscribeReq("meta%5Bcreated_at%5D%5Bgte%5D=2026-01-01"),
       store,
       VAULT,
       unscopedScope(),
@@ -430,6 +433,24 @@ describe("handleSubscribe — rejected query shapes", () => {
     expect(body.error).toContain("date");
   });
 
+  it("flat date_from is ignored → subscription created (vault#288 removal)", async () => {
+    // Documents the breaking change: the removed flat param no longer reaches
+    // the date guard, so a sub that ONLY carries it is now a valid (unfiltered)
+    // subscription rather than a 400.
+    const res = await handleSubscribe(
+      subscribeReq("date_from=2026-01-01"),
+      store,
+      VAULT,
+      unscopedScope(),
+      manager,
+    );
+    expect(res.status).toBe(200);
+    expect(res.headers.get("Content-Type")).toBe("text/event-stream");
+    const r = sseReader(res);
+    await r.pump();
+    await r.close();
+  });
+
   it("date filter → 400 (M1) — bracket date_filter on updated_at", async () => {
     const res = await handleSubscribe(
       subscribeReq("meta%5Bupdated_at%5D%5Bgte%5D=2026-01-01"),

package/src/vault.test.ts

@@ -1862,13 +1862,15 @@ describe("HTTP /notes", async () => {
     expect(body.map((n) => n.content)).toEqual(["plain"]);
   });
 
-  // ---- updated_at filter via date_field (vault#285 friction point 1.5) ----
+  // ---- updated_at filter via bracket date (vault#285 friction point 1.5) ----
   //
-  // HTTP plumbing routes `date_field=updated_at&date_from=…` straight to
-  // the core `dateFilter` resolver, which now recognizes `updated_at` as
-  // a real column. Smoke-tests the end-to-end HTTP path; the engine-side
-  // semantics are exercised in core.test.ts.
-  test("GET /notes?date_field=updated_at filters by last-write time", async () => {
+  // HTTP plumbing routes `meta[updated_at][gte]=…` straight to the core
+  // `dateFilter` resolver, which recognizes `updated_at` as a real column.
+  // Smoke-tests the end-to-end HTTP path; the engine-side semantics are
+  // exercised in core.test.ts. (The flat `date_field=updated_at&date_from=…`
+  // shape was removed in 0.6.4 — vault#288 — bracket-style is the only
+  // query-string date filter.)
+  test("GET /notes?meta[updated_at][gte]=… filters by last-write time", async () => {
     const a = await store.createNote("untouched", { id: "ua", path: "ua" });
     const b = await store.createNote("modified", { id: "ub", path: "ub" });
     // Bump b's updated_at into the test window, leave a's at its createdAt.
@@ -1878,7 +1880,7 @@ describe("HTTP /notes", async () => {
       .run("2026-04-25T00:00:00.000Z", b.id);
 
     const res = await handleNotes(
-      mkReq("GET", "/notes?date_field=updated_at&date_from=2026-04-01&include_content=true"),
+      mkReq("GET", "/notes?meta[updated_at][gte]=2026-04-01&include_content=true"),
       store,
       "",
     );
@@ -2880,7 +2882,7 @@ describe("HTTP /notes", async () => {
     });
 
     // ---- Bridge: created_at / updated_at via brackets route to dateFilter ----
-    test("`meta[created_at][gte]=…` routes to dateFilter (same result as flat date_field)", async () => {
+    test("`meta[created_at][gte]=…` routes to dateFilter", async () => {
       await store.createNote("old", { created_at: "2026-01-15T00:00:00.000Z" });
       await store.createNote("new", { created_at: "2026-04-15T00:00:00.000Z" });
 
@@ -2890,14 +2892,37 @@ describe("HTTP /notes", async () => {
         "",
       );
       const bracketBody = await bracketRes.json() as any[];
-      const flatRes = await handleNotes(
+      expect(bracketBody.map((n) => n.content)).toEqual(["new"]);
+    });
+
+    // ---- Removed: flat date params are now ignored (vault#288, breaking) ----
+    // The flat `date_field` / `date_from` / `date_to` query params were
+    // removed in 0.6.4. A request that passes ONLY the flat shape is no
+    // longer date-filtered — it comes back unfiltered. Use bracket-style
+    // (`meta[created_at][gte]=…`) instead. (The MCP `date_from`/`date_to`
+    // shorthand is a separate, supported path and is unaffected.)
+    test("flat date params (date_field/date_from/date_to) are ignored", async () => {
+      await store.createNote("old", { created_at: "2026-01-15T00:00:00.000Z" });
+      await store.createNote("new", { created_at: "2026-04-15T00:00:00.000Z" });
+
+      const targetedRes = await handleNotes(
         mkReq("GET", "/notes?date_field=created_at&date_from=2026-04-01&include_content=true"),
         store,
         "",
       );
-      const flatBody = await flatRes.json() as any[];
-      expect(bracketBody.map((n) => n.content)).toEqual(["new"]);
-      expect(bracketBody.map((n) => n.content)).toEqual(flatBody.map((n) => n.content));
+      const targetedBody = await targetedRes.json() as any[];
+      expect(targetedRes.status).toBe(200);
+      // Both notes returned — the flat param did not filter.
+      expect(targetedBody.map((n) => n.content).sort()).toEqual(["new", "old"]);
+
+      const bareRes = await handleNotes(
+        mkReq("GET", "/notes?date_from=2026-04-01&include_content=true"),
+        store,
+        "",
+      );
+      const bareBody = await bareRes.json() as any[];
+      expect(bareRes.status).toBe(200);
+      expect(bareBody.map((n) => n.content).sort()).toEqual(["new", "old"]);
     });
 
     test("`meta[updated_at][gte]=…` routes to dateFilter on n.updated_at", async () => {
@@ -3047,13 +3072,14 @@ describe("HTTP /notes", async () => {
       expect(body.error).toContain("not_in");
     });
 
-    // ---- Precedence on overlap ----
-    test("when both flat and bracket date params overlap, bracket wins", async () => {
+    // ---- Bracket applies; co-passed flat params are ignored (vault#288) ----
+    test("bracket date filter applies even when removed flat params are also passed", async () => {
       await store.createNote("old", { created_at: "2026-01-15T00:00:00.000Z" });
       await store.createNote("new", { created_at: "2026-04-15T00:00:00.000Z" });
-      // Bracket says "from 2026-04-01"; flat says "from 2020-01-01". If
-      // flat won, both notes would match. The bracket-wins precedence is
-      // verified by getting back only the post-April note.
+      // Bracket says "from 2026-04-01"; the (removed) flat params say "from
+      // 2020-01-01". The flat params are now inert, so only the bracket
+      // filter applies — back comes only the post-April note. (Pre-0.6.4
+      // this exercised bracket-wins precedence; flat is now simply ignored.)
       const res = await handleNotes(
         mkReq(
           "GET",