@openparachute/hub 0.5.13 → 0.5.14-rc.10

package/src/vault/auth-status.ts

@@ -1,29 +1,47 @@
 /**
- * Read-only probe of vault's auth state, for the post-exposure preflight
- * nudge. We don't want to lock the DB or mutate anything — this is a
- * one-shot "should we warn the user their vault is wide open on the public
+ * Read-only probe of operator auth state, for the post-exposure preflight
+ * nudge. We don't want to lock anything or mutate state — this is a one-
+ * shot "should we warn the user their vault is wide open on the public
  * internet?" check.
  *
- * Two sources:
- *   1. ~/.parachute/vault/config.yaml   → owner_password_hash + totp_secret
- *   2. ~/.parachute/vault/data/<name>/vault.db (SQLite) → tokens table count
+ * Three sources, checked in this order:
  *
- * The YAML path uses line-anchored regex parsing that matches vault's own
- * `readGlobalConfig()` semantics (parachute-vault src/config.ts): keys are
- * optional, quoted scalars, and empty-string / missing-key both mean "not
- * configured." We mirror that rather than bringing in a YAML dependency.
+ *   1. ~/.parachute/hub.db  →  users table (authoritative since multi-user
+ *      Phase 1, hub#252 / PRs 279–281 / 425). Hub-issued OAuth + browser
+ *      sign-in both verify against `users.password_hash`. If any user row
+ *      exists with a non-empty password_hash, the operator has an account —
+ *      "owner password set." The earliest-created user row is the canonical
+ *      operator (cf. `getFirstAdminId` in src/users.ts).
+ *   2. ~/.parachute/vault/config.yaml  →  owner_password_hash + totp_secret
+ *      (pre-multi-user Phase 1 location). Fallback for super-old installs
+ *      whose hub.db is absent or empty.
+ *   3. ~/.parachute/vault/data/<name>/vault.db (SQLite) → tokens table
+ *      count, summed across every vault instance.
  *
- * The SQLite path is best-effort: if the DB is missing, locked (vault is
- * writing), or the schema has drifted, `tokenCount` comes back as `null`
- * and the caller surfaces "token status unknown" rather than lying with a
- * false zero. The exposure flow has already succeeded by the time this
- * runs — a probe failure must never block the user's happy path.
+ * The hub.db schema doesn't yet carry a TOTP column (2FA lands in a later
+ * phase per the multi-user design doc); we always report `hasTotp: false`
+ * when the hub.db path is the source of truth. That matches what's
+ * actually shipped — pretending otherwise would whisper "you're covered"
+ * when no second factor exists.
  *
- * Schema coupling note: we read the `tokens` table by name with a bare
- * COUNT(*). If vault ever renames that table, that's a breaking change on
- * vault's side and this probe is the least of the fallout. Post-launch,
- * a public `/api/auth/status` endpoint on vault (tracked separately) would
- * let us drop this coupling entirely.
+ * The YAML fallback path uses line-anchored regex parsing that matches
+ * vault's own `readGlobalConfig()` semantics (parachute-vault src/config.ts):
+ * keys are optional, quoted scalars, and empty-string / missing-key both
+ * mean "not configured." We mirror that rather than bringing in a YAML
+ * dependency.
+ *
+ * The vault-token SQLite path is best-effort: if the DB is missing,
+ * locked (vault is writing), or the schema has drifted, `tokenCount`
+ * comes back as `null` and the caller surfaces "token status unknown"
+ * rather than lying with a false zero. The exposure flow has already
+ * succeeded by the time this runs — a probe failure must never block
+ * the user's happy path.
+ *
+ * Schema coupling note: we read the `tokens` table in each vault.db by
+ * name with a bare COUNT(*). If vault ever renames that table, that's a
+ * breaking change on vault's side and this probe is the least of the
+ * fallout. Post-launch, a public `/api/auth/status` endpoint on vault
+ * (tracked separately) would let us drop this coupling entirely.
  */
 
 import { existsSync, readFileSync, readdirSync } from "node:fs";
@@ -36,9 +54,12 @@ export interface VaultAuthStatus {
   hasTotp: boolean;
   /**
    * `null` means we couldn't read the SQLite DB — distinct from "0 tokens
-   * exist." Callers branch the UI on this: `null` → "token status unknown,
-   * run `parachute vault tokens list` to check"; `0` → loud "no auth at
-   * all!" warning; `>0` → benign.
+   * exist." Post the pvt_* DROP (hub#466) the expose preflight no longer
+   * branches on this — `classify()` in expose-auth-preflight.ts gates on
+   * `hasOwnerPassword`, since access now flows through the owner password +
+   * on-demand hub JWT mint, not standing vault tokens. `tokenCount` is kept
+   * as a best-effort diagnostic only (these rows are vestigial); `null`
+   * still cleanly distinguishes "unreadable DB" from "0 rows."
    */
   tokenCount: number | null;
   /** Vault instance names discovered under data/. Empty when vault has
@@ -49,6 +70,8 @@ export interface VaultAuthStatus {
 export interface AuthStatusOpts {
   /** Override `~/.parachute/vault` for tests. */
   vaultHome?: string;
+  /** Override `~/.parachute/hub.db` for tests. */
+  hubDbPath?: string;
   /** Read a YAML file; defaults to `readFileSync(path, "utf8")`. Missing
    *  file should return `undefined` (not throw) so callers can distinguish
    *  "no password configured" from "IO error." */
@@ -60,13 +83,31 @@ export interface AuthStatusOpts {
    *  thrown error (missing, locked, schema drift) is caught by the caller
    *  and mapped to `tokenCount: null`. */
   countTokens?: (dbPath: string) => number;
+  /**
+   * Probe hub.db for "does at least one user row with a non-empty
+   * `password_hash` exist?" — the canonical "owner password is set"
+   * signal post-multi-user-Phase-1. Returning:
+   *   - `true`  → at least one user has a password_hash; hub.db is
+   *               the source of truth, YAML fallback is skipped.
+   *   - `false` → hub.db opened cleanly but users is empty (fresh
+   *               install pre-wizard); fall back to YAML.
+   *   - `undefined` → hub.db missing / unreadable / migration not yet
+   *               applied; fall back to YAML (legacy install path).
+   * The split between `false` and `undefined` matters: an empty hub.db
+   * on a fresh wizard run should NOT be allowed to mask an owner_password_hash
+   * that the operator set via vault's pre-multi-user flow. Callers that
+   * want true "I can sign in" semantics get the OR of hub.db∪YAML.
+   */
+  probeHubDbHasUserPassword?: (dbPath: string) => boolean | undefined;
 }
 
 interface Resolved {
   vaultHome: string;
+  hubDbPath: string;
   readText: (path: string) => string | undefined;
   listVaultNames: (dataDir: string) => string[];
   countTokens: (dbPath: string) => number;
+  probeHubDbHasUserPassword: (dbPath: string) => boolean | undefined;
 }
 
 function defaultVaultHome(): string {
@@ -77,6 +118,11 @@ function defaultVaultHome(): string {
   return root.length > 0 ? join(root, "vault") : join(homedir(), ".parachute", "vault");
 }
 
+function defaultHubDbPath(): string {
+  const root = configDir();
+  return root.length > 0 ? join(root, "hub.db") : join(homedir(), ".parachute", "hub.db");
+}
+
 function defaultReadText(path: string): string | undefined {
   try {
     return readFileSync(path, "utf8");
@@ -112,12 +158,59 @@ function defaultCountTokens(dbPath: string): number {
   }
 }
 
+/**
+ * Open hub.db readonly and ask "does at least one user have a non-empty
+ * password_hash?" Returns `undefined` on any failure (DB missing, locked,
+ * schema drift, users table absent because migration v2 hasn't applied) —
+ * indistinguishable from "no hub.db at all," which is what the caller
+ * wants for the YAML-fallback branch.
+ *
+ * We deliberately do NOT open hub.db read-write here — `openHubDb()`
+ * would run migrations as a side effect, and this is a read probe from
+ * an unrelated command (`parachute expose`). `readonly: true` skips the
+ * WAL handshake and won't contend with the live hub server.
+ */
+function defaultProbeHubDbHasUserPassword(dbPath: string): boolean | undefined {
+  if (!existsSync(dbPath)) return undefined;
+  const { Database } = require("bun:sqlite");
+  let db: { prepare: (sql: string) => { get: () => unknown }; close: () => void } | undefined;
+  try {
+    db = new Database(dbPath, { readonly: true }) as typeof db;
+    // COUNT(*) over users with non-empty password_hash. `length(...) > 0`
+    // matches the "missing/empty hash" treatment from the YAML side.
+    //
+    // Why "any user with a hash" not "first admin specifically": friend
+    // accounts can only be created by an already-authenticated admin
+    // (per api-users.ts's host:admin gate), so any user-with-hash
+    // implies the first admin has one too. Equivalent in practice and
+    // simpler than a JOIN on earliest-created-at. A future env-seed
+    // flow that creates friend accounts before the operator sets a
+    // password would need to revisit this assumption.
+    const row = db
+      ?.prepare(
+        "SELECT COUNT(*) AS n FROM users WHERE password_hash IS NOT NULL AND length(password_hash) > 0",
+      )
+      .get() as { n: number } | null;
+    return (row?.n ?? 0) > 0;
+  } catch {
+    return undefined;
+  } finally {
+    try {
+      db?.close();
+    } catch {
+      // ignore
+    }
+  }
+}
+
 function resolve(opts: AuthStatusOpts): Resolved {
   return {
     vaultHome: opts.vaultHome ?? defaultVaultHome(),
+    hubDbPath: opts.hubDbPath ?? defaultHubDbPath(),
     readText: opts.readText ?? defaultReadText,
     listVaultNames: opts.listVaultNames ?? defaultListVaultNames,
     countTokens: opts.countTokens ?? defaultCountTokens,
+    probeHubDbHasUserPassword: opts.probeHubDbHasUserPassword ?? defaultProbeHubDbHasUserPassword,
   };
 }
 
@@ -134,7 +227,12 @@ function matchQuotedKey(yaml: string, key: string): string | undefined {
   return captured;
 }
 
-function readGlobalAuth(r: Resolved): { hasOwnerPassword: boolean; hasTotp: boolean } {
+interface AuthSignals {
+  hasOwnerPassword: boolean;
+  hasTotp: boolean;
+}
+
+function readYamlAuth(r: Resolved): AuthSignals {
   const yaml = r.readText(join(r.vaultHome, "config.yaml"));
   if (yaml === undefined) return { hasOwnerPassword: false, hasTotp: false };
   return {
@@ -143,6 +241,35 @@ function readGlobalAuth(r: Resolved): { hasOwnerPassword: boolean; hasTotp: bool
   };
 }
 
+/**
+ * Combine the hub.db probe + the legacy YAML probe into a single auth-signals
+ * read. Logic:
+ *
+ *   - hub.db says yes → operator has an account in the canonical store;
+ *     report `hasOwnerPassword: true`. TOTP is reported per the YAML probe
+ *     (so a legacy operator who set both YAML password + YAML totp_secret,
+ *     then migrated to a hub.db user, still surfaces "TOTP is on" — we
+ *     don't have a hub-side TOTP column yet, hub#252 Phase 3 lands it).
+ *   - hub.db says no AND was reachable → users table is empty, no hub
+ *     account exists yet. Fall back to YAML for both signals — a pre-
+ *     multi-user install would have its password in YAML.
+ *   - hub.db unreachable → can't tell, fall back to YAML entirely.
+ *
+ * Net effect: `hasOwnerPassword` is the OR of (hub.db has a user with a
+ * password) ∪ (YAML has owner_password_hash). Either source counts.
+ */
+function readAuthSignals(r: Resolved): AuthSignals {
+  const yaml = readYamlAuth(r);
+  const hubDbHasUser = r.probeHubDbHasUserPassword(r.hubDbPath);
+  const hasOwnerPassword = hubDbHasUser === true ? true : yaml.hasOwnerPassword;
+  return {
+    hasOwnerPassword,
+    // No hub-side TOTP column shipped yet (multi-user Phase 3). Until it
+    // lands, TOTP is YAML-only — matches what's actually true on disk.
+    hasTotp: yaml.hasTotp,
+  };
+}
+
 /**
  * Sum token counts across every vault instance found under data/. If any
  * probe throws (missing DB, locked, schema drift), the whole result
@@ -171,7 +298,7 @@ function readTotalTokenCount(r: Resolved, vaultNames: string[]): number | null {
 
 export function readVaultAuthStatus(opts: AuthStatusOpts = {}): VaultAuthStatus {
   const r = resolve(opts);
-  const { hasOwnerPassword, hasTotp } = readGlobalAuth(r);
+  const { hasOwnerPassword, hasTotp } = readAuthSignals(r);
   const dataDir = join(r.vaultHome, "data");
   const vaultNames = r.listVaultNames(dataDir);
   const tokenCount = readTotalTokenCount(r, vaultNames);

package/src/vault-hub-origin-env.ts

@@ -0,0 +1,100 @@
+/**
+ * Persist the resolved hub PUBLIC origin into `<configDir>/vault/.env` so the
+ * launchd / systemd daemon validates hub-minted JWTs against it.
+ *
+ * The OAuth issuer-mismatch P0 (this module's reason to exist): hub stamps the
+ * public origin (e.g. `https://parachute-x.ts.net`) on every JWT it mints.
+ * Vault, as the resource server, validates the `iss` claim against
+ * `getHubOrigin()` (`parachute-vault/src/hub-jwt.ts`), which reads ONLY
+ * `PARACHUTE_HUB_ORIGIN` from its process env and falls back to loopback
+ * `http://127.0.0.1:1939` when unset.
+ *
+ * `parachute start|restart vault` injects `PARACHUTE_HUB_ORIGIN` into the
+ * *spawn* env (see `commands/lifecycle.ts`). But the real-world boot path on an
+ * owner-operated box is the autostart daemon: `parachute-vault init` registers
+ * a launchd agent (macOS) / systemd unit (Linux) with `KeepAlive`/`Restart`,
+ * and that daemon boots vault out-of-band via `~/.parachute/vault/start.sh`.
+ * The wrapper sources `~/.parachute/vault/.env` and never reads expose-state,
+ * and the launchd plist carries no `EnvironmentVariables`. So on every reboot
+ * or crash-restart, launchd starts vault with NO `PARACHUTE_HUB_ORIGIN`, vault
+ * falls back to loopback, and every token stamped with the public FQDN fails
+ * the `iss` check → `HubJwtError('issuer')` → 401 on every OAuth/MCP reconnect.
+ * Bricks team onboarding on any exposed deploy.
+ *
+ * The durable fix: write `PARACHUTE_HUB_ORIGIN` into `vault/.env` so the daemon
+ * boot path picks it up too. Mirrors `auto-wire.ts`'s vault-.env writes
+ * (SCRIBE_AUTH_TOKEN / SCRIBE_URL) — hub owns these keys, vault's boot wrapper
+ * reads them.
+ */
+import { join } from "node:path";
+import { parseEnvFile, removeEnvLine, upsertEnvLine, writeEnvFile } from "./env-file.ts";
+import { HUB_ORIGIN_ENV } from "./hub-origin.ts";
+
+/**
+ * Loopback origins (`http://127.0.0.1:<port>`, `localhost`, `[::1]`) are the
+ * local-dev fallback `deriveHubOrigin` returns when no exposure is active. We
+ * never *persist* one — baking a loopback value into `.env` would SHADOW a
+ * later exposure on the daemon boot path (which has no other source of truth),
+ * recreating the exact `iss` mismatch this fix prevents. Worse than absent.
+ */
+export function isLoopbackOrigin(origin: string): boolean {
+  try {
+    // URL.hostname keeps IPv6 in bracket form (`[::1]`); strip them so the
+    // comparison is on the bare address.
+    const hostname = new URL(origin).hostname.replace(/^\[|\]$/g, "");
+    // `0.0.0.0` is a bind-all wildcard, not a reachable origin — `deriveHubOrigin`
+    // never emits it, but `--hub-origin http://0.0.0.0:1939` flows straight
+    // through `persistVaultHubOrigin`. Baking it into vault/.env would advertise
+    // a non-functional issuer and recreate the iss-mismatch class this guard
+    // exists to prevent. Refuse it like any other loopback.
+    return (
+      hostname === "127.0.0.1" ||
+      hostname === "localhost" ||
+      hostname === "::1" ||
+      hostname === "0.0.0.0"
+    );
+  } catch {
+    return false;
+  }
+}
+
+function vaultEnvPath(configDir: string): string {
+  return join(configDir, "vault", ".env");
+}
+
+/**
+ * Upsert `PARACHUTE_HUB_ORIGIN=<origin>` into `vault/.env` when `origin` is a
+ * non-loopback public origin. Idempotent — skips the write (and the log) when
+ * the value is already current so repeated `start`s don't churn the file.
+ * Returns true iff the file was written this call.
+ */
+export function persistVaultHubOrigin(
+  configDir: string,
+  origin: string,
+  log: (line: string) => void,
+): boolean {
+  if (isLoopbackOrigin(origin)) return false;
+  const path = vaultEnvPath(configDir);
+  const parsed = parseEnvFile(path);
+  if (parsed.values[HUB_ORIGIN_ENV] === origin) return false;
+  writeEnvFile(path, upsertEnvLine(parsed.lines, HUB_ORIGIN_ENV, origin));
+  log(`  persisted ${HUB_ORIGIN_ENV}=${origin} to ${path} (survives daemon restart)`);
+  return true;
+}
+
+/**
+ * Drop a previously-persisted `PARACHUTE_HUB_ORIGIN` from `vault/.env`. Called
+ * on `expose … off`: once exposure is torn down, a local-only hub mints tokens
+ * with a loopback `iss`, so a stale public origin left in `.env` would itself
+ * cause the mismatch. Removing the line reverts vault to its loopback default
+ * (`getHubOrigin`), which matches what the local hub now stamps. No-op (returns
+ * false) when the key isn't present. Returns true iff the file was rewritten.
+ */
+export function clearVaultHubOrigin(configDir: string, log: (line: string) => void): boolean {
+  const path = vaultEnvPath(configDir);
+  const parsed = parseEnvFile(path);
+  if (parsed.values[HUB_ORIGIN_ENV] === undefined) return false;
+  writeEnvFile(path, removeEnvLine(parsed.lines, HUB_ORIGIN_ENV));
+  log(`  cleared ${HUB_ORIGIN_ENV} from ${path} (exposure torn down)`);
+  return true;
+}