@openparachute/agent 0.2.3-rc.6 → 0.2.3-rc.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openparachute/agent",
-  "version": "0.2.3-rc.6",
+  "version": "0.2.3-rc.7",
   "description": "Vault-native agents for Claude Code — a #agent/definition note + an inbound message becomes a sandboxed claude turn; the reply is written back as a note. Messaging gateway on :1941.",
   "license": "AGPL-3.0",
   "type": "module",

package/src/daemon.ts

@@ -114,6 +114,7 @@ import {
 import { TERMINAL_UI_HTML } from "./terminal-ui.ts";
 import { serveTerminalAsset } from "./terminal-assets.ts";
 import { isSpaPath, serveSpa, spaDistDir } from "./spa-serve.ts";
+import { runBootPreflight, type PreflightResult } from "./preflight.ts";
 import {
   buildSpecFromBody,
   setupProgrammaticSpawn,
@@ -1311,6 +1312,13 @@ export function createFetchHandler(
       url: string;
       tokenPresent: boolean;
     }>;
+    /**
+     * The boot dependency-PREFLIGHT result (agent#156) — surfaced on `/health` so the
+     * admin UI can show that programmatic turns will fail until the missing deps
+     * (`bwrap`/`rg`/`socat`/`claude`) are installed. `main` passes the boot check;
+     * absent (a plain createFetchHandler / tests) → omitted from `/health`.
+     */
+    preflight?: PreflightResult;
   },
 ): (req: Request, server?: { upgrade: (req: Request, opts: { data: TerminalWsData }) => boolean }) => Promise<Response> {
   // The per-channel turn-event SSE registry — subscribers of the live "watch it
@@ -1503,6 +1511,10 @@ export function createFetchHandler(
     // (`programmatic · idle|working|queued:N`) instead of `mcp_sessions` — a
     // programmatic agent has no live subscriber, so SSE/MCP counts don't describe it.
     if (url.pathname === "/health") {
+      // Surface the boot dependency-preflight (agent#156) so the admin UI can show
+      // that programmatic turns will fail until the missing deps are installed. Only
+      // present when `main` passed the boot check (absent in a plain handler/tests).
+      const preflight = opts?.preflight;
       return json({
         status: "ok",
         channels: [...channels.values()].map((c) => ({
@@ -1521,6 +1533,15 @@ export function createFetchHandler(
             status: s.state === "queued" ? `queued:${s.queued}` : s.state,
           };
         }),
+        ...(preflight
+          ? {
+              dependencies: {
+                ok: preflight.ok,
+                // The binary names missing on PATH — what programmatic turns need installed.
+                missing: preflight.missing.map((d) => d.bin),
+              },
+            }
+          : {}),
       });
     }
 
@@ -3233,6 +3254,14 @@ function main(): void {
   mkdirSync(STATE_DIR, { recursive: true });
   mkdirSync(INBOX_DIR, { recursive: true });
 
+  // BOOT DEPENDENCY PREFLIGHT (agent#156). A fresh box can't run a programmatic
+  // `claude -p` turn until bwrap/rg/socat + the claude CLI are on PATH — pre-#156
+  // each surfaced only as a failed *turn*, one at a time. Check them ONCE at boot and
+  // log a single clear warning (with the install one-liners) when any is missing. It's
+  // advisory, never fatal: the daemon may run only attached-backend agents that need
+  // none of these, so we warn + keep serving. The result is also surfaced on /health.
+  const preflight = runBootPreflight();
+
   // Verify the one MCP SDK internal our HTTP-MCP delivery accounting reads
   // (`_streamMapping['_GET_stream']`, see assertMcpSdkStreamContract). A screaming
   // boot error on SDK drift beats discovering it as silent message loss later.
@@ -3349,7 +3378,7 @@ function main(): void {
     buildInstantiateDeps(channels, registry, deliveryState, programmatic, attachedQueue),
   );
 
-  const fetchHandler = createFetchHandler(channels, registry, { deliveryState, programmatic, attachedQueue, turnEvents, jobStore, runner, agentDefs });
+  const fetchHandler = createFetchHandler(channels, registry, { deliveryState, programmatic, attachedQueue, turnEvents, jobStore, runner, agentDefs, preflight });
   const server = Bun.serve<TerminalWsData, never>({
     port: PORT,
     hostname: "127.0.0.1",

package/src/preflight.ts

@@ -0,0 +1,139 @@
+/**
+ * Boot-time dependency PREFLIGHT (agent#156).
+ *
+ * A freshly-provisioned box can't run a programmatic `claude -p` turn until the
+ * sandbox deps (`bwrap`, `rg`, `socat`) AND the `claude` CLI are installed — but
+ * pre-#156 each missing piece surfaced ONLY as a failed *turn*, one at a time, so
+ * an operator discovered them serially (install bwrap → next turn fails on rg →
+ * install rg → next turn fails on claude → …).
+ *
+ * This lifts the check to DAEMON BOOT: resolve each required binary on PATH ONCE
+ * and log a single clear warning naming exactly what's missing + the one-liner to
+ * fix it. It is a WARNING, never a crash — the daemon may run only `attached`-backend
+ * agents (which don't spawn `claude -p` and need no sandbox/claude), so a missing
+ * dep means "programmatic turns will fail until …", not "the daemon can't start."
+ *
+ * Deliberately NOT a full doctor framework — a focused boot preflight + clear log is
+ * the whole of #156. (`spawn-deps.ts`'s turn-time check still stands as the last line
+ * of defence for a dep removed AFTER boot.)
+ */
+
+/**
+ * One required external binary the programmatic backend needs on PATH, with the
+ * one-liner that installs it on a fresh Debian/Ubuntu box (the #156 reproduction).
+ */
+interface RequiredDep {
+  /** The binary name resolved on PATH (`Bun.which`). */
+  bin: string;
+  /** Human label for the warning. */
+  label: string;
+  /** The install hint shown when it's missing. */
+  hint: string;
+  /**
+   * True when this dep is only required on LINUX. On macOS the sandbox uses Seatbelt
+   * (built in, no helper binaries), so the bubblewrap egress-proxy deps (`bwrap`,
+   * `socat`) aren't needed — flagging them on a Mac deploy (the documented preferred
+   * self-host path) would be a false-positive that trains operators to ignore the
+   * preflight. So they're checked on Linux only. (`rg` is NOT linux-only: the runtime's
+   * deny-path scan needs a real ripgrep on macOS too. `claude` is needed everywhere.)
+   */
+  linuxOnly?: boolean;
+}
+
+/**
+ * The deps a programmatic `claude -p` turn needs. `bwrap`/`socat` are the LINUX
+ * bubblewrap sandbox deps the runtime shells out to (bubblewrap is the containment,
+ * socat bridges the egress proxy) — not needed under macOS Seatbelt, so `linuxOnly`.
+ * `rg` (ripgrep) does the deny-path scan on EVERY platform (the macOS sandbox needs a
+ * real `rg` too). `claude` is the CLI the turn runs, required everywhere. The platform
+ * filter is applied in {@link checkProgrammaticDeps}.
+ */
+export const REQUIRED_DEPS: readonly RequiredDep[] = [
+  { bin: "bwrap", label: "bubblewrap (bwrap)", hint: "apt install bubblewrap", linuxOnly: true },
+  { bin: "rg", label: "ripgrep (rg)", hint: "apt install ripgrep" },
+  { bin: "socat", label: "socat", hint: "apt install socat", linuxOnly: true },
+  {
+    bin: "claude",
+    label: "Claude Code CLI (claude)",
+    hint: "curl -fsSL https://claude.ai/install.sh | bash  (native build — no node/npm needed)",
+  },
+] as const;
+
+/** A resolver from binary name → absolute path (or null when not on PATH). Injectable for tests. */
+export type WhichFn = (bin: string) => string | null;
+
+/** The default resolver — Bun.which against the daemon's PATH. */
+export const realWhich: WhichFn = (bin) => Bun.which(bin);
+
+/** Which {@link REQUIRED_DEPS} apply on the given platform (drops `linuxOnly` deps off Linux). */
+export function depsForPlatform(platform: NodeJS.Platform = process.platform): RequiredDep[] {
+  return REQUIRED_DEPS.filter((d) => !d.linuxOnly || platform === "linux");
+}
+
+/** The outcome of {@link checkProgrammaticDeps}: which required deps are missing + a ready-to-log warning. */
+export interface PreflightResult {
+  /** The deps NOT resolvable on PATH (empty = all present). */
+  missing: RequiredDep[];
+  /** True when every required dep resolved (nothing to warn about). */
+  ok: boolean;
+  /**
+   * The formatted multi-line warning to log, or null when nothing is missing. Lists
+   * each missing dep + its install one-liner, framed as "programmatic turns will fail
+   * until …" (attached-backend agents are unaffected).
+   */
+  warning: string | null;
+}
+
+/**
+ * PURE check: resolve each platform-applicable {@link REQUIRED_DEPS} binary via `which`
+ * and build the missing-deps result + warning text. No I/O beyond the injected `which`;
+ * no logging (the caller logs). Cheap + idempotent — safe to call at boot. `platform` is
+ * injectable so a test can assert the macOS filter without running on a Mac.
+ */
+export function checkProgrammaticDeps(
+  which: WhichFn = realWhich,
+  platform: NodeJS.Platform = process.platform,
+): PreflightResult {
+  const missing = depsForPlatform(platform).filter((d) => {
+    try {
+      return !which(d.bin);
+    } catch {
+      // A which() fault is treated as "can't confirm it's present" → report it missing
+      // (better a spurious advisory than silently swallowing a real gap).
+      return true;
+    }
+  });
+  if (missing.length === 0) return { missing: [], ok: true, warning: null };
+  const lines = missing.map((d) => `    - ${d.label}: ${d.hint}`);
+  const warning =
+    `parachute-agent: PREFLIGHT — ${missing.length} dependency/dependencies for programmatic ` +
+    `(claude -p) turns is/are NOT on PATH. Programmatic-backend turns will FAIL until installed ` +
+    `(attached-backend agents are unaffected):\n${lines.join("\n")}`;
+  return { missing, ok: false, warning };
+}
+
+/**
+ * Run the boot preflight: check the deps and LOG the warning once (via `console.warn`)
+ * when anything is missing. Returns the {@link PreflightResult} so the caller can also
+ * surface the missing-deps state elsewhere (e.g. `/health`). Never throws — the daemon
+ * keeps booting regardless.
+ */
+export function runBootPreflight(
+  which: WhichFn = realWhich,
+  platform: NodeJS.Platform = process.platform,
+): PreflightResult {
+  let result: PreflightResult;
+  try {
+    result = checkProgrammaticDeps(which, platform);
+  } catch (err) {
+    // Defensive: the preflight must never break boot. An unexpected fault is reported
+    // HONESTLY (ok:false + the error in the warning) rather than a false "all clear" —
+    // but it's still non-fatal; the daemon boots and the turn-time check in
+    // spawn-deps.ts remains the real guard.
+    const msg = `parachute-agent: boot preflight errored (continuing, dependency state UNKNOWN): ${(err as Error).message}`;
+    console.error(msg);
+    return { missing: [], ok: false, warning: msg };
+  }
+  if (result.warning) console.warn(result.warning);
+  return result;
+}

package/src/spawn-agent.ts

@@ -428,6 +428,22 @@ export function buildAgentChildEnv(
   }
   if (!out.PATH) out.PATH = "/usr/local/bin:/usr/bin:/bin";
 
+  // IS_SANDBOX=1 — signal to claude that it is running INSIDE a sandbox (agent#155).
+  // The programmatic turn always launches inside a bwrap/Seatbelt sandbox (that IS the
+  // containment), so `--dangerously-skip-permissions` is safe — but Claude Code REFUSES
+  // that flag under root/sudo ("cannot be used with root/sudo privileges for security
+  // reasons") UNLESS `IS_SANDBOX` is set, which makes EVERY turn error on a daemon that
+  // runs as root (e.g. the friends/team box). Setting it here makes the fix permanent +
+  // automatic (it was being worked around per-deploy via the env store, which is lost on
+  // reset). It defaults to "1" for every sandboxed turn but honors an explicit operator
+  // value from `channelEnv` (already laid down above) — so an operator who deliberately
+  // sets it can still override. NB: IS_SANDBOX is NOT in SANDBOX_ENV_ALLOWLIST and is not
+  // set by `seedAgentHome`, so it survives `mergeSandboxLaunchEnv` un-clobbered — it can
+  // never be reset to empty by the env-merge layering.
+  if (typeof out.IS_SANDBOX !== "string" || out.IS_SANDBOX.length === 0) {
+    out.IS_SANDBOX = "1";
+  }
+
   // The interactive subscription credential (design §6). Explicitly the ONLY
   // Claude auth var set; ANTHROPIC_API_KEY is intentionally absent. Set LAST so no
   // channel-injected var can ever override the session's managed auth.