@openneuro/server 4.20.5 → 4.20.6-alpha.3

package/src/datalad/__tests__/description.spec.js

@@ -1,137 +0,0 @@
-import {
-  getDescriptionObject,
-  repairDescriptionTypes,
-  appendSeniorAuthor,
-} from '../description.js'
-
-// Mock requests to Datalad service
-vi.mock('ioredis')
-vi.mock('../../config.js')
-
-describe('datalad dataset descriptions', () => {
-  describe('appendSeniorAuthor', () => {
-    it('returns author out of several', () => {
-      expect(
-        appendSeniorAuthor({
-          Authors: ['A. Bee', 'C. Dee', 'E. Eff'],
-          Name: 'test dataset',
-        }),
-      ).toHaveProperty('SeniorAuthor', 'E. Eff')
-    })
-    it('returns a description when no Authors array is provided', () => {
-      expect(
-        appendSeniorAuthor({ Authors: null, Name: 'test dataset' }),
-      ).toHaveProperty('Name', 'test dataset')
-    })
-    it('returns a description when no Authors array is empty', () => {
-      expect(
-        appendSeniorAuthor({ Authors: [], Name: 'test dataset' }),
-      ).toHaveProperty('Name', 'test dataset')
-    })
-  })
-  describe('repairDescriptionTypes', () => {
-    it('converts strings to one element arrays for array fields', () => {
-      const description = {
-        Authors: 'Not, An Array',
-        BIDSVersion: '1.2.0',
-        ReferencesAndLinks: 'https://openneuro.org',
-        Funding: ['This one', 'is correct'],
-        EthicsApprovals: 'Also, Not, Array',
-      }
-      const repaired = repairDescriptionTypes(description)
-      // Check for discarded fields
-      expect(repaired.BIDSVersion).toBe(description.BIDSVersion)
-      // Check for extra fields
-      expect(repaired.DatasetDOI).toBe(undefined)
-      // Test each repaired field for type correct value
-      expect(Array.isArray(repaired.Authors)).toBe(true)
-      expect(Array.isArray(repaired.ReferencesAndLinks)).toBe(true)
-      expect(Array.isArray(repaired.Funding)).toBe(true)
-      expect(Array.isArray(repaired.EthicsApprovals)).toBe(true)
-    })
-    it('converts any invalid value to string values for string fields', () => {
-      const description = {
-        BIDSVersion: '1.2.0',
-        Name: 1.5,
-        DatasetDOI: ['Should', 'not', 'be', 'an', 'array'],
-        Acknowledgements: ['Should not be an array'],
-        HowToAcknowledge: Symbol(), // This can't serialize but just in case
-      }
-      const repaired = repairDescriptionTypes(description)
-      // Check for discarded fields
-      expect(repaired.BIDSVersion).toBe(description.BIDSVersion)
-      // Check for extra fields
-      expect(repaired.Authors).toBe(undefined)
-      // Check converted types
-      expect(typeof repaired.Name).toBe('string')
-      expect(typeof repaired.DatasetDOI).toBe('string')
-      expect(typeof repaired.Acknowledgements).toBe('string')
-      expect(typeof repaired.HowToAcknowledge).toBe('string')
-    })
-    it('returns correct types for empty strings', () => {
-      const description = {
-        Name: 'Classification learning',
-        License:
-          'This dataset is made available under the Public Domain Dedication and License \nv1.0, whose full text can be found at \nhttp://www.opendatacommons.org/licenses/pddl/1.0/. \nWe hope that all users will follow the ODC Attribution/Share-Alike \nCommunity Norms (http://www.opendatacommons.org/norms/odc-by-sa/); \nin particular, while not legally required, we hope that all users \nof the data will acknowledge the OpenfMRI project and NSF Grant \nOCI-1131441 (R. Poldrack, PI) in any publications.',
-        Authors: '',
-        Acknowledgements: '',
-        HowToAcknowledge: '',
-        Funding: '',
-        ReferencesAndLinks: '',
-        DatasetDOI: '',
-        BIDSVersion: '1.0.0',
-      }
-      const repaired = repairDescriptionTypes(description)
-      expect(Array.isArray(repaired.Authors)).toBe(true)
-      expect(Array.isArray(repaired.ReferencesAndLinks)).toBe(true)
-      expect(Array.isArray(repaired.Funding)).toBe(true)
-    })
-  })
-  describe('getDescriptionObject()', () => {
-    beforeAll(() => {
-      global.fetch = vi.fn()
-    })
-    it('returns the parsed dataset_description.json object', async () => {
-      fetch.mockResolvedValue({
-        json: () =>
-          Promise.resolve({ Name: 'Balloon Analog Risk-taking Task' }),
-        headers: {
-          get: () => 'application/json',
-        },
-        status: 200,
-      })
-      const description = await getDescriptionObject('ds000001', '1.0.0')
-      expect(description).toEqual({ Name: 'Balloon Analog Risk-taking Task' })
-    })
-    it('handles a corrupted response', async () => {
-      global.fetch = vi.fn()
-      fetch.mockResolvedValue({
-        json: () => Promise.reject('JSON could not be parsed'),
-        headers: {
-          get: () => 'application/json',
-        },
-        status: 400,
-      })
-      await expect(getDescriptionObject('ds000001', '1.0.0')).rejects.toEqual(
-        Error(
-          'Backend request failed, dataset_description.json may not exist or may be non-JSON (type: application/json, status: 400)',
-        ),
-      )
-    })
-    it('throws an error when nothing is returned', async () => {
-      global.fetch = vi.fn()
-      fetch.mockResolvedValue({
-        json: () => Promise.reject('JSON could not be parsed'),
-        headers: {
-          get: () => 'application/json',
-        },
-        status: 404,
-      })
-      await expect(getDescriptionObject('ds000001', '1.0.0')).rejects.toEqual(
-        Error(
-          'Backend request failed, dataset_description.json may not exist or may be non-JSON (type: application/json, status: 404)',
-        ),
-      )
-    })
-  })
-})

package/src/datalad/__tests__/files.spec.js

@@ -1,75 +0,0 @@
-import {
-  encodeFilePath,
-  decodeFilePath,
-  fileUrl,
-  computeTotalSize,
-} from '../files'
-
-vi.mock('ioredis')
-vi.mock('../../config.js')
-
-const filename = 'sub-01/anat/sub-01_T1w.nii.gz'
-
-const mockRootFiles = [
-  { filename: 'README' },
-  { filename: 'dataset_description.json' },
-]
-const mockSub01 = [
-  { filename: 'sub-01/anat/sub-01_T1w.nii.gz' },
-  { filename: 'sub-01/func/sub-01_task-onebacktask_run-01_bold.nii.gz' },
-]
-const mockSub02 = [
-  { filename: 'sub-02/anat/sub-02_T1w.nii.gz' },
-  { filename: 'sub-02/func/sub-02_task-onebacktask_run-01_bold.nii.gz' },
-]
-const mockSub03 = [
-  { filename: 'sub-03/anat/sub-03_T1w.nii.gz' },
-  { filename: 'sub-03/func/sub-03_task-onebacktask_run-01_bold.nii.gz' },
-]
-const mockDerivatives = [{ filename: 'derivatives/groundbreaking_output.html' }]
-const mockFiles = [
-  ...mockRootFiles,
-  ...mockSub01,
-  ...mockSub02,
-  ...mockSub03,
-  ...mockDerivatives,
-]
-
-describe('datalad files', () => {
-  describe('encodeFilePath()', () => {
-    it('should encode a nested path', () => {
-      expect(encodeFilePath(filename)).toBe('sub-01:anat:sub-01_T1w.nii.gz')
-    })
-  })
-  describe('decodeFilePath()', () => {
-    it('decodes a file path', () => {
-      expect(decodeFilePath('sub-01:anat:sub-01_T1w.nii.gz')).toBe(filename)
-    })
-  })
-  describe('fileUrl()', () => {
-    it('returns a working URL', () => {
-      expect(fileUrl('ds000001', '', filename)).toBe(
-        'http://datalad-0/datasets/ds000001/files/sub-01:anat:sub-01_T1w.nii.gz',
-      )
-    })
-    it('handles path nesting', () => {
-      expect(fileUrl('ds000001', 'sub-01/anat', 'sub-01_T1w.nii.gz')).toBe(
-        'http://datalad-0/datasets/ds000001/files/sub-01:anat:sub-01_T1w.nii.gz',
-      )
-    })
-  })
-  describe('computeTotalSize()', () => {
-    it('computes the size correctly', () => {
-      const mockFileSizes = [
-        { filename: 'README', size: 234 },
-        { filename: 'dataset_description.json', size: 432 },
-        { filename: 'sub-01/anat/sub-01_T1w.nii.gz', size: 10858 },
-        {
-          filename: 'sub-01/func/sub-01_task-onebacktask_run-01_bold.nii.gz',
-          size: 1945682,
-        },
-      ]
-      expect(computeTotalSize(mockFileSizes)).toBe(1957206)
-    })
-  })
-})

package/src/datalad/__tests__/pagination.spec.js

@@ -1,136 +0,0 @@
-import { vi } from 'vitest'
-vi.mock('ioredis')
-import * as pagination from '../pagination.js'
-import { connect, Types } from 'mongoose'
-import Dataset from '../../models/dataset'
-const ObjectID = Types.ObjectId
-
-const base64 = /^([A-Za-z0-9+/]{4})*([A-Za-z0-9+/]{3}=|[A-Za-z0-9+/]{2}==)?$/
-
-describe('pagination model operations', () => {
-  describe('enumToMongoSort()', () => {
-    it('should convert enum strings to -1 or 1 values', () => {
-      expect(
-        pagination.enumToMongoSort({
-          created: 'descending',
-          name: 'ascending',
-        }),
-      ).toEqual({ created: -1, name: 1 })
-    })
-  })
-  describe('apiCursor()', () => {
-    it('returns base64 string', () => {
-      expect(pagination.apiCursor(new ObjectID(5))).toMatch(base64)
-    })
-  })
-  describe('applyCursorToEdges()', () => {
-    it('returns the correct shape matching Relay connections', () => {
-      const res = pagination.applyCursorToEdges(
-        [{ _id: '123' }, { _id: '234' }, { _id: '345' }],
-        0,
-      )
-      expect(res).toEqual([
-        { cursor: 'eyJvZmZzZXQiOjB9', node: { _id: '123' } },
-        { cursor: 'eyJvZmZzZXQiOjF9', node: { _id: '234' } },
-        { cursor: 'eyJvZmZzZXQiOjJ9', node: { _id: '345' } },
-      ])
-    })
-  })
-  describe('datasetsConnection()', () => {
-    beforeAll(async () => {
-      await connect(globalThis.__MONGO_URI__)
-      const ds = new Dataset({
-        _id: new ObjectID('5bef51a1ed211400c08e5524'),
-        id: 'ds001001',
-        created: new Date('2018-11-16T23:24:17.203Z'),
-        modified: new Date('2018-11-16T23:24:25.050Z'),
-        uploader: 'f8d5a57c-879a-40e6-b151-e34c4a28ff70',
-        revision: '262a8e610e32b5766cbf669acc71911c1ece7126',
-      })
-      await ds.save()
-    })
-    it('returns a connection shaped result', async () => {
-      const res = await pagination.datasetsConnection({
-        orderBy: { created: 'ascending' },
-        limit: 5,
-        first: 10,
-      })([])
-      expect(res).toHaveProperty('pageInfo')
-      expect(res).toHaveProperty('edges')
-    })
-  })
-  describe('maxLimit()', () => {
-    it('should be within range 1-100', () => {
-      expect(pagination.maxLimit(0)).toBe(1)
-      expect(pagination.maxLimit(101)).toBe(100)
-    })
-    it('does not error with negative values', () => {
-      expect(pagination.maxLimit(-10)).toBe(1)
-    })
-  })
-  describe('sortAggregate()', () => {
-    it('should return natural sort for orderBy: created', () => {
-      expect(
-        pagination.sortAggregate({ orderBy: { created: 'ascending' } }),
-      ).toEqual([{ $sort: { _id: 1 } }])
-    })
-    it('does not throw an error with no orderBy', () => {
-      expect(pagination.sortAggregate({})).toEqual([])
-    })
-    it('should return -1 for descending sorts', () => {
-      expect(
-        pagination.sortAggregate({ orderBy: { created: 'descending' } }),
-      ).toEqual([{ $sort: { _id: -1 } }])
-    })
-    it('includes "name" for name sorts', () => {
-      expect(
-        pagination.sortAggregate({ orderBy: { name: 'descending' } }),
-      ).toEqual([{ $sort: { name: -1 } }])
-    })
-    it('returns a lookup and count stage for stars', () => {
-      const agg = pagination.sortAggregate({ orderBy: { stars: 'ascending' } })
-      expect(agg[0]).toHaveProperty('$lookup')
-      expect(agg[1]).toHaveProperty('$addFields')
-      // Ends with count sort
-      expect(agg.slice(-1)).toEqual([{ $sort: { starsCount: 1 } }])
-    })
-    it('returns a lookup and count stage for subscriptions', () => {
-      const agg = pagination.sortAggregate({
-        orderBy: { subscriptions: 'descending' },
-      })
-      expect(agg[0]).toHaveProperty('$lookup')
-      expect(agg[1]).toHaveProperty('$addFields')
-      // Ends with count sort
-      expect(agg.slice(-1)).toEqual([{ $sort: { subscriptionsCount: -1 } }])
-    })
-    it('returns a lookup and no count stage for downloads', () => {
-      const agg = pagination.sortAggregate({
-        orderBy: { downloads: 'ascending' },
-      })
-      // Ends with count sort
-      expect(agg.slice(-1)).toEqual([{ $sort: { downloads: 1 } }])
-    })
-    it('returns a lookup and no count stage for views', () => {
-      const agg = pagination.sortAggregate({
-        orderBy: { views: 'ascending' },
-      })
-      // Ends with count sort
-      expect(agg.slice(-1)).toEqual([{ $sort: { views: 1 } }])
-    })
-    it('does not explode with all sorts', () => {
-      const agg = pagination.sortAggregate({
-        orderBy: {
-          created: 'ascending',
-          name: 'ascending',
-          uploader: 'ascending',
-          stars: 'ascending',
-          downloads: 'ascending',
-          subscriptions: 'ascending',
-        },
-      })
-      expect(agg).toHaveLength(6)
-      // Final stage should always be a sort
-      expect(agg.slice(-1)[0]).toHaveProperty('$sort')
-    })
-  })
-})

package/src/datalad/draft.js

@@ -1,37 +0,0 @@
-/**
- * Manage serving a Draft object based on DataLad working trees
- */
-import request from 'superagent'
-import Dataset from '../models/dataset'
-import publishDraftUpdate from '../graphql/utils/publish-draft-update.js'
-import { getDatasetWorker } from '../libs/datalad-service'
-
-export const getDraftRevision = async datasetId => {
-  const draftUrl = `http://${getDatasetWorker(
-    datasetId,
-  )}/datasets/${datasetId}/draft`
-  const response = await fetch(draftUrl)
-  const { hexsha } = await response.json()
-  return hexsha
-}
-
-export const updateDatasetRevision = (datasetId, gitRef) => {
-  /**
-   * Update the revision modified time in a draft on changes
-   */
-  return Dataset.updateOne({ id: datasetId }, { modified: new Date() })
-    .exec()
-    .then(() => publishDraftUpdate(datasetId, gitRef))
-}
-
-/**
- * Run a git reset on the draft
- * @param {string} datasetId Accession number
- * @param {string} ref Git hexsha
- */
-export const resetDraft = (datasetId, ref) => {
-  const resetUrl = `${getDatasetWorker(
-    datasetId,
-  )}/datasets/${datasetId}/reset/${ref}`
-  return request.post(resetUrl).set('Accept', 'application/json')
-}

package/src/elasticsearch/elastic-client.js

@@ -1,11 +0,0 @@
-import config from '../config.js'
-import { Client } from '@elastic/elasticsearch'
-
-const elasticConfig = {
-  node: config.elasticsearch.connection || 'http://mock-client',
-  maxRetries: 3,
-}
-
-export const elasticClient = new Client(elasticConfig)
-
-export default elasticClient

package/src/graphql/__tests__/permissions.spec.js

@@ -1,107 +0,0 @@
-import {
-  datasetReadQuery,
-  checkPermissionLevel,
-  states,
-  checkDatasetWrite,
-  checkDatasetAdmin,
-} from '../permissions'
-
-vi.mock('ioredis')
-
-describe('resolver permissions helpers', () => {
-  describe('datasetReadQuery()', () => {
-    it('returns public for anonymous users', () => {
-      expect(datasetReadQuery('ds000001', null, null)).toHaveProperty(
-        'public',
-        true,
-      )
-    })
-    it('returns non-public for admins', () => {
-      expect(
-        datasetReadQuery('ds000001', '1234', { admin: true }),
-      ).not.toHaveProperty('public', true)
-    })
-    it('returns public for logged in users', () => {
-      expect(
-        datasetReadQuery('ds000001', '1234', { admin: false }),
-      ).toHaveProperty('public', true)
-    })
-  })
-  describe('checkPermissionLevel(..., READ)', () => {
-    it('returns false if no permission passed in', () => {
-      expect(checkPermissionLevel(null, states.READ)).toBe(false)
-    })
-    it('returns true for valid read access level', () => {
-      expect(checkPermissionLevel({ level: 'admin' }, states.READ)).toBe(true)
-      expect(checkPermissionLevel({ level: 'ro' }, states.READ)).toBe(true)
-    })
-    it('returns false if an unexpected level is present', () => {
-      expect(checkPermissionLevel({ level: 'not-real' }, states.READ)).toBe(
-        false,
-      )
-    })
-  })
-  describe('checkPermissionLevel(..., WRITE)', () => {
-    it('returns false if no permission passed in', () => {
-      expect(checkPermissionLevel(null, states.WRITE)).toBe(false)
-    })
-    it('returns true for admin', () => {
-      expect(checkPermissionLevel({ level: 'admin' }, states.WRITE)).toBe(true)
-    })
-    it('returns false for read only access', () => {
-      expect(checkPermissionLevel({ level: 'ro' }, states.WRITE)).toBe(false)
-    })
-    it('returns false if an unexpected level is present', () => {
-      expect(checkPermissionLevel({ level: 'not-real' }, states.WRITE)).toBe(
-        false,
-      )
-    })
-  })
-  describe('checkDatasetWrite()', () => {
-    it('resolves to false for anonymous users', () => {
-      return expect(
-        checkDatasetWrite('ds000001', null, null, undefined, {
-          checkExists: false,
-        }),
-      ).rejects.toThrowErrorMatchingSnapshot()
-    })
-    it('resolves to true for admins', () => {
-      return expect(
-        checkDatasetWrite('ds000001', '1234', { admin: true }, undefined, {
-          checkExists: false,
-        }),
-      ).resolves.toBe(true)
-    })
-  })
-  describe('checkPermissionLevel(..., ADMIN)', () => {
-    it('returns false if no permission passed in', () => {
-      expect(checkPermissionLevel(null, states.ADMIN)).toBe(false)
-    })
-    it('returns true for admin', () => {
-      expect(checkPermissionLevel({ level: 'admin' }, states.ADMIN)).toBe(true)
-    })
-    it('returns false for read write access', () => {
-      expect(checkPermissionLevel({ level: 'rw' }, states.ADMIN)).toBe(false)
-    })
-    it('returns false for read only access', () => {
-      expect(checkPermissionLevel({ level: 'ro' }, states.ADMIN)).toBe(false)
-    })
-    it('returns false if an unexpected level is present', () => {
-      expect(checkPermissionLevel({ level: 'not-real' }, states.ADMIN)).toBe(
-        false,
-      )
-    })
-  })
-  describe('checkDatasetAdmin()', () => {
-    it('resolves to false for anonymous users', () => {
-      return expect(
-        checkDatasetAdmin('ds000001', null, null, false),
-      ).rejects.toThrowErrorMatchingSnapshot()
-    })
-    it('resolves to true for admins', () => {
-      return expect(
-        checkDatasetAdmin('ds000001', '1234', { admin: true }, false),
-      ).resolves.toBe(true)
-    })
-  })
-})

package/src/graphql/pubsub.js

@@ -1,5 +0,0 @@
-async function* asyncIterator(_) {
-  yield null
-}
-
-export default { publish: (_, __) => {}, asyncIterator }

package/src/graphql/resolvers/__tests__/dataset.spec.js

@@ -1,175 +0,0 @@
-import { vi } from 'vitest'
-import { connect } from 'mongoose'
-import request from 'superagent'
-import * as ds from '../dataset'
-
-vi.mock('superagent')
-vi.mock('ioredis')
-vi.mock('../../../config.js')
-vi.mock('../../../libs/notifications.js')
-
-describe('dataset resolvers', () => {
-  beforeAll(() => {
-    connect(globalThis.__MONGO_URI__)
-  })
-  describe('createDataset()', () => {
-    it('createDataset mutation succeeds', async () => {
-      const { id: dsId } = await ds.createDataset(
-        null,
-        { affirmedDefaced: true, affirmedConsent: false },
-        { user: '123456', userInfo: {} },
-      )
-      expect(dsId).toEqual(expect.stringMatching(/^ds[0-9]{6}$/))
-    })
-  })
-  describe('snapshotCreationComparison()', () => {
-    it('sorts array of objects by the "created" and "tag" properties', () => {
-      const testArray = [
-        { id: 2, created: new Date('2018-11-20T00:05:43.473Z'), tag: '1.0.0' },
-        { id: 1, created: new Date('2018-11-19T00:05:43.473Z'), tag: '1.0.1' },
-        { id: 3, created: new Date('2018-11-23T00:05:43.473Z'), tag: '1.0.2' },
-        { id: 5, created: new Date('2018-11-23T00:05:43.473Z'), tag: '1.0.10' },
-        { id: 4, created: new Date('2018-11-23T00:05:43.473Z'), tag: '1.0.3' },
-      ]
-      const sorted = testArray.sort(ds.snapshotCreationComparison)
-      expect(sorted[0].id).toBe(2)
-      expect(sorted[1].id).toBe(1)
-      expect(sorted[2].id).toBe(3)
-      expect(sorted[3].id).toBe(4)
-      expect(sorted[4].id).toBe(5)
-    })
-    it('sorts array of objects by the "created" property as strings', () => {
-      const testArray = [
-        { id: 2, created: '2018-11-20T00:05:43.473Z' },
-        { id: 1, created: '2018-11-19T00:05:43.473Z' },
-        { id: 3, created: '2018-11-23T00:05:43.473Z' },
-      ]
-      const sorted = testArray.sort(ds.snapshotCreationComparison)
-      expect(sorted[0].id).toBe(1)
-      expect(sorted[1].id).toBe(2)
-      expect(sorted[2].id).toBe(3)
-    })
-    it('sorts non-semver tags mixed with semver tags', () => {
-      const testArray = [
-        { id: 2, created: new Date('2018-11-19T00:05:43.473Z'), tag: '1.0.2' },
-        {
-          id: 1,
-          created: new Date('2018-11-19T00:05:43.473Z'),
-          tag: '57fed018cce88d000ac1757f',
-        },
-        { id: 3, created: new Date('2018-11-19T00:05:43.473Z'), tag: '1.0.1' },
-      ]
-      const sorted = testArray.sort(ds.snapshotCreationComparison)
-      expect(sorted[0].id).toBe(2)
-      expect(sorted[1].id).toBe(1)
-      expect(sorted[2].id).toBe(3)
-    })
-    it('sorts snapshots with only non-semver tags', () => {
-      const testArray = [
-        {
-          id: 2,
-          created: new Date('2018-11-19T00:05:43.473Z'),
-          tag: '00001',
-        },
-        {
-          id: 1,
-          created: new Date('2018-11-19T00:05:43.473Z'),
-          tag: '57fed018cce88d000ac1757f',
-        },
-        {
-          id: 3,
-          created: new Date('2018-11-19T00:05:43.473Z'),
-          tag: '57fed018cce88d000ac1757f',
-        },
-      ]
-      const sorted = testArray.sort(ds.snapshotCreationComparison)
-      expect(sorted[0].id).toBe(2)
-      expect(sorted[1].id).toBe(1)
-      expect(sorted[2].id).toBe(3)
-    })
-    it('sorts very similar creation times by semver order', () => {
-      const testSnapshots = [
-        {
-          id: 'ds002680:1.0.0',
-          created: '2020-04-03T23:19:56.000Z',
-          tag: '1.0.0',
-        },
-        {
-          id: 'ds002680:1.2.0',
-          created: '2021-10-19T16:26:43.000Z',
-          tag: '1.2.0',
-        },
-        {
-          id: 'ds002680:1.1.0',
-          created: '2021-10-19T16:26:44.000Z',
-          tag: '1.1.0',
-        },
-      ]
-      const sorted = testSnapshots.sort(ds.snapshotCreationComparison)
-      expect(sorted[0].id).toBe('ds002680:1.0.0')
-      expect(sorted[1].id).toBe('ds002680:1.1.0')
-      expect(sorted[2].id).toBe('ds002680:1.2.0')
-    })
-    it('sorts 000002 (legacy snapshots) before 1.0.1 (current format)', () => {
-      const testSnapshots = [
-        {
-          id: 'ds000247:00002',
-          created: '2018-07-18T02:27:39.000Z',
-          tag: '00002',
-        },
-        {
-          id: 'ds000247:00001',
-          created: '2018-07-18T02:35:37.000Z',
-          tag: '00001',
-        },
-        {
-          id: 'ds000247:1.0.0',
-          created: '2021-07-05T15:58:18.000Z',
-          tag: '1.0.0',
-        },
-        {
-          id: 'ds000247:1.0.1',
-          created: '2021-08-25T23:37:53.000Z',
-          tag: '1.0.1',
-        },
-      ]
-      const sorted = testSnapshots.sort(ds.snapshotCreationComparison)
-      expect(sorted[0].id).toBe('ds000247:00002')
-      expect(sorted[1].id).toBe('ds000247:00001')
-      expect(sorted[2].id).toBe('ds000247:1.0.0')
-      expect(sorted[3].id).toBe('ds000247:1.0.1')
-    })
-  })
-  describe('deleteFiles', () => {
-    beforeEach(() => {
-      request.post.mockClear()
-    })
-    it('makes correct delete call to datalad', () => {
-      // capture and check datalad delete request
-      request.del = url => ({
-        set: (header1, headerValue1) => ({
-          set: () => ({
-            send: ({ filenames }) => {
-              expect(url).toEqual('http://datalad-0/datasets/ds999999/files')
-              expect(filenames).toEqual([':sub-99'])
-              expect(header1).toEqual('Cookie')
-              expect(headerValue1).toMatch(/^accessToken=/)
-            },
-          }),
-        }),
-      })
-
-      return ds.deleteFiles(
-        null,
-        { datasetId: 'ds999999', files: [{ path: '/sub-99' }] },
-        {
-          user: 'a_user_id',
-          userInfo: {
-            // bypass permission checks
-            admin: true,
-          },
-        },
-      )
-    })
-  })
-})