@openneuro/app 4.47.6 → 5.0.0-alpha.0

package/src/scripts/users/notifications/user-notification-reason-input.tsx

@@ -1,10 +1,11 @@
 import React from "react"
+import { formatStatusForDisplay } from "../../types/event-types"
 import styles from "./scss/usernotifications.module.scss"
 
 interface NotificationReasonInputProps {
   reasonInput: string
   setReasonInput: (reason: string) => void
-  currentApprovalAction: "accepted" | "denied" | null
+  currentApprovalAction: "ACCEPTED" | "DENIED" | null
   handleReasonCancel: () => void
   handleReasonSubmit: () => void
   isProcessing: boolean
@@ -26,14 +27,16 @@ export const NotificationReasonInput: React.FC<NotificationReasonInputProps> = (
     <div className={styles.reasonInputContainer}>
       <label htmlFor={textareaId} className="sr-only">
         {`Reason for ${
-          currentApprovalAction ? currentApprovalAction : "approval"
+          formatStatusForDisplay(currentApprovalAction) || "approval"
         } action`}
       </label>
       <textarea
         id={textareaId}
         value={reasonInput}
         onChange={(e) => setReasonInput(e.target.value)}
-        placeholder={`Reason for ${currentApprovalAction}...`}
+        placeholder={`Reason for ${
+          formatStatusForDisplay(currentApprovalAction)
+        }...`}
         rows={3}
         className={styles.reasonTextarea}
         style={{ width: "100%" }}

package/src/scripts/users/notifications/user-notifications-accordion-body.tsx

@@ -58,7 +58,7 @@ export const NotificationBodyContent: React.FC<NotificationBodyContentProps> = (
     )
   }
 
-  if (approval === "accepted" && isContributorCitation) {
+  if (approval === "ACCEPTED" && isContributorCitation) {
     return (
       <div>
         The following user has been added as a contributor to {datasetId}.
@@ -67,7 +67,7 @@ export const NotificationBodyContent: React.FC<NotificationBodyContentProps> = (
     )
   }
 
-  if (approval === "accepted" && isContributorRequest) {
+  if (approval === "ACCEPTED" && isContributorRequest) {
     return (
       <div>
         <Username user={requesterUser} />{" "}
@@ -77,7 +77,7 @@ export const NotificationBodyContent: React.FC<NotificationBodyContentProps> = (
     )
   }
 
-  if (approval === "accepted" && isContributorResponse) {
+  if (approval === "ACCEPTED" && isContributorResponse) {
     return (
       <div>
         Admin <Username user={adminUser} />{" "}

package/src/scripts/users/user-datasets-view.tsx

@@ -9,36 +9,51 @@ import { Loading } from "../components/loading/Loading"
 import type { Dataset, UserDatasetsViewProps } from "../types/user-types"
 import styles from "./scss/datasetcard.module.scss"
 
-type SortByType = {
-  [key: string]: "asc" | "desc"
-} | null
+interface SearchInput {
+  keywords?: string[]
+  userId?: string
+  publicOnly?: boolean
+  sortBy?: string
+}
 
-interface ElasticsearchQuery {
-  bool: {
-    filter: (
-      | { terms: { "permissions.userPermissions.user.id": string[] } }
-      | { term: { public: boolean | null } }
-    )[]
-    must: (
-      | {
-        bool: {
-          should: (
-            | {
-              multi_match: {
-                query: string
-                fields: string[]
-                fuzziness: number
-              }
-            }
-            | { prefix: { name: string } }
-            | { prefix: { "description.Name": string } }
-          )[]
-          minimum_should_match: number
-        }
-      }
-      | { match_all: Record<string, never> }
-    )[]
+const buildSearchInput = (
+  searchQuery: string,
+  publicFilter: string,
+  userId: string | undefined,
+  hasEdit: boolean,
+  sortBy: string | undefined,
+): SearchInput => {
+  const input: SearchInput = {}
+
+  if (userId) {
+    input.userId = userId
+  }
+
+  if (hasEdit) {
+    if (publicFilter === "public") {
+      input.publicOnly = true
+    }
+  } else {
+    input.publicOnly = true
+  }
+
+  if (searchQuery) {
+    input.keywords = [searchQuery]
   }
+
+  if (sortBy) {
+    input.sortBy = sortBy
+  }
+
+  return input
+}
+
+const SORT_MAP: Record<string, string | undefined> = {
+  "name-asc": "name_asc",
+  "name-desc": "name_desc",
+  "date-newest": "newest",
+  "date-oldest": "oldest",
+  "date-updated": "last_updated",
 }
 
 export const UserDatasetsView: React.FC<UserDatasetsViewProps> = ({
@@ -52,81 +67,12 @@ export const UserDatasetsView: React.FC<UserDatasetsViewProps> = ({
   const [loadMoreLoading, setLoadMoreLoading] = useState(false)
   const [cursor, setCursor] = useState<string | null>(null)
   const [hasNextPage, setHasNextPage] = useState(false)
-  const [sortBy, setSortBy] = useState<SortByType>(null)
   const loadAmount = 26
 
-  const generateElasticsearchQuery = useCallback(
-    (
-      currentSearchQuery: string,
-      currentPublicFilter: string,
-    ): ElasticsearchQuery => {
-      const baseQuery: ElasticsearchQuery = {
-        bool: {
-          filter: [],
-          must: [],
-        },
-      }
-
-      if (orcidUser?.id) {
-        baseQuery.bool.filter.push({
-          terms: {
-            "permissions.userPermissions.user.id": [orcidUser.id],
-          },
-        })
-      }
+  const sortByValue = SORT_MAP[sortOrder]
 
-      if (hasEdit) {
-        if (currentPublicFilter === "public") {
-          baseQuery.bool.filter.push({ term: { public: true } })
-        }
-      } else {
-        baseQuery.bool.filter.push({ term: { public: true } })
-      }
-
-      if (currentSearchQuery) {
-        baseQuery.bool.must.push({
-          bool: {
-            should: [
-              {
-                multi_match: {
-                  query: currentSearchQuery,
-                  fields: [
-                    "id^3",
-                    "name^3",
-                    "description.Name^3",
-                    "description.Authors^3",
-                    "latestSnapshot.description.Name",
-                    "latestSnapshot.description.Authors",
-                    "latestSnapshot.readme",
-                  ],
-                  fuzziness: 1,
-                },
-              },
-              {
-                prefix: {
-                  name: currentSearchQuery.toLowerCase(),
-                },
-              },
-              {
-                prefix: {
-                  "description.Name": currentSearchQuery.toLowerCase(),
-                },
-              },
-            ],
-            minimum_should_match: 1,
-          },
-        })
-      } else {
-        baseQuery.bool.must.push({ match_all: {} })
-      }
-
-      return baseQuery
-    },
-    [orcidUser?.id, hasEdit],
-  )
-
-  const [elasticsearchQuery, setElasticsearchQuery] = useState(() =>
-    generateElasticsearchQuery("", "all")
+  const [searchInput, setSearchInput] = useState(() =>
+    buildSearchInput("", "all", orcidUser?.id, hasEdit, sortByValue)
   )
 
   const { data, loading, error, fetchMore, refetch } = useQuery(
@@ -134,8 +80,7 @@ export const UserDatasetsView: React.FC<UserDatasetsViewProps> = ({
     {
       variables: {
         first: loadAmount,
-        query: elasticsearchQuery,
-        sortBy: sortBy,
+        query: searchInput,
         cursor: null,
         allDatasets: true,
         datasetStatus: undefined,
@@ -161,89 +106,63 @@ export const UserDatasetsView: React.FC<UserDatasetsViewProps> = ({
     (newSearchQuery: string, currentPublicFilter: string) => {
       setSearchQuery(newSearchQuery)
       setPublicFilter(currentPublicFilter)
-      const newElasticsearchQuery = generateElasticsearchQuery(
+      const newInput = buildSearchInput(
         newSearchQuery,
         currentPublicFilter,
+        orcidUser?.id,
+        hasEdit,
+        sortByValue,
       )
-      setElasticsearchQuery(newElasticsearchQuery)
+      setSearchInput(newInput)
       refetch({
-        query: newElasticsearchQuery,
+        query: newInput,
         cursor: null,
-        sortBy: sortBy,
         datasetStatus: undefined,
       })
     },
-    [
-      generateElasticsearchQuery,
-      refetch,
-      setSearchQuery,
-      setPublicFilter,
-      setElasticsearchQuery,
-      sortBy,
-      hasEdit,
-      orcidUser?.id,
-    ],
+    [refetch, sortByValue, hasEdit, orcidUser?.id],
   )
 
   const handlePublicFilterChange = useCallback(
     (newPublicFilter) => {
       setPublicFilter(newPublicFilter)
-      const newElasticsearchQuery = generateElasticsearchQuery(
+      const newInput = buildSearchInput(
         searchQuery,
         newPublicFilter,
+        orcidUser?.id,
+        hasEdit,
+        sortByValue,
       )
-      setElasticsearchQuery(newElasticsearchQuery)
+      setSearchInput(newInput)
       refetch({
-        query: newElasticsearchQuery,
+        query: newInput,
         cursor: null,
-        sortBy: sortBy,
         datasetStatus: undefined,
       })
     },
-    [
-      setPublicFilter,
-      generateElasticsearchQuery,
-      refetch,
-      searchQuery,
-      sortBy,
-      hasEdit,
-      orcidUser?.id,
-    ],
+    [refetch, searchQuery, sortByValue, hasEdit, orcidUser?.id],
   )
 
   const handleSortOrderChange = useCallback(
     (newSortOrder) => {
       setSortOrder(newSortOrder)
-      let newSortBy = null
-      switch (newSortOrder) {
-        case "name-asc":
-          newSortBy = { "metadata.datasetName": "asc" }
-          break
-        case "name-desc":
-          newSortBy = { "metadata.datasetName": "desc" }
-          break
-        case "date-newest":
-          newSortBy = { created: "desc" }
-          break
-        case "date-oldest":
-          newSortBy = { created: "asc" }
-          break
-        case "date-updated":
-          newSortBy = { "metadata.latestSnapshotCreatedAt": "desc" }
-          break
-        default:
-          newSortBy = null
-      }
-      setSortBy(newSortBy)
+      const newSortByValue = SORT_MAP[newSortOrder]
+      const newInput = buildSearchInput(
+        searchQuery,
+        publicFilter,
+        orcidUser?.id,
+        hasEdit,
+        newSortByValue,
+      )
+      setSearchInput(newInput)
       refetch({
-        sortBy: newSortBy,
+        query: newInput,
         first: loadAmount,
         cursor: null,
-        query: elasticsearchQuery,
         datasetStatus: undefined,
       })
     },
-    [setSortOrder, refetch, setSortBy, elasticsearchQuery, hasEdit],
+    [refetch, searchQuery, publicFilter, hasEdit, orcidUser?.id],
   )
 
   const handleLoadMore = useCallback(() => {
@@ -256,8 +175,7 @@ export const UserDatasetsView: React.FC<UserDatasetsViewProps> = ({
       variables: {
         first: loadAmount,
         cursor: cursor,
-        query: elasticsearchQuery,
-        sortBy: sortBy,
+        query: searchInput,
         allDatasets: true,
         datasetStatus: undefined,
       },
@@ -293,8 +211,7 @@ export const UserDatasetsView: React.FC<UserDatasetsViewProps> = ({
     hasNextPage,
     loadMoreLoading,
     cursor,
-    elasticsearchQuery,
-    sortBy,
+    searchInput,
     hasEdit,
   ])
 
@@ -307,23 +224,25 @@ export const UserDatasetsView: React.FC<UserDatasetsViewProps> = ({
   }, [data, hasEdit, loadAmount])
 
   useEffect(() => {
-    const newElasticsearchQuery = generateElasticsearchQuery(
+    const newInput = buildSearchInput(
       searchQuery,
       publicFilter,
+      orcidUser?.id,
+      hasEdit,
+      sortByValue,
     )
-    setElasticsearchQuery(newElasticsearchQuery)
-  }, [searchQuery, publicFilter, generateElasticsearchQuery])
+    setSearchInput(newInput)
+  }, [searchQuery, publicFilter, orcidUser?.id, hasEdit, sortByValue])
 
   useEffect(() => {
-    if (elasticsearchQuery) {
+    if (searchInput) {
       refetch({
-        query: elasticsearchQuery,
+        query: searchInput,
         cursor: null,
-        sortBy: sortBy,
         datasetStatus: undefined,
       })
     }
-  }, [elasticsearchQuery, refetch, sortBy, hasEdit])
+  }, [searchInput, refetch, hasEdit])
 
   if (loading) return <Loading />
   if (error) {

package/src/scripts/users/user-menu.tsx

@@ -62,7 +62,7 @@ export const UserMenu: React.FC<UserMenuProps> = ({ signOutAndRedirect }) => {
 
   return (
     <span className="user-menu-wrap">
-      {user.orcid && (
+      {user.orcid && user.id !== "reviewer" && (
         <span className="notifications-link">
           <Link to={`/user/${user.orcid}/notifications/unread`}>
             <i className="fa fa-inbox">

package/src/scripts/datalad/dataset/comments-fragments.js

@@ -1,22 +0,0 @@
-import { gql } from "@apollo/client"
-
-export const DATASET_COMMENTS = gql`
-  fragment DatasetComments on Dataset {
-    id
-    comments {
-      id
-      text
-      createDate
-      user {
-        name
-        orcid
-      }
-      parent {
-        id
-      }
-      replies {
-        id
-      }
-    }
-  }
-`

package/src/scripts/datalad/mutations/follow.jsx

@@ -1,54 +0,0 @@
-import React from "react"
-import PropTypes from "prop-types"
-import { gql } from "@apollo/client"
-import { Mutation } from "@apollo/client/react/components"
-import WarnButton from "../../common/forms/warn-button.jsx"
-import { datasetCacheId } from "./cache-id.js"
-
-const FOLLOW_DATASET = gql`
-  mutation followDataset($datasetId: ID!) {
-    followDataset(datasetId: $datasetId)
-  }
-`
-
-const USER_FOLLOWING = gql`
-  fragment UserFollowing on Dataset {
-    id
-    following
-  }
-`
-
-const FollowDataset = ({ datasetId, following }) => (
-  <Mutation
-    mutation={FOLLOW_DATASET}
-    update={(cache, { data: { followDataset } }) => {
-      cache.writeFragment({
-        id: datasetCacheId(datasetId),
-        fragment: USER_FOLLOWING,
-        data: {
-          __typename: "Dataset",
-          id: datasetId,
-          following: followDataset,
-        },
-      })
-    }}
-  >
-    {(followDataset) => (
-      <WarnButton
-        tooltip="Follow Dataset"
-        icon={following ? "fa-tag icon-minus" : "fa-tag icon-plus"}
-        warn={false}
-        action={(cb) => {
-          followDataset({ variables: { datasetId } }).then(() => cb())
-        }}
-      />
-    )}
-  </Mutation>
-)
-
-FollowDataset.propTypes = {
-  datasetId: PropTypes.string,
-  following: PropTypes.bool,
-}
-
-export default FollowDataset

package/src/scripts/datalad/mutations/publish.jsx

@@ -1,58 +0,0 @@
-import React from "react"
-import PropTypes from "prop-types"
-import { gql } from "@apollo/client"
-import { Mutation } from "@apollo/client/react/components"
-import { useNavigate } from "react-router-dom"
-import { datasetCacheId } from "./cache-id.js"
-
-const PUBLISH_DATASET = gql`
-  mutation publishDataset($datasetId: ID!) {
-    publishDataset(datasetId: $datasetId)
-  }
-`
-
-const DATASET_PUBLISHED = gql`
-  fragment DatasetPublished on Dataset {
-    id
-    public
-  }
-`
-
-const PublishDataset = ({ datasetId }) => {
-  const navigate = useNavigate()
-  return (
-    <Mutation
-      mutation={PUBLISH_DATASET}
-      update={(cache) => {
-        cache.writeFragment({
-          id: datasetCacheId(datasetId),
-          fragment: DATASET_PUBLISHED,
-          data: {
-            __typename: "Dataset",
-            id: datasetId,
-            public: true,
-          },
-        })
-      }}
-    >
-      {(publishDataset) => (
-        <button
-          className="btn-modal-action"
-          onClick={() =>
-            publishDataset({ variables: { datasetId } }).then(() => {
-              navigate(`/datasets/${datasetId}`)
-            })}
-        >
-          Publish
-        </button>
-      )}
-    </Mutation>
-  )
-}
-
-PublishDataset.propTypes = {
-  datasetId: PropTypes.string,
-  history: PropTypes.object,
-}
-
-export default PublishDataset

package/src/scripts/datalad/mutations/star.jsx

@@ -1,54 +0,0 @@
-import React from "react"
-import PropTypes from "prop-types"
-import { gql } from "@apollo/client"
-import { Mutation } from "@apollo/client/react/components"
-import WarnButton from "../../common/forms/warn-button.jsx"
-import { datasetCacheId } from "./cache-id.js"
-
-const STAR_DATASET = gql`
-  mutation starDataset($datasetId: ID!) {
-    starDataset(datasetId: $datasetId)
-  }
-`
-
-const USER_STARRED = gql`
-  fragment UserStarred on Dataset {
-    id
-    starred
-  }
-`
-
-const StarDataset = ({ datasetId, starred }) => (
-  <Mutation
-    mutation={STAR_DATASET}
-    update={(cache, { data: { starDataset } }) => {
-      cache.writeFragment({
-        id: datasetCacheId(datasetId),
-        fragment: USER_STARRED,
-        data: {
-          __typename: "Dataset",
-          id: datasetId,
-          starred: starDataset,
-        },
-      })
-    }}
-  >
-    {(starDataset) => (
-      <WarnButton
-        tooltip="Save Dataset"
-        icon={starred ? "fa-star icon-minus" : "fa-star icon-plus"}
-        warn={false}
-        action={(cb) => {
-          starDataset({ variables: { datasetId } }).then(() => cb())
-        }}
-      />
-    )}
-  </Mutation>
-)
-
-StarDataset.propTypes = {
-  datasetId: PropTypes.string,
-  starred: PropTypes.bool,
-}
-
-export default StarDataset

package/src/scripts/pages/admin/user-fragment.ts

@@ -1,21 +0,0 @@
-import { gql } from "@apollo/client"
-
-export const USER_FRAGMENT = gql`
-  fragment userFields on User {
-    id
-    name
-    admin
-    blocked
-    email
-    provider
-    lastSeen
-    created
-    avatar
-    github
-    institution
-    location
-    modified
-    orcid
-  
-  }
-`