@openmrs/esm-stock-management-app 1.0.1-pre.632 → 1.0.1-pre.641

package/dist/openmrs-esm-stock-management-app.js.buildmanifest.json

@@ -85,9 +85,9 @@
       "initial": false,
       "entry": false,
       "recorded": false,
-      "size": 1841106,
+      "size": 1841303,
       "sizes": {
-        "javascript": 1840896,
+        "javascript": 1841093,
         "consume-shared": 210
       },
       "names": [],
@@ -101,7 +101,7 @@
       "auxiliaryFiles": [
         "173.js.map"
       ],
-      "hash": "a8491eb316af7797",
+      "hash": "be71504bcfe9203c",
       "childrenByOrder": {}
     },
     {
@@ -109,10 +109,10 @@
       "initial": true,
       "entry": true,
       "recorded": false,
-      "size": 5509533,
+      "size": 5509730,
       "sizes": {
         "consume-shared": 252,
-        "javascript": 5487583,
+        "javascript": 5487780,
         "share-init": 252,
         "runtime": 21446
       },
@@ -129,7 +129,7 @@
       "auxiliaryFiles": [
         "main.js.map"
       ],
-      "hash": "33a6a9db8e921f65",
+      "hash": "05641415f286ec13",
       "childrenByOrder": {}
     },
     {

package/dist/routes.json

@@ -1 +1 @@
-{"$schema":"https://json.openmrs.org/routes.schema.json","backendDependencies":{"fhir2":">=1.2","webservices.rest":"^2.24.0"},"extensions":[{"name":"stock-nav-menu","slot":"stock-sidebar-slot","component":"stockNavMenu","online":true,"offline":true},{"name":"overview-db-link","slot":"stock-page-dashboard-slot","component":"stockOverviewLink","meta":{"name":"overview","slot":"overview-dashboard-slot","title":"overview"},"order":0,"online":true,"offline":true},{"name":"stock-overview-db","slot":"overview-dashboard-slot","component":"stockOverview"},{"name":"operations-db-link","slot":"stock-page-dashboard-slot","component":"stockOperationsLink","meta":{"name":"operations","slot":"operations-dashboard-slot","title":"operations"},"order":2,"online":true,"offline":true},{"name":"stock-operations-db","slot":"operations-dashboard-slot","component":"stockOperations"},{"name":"items-db-link","slot":"stock-page-dashboard-slot","component":"stockItemsLink","meta":{"name":"items","slot":"items-dashboard-slot","title":"items"},"order":1,"online":true,"offline":true},{"name":"stock-items-db","slot":"items-dashboard-slot","component":"stockItems"},{"name":"user-scopes-db-link","slot":"stock-page-dashboard-slot","component":"stockUserScopesLink","meta":{"name":"user-scopes","slot":"user-scopes-dashboard-slot","title":"user-scopes"},"order":3,"online":true,"offline":true},{"name":"stock-user-scopes-db","slot":"user-scopes-dashboard-slot","component":"stockUserScopes"},{"name":"sources-db-link","slot":"stock-page-dashboard-slot","component":"stockSourcesLink","meta":{"name":"sources","slot":"sources-dashboard-slot","title":"Sources"},"order":2,"online":true,"offline":true},{"name":"stock-sources-db","slot":"sources-dashboard-slot","component":"stockSources"},{"name":"locations-db-link","slot":"stock-page-dashboard-slot","component":"stockLocationsLink","meta":{"name":"locations","slot":"locations-dashboard-slot","title":"Locations"},"order":4,"online":true,"offline":true},{"name":"stock-locations-db","slot":"locations-dashboard-slot","component":"stockLocations"},{"name":"reports-db-link","slot":"stock-page-dashboard-slot","component":"stockReportsLink","meta":{"name":"reports","slot":"reports-dashboard-slot","title":"Reports"},"order":5,"online":true,"offline":true},{"name":"stock-reports-db","slot":"reports-dashboard-slot","component":"stockReports"},{"name":"settings-db-link","slot":"stock-page-dashboard-slot","component":"stockSettingsLink","meta":{"name":"settings","slot":"settings-dashboard-slot","title":"Settings"},"order":6,"online":true,"offline":true},{"name":"stock-settings-db","slot":"settings-dashboard-slot","component":"stockSettings"},{"name":"stock-management-admin-card-link","slot":"system-admin-page-card-link-slot","component":"stockManagementAdminCardLink"},{"name":"stock-operation-dialog","component":"stockOperationDialog"},{"name":"import-bulk-stock-items","component":"importBulkStockItemsDialog"},{"name":"delete-stock-modal","component":"deleteStockModal"},{"name":"delete-stock-user-scope-modal","component":"deleteUserScopeModal"},{"name":"stock-management-app-menu-item","component":"stockManagementAppMenuItem","slot":"app-menu-item-slot","meta":{"name":" Stock Management"}},{"name":"delete-stock-rule-modal","component":"deleteStockRuleModal"},{"name":"delete-packaging-unit-modal","component":"deletePackagingUnitModal"},{"name":"delete-packaging-unit-button","component":"deletePackagingUnitButton"}],"pages":[{"component":"root","route":"stock-management"}],"version":"1.0.1-pre.632"}
+{"$schema":"https://json.openmrs.org/routes.schema.json","backendDependencies":{"fhir2":">=1.2","webservices.rest":"^2.24.0"},"extensions":[{"name":"stock-nav-menu","slot":"stock-sidebar-slot","component":"stockNavMenu","online":true,"offline":true},{"name":"overview-db-link","slot":"stock-page-dashboard-slot","component":"stockOverviewLink","meta":{"name":"overview","slot":"overview-dashboard-slot","title":"overview"},"order":0,"online":true,"offline":true},{"name":"stock-overview-db","slot":"overview-dashboard-slot","component":"stockOverview"},{"name":"operations-db-link","slot":"stock-page-dashboard-slot","component":"stockOperationsLink","meta":{"name":"operations","slot":"operations-dashboard-slot","title":"operations"},"order":2,"online":true,"offline":true},{"name":"stock-operations-db","slot":"operations-dashboard-slot","component":"stockOperations"},{"name":"items-db-link","slot":"stock-page-dashboard-slot","component":"stockItemsLink","meta":{"name":"items","slot":"items-dashboard-slot","title":"items"},"order":1,"online":true,"offline":true},{"name":"stock-items-db","slot":"items-dashboard-slot","component":"stockItems"},{"name":"user-scopes-db-link","slot":"stock-page-dashboard-slot","component":"stockUserScopesLink","meta":{"name":"user-scopes","slot":"user-scopes-dashboard-slot","title":"user-scopes"},"order":3,"online":true,"offline":true},{"name":"stock-user-scopes-db","slot":"user-scopes-dashboard-slot","component":"stockUserScopes"},{"name":"sources-db-link","slot":"stock-page-dashboard-slot","component":"stockSourcesLink","meta":{"name":"sources","slot":"sources-dashboard-slot","title":"Sources"},"order":2,"online":true,"offline":true},{"name":"stock-sources-db","slot":"sources-dashboard-slot","component":"stockSources"},{"name":"locations-db-link","slot":"stock-page-dashboard-slot","component":"stockLocationsLink","meta":{"name":"locations","slot":"locations-dashboard-slot","title":"Locations"},"order":4,"online":true,"offline":true},{"name":"stock-locations-db","slot":"locations-dashboard-slot","component":"stockLocations"},{"name":"reports-db-link","slot":"stock-page-dashboard-slot","component":"stockReportsLink","meta":{"name":"reports","slot":"reports-dashboard-slot","title":"Reports"},"order":5,"online":true,"offline":true},{"name":"stock-reports-db","slot":"reports-dashboard-slot","component":"stockReports"},{"name":"settings-db-link","slot":"stock-page-dashboard-slot","component":"stockSettingsLink","meta":{"name":"settings","slot":"settings-dashboard-slot","title":"Settings"},"order":6,"online":true,"offline":true},{"name":"stock-settings-db","slot":"settings-dashboard-slot","component":"stockSettings"},{"name":"stock-management-admin-card-link","slot":"system-admin-page-card-link-slot","component":"stockManagementAdminCardLink"},{"name":"stock-operation-dialog","component":"stockOperationDialog"},{"name":"import-bulk-stock-items","component":"importBulkStockItemsDialog"},{"name":"delete-stock-modal","component":"deleteStockModal"},{"name":"delete-stock-user-scope-modal","component":"deleteUserScopeModal"},{"name":"stock-management-app-menu-item","component":"stockManagementAppMenuItem","slot":"app-menu-item-slot","meta":{"name":" Stock Management"}},{"name":"delete-stock-rule-modal","component":"deleteStockRuleModal"},{"name":"delete-packaging-unit-modal","component":"deletePackagingUnitModal"},{"name":"delete-packaging-unit-button","component":"deletePackagingUnitButton"}],"pages":[{"component":"root","route":"stock-management"}],"version":"1.0.1-pre.641"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openmrs/esm-stock-management-app",
-  "version": "1.0.1-pre.632",
+  "version": "1.0.1-pre.641",
   "license": "MPL-2.0",
   "description": "Stock management microfrontend for OpenMRS 3.x",
   "browser": "dist/openmrs-esm-stock-management-app.js",

package/src/core/components/carbon/controlled-number-input/controlled-number-input.component.tsx

@@ -19,6 +19,7 @@ const ControlledNumberInput = <T,>(props: ControlledNumberInputProps<T>) => {
       control={props.control}
       render={({ field: { onChange, value, ref } }) => (
         <NumberInput
+          disableWheel
           label={props.label}
           id={`${props.name}-${props.id}-${props.row?.uuid}`}
           value={props.row?.factor ?? value}

package/src/stock-items/stock-items-table.component.tsx

@@ -187,7 +187,7 @@ const StockItemsTableComponent: React.FC<StockItemsTableProps> = () => {
 
                 <FilterStockItems filterType={isDrug} changeFilterType={setDrug} />
                 <AddStockItemsBulktImportActionButton />
-                <TableToolbarMenu>
+                <TableToolbarMenu data-testid="stock-items-menu">
                   <TableToolbarAction onClick={handleRefresh}>Refresh</TableToolbarAction>
                 </TableToolbarMenu>
                 <AddStockItemActionButton />

package/src/stock-items/stock-items-table.test.tsx

@@ -0,0 +1,134 @@
+import React from 'react';
+import { render, screen, waitFor, within } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
+import StockItemsTableComponent from './stock-items-table.component';
+import { useStockItemsPages } from './stock-items-table.resource';
+import { handleMutate } from '../utils';
+import { launchAddOrEditDialog } from './stock-item.utils';
+
+jest.mock('./stock-items-table.resource', () => ({
+  useStockItemsPages: jest.fn(),
+}));
+
+jest.mock('../utils', () => ({
+  handleMutate: jest.fn(),
+}));
+
+jest.mock('./stock-item.utils', () => ({
+  launchAddOrEditDialog: jest.fn(),
+}));
+
+jest.mock('react-i18next', () => ({
+  useTranslation: () => ({
+    t: (key: string) => key,
+  }),
+}));
+
+describe('StockItemsTableComponent', () => {
+  const mockUseStockItemsPages = {
+    isLoading: false,
+    items: Array(25).fill(null).map((_, index) => ({
+      uuid: `item-${index}`,
+      commonName: `Test Item ${index}`,
+      drugUuid: index % 2 === 0 ? `drug-${index}` : null,
+      conceptName: `Concept ${index}`,
+      dispensingUnitName: `Unit ${index}`,
+      defaultStockOperationsUoMName: `UoM ${index}`,
+      reorderLevel: index * 10,
+      reorderLevelUoMName: 'Units',
+    })),
+    totalCount: 25,
+    currentPageSize: 10,
+    setPageSize: jest.fn(),
+    pageSizes: [10, 20, 30],
+    currentPage: 1,
+    setCurrentPage: jest.fn(),
+    isDrug: '',
+    setDrug: jest.fn(),
+    setSearchString: jest.fn(),
+  };
+
+  beforeEach(() => {
+    jest.clearAllMocks();
+    (useStockItemsPages as jest.Mock).mockReturnValue(mockUseStockItemsPages);
+  });
+
+  it('renders initial state and UI elements correctly', async () => {
+    render(<StockItemsTableComponent />);
+    expect(screen.getByText('panelDescription')).toBeInTheDocument();
+    expect(screen.getByRole('searchbox')).toBeInTheDocument();
+    
+    const user = userEvent.setup();
+    const menuButton = screen.getByTestId('stock-items-menu');
+    await user.click(menuButton);
+  
+    await screen.findByText('Refresh');
+    
+    expect(screen.getByText('type')).toBeInTheDocument();
+    expect(screen.getByText('genericName')).toBeInTheDocument();
+    expect(screen.getByText('commonName')).toBeInTheDocument();
+  });
+
+  it('displays skeleton loader when isLoading is true', () => {
+    (useStockItemsPages as jest.Mock).mockReturnValue({ ...mockUseStockItemsPages, isLoading: true });
+    render(<StockItemsTableComponent />);
+    expect(screen.getByRole('progressbar')).toBeInTheDocument();
+  });
+
+  it('renders table rows correctly based on items prop', () => {
+    render(<StockItemsTableComponent />);
+    expect(screen.getByText('Test Item 0')).toBeInTheDocument();
+    expect(screen.getAllByText('drug').length).toBeGreaterThan(0);
+    expect(screen.getAllByText('other').length).toBeGreaterThan(0);
+  });
+
+  it('updates search input and triggers search function', async () => {
+    render(<StockItemsTableComponent />);
+    const user = userEvent.setup();
+    const searchInput = screen.getByRole('searchbox');
+    await user.type(searchInput, 'test search');
+    await waitFor(() => {
+      expect(mockUseStockItemsPages.setSearchString).toHaveBeenCalledWith('test search');
+    }, { timeout: 2000 });
+  });
+
+  it('updates pagination when page or page size changes', async () => {
+    render(<StockItemsTableComponent />);
+    const user = userEvent.setup();
+    const nextPageButton = screen.getByLabelText('Next page');
+    await user.click(nextPageButton);
+    expect(mockUseStockItemsPages.setCurrentPage).toHaveBeenCalled();
+
+    const pageSizeSelect = screen.getByLabelText('Items per page:');
+    await user.selectOptions(pageSizeSelect, '20');
+    expect(mockUseStockItemsPages.setPageSize).toHaveBeenCalledWith(20);
+  });
+
+  it('triggers handleRefresh when refresh button is clicked', async () => {
+    render(<StockItemsTableComponent />);
+    
+    const user = userEvent.setup();
+    const menuButton = screen.getByTestId('stock-items-menu');
+    expect(menuButton).toBeInTheDocument();
+    await user.click(menuButton);
+  
+    const refreshButton = await screen.findByText('Refresh');
+    expect(refreshButton).toBeInTheDocument();
+    await user.click(refreshButton);
+    await waitFor(() => {
+      expect(handleMutate).toHaveBeenCalledWith(expect.stringContaining('/stockmanagement/stockitem'));
+    });
+  });
+
+  it('triggers launchAddOrEditDialog when edit button is clicked', async () => {
+    render(<StockItemsTableComponent />);
+    const user = userEvent.setup();
+    const editButtons = screen.getAllByLabelText('Edit Stock Item');
+    await user.click(editButtons[0]);
+    expect(launchAddOrEditDialog).toHaveBeenCalledWith(
+      expect.any(Function),
+      expect.objectContaining({ uuid: 'item-0' }),
+      true
+    );
+  });
+});

package/src/stock-operations/add-stock-operation/stock-items-addition-row.component.tsx

@@ -3,7 +3,6 @@ import { isDesktop } from '@openmrs/esm-framework';
 import { Button, DatePicker, DatePickerInput, Link, NumberInput, TableCell, TableRow, TextInput } from '@carbon/react';
 import { TrashCan } from '@carbon/react/icons';
 import { StockOperationItemFormData } from '../validation-schema';
-import StockItemSelector from '../stock-item-selector/stock-item-selector.component';
 import {
   Control,
   FieldArrayWithId,
@@ -217,11 +216,12 @@ const StockItemsAdditionRow: React.FC<StockItemsAdditionRowProps> = ({
               <div className={styles.cellContent}>
                 {canEdit && (
                   <NumberInput
+                    allowEmpty
                     className="small-placeholder-text"
+                    disableWheel
+                    hideSteppers
                     size="sm"
                     id={`qty-${row?.uuid}`}
-                    hideSteppers={true}
-                    allowEmpty={true}
                     onChange={(e: any) => setValue(`stockItems.${index}.quantity`, e?.target?.value)}
                     value={row?.quantity ?? ''}
                     invalidText={errors?.stockItems?.[index]?.quantity?.message}
@@ -262,11 +262,12 @@ const StockItemsAdditionRow: React.FC<StockItemsAdditionRowProps> = ({
                   <div className={styles.cellContent}>
                     {canEdit && (
                       <NumberInput
+                        allowEmpty
+                        disableWheel
                         size="sm"
                         invalid={!!errors?.stockItems?.[index]?.purchasePrice}
                         invalidText=""
                         id={`purchaseprice-${row.uuid}`}
-                        allowEmpty={true}
                         onChange={(e: any) => setValue(`stockItems.${index}.purchasePrice`, e?.target?.value)}
                         value={row?.purchasePrice ?? ''}
                         title=""

package/src/stock-reports/generate-report/create-stock-report.component.tsx

@@ -522,8 +522,9 @@ const CreateReport: React.FC<CreateReportProps> = ({ model }) => {
             render={({ field: { onChange, value } }) => (
               <NumberInput
                 id="limitTop"
-                allowEmpty={true}
-                hideSteppers={true}
+                allowEmpty
+                disableWheel
+                hideSteppers
                 value={value}
                 onchange={onChange}
                 label={t('limit', 'Limit')}

package/src/stock-sources/add-stock-sources/add-stock-sources.test.tsx

@@ -41,7 +41,7 @@ describe('StockSourcesAddOrUpdate', () => {
 
   it('renders correctly with model prop', () => {
     const model: StockSource = {
-      uuid: '123', // Add this
+      uuid: '123',
       name: 'Test Source',
       acronym: 'TS',
       sourceType: {
@@ -72,7 +72,6 @@ describe('StockSourcesAddOrUpdate', () => {
         retiredBy: undefined,
         retireReason: '',
       },
-      // Add these properties from BaseOpenmrsData
       creator: {
         uuid: 'creator-uuid',
         display: 'Creator Name',
@@ -115,13 +114,14 @@ describe('StockSourcesAddOrUpdate', () => {
 
     await user.type(screen.getByLabelText('Full Name'), 'New Source');
     await user.type(screen.getByLabelText('Acronym/Code'), 'NS');
-    await user.type(screen.getByLabelText('Source Type'), 'type2');
+    await user.selectOptions(screen.getByLabelText('Source Type'), 'type2');
     await user.click(screen.getByText('Save'));
 
     expect(createOrUpdateStockSource).toHaveBeenCalledWith(
       expect.objectContaining({
         name: 'New Source',
         acronym: 'NS',
+        sourceType: expect.objectContaining({ uuid: 'type2' }),
       }),
     );
   });
@@ -168,4 +168,4 @@ describe('StockSourcesAddOrUpdate', () => {
 
     expect(closeOverlay).toHaveBeenCalled();
   });
-});
+});