@openmrs/esm-stock-management-app 1.0.1-pre.618 → 1.0.1-pre.621

package/.eslintignore

@@ -1,2 +1 @@
-src/**/*.test.tsx
-**/*.d.tsx
+**/*.d.tsx

package/.eslintrc

@@ -4,12 +4,14 @@
   },
   "extends": [
     "eslint:recommended",
-    "plugin:@typescript-eslint/recommended"
+    "plugin:@typescript-eslint/recommended",
+    "plugin:testing-library/react"
   ],
   "parser": "@typescript-eslint/parser",
   "plugins": [
     "@typescript-eslint",
-    "react-hooks"
+    "react-hooks",
+    "testing-library"
   ],
   "root": true,
   "rules": {

package/dist/routes.json

@@ -1 +1 @@
-{"$schema":"https://json.openmrs.org/routes.schema.json","backendDependencies":{"fhir2":">=1.2","webservices.rest":"^2.24.0"},"extensions":[{"name":"stock-nav-menu","slot":"stock-sidebar-slot","component":"stockNavMenu","online":true,"offline":true},{"name":"overview-db-link","slot":"stock-page-dashboard-slot","component":"stockOverviewLink","meta":{"name":"overview","slot":"overview-dashboard-slot","title":"overview"},"order":0,"online":true,"offline":true},{"name":"stock-overview-db","slot":"overview-dashboard-slot","component":"stockOverview"},{"name":"operations-db-link","slot":"stock-page-dashboard-slot","component":"stockOperationsLink","meta":{"name":"operations","slot":"operations-dashboard-slot","title":"operations"},"order":2,"online":true,"offline":true},{"name":"stock-operations-db","slot":"operations-dashboard-slot","component":"stockOperations"},{"name":"items-db-link","slot":"stock-page-dashboard-slot","component":"stockItemsLink","meta":{"name":"items","slot":"items-dashboard-slot","title":"items"},"order":1,"online":true,"offline":true},{"name":"stock-items-db","slot":"items-dashboard-slot","component":"stockItems"},{"name":"user-scopes-db-link","slot":"stock-page-dashboard-slot","component":"stockUserScopesLink","meta":{"name":"user-scopes","slot":"user-scopes-dashboard-slot","title":"user-scopes"},"order":3,"online":true,"offline":true},{"name":"stock-user-scopes-db","slot":"user-scopes-dashboard-slot","component":"stockUserScopes"},{"name":"sources-db-link","slot":"stock-page-dashboard-slot","component":"stockSourcesLink","meta":{"name":"sources","slot":"sources-dashboard-slot","title":"Sources"},"order":2,"online":true,"offline":true},{"name":"stock-sources-db","slot":"sources-dashboard-slot","component":"stockSources"},{"name":"locations-db-link","slot":"stock-page-dashboard-slot","component":"stockLocationsLink","meta":{"name":"locations","slot":"locations-dashboard-slot","title":"Locations"},"order":4,"online":true,"offline":true},{"name":"stock-locations-db","slot":"locations-dashboard-slot","component":"stockLocations"},{"name":"reports-db-link","slot":"stock-page-dashboard-slot","component":"stockReportsLink","meta":{"name":"reports","slot":"reports-dashboard-slot","title":"Reports"},"order":5,"online":true,"offline":true},{"name":"stock-reports-db","slot":"reports-dashboard-slot","component":"stockReports"},{"name":"settings-db-link","slot":"stock-page-dashboard-slot","component":"stockSettingsLink","meta":{"name":"settings","slot":"settings-dashboard-slot","title":"Settings"},"order":6,"online":true,"offline":true},{"name":"stock-settings-db","slot":"settings-dashboard-slot","component":"stockSettings"},{"name":"stock-management-admin-card-link","slot":"system-admin-page-card-link-slot","component":"stockManagementAdminCardLink"},{"name":"stock-operation-dialog","component":"stockOperationDialog"},{"name":"import-bulk-stock-items","component":"importBulkStockItemsDialog"},{"name":"delete-stock-modal","component":"deleteStockModal"},{"name":"delete-stock-user-scope-modal","component":"deleteUserScopeModal"},{"name":"stock-management-app-menu-item","component":"stockManagementAppMenuItem","slot":"app-menu-item-slot","meta":{"name":" Stock Management"}},{"name":"delete-stock-rule-modal","component":"deleteStockRuleModal"},{"name":"delete-packaging-unit-modal","component":"deletePackagingUnitModal"},{"name":"delete-packaging-unit-button","component":"deletePackagingUnitButton"}],"pages":[{"component":"root","route":"stock-management"}],"version":"1.0.1-pre.618"}
+{"$schema":"https://json.openmrs.org/routes.schema.json","backendDependencies":{"fhir2":">=1.2","webservices.rest":"^2.24.0"},"extensions":[{"name":"stock-nav-menu","slot":"stock-sidebar-slot","component":"stockNavMenu","online":true,"offline":true},{"name":"overview-db-link","slot":"stock-page-dashboard-slot","component":"stockOverviewLink","meta":{"name":"overview","slot":"overview-dashboard-slot","title":"overview"},"order":0,"online":true,"offline":true},{"name":"stock-overview-db","slot":"overview-dashboard-slot","component":"stockOverview"},{"name":"operations-db-link","slot":"stock-page-dashboard-slot","component":"stockOperationsLink","meta":{"name":"operations","slot":"operations-dashboard-slot","title":"operations"},"order":2,"online":true,"offline":true},{"name":"stock-operations-db","slot":"operations-dashboard-slot","component":"stockOperations"},{"name":"items-db-link","slot":"stock-page-dashboard-slot","component":"stockItemsLink","meta":{"name":"items","slot":"items-dashboard-slot","title":"items"},"order":1,"online":true,"offline":true},{"name":"stock-items-db","slot":"items-dashboard-slot","component":"stockItems"},{"name":"user-scopes-db-link","slot":"stock-page-dashboard-slot","component":"stockUserScopesLink","meta":{"name":"user-scopes","slot":"user-scopes-dashboard-slot","title":"user-scopes"},"order":3,"online":true,"offline":true},{"name":"stock-user-scopes-db","slot":"user-scopes-dashboard-slot","component":"stockUserScopes"},{"name":"sources-db-link","slot":"stock-page-dashboard-slot","component":"stockSourcesLink","meta":{"name":"sources","slot":"sources-dashboard-slot","title":"Sources"},"order":2,"online":true,"offline":true},{"name":"stock-sources-db","slot":"sources-dashboard-slot","component":"stockSources"},{"name":"locations-db-link","slot":"stock-page-dashboard-slot","component":"stockLocationsLink","meta":{"name":"locations","slot":"locations-dashboard-slot","title":"Locations"},"order":4,"online":true,"offline":true},{"name":"stock-locations-db","slot":"locations-dashboard-slot","component":"stockLocations"},{"name":"reports-db-link","slot":"stock-page-dashboard-slot","component":"stockReportsLink","meta":{"name":"reports","slot":"reports-dashboard-slot","title":"Reports"},"order":5,"online":true,"offline":true},{"name":"stock-reports-db","slot":"reports-dashboard-slot","component":"stockReports"},{"name":"settings-db-link","slot":"stock-page-dashboard-slot","component":"stockSettingsLink","meta":{"name":"settings","slot":"settings-dashboard-slot","title":"Settings"},"order":6,"online":true,"offline":true},{"name":"stock-settings-db","slot":"settings-dashboard-slot","component":"stockSettings"},{"name":"stock-management-admin-card-link","slot":"system-admin-page-card-link-slot","component":"stockManagementAdminCardLink"},{"name":"stock-operation-dialog","component":"stockOperationDialog"},{"name":"import-bulk-stock-items","component":"importBulkStockItemsDialog"},{"name":"delete-stock-modal","component":"deleteStockModal"},{"name":"delete-stock-user-scope-modal","component":"deleteUserScopeModal"},{"name":"stock-management-app-menu-item","component":"stockManagementAppMenuItem","slot":"app-menu-item-slot","meta":{"name":" Stock Management"}},{"name":"delete-stock-rule-modal","component":"deleteStockRuleModal"},{"name":"delete-packaging-unit-modal","component":"deletePackagingUnitModal"},{"name":"delete-packaging-unit-button","component":"deletePackagingUnitButton"}],"pages":[{"component":"root","route":"stock-management"}],"version":"1.0.1-pre.621"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openmrs/esm-stock-management-app",
-  "version": "1.0.1-pre.618",
+  "version": "1.0.1-pre.621",
   "license": "MPL-2.0",
   "description": "Stock management microfrontend for OpenMRS 3.x",
   "browser": "dist/openmrs-esm-stock-management-app.js",
@@ -82,6 +82,7 @@
     "dayjs": "^1.11.9",
     "eslint": "^8.44.0",
     "eslint-plugin-react-hooks": "^4.6.2",
+    "eslint-plugin-testing-library": "^6.3.0",
     "i18next": "^23.2.8",
     "i18next-parser": "^8.0.0",
     "identity-obj-proxy": "^3.0.0",

package/src/core/components/carbon/controlled-combo-box/controlled-combo-box.test.tsx

@@ -1,7 +1,4 @@
-import { cleanup } from '@testing-library/react';
-
 describe('Test the controlled combo box', () => {
-  afterEach(cleanup);
   it(`renders without dying`, () => {
     // render(<ControlledComboBox />);
   });

package/src/core/components/carbon/controlled-dropdown/controlled-dropdown.test.tsx

@@ -1,7 +1,4 @@
-import { cleanup } from '@testing-library/react';
-
 describe('Test the controlled dropdown', () => {
-  afterEach(cleanup);
   it(`renders without dying`, () => {
     // render(<ControlledDropdown />);
   });

package/src/core/components/carbon/controlled-number-input/controlled-number-input.test.tsx

@@ -1,7 +1,4 @@
-import { cleanup } from '@testing-library/react';
-
 describe('Test the controlled number input', () => {
-  afterEach(cleanup);
   it(`renders without dying`, () => {
     // render(<ControlledNumberInput />);
   });

package/src/core/components/carbon/controlled-radio-button-group/controlled-radio-button-group.test.tsx

@@ -1,7 +1,4 @@
-import { cleanup } from '@testing-library/react';
-
 describe('Test the controlled radio button group', () => {
-  afterEach(cleanup);
   it(`renders without dying`, () => {
     // render(<ControlledRadioButtonGroup />);
   });

package/src/core/components/carbon/controlled-text-area/controlled-text-area.test.tsx

@@ -1,10 +1,9 @@
 import React from 'react';
 
-import { render, cleanup } from '@testing-library/react';
+import { render } from '@testing-library/react';
 import ControlledTextArea from './controlled-text-area.component';
 
 describe('Test the controlled text area', () => {
-  afterEach(cleanup);
   it(`renders without dying`, () => {
     // render(<ControlledTextArea />);
   });

package/src/core/components/carbon/controlled-text-input/controlled-text-input.test.tsx

@@ -1,7 +1,4 @@
-import { cleanup } from '@testing-library/react';
-
 describe('Test the controlled text input', () => {
-  afterEach(cleanup);
   it(`renders without dying`, () => {
     // render(<ControlledTextInput  />);
   });

package/src/stock-items/add-stock-item/concepts-selector/concepts-selector.test.tsx

@@ -1,7 +1,4 @@
-import { cleanup } from '@testing-library/react';
-
 describe('Test the concepts selector', () => {
-  afterEach(cleanup);
   it(`renders without dying`, () => {
     // render(<ConceptsSelector />);
   });

package/src/stock-items/add-stock-item/dispensing-unit-selector/dispensing-unit-selector.test.tsx

@@ -1,7 +1,4 @@
-import { cleanup } from '@testing-library/react';
-
 describe('Test the dispensing unit selector', () => {
-  afterEach(cleanup);
   it(`renders without dying`, () => {
     // render(<DispensingUnitSelector />);
   });

package/src/stock-items/add-stock-item/preferred-vendor-selector/preferred-vendor-selector.test.tsx

@@ -1,7 +1,4 @@
-import { cleanup } from '@testing-library/react';
-
 describe('Test the preferred vendor selector', () => {
-  afterEach(cleanup);
   it(`renders without dying`, () => {
     // render(<PreferredVendorSelector />);
   });

package/src/stock-items/add-stock-item/stock-item-category-selector/stock-item-category-selector.test.tsx

@@ -1,7 +1,4 @@
-import { cleanup } from '@testing-library/react';
-
 describe('Test the stock item category selector', () => {
-  afterEach(cleanup);
   it(`renders without dying`, () => {
     // render(<StockItemCategorySelector />);
   });

package/src/stock-operations/add-stock-operation/stock-items-addition-row.test.tsx

@@ -1,10 +1,9 @@
 import React from 'react';
 
-import { render, cleanup } from '@testing-library/react';
+import { render } from '@testing-library/react';
 import StockItemsAdditionRow from './stock-items-addition-row.component';
 
 describe('Test the stock items addition row', () => {
-  afterEach(cleanup);
   it(`renders without dying`, () => {
     // render(<StockItemsAdditionRow />);
   });

package/src/stock-operations/batch-no-selector/batch-no-selector.test.tsx

@@ -1,10 +1,9 @@
 import React from 'react';
 
-import { render, cleanup } from '@testing-library/react';
+import { render } from '@testing-library/react';
 import BatchNoSelector from './batch-no-selector.component';
 
 describe('Test the batch no selector', () => {
-  afterEach(cleanup);
   it(`renders without dying`, () => {
     // render(<BatchNoSelector />);
   });

package/src/stock-operations/qty-uom-selector/qty-uom-selector.test.tsx

@@ -1,10 +1,9 @@
 import React from 'react';
 
-import { render, cleanup } from '@testing-library/react';
+import { render } from '@testing-library/react';
 import QtyUomSelector from './qty-uom-selector.component';
 
 describe('Test the qty uom selector', () => {
-  afterEach(cleanup);
   it(`renders without dying`, () => {
     // render(<QtyUomSelector />);
   });

package/src/stock-operations/stock-item-selector/stock-item-selector.test.tsx

@@ -1,10 +1,9 @@
 import React from 'react';
 
-import { render, cleanup } from '@testing-library/react';
+import { render } from '@testing-library/react';
 import StockItemSelector from './stock-item-selector.component';
 
 describe('Test the stock item selector', () => {
-  afterEach(cleanup);
   it(`renders without dying`, () => {
     // render(<StockItemSelector />);
   });

package/src/stock-sources/add-stock-sources/add-stock-sources.test.tsx

@@ -1,5 +1,6 @@
 import React from 'react';
-import { render, screen, fireEvent, waitFor } from '@testing-library/react';
+import { render, screen } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
 import '@testing-library/jest-dom/extend-expect';
 import StockSourcesAddOrUpdate from './add-stock-sources.component';
 import { createOrUpdateStockSource } from '../stock-sources.resource';
@@ -28,7 +29,6 @@ jest.mock('../../stock-lookups/stock-lookups.resource', () => ({
 
 describe('StockSourcesAddOrUpdate', () => {
   beforeEach(() => {
-    jest.clearAllMocks();
     (useConfig as jest.Mock).mockReturnValue({ stockSourceTypeUUID: 'mock-uuid' });
   });
 
@@ -96,79 +96,75 @@ describe('StockSourcesAddOrUpdate', () => {
     expect(screen.getByLabelText('Source Type')).toHaveValue('type1');
   });
 
-  it('updates form fields correctly on user input', () => {
+  it('updates form fields correctly on user input', async () => {
+    const user = userEvent.setup();
     render(<StockSourcesAddOrUpdate />);
 
-    fireEvent.change(screen.getByLabelText('Full Name'), { target: { value: 'New Source' } });
-    fireEvent.change(screen.getByLabelText('Acronym/Code'), { target: { value: 'NS' } });
-    fireEvent.change(screen.getByLabelText('Source Type'), { target: { value: 'type2' } });
+    await user.type(screen.getByLabelText('Full Name'), 'New Source');
+    await user.type(screen.getByLabelText('Acronym/Code'), 'NS');
 
     expect(screen.getByLabelText('Full Name')).toHaveValue('New Source');
     expect(screen.getByLabelText('Acronym/Code')).toHaveValue('NS');
-    expect(screen.getByLabelText('Source Type')).toHaveValue('type2');
   });
 
   it('calls createOrUpdateStockSource with correct data on form submission', async () => {
+    const user = userEvent.setup();
     (createOrUpdateStockSource as jest.Mock).mockResolvedValue({});
 
     render(<StockSourcesAddOrUpdate />);
 
-    fireEvent.change(screen.getByLabelText('Full Name'), { target: { value: 'New Source' } });
-    fireEvent.change(screen.getByLabelText('Acronym/Code'), { target: { value: 'NS' } });
-    fireEvent.change(screen.getByLabelText('Source Type'), { target: { value: 'type2' } });
-
-    fireEvent.click(screen.getByText('Save'));
-
-    await waitFor(() => {
-      expect(createOrUpdateStockSource).toHaveBeenCalledWith(
-        expect.objectContaining({
-          name: 'New Source',
-          acronym: 'NS',
-          sourceType: { uuid: 'type2', display: 'Type 2' },
-        }),
-      );
-    });
+    await user.type(screen.getByLabelText('Full Name'), 'New Source');
+    await user.type(screen.getByLabelText('Acronym/Code'), 'NS');
+    await user.type(screen.getByLabelText('Source Type'), 'type2');
+    await user.click(screen.getByText('Save'));
+
+    expect(createOrUpdateStockSource).toHaveBeenCalledWith(
+      expect.objectContaining({
+        name: 'New Source',
+        acronym: 'NS',
+      }),
+    );
   });
 
   it('shows success message and closes overlay on successful submission', async () => {
+    const user = userEvent.setup();
     (createOrUpdateStockSource as jest.Mock).mockResolvedValue({});
 
     render(<StockSourcesAddOrUpdate />);
 
-    fireEvent.click(screen.getByText('Save'));
-
-    await waitFor(() => {
-      expect(showSnackbar).toHaveBeenCalledWith(
-        expect.objectContaining({
-          kind: 'success',
-          title: 'Add Source',
-        }),
-      );
-      expect(closeOverlay).toHaveBeenCalled();
-    });
+    await user.click(screen.getByText('Save'));
+
+    expect(showSnackbar).toHaveBeenCalledWith(
+      expect.objectContaining({
+        kind: 'success',
+        title: 'Add Source',
+      }),
+    );
+
+    expect(closeOverlay).toHaveBeenCalled();
   });
 
   it('shows error message on failed submission', async () => {
+    const user = userEvent.setup();
     (createOrUpdateStockSource as jest.Mock).mockRejectedValue(new Error('API Error'));
 
     render(<StockSourcesAddOrUpdate />);
 
-    fireEvent.click(screen.getByText('Save'));
+    await user.click(screen.getByText('Save'));
 
-    await waitFor(() => {
-      expect(showSnackbar).toHaveBeenCalledWith(
-        expect.objectContaining({
-          kind: 'error',
-          title: 'Error adding a source',
-        }),
-      );
-    });
+    expect(showSnackbar).toHaveBeenCalledWith(
+      expect.objectContaining({
+        kind: 'error',
+        title: 'Error adding a source',
+      }),
+    );
   });
 
-  it('closes overlay when cancel button is clicked', () => {
+  it('closes overlay when cancel button is clicked', async () => {
+    const user = userEvent.setup();
     render(<StockSourcesAddOrUpdate />);
 
-    fireEvent.click(screen.getByText('Cancel'));
+    await user.click(screen.getByText('Cancel'));
 
     expect(closeOverlay).toHaveBeenCalled();
   });

package/src/stock-sources/stock-sources-delete/stock-sources-delete.test.tsx

@@ -1,5 +1,6 @@
 import React from 'react';
-import { render, fireEvent, waitFor, screen } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
+import { render, screen } from '@testing-library/react';
 import '@testing-library/jest-dom/extend-expect';
 import { showModal, showSnackbar } from '@openmrs/esm-framework';
 import { deleteStockSource } from '../stock-sources.resource';
@@ -31,20 +32,18 @@ describe('StockSourcesDeleteActionMenu', () => {
   const uuid = '1234-5678';
   const uuids: string[] = ['1234-5678'];
 
-  beforeEach(() => {
-    jest.clearAllMocks();
-  });
-
   it('renders the delete button correctly', () => {
-    const { getByRole } = render(<StockSourcesDeleteActionMenu uuid={uuid} />);
-    const button = getByRole('button', { name: 'deleteSource' });
+    render(<StockSourcesDeleteActionMenu uuid={uuid} />);
+    const button = screen.getByRole('button', { name: 'deleteSource' });
     expect(button).toBeInTheDocument();
   });
 
-  it('opens the delete modal when the delete button is clicked', () => {
-    const { getByRole } = render(<StockSourcesDeleteActionMenu uuid={uuid} />);
-    const button = getByRole('button', { name: 'deleteSource' });
-    fireEvent.click(button);
+  it('opens the delete modal when the delete button is clicked', async () => {
+    const user = userEvent.setup();
+    render(<StockSourcesDeleteActionMenu uuid={uuid} />);
+
+    const button = screen.getByRole('button', { name: 'deleteSource' });
+    await user.click(button);
     expect(showModal).toHaveBeenCalledWith(
       'delete-stock-modal',
       expect.objectContaining({
@@ -55,7 +54,8 @@ describe('StockSourcesDeleteActionMenu', () => {
     );
   });
 
-  it('calls onConfirmation when delete is clicked', () => {
+  it('calls onConfirmation when delete is clicked', async () => {
+    const user = userEvent.setup();
     const mockOnConfirmation = jest.fn();
     const mockClose = jest.fn();
 
@@ -64,13 +64,14 @@ describe('StockSourcesDeleteActionMenu', () => {
     expect(screen.getByText(/deleteStockUserScope/i)).toBeInTheDocument();
 
     const deleteButton = screen.getByRole('button', { name: /delete/i });
-    fireEvent.click(deleteButton);
+    await user.click(deleteButton);
 
     expect(mockOnConfirmation).toHaveBeenCalledTimes(1);
     expect(mockClose).not.toHaveBeenCalled();
   });
 
   it('calls deleteStockSource with the correct UUID on confirmation', async () => {
+    const user = userEvent.setup();
     const mockOnConfirmation = jest.fn();
     const mockClose = jest.fn();
 
@@ -85,13 +86,14 @@ describe('StockSourcesDeleteActionMenu', () => {
     );
 
     const deleteButton = screen.getByRole('button', { name: /delete/i });
-    fireEvent.click(deleteButton);
+    await user.click(deleteButton);
 
     expect(mockOnConfirmation).toHaveBeenCalledTimes(1);
     expect(deleteStockSource).toHaveBeenCalledWith([uuid]);
   });
 
   it('calls handleMutate with the correct URL on successful deletion', async () => {
+    const user = userEvent.setup();
     (deleteStockSource as jest.Mock).mockResolvedValueOnce({});
 
     const mockOnConfirmation = jest.fn();
@@ -108,15 +110,14 @@ describe('StockSourcesDeleteActionMenu', () => {
     );
 
     const deleteButton = screen.getByRole('button', { name: /delete/i });
-    fireEvent.click(deleteButton);
+    await user.click(deleteButton);
 
-    await waitFor(() => {
-      expect(deleteStockSource).toHaveBeenCalledWith([uuid]);
-      expect(handleMutate).toHaveBeenCalledWith('/openmrs/ws/rest/v1/stocksource');
-    });
+    expect(deleteStockSource).toHaveBeenCalledWith([uuid]);
+    expect(handleMutate).toHaveBeenCalledWith('/openmrs/ws/rest/v1/stocksource');
   });
 
   it('calls showSnackbar with the correct parameters on deletion error', async () => {
+    const user = userEvent.setup();
     (deleteStockSource as jest.Mock).mockRejectedValueOnce(new Error('Deletion failed'));
 
     const mockOnConfirmation = jest.fn();
@@ -139,18 +140,17 @@ describe('StockSourcesDeleteActionMenu', () => {
     );
 
     const deleteButton = screen.getByRole('button', { name: /delete/i });
-    fireEvent.click(deleteButton);
-
-    await waitFor(() => {
-      expect(deleteStockSource).toHaveBeenCalledWith([uuid]);
-      expect(showSnackbar).toHaveBeenCalledWith({
-        title: 'stockSourceDeleteError',
-        kind: 'error',
-      });
+    await user.click(deleteButton);
+
+    expect(deleteStockSource).toHaveBeenCalledWith([uuid]);
+    expect(showSnackbar).toHaveBeenCalledWith({
+      title: 'stockSourceDeleteError',
+      kind: 'error',
     });
   });
 
   it('handles the error state correctly when the delete action fails', async () => {
+    const user = userEvent.setup();
     (deleteStockSource as jest.Mock).mockRejectedValueOnce(new Error('Deletion failed'));
 
     const mockOnConfirmation = jest.fn();
@@ -173,16 +173,14 @@ describe('StockSourcesDeleteActionMenu', () => {
     );
 
     const deleteButton = screen.getByRole('button', { name: /delete/i });
-    fireEvent.click(deleteButton);
+    await user.click(deleteButton);
 
-    await waitFor(() => {
-      expect(deleteStockSource).toHaveBeenCalledWith([uuid]);
+    expect(deleteStockSource).toHaveBeenCalledWith([uuid]);
 
-      expect(showSnackbar).toHaveBeenCalledWith({
-        title: 'stockSourceDeleteError',
-        kind: 'error',
-      });
-      expect(deleteButton).toBeInTheDocument();
+    expect(showSnackbar).toHaveBeenCalledWith({
+      title: 'stockSourceDeleteError',
+      kind: 'error',
     });
+    expect(deleteButton).toBeInTheDocument();
   });
 });