@openmfp/portal-ui-lib 0.183.0 → 0.183.1

package/fesm2022/openmfp-portal-ui-lib.mjs

@@ -230,8 +230,9 @@ class ConfigService {
             this.entityConfigCache[entity] = {};
         }
         const entityCacheKey = JSON.stringify(context);
-        if (this.entityConfigCache[entity][entityCacheKey]) {
-            return this.entityConfigCache[entity][entityCacheKey];
+        const cachedConfig = this.entityConfigCache[entity][entityCacheKey];
+        if (cachedConfig) {
+            return cachedConfig;
         }
         const options = this.requestHeadersService.createOptionsWithAuthHeader();
         const entityConfig = firstValueFrom(this.http.get(`/rest/config/${entity}`, {
@@ -671,6 +672,9 @@ const localDevelopmentSettingsLocalStorage = {
             return null;
         }
         try {
+            if (!localDevelopmentSettingsFromLocalStore) {
+                return null;
+            }
             return JSON.parse(localDevelopmentSettingsFromLocalStore);
         }
         catch (e) {
@@ -797,7 +801,7 @@ class IframeService {
                 allow += ';';
             }
             permissions.allow.forEach((policy) => {
-                if (this.isIFrameFeaturePolicyAllowed(policy, iframe.getAttribute('src'))) {
+                if (this.isIFrameFeaturePolicyAllowed(policy, this.getIframeSrc(iframe))) {
                     // feature policies are separated by semicolon
                     allow += ` ${policy};`;
                 }
@@ -807,7 +811,7 @@ class IframeService {
         if (permissions.sandbox) {
             let sandbox = (iframe.getAttribute('sandbox') || '').trim();
             permissions.sandbox.forEach((permission) => {
-                if (this.isIFrameSandboxPermissionAllowed(permission, iframe.getAttribute('src'))) {
+                if (this.isIFrameSandboxPermissionAllowed(permission, this.getIframeSrc(iframe))) {
                     // sandbox permission are separated by whitespace
                     sandbox += ' ' + permission;
                 }
@@ -815,6 +819,17 @@ class IframeService {
             iframe.setAttribute('sandbox', sandbox.trim());
         }
     }
+    getIframeSrc(iframe) {
+        const src = iframe.getAttribute('src');
+        if (!src) {
+            this.luigiCoreService.showAlert({
+                text: 'Iframe source not found',
+                type: 'error',
+            });
+            throw new Error('Iframe source not found');
+        }
+        return src;
+    }
     static { this.ɵfac = i0.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "20.3.9", ngImport: i0, type: IframeService, deps: [], target: i0.ɵɵFactoryTarget.Injectable }); }
     static { this.ɵprov = i0.ɵɵngDeclareInjectable({ minVersion: "12.0.0", version: "20.3.9", ngImport: i0, type: IframeService, providedIn: 'root' }); }
 }
@@ -1004,7 +1019,7 @@ class UserSettingsConfigService {
                 this.applyNewTheme(settings, previous);
                 this.changeToSelectedLanguage(settings, previous);
                 this.saveLocalDevelopmentSettings(settings, previous);
-                if (envConfig.uiOptions.includes('enableFeatureToggleSetting')) {
+                if (envConfig.uiOptions?.includes('enableFeatureToggleSetting')) {
                     this.saveFeatureToggleSettings(settings);
                 }
             },
@@ -1017,7 +1032,7 @@ class UserSettingsConfigService {
         await this.addUserSettings(settings);
         await this.addThemingSettings(settings);
         this.addLocalDevelopmentSettings(settings);
-        if (envConfig.uiOptions.includes('enableFeatureToggleSetting')) {
+        if (envConfig.uiOptions?.includes('enableFeatureToggleSetting')) {
             this.addFeatureToggleSettings(settings);
         }
         this.addInfoSettings(settings);
@@ -1025,10 +1040,12 @@ class UserSettingsConfigService {
     }
     saveFeatureToggleSettings(settings) {
         const currentFeatureToggleSettings = settings?.frame_featureToggle?.featureToggleSettings;
-        featureToggleLocalStorage.store(currentFeatureToggleSettings);
-        this.luigiCoreService.unsetAllFeatureToggles();
-        this.luigiCoreService.setFeatureToggles(currentFeatureToggleSettings);
-        globalThis.location.reload();
+        if (currentFeatureToggleSettings) {
+            featureToggleLocalStorage.store(currentFeatureToggleSettings);
+            this.luigiCoreService.unsetAllFeatureToggles();
+            this.luigiCoreService.setFeatureToggles(currentFeatureToggleSettings);
+            globalThis.location.reload();
+        }
     }
     saveLocalDevelopmentSettings(settings, previous) {
         const currentLocalDevelopmentSettings = settings?.frame_development?.localDevelopmentSettings;
@@ -1081,10 +1098,10 @@ class UserSettingsConfigService {
         const user = this.authService.getUserInfo();
         const userSettings = await userSettingsLocalStorage.read(user);
         const selectedTheme = userSettings?.frame_appearance?.selectedTheme ||
-            this.luigiThemingService.getDefaultThemeId();
-        return this.luigiThemingService
-            .getAvailableThemes()
-            .find((t) => t.id === selectedTheme)?.name;
+            this.luigiThemingService?.getDefaultThemeId();
+        return (this.luigiThemingService
+            ?.getAvailableThemes()
+            ?.find((t) => t.id === selectedTheme)?.name || '');
     }
     async addThemingSettings(settings) {
         if (this.luigiThemingService) {
@@ -1265,8 +1282,8 @@ class AppSwitcherConfigServiceImpl {
         })
             .map((node) => {
             const nodeConfig = {
-                title: node.label,
-                icon: node.icon,
+                title: node.label || '',
+                icon: node.icon || '',
                 link: '/' + node.pathSegment,
             };
             return nodeConfig;
@@ -1493,9 +1510,9 @@ class LocalConfigurationServiceImpl {
         this.luigiCoreService.showAlert({
             text: `
             Your local development configuration contains error(s).
-            You will not be able to see your local changes and local development results unless you correct the data and reload the page. 
+            You will not be able to see your local changes and local development results unless you correct the data and reload the page.
             Please see below the detailed information: <br/><br/>
-            
+
             ${message}
           `,
             type: 'error',
@@ -1546,8 +1563,8 @@ class LocalConfigurationServiceImpl {
         const localEntityTypes = [...new Set(localNodes.map((n) => n.entityType))]
             .filter(Boolean)
             .join(',');
-        console.debug(`Found '${serverLuigiNodes.length}' server nodes. 
-       Found '${localNodes.length}' local luigi nodes. 
+        console.debug(`Found '${serverLuigiNodes.length}' server nodes.
+       Found '${localNodes.length}' local luigi nodes.
        The entities of the server node are: [${serverEntityTypes}]
        The entities of local nodes are: [${localEntityTypes}]`);
     }
@@ -1557,10 +1574,10 @@ class LocalConfigurationServiceImpl {
     }
     async getLocalConfigurations(localDevelopmentSettings) {
         const initialConfigurations = localDevelopmentSettings.configs
-            .filter((config) => config.data)
+            .filter((config) => !!config.data)
             .map((config) => config.data);
         const configurations = (await Promise.allSettled(localDevelopmentSettings.configs
-            .filter((config) => config.url)
+            .filter((config) => !!config.url)
             .map((config) => lastValueFrom(this.http.get(config.url)).then((contentConfiguration) => ({
             ...contentConfiguration,
             url: config.url,
@@ -1584,6 +1601,7 @@ class LuigiNodesService {
     constructor() {
         this.i18nService = inject(I18nService);
         this.configService = inject(ConfigService);
+        this.luigiCoreService = inject(LuigiCoreService);
         this.localConfigurationService = inject(LocalConfigurationServiceImpl);
         this.errorComponentConfig = inject(ERROR_COMPONENT_CONFIG, {
             optional: true,
@@ -1620,18 +1638,19 @@ class LuigiNodesService {
         let configsForEntity;
         const entityType = entityDefinition.dynamicFetchId;
         try {
+            if (!entityType) {
+                throw new Error('Entity type is required');
+            }
             configsForEntity = await this.configService.getEntityConfig(entityType, additionalContext);
+            return configsForEntity.providers.flatMap((p) => p.nodes);
         }
         catch (e) {
             errorCode = e.status || 500;
             console.warn(`Could not retrieve nodes for entity: ${entityType}, error: `, e);
+            return this.createErrorNodes(entityDefinition, errorCode, additionalContext);
         }
-        if (errorCode) {
-            return this.createErrorNodes(entityDefinition, additionalContext, errorCode);
-        }
-        return configsForEntity.providers.flatMap((p) => p.nodes);
     }
-    createErrorNodes(entityDefinition, additionalContext, errorCode) {
+    createErrorNodes(entityDefinition, errorCode, additionalContext) {
         return [
             {
                 pathSegment: 'error',
@@ -1956,10 +1975,10 @@ function logJMESException(context, jmesPathExpression, error) {
 
 const visibleForContext = (ctx, node) => {
     // visibleForEntityContext is deprecated
-    if (!isMatch(ctx.entityContext, node.visibleForEntityContext)) {
+    if (!isMatch(ctx?.entityContext, node.visibleForEntityContext)) {
         return false;
     }
-    return matchesJMESPath(ctx, node.visibleForContext);
+    return matchesJMESPath(ctx, node.visibleForContext ?? '');
 };
 const computeDynamicFetchContext = (entityNode, ctx) => {
     const contextForEntityConfig = new Map();
@@ -2057,6 +2076,9 @@ class NodeSortingService {
         const sortedOther = otherChildren.sort(this.nodeComparison);
         if (slotNodes.length > 0) {
             slotNodes.forEach((slotNode) => {
+                if (!slotNode.defineSlot) {
+                    return;
+                }
                 if (slottedChildrenMap[slotNode.defineSlot]) {
                     this.appendChildrenToSlot(sortedNodes, slotNode, slottedChildrenMap[slotNode.defineSlot].sort(this.nodeComparison));
                     delete slottedChildrenMap[slotNode.defineSlot];
@@ -2119,7 +2141,7 @@ class ChildrenNodesService {
                 entityContext[dynamicFetchId] = (await this.configService.getEntityConfig(dynamicFetchId, context)).entityContext;
             }
             catch (error) {
-                console.error(entityNode.defineEntity.id, 'does not exist', context);
+                console.error(entityNode.defineEntity?.id, 'does not exist', context);
             }
         }));
         childrenNodes.forEach((child) => {
@@ -2188,6 +2210,7 @@ class CommonGlobalLuigiNodesService {
                 label: 'Content not found',
                 order: '1000',
                 hideFromNav: true,
+                context: {},
                 children: [
                     {
                         pathSegment: ':id',
@@ -2221,6 +2244,7 @@ i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "20.3.9", ngImpor
 class NodesProcessingService {
     constructor() {
         this.nodeContextProcessingService = inject(LUIGI_CUSTOM_NODE_CONTEXT_PROCESSING_SERVICE_INJECTION_TOKEN, { optional: true });
+        this.luigiCoreService = inject(LuigiCoreService);
         this.luigiNodesService = inject(LuigiNodesService);
         this.localConfigurationService = inject(LocalConfigurationServiceImpl);
         this.nodeSortingService = inject(NodeSortingService);
@@ -2270,6 +2294,13 @@ class NodesProcessingService {
         }
     }
     processNodeDefineEntity(node, childrenByEntity, parentEntityPath, directChildren) {
+        if (!node.defineEntity) {
+            this.luigiCoreService.showAlert({
+                text: 'Node defineEntity is missing',
+                type: 'error',
+            });
+            throw new Error('Node defineEntity is missing');
+        }
         let newEntityPath = parentEntityPath;
         if (parentEntityPath?.length > 0) {
             newEntityPath = parentEntityPath + '.' + node.defineEntity.id;
@@ -2310,10 +2341,11 @@ class NodesProcessingService {
     entityChildrenProvider(entityNode, ctx, childrenByEntity, directChildren, entityPath) {
         return new Promise(async (resolve, reject) => {
             const entityTypeId = entityPath || entityNode?.defineEntity?.id;
-            const entityId = ctx[entityNode?.defineEntity?.contextKey];
+            const contextKey = entityNode?.defineEntity?.contextKey;
+            const entityId = contextKey ? ctx[contextKey] : undefined;
             const staticChildren = [
                 ...(directChildren || []),
-                ...(childrenByEntity[entityTypeId] || []),
+                ...(childrenByEntity[entityTypeId ?? ''] || []),
             ];
             await this.nodeContextProcessingService?.processNodeContext(entityId, entityNode, ctx);
             if (!entityTypeId || !entityNode.defineEntity?.dynamicFetchId) {
@@ -2334,7 +2366,7 @@ class NodesProcessingService {
             }
             catch (error) {
                 dynamicRetrievedChildren = staticChildren;
-                staticRetrievedChildren = null;
+                staticRetrievedChildren = undefined;
             }
             const childrenList = await this.createChildrenList(entityNode, ctx, childrenByEntity, entityPath, dynamicRetrievedChildren, staticRetrievedChildren);
             resolve(childrenList);
@@ -2419,7 +2451,7 @@ class NavigationConfigService {
         };
     }
     initFeatureToggles(configFeatureToggles, envConfig) {
-        if (envConfig.uiOptions.includes('enableFeatureToggleSetting')) {
+        if (envConfig.uiOptions?.includes('enableFeatureToggleSetting')) {
             const featureToggleSettings = featureToggleLocalStorage.read();
             this.luigiCoreService.setFeatureToggles({
                 ...configFeatureToggles,
@@ -2511,7 +2543,7 @@ class LifecycleHooksConfigService {
         this.luigiCoreService.ux().hideAppLoadingIndicator();
     }
     openErrorDialog() {
-        const appTitle = this.luigiCoreService.config.settings.header.title;
+        const appTitle = this.luigiCoreService.config?.settings?.header?.title;
         this.luigiCoreService.showAlert({
             text: $localize `There was an error loading the ${appTitle}`,
             type: 'error',