@openinc/parse-server-opendash 3.24.3 → 3.24.4

package/dist/features/openservice/functions/saveProject.d.ts

@@ -1,3 +1,3 @@
 import { Maintenance_Ticket, Maintenance_Ticket_Project } from "../../../types";
 import { FetchOptions } from "../types/FetchOptions";
-export declare function saveProject(ticket: Maintenance_Ticket, project: string, fetchOptions: FetchOptions): Promise<Maintenance_Ticket_Project | undefined>;
+export declare function saveProject(ticket: Maintenance_Ticket, project: string, fetchOptions: FetchOptions): Promise<Maintenance_Ticket_Project | null>;

package/dist/features/openservice/functions/saveProject.js

@@ -7,39 +7,79 @@ async function saveProject(ticket, project, fetchOptions) {
     const changed = current?.get("project")?.id !== project;
     if (!changed)
         return current;
-    // check if ticket already has a project assigned
-    // if so, remove the ticket from the old project
-    let prevProject;
+    // attempt to fetch previous project pointer (if any)
+    let prevProject = null;
     try {
-        prevProject = await ticket.get("project")?.fetch(fetchOptions);
+        prevProject = (await ticket.get("project")?.fetch(fetchOptions)) || null;
     }
     catch (error) {
-        // Project reference exists but object was deleted - clear the reference
         console.warn(`Referenced project not found for ticket ${ticket.id}, clearing reference:`, error);
         ticket.unset("project");
-        await ticket.save(null, fetchOptions);
+        try {
+            await ticket.save(null, fetchOptions);
+        }
+        catch (err) {
+            console.error("Failed to save ticket after clearing missing project reference:", err);
+        }
         prevProject = null;
     }
     if (prevProject && prevProject.id !== project) {
-        prevProject.relation("tickets").remove(ticket);
-        prevProject.save(null, fetchOptions);
+        try {
+            prevProject.relation("tickets").remove(ticket);
+            await prevProject.save(null, fetchOptions);
+        }
+        catch (err) {
+            console.warn(`Failed to remove ticket from previous project ${prevProject.id}:`, err);
+        }
     }
+    // Fetch new project by id (use .first to avoid throwing). If not found, abort cleanly.
     const projectObj = await new Parse.Query(types_1.Maintenance_Project)
         .equalTo("objectId", project)
         .first(fetchOptions);
+    if (!projectObj) {
+        console.warn(`Project ${project} not found. Aborting ticket->project association.`);
+        // optional: ensure ticket.project is unset to avoid dangling pointer
+        ticket.unset("project");
+        try {
+            await ticket.save(null, fetchOptions);
+        }
+        catch (err) {
+            console.error("Failed to save ticket after unsetting missing target project:", err);
+        }
+        return null;
+    }
+    // create the relation record and save guarded by try/catch
     const ticketProjectObject = new types_1.Maintenance_Ticket_Project({
         ticket,
         project: projectObj,
         tenant: ticket.get("tenant"),
         user: ticket.get("user"),
     });
-    await ticketProjectObject.save(null, fetchOptions);
-    ticket.set("project", projectObj);
-    await ticket.save(null, fetchOptions);
-    if (projectObj) {
+    try {
+        await ticketProjectObject.save(null, fetchOptions);
+    }
+    catch (err) {
+        console.error("Failed to save Maintenance_Ticket_Project:", err);
+        throw err;
+    }
+    try {
+        ticket.set("project", projectObj);
+        await ticket.save(null, fetchOptions);
+    }
+    catch (err) {
+        console.error("Failed to save ticket with new project pointer:", err);
+        // Consider rollback of ticketProjectObject if needed
+        throw err;
+    }
+    // update project's tickets relation with master key to avoid permission issues
+    try {
         projectObj.relation("tickets").add(ticket);
         await projectObj.save(null, { useMasterKey: true });
     }
+    catch (err) {
+        console.warn(`Failed to add ticket to project ${projectObj.id} relation:`, err);
+    }
+    return ticketProjectObject;
 }
 async function getCurrent(ticket) {
     return await new Parse.Query(types_1.Maintenance_Ticket_Project)

package/dist/functions/openinc-openservice-save-ticket-data.js

@@ -101,7 +101,7 @@ async function saveTicketData(data, user, overrideFetchOptions) {
         const [lastPriorityError, lastPriority] = await (0, catchError_1.catchError)(new Parse.Query(types_1.Maintenance_Priority)
             .equalTo("ticket", ticket)
             .descending("createdAt")
-            .first(fetchOptions));
+            .first(fetchOptions), [Error]);
         if (lastPriorityError) {
             console.log("Error fetching last priority", lastPriorityError);
         }
@@ -118,7 +118,7 @@ async function saveTicketData(data, user, overrideFetchOptions) {
         const [lastDowntimeError, lastDowntime] = await (0, catchError_1.catchError)(new Parse.Query(types_1.Maintenance_Downtime)
             .equalTo("ticket", ticket)
             .descending("createdAt")
-            .first(fetchOptions));
+            .first(fetchOptions), [Error]);
         if (lastDowntimeError) {
             console.log("Error fetching last downtime", lastDowntimeError);
         }
@@ -135,7 +135,7 @@ async function saveTicketData(data, user, overrideFetchOptions) {
         const [lastFrequencyError, lastFrequency] = await (0, catchError_1.catchError)(new Parse.Query(types_1.Maintenance_Frequency)
             .equalTo("ticket", ticket)
             .descending("createdAt")
-            .first(fetchOptions));
+            .first(fetchOptions), [Error]);
         if (lastFrequencyError) {
             console.log("Error fetching last frequency", lastFrequencyError);
         }
@@ -152,7 +152,7 @@ async function saveTicketData(data, user, overrideFetchOptions) {
         const [lastRestrictionError, lastRestriction] = await (0, catchError_1.catchError)(new Parse.Query(types_1.Maintenance_Restriction)
             .equalTo("ticket", ticket)
             .descending("createdAt")
-            .first(fetchOptions));
+            .first(fetchOptions), [Error]);
         if (lastRestrictionError) {
             console.log("Error fetching last restriction", lastRestrictionError);
         }
@@ -164,7 +164,7 @@ async function saveTicketData(data, user, overrideFetchOptions) {
         const savedissuecategory = await (0, openservice_1.saveIssueCategory)(ticket, data.issuecategory, fetchOptions);
         const [fetchedSavedIssuecategoryError, fetchedSavedIssuecategory] = await (0, catchError_1.catchError)(new Parse.Query(types_1.Maintenance_Ticket_Issuecategory)
             .include("issuecategory")
-            .get(savedissuecategory.id, fetchOptions));
+            .get(savedissuecategory.id, fetchOptions), [Error]);
         if (fetchedSavedIssuecategoryError) {
             console.log("Error fetching saved issue category", fetchedSavedIssuecategoryError);
         }
@@ -176,7 +176,7 @@ async function saveTicketData(data, user, overrideFetchOptions) {
         const savedstate = await (0, openservice_1.saveState)(ticket, data.state, fetchOptions);
         const [fetchedSavedStateError, fetchedSavedState] = await (0, catchError_1.catchError)(new Parse.Query(types_1.Maintenance_Ticket_Kanban_State)
             .include("state")
-            .get(savedstate.id, fetchOptions));
+            .get(savedstate.id, fetchOptions), [Error]);
         if (fetchedSavedStateError) {
             console.log("Error fetching saved state", fetchedSavedStateError);
         }
@@ -185,41 +185,53 @@ async function saveTicketData(data, user, overrideFetchOptions) {
         }
     }
     if (data.media && data.media.length > 0) {
-        const [saveError] = await (0, catchError_1.catchError)((0, openservice_1.saveMedia)(ticket, data.media, fetchOptions));
-        if (saveError) {
-            console.error(`Error saving media for ticket ${ticket.id}:`, saveError);
+        try {
+            await (0, openservice_1.saveMedia)(ticket, data.media, fetchOptions);
+        }
+        catch (error) {
+            console.error(`Error saving media for ticket ${ticket.id}:`, error);
         }
     }
     if (data.material) {
-        const [saveError] = await (0, catchError_1.catchError)((0, openservice_1.saveMaterial)(ticket, data.material, fetchOptions));
-        if (saveError) {
-            console.error(`Error saving material for ticket ${ticket.id}:`, saveError);
+        try {
+            await (0, openservice_1.saveMaterial)(ticket, data.material, fetchOptions);
+        }
+        catch (error) {
+            console.error(`Error saving material for ticket ${ticket.id}:`, error);
         }
     }
     if (data.project) {
-        const [saveError] = await (0, catchError_1.catchError)((0, openservice_1.saveProject)(ticket, data.project, fetchOptions));
-        if (saveError) {
-            console.error(`Error saving project ${data.project} for ticket ${ticket.id}:`, saveError);
+        try {
+            await (0, openservice_1.saveProject)(ticket, data.project, fetchOptions);
+        }
+        catch (error) {
+            console.error(`Error saving project ${data.project} for ticket ${ticket.id}:`, error);
         }
     }
     // save defaults
     if (!data.issuecategory && !data.existingTicketId) {
-        const [saveError] = await (0, catchError_1.catchError)((0, openservice_1.saveDefaultIssueCategory)(ticket, fetchOptions));
-        if (saveError) {
-            console.error(`Error saving default issue category for ticket ${ticket.id}:`, saveError);
+        try {
+            await (0, openservice_1.saveDefaultIssueCategory)(ticket, fetchOptions);
+        }
+        catch (error) {
+            console.error(`Error saving default issue category for ticket ${ticket.id}:`, error);
         }
     }
     if (!data.state && !data.existingTicketId) {
-        const [saveError] = await (0, catchError_1.catchError)((0, openservice_1.saveDefaultState)(ticket, fetchOptions));
-        if (saveError) {
-            console.error(`Error saving default state for ticket ${ticket.id}:`, saveError);
+        try {
+            await (0, openservice_1.saveDefaultState)(ticket, fetchOptions);
+        }
+        catch (error) {
+            console.error(`Error saving default state for ticket ${ticket.id}:`, error);
         }
     }
     // save source last so the machinelog does not have the initialization messages of the ticket data
     if (data.source) {
-        const [saveError] = await (0, catchError_1.catchError)((0, openservice_1.saveSource)(ticket, data.source, fetchOptions));
-        if (saveError) {
-            console.error(`Error saving source ${data.source} for ticket ${ticket.id}:`, saveError);
+        try {
+            await (0, openservice_1.saveSource)(ticket, data.source, fetchOptions);
+        }
+        catch (error) {
+            console.error(`Error saving source ${data.source} for ticket ${ticket.id}:`, error);
         }
     }
     //Get source from ticket and save to openware
@@ -227,7 +239,7 @@ async function saveTicketData(data, user, overrideFetchOptions) {
         .equalTo("ticket", new types_1.Maintenance_Ticket({ objectId: ticket.id }))
         .descending("createdAt")
         .include("source")
-        .first({ useMasterKey: true }));
+        .first({ useMasterKey: true }), [Error]);
     if (fetchedTicketSourceError) {
         console.log("Error fetching saved source", fetchedTicketSourceError);
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openinc/parse-server-opendash",
-  "version": "3.24.3",
+  "version": "3.24.4",
   "description": "Parse Server Cloud Code for open.INC Stack.",
   "packageManager": "pnpm@10.19.0",
   "keywords": [