@openhands/extensions 0.30.0 → 0.31.0

package/tests/test_software_factory_script.py

@@ -0,0 +1,231 @@
+"""The software-factory helper builds the same create body as Agent Canvas."""
+
+import importlib.util
+import io
+import json
+import tarfile
+from pathlib import Path
+
+import pytest
+from test_automation_setup import _render_payload
+
+ROOT = Path(__file__).resolve().parents[1]
+BUNDLE_STATIONS = [
+    "github-issue-to-pr",
+    "github-pr-reviewer",
+    "github-agents-md-maintainer",
+    "github-issue-triage",
+    "github-delivery-watchdog",
+    "github-stale-ci-pr-closer",
+]
+
+
+@pytest.fixture(scope="module")
+def factory():
+    path = ROOT / "skills" / "software-factory" / "scripts" / "factory.py"
+    spec = importlib.util.spec_from_file_location("factory", path)
+    assert spec and spec.loader
+    module = importlib.util.module_from_spec(spec)
+    spec.loader.exec_module(module)
+    return module
+
+
+def _entry(station: str) -> dict:
+    return json.loads((ROOT / "automations" / "catalog" / station / "manifest.json").read_text())
+
+
+@pytest.mark.parametrize("station", BUNDLE_STATIONS)
+@pytest.mark.parametrize("repos", [["acme/api"], ["acme/api", "acme/web"]])
+def test_create_body_matches_reference_renderer(factory, station, repos):
+    entry = _entry(station)
+    values = factory._form_values(entry, repos, {})
+    expected = _render_payload(entry, values, "", selected_trigger="cron")
+    assert factory._create_body(entry, values, repos) == expected
+
+
+@pytest.mark.parametrize("station", BUNDLE_STATIONS)
+def test_every_token_secret_is_the_factory_token(factory, station):
+    values = factory._form_values(_entry(station), ["acme/api"], {})
+    if "githubTokenSecret" in values:
+        assert values["githubTokenSecret"] == "GITHUB_PERSONAL_ACCESS_TOKEN"
+
+
+def test_overrides_keep_json_types(factory):
+    entry = _entry("github-pr-reviewer")
+    values = factory._form_values(
+        entry, ["acme/api"], {"maxNewPerRun": factory._parse_value("4"), "reviewTone": "thorough"}
+    )
+    config = factory._create_body(entry, values, ["acme/api"])["template"]["config"]
+    assert config["max_new_per_run"] == 4
+    assert config["review_tone"] == "thorough"
+    assert config["repos"] == ["acme/api"]
+
+
+def test_unknown_field_is_rejected(factory):
+    with pytest.raises(factory.FactoryError):
+        factory._form_values(_entry("github-issue-to-pr"), ["acme/api"], {"nope": 1})
+
+
+@pytest.mark.parametrize("station", BUNDLE_STATIONS)
+def test_tarball_holds_bundle_files_and_config(factory, station):
+    bundle = _entry(station)["setup"]["bundle"]
+    data = factory._tarball(ROOT, bundle["files"], {"repos": ["acme/api"]})
+    with tarfile.open(fileobj=io.BytesIO(data), mode="r:gz") as tar:
+        names = set(tar.getnames())
+        config = json.load(tar.extractfile("config.json"))
+    assert names == set(bundle["files"]) | {"config.json"}
+    assert config == {"repos": ["acme/api"]}
+
+
+def test_prs_keeps_only_branches_with_the_prefix(factory, monkeypatch):
+    pulls = [
+        {"number": 2, "title": "docs: add AGENTS.md", "html_url": "u2", "draft": True,
+         "created_at": "2026-10-16T21:32:40Z", "head": {"ref": "openhands/agents-md-2026-W42"}},
+        {"number": 3, "title": "feature", "html_url": "u3", "draft": False,
+         "head": {"ref": "feature/x"}},
+    ]
+    monkeypatch.setattr(factory, "_github", lambda path: pulls)
+    args = type("Args", (), {"repos": "acme/api", "branch_prefix": "openhands/agents-md"})
+    assert factory.prs(args) == {
+        "acme/api": [
+            {"number": 2, "title": "docs: add AGENTS.md", "url": "u2", "draft": True,
+             "created_at": "2026-10-16T21:32:40Z"}
+        ]
+    }
+
+
+def test_automation_url_points_at_the_canvas_page(factory, monkeypatch):
+    monkeypatch.setenv("OPENHANDS_HOST", "http://localhost:8000/")
+    assert factory._automation_url("abc") == "http://localhost:8000/automations/abc"
+
+
+def test_extensions_prefers_the_installed_checkout(factory, monkeypatch):
+    """Bundles must come from the release the user has, not a moving main."""
+    monkeypatch.delenv("FACTORY_EXTENSIONS", raising=False)
+    monkeypatch.setattr(factory, "subprocess", None)  # a clone here would fail
+    assert factory._extensions() == ROOT
+
+
+def test_extensions_honours_the_override(factory, monkeypatch, tmp_path):
+    monkeypatch.setenv("FACTORY_EXTENSIONS", str(tmp_path))
+    assert factory._extensions() == tmp_path
+
+
+def test_release_ref_is_none_without_installed_metadata(factory, monkeypatch):
+    import importlib.metadata as md
+
+    def missing(name):
+        raise md.PackageNotFoundError(name)
+
+    monkeypatch.setattr(md, "version", missing)
+    assert factory._release_ref() is None
+
+
+def test_automation_backend_host_gets_a_clear_error(factory, monkeypatch):
+    def not_found(*args, **kwargs):
+        raise factory.FactoryError("GET http://localhost:18001/api/agent-profiles -> 404: {}")
+
+    monkeypatch.setenv("OPENHANDS_HOST", "http://localhost:18001")
+    monkeypatch.setenv("OPENHANDS_AUTOMATION_API_KEY", "key")
+    monkeypatch.setattr(factory, "_request", not_found)
+    with pytest.raises(factory.FactoryError, match="Ingress URL"):
+        factory._profile(None)
+
+
+def _create_args(ids: str, repos: str = "acme/api", sets=None):
+    return type("Args", (), {"ids": ids, "repos": repos, "set": sets, "profile": None})
+
+
+def _stub_create(factory, monkeypatch, responses):
+    """Stub upload/manifest/profile and record the POST bodies and PATCHes."""
+    monkeypatch.setenv("OPENHANDS_HOST", "http://localhost:8000")
+    monkeypatch.setattr(factory, "_upload", lambda name, data: f"oh-internal://uploads/{name}")
+    monkeypatch.setattr(factory, "_extensions", lambda: ROOT)
+    monkeypatch.setattr(factory, "_profile", lambda name: {"id": "p1", "name": "default"})
+    posts = []
+    patches = []
+
+    def api(method, path, body=None, **kwargs):
+        if method == "POST" and path == "":
+            posts.append(body)
+            return responses[len(posts) - 1]
+        if method == "PATCH":
+            patches.append((path, body))
+            return {"id": path.strip("/")}
+        raise AssertionError(f"unexpected {method} {path}")
+
+    monkeypatch.setattr(factory, "_api", api)
+    return posts, patches
+
+
+def test_create_reports_existing_station_instead_of_claiming_it(factory, monkeypatch):
+    """A 200 from the service means the template already exists, not a create."""
+    responses = [
+        (201, {"id": "a1", "enabled": False, "state": "INACTIVE"}),
+        (200, {"id": "a2", "enabled": True, "state": "ACTIVE"}),
+    ]
+    posts, patches = _stub_create(factory, monkeypatch, responses)
+    result = factory.create(_create_args("github-pr-reviewer,github-issue-to-pr"))
+    assert [c["id"] for c in result["created"]] == ["a1"]
+    assert [e["id"] for e in result["existing"]] == ["a2"]
+    # The pre-existing automation is left untouched: no disable PATCH for it.
+    assert patches == []
+
+
+def test_create_disables_a_station_the_service_returned_enabled(factory, monkeypatch):
+    posts, patches = _stub_create(factory, monkeypatch, [(201, {"id": "a1", "enabled": True})])
+    factory.create(_create_args("github-pr-reviewer"))
+    assert patches == [("/a1", {"enabled": False})]
+
+
+def test_tune_patches_in_place_without_stamping_template(factory, monkeypatch):
+    """Tune must not go through create's template-id dedup path."""
+    monkeypatch.setenv("OPENHANDS_HOST", "http://localhost:8000")
+    monkeypatch.setattr(factory, "_upload", lambda name, data: f"oh-internal://uploads/{name}")
+    monkeypatch.setattr(factory, "_extensions", lambda: ROOT)
+    monkeypatch.setattr(factory, "_profile", lambda name: {"id": "p1", "name": "default"})
+    monkeypatch.setattr(factory, "_find_existing", lambda station: {"id": "a1"})
+    calls = []
+
+    def api(method, path, body=None, **kwargs):
+        calls.append((method, path, body))
+        return {"id": "a1"}
+
+    monkeypatch.setattr(factory, "_api", api)
+    result = factory.tune(
+        _create_args("github-pr-reviewer", sets=["reviewTone=thorough"])
+    )
+    assert [t["id"] for t in result["tuned"]] == ["a1"]
+    method, path, body = calls[-1]
+    assert (method, path) == ("PATCH", "/a1")
+    assert "template" not in body
+    assert body["tarball_path"].startswith("oh-internal://uploads/")
+    assert body["agent_profile_id"] == "p1"
+
+
+def test_tune_rejects_a_station_that_is_not_set_up(factory, monkeypatch):
+    monkeypatch.setattr(factory, "_extensions", lambda: ROOT)
+    monkeypatch.setattr(factory, "_find_existing", lambda station: None)
+    with pytest.raises(factory.FactoryError, match="not set up yet"):
+        factory.tune(_create_args("github-pr-reviewer"))
+
+
+def test_find_existing_matches_on_template_id(factory, monkeypatch):
+    page = {
+        "automations": [
+            {"id": "a1", "preset_metadata": {"template": {"id": "other"}}},
+            {"id": "a2", "preset_metadata": {"template": {"id": "github-pr-reviewer"}}},
+            {"id": "a3", "preset_metadata": None},
+        ]
+    }
+    monkeypatch.setattr(factory, "_api", lambda method, path, **kwargs: page)
+    assert factory._find_existing("github-pr-reviewer")["id"] == "a2"
+    assert factory._find_existing("github-issue-to-pr") is None
+
+
+def test_event_only_station_fields_do_not_raise(factory):
+    """qa-changes declares only an event trigger; --set must report, not KeyError."""
+    entry = _entry("qa-changes")
+    assert factory._fields(entry) == entry["setup"]["form"]["args"]
+    with pytest.raises(factory.FactoryError, match="no listed station has field"):
+        factory._overrides({"qa-changes": entry}, ["reviewTone=thorough"], ["qa-changes"])