@openhands/extensions 0.24.0 → 0.25.0

package/tests/fixtures/automations/github-pr-reviewer.json

@@ -20,7 +20,8 @@
         ],
         "githubTokenSecret": "GITHUB_PERSONAL_ACCESS_TOKEN",
         "maintainers": "",
-        "triggerReviewer": "all-hands-bot"
+        "triggerReviewer": "all-hands-bot",
+        "maxNewPerRun": 2
       },
       "upload": {
         "request": {
@@ -67,7 +68,7 @@
               "timeout": 300,
               "template": {
                 "id": "github-pr-reviewer",
-                "version": "1.5.0",
+                "version": "1.8.0",
                 "config": {
                   "repos": [
                     "OpenHands/agent-server-gui"
@@ -76,7 +77,8 @@
                   "review_tone": "thorough",
                   "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN",
                   "maintainers": "",
-                  "trigger_reviewer": "all-hands-bot"
+                  "trigger_reviewer": "all-hands-bot",
+                  "max_new_per_run": 2
                 }
               }
             }
@@ -106,7 +108,7 @@
             "timeout": 300,
             "template": {
               "id": "github-pr-reviewer",
-              "version": "1.5.0",
+              "version": "1.8.0",
               "config": {
                 "repos": [
                   "OpenHands/agent-server-gui"
@@ -115,7 +117,8 @@
                 "review_tone": "thorough",
                 "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN",
                 "maintainers": "",
-                "trigger_reviewer": "all-hands-bot"
+                "trigger_reviewer": "all-hands-bot",
+                "max_new_per_run": 2
               }
             }
           }
@@ -162,7 +165,8 @@
         ],
         "githubTokenSecret": "GITHUB_PERSONAL_ACCESS_TOKEN",
         "maintainers": "",
-        "triggerReviewer": "all-hands-bot"
+        "triggerReviewer": "all-hands-bot",
+        "maxNewPerRun": 2
       },
       "upload": {
         "request": {
@@ -209,7 +213,7 @@
               "timeout": 300,
               "template": {
                 "id": "github-pr-reviewer",
-                "version": "1.5.0",
+                "version": "1.8.0",
                 "config": {
                   "repos": [
                     "OpenHands/agent-server-gui",
@@ -219,7 +223,8 @@
                   "review_tone": "thorough",
                   "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN",
                   "maintainers": "",
-                  "trigger_reviewer": "all-hands-bot"
+                  "trigger_reviewer": "all-hands-bot",
+                  "max_new_per_run": 2
                 }
               }
             }
@@ -249,7 +254,7 @@
             "timeout": 300,
             "template": {
               "id": "github-pr-reviewer",
-              "version": "1.5.0",
+              "version": "1.8.0",
               "config": {
                 "repos": [
                   "OpenHands/agent-server-gui",
@@ -259,7 +264,8 @@
                 "review_tone": "thorough",
                 "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN",
                 "maintainers": "",
-                "trigger_reviewer": "all-hands-bot"
+                "trigger_reviewer": "all-hands-bot",
+                "max_new_per_run": 2
               }
             }
           }
@@ -290,7 +296,7 @@
             "preset_metadata": {
               "template": {
                 "id": "github-pr-reviewer",
-                "version": "1.5.0",
+                "version": "1.8.0",
                 "config": {
                   "repos": [
                     "OpenHands/agent-server-gui",
@@ -300,7 +306,8 @@
                   "review_tone": "thorough",
                   "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN",
                   "maintainers": "",
-                  "trigger_reviewer": "all-hands-bot"
+                  "trigger_reviewer": "all-hands-bot",
+                  "max_new_per_run": 2
                 }
               }
             }
@@ -322,7 +329,8 @@
         ],
         "githubTokenSecret": "GITHUB_PERSONAL_ACCESS_TOKEN",
         "maintainers": "",
-        "triggerReviewer": "all-hands-bot"
+        "triggerReviewer": "all-hands-bot",
+        "maxNewPerRun": 2
       },
       "preflight": {
         "request": {
@@ -343,7 +351,7 @@
               "timeout": 300,
               "template": {
                 "id": "github-pr-reviewer",
-                "version": "1.5.0",
+                "version": "1.8.0",
                 "config": {
                   "repos": [
                     "OpenHands/agent-server-gui"
@@ -352,7 +360,8 @@
                   "review_tone": "concise",
                   "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN",
                   "maintainers": "",
-                  "trigger_reviewer": "all-hands-bot"
+                  "trigger_reviewer": "all-hands-bot",
+                  "max_new_per_run": 2
                 }
               }
             }
@@ -390,7 +399,8 @@
         ],
         "githubTokenSecret": "GITHUB_PERSONAL_ACCESS_TOKEN",
         "maintainers": "",
-        "triggerReviewer": "all-hands-bot"
+        "triggerReviewer": "all-hands-bot",
+        "maxNewPerRun": 2
       },
       "upload": {
         "request": {
@@ -434,7 +444,7 @@
             "timeout": 300,
             "template": {
               "id": "github-pr-reviewer",
-              "version": "1.5.0",
+              "version": "1.8.0",
               "config": {
                 "repos": [
                   "OpenHands/agent-server-gui"
@@ -443,7 +453,8 @@
                 "review_tone": "concise",
                 "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN",
                 "maintainers": "",
-                "trigger_reviewer": "all-hands-bot"
+                "trigger_reviewer": "all-hands-bot",
+                "max_new_per_run": 2
               }
             }
           }
@@ -484,7 +495,8 @@
         ],
         "githubTokenSecret": "GITHUB_PERSONAL_ACCESS_TOKEN",
         "maintainers": "",
-        "triggerReviewer": "all-hands-bot"
+        "triggerReviewer": "all-hands-bot",
+        "maxNewPerRun": 2
       },
       "upload": {
         "request": {
@@ -528,7 +540,7 @@
             "timeout": 300,
             "template": {
               "id": "github-pr-reviewer",
-              "version": "1.5.0",
+              "version": "1.8.0",
               "config": {
                 "repos": [
                   "OpenHands/agent-server-gui"
@@ -537,7 +549,8 @@
                 "review_tone": "concise",
                 "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN",
                 "maintainers": "",
-                "trigger_reviewer": "all-hands-bot"
+                "trigger_reviewer": "all-hands-bot",
+                "max_new_per_run": 2
               }
             },
             "repos": [
@@ -580,7 +593,8 @@
           "OpenHands/automation"
         ],
         "githubTokenSecret": "GITHUB_TOKEN_REVIEW",
-        "maintainers": "neubig,malhotra5"
+        "maintainers": "neubig,malhotra5",
+        "maxNewPerRun": 2
       },
       "preflight": {
         "request": {
@@ -602,7 +616,7 @@
               "timeout": 300,
               "template": {
                 "id": "github-pr-reviewer",
-                "version": "1.5.0",
+                "version": "1.8.0",
                 "config": {
                   "repos": [
                     "OpenHands/automation"
@@ -611,7 +625,8 @@
                   "trigger_reviewer": "all-hands-bot",
                   "review_tone": "concise",
                   "maintainers": "neubig,malhotra5",
-                  "github_token_secret": "GITHUB_TOKEN_REVIEW"
+                  "github_token_secret": "GITHUB_TOKEN_REVIEW",
+                  "max_new_per_run": 2
                 }
               }
             }

package/tests/test_github_automation_foundation.py

@@ -71,3 +71,161 @@ def test_dependency_permission_errors_fail_closed():
     repository.gh = denied
     with pytest.raises(HTTPError):
         repository.dependencies_complete({"body": "Depends on: #12"})
+
+
+def test_check_runs_reads_every_page_of_the_object_response():
+    """The endpoint answers with an object, not a list, so paging is manual."""
+    repository = object.__new__(github_client.GitHubRepository)
+    pages = {
+        1: {"total_count": 3, "check_runs": [{"name": "a"}, {"name": "b"}]},
+        2: {"total_count": 3, "check_runs": [{"name": "c"}]},
+    }
+    requests = []
+
+    def gh(method, path, body=None):
+        assert method == "GET"
+        page = int(path.rsplit("page=", 1)[1])
+        requests.append(page)
+        return pages[page]
+
+    repository.gh = gh
+
+    assert [run["name"] for run in repository.check_runs("abc")] == ["a", "b", "c"]
+    assert requests == [1, 2]
+
+
+def test_check_runs_stops_on_an_empty_first_page():
+    repository = object.__new__(github_client.GitHubRepository)
+    repository.gh = lambda *args, **kwargs: {"total_count": 0, "check_runs": []}
+
+    assert repository.check_runs("abc") == []
+
+
+def test_workflow_runs_reads_every_page_of_the_object_response():
+    """The runs endpoint answers with an object too, so paging is manual."""
+    repository = object.__new__(github_client.GitHubRepository)
+    pages = {
+        1: {"total_count": 3, "workflow_runs": [{"name": "a"}, {"name": "b"}]},
+        2: {"total_count": 3, "workflow_runs": [{"name": "c"}]},
+    }
+    requests = []
+
+    def gh(method, path, body=None):
+        assert method == "GET"
+        assert "head_sha=abc" in path
+        page = int(path.rsplit("page=", 1)[1])
+        requests.append(page)
+        return pages[page]
+
+    repository.gh = gh
+
+    assert [run["name"] for run in repository.workflow_runs("abc")] == [
+        "a",
+        "b",
+        "c",
+    ]
+    assert requests == [1, 2]
+
+
+def test_required_check_contexts_keeps_only_required_nodes():
+    """`isRequired` is the merge-policy signal; optional contexts are dropped."""
+    repository = object.__new__(github_client.GitHubRepository)
+    repository.repository = "owner/repo"
+    calls = []
+
+    def api(method, path, params=None, body=None):
+        calls.append((method, path, body))
+        return {
+            "data": {
+                "repository": {
+                    "pullRequest": {
+                        "commits": {
+                            "nodes": [
+                                {
+                                    "commit": {
+                                        "statusCheckRollup": {
+                                            "contexts": {
+                                                "pageInfo": {"hasNextPage": False},
+                                                "nodes": [
+                                                    {
+                                                        "__typename": "CheckRun",
+                                                        "name": "test-and-build (ubuntu)",
+                                                        "isRequired": True,
+                                                    },
+                                                    {
+                                                        "__typename": "CheckRun",
+                                                        "name": "release ready",
+                                                        "isRequired": False,
+                                                    },
+                                                    {
+                                                        "__typename": "StatusContext",
+                                                        "context": "ci/required",
+                                                        "isRequired": True,
+                                                    },
+                                                ],
+                                            }
+                                        }
+                                    }
+                                }
+                            ]
+                        }
+                    }
+                }
+            }
+        }
+
+    repository.api = api
+
+    contexts = repository.required_check_contexts(17200)
+
+    assert contexts == [
+        {"name": "test-and-build (ubuntu)", "kind": "CheckRun"},
+        {"name": "ci/required", "kind": "StatusContext"},
+    ]
+    method, path, body = calls[0]
+    assert (method, path) == ("POST", "/graphql")
+    assert body["variables"] == {"owner": "owner", "name": "repo", "number": 17200}
+    assert "isRequired(pullRequestNumber:$number)" in body["query"]
+
+
+def test_required_check_contexts_rejects_an_over_long_rollup():
+    """A truncated rollup must fail loudly instead of reporting a partial set."""
+    repository = object.__new__(github_client.GitHubRepository)
+    repository.repository = "owner/repo"
+    repository.api = lambda *args, **kwargs: {
+        "data": {
+            "repository": {
+                "pullRequest": {
+                    "commits": {
+                        "nodes": [
+                            {
+                                "commit": {
+                                    "statusCheckRollup": {
+                                        "contexts": {
+                                            "pageInfo": {"hasNextPage": True},
+                                            "nodes": [],
+                                        }
+                                    }
+                                }
+                            }
+                        ]
+                    }
+                }
+            }
+        }
+    }
+
+    with pytest.raises(RuntimeError, match="one page"):
+        repository.required_check_contexts(2)
+
+
+def test_required_check_contexts_raises_on_graphql_errors():
+    """A GraphQL error must surface, so the caller can fail closed."""
+    repository = object.__new__(github_client.GitHubRepository)
+    repository.repository = "owner/repo"
+    repository.api = lambda *args, **kwargs: {
+        "errors": [{"message": "A pull request ID or pull request number is required."}]
+    }
+
+    with pytest.raises(RuntimeError, match="required-check query failed"):
+        repository.required_check_contexts(2)

package/tests/test_github_repo_monitor.py

@@ -0,0 +1,107 @@
+import io
+import json
+import urllib.error
+from pathlib import Path
+
+
+SCRIPT_PATH = (
+    Path(__file__).parent.parent
+    / "skills"
+    / "github-repo-monitor"
+    / "scripts"
+    / "main.py"
+)
+
+
+def load_repo_monitor_helpers():
+    source = SCRIPT_PATH.read_text(encoding="utf-8")
+    namespace: dict = {"__name__": "repo_monitor_main"}
+    exec(compile(source, str(SCRIPT_PATH), "exec"), namespace)
+    return namespace
+
+
+class _FakeResponse:
+    def __init__(self, payload: dict):
+        self._payload = payload
+
+    def __enter__(self):
+        return self
+
+    def __exit__(self, *exc_info):
+        return False
+
+    def read(self):
+        return json.dumps(self._payload).encode()
+
+
+def _http_error(url: str, code: int) -> urllib.error.HTTPError:
+    return urllib.error.HTTPError(url, code, "error", {}, io.BytesIO(b"{}"))
+
+
+def _patch_urlopen(monkeypatch, helpers, handler):
+    monkeypatch.setattr(helpers["urllib"].request, "urlopen", handler)
+
+
+ACTIVE_LLM = {"model": "openai/gpt-5.5", "api_key": "sk-active"}
+PROFILE_LLM = {"model": "openai/gpt-5.6-sol", "api_key": "sk-profile"}
+
+
+def test_automation_model_profile_resolves(monkeypatch):
+    helpers = load_repo_monitor_helpers()
+    monkeypatch.setenv("AUTOMATION_MODEL", "gpt-5.6-sol")
+    monkeypatch.setitem(
+        helpers, "_fetch_settings", lambda url, key: {"agent_settings": {"llm": ACTIVE_LLM}}
+    )
+    seen: dict = {}
+
+    def fake_urlopen(req, *args, **kwargs):
+        seen["url"] = req.full_url
+        seen["headers"] = {k.lower(): v for k, v in req.header_items()}
+        return _FakeResponse({"config": dict(PROFILE_LLM)})
+
+    _patch_urlopen(monkeypatch, helpers, fake_urlopen)
+
+    agent = helpers["_get_agent_dict"]("http://agent:8000", "key")
+
+    assert seen["url"] == "http://agent:8000/api/profiles/gpt-5.6-sol"
+    assert seen["headers"]["x-expose-secrets"] == "plaintext"
+    assert agent["llm"]["model"] == "openai/gpt-5.6-sol"
+    assert agent["llm"]["api_key"] == "sk-profile"
+    assert agent["llm"]["usage_id"] == "profile:gpt-5.6-sol"
+
+
+def test_missing_profile_falls_back_to_active(monkeypatch):
+    helpers = load_repo_monitor_helpers()
+    monkeypatch.setenv("AUTOMATION_MODEL", "renamed-profile")
+    monkeypatch.setitem(
+        helpers, "_fetch_settings", lambda url, key: {"agent_settings": {"llm": ACTIVE_LLM}}
+    )
+
+    def fake_urlopen(req, *args, **kwargs):
+        raise _http_error(req.full_url, 404)
+
+    _patch_urlopen(monkeypatch, helpers, fake_urlopen)
+
+    agent = helpers["_get_agent_dict"]("http://agent:8000", "key")
+
+    assert agent["llm"] == ACTIVE_LLM
+
+
+def test_no_automation_model_uses_active_profile(monkeypatch):
+    helpers = load_repo_monitor_helpers()
+    monkeypatch.delenv("AUTOMATION_MODEL", raising=False)
+    monkeypatch.setitem(
+        helpers, "_fetch_settings", lambda url, key: {"agent_settings": {"llm": ACTIVE_LLM}}
+    )
+    calls: list = []
+
+    def fake_urlopen(req, *args, **kwargs):
+        calls.append(req.full_url)
+        raise AssertionError("no profile request expected")
+
+    _patch_urlopen(monkeypatch, helpers, fake_urlopen)
+
+    agent = helpers["_get_agent_dict"]("http://agent:8000", "key")
+
+    assert agent["llm"] == ACTIVE_LLM
+    assert calls == []