@openhands/extensions 0.22.1 → 0.23.0

package/tests/fixtures/automations/github-pr-reviewer.json

@@ -18,7 +18,9 @@
         "repositories": [
           "OpenHands/agent-server-gui"
         ],
-        "githubTokenSecret": "GITHUB_PERSONAL_ACCESS_TOKEN"
+        "githubTokenSecret": "GITHUB_PERSONAL_ACCESS_TOKEN",
+        "maintainers": "",
+        "triggerReviewer": "all-hands-bot"
       },
       "upload": {
         "request": {
@@ -32,6 +34,7 @@
             "config.json",
             "main.py",
             "github_client.py",
+            "maintainer_handoff.py",
             "worker.py"
           ]
         },
@@ -64,14 +67,16 @@
               "timeout": 300,
               "template": {
                 "id": "github-pr-reviewer",
-                "version": "1.1.1",
+                "version": "1.3.0",
                 "config": {
                   "repos": [
                     "OpenHands/agent-server-gui"
                   ],
                   "trigger_label": "openhands-review",
                   "review_tone": "thorough",
-                  "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN"
+                  "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN",
+                  "maintainers": "",
+                  "trigger_reviewer": "all-hands-bot"
                 }
               }
             }
@@ -101,14 +106,16 @@
             "timeout": 300,
             "template": {
               "id": "github-pr-reviewer",
-              "version": "1.1.1",
+              "version": "1.3.0",
               "config": {
                 "repos": [
                   "OpenHands/agent-server-gui"
                 ],
                 "trigger_label": "openhands-review",
                 "review_tone": "thorough",
-                "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN"
+                "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN",
+                "maintainers": "",
+                "trigger_reviewer": "all-hands-bot"
               }
             }
           }
@@ -138,7 +145,8 @@
             "updated_at": "2026-07-27T12:00:00Z"
           }
         }
-      }
+      },
+      "selectedTrigger": "cron"
     },
     {
       "id": "several-repositories",
@@ -152,7 +160,9 @@
           "OpenHands/agent-server-gui",
           "OpenHands/automation"
         ],
-        "githubTokenSecret": "GITHUB_PERSONAL_ACCESS_TOKEN"
+        "githubTokenSecret": "GITHUB_PERSONAL_ACCESS_TOKEN",
+        "maintainers": "",
+        "triggerReviewer": "all-hands-bot"
       },
       "upload": {
         "request": {
@@ -166,6 +176,7 @@
             "config.json",
             "main.py",
             "github_client.py",
+            "maintainer_handoff.py",
             "worker.py"
           ]
         },
@@ -198,7 +209,7 @@
               "timeout": 300,
               "template": {
                 "id": "github-pr-reviewer",
-                "version": "1.1.1",
+                "version": "1.3.0",
                 "config": {
                   "repos": [
                     "OpenHands/agent-server-gui",
@@ -206,7 +217,9 @@
                   ],
                   "trigger_label": "openhands-review",
                   "review_tone": "thorough",
-                  "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN"
+                  "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN",
+                  "maintainers": "",
+                  "trigger_reviewer": "all-hands-bot"
                 }
               }
             }
@@ -236,7 +249,7 @@
             "timeout": 300,
             "template": {
               "id": "github-pr-reviewer",
-              "version": "1.1.1",
+              "version": "1.3.0",
               "config": {
                 "repos": [
                   "OpenHands/agent-server-gui",
@@ -244,7 +257,9 @@
                 ],
                 "trigger_label": "openhands-review",
                 "review_tone": "thorough",
-                "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN"
+                "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN",
+                "maintainers": "",
+                "trigger_reviewer": "all-hands-bot"
               }
             }
           }
@@ -275,7 +290,7 @@
             "preset_metadata": {
               "template": {
                 "id": "github-pr-reviewer",
-                "version": "1.1.1",
+                "version": "1.3.0",
                 "config": {
                   "repos": [
                     "OpenHands/agent-server-gui",
@@ -283,13 +298,16 @@
                   ],
                   "trigger_label": "openhands-review",
                   "review_tone": "thorough",
-                  "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN"
+                  "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN",
+                  "maintainers": "",
+                  "trigger_reviewer": "all-hands-bot"
                 }
               }
             }
           }
         }
-      }
+      },
+      "selectedTrigger": "cron"
     },
     {
       "id": "interval-below-deployment-minimum",
@@ -302,7 +320,9 @@
         "repositories": [
           "OpenHands/agent-server-gui"
         ],
-        "githubTokenSecret": "GITHUB_PERSONAL_ACCESS_TOKEN"
+        "githubTokenSecret": "GITHUB_PERSONAL_ACCESS_TOKEN",
+        "maintainers": "",
+        "triggerReviewer": "all-hands-bot"
       },
       "preflight": {
         "request": {
@@ -323,14 +343,16 @@
               "timeout": 300,
               "template": {
                 "id": "github-pr-reviewer",
-                "version": "1.1.1",
+                "version": "1.3.0",
                 "config": {
                   "repos": [
                     "OpenHands/agent-server-gui"
                   ],
                   "trigger_label": "openhands-review",
                   "review_tone": "concise",
-                  "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN"
+                  "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN",
+                  "maintainers": "",
+                  "trigger_reviewer": "all-hands-bot"
                 }
               }
             }
@@ -352,7 +374,8 @@
       },
       "expectedFieldErrors": {
         "schedule": "Minimum interval for this deployment is 5 minutes."
-      }
+      },
+      "selectedTrigger": "cron"
     },
     {
       "id": "unfireable-cron-rejected-at-create",
@@ -365,7 +388,9 @@
         "repositories": [
           "OpenHands/agent-server-gui"
         ],
-        "githubTokenSecret": "GITHUB_PERSONAL_ACCESS_TOKEN"
+        "githubTokenSecret": "GITHUB_PERSONAL_ACCESS_TOKEN",
+        "maintainers": "",
+        "triggerReviewer": "all-hands-bot"
       },
       "upload": {
         "request": {
@@ -379,6 +404,7 @@
             "config.json",
             "main.py",
             "github_client.py",
+            "maintainer_handoff.py",
             "worker.py"
           ]
         },
@@ -408,14 +434,16 @@
             "timeout": 300,
             "template": {
               "id": "github-pr-reviewer",
-              "version": "1.1.1",
+              "version": "1.3.0",
               "config": {
                 "repos": [
                   "OpenHands/agent-server-gui"
                 ],
                 "trigger_label": "openhands-review",
                 "review_tone": "concise",
-                "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN"
+                "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN",
+                "maintainers": "",
+                "trigger_reviewer": "all-hands-bot"
               }
             }
           }
@@ -440,7 +468,8 @@
       },
       "expectedFieldErrors": {
         "schedule": "Value error, Cron expression cannot produce any future fire times: 0 0 31 2 *"
-      }
+      },
+      "selectedTrigger": "cron"
     },
     {
       "id": "repos-on-the-raw-create-request-is-rejected",
@@ -453,7 +482,9 @@
         "repositories": [
           "OpenHands/agent-server-gui"
         ],
-        "githubTokenSecret": "GITHUB_PERSONAL_ACCESS_TOKEN"
+        "githubTokenSecret": "GITHUB_PERSONAL_ACCESS_TOKEN",
+        "maintainers": "",
+        "triggerReviewer": "all-hands-bot"
       },
       "upload": {
         "request": {
@@ -467,6 +498,7 @@
             "config.json",
             "main.py",
             "github_client.py",
+            "maintainer_handoff.py",
             "worker.py"
           ]
         },
@@ -496,14 +528,16 @@
             "timeout": 300,
             "template": {
               "id": "github-pr-reviewer",
-              "version": "1.1.1",
+              "version": "1.3.0",
               "config": {
                 "repos": [
                   "OpenHands/agent-server-gui"
                 ],
                 "trigger_label": "openhands-review",
                 "review_tone": "concise",
-                "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN"
+                "github_token_secret": "GITHUB_PERSONAL_ACCESS_TOKEN",
+                "maintainers": "",
+                "trigger_reviewer": "all-hands-bot"
               }
             },
             "repos": [
@@ -530,7 +564,67 @@
           }
         }
       },
-      "matchesSetupPayload": false
+      "matchesSetupPayload": false,
+      "selectedTrigger": "cron"
+    },
+    {
+      "id": "reviewer-request-event",
+      "description": "A reviewer request selects the event trigger and filters the shared GitHub source to configured repositories, the configured bot request, and that bot's completion review.",
+      "selectedTrigger": "event",
+      "formValues": {
+        "triggerLabel": "openhands-review",
+        "triggerReviewer": "all-hands-bot",
+        "reviewTone": "concise",
+        "on": "*",
+        "repositories": [
+          "OpenHands/automation"
+        ],
+        "githubTokenSecret": "GITHUB_TOKEN_REVIEW",
+        "maintainers": "neubig,malhotra5"
+      },
+      "preflight": {
+        "request": {
+          "method": "POST",
+          "path": "/v1/validate",
+          "body": {
+            "automationId": "github-pr-reviewer",
+            "endpoint": "/v1",
+            "draft": {
+              "name": "GitHub code review - OpenHands/automation",
+              "trigger": {
+                "type": "event",
+                "on": "*",
+                "source": "github",
+                "filter": "contains(['OpenHands/automation'], repository.full_name) && contains(keys(@), 'pull_request') && ((action == 'review_requested' && requested_reviewer.login == 'all-hands-bot') || (action == 'submitted' && contains(keys(@), 'review') && review.user.login == 'all-hands-bot'))"
+              },
+              "tarball_path": "oh-internal://uploads/00000000-0000-0000-0000-000000000000",
+              "entrypoint": "python3 worker.py",
+              "timeout": 300,
+              "template": {
+                "id": "github-pr-reviewer",
+                "version": "1.3.0",
+                "config": {
+                  "repos": [
+                    "OpenHands/automation"
+                  ],
+                  "trigger_label": "openhands-review",
+                  "trigger_reviewer": "all-hands-bot",
+                  "review_tone": "concise",
+                  "maintainers": "neubig,malhotra5",
+                  "github_token_secret": "GITHUB_TOKEN_REVIEW"
+                }
+              }
+            }
+          }
+        },
+        "response": {
+          "status": 200,
+          "body": {
+            "valid": true,
+            "errors": []
+          }
+        }
+      }
     }
   ]
 }

package/tests/github_automation_helpers.py

@@ -20,6 +20,7 @@ def worker(name, tmp_path, monkeypatch):
         "agent_conversation",
         "main",
         "github_client",
+        "maintainer_handoff",
         "qa_prompt",
         "worker",
     ):

package/tests/test_agent_conversation_dispatch.py

@@ -4,6 +4,7 @@ from uuid import NAMESPACE_URL, UUID, uuid5
 
 import agent_conversation
 import github_client
+import pytest
 from openhands.sdk.conversation.state import ConversationExecutionStatus
 from openhands.sdk.secret import LookupSecret
 
@@ -130,7 +131,17 @@ def test_known_subject_resumes_once_per_delivery(monkeypatch):
     conversation.run.assert_called_once_with(blocking=False)
 
 
-def test_same_delivery_resumes_paused_conversation(monkeypatch):
+@pytest.mark.parametrize(
+    ("status", "disposition", "should_run"),
+    [
+        (ConversationExecutionStatus.IDLE, "resumed", True),
+        (ConversationExecutionStatus.PAUSED, "resumed", True),
+        (ConversationExecutionStatus.RUNNING, "in_progress", False),
+    ],
+)
+def test_same_delivery_resumes_only_inactive_conversation(
+    monkeypatch, status, disposition, should_run
+):
     state = {
         _state_key("repo:pr:9"): {
             "subject": "repo:pr:9",
@@ -147,7 +158,7 @@ def test_same_delivery_resumes_paused_conversation(monkeypatch):
         agent_conversation, "RemoteWorkspace", lambda **kwargs: workspace
     )
     conversation = MagicMock()
-    conversation.state.execution_status = ConversationExecutionStatus.PAUSED
+    conversation.state.execution_status = status
     monkeypatch.setattr(
         agent_conversation.RemoteConversation,
         "attach",
@@ -157,9 +168,13 @@ def test_same_delivery_resumes_paused_conversation(monkeypatch):
     with _dispatcher(monkeypatch) as dispatcher:
         result = dispatcher.deliver("repo:pr:9", "head-1", "old")
 
-    assert result["disposition"] == "resumed"
+    assert result["disposition"] == disposition
     conversation.send_message.assert_not_called()
-    conversation.run.assert_called_once_with(blocking=False)
+    conversation.update_secrets.assert_called_once_with(dispatcher._secrets)
+    if should_run:
+        conversation.run.assert_called_once_with(blocking=False)
+    else:
+        conversation.run.assert_not_called()
 
 
 def test_subjects_use_independent_kv_records(monkeypatch):

package/tests/test_automation_setup.py

@@ -654,6 +654,21 @@ def test_schema_file_is_valid_draft_2020_12() -> None:
     Draft202012Validator.check_schema(_SCHEMA)
 
 
+def test_schema_allows_event_filter_on_script_bundle() -> None:
+    entry = deepcopy(_load(CATALOG_DIR / "github-pr-reviewer" / "manifest.json"))
+    entry["setup"]["form"]["triggers"]["event"] = {
+        "on": {
+            "type": "event-type",
+            "label": "Event type",
+            "help": "GitHub event that starts the bundled script.",
+            "required": True,
+        }
+    }
+    entry["setup"]["filter"] = "repository.full_name == 'owner/repo'"
+
+    assert list(VALIDATOR.iter_errors(entry)) == []
+
+
 def test_schema_rejects_content_a_setup_block_must_never_carry() -> None:
     """The format constraints are the trust boundary, so they are asserted here.
 

package/tests/test_code_review_risk_evaluation.py

@@ -80,8 +80,8 @@ class TestCodeReviewSkillReferencesRisk:
 
     def test_risk_section_appears_after_dependency_section(self):
         content = get_code_review_skill()
-        dep_pos = content.index("8. **Dependency Changes**")
-        risk_pos = content.index("9. **Risk and Safety Evaluation**")
+        dep_pos = content.index("## Dependency and workflow updates")
+        risk_pos = content.index("## Risk and Safety Evaluation and output")
         assert risk_pos > dep_pos
 
     def test_always_include_risk_instruction(self):