@openhands/extensions 0.19.0 → 0.21.0

package/tests/test_github_automation_foundation.py

@@ -0,0 +1,73 @@
+"""Contracts for the shared GitHub automation foundation."""
+
+import json
+from urllib.error import HTTPError
+
+import github_client
+import pytest
+
+
+def test_repository_runs_are_isolated(tmp_path, monkeypatch):
+    monkeypatch.chdir(tmp_path)
+    monkeypatch.setattr("sys.argv", ["worker.py"])
+    (tmp_path / "config.json").write_text(
+        json.dumps(
+            {
+                "repos": ["owner/failed", "owner/next"],
+                "github_token_secret": "GITHUB_TOKEN",
+            }
+        )
+    )
+    visited = []
+
+    class Automation:
+        def __init__(self, *, repository, github_token_secret, conversation):
+            assert github_token_secret == "GITHUB_TOKEN"
+            self.repository = repository
+
+        def run(self):
+            visited.append(self.repository)
+            if self.repository == "owner/failed":
+                raise TimeoutError
+
+    with pytest.raises(RuntimeError, match="owner/failed"):
+        github_client.run_repositories(Automation)
+
+    assert visited == ["owner/failed", "owner/next"]
+
+
+def test_pagination_rejects_a_non_list_response(monkeypatch):
+    monkeypatch.setattr(
+        github_client, "github_request", lambda *args, **kwargs: ({}, {})
+    )
+
+    with pytest.raises(TypeError, match="paginated GitHub list"):
+        github_client.github_paginate("token", "/repos/owner/repo/issues")
+
+
+@pytest.mark.parametrize(
+    "state,reason,expected",
+    [
+        ("closed", "completed", True),
+        ("closed", "not_planned", False),
+        ("open", None, False),
+    ],
+)
+def test_dependencies_must_be_completed(state, reason, expected):
+    repository = object.__new__(github_client.GitHubRepository)
+    repository._completed_dependencies = {}
+    repository.gh = lambda *args: {"state": state, "state_reason": reason}
+
+    assert repository.dependencies_complete({"body": "Depends on: #12"}) is expected
+
+
+def test_dependency_permission_errors_fail_closed():
+    repository = object.__new__(github_client.GitHubRepository)
+    repository._completed_dependencies = {}
+
+    def denied(*args):
+        raise HTTPError("https://api.github.com", 403, "Forbidden", {}, None)
+
+    repository.gh = denied
+    with pytest.raises(HTTPError):
+        repository.dependencies_complete({"body": "Depends on: #12"})

package/tests/test_github_skill_installation.py

@@ -0,0 +1,63 @@
+"""Verify shared support is included in independently installed skills."""
+
+import json
+import subprocess
+import sys
+from pathlib import Path
+
+import pytest
+from openhands.sdk.skills import install_skill
+
+ROOT = Path(__file__).resolve().parents[1]
+
+
+def test_installed_triage_skill_contains_its_bundle(tmp_path):
+    name = "github-issue-triage"
+    install_skill(source=str(ROOT / "skills" / name), installed_dir=tmp_path)
+    scripts = tmp_path / name / "scripts"
+    manifest = json.loads(
+        (ROOT / f"automations/catalog/{name}/manifest.json").read_text()
+    )
+
+    for filename, source in manifest["setup"]["bundle"]["files"].items():
+        installed = scripts / filename
+        assert installed.is_file() and not installed.is_symlink()
+        assert installed.read_bytes() == (ROOT / source).read_bytes()
+
+    result = subprocess.run(
+        [sys.executable, "-c", "import worker"],
+        cwd=scripts,
+        text=True,
+        capture_output=True,
+        check=False,
+    )
+    assert result.returncode == 0, result.stderr
+
+
+@pytest.mark.parametrize(
+    "name",
+    [
+        "github-repo-monitor",
+        "github-agents-md-maintainer",
+        "github-issue-to-pr",
+        "github-pr-reviewer",
+    ],
+)
+def test_installed_github_skill_contains_shared_client(tmp_path, name):
+    install_skill(source=str(ROOT / "skills" / name), installed_dir=tmp_path)
+    scripts = tmp_path / name / "scripts"
+    helper = scripts / "github_client.py"
+
+    assert helper.is_file() and not helper.is_symlink()
+    assert (
+        helper.read_bytes()
+        == (ROOT / "skills/github/scripts/github_client.py").read_bytes()
+    )
+    result = subprocess.run(
+        [sys.executable, "-c", "import main"],
+        cwd=scripts,
+        text=True,
+        capture_output=True,
+        check=False,
+    )
+    assert result.returncode == 0, result.stderr

package/tests/test_github_triage_delivery.py

@@ -0,0 +1,53 @@
+"""Contract tests for independent triage delivery."""
+
+import json
+from unittest.mock import Mock
+
+import pytest
+from github_automation_helpers import worker
+
+
+@pytest.mark.parametrize(
+    "ready,criteria",
+    [(True, ["One observable result"]), (False, ["Clarify account ownership"])],
+)
+def test_triage_preserves_labels_and_only_readies_clear_work(
+    tmp_path, monkeypatch, ready, criteria
+):
+    cls = worker("github-issue-triage", tmp_path, monkeypatch).IssueTriage
+    run = object.__new__(cls)
+    issue = {
+        "number": 1,
+        "title": "A small feature",
+        "body": "",
+        "labels": [{"name": "enhancement"}],
+    }
+    run.open_issues = lambda: [issue]
+    run.gh_pages = lambda path: []
+    run.dependencies_complete = lambda issue: True
+    result = {
+        "ready": ready,
+        "priority": "normal",
+        "acceptance_criteria": criteria,
+        "rationale": "Small independent change",
+    }
+    run.evidence = tmp_path
+    run.conversation = Mock()
+    run.conversation.run.side_effect = lambda **kwargs: (
+        tmp_path / "triage.json"
+    ).write_text(json.dumps(result))
+    calls = []
+    run.gh = lambda *args: calls.append(args)
+    run.comment = lambda *args: calls.append(("comment", *args))
+
+    run.run()
+
+    updates = [call for call in calls if call[0] == "PATCH"]
+    assert bool(updates) is ready
+    if ready:
+        assert set(updates[0][2]["labels"]) == {
+            "enhancement",
+            "priority:normal",
+            "ready-for-dev",
+        }
+    assert criteria[0] in next(call[2] for call in calls if call[0] == "comment")