@openhands/extensions 0.18.0 → 0.19.0

package/tests/test_check_issue_readiness.py

@@ -0,0 +1,135 @@
+from __future__ import annotations
+
+import importlib.util
+import sys
+from pathlib import Path
+
+
+def _load_prod_module():
+    repo_root = Path(__file__).resolve().parents[1]
+    script_path = repo_root / ".github" / "scripts" / "check_issue_readiness.py"
+    name = "check_issue_readiness"
+    spec = importlib.util.spec_from_file_location(name, script_path)
+    assert spec and spec.loader
+    mod = importlib.util.module_from_spec(spec)
+    sys.modules[name] = mod
+    spec.loader.exec_module(mod)
+    return mod
+
+
+_prod = _load_prod_module()
+evaluate_readiness = _prod.evaluate_readiness
+extract_sections = _prod.extract_sections
+
+
+ENHANCEMENT_READY = """### Problem or Use Case
+
+The integration catalog lacks a Linear entry.
+
+### Desired Behavior
+
+`integrations/catalog/linear.json` describes the Linear MCP server so the
+catalog build picks it up.
+
+### Acceptance Criteria
+
+- [ ] `npm run build:integrations` succeeds with the new entry
+- [ ] `getIntegrationCatalogEntry("linear")` returns the Linear catalog model
+"""
+
+BUG_READY = """### Actual Behavior
+
+Running `uv run --group test pytest tests/` fails in
+`test_skills_catalog.py` with a KeyError when a skill is missing from the
+marketplace.
+
+### Acceptance Criteria
+
+- [ ] `uv run --group test pytest tests/` passes with a clear error message
+"""
+
+
+def test_extract_sections_splits_on_headings():
+    sections = extract_sections("### Alpha\n\ntext\n\n### Beta\n\nmore\n")
+    assert sections["alpha"] == "\ntext\n\n"
+    assert sections["beta"] == "\nmore\n"
+
+
+def test_enhancement_ready_passes():
+    result = evaluate_readiness(ENHANCEMENT_READY, ["enhancement"])
+    assert result.ready is True
+    assert result.reasons == []
+
+
+def test_enhancement_missing_acceptance_criteria_fails():
+    body = "### Desired Behavior\n\nSome desired change.\n"
+    result = evaluate_readiness(body, ["enhancement"])
+    assert result.ready is False
+    assert any("Acceptance Criteria" in r for r in result.reasons)
+
+
+def test_enhancement_missing_desired_behavior_fails():
+    body = ENHANCEMENT_READY.replace(
+        "### Desired Behavior\n\n"
+        "`integrations/catalog/linear.json` describes the Linear MCP server so the\n"
+        "catalog build picks it up.\n\n",
+        "",
+    )
+    result = evaluate_readiness(body, ["enhancement"])
+    assert result.ready is False
+    assert any("Desired Behavior" in r for r in result.reasons)
+
+
+def test_bug_ready_passes():
+    result = evaluate_readiness(BUG_READY, ["bug"])
+    assert result.ready is True
+    assert result.reasons == []
+
+
+def test_bug_missing_run_method_fails():
+    body = BUG_READY.replace(
+        "Running `uv run --group test pytest tests/` fails",
+        "Running the test suite fails",
+    )
+    result = evaluate_readiness(body, ["bug"])
+    assert result.ready is False
+    assert any("reproducible command" in r for r in result.reasons)
+
+
+def test_bug_npm_build_command_is_a_valid_run_method():
+    body = BUG_READY.replace(
+        "Running `uv run --group test pytest tests/` fails in\n"
+        "`test_skills_catalog.py` with a KeyError when a skill is missing from the\n"
+        "marketplace.",
+        "Running `npm run build:skills` fails with a schema error.",
+    )
+    result = evaluate_readiness(body, ["bug"])
+    assert result.ready is True
+    assert result.reasons == []
+
+
+def test_bug_acceptance_needs_checklist_item():
+    body = BUG_READY.replace(
+        "- [ ] `uv run --group test pytest tests/` passes with a clear error message",
+        "Make the test error message clearer",
+    )
+    result = evaluate_readiness(body, ["bug"])
+    assert result.ready is False
+    assert any("checklist item" in r for r in result.reasons)
+
+
+def test_no_response_field_counts_as_empty():
+    body = BUG_READY.replace(
+        "### Acceptance Criteria\n\n- [ ] `uv run --group test pytest tests/` "
+        "passes with a clear error message\n",
+        "### Acceptance Criteria\n\n_No response_\n",
+    )
+    result = evaluate_readiness(body, ["bug"])
+    assert result.ready is False
+    assert any("Acceptance Criteria" in r for r in result.reasons)
+
+
+def test_no_bug_or_enhancement_label_not_ready():
+    result = evaluate_readiness(ENHANCEMENT_READY, [])
+    assert result.ready is False
+    assert any("bug" in r and "enhancement" in r for r in result.reasons)

package/tests/test_check_pr_description.py

@@ -0,0 +1,228 @@
+from __future__ import annotations
+
+import importlib.util
+import json
+import sys
+from pathlib import Path
+
+
+def _load_prod_module():
+    repo_root = Path(__file__).resolve().parents[1]
+    script_path = repo_root / ".github" / "scripts" / "check_pr_description.py"
+    name = "check_pr_description"
+    spec = importlib.util.spec_from_file_location(name, script_path)
+    assert spec and spec.loader
+    mod = importlib.util.module_from_spec(spec)
+    sys.modules[name] = mod
+    spec.loader.exec_module(mod)
+    return mod
+
+
+_prod = _load_prod_module()
+validate_pr_body = _prod.validate_pr_body
+body_from_event = _prod.body_from_event
+extract_linked_issue_numbers = _prod.extract_linked_issue_numbers
+validate_linked_issue_ready = _prod.validate_linked_issue_ready
+fetch_issue_details = _prod.fetch_issue_details
+
+
+VALID_BODY = """<!-- Keep this PR as draft until it is ready for review. -->
+
+<!-- AI/LLM agents: be concise and specific. Do not check the box below. -->
+
+- [ ] A human has tested these changes.
+
+---
+
+## Why
+
+The repository had no readiness gate for issues or linked PRs.
+
+## Summary
+
+- Add ready-for-dev issue and PR readiness gates.
+
+## Issue Number
+
+Fixes #508
+
+## How to Test
+
+Run `uv run --group test pytest tests/`.
+
+## Video/Screenshots
+
+N/A
+
+## Notes
+
+N/A
+"""
+
+
+def test_valid_pr_body_passes():
+    assert validate_pr_body(VALID_BODY) == []
+
+
+def test_required_template_fields_must_be_present_and_filled():
+    how_to_test = "## How to Test\n\nRun `uv run --group test pytest tests/`."
+    body = VALID_BODY.replace(how_to_test, "## How to Test\n\n<!-- TODO -->")
+    body = body.replace("## Summary", "## Details")
+
+    errors = validate_pr_body(body)
+
+    assert "Fill in the `## How to Test` section of the PR template." in errors
+    assert "Keep the `## Summary` section from the PR template." in errors
+
+
+def test_summary_placeholder_bullet_counts_as_empty():
+    body = VALID_BODY.replace(
+        "- Add ready-for-dev issue and PR readiness gates.", "-"
+    )
+
+    errors = validate_pr_body(body)
+
+    assert "Fill in the `## Summary` section of the PR template." in errors
+
+
+def test_optional_template_sections_may_be_removed():
+    body = VALID_BODY.replace("## Issue Number\n\nFixes #508\n\n", "")
+    body = body.split("## Video/Screenshots", maxsplit=1)[0]
+
+    assert validate_pr_body(body) == []
+
+
+def test_body_from_event_reads_pull_request_body(tmp_path: Path):
+    event_path = tmp_path / "event.json"
+    event_path.write_text(
+        json.dumps(
+            {
+                "pull_request": {"body": VALID_BODY},
+                "repository": {"full_name": "org/repo"},
+            }
+        )
+    )
+
+    body, repo = body_from_event(event_path)
+    assert body == VALID_BODY
+    assert repo == "org/repo"
+
+
+def test_extract_linked_issue_numbers_keyword_and_bare_ref():
+    body = (
+        "Fixes #12\n"
+        "Closes #12 again\n"
+        "resolves #34\n"
+        "## Issue Number\n"
+        "Issue: #56, see also #12\n"
+    )
+    assert extract_linked_issue_numbers(body) == [12, 34, 56]
+
+
+def test_extract_linked_issue_numbers_only_bare_ref_in_issue_section():
+    body = "## Summary\n\nSome work.\n\n## Issue Number\n\n#7\n"
+    assert extract_linked_issue_numbers(body) == [7]
+
+
+def test_extract_linked_issue_numbers_no_bare_ref_outside_issue_section():
+    # A bare `#42` in the Summary must not be treated as a linked issue.
+    body = "## Summary\n\nSee #42 for background.\n\n## Issue Number\n\nN/A\n"
+    assert extract_linked_issue_numbers(body) == []
+
+
+def test_extract_linked_issue_numbers_keyword_inside_word_is_ignored():
+    # "fix"/"clos"/"resolv" must not match inside larger words (e.g. "crucifixes").
+    body = (
+        "## Summary\n\n"
+        "crucifixes #12, encloses #34, transfixes #56.\n\n"
+        "## Issue Number\n\nN/A\n"
+    )
+    assert extract_linked_issue_numbers(body) == []
+
+
+def test_validate_linked_issue_ready_requires_a_number():
+    errors = validate_linked_issue_ready(
+        "## Issue Number\n\nN/A\n", "org/repo", "token"
+    )
+    assert errors and "Link an issue" in errors[0]
+
+
+def test_validate_linked_issue_ready_no_token_skips_network(monkeypatch):
+    def _fail(*args, **kwargs):
+        raise AssertionError("should not call the network without a token")
+
+    monkeypatch.setattr(_prod, "fetch_issue_details", _fail)
+    assert validate_linked_issue_ready("Fixes #12\n", None, None) == []
+
+
+def test_validate_linked_issue_ready_passes_with_ready_label(monkeypatch):
+    monkeypatch.setattr(
+        _prod,
+        "fetch_issue_details",
+        lambda repo, num, token: (["ready-for-dev"], "2026-08-25T00:00:00Z"),
+    )
+    assert validate_linked_issue_ready("Fixes #12\n", "org/repo", "token") == []
+
+
+def test_validate_linked_issue_ready_grandfathers_pre_rollout_issue(monkeypatch):
+    monkeypatch.setattr(
+        _prod,
+        "fetch_issue_details",
+        lambda repo, num, token: (["bug"], "2026-01-15T00:00:00Z"),
+    )
+    assert validate_linked_issue_ready("Fixes #12\n", "org/repo", "token") == []
+
+
+def test_validate_linked_issue_ready_grandfathers_rollout_day_before_deployment(
+    monkeypatch,
+):
+    # Opened on the rollout day (2026-08-24) before the workflow was deployed,
+    # so it was never labeled. It must be exempt.
+    monkeypatch.setattr(
+        _prod,
+        "fetch_issue_details",
+        lambda repo, num, token: (["bug"], "2026-08-24T06:46:00Z"),
+    )
+    assert validate_linked_issue_ready("Fixes #12\n", "org/repo", "token") == []
+
+
+def test_validate_linked_issue_ready_fails_for_new_not_ready_issue(monkeypatch):
+    monkeypatch.setattr(
+        _prod,
+        "fetch_issue_details",
+        lambda repo, num, token: (["bug"], "2026-08-25T00:00:00Z"),
+    )
+    errors = validate_linked_issue_ready("Fixes #12\n", "org/repo", "token")
+    assert errors and "ready-for-dev" in errors[0]
+
+
+def test_validate_linked_issue_ready_new_unready_not_masked_by_ready_sibling(
+    monkeypatch,
+):
+    def _issues(repo, num, token):
+        # #12 carries ready-for-dev; #34 is new and not ready.
+        if num == 34:
+            return ["bug"], "2026-08-25T00:00:00Z"
+        return ["ready-for-dev"], "2026-08-25T00:00:00Z"
+
+    monkeypatch.setattr(_prod, "fetch_issue_details", _issues)
+    body = "Fixes #12 and Closes #34"
+    errors = validate_linked_issue_ready(body, "org/repo", "token")
+    assert "#34" in errors[0]
+    assert "ready-for-dev" in errors[0]
+
+
+def test_validate_linked_issue_ready_returns_error_when_all_issues_not_found(
+    monkeypatch,
+):
+    import urllib.error
+    from http.client import HTTPMessage
+
+    def _missing(repo, num, token):
+        raise urllib.error.HTTPError(
+            "https://api.github.com", 404, "Not Found", HTTPMessage(), None
+        )
+
+    monkeypatch.setattr(_prod, "fetch_issue_details", _missing)
+    errors = validate_linked_issue_ready("Fixes #12\n", "org/repo", "token")
+    assert errors and "could not be found" in errors[0]

package/tests/test_pr_review_prompt.py

@@ -59,6 +59,16 @@ def test_prompt_with_roasted_trigger():
     assert "/codereview-roasted" in prompt
 
 
+def test_prompt_instructs_reading_repo_guidance():
+    """The reviewer must be told to read AGENTS.md (and other guideline docs)
+    to understand the repo before reviewing."""
+    prompt = _format_prompt(require_evidence=False)
+
+    assert "AGENTS.md" in prompt
+    assert "MUST read" in prompt
+    assert "CONTRIBUTING.md" in prompt
+
+
 def test_format_prompt_omits_evidence_requirements_by_default():
     prompt = _format_prompt(require_evidence=False)
 

package/tests/test_refresh_linked_pr_checks.py

@@ -0,0 +1,130 @@
+from __future__ import annotations
+
+import importlib.util
+import json
+import sys
+from pathlib import Path
+
+
+def _load(name: str, script_name: str):
+    script_path = (
+        Path(__file__).resolve().parents[1] / ".github" / "scripts" / script_name
+    )
+    spec = importlib.util.spec_from_file_location(name, script_path)
+    assert spec and spec.loader
+    mod = importlib.util.module_from_spec(spec)
+    sys.modules[name] = mod
+    spec.loader.exec_module(mod)
+    return mod
+
+
+# Import check_pr_description first so refresh_linked_pr_checks can resolve its
+# `from check_pr_description import ...` against the module we loaded above.
+_load("check_pr_description", "check_pr_description.py")
+_prod = _load("refresh_linked_pr_checks", "refresh_linked_pr_checks.py")
+
+
+def _event(action="labeled", label="ready-for-dev", number=12):
+    return {
+        "action": action,
+        "issue": {"number": number},
+        "label": {"name": label},
+        "repository": {"full_name": "org/repo"},
+    }
+
+
+def _write_event(monkeypatch, payload, tmp_path):
+    event_path = tmp_path / "event.json"
+    event_path.write_text(json.dumps(payload))
+    monkeypatch.setenv("GITHUB_EVENT_PATH", str(event_path))
+
+
+class _FakeProc:
+    def __init__(self, stdout: str = ""):
+        self.returncode = 0
+        self.stdout = stdout
+        self.stderr = ""
+
+
+def _recording_run(calls):
+    def _call(args):
+        calls.append(args)
+        # Listing runs returns one run; rerun is a no-op success.
+        if any("/actions/runs" in a for a in args):
+            return _FakeProc("8675309 2026-08-25T00:00:00Z\n")
+        return _FakeProc()
+
+    return _call
+
+
+def _fail_on_call(value):
+    def _call(*args, **kwargs):
+        raise AssertionError(value)
+
+    return _call
+
+
+def test_noop_for_unrelated_label(monkeypatch, tmp_path):
+    _write_event(monkeypatch, _event(label="bug"), tmp_path)
+    monkeypatch.setattr(_prod, "_linked_open_prs", _fail_on_call("unexpected"))
+    assert _prod.main() == 0
+
+
+def test_noop_for_unrelated_action(monkeypatch, tmp_path):
+    _write_event(monkeypatch, _event(action="edited"), tmp_path)
+    monkeypatch.setattr(_prod, "_linked_open_prs", _fail_on_call("unexpected"))
+    assert _prod.main() == 0
+
+
+def test_reruns_linked_pr_check_when_readiness_label_changes(monkeypatch, tmp_path):
+    _write_event(monkeypatch, _event(), tmp_path)
+    monkeypatch.setattr(
+        _prod,
+        "_linked_open_prs",
+        lambda repo, num: [{"number": 7, "headRefOid": "abc123"}],
+    )
+    monkeypatch.setattr(_prod, "_run", lambda args: _FakeProc("Fixes #12"))
+    seen = []
+    monkeypatch.setattr(
+        _prod,
+        "_rerun_pr_description_check",
+        lambda repo, sha: (seen.append((repo, sha)) or True),
+    )
+    assert _prod.main() == 0
+    assert seen == [("org/repo", "abc123")]
+
+
+def test_skips_cross_referenced_pr_that_does_not_link_issue(monkeypatch, tmp_path):
+    _write_event(monkeypatch, _event(), tmp_path)
+    monkeypatch.setattr(
+        _prod,
+        "_linked_open_prs",
+        lambda repo, num: [{"number": 7, "headRefOid": "abc123"}],
+    )
+    # Body mentions #99 (the cross-reference) but not the event's issue #12.
+    monkeypatch.setattr(_prod, "_run", lambda args: _FakeProc("Fixes #99"))
+    seen = []
+    monkeypatch.setattr(
+        _prod,
+        "_rerun_pr_description_check",
+        lambda repo, sha: (seen.append((repo, sha)) or True),
+    )
+    assert _prod.main() == 0
+    assert seen == []
+
+
+def test_rerun_pr_description_check_lists_runs_with_get(monkeypatch):
+    calls: list[list[str]] = []
+    monkeypatch.setattr(_prod, "_run", _recording_run(calls))
+    assert _prod._rerun_pr_description_check("org/repo", "abc123") is True
+    # Listing runs must be an explicit GET: `-f` args alone switch `gh api`
+    # to POST, which 404s on the runs collection endpoint (seen in the wild).
+    list_call = next(a for a in calls if "repos/org/repo/actions/runs" in a)
+    assert "-X" in list_call
+    assert list_call[list_call.index("-X") + 1] == "GET"
+    # The selected run is then re-run via an explicit POST.
+    rerun_call = next(a for a in calls if any("/rerun" in arg for arg in a))
+    assert rerun_call[rerun_call.index("api") + 1 : rerun_call.index("api") + 3] == [
+        "-X",
+        "POST",
+    ]