@openhands/extensions 0.1.0 → 0.3.0

package/tests/test_openhands_api_python.py

@@ -0,0 +1,152 @@
+import importlib.util
+import sys
+from pathlib import Path
+
+
+def _load_openhands_api_module():
+    skill_path = Path(__file__).parent.parent / "skills" / "openhands-api" / "scripts" / "openhands_api.py"
+    spec = importlib.util.spec_from_file_location("openhands_api", skill_path)
+    mod = importlib.util.module_from_spec(spec)
+    sys.modules["openhands_api"] = mod
+    spec.loader.exec_module(mod)
+    return mod
+
+
+def test_app_conversation_start_builds_v1_payload(monkeypatch):
+    mod = _load_openhands_api_module()
+    OpenHandsAPI = mod.OpenHandsAPI
+
+    captured = {}
+
+    class FakeResp:
+        def raise_for_status(self):
+            return None
+
+        def json(self):
+            return {"id": "task-1", "status": "WORKING"}
+
+    class FakeClient:
+        def __init__(self, **kwargs):
+            self.kwargs = kwargs
+
+        def post(self, url, json=None, timeout=None):
+            captured["url"] = url
+            captured["json"] = json
+            captured["timeout"] = timeout
+            return FakeResp()
+
+        def close(self):
+            return None
+
+    monkeypatch.setattr(mod.httpx, "Client", lambda **kwargs: FakeClient(**kwargs))
+
+    api = OpenHandsAPI(api_key="k", base_url="https://example.com/")
+    resp = api.app_conversation_start(
+        initial_message="hi",
+        selected_repository="o/r",
+        selected_branch="main",
+        title="Test title",
+        run=False,
+    )
+
+    assert resp == {"id": "task-1", "status": "WORKING"}
+    assert captured["url"] == "https://example.com/api/v1/app-conversations"
+    assert captured["timeout"] == 120
+    assert captured["json"] == {
+        "initial_message": {
+            "role": "user",
+            "content": [{"type": "text", "text": "hi"}],
+            "run": False,
+        },
+        "selected_repository": "o/r",
+        "selected_branch": "main",
+        "title": "Test title",
+    }
+
+
+def test_app_conversations_get_batch_passes_ids(monkeypatch):
+    mod = _load_openhands_api_module()
+    OpenHandsAPI = mod.OpenHandsAPI
+
+    captured = {}
+
+    class FakeResp:
+        def raise_for_status(self):
+            return None
+
+        def json(self):
+            return [{"id": "conv-1"}]
+
+    class FakeClient:
+        def __init__(self, **kwargs):
+            self.kwargs = kwargs
+
+        def get(self, url, params=None):
+            captured["url"] = url
+            captured["params"] = params
+            return FakeResp()
+
+        def close(self):
+            return None
+
+    monkeypatch.setattr(mod.httpx, "Client", lambda **kwargs: FakeClient(**kwargs))
+
+    api = OpenHandsAPI(api_key="k", base_url="https://example.com")
+    conversations = api.app_conversations_get_batch(ids=["conv-1", "conv-2"])
+
+    assert conversations == [{"id": "conv-1"}]
+    assert captured["url"] == "https://example.com/api/v1/app-conversations"
+    assert captured["params"] == {"ids": ["conv-1", "conv-2"]}
+
+
+def test_poll_start_task_until_ready_uses_start_task_endpoint(monkeypatch):
+    mod = _load_openhands_api_module()
+    OpenHandsAPI = mod.OpenHandsAPI
+
+    states = [
+        {"id": "task-1", "status": "WORKING"},
+        {"id": "task-1", "status": "READY", "app_conversation_id": "conv-1"},
+    ]
+    call_count = {"sleep": 0}
+
+    class FakeClient:
+        def __init__(self, **kwargs):
+            self.kwargs = kwargs
+
+        def get(self, url, params=None):
+            class FakeResp:
+                def raise_for_status(self_nonlocal):
+                    return None
+
+                def json(self_nonlocal):
+                    return [states.pop(0)]
+
+            return FakeResp()
+
+        def close(self):
+            return None
+
+    monkeypatch.setattr(mod.httpx, "Client", lambda **kwargs: FakeClient(**kwargs))
+    monkeypatch.setattr(mod.time, "sleep", lambda *_args, **_kwargs: call_count.__setitem__("sleep", call_count["sleep"] + 1))
+
+    api = OpenHandsAPI(api_key="k", base_url="https://example.com")
+    ready = api.poll_start_task_until_ready("task-1", timeout_s=10, poll_interval_s=0.01, backoff_factor=1.0)
+
+    assert ready == {"id": "task-1", "status": "READY", "app_conversation_id": "conv-1"}
+    assert call_count["sleep"] == 1
+
+
+def test_legacy_alias_still_exists(monkeypatch):
+    mod = _load_openhands_api_module()
+
+    class FakeClient:
+        def __init__(self, **kwargs):
+            self.kwargs = kwargs
+
+        def close(self):
+            return None
+
+    monkeypatch.setattr(mod.httpx, "Client", lambda **kwargs: FakeClient(**kwargs))
+
+    api = mod.OpenHandsV1API(api_key="k")
+    assert isinstance(api, mod.OpenHandsAPI)

package/tests/test_plugin_manifest.py

@@ -0,0 +1,83 @@
+"""Test that all plugin.json manifests are valid and Claude Code compatible."""
+
+import json
+from pathlib import Path
+
+import pytest
+
+
+def get_plugins_directory():
+    """Get the path to the plugins directory."""
+    test_dir = Path(__file__).parent
+    return test_dir.parent / "plugins"
+
+
+def get_all_plugin_manifests():
+    """Yield (plugin_name, manifest_path) for every plugin with a .plugin/plugin.json."""
+    plugins_dir = get_plugins_directory()
+    for plugin_dir in sorted(plugins_dir.iterdir()):
+        if not plugin_dir.is_dir() or plugin_dir.name.startswith("."):
+            continue
+        manifest = plugin_dir / ".plugin" / "plugin.json"
+        if manifest.exists():
+            yield plugin_dir.name, manifest
+
+
+REQUIRED_FIELDS = ["name", "description", "author", "version"]
+
+
+@pytest.fixture(params=list(get_all_plugin_manifests()), ids=lambda p: p[0])
+def plugin_manifest(request):
+    """Parametrized fixture returning (name, path, parsed_json) for each plugin."""
+    name, path = request.param
+    data = json.loads(path.read_text())
+    return name, path, data
+
+
+def test_plugin_has_required_fields(plugin_manifest):
+    name, path, data = plugin_manifest
+    for field in REQUIRED_FIELDS:
+        assert field in data, (
+            f"Plugin '{name}' is missing required field '{field}' in {path}"
+        )
+
+
+def test_plugin_author_is_object(plugin_manifest):
+    """Claude Code requires 'author' to be an object with at least a 'name' key."""
+    name, path, data = plugin_manifest
+    author = data.get("author")
+    assert isinstance(author, dict), (
+        f"Plugin '{name}': 'author' must be an object (got {type(author).__name__}). "
+        f"Use {{\"name\": \"...\", \"email\": \"...\"}} format for Claude Code compatibility."
+    )
+    assert "name" in author, (
+        f"Plugin '{name}': 'author' object must contain a 'name' field."
+    )
+
+
+def test_plugin_json_is_valid(plugin_manifest):
+    """Ensure plugin.json is valid JSON with expected types."""
+    name, path, data = plugin_manifest
+    assert isinstance(data.get("name"), str), f"Plugin '{name}': 'name' must be a string"
+    assert isinstance(data.get("version"), str), f"Plugin '{name}': 'version' must be a string"
+    assert isinstance(data.get("description"), str), f"Plugin '{name}': 'description' must be a string"
+
+
+def test_all_plugins_have_manifest():
+    """Ensure every plugin directory has a .plugin/plugin.json manifest."""
+    plugins_dir = get_plugins_directory()
+    plugin_dirs = [
+        d.name
+        for d in plugins_dir.iterdir()
+        if d.is_dir() and not d.name.startswith(".")
+    ]
+    assert len(plugin_dirs) > 0, "No plugin directories found"
+
+    missing = [
+        name
+        for name in plugin_dirs
+        if not (plugins_dir / name / ".plugin" / "plugin.json").exists()
+    ]
+    assert len(missing) == 0, (
+        f"Plugins missing .plugin/plugin.json: {', '.join(missing)}"
+    )

package/tests/test_pr_review_diff_payload.py

@@ -0,0 +1,202 @@
+"""Tests for the per-file diff payload introduced to replace the global byte-
+slice truncation in agent_script.py.
+
+The legacy `truncate_text()` cut the raw diff at byte 100,000, which silently
+dropped files whose patches lived past that point (issue #233). These tests
+exercise the replacement: a manifest that lists every file plus per-file
+budgeted patches that mark abbreviation/omission explicitly.
+"""
+
+from __future__ import annotations
+
+# Re-use the module loader from the review-context test file so we don't
+# duplicate ~130 lines of openhands-SDK stubbing.
+from test_pr_review_review_context import _load_agent_script_module
+
+
+def _file(
+    filename: str,
+    *,
+    status: str = "modified",
+    additions: int = 0,
+    deletions: int = 0,
+    patch: str | None = "",
+    previous_filename: str | None = None,
+) -> dict:
+    return {
+        "filename": filename,
+        "status": status,
+        "additions": additions,
+        "deletions": deletions,
+        "patch": patch,
+        "previous_filename": previous_filename,
+    }
+
+
+# --- manifest -----------------------------------------------------------
+
+
+def test_manifest_lists_every_file():
+    module = _load_agent_script_module()
+    files = [
+        _file("a.py", status="added", additions=10),
+        _file("b.py", status="modified", additions=2, deletions=3),
+        _file("c.py", status="removed", deletions=15),
+    ]
+    manifest = module.format_files_manifest(files)
+    assert "`a.py`" in manifest
+    assert "`b.py`" in manifest
+    assert "`c.py`" in manifest
+    assert "[added]" in manifest
+    assert "[modified]" in manifest
+    assert "[removed]" in manifest
+    assert "+10" in manifest
+    assert "+2/-3" in manifest
+    assert "-15" in manifest
+
+
+def test_manifest_includes_totals_in_header():
+    module = _load_agent_script_module()
+    files = [
+        _file("a.py", additions=10, deletions=2),
+        _file("b.py", additions=5, deletions=1),
+    ]
+    manifest = module.format_files_manifest(files)
+    assert "2 files" in manifest
+    assert "+15" in manifest
+    assert "-3" in manifest
+
+
+def test_manifest_handles_renames():
+    module = _load_agent_script_module()
+    files = [
+        _file(
+            "new.py",
+            status="renamed",
+            additions=1,
+            deletions=1,
+            previous_filename="old.py",
+        ),
+    ]
+    manifest = module.format_files_manifest(files)
+    assert "`new.py`" in manifest
+    assert "renamed from old.py" in manifest
+
+
+def test_manifest_flags_binary_files():
+    module = _load_agent_script_module()
+    files = [
+        _file("logo.png", status="modified", additions=1, deletions=1, patch=""),
+    ]
+    manifest = module.format_files_manifest(files)
+    assert "`logo.png`" in manifest
+    assert "binary or unavailable" in manifest
+
+
+# --- patch formatting ---------------------------------------------------
+
+
+def test_patches_include_header_for_every_file():
+    """Every file gets a diff header even when only a stub fits."""
+    module = _load_agent_script_module()
+    files = [
+        _file("a.py", status="added", additions=1, patch="@@ -0,0 +1 @@\n+x\n"),
+        _file("b.py", status="added", additions=1, patch="@@ -0,0 +1 @@\n+y\n"),
+    ]
+    out = module.format_patches(files)
+    assert "diff --git a/a.py b/a.py" in out
+    assert "diff --git a/b.py b/b.py" in out
+
+
+def test_patches_below_budget_passthrough():
+    module = _load_agent_script_module()
+    patch = "@@ -1,2 +1,2 @@\n-foo\n+bar\n"
+    files = [_file("a.py", patch=patch)]
+    out = module.format_patches(files, max_total=10000, max_per_file=10000)
+    assert patch in out
+    assert "[patch abbreviated" not in out
+
+
+def test_per_file_cap_abbreviates_huge_single_file():
+    """A single large patch is abbreviated, not dropped."""
+    module = _load_agent_script_module()
+    big_patch = "@@ -0,0 +1,1000 @@\n" + "".join(
+        f"+line {i}\n" for i in range(1000)
+    )
+    files = [_file("big.py", status="added", patch=big_patch)]
+    out = module.format_patches(files, max_total=100000, max_per_file=500)
+    assert "diff --git a/big.py b/big.py" in out
+    # The marker is the contract — the agent knows the patch was cut.
+    assert "[patch abbreviated" in out
+    # Should reference the actual file path so the agent knows where to look.
+    assert "`big.py`" in out
+    # Must not contain the full patch text.
+    assert len(out) < len(big_patch)
+
+
+def test_total_budget_omits_late_files_with_marker_not_silence():
+    """When total budget is exhausted, later files become header-only stubs
+    with an explicit `[patch omitted]` marker — never silently dropped."""
+    module = _load_agent_script_module()
+    fat_patch = "@@ -0,0 +1,100 @@\n" + "".join(f"+x{i}\n" for i in range(100))
+    files = [
+        _file("first.py", status="added", patch=fat_patch),
+        _file("second.py", status="added", patch=fat_patch),
+        _file("third.py", status="added", patch=fat_patch),
+    ]
+    # Budget that comfortably fits one full patch but not three.
+    out = module.format_patches(files, max_total=800, max_per_file=10000)
+
+    # All three files appear in the patch block — at minimum as headers.
+    assert "diff --git a/first.py b/first.py" in out
+    assert "diff --git a/second.py b/second.py" in out
+    assert "diff --git a/third.py b/third.py" in out
+    # At least one of the later files is marked omitted.
+    assert "[patch omitted" in out
+
+
+def test_no_patch_field_is_annotated_not_silent():
+    """A file with no patch text (binary, rename, etc) gets a clear note."""
+    module = _load_agent_script_module()
+    files = [_file("logo.png", additions=1, deletions=1, patch="")]
+    out = module.format_patches(files)
+    assert "diff --git a/logo.png b/logo.png" in out
+    assert "no patch available" in out
+
+
+def test_smoking_gun_pr_14401_shape():
+    """Regression for issue #233 — the specific failure mode that triggered
+    the redesign. Earlier files have huge patches; the implementation file
+    of interest sits past the byte-100K mark of the original raw diff. With
+    a per-file budget the late file's *patch* may still be abbreviated, but
+    its *presence* must always be visible in both manifest and patch block."""
+    module = _load_agent_script_module()
+
+    # Two heavy files dominate the byte budget.
+    bulk_patch = "@@ -1 +1,2000 @@\n" + "".join(
+        f"+filler {i}\n" for i in range(2000)
+    )
+    # The implementation file the bot kept missing.
+    target = (
+        "@@ -0,0 +1,55 @@\n"
+        + "".join(f"+line {i}\n" for i in range(55))
+    )
+    files = [
+        _file("enterprise/poetry.lock", patch=bulk_patch),
+        _file("openhands/long_module.py", patch=bulk_patch),
+        _file(
+            "frontend/src/utils/shell-tokenize.ts",
+            status="added",
+            additions=55,
+            patch=target,
+        ),
+    ]
+
+    manifest = module.format_files_manifest(files)
+    patches = module.format_patches(files, max_total=2000, max_per_file=600)
+
+    # Manifest always names the target file — this is the property that
+    # prevents the bot from claiming the file is missing.
+    assert "`frontend/src/utils/shell-tokenize.ts`" in manifest
+    # Patch block lists it too, even when its content is abbreviated/omitted.
+    assert "diff --git a/frontend/src/utils/shell-tokenize.ts" in patches

package/tests/test_pr_review_feedback.py

@@ -0,0 +1,263 @@
+"""Tests for PR review feedback collection."""
+
+import importlib.util
+import sys
+import types
+from pathlib import Path
+
+import yaml
+
+
+_ROOT = Path(__file__).parent.parent
+_PR_REVIEW_SCRIPTS = _ROOT / "plugins" / "pr-review" / "scripts"
+
+
+def _load_prompt_module():
+    path = _PR_REVIEW_SCRIPTS / "prompt.py"
+    spec = importlib.util.spec_from_file_location("pr_review_prompt_feedback", path)
+    module = importlib.util.module_from_spec(spec)
+    sys.modules[spec.name] = module
+    spec.loader.exec_module(module)
+    return module
+
+
+
+def _load_eval_module():
+    """Load evaluate_review.py with Laminar stubbed."""
+    lmnr_mod = types.ModuleType("lmnr")
+
+    class _FakeLaminar:
+        @staticmethod
+        def initialize():
+            return None
+
+        @staticmethod
+        def get_trace_id():
+            return None
+
+        @staticmethod
+        def get_laminar_span_context():
+            return None
+
+        @staticmethod
+        def set_trace_metadata(metadata):
+            return None
+
+        @staticmethod
+        def set_span_output(output):
+            return None
+
+        @staticmethod
+        def flush():
+            return None
+
+        @staticmethod
+        def start_as_current_span(**kwargs):
+            import contextlib
+
+            return contextlib.nullcontext()
+
+    class _FakeClient:
+        class evaluators:
+            @staticmethod
+            def score(**kwargs):
+                return None
+
+        class tags:
+            @staticmethod
+            def tag(trace_id, tags):
+                return None
+
+    lmnr_mod.Laminar = _FakeLaminar
+    lmnr_mod.LaminarClient = _FakeClient
+
+    saved = sys.modules.get("lmnr")
+    sys.modules["lmnr"] = lmnr_mod
+    try:
+        path = _PR_REVIEW_SCRIPTS / "evaluate_review.py"
+        spec = importlib.util.spec_from_file_location("pr_review_evaluate", path)
+        module = importlib.util.module_from_spec(spec)
+        sys.modules[spec.name] = module
+        spec.loader.exec_module(module)
+        return module
+    finally:
+        if saved is None:
+            sys.modules.pop("lmnr", None)
+        else:
+            sys.modules["lmnr"] = saved
+
+
+
+def _format_prompt(*, collect_feedback: bool, review_run_url: str = "") -> str:
+    module = _load_prompt_module()
+    return module.format_prompt(
+        skill_trigger="/codereview",
+        title="Add review feedback footer",
+        body="## Summary\nCapture review reactions without extra PR spam.",
+        repo_name="OpenHands/extensions",
+        base_branch="main",
+        head_branch="feature/feedback-footer",
+        pr_number="249",
+        commit_id="abc123",
+        diff="diff --git a/file b/file",
+        review_context="",
+        require_evidence=False,
+        collect_feedback=collect_feedback,
+        review_run_url=review_run_url,
+        use_sub_agents=False,
+    )
+
+
+
+def test_action_collect_feedback_defaults_to_true_and_uses_agent_prompt():
+    action_yml = _ROOT / "plugins" / "pr-review" / "action.yml"
+    with open(action_yml) as f:
+        action = yaml.safe_load(f)
+
+    collect_feedback = action["inputs"]["collect-feedback"]
+    assert collect_feedback["default"] == "true"
+
+    run_step = next(
+        step for step in action["runs"]["steps"] if step["name"] == "Run PR review"
+    )
+    assert run_step["env"]["COLLECT_FEEDBACK"] == "${{ inputs.collect-feedback }}"
+    assert run_step["env"]["REVIEW_RUN_URL"] == (
+        "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
+    )
+    assert all(
+        step["name"] != "Post PR review feedback prompt"
+        for step in action["runs"]["steps"]
+    )
+
+
+
+def test_prompt_omits_feedback_footer_by_default():
+    prompt = _format_prompt(collect_feedback=False)
+
+    assert "## Review Feedback Footer" not in prompt
+    assert "React with 👍 or 👎 to this review" not in prompt
+    assert "<!-- openhands-pr-review-feedback -->" not in prompt
+
+
+
+def test_prompt_includes_feedback_footer_when_enabled():
+    prompt = _format_prompt(
+        collect_feedback=True,
+        review_run_url="https://github.com/OpenHands/extensions/actions/runs/123",
+    )
+
+    assert "## Review Feedback Footer" in prompt
+    assert "main review body, not in a separate issue comment" in prompt
+    assert "React with 👍 or 👎 to this review" in prompt
+    assert "https://github.com/OpenHands/extensions/actions/runs/123" in prompt
+    assert "<!-- openhands-pr-review-feedback -->" in prompt
+
+
+
+def test_extract_review_feedback_counts_thumbs_reactions_from_reviews():
+    module = _load_eval_module()
+
+    reviews = [
+        {
+            "id": 101,
+            "user": {"login": "openhands-agent"},
+            "body": "Automated review\n<!-- openhands-pr-review-feedback -->",
+            "submitted_at": "2026-05-19T12:00:00Z",
+            "reactions": {"+1": 3, "-1": 1, "total_count": 4},
+        },
+        {
+            "id": 102,
+            "user": {"login": "openhands-agent"},
+            "body": "Regular review comment",
+            "reactions": {"+1": 100, "-1": 100},
+        },
+        {
+            "id": 103,
+            "user": {"login": "human-dev"},
+            "body": "<!-- openhands-pr-review-feedback -->",
+            "reactions": {"+1": 5, "-1": 0},
+        },
+    ]
+
+    assert module.extract_review_feedback([], reviews) == [
+        {
+            "comment_id": 101,
+            "created_at": "2026-05-19T12:00:00Z",
+            "thumbs_up": 3,
+            "thumbs_down": 1,
+            "total": 4,
+        }
+    ]
+
+
+
+def test_extract_review_feedback_keeps_legacy_issue_comment_support():
+    module = _load_eval_module()
+
+    result = module.extract_review_feedback(
+        [
+            {
+                "id": 201,
+                "user": {"login": "all-hands-bot"},
+                "body": "<!-- openhands-pr-review-feedback -->",
+                "created_at": "2026-05-19T12:00:00Z",
+                "reactions": {"+1": 2, "-1": 0},
+            }
+        ]
+    )
+
+    assert result == [
+        {
+            "comment_id": 201,
+            "created_at": "2026-05-19T12:00:00Z",
+            "thumbs_up": 2,
+            "thumbs_down": 0,
+            "total": 2,
+        }
+    ]
+
+
+
+def test_extract_review_feedback_handles_missing_reactions():
+    module = _load_eval_module()
+
+    result = module.extract_review_feedback(
+        [],
+        [
+            {
+                "id": 301,
+                "user": {"login": "all-hands-bot"},
+                "body": "<!-- openhands-pr-review-feedback -->",
+            }
+        ],
+    )
+
+    assert result == [
+        {
+            "comment_id": 301,
+            "created_at": None,
+            "thumbs_up": 0,
+            "thumbs_down": 0,
+            "total": 0,
+        }
+    ]
+
+
+
+def test_extract_review_feedback_accepts_github_actions_bot():
+    module = _load_eval_module()
+
+    result = module.extract_review_feedback(
+        [],
+        [
+            {
+                "id": 401,
+                "user": {"login": "github-actions[bot]"},
+                "body": "<!-- openhands-pr-review-feedback -->",
+                "reactions": {"+1": 1, "-1": 2},
+            }
+        ],
+    )
+
+    assert result[0]["thumbs_up"] == 1
+    assert result[0]["thumbs_down"] == 2