@opengsd/gsd-pi 1.8.1 → 1.9.0-dev.97ef11e3

package/dist/resources/extensions/gsd/templates/PREFERENCES.md

@@ -92,6 +92,11 @@ remote_questions:
 uat_dispatch:
 post_unit_hooks: []
 pre_dispatch_hooks: []
+# planning_subagents:
+#   plan-milestone:
+#     allowed: [scout, planner, security]
+#   plan-slice:
+#     allowed: [scout, planner, reviewer, security]
 # language:
 # experimental:
 #   rtk: false

package/dist/resources/extensions/gsd/tools/complete-task.js

@@ -12,10 +12,10 @@
 import { existsSync, unlinkSync } from "node:fs";
 import { join } from "node:path";
 import { isClosedStatus } from "../status-guards.js";
-import { transaction, insertMilestone, insertSlice, insertTask, insertVerificationEvidence, getMilestone, getSlice, getTask, updateTaskStatus, deleteVerificationEvidence, saveGateResult, getPendingGatesForTurn, } from "../gsd-db.js";
+import { transaction, insertMilestone, insertSlice, insertTask, insertVerificationEvidence, getMilestone, getSlice, getTask, updateTaskStatus, deleteVerificationEvidence, saveGateResult, getPendingGatesForTurn, getUnresolvedBlockingReworkFindingsForTask, getBlockingReworkFindingsForTask, applyReworkResolutions, } from "../gsd-db.js";
 import { getWorkflowDatabasePath, ensureWorkflowDbAtPath } from "../db-workspace.js";
 import { getGatesForTurn } from "../gate-registry.js";
-import { gsdProjectionRoot, clearPathCache, resolveMilestonePath, resolveSlicePath } from "../paths.js";
+import { buildFlatTaskFileName, buildTaskFileName, gsdProjectionRoot, clearPathCache, legacyMilestonesDir, resolveMilestonePath, resolveSlicePath, } from "../paths.js";
 import { resolveCanonicalMilestoneRoot } from "../worktree-manager.js";
 import { checkOwnership, taskUnitKey } from "../unit-ownership.js";
 import { saveFile, clearParseCache } from "../files.js";
@@ -34,13 +34,20 @@ function taskSummaryPath(basePath, milestoneId, sliceId, taskId) {
     // a legacy layout and breaks all subsequent path resolution for the session.
     const slicePath = resolveSlicePath(basePath, milestoneId, sliceId);
     const phaseDir = resolveMilestonePath(basePath, milestoneId);
-    if (slicePath && phaseDir && slicePath !== phaseDir) {
-        // Legacy layout: the slice has its own slices/SID/ subdir → tasks/ subdir
-        return join(slicePath, "tasks", `${taskId}-SUMMARY.md`);
+    const legacyBase = legacyMilestonesDir(basePath);
+    const isLegacy = phaseDir
+        ? phaseDir.startsWith(legacyBase + "/") || phaseDir.startsWith(legacyBase + "\\")
+        : false;
+    if (isLegacy && phaseDir) {
+        // Legacy layout: the slice has its own slices/SID/ subdir → tasks/ subdir.
+        const legacySlicePath = slicePath && slicePath !== phaseDir
+            ? slicePath
+            : join(phaseDir, "slices", sliceId);
+        return join(legacySlicePath, "tasks", buildTaskFileName(taskId, "SUMMARY"));
     }
     if (phaseDir) {
         // Flat-phase: task summaries go in the phase dir (no tasks/ subdir)
-        return join(phaseDir, `${taskId}-SUMMARY.md`);
+        return join(phaseDir, buildFlatTaskFileName(sliceId, taskId, "SUMMARY"));
     }
     // Fallback: legacy hardcoded path (milestone/slice dir not on disk yet)
     return join(gsdProjectionRoot(basePath), "milestones", milestoneId, "slices", sliceId, "tasks", `${taskId}-SUMMARY.md`);
@@ -107,6 +114,44 @@ export function normalizeListParam(value) {
  * Build a TaskRow-shaped object from CompleteTaskParams so the unified
  * renderSummaryContent() can be used at completion time (#2720).
  */
+function normalizeReworkResolution(params) {
+    return (params.reworkResolution ?? []).map((resolution) => ({
+        milestoneId: params.milestoneId,
+        sliceId: params.sliceId,
+        taskId: params.taskId,
+        findingId: resolution.findingId,
+        status: resolution.status,
+        evidence: resolution.evidence,
+        decisionRef: resolution.decisionRef,
+    }));
+}
+function unresolvedReworkError(missingFindingIds) {
+    const plural = missingFindingIds.length === 1 ? "finding" : "findings";
+    return `unresolved blocking rework ${plural}: ${missingFindingIds.join(", ")} — provide reworkResolution entries with status resolved and evidence, or status deferred-with-override with evidence and decisionRef, before completing the task`;
+}
+function satisfiesBlockingReworkFinding(resolution) {
+    if (resolution.evidence.trim().length === 0)
+        return false;
+    if (resolution.status === "resolved")
+        return true;
+    return (resolution.decisionRef ?? "").trim().length > 0;
+}
+/**
+ * Restore rework findings to their pre-completion state.
+ *
+ * The completion transaction flips blocking findings to resolved/
+ * deferred-with-override via applyReworkResolutions. When a later projection
+ * or escalation write fails and we compensate by reverting the task to
+ * `pending`, we must also revert those findings. Otherwise a retry sees no
+ * unresolved blocking findings (getUnresolvedBlockingReworkFindingsForTask
+ * only returns `pending` rows) and completes the task with the blocking gate
+ * silently skipped.
+ */
+function revertAppliedReworkResolutions(snapshot) {
+    if (snapshot.length === 0)
+        return;
+    applyReworkResolutions(snapshot);
+}
 function paramsToTaskRow(params, completedAt) {
     return {
         milestone_id: params.milestoneId,
@@ -182,6 +227,7 @@ export async function handleCompleteTask(params, basePath) {
     let guardError = null;
     let summaryMd = "";
     let repairTaskSummaryRow = null;
+    let appliedReworkSnapshot = [];
     const rollbackDbPath = getWorkflowDatabasePath();
     // ── ADR-011 Phase 2: validate escalation payload BEFORE any side effects ─
     // Building the artifact runs the full shape validation (2-4 options, unique
@@ -192,6 +238,7 @@ export async function handleCompleteTask(params, basePath) {
     // no escalation recorded, and the loop would silently advance past it.
     // The filesystem write happens later (after side effects) because that's
     // the cheapest ordering and validation is where 99% of failures live.
+    const reworkResolutions = normalizeReworkResolution(params);
     let validatedEscalationArtifact = null;
     let escalationWriteEnabled = false;
     if (params.escalation) {
@@ -231,6 +278,17 @@ export async function handleCompleteTask(params, basePath) {
             return;
         }
         const existingTask = getTask(params.milestoneId, params.sliceId, params.taskId);
+        const unresolvedRework = getUnresolvedBlockingReworkFindingsForTask(params.milestoneId, params.sliceId, params.taskId);
+        const resolvedFindingIds = new Set(reworkResolutions
+            .filter(satisfiesBlockingReworkFinding)
+            .map((resolution) => resolution.findingId));
+        const missingFindingIds = unresolvedRework
+            .filter((finding) => !resolvedFindingIds.has(finding.finding_id))
+            .map((finding) => finding.finding_id);
+        if (missingFindingIds.length > 0) {
+            guardError = unresolvedReworkError(missingFindingIds);
+            return;
+        }
         if (existingTask && isClosedStatus(existingTask.status)) {
             // Stale-turn path: a timed-out turn that was superseded by recovery
             // can still reach this code when its LLM call eventually returns and
@@ -278,6 +336,33 @@ export async function handleCompleteTask(params, basePath) {
             keyDecisions: params.keyDecisions ?? [],
             fullSummaryMd: summaryMd,
         });
+        // Only persist resolutions that actually satisfy the evidence
+        // requirement. The guard above admits a finding as long as ONE satisfying
+        // entry exists, but applyReworkResolutions writes by findingId and lets the
+        // last entry win. Persisting every entry would let a later non-satisfying
+        // duplicate (empty evidence, or deferred-with-override without decisionRef)
+        // overwrite a valid resolution and leave the finding non-pending without
+        // acceptable evidence. Filtering with the same predicate the guard uses
+        // keeps the applied set and the gate consistent.
+        const resolutionsToApply = reworkResolutions.filter(satisfiesBlockingReworkFinding);
+        if (resolutionsToApply.length > 0) {
+            // Snapshot the pre-resolution state of the findings we're about to
+            // change so a compensating rollback can restore them exactly (see
+            // revertAppliedReworkResolutions).
+            const resolvedFindingIdsForSnapshot = new Set(resolutionsToApply.map((r) => r.findingId));
+            appliedReworkSnapshot = getBlockingReworkFindingsForTask(params.milestoneId, params.sliceId, params.taskId)
+                .filter((finding) => resolvedFindingIdsForSnapshot.has(finding.finding_id))
+                .map((finding) => ({
+                milestoneId: params.milestoneId,
+                sliceId: params.sliceId,
+                taskId: params.taskId,
+                findingId: finding.finding_id,
+                status: finding.status,
+                evidence: finding.evidence,
+                decisionRef: finding.decision_ref,
+            }));
+            applyReworkResolutions(resolutionsToApply);
+        }
         for (const evidence of (params.verificationEvidence ?? [])) {
             insertVerificationEvidence({
                 taskId: params.taskId,
@@ -340,6 +425,7 @@ export async function handleCompleteTask(params, basePath) {
             ensureWorkflowDbAtPath(rollbackDbPath);
             deleteVerificationEvidence(params.milestoneId, params.sliceId, params.taskId);
             updateTaskStatus(params.milestoneId, params.sliceId, params.taskId, "pending");
+            revertAppliedReworkResolutions(appliedReworkSnapshot);
             invalidateStateCache();
             rollbackSucceeded = true;
         }
@@ -430,6 +516,7 @@ export async function handleCompleteTask(params, basePath) {
                 try {
                     deleteVerificationEvidence(params.milestoneId, params.sliceId, params.taskId);
                     updateTaskStatus(params.milestoneId, params.sliceId, params.taskId, 'pending');
+                    revertAppliedReworkResolutions(appliedReworkSnapshot);
                     invalidateStateCache();
                     logWarning("tool", `complete-task rolled back DB completion for ${params.milestoneId}/${params.sliceId}/${params.taskId} after escalation write failure; SUMMARY.md left on disk for retry.`);
                 }
@@ -447,6 +534,7 @@ export async function handleCompleteTask(params, basePath) {
             try {
                 deleteVerificationEvidence(params.milestoneId, params.sliceId, params.taskId);
                 updateTaskStatus(params.milestoneId, params.sliceId, params.taskId, 'pending');
+                revertAppliedReworkResolutions(appliedReworkSnapshot);
                 invalidateStateCache();
                 logWarning("tool", `complete-task rolled back DB completion for ${params.milestoneId}/${params.sliceId}/${params.taskId} because hard-blocker escalation handling is disabled; SUMMARY.md left on disk for retry.`);
             }

package/dist/resources/extensions/gsd/tools/plan-task.js

@@ -5,7 +5,7 @@ import { getGateIdsForTurn } from "../gate-registry.js";
 import { transaction, getSlice, getTask, insertTask, upsertTaskPlanning, insertGateRow, setSliceSketchFlag } from "../gsd-db.js";
 import { invalidateStateCache } from "../state.js";
 import { renderTaskPlanFromDb, renderPlanFromDb } from "../markdown-renderer.js";
-import { resolveTasksDir } from "../paths.js";
+import { resolveMilestonePath, resolveSlicePath } from "../paths.js";
 import { flushWorkflowProjections } from "../projection-flush.js";
 import { writeManifest } from "../workflow-manifest.js";
 import { appendEvent } from "../workflow-events.js";
@@ -193,21 +193,19 @@ export async function handlePlanTask(rawParams, basePath) {
         return { error: guardError };
     }
     try {
-        const renderResult = await renderTaskPlanFromDb(basePath, params.milestoneId, params.sliceId, params.taskId);
-        // Flat-phase: tasks live as checkboxes in the slice plan's <tasks> block,
-        // not as standalone TID-PLAN.md files. Re-render the slice plan so the
-        // new/updated task appears in the plan file that gsd-core reads.
-        // Guard: resolveTasksDir is null in flat-phase (no tasks/ subdir exists).
+        const milestonePath = resolveMilestonePath(basePath, params.milestoneId);
+        const slicePath = resolveSlicePath(basePath, params.milestoneId, params.sliceId);
+        const isLegacySliceLayout = Boolean(milestonePath && slicePath && slicePath !== milestonePath);
+        let renderedPath;
         let slicePlanSynced = false;
-        try {
-            const tDir = resolveTasksDir(basePath, params.milestoneId, params.sliceId);
-            if (!tDir) {
-                await renderPlanFromDb(basePath, params.milestoneId, params.sliceId);
-                slicePlanSynced = true;
-            }
+        if (isLegacySliceLayout) {
+            const renderResult = await renderTaskPlanFromDb(basePath, params.milestoneId, params.sliceId, params.taskId);
+            renderedPath = renderResult.taskPlanPath;
         }
-        catch (syncErr) {
-            logWarning("tool", `plan-task: slice-plan sync failed: ${syncErr.message}`);
+        else {
+            const renderResult = await renderPlanFromDb(basePath, params.milestoneId, params.sliceId);
+            renderedPath = renderResult.planPath;
+            slicePlanSynced = true;
         }
         if (slicePlanSynced) {
             setSliceSketchFlag(params.milestoneId, params.sliceId, false);
@@ -234,7 +232,7 @@ export async function handlePlanTask(rawParams, basePath) {
             milestoneId: params.milestoneId,
             sliceId: params.sliceId,
             taskId: params.taskId,
-            taskPlanPath: renderResult.taskPlanPath,
+            taskPlanPath: renderedPath,
         };
     }
     catch (err) {

package/dist/resources/extensions/gsd/tools/reassess-roadmap.js

@@ -1,6 +1,6 @@
 import { existsSync, unlinkSync } from "node:fs";
-import { join } from "node:path";
-import { relSliceFile, resolveMilestoneFile, resolveMilestonePath, targetMilestoneFile } from "../paths.js";
+import { join, relative } from "node:path";
+import { gsdProjectionRoot, gsdRoot, resolveMilestoneFile, resolveMilestonePath, targetMilestoneFile } from "../paths.js";
 import { clearParseCache } from "../files.js";
 import { isClosedStatus } from "../status-guards.js";
 import { isNonEmptyString } from "../validation.js";
@@ -11,6 +11,14 @@ import { flushWorkflowProjections } from "../projection-flush.js";
 import { writeManifest } from "../workflow-manifest.js";
 import { appendEvent } from "../workflow-events.js";
 import { logWarning } from "../workflow-logger.js";
+function assessmentDbPathForRenderedFile(basePath, absPath) {
+    const projectionRoot = gsdProjectionRoot(basePath);
+    const projectionRel = relative(projectionRoot, absPath);
+    const root = projectionRel && !projectionRel.startsWith("..") && !projectionRel.startsWith("/")
+        ? projectionRoot
+        : gsdRoot(basePath);
+    return `.gsd/${relative(root, absPath).replace(/\\/g, "/")}`;
+}
 function validateParams(params) {
     if (!isNonEmptyString(params?.milestoneId))
         throw new Error("milestoneId is required");
@@ -74,10 +82,6 @@ export async function handleReassessRoadmap(rawParams, basePath) {
     catch (err) {
         return { error: `validation failed: ${err.message}` };
     }
-    // ── Compute assessment artifact path ──────────────────────────────
-    // Assessment lives in the completed slice's directory.
-    // Use relSliceFile so the path is layout-aware (flat-phase or legacy).
-    const assessmentRelPath = relSliceFile(basePath, params.milestoneId, params.completedSliceId, "ASSESSMENT");
     // ── Guards + DB writes inside a single transaction (prevents TOCTOU) ───
     // Guards must be inside the transaction so the state they check cannot
     // change between the read and the write (#2723).
@@ -152,15 +156,6 @@ export async function handleReassessRoadmap(rawParams, basePath) {
                     }
                 }
             }
-            // Record assessment
-            insertAssessment({
-                path: assessmentRelPath,
-                milestoneId: params.milestoneId,
-                sliceId: params.completedSliceId,
-                status: params.verdict,
-                scope: "roadmap",
-                fullContent: params.assessment,
-            });
             // Apply slice modifications
             for (const mod of params.sliceChanges.modified) {
                 updateSliceFields(params.milestoneId, mod.sliceId, {
@@ -220,6 +215,14 @@ export async function handleReassessRoadmap(rawParams, basePath) {
             assessment: params.assessment,
             completedSliceId: params.completedSliceId,
         });
+        insertAssessment({
+            path: assessmentDbPathForRenderedFile(basePath, assessmentResult.assessmentPath),
+            milestoneId: params.milestoneId,
+            sliceId: params.completedSliceId,
+            status: params.verdict,
+            scope: "roadmap",
+            fullContent: params.assessment,
+        });
         // ── Remove stale VALIDATION file from disk (#2957) ────────────
         const hasStructuralChanges = params.sliceChanges.added.length > 0 ||
             params.sliceChanges.modified.length > 0 ||

package/dist/resources/extensions/gsd/tools/reopen-milestone.js

@@ -16,7 +16,7 @@ import { logWarning } from "../workflow-logger.js";
 import { debugLog } from "../debug-logger.js";
 import { existsSync, unlinkSync } from "node:fs";
 import { join } from "node:path";
-import { resolveMilestonePath, resolveSlicePath, resolveTasksDir, clearPathCache } from "../paths.js";
+import { buildFlatTaskFileName, buildTaskFileName, legacyMilestonesDir, resolveMilestonePath, resolveSlicePath, resolveTasksDir, clearPathCache, } from "../paths.js";
 export async function handleReopenMilestone(params, basePath) {
     // ── Validate required fields ────────────────────────────────────────────
     if (!params.milestoneId || typeof params.milestoneId !== "string" || params.milestoneId.trim() === "") {
@@ -41,6 +41,8 @@ export async function handleReopenMilestone(params, basePath) {
     // auto-corrects entities back to "complete", making reopen a no-op (#3161).
     try {
         const milestoneDir = resolveMilestonePath(basePath, params.milestoneId);
+        const legacyBase = legacyMilestonesDir(basePath);
+        const isLegacy = !!milestoneDir && (milestoneDir.startsWith(legacyBase + "/") || milestoneDir.startsWith(legacyBase + "\\"));
         if (milestoneDir) {
             const milestoneSummary = join(milestoneDir, `${params.milestoneId}-SUMMARY.md`);
             if (existsSync(milestoneSummary))
@@ -58,10 +60,17 @@ export async function handleReopenMilestone(params, basePath) {
                     unlinkSync(sliceUat);
             }
             const tasksDir = resolveTasksDir(basePath, params.milestoneId, slice.id);
-            if (tasksDir) {
-                const tasks = getSliceTasks(params.milestoneId, slice.id);
-                for (const task of tasks) {
-                    const taskSummary = join(tasksDir, `${task.id}-SUMMARY.md`);
+            const tasks = getSliceTasks(params.milestoneId, slice.id);
+            for (const task of tasks) {
+                const taskSummaries = isLegacy
+                    ? (tasksDir ? [join(tasksDir, buildTaskFileName(task.id, "SUMMARY"))] : [])
+                    : milestoneDir
+                        ? [
+                            join(milestoneDir, buildFlatTaskFileName(slice.id, task.id, "SUMMARY")),
+                            join(milestoneDir, buildTaskFileName(task.id, "SUMMARY")),
+                        ]
+                        : [];
+                for (const taskSummary of taskSummaries) {
                     if (existsSync(taskSummary))
                         unlinkSync(taskSummary);
                 }

package/dist/resources/extensions/gsd/tools/reopen-slice.js

@@ -22,7 +22,7 @@ import { appendEvent } from "../workflow-events.js";
 import { logWarning } from "../workflow-logger.js";
 import { existsSync, unlinkSync } from "node:fs";
 import { join } from "node:path";
-import { resolveTasksDir, resolveSlicePath, clearPathCache } from "../paths.js";
+import { buildFlatTaskFileName, buildTaskFileName, legacyMilestonesDir, resolveMilestonePath, resolveTasksDir, resolveSlicePath, clearPathCache, } from "../paths.js";
 export async function handleReopenSlice(params, basePath) {
     // ── Validate required fields ────────────────────────────────────────────
     if (!params.sliceId || typeof params.sliceId !== "string" || params.sliceId.trim() === "") {
@@ -52,11 +52,21 @@ export async function handleReopenSlice(params, basePath) {
     // Without this, the DB-filesystem reconciler sees SUMMARY.md files and
     // auto-corrects tasks back to "complete", making reopen a no-op (#3161).
     try {
+        const milestoneDir = resolveMilestonePath(basePath, params.milestoneId);
+        const legacyBase = legacyMilestonesDir(basePath);
+        const isLegacy = !!milestoneDir && (milestoneDir.startsWith(legacyBase + "/") || milestoneDir.startsWith(legacyBase + "\\"));
         const tasksDir = resolveTasksDir(basePath, params.milestoneId, params.sliceId);
-        if (tasksDir) {
-            const tasks = getSliceTasks(params.milestoneId, params.sliceId);
-            for (const task of tasks) {
-                const summaryPath = join(tasksDir, `${task.id}-SUMMARY.md`);
+        const tasks = getSliceTasks(params.milestoneId, params.sliceId);
+        for (const task of tasks) {
+            const summaryPaths = isLegacy
+                ? (tasksDir ? [join(tasksDir, buildTaskFileName(task.id, "SUMMARY"))] : [])
+                : milestoneDir
+                    ? [
+                        join(milestoneDir, buildFlatTaskFileName(params.sliceId, task.id, "SUMMARY")),
+                        join(milestoneDir, buildTaskFileName(task.id, "SUMMARY")),
+                    ]
+                    : [];
+            for (const summaryPath of summaryPaths) {
                 if (existsSync(summaryPath))
                     unlinkSync(summaryPath);
             }

package/dist/resources/extensions/gsd/tools/reopen-task.js

@@ -17,8 +17,8 @@ import { appendEvent } from "../workflow-events.js";
 import { logWarning } from "../workflow-logger.js";
 import { writeReopenReason } from "../reopen-reason.js";
 import { existsSync, unlinkSync } from "node:fs";
-import { join, basename, dirname } from "node:path";
-import { resolveTasksDir, resolveSlicePath, clearPathCache } from "../paths.js";
+import { join } from "node:path";
+import { buildFlatTaskFileName, buildTaskFileName, legacyMilestonesDir, resolveMilestonePath, resolveTasksDir, resolveSlicePath, clearPathCache, } from "../paths.js";
 export async function handleReopenTask(params, basePath) {
     // ── Validate required fields ────────────────────────────────────────────
     if (!params.taskId || typeof params.taskId !== "string" || params.taskId.trim() === "") {
@@ -76,14 +76,20 @@ export async function handleReopenTask(params, basePath) {
     // summary cleanup into tasks/ (#1208).
     try {
         const slicePath = resolveSlicePath(basePath, params.milestoneId, params.sliceId);
-        if (slicePath) {
-            const isLegacySlice = basename(dirname(slicePath)) === "slices";
-            const summaryDir = isLegacySlice
-                ? (resolveTasksDir(basePath, params.milestoneId, params.sliceId) ?? slicePath)
-                : slicePath;
-            const summaryPath = join(summaryDir, `${params.taskId}-SUMMARY.md`);
-            if (existsSync(summaryPath))
-                unlinkSync(summaryPath);
+        const milestonePath = resolveMilestonePath(basePath, params.milestoneId);
+        if (milestonePath) {
+            const legacyBase = legacyMilestonesDir(basePath);
+            const isLegacy = milestonePath.startsWith(legacyBase + "/") || milestonePath.startsWith(legacyBase + "\\");
+            const summaryPaths = isLegacy
+                ? [join(resolveTasksDir(basePath, params.milestoneId, params.sliceId) ?? slicePath ?? join(milestonePath, "slices", params.sliceId, "tasks"), buildTaskFileName(params.taskId, "SUMMARY"))]
+                : [
+                    join(milestonePath, buildFlatTaskFileName(params.sliceId, params.taskId, "SUMMARY")),
+                    join(milestonePath, buildTaskFileName(params.taskId, "SUMMARY")),
+                ];
+            for (const summaryPath of summaryPaths) {
+                if (existsSync(summaryPath))
+                    unlinkSync(summaryPath);
+            }
         }
     }
     catch (cleanupErr) {

package/dist/resources/extensions/gsd/tools/replan-task.js

@@ -0,0 +1,128 @@
+import { clearParseCache } from "../files.js";
+import { getSlice, getTask, insertReplanHistory, transaction, upsertTaskPlanning, } from "../gsd-db.js";
+import { invalidateStateCache } from "../state.js";
+import { isClosedStatus } from "../status-guards.js";
+import { isNonEmptyString, validateStringArray } from "../validation.js";
+import { renderPlanFromDb, renderTaskPlanFromDb } from "../markdown-renderer.js";
+import { resolveMilestonePath, resolveSlicePath } from "../paths.js";
+import { flushWorkflowProjections } from "../projection-flush.js";
+import { writeManifest } from "../workflow-manifest.js";
+import { appendEvent } from "../workflow-events.js";
+import { logWarning } from "../workflow-logger.js";
+function validateParams(params) {
+    if (!isNonEmptyString(params?.milestoneId))
+        throw new Error("milestoneId is required");
+    if (!isNonEmptyString(params?.sliceId))
+        throw new Error("sliceId is required");
+    if (!isNonEmptyString(params?.taskId))
+        throw new Error("taskId is required");
+    if (!isNonEmptyString(params?.title))
+        throw new Error("title is required");
+    if (!isNonEmptyString(params?.description))
+        throw new Error("description is required");
+    if (!isNonEmptyString(params?.estimate))
+        throw new Error("estimate is required");
+    if (!isNonEmptyString(params?.verify))
+        throw new Error("verify is required");
+    return {
+        ...params,
+        files: validateStringArray(params.files, "files"),
+        inputs: validateStringArray(params.inputs, "inputs"),
+        expectedOutput: validateStringArray(params.expectedOutput, "expectedOutput"),
+    };
+}
+function replanSummary(params) {
+    const ref = params.reworkBriefRef?.trim();
+    return ref
+        ? `Task ${params.taskId} replanned from rework brief ${ref}`
+        : `Task ${params.taskId} replanned`;
+}
+export async function handleReplanTask(rawParams, basePath) {
+    let params;
+    try {
+        params = validateParams(rawParams);
+    }
+    catch (err) {
+        return { error: `validation failed: ${err.message}` };
+    }
+    let guardError = null;
+    try {
+        transaction(() => {
+            const parentSlice = getSlice(params.milestoneId, params.sliceId);
+            if (!parentSlice) {
+                guardError = `missing parent slice: ${params.milestoneId}/${params.sliceId}`;
+                return;
+            }
+            if (isClosedStatus(parentSlice.status)) {
+                guardError = `cannot replan a task in a closed slice: ${params.sliceId} (status: ${parentSlice.status})`;
+                return;
+            }
+            const task = getTask(params.milestoneId, params.sliceId, params.taskId);
+            if (!task) {
+                guardError = `task not found: ${params.milestoneId}/${params.sliceId}/${params.taskId}`;
+                return;
+            }
+            if (isClosedStatus(task.status)) {
+                guardError = `cannot replan completed task ${params.taskId} — use gsd_task_reopen first`;
+                return;
+            }
+            upsertTaskPlanning(params.milestoneId, params.sliceId, params.taskId, {
+                title: params.title,
+                description: params.description,
+                estimate: params.estimate,
+                files: params.files,
+                verify: params.verify,
+                inputs: params.inputs,
+                expectedOutput: params.expectedOutput,
+                fullPlanMd: params.fullPlanMd,
+            });
+            insertReplanHistory({
+                milestoneId: params.milestoneId,
+                sliceId: params.sliceId,
+                taskId: params.taskId,
+                summary: replanSummary(params),
+                previousArtifactPath: params.reworkBriefRef ?? null,
+            });
+        });
+    }
+    catch (err) {
+        return { error: `db write failed: ${err.message}` };
+    }
+    if (guardError)
+        return { error: guardError };
+    try {
+        const milestonePath = resolveMilestonePath(basePath, params.milestoneId);
+        const slicePath = resolveSlicePath(basePath, params.milestoneId, params.sliceId);
+        const isLegacySliceLayout = Boolean(milestonePath && slicePath && slicePath !== milestonePath);
+        const renderResult = isLegacySliceLayout
+            ? await renderTaskPlanFromDb(basePath, params.milestoneId, params.sliceId, params.taskId)
+            : await renderPlanFromDb(basePath, params.milestoneId, params.sliceId);
+        const taskPlanPath = "taskPlanPath" in renderResult ? renderResult.taskPlanPath : renderResult.planPath;
+        invalidateStateCache();
+        clearParseCache();
+        try {
+            await flushWorkflowProjections(basePath, { milestoneId: params.milestoneId });
+            writeManifest(basePath);
+            appendEvent(basePath, {
+                cmd: "replan-task",
+                params: { milestoneId: params.milestoneId, sliceId: params.sliceId, taskId: params.taskId },
+                ts: new Date().toISOString(),
+                actor: "agent",
+                actor_name: params.actorName,
+                trigger_reason: params.triggerReason,
+            });
+        }
+        catch (hookErr) {
+            logWarning("tool", `replan-task post-mutation hook warning: ${hookErr.message}`);
+        }
+        return {
+            milestoneId: params.milestoneId,
+            sliceId: params.sliceId,
+            taskId: params.taskId,
+            taskPlanPath,
+        };
+    }
+    catch (err) {
+        return { error: `render failed: ${err.message}` };
+    }
+}

package/dist/resources/extensions/gsd/tools/rework-brief.js

@@ -0,0 +1,74 @@
+import { saveReworkBrief } from "../gsd-db.js";
+import { isNonEmptyString, validateStringArray } from "../validation.js";
+function validateFinding(finding, index) {
+    if (!isNonEmptyString(finding?.findingId))
+        throw new Error(`findings[${index}].findingId is required`);
+    if (finding.severity !== "blocking" && finding.severity !== "advisory") {
+        throw new Error(`findings[${index}].severity must be blocking or advisory`);
+    }
+    if (!isNonEmptyString(finding.description))
+        throw new Error(`findings[${index}].description is required`);
+    if (!isNonEmptyString(finding.requiredFix))
+        throw new Error(`findings[${index}].requiredFix is required`);
+    const status = finding.status ?? "pending";
+    if (status !== "pending" && status !== "resolved" && status !== "deferred-with-override") {
+        throw new Error(`findings[${index}].status must be pending, resolved, or deferred-with-override`);
+    }
+    // A blocking finding is only enforced by gsd_task_complete while it is
+    // `pending` (getUnresolvedBlockingReworkFindingsForTask returns pending rows
+    // only). Persisting a blocking finding as resolved/deferred-with-override
+    // at save time therefore bypasses the completion gate entirely, so require
+    // the same justification a reworkResolution would (evidence for `resolved`,
+    // evidence + decisionRef for `deferred-with-override`). Advisory findings do
+    // not gate completion, so their status is left as-is.
+    if (finding.severity === "blocking" && status !== "pending") {
+        if (!isNonEmptyString(finding.evidence)) {
+            throw new Error(`findings[${index}].evidence is required when a blocking finding is saved as ${status}`);
+        }
+        if (status === "deferred-with-override" && !isNonEmptyString(finding.decisionRef)) {
+            throw new Error(`findings[${index}].decisionRef is required when a blocking finding is saved as deferred-with-override`);
+        }
+    }
+    return {
+        ...finding,
+        verificationCommands: validateStringArray(finding.verificationCommands, `findings[${index}].verificationCommands`),
+        status,
+    };
+}
+function validateParams(params) {
+    if (!isNonEmptyString(params?.milestoneId))
+        throw new Error("milestoneId is required");
+    if (!isNonEmptyString(params?.sliceId))
+        throw new Error("sliceId is required");
+    if (!isNonEmptyString(params?.taskId))
+        throw new Error("taskId is required");
+    if (!Array.isArray(params.findings) || params.findings.length === 0) {
+        throw new Error("findings must be a non-empty array");
+    }
+    return {
+        ...params,
+        findings: params.findings.map(validateFinding),
+    };
+}
+export async function handleReworkBriefSave(rawParams) {
+    let params;
+    try {
+        params = validateParams(rawParams);
+    }
+    catch (err) {
+        return { error: `validation failed: ${err.message}` };
+    }
+    try {
+        const { briefId } = saveReworkBrief(params);
+        return {
+            briefId,
+            milestoneId: params.milestoneId,
+            sliceId: params.sliceId,
+            taskId: params.taskId,
+            findingCount: params.findings.length,
+        };
+    }
+    catch (err) {
+        return { error: `db write failed: ${err.message}` };
+    }
+}