@opengsd/gsd-pi 1.8.0 → 1.8.1-dev.897b3c90

package/src/resources/extensions/gsd/migrate/execution.ts

@@ -0,0 +1,136 @@
+// gsd-pi - /gsd migrate execution service.
+// File Purpose: Write migrated .gsd files, import them into the DB, verify projection/readiness, and rollback on failure.
+
+import { ensureDbOpen } from "../bootstrap/dynamic-tools.js";
+import { closeWorkflowDatabase } from "../db-workspace.js";
+import { clearArtifacts, clearDecisions, clearEngineHierarchy, clearRequirements, transaction } from "../gsd-db.js";
+import { migrateFromMarkdown } from "../md-importer.js";
+import { deriveState, invalidateStateCache } from "../state.js";
+import {
+  archiveLegacyPlanningDirectory,
+  verifyMigrationProjection,
+  writeMigrationAudit,
+  type LegacyArchiveResult,
+  type MigrationAuditResult,
+  type MigrationProjectionVerification,
+} from "./audit.js";
+import {
+  prepareMigrationTarget,
+  restoreMigrationTarget,
+  type MigrationBackup,
+} from "./safety.js";
+import { writeGSDDirectory, type MigrationPreview, type WrittenFiles } from "./writer.js";
+import type { GSDProject } from "./types.js";
+
+export type MigrationImportCounts = ReturnType<typeof migrateFromMarkdown>;
+
+export interface MigrationExecutionResult {
+  backup: MigrationBackup;
+  written: WrittenFiles;
+  imported: MigrationImportCounts;
+  legacyArchive: LegacyArchiveResult;
+  verification: MigrationProjectionVerification;
+  audit: MigrationAuditResult;
+}
+
+function assertMigrationImportMatchesPreview(imported: MigrationImportCounts, preview: MigrationPreview): void {
+  const mismatches: string[] = [];
+  if (imported.decisions !== preview.decisions.total) {
+    mismatches.push(`decisions ${imported.decisions}/${preview.decisions.total}`);
+  }
+  if (imported.hierarchy.milestones !== preview.milestoneCount) {
+    mismatches.push(`milestones ${imported.hierarchy.milestones}/${preview.milestoneCount}`);
+  }
+  if (imported.hierarchy.slices !== preview.totalSlices) {
+    mismatches.push(`slices ${imported.hierarchy.slices}/${preview.totalSlices}`);
+  }
+  if (imported.hierarchy.tasks !== preview.totalTasks) {
+    mismatches.push(`tasks ${imported.hierarchy.tasks}/${preview.totalTasks}`);
+  }
+  if (imported.requirements !== preview.requirements.total) {
+    mismatches.push(`requirements ${imported.requirements}/${preview.requirements.total}`);
+  }
+  if (mismatches.length > 0) {
+    throw new Error(`migration DB import verification failed: ${mismatches.join(", ")}`);
+  }
+}
+
+export async function importWrittenMigrationToDb(
+  basePath: string,
+  preview?: MigrationPreview,
+): Promise<MigrationImportCounts> {
+  const opened = await ensureDbOpen(basePath);
+  if (!opened) {
+    throw new Error(`failed to open or create the GSD database at ${basePath}`);
+  }
+
+  const counts = transaction(() => {
+    clearEngineHierarchy();
+    clearArtifacts();
+    clearDecisions();
+    clearRequirements();
+    const imported = migrateFromMarkdown(basePath);
+    if (preview) assertMigrationImportMatchesPreview(imported, preview);
+    return imported;
+  });
+  invalidateStateCache();
+  return counts;
+}
+
+export async function assertMigrationDbReadiness(
+  targetRoot: string,
+  preview: MigrationPreview,
+): Promise<{ phase: string; registry: number }> {
+  invalidateStateCache();
+  const state = await deriveState(targetRoot);
+  const dbUnavailable = state.blockers.some((blocker) => blocker.includes("DB unavailable"));
+  if (dbUnavailable) {
+    throw new Error(`migration DB readiness failed: ${state.blockers.join("; ")}`);
+  }
+  if (state.registry.length !== preview.milestoneCount) {
+    throw new Error(`migration DB readiness failed: registry ${state.registry.length}/${preview.milestoneCount}`);
+  }
+  return {
+    phase: state.phase,
+    registry: state.registry.length,
+  };
+}
+
+export async function executeMigrationWrite(
+  sourcePath: string,
+  targetRoot: string,
+  project: GSDProject,
+  preview: MigrationPreview,
+  startedAt: string = new Date().toISOString(),
+): Promise<MigrationExecutionResult> {
+  const backup = prepareMigrationTarget(targetRoot);
+
+  try {
+    const written = await writeGSDDirectory(project, targetRoot);
+    const legacyArchive = await archiveLegacyPlanningDirectory(sourcePath, targetRoot);
+    const imported = await importWrittenMigrationToDb(targetRoot, preview);
+    const verification = await verifyMigrationProjection(targetRoot, preview);
+    verification.dbReadiness = await assertMigrationDbReadiness(targetRoot, preview);
+    const audit = await writeMigrationAudit({
+      sourcePath,
+      targetRoot,
+      backupPath: backup.backupPath,
+      preview,
+      written,
+      imported,
+      legacyArchive,
+      verification,
+      startedAt,
+      completedAt: new Date().toISOString(),
+    });
+
+    return { backup, written, imported, legacyArchive, verification, audit };
+  } catch (error) {
+    // The import transaction may have committed and the process may hold an
+    // open handle to the target gsd.db; close before the restore replaces the
+    // file on disk, and leave closed so the next open rebinds to the restored file.
+    try { closeWorkflowDatabase(); } catch { /* best-effort: restore must proceed */ }
+    restoreMigrationTarget(backup);
+    throw error;
+  }
+}

package/src/resources/extensions/gsd/migrate/plan.ts

@@ -0,0 +1,101 @@
+// gsd-pi - /gsd migrate planning service.
+// File Purpose: Resolve, validate, parse, transform, preview, and guard a migration before UI confirmation.
+
+import { existsSync } from "node:fs";
+
+import {
+  assertMigrationHasSlices,
+  assertMigrationTargetAvailable,
+  resolveMigrationPaths,
+  type MigrationPaths,
+} from "./safety.js";
+import { parsePlanningDirectory } from "./parser.js";
+import { generatePreview } from "./preview.js";
+import { transformToGSD } from "./transformer.js";
+import { validatePlanningDirectory } from "./validator.js";
+import type { GSDProject, ValidationIssue, ValidationResult } from "./types.js";
+import type { MigrationPreview } from "./writer.js";
+
+export interface SplitValidationIssues {
+  warnings: ValidationIssue[];
+  fatals: ValidationIssue[];
+}
+
+interface MigrationPlanBase extends MigrationPaths {
+  warnings: ValidationIssue[];
+  fatals: ValidationIssue[];
+}
+
+export interface MissingMigrationSourceResult extends MigrationPaths {
+  status: "missing-source";
+}
+
+export interface InvalidMigrationPlanResult extends MigrationPlanBase {
+  status: "invalid";
+  validation: ValidationResult;
+}
+
+export interface BlockedMigrationPlanResult extends MigrationPlanBase {
+  status: "blocked";
+  validation: ValidationResult;
+  message: string;
+}
+
+export interface ReadyMigrationPlanResult extends MigrationPlanBase {
+  status: "ready";
+  validation: ValidationResult;
+  project: GSDProject;
+  preview: MigrationPreview;
+}
+
+export type MigrationPlanResult =
+  | MissingMigrationSourceResult
+  | InvalidMigrationPlanResult
+  | BlockedMigrationPlanResult
+  | ReadyMigrationPlanResult;
+
+export function splitValidationIssues(validation: ValidationResult): SplitValidationIssues {
+  return {
+    warnings: validation.issues.filter((issue) => issue.severity === "warning"),
+    fatals: validation.issues.filter((issue) => issue.severity === "fatal"),
+  };
+}
+
+export async function createMigrationPlan(args: string, cwd: string = process.cwd()): Promise<MigrationPlanResult> {
+  const paths = resolveMigrationPaths(args, cwd);
+  if (!existsSync(paths.sourcePath)) {
+    return { status: "missing-source", ...paths };
+  }
+
+  const validation = await validatePlanningDirectory(paths.sourcePath);
+  const issues = splitValidationIssues(validation);
+  if (!validation.valid) {
+    return { status: "invalid", ...paths, validation, ...issues };
+  }
+
+  const parsed = await parsePlanningDirectory(paths.sourcePath);
+  const project = transformToGSD(parsed);
+  const preview = generatePreview(project);
+
+  try {
+    assertMigrationHasSlices(preview);
+    await assertMigrationTargetAvailable(paths.targetRoot);
+  } catch (error) {
+    return {
+      status: "blocked",
+      ...paths,
+      validation,
+      ...issues,
+      message: error instanceof Error ? error.message : String(error),
+    };
+  }
+
+  return {
+    status: "ready",
+    ...paths,
+    validation,
+    ...issues,
+    project,
+    preview,
+  };
+}

package/src/resources/extensions/gsd/migrate/planning-writer.ts

@@ -11,6 +11,7 @@ import { join, relative } from "node:path";
 
 import { getAllMilestones, getMilestoneSlices, getSliceTasks } from "../gsd-db.js";
 import { saveFile } from "../files.js";
+import { isClosedStatus } from "../status-guards.js";
 import type { PlanningLayout } from "../compat/compat-marker.js";
 import {
   applyPlanningProjectionWrites,
@@ -104,7 +105,7 @@ function formatPlanningPlan(
   phaseNum: number,
   planNum: number,
   title: string,
-  tasks: Array<{ id: string; title: string; estimate?: string }>,
+  tasks: Array<{ id: string; title: string; estimate?: string; done?: boolean }>,
 ): string {
   const lines: string[] = [];
   lines.push(`# ${pad(phaseNum)}-${pad(planNum)}: ${title}`, "");
@@ -115,7 +116,11 @@ function formatPlanningPlan(
   lines.push("<tasks>");
   for (const t of tasks) {
     const est = t.estimate ? ` _(${t.estimate})_` : "";
-    lines.push(`- [ ] **${t.id}**: ${t.title}${est}`);
+    // Render the checkbox from the task's DB status so a DB→.planning
+    // projection preserves completion. Hardcoding `[ ]` here silently reset
+    // every completed historical task to unchecked on each reconcile (#1276).
+    const box = t.done ? "[x]" : "[ ]";
+    lines.push(`- ${box} **${t.id}**: ${t.title}${est}`);
   }
   lines.push("</tasks>");
   lines.push("");
@@ -173,7 +178,7 @@ export async function writePlanningDirectory(
 
       const tasks = getSliceTasks(milestone.id, slice.id);
       const isDone =
-        tasks.length > 0 && tasks.every((t) => t.status === "complete");
+        tasks.length > 0 && tasks.every((t) => isClosedStatus(t.status));
       roadmapEntries.push({
         number: phaseNum,
         title: slice.title || slice.id,
@@ -181,17 +186,14 @@ export async function writePlanningDirectory(
       });
 
       if (tasks.length === 0) {
-        // Empty phase — write a single placeholder plan so the dir isn't empty.
-        const planPath = join(phaseDir, `${pad(phaseNum)}-01-PLAN.md`);
-        await saveFile(
-          planPath,
-          formatPlanningPlan(phaseNum, 1, slice.title || slice.id, []),
-        );
-        paths.push(planPath);
-        projectionWrites.push({
-          relPath: toPlanningRel(planPath),
-          entities: [`${milestone.id}/${slice.id}`],
-        });
+        // Sketch / undecomposed slice — zero tasks. Do NOT emit an ingestible
+        // *-PLAN.md here: the reverse transform maps one GSDTask per plan file
+        // (transformer.ts mapSlice), so a placeholder would materialize a
+        // phantom "Plan NN" task and flip the slice from "needs planning" to
+        // "has a planned task", causing auto-mode to skip planning (issue #1285).
+        // The phase dir is already created (mkdirSync above) and the slice is
+        // listed in ROADMAP.md, so it round-trips with tasks = [] — the correct
+        // sketch-slice shape.
       } else {
         for (let ti = 0; ti < tasks.length; ti++) {
           const task = tasks[ti]!;
@@ -204,6 +206,7 @@ export async function writePlanningDirectory(
                 id: task.id,
                 title: task.title || task.id,
                 estimate: task.estimate || undefined,
+                done: isClosedStatus(task.status),
               },
             ]),
           );
@@ -217,19 +220,14 @@ export async function writePlanningDirectory(
     }
   }
 
-  // If no slices produced any phases, write a single empty phase so ROADMAP.md
-  // isn't blank and the layout is still discoverable.
+  // If no slices produced any phases, emit a single empty phase dir + ROADMAP
+  // entry so the layout stays discoverable. Do NOT write a placeholder
+  // *-PLAN.md — an ingestible plan file would round-trip into a phantom task
+  // (see the tasks.length === 0 branch above, issue #1285).
   if (roadmapEntries.length === 0) {
     const phaseDirName = `${pad(1)}-milestone`;
     const phaseDir = join(root, "phases", phaseDirName);
     mkdirSync(phaseDir, { recursive: true });
-    const planPath = join(phaseDir, `${pad(1)}-01-PLAN.md`);
-    await saveFile(planPath, formatPlanningPlan(1, 1, milestones[0]!.title || milestones[0]!.id, []));
-    paths.push(planPath);
-    projectionWrites.push({
-      relPath: toPlanningRel(planPath),
-      entities: [milestones[0]!.id],
-    });
     roadmapEntries.push({ number: 1, title: milestones[0]!.title || milestones[0]!.id, done: false });
   }
 

package/src/resources/extensions/gsd/migrate/presentation.ts

@@ -0,0 +1,83 @@
+// gsd-pi - /gsd migrate presentation helpers.
+// File Purpose: Pure formatting for migration previews and post-write review prompts.
+
+import { existsSync, readFileSync } from "node:fs";
+import { dirname, join } from "node:path";
+import { fileURLToPath } from "node:url";
+
+import { gsdRoot } from "../paths.js";
+import type { MigrationPreview } from "./writer.js";
+
+export interface ReviewPromptInput {
+  sourcePath: string;
+  gsdPath: string;
+  preview: MigrationPreview;
+  templatePath?: string;
+}
+
+function formatRequirements(preview: MigrationPreview): string | null {
+  if (preview.requirements.total === 0) return null;
+  return `Requirements: ${preview.requirements.total} (${preview.requirements.validated} validated, ${preview.requirements.active} active, ${preview.requirements.deferred} deferred, ${preview.requirements.outOfScope} out of scope)`;
+}
+
+function formatLegacyInputs(preview: MigrationPreview): string | null {
+  if (!preview.migrationInputs) return null;
+  return `Legacy inputs: ${preview.migrationInputs.milestonePhaseDirs} milestone phase dir(s), ${preview.migrationInputs.decisions} decision file(s), ${preview.migrationInputs.seeds} seed file(s)`;
+}
+
+export function buildMigrationPreviewSummary(preview: MigrationPreview, targetRoot: string): string[] {
+  const lines: string[] = [
+    `Decisions: ${preview.decisions.total}`,
+    `Milestones: ${preview.milestoneCount}`,
+    `Slices: ${preview.totalSlices} (${preview.doneSlices} done — ${preview.sliceCompletionPct}%)`,
+    `Tasks: ${preview.totalTasks} (${preview.doneTasks} done — ${preview.taskCompletionPct}%)`,
+  ];
+
+  const requirements = formatRequirements(preview);
+  if (requirements) lines.push(requirements);
+
+  const legacyInputs = formatLegacyInputs(preview);
+  if (legacyInputs) lines.push(legacyInputs);
+
+  const targetGsdPath = gsdRoot(targetRoot);
+  if (existsSync(targetGsdPath)) {
+    lines.push("");
+    lines.push(`⚠ A .gsd directory already exists at ${targetGsdPath}.`);
+    lines.push("It will be backed up, deleted, and rewritten fresh before DB import.");
+  }
+
+  return lines;
+}
+
+export function formatMigrationPreviewStats(preview: MigrationPreview): string {
+  const lines = [
+    `- Decisions: ${preview.decisions.total}`,
+    `- Milestones: ${preview.milestoneCount}`,
+    `- Slices: ${preview.totalSlices} (${preview.doneSlices} done — ${preview.sliceCompletionPct}%)`,
+    `- Tasks: ${preview.totalTasks} (${preview.doneTasks} done — ${preview.taskCompletionPct}%)`,
+  ];
+
+  const requirements = formatRequirements(preview);
+  if (requirements) lines.push(`- ${requirements}`);
+
+  const legacyInputs = formatLegacyInputs(preview);
+  if (legacyInputs) lines.push(`- ${legacyInputs}`);
+
+  return lines.join("\n");
+}
+
+function defaultReviewTemplatePath(): string {
+  const promptsDir = join(dirname(fileURLToPath(import.meta.url)), "..", "prompts");
+  return join(promptsDir, "review-migration.md");
+}
+
+export function buildReviewPrompt(input: ReviewPromptInput): string {
+  const templatePath = input.templatePath ?? defaultReviewTemplatePath();
+  let content = readFileSync(templatePath, "utf-8");
+
+  content = content.replaceAll("{{sourcePath}}", input.sourcePath);
+  content = content.replaceAll("{{gsdPath}}", input.gsdPath);
+  content = content.replaceAll("{{previewStats}}", formatMigrationPreviewStats(input.preview));
+
+  return content.trim();
+}

package/src/resources/extensions/gsd/migration-auto-check.ts

@@ -169,6 +169,9 @@ export function scanMarkdownHierarchy(basePath: string): HierarchyScan {
 
     for (const slice of roadmap.slices) {
       scan.slices.add(`${milestoneId}/${slice.id}`);
+      // Sketch slices carry only a stub PLAN until refined; match migrateHierarchyToDb
+      // and do not count placeholder tasks from the <tasks> block (#1286).
+      if (slice.isSketch) continue;
       const planPath = resolveSliceFile(basePath, milestoneId, slice.id, "PLAN");
       if (!planPath || !existsSync(planPath)) continue;
       const plan = parsePlan(readFileSync(planPath, "utf-8"));

package/src/resources/extensions/gsd/parallel-eligibility.ts

@@ -8,7 +8,7 @@
 import { deriveState } from "./state.js";
 import { resolveMilestoneFile, resolveSliceFile } from "./paths.js";
 import { findMilestoneIds } from "./guided-flow.js";
-import { isDbAvailable, getMilestoneSlices, getSliceTasks } from "./gsd-db.js";
+import { isDbAvailable, getMilestoneSlices, getTasksBySliceIds } from "./gsd-db.js";
 import { openExistingWorkflowDatabase } from "./db-workspace.js";
 import type { MilestoneRegistryEntry } from "./types.js";
 
@@ -40,10 +40,11 @@ async function collectTouchedFiles(
   const files = new Set<string>();
 
   if (isDbAvailable()) {
-    // DB path: query slices and their tasks for file lists
+    // DB path: query slices and their tasks for file lists (one batched task
+    // query instead of one per slice; file order is irrelevant here — Set dedup)
     const slices = getMilestoneSlices(milestoneId);
-    for (const slice of slices) {
-      const tasks = getSliceTasks(milestoneId, slice.id);
+    const tasksBySlice = getTasksBySliceIds(slices.map((slice) => ({ milestoneId, sliceId: slice.id })));
+    for (const tasks of tasksBySlice.values()) {
       for (const task of tasks) {
         if (Array.isArray(task.files)) {
           for (const f of task.files) {

package/src/resources/extensions/gsd/parallel-monitor-overlay.ts

@@ -72,6 +72,7 @@ interface WorkerView {
   totalSlices: number;
   doneSlices: number;
   slices: SliceProgress[];
+  completions: string[];
   errors: string[];
 }
 
@@ -143,14 +144,21 @@ function discoverWorkers(basePath: string): string[] {
   return [...mids].sort();
 }
 
-function querySliceProgress(basePath: string, mid: string, workRoot: string = worktreePathFor(basePath, mid)): SliceProgress[] {
+// Slice progress + recent completions share one DB connection per worker per
+// tick. Opening the isolated worker DB twice per refresh (once for each) was
+// pure churn on the 5s interval.
+function queryWorkerProgress(
+  basePath: string,
+  mid: string,
+  workRoot: string = worktreePathFor(basePath, mid),
+): { slices: SliceProgress[]; completions: string[] } {
   const dbPath = resolveGsdPathContract(workRoot, basePath).projectDb;
-  if (!existsSync(dbPath)) return [];
+  if (!existsSync(dbPath)) return { slices: [], completions: [] };
 
   const db = openWorkflowDatabaseIsolated(dbPath);
-  if (!db) return [];
+  if (!db) return { slices: [], completions: [] };
   try {
-    const rows = db.prepare(
+    const sliceRows = db.prepare(
       `SELECT
          s.id AS id,
          s.status AS status,
@@ -162,14 +170,32 @@ function querySliceProgress(basePath: string, mid: string, workRoot: string = wo
        GROUP BY s.id
        ORDER BY s.id`,
     ).all({ ":mid": mid });
-    return rows.map((row) => ({
+    const slices = sliceRows.map((row) => ({
       id: String(row["id"] ?? ""),
       status: String(row["status"] ?? ""),
       total: Number(row["total"] ?? 0),
       done: Number(row["done"] ?? 0),
     }));
+
+    const completionRows = db.prepare(
+      `SELECT id, slice_id, one_liner
+       FROM tasks
+       WHERE milestone_id=:mid
+         AND status='complete'
+         AND completed_at IS NOT NULL
+       ORDER BY completed_at DESC
+       LIMIT 5`,
+    ).all({ ":mid": mid });
+    const completions = completionRows.map((row) => {
+      const taskId = String(row["id"] ?? "");
+      const sliceId = String(row["slice_id"] ?? "");
+      const oneLiner = String(row["one_liner"] ?? "");
+      return `✓ ${mid}/${sliceId}/${taskId}${oneLiner ? ": " + oneLiner : ""}`;
+    });
+
+    return { slices, completions };
   } catch {
-    return [];
+    return { slices: [], completions: [] };
   } finally {
     try { db.close(); } catch { /* ignore */ }
   }
@@ -276,36 +302,6 @@ function extractCostFromNdjson(basePath: string, mid: string): number {
   }
 }
 
-function queryRecentCompletions(basePath: string, mid: string): string[] {
-  const workRoot = worktreePathFor(basePath, mid);
-  const dbPath = resolveGsdPathContract(workRoot, basePath).projectDb;
-  if (!existsSync(dbPath)) return [];
-
-  const db = openWorkflowDatabaseIsolated(dbPath);
-  if (!db) return [];
-  try {
-    const rows = db.prepare(
-      `SELECT id, slice_id, one_liner
-       FROM tasks
-       WHERE milestone_id=:mid
-         AND status='complete'
-         AND completed_at IS NOT NULL
-       ORDER BY completed_at DESC
-       LIMIT 5`,
-    ).all({ ":mid": mid });
-    return rows.map((row) => {
-      const taskId = String(row["id"] ?? "");
-      const sliceId = String(row["slice_id"] ?? "");
-      const oneLiner = String(row["one_liner"] ?? "");
-      return `✓ ${mid}/${sliceId}/${taskId}${oneLiner ? ": " + oneLiner : ""}`;
-    });
-  } catch {
-    return [];
-  } finally {
-    try { db.close(); } catch { /* ignore */ }
-  }
-}
-
 function collectWorkerData(basePath: string): WorkerView[] {
   const mids = discoverWorkers(basePath);
   const parallelDir = join(basePath, ".gsd", "parallel");
@@ -317,7 +313,7 @@ function collectWorkerData(basePath: string): WorkerView[] {
     const workRoot = worktreePathFor(basePath, mid);
     const status = readJsonSafe<StatusJson>(join(parallelDir, `${mid}.status.json`));
     const lock = readJsonSafe<AutoLock>(join(workRoot, ".gsd", "auto.lock"));
-    const slices = querySliceProgress(basePath, mid, workRoot);
+    const { slices, completions } = queryWorkerProgress(basePath, mid, workRoot);
 
     const pid = lock?.pid || status?.pid || 0;
     const alive = pid ? isPidAlive(pid) : false;
@@ -378,6 +374,7 @@ function collectWorkerData(basePath: string): WorkerView[] {
       totalSlices: slices.length,
       doneSlices,
       slices,
+      completions,
       errors,
     });
   }
@@ -443,10 +440,10 @@ export class ParallelMonitorOverlay {
     if (this.disposed) return;
     this.workers = collectWorkerData(this.basePath);
 
-    // Collect completion events
+    // Collect completion events (already read during collectWorkerData's single
+    // DB open per worker — no second connection here).
     for (const wk of this.workers) {
-      const completions = queryRecentCompletions(this.basePath, wk.mid);
-      for (const evt of completions) {
+      for (const evt of wk.completions) {
         if (!this.events.includes(evt)) this.events.push(evt);
       }
     }

package/src/resources/extensions/gsd/paths.ts

@@ -618,17 +618,20 @@ function legacyMilestonesHasSubdirs(basePath: string): boolean {
  * See the matching TODO in markdown-renderer.ts detectStaleRenders, which
  * disabled stale-render detection for the same reason.
  */
+const LEGACY_MILESTONE_RUNTIME_DIRS = new Set(["anchors"]);
+
 export function dirIsContentBearingLegacyMilestone(dir: string): boolean {
   try {
     const entries = readdirSync(dir, { withFileTypes: true });
     // 1. Any non-META regular file → real legacy content.
     if (entries.some(e => e.isFile() && !e.name.endsWith("-META.json"))) return true;
-    // 2. A non-empty subdirectory → real legacy content (e.g. slices/ with slice dirs).
+    // 2. A non-empty non-runtime subdirectory → real legacy content (e.g. slices/ with slice dirs).
     //    An *empty* subdir is treated as scaffolding (e.g. git-service.ts may create
     //    an empty slices/ alongside the integration META file) and must NOT flip the
     //    layout — that is the Bugbot finding this guard addresses.
     return entries.some(e => {
       if (!e.isDirectory()) return false;
+      if (LEGACY_MILESTONE_RUNTIME_DIRS.has(e.name)) return false;
       try { return readdirSync(join(dir, e.name)).length > 0; } catch { return false; }
     });
   } catch {

package/src/resources/extensions/gsd/phase-anchor.ts

@@ -19,13 +19,17 @@ export interface PhaseAnchor {
 }
 
 function anchorsDir(basePath: string, milestoneId: string): string {
-  return join(gsdRoot(basePath), "milestones", milestoneId, "anchors");
+  return join(gsdRoot(basePath), "runtime", "anchors", milestoneId);
 }
 
 function anchorPath(basePath: string, milestoneId: string, phase: string): string {
   return join(anchorsDir(basePath, milestoneId), `${phase}.json`);
 }
 
+function legacyAnchorPath(basePath: string, milestoneId: string, phase: string): string {
+  return join(gsdRoot(basePath), "milestones", milestoneId, "anchors", `${phase}.json`);
+}
+
 export function writePhaseAnchor(basePath: string, milestoneId: string, anchor: PhaseAnchor): void {
   const dir = anchorsDir(basePath, milestoneId);
   if (!existsSync(dir)) {
@@ -35,7 +39,9 @@ export function writePhaseAnchor(basePath: string, milestoneId: string, anchor:
 }
 
 export function readPhaseAnchor(basePath: string, milestoneId: string, phase: string): PhaseAnchor | null {
-  const path = anchorPath(basePath, milestoneId, phase);
+  const path = existsSync(anchorPath(basePath, milestoneId, phase))
+    ? anchorPath(basePath, milestoneId, phase)
+    : legacyAnchorPath(basePath, milestoneId, phase);
   if (!existsSync(path)) return null;
   try {
     return JSON.parse(readFileSync(path, "utf-8")) as PhaseAnchor;

package/src/resources/extensions/gsd/post-execution-checks.ts

@@ -318,12 +318,12 @@ export function checkImportResolution(
     const imports = extractRelativeImports(source);
 
     for (const { importPath, lineNum } of imports) {
-      // Framework-generated type modules may not exist on disk during post-exec
-      // checks (typically generated during framework builds/typegen). Don't
-      // block task completion on these imports.
+      // Framework/codegen-generated modules may not exist on disk during
+      // post-exec checks. Don't block task completion on these imports.
       if (
         /^\.{1,2}\/\+types\//.test(importPath) ||
-        /^(?:\.{1,2}\/)+(?:[^/]+\/)*\$types(?:$|\/)/.test(importPath)
+        /^(?:\.{1,2}\/)+(?:[^/]+\/)*\$types(?:$|\/)/.test(importPath) ||
+        /^(?:\.{1,2}\/)+(?:[^/]+\/)*_generated(?:$|\/)/.test(importPath)
       ) {
         continue;
       }