@opengsd/gsd-pi 1.3.0 → 1.4.0-dev.c18009cd

package/src/resources/extensions/gsd/tests/derive-state-db.test.ts

@@ -1,6 +1,8 @@
 import { describe, test } from 'node:test';
 import assert from 'node:assert/strict';
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from 'node:fs';
+import fs from 'node:fs';
+import { mkdtempSync, mkdirSync, realpathSync, rmSync, writeFileSync } from 'node:fs';
+import { syncBuiltinESMExports } from 'node:module';
 import { join } from 'node:path';
 import { tmpdir } from 'node:os';
 
@@ -254,6 +256,29 @@ describe('derive-state-db', async () => {
     }
   });
 
+  test('derive-state-db: opens existing project DB before querying milestones', async (t) => {
+    const base = createFixtureBase();
+    t.after(() => {
+      closeDatabase();
+      cleanup(base);
+    });
+
+    const dbPath = join(base, '.gsd', 'gsd.db');
+    assert.equal(openDatabase(dbPath), true);
+    insertMilestone({ id: 'M001', title: 'Cold DB Milestone', status: 'active' });
+    insertSlice({ id: 'S01', milestoneId: 'M001', title: 'Ready Slice', status: 'active', risk: 'low', depends: [] });
+    insertTask({ id: 'T01', sliceId: 'S01', milestoneId: 'M001', title: 'Ready Task', status: 'pending' });
+    closeDatabase();
+    assert.equal(isDbAvailable(), false);
+
+    const state = await deriveStateFromDb(base);
+
+    assert.equal(state.activeMilestone?.id, 'M001');
+    assert.equal(state.activeSlice?.id, 'S01');
+    assert.equal(state.activeTask?.id, 'T01');
+    assert.notEqual(state.nextAction, 'No milestones found. Run /gsd to create one.');
+  });
+
   // ─── Test 4: Partial DB content does not fill gaps from disk ──────────
   test('derive-state-db: partial DB does not fill requirements from disk', async () => {
     const base = createFixtureBase();
@@ -1239,6 +1264,43 @@ describe('derive-state-db', async () => {
     }
   });
 
+  test('derive-state-db: missing context resolves milestone directory once', async () => {
+    const base = createFixtureBase();
+    const phaseDir = join(realpathSync.native(base), '.gsd', 'phases', '01-m001');
+    let phaseDirExistsChecks = 0;
+    const mutableFs = fs as { existsSync: typeof fs.existsSync };
+    const originalExistsSync = fs.existsSync;
+    mutableFs.existsSync = ((path) => {
+      if (String(path) === phaseDir) phaseDirExistsChecks += 1;
+      return originalExistsSync(path);
+    }) as typeof fs.existsSync;
+    syncBuiltinESMExports();
+
+    try {
+      mkdirSync(phaseDir, { recursive: true });
+
+      openDatabase(':memory:');
+      insertMilestone({ id: 'M001', title: 'First', status: 'queued' });
+
+      invalidateStateCache();
+      const dbState = await deriveStateFromDb(base);
+
+      assert.equal(dbState.activeMilestone?.id, 'M001', 'single-resolve: queued milestone becomes active');
+      assert.equal(
+        phaseDirExistsChecks,
+        3,
+        'single-resolve: one directory resolve plus two artifact probes re-check the milestone directory via resolveFile',
+      );
+
+      closeDatabase();
+    } finally {
+      mutableFs.existsSync = originalExistsSync;
+      syncBuiltinESMExports();
+      closeDatabase();
+      cleanup(base);
+    }
+  });
+
   // ─── Regression: disk-only milestones synced into DB (#2416) ─────────
   test('derive-state-db: disk-only milestone auto-synced into DB (#2416)', async () => {
     const base = createFixtureBase();

package/src/resources/extensions/gsd/tests/derive-state-helpers.test.ts

@@ -20,6 +20,7 @@ import {
   insertRequirement,
   insertSlice,
   insertTask,
+  getAllMilestones,
   setMilestoneQueueOrder,
   transaction,
   updateTaskStatus,
@@ -445,11 +446,10 @@ describe('derive-state-helpers', () => {
     }
   });
 
-  // ─── Queue order: DB sequence is authoritative ─────────────────────
-  test('deriveStateFromDb ignores QUEUE-ORDER.json and uses DB sequence', async () => {
+  // ─── Queue order: explicit file order repairs stale DB sequence ─────
+  test('deriveStateFromDb syncs QUEUE-ORDER.json into DB sequence', async () => {
     const base = createFixtureBase();
     try {
-      // QUEUE-ORDER.json is a projection and should not drive DB derivation.
       const queueOrder = JSON.stringify({ order: ['M003', 'M001', 'M002'], updatedAt: new Date().toISOString() });
       writeFileSync(join(base, '.gsd', 'QUEUE-ORDER.json'), queueOrder);
       writeFile(base, 'milestones/M001/M001-CONTEXT.md', '# M001\n\nContext.');
@@ -466,8 +466,52 @@ describe('derive-state-helpers', () => {
       invalidateStateCache();
       const state = await deriveStateFromDb(base);
 
-      assert.equal(state.activeMilestone?.id, 'M002', 'queue-order: DB sequence chooses M002');
-      assert.equal(state.registry[0]?.id, 'M002', 'queue-order: registry[0] follows DB sequence');
+      assert.equal(state.activeMilestone?.id, 'M003', 'queue-order: QUEUE-ORDER.json chooses M003');
+      assert.equal(state.registry[0]?.id, 'M003', 'queue-order: registry[0] follows QUEUE-ORDER.json');
+      assert.deepEqual(getAllMilestones().map(m => m.id), ['M003', 'M001', 'M002'], 'queue-order: DB sequence is repaired');
+    } finally {
+      closeDatabase();
+      cleanup(base);
+    }
+  });
+
+  // ─── Queue order: milestone absent from file gets explicit sequence (idempotency) ─
+  test('deriveStateFromDb sync is idempotent when a milestone is omitted from QUEUE-ORDER.json', async () => {
+    const base = createFixtureBase();
+    try {
+      // QUEUE-ORDER.json lists only M002 and M001; M003 is absent.
+      const queueOrder = JSON.stringify({ order: ['M002', 'M001'], updatedAt: new Date().toISOString() });
+      writeFileSync(join(base, '.gsd', 'QUEUE-ORDER.json'), queueOrder);
+      writeFile(base, 'milestones/M001/M001-CONTEXT.md', '# M001\n\nContext.');
+      writeFile(base, 'milestones/M002/M002-CONTEXT.md', '# M002\n\nContext.');
+      writeFile(base, 'milestones/M003/M003-CONTEXT.md', '# M003\n\nContext.');
+
+      openDatabase(':memory:');
+      insertMilestone({ id: 'M001', title: 'First', status: 'active' });
+      insertMilestone({ id: 'M002', title: 'Second', status: 'active' });
+      insertMilestone({ id: 'M003', title: 'Third', status: 'active' });
+      // DB starts with natural order M001→M002→M003 (stale vs the file's M002→M001).
+
+      invalidateStateCache();
+      const state = await deriveStateFromDb(base);
+
+      // After sync, M002 leads (per file), M003 is appended at the end.
+      assert.equal(state.activeMilestone?.id, 'M002', 'omitted-milestone: QUEUE-ORDER.json chooses M002 as active');
+      assert.deepEqual(
+        getAllMilestones().map(m => m.id),
+        ['M002', 'M001', 'M003'],
+        'omitted-milestone: DB sequence is M002, M001, M003 with M003 appended',
+      );
+
+      // Second derive must not re-write the DB (idempotency guard holds).
+      invalidateStateCache();
+      const state2 = await deriveStateFromDb(base);
+      assert.equal(state2.activeMilestone?.id, 'M002', 'omitted-milestone: second derive still picks M002');
+      assert.deepEqual(
+        getAllMilestones().map(m => m.id),
+        ['M002', 'M001', 'M003'],
+        'omitted-milestone: DB sequence unchanged on second call',
+      );
     } finally {
       closeDatabase();
       cleanup(base);

package/src/resources/extensions/gsd/tests/destructive-guard.test.ts

@@ -0,0 +1,44 @@
+import test from "node:test";
+import assert from "node:assert/strict";
+
+import { classifyCommand } from "../safety/destructive-guard.ts";
+
+test("destructive guard ignores rm -rf text inside quoted literals and comments", () => {
+  const readOnlyCommands = [
+    'grep -rn "rm -rf" .',
+    'echo "rm -rf /tmp/x"',
+    'git commit -m "remove stray rm -rf usage"',
+    "cat notes.md  # remove stray rm -rf usage",
+    'printf "rm -rf /tmp/x\\n"',
+  ];
+
+  for (const command of readOnlyCommands) {
+    assert.deepEqual(classifyCommand(command), { destructive: false, labels: [] }, command);
+  }
+});
+
+test("destructive guard still detects direct and wrapper-prefixed recursive deletes", () => {
+  const destructiveCommands = [
+    "rm -rf build",
+    "rm build -rf",
+    "sudo rm -rf /",
+    "doas rm -rf /",
+    "sudo -u bob rm -rf /x",
+    "timeout 5 rm -rf /x",
+    "time rm -rf build",
+    "find . -exec rm -rf {} \\;",
+    "cat doomed.txt | xargs rm -rf /tmp/x",
+    'rm -rf "/tmp/my build"',
+  ];
+
+  for (const command of destructiveCommands) {
+    assert.deepEqual(classifyCommand(command), {
+      destructive: true,
+      labels: ["recursive delete"],
+    }, command);
+  }
+});
+
+test("destructive guard treats quoted interpreter payloads as literals", () => {
+  assert.deepEqual(classifyCommand('bash -c "rm -rf /"'), { destructive: false, labels: [] });
+});

package/src/resources/extensions/gsd/tests/discuss-cold-start-db-open.test.ts

@@ -1,16 +1,13 @@
 /**
  * Behavioural regression test for #5837.
  *
- * /gsd discuss silently exited on cold-start because showDiscuss() derived
- * workflow state before opening the DB. On a cold-start session the DB file
- * exists on disk but is not open in-process, so deriveState() takes the
- * "DB unavailable" branch, reports no active milestone, and showDiscuss()
- * exits as if the project had no milestones.
+ * /gsd discuss and /gsd auto can cold-start with a DB file on disk but no
+ * in-process connection yet. State derivation must open that existing DB
+ * before it decides whether DB-backed state is available.
  *
- * The fix moves `ensureDbOpen(basePath)` ahead of `deriveState()`. This test
- * pins that ordering contract at the behavioural level: with a milestone
- * living only in the DB, deriveState() surfaces nothing until the DB is
- * opened, and surfaces the milestone once ensureDbOpen() has run.
+ * This test pins that behavioural contract: with a milestone living only in
+ * the DB, deriveState() surfaces it even when the process begins with no DB
+ * handle open.
  */
 
 import { describe, test, afterEach } from "node:test";
@@ -19,7 +16,6 @@ import { mkdtempSync, mkdirSync, realpathSync, rmSync } from "node:fs";
 import { join } from "node:path";
 import { tmpdir } from "node:os";
 
-import { ensureDbOpen } from "../bootstrap/dynamic-tools.ts";
 import { openDatabase, closeDatabase, isDbAvailable, insertMilestone } from "../gsd-db.ts";
 import { deriveState, invalidateStateCache } from "../state.ts";
 
@@ -29,7 +25,7 @@ afterEach(() => {
 });
 
 describe("discuss cold-start DB ordering (#5837)", () => {
-  test("deriveState only surfaces a DB-resident milestone after ensureDbOpen runs", async () => {
+  test("deriveState opens an existing DB before reading a DB-resident milestone", async () => {
     const base = realpathSync(mkdtempSync(join(tmpdir(), "gsd-discuss-cold-")));
     try {
       mkdirSync(join(base, ".gsd"), { recursive: true });
@@ -42,26 +38,13 @@ describe("discuss cold-start DB ordering (#5837)", () => {
       closeDatabase();
       invalidateStateCache();
 
-      // Before ensureDbOpen(): showDiscuss's pre-fix ordering. The DB is not
-      // open, so state derivation cannot see the milestone — the silent exit.
       const coldState = await deriveState(base);
       assert.equal(
-        coldState.activeMilestone,
-        null,
-        "without an open DB, deriveState must not surface the milestone — this is the cold-start silent-exit bug",
-      );
-      assert.equal(isDbAvailable(), false, "DB must still be closed before ensureDbOpen");
-
-      // The fix: ensureDbOpen(basePath) runs before deriveState.
-      assert.equal(await ensureDbOpen(base), true, "ensureDbOpen must open the cold-start DB");
-      invalidateStateCache();
-
-      const warmState = await deriveState(base);
-      assert.equal(
-        warmState.activeMilestone?.id,
+        coldState.activeMilestone?.id,
         "M001",
-        "after ensureDbOpen, deriveState must surface the DB-resident milestone so /gsd discuss does not silently exit",
+        "cold-start deriveState must open and read the existing workflow DB",
       );
+      assert.equal(isDbAvailable(), true, "deriveState must leave the existing DB open for downstream reads");
     } finally {
       if (isDbAvailable()) closeDatabase();
       invalidateStateCache();

package/src/resources/extensions/gsd/tests/dispatch-complete-milestone-guard.test.ts

@@ -7,7 +7,7 @@
 
 import { describe, test, afterEach } from "node:test";
 import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from "node:fs";
+import { existsSync, mkdtempSync, mkdirSync, readFileSync, rmSync, writeFileSync } from "node:fs";
 import { join } from "node:path";
 import { tmpdir } from "node:os";
 import { execFileSync } from "node:child_process";
@@ -16,6 +16,7 @@ import { DISPATCH_RULES, resolveDispatch, type DispatchContext } from "../auto-d
 import { AutoSession } from "../auto/session.ts";
 import {
   closeDatabase,
+  getLatestAssessmentByScope,
   getPendingGates,
   insertAssessment,
   insertGateRow,
@@ -99,6 +100,23 @@ describe("completing-milestone dispatch guard (#4324)", () => {
     assert.equal(result?.unitId, "M001");
   });
 
+  test("records pass-through validation before completing-milestone dispatch when validation is absent (#823)", async () => {
+    base = makeBase();
+    openDatabase(join(base, ".gsd", "gsd.db"));
+    insertMilestone({ id: "M001", title: "Milestone One", status: "active" });
+    insertSlice({ milestoneId: "M001", id: "S01", title: "Done", status: "complete" });
+
+    const result = await rule.match(buildDispatchCtx(base));
+
+    assert.equal(result?.action, "dispatch");
+    assert.equal(result?.unitType, "complete-milestone");
+    const validation = getLatestAssessmentByScope("M001", "milestone-validation");
+    assert.equal(validation?.status, "pass");
+    const validationPath = join(base, ".gsd", "milestones", "M001", "M001-VALIDATION.md");
+    assert.equal(existsSync(validationPath), true);
+    assert.match(readFileSync(validationPath, "utf-8"), /skip_validation_reason: closeout-recovery/);
+  });
+
   test("resolveDispatch stops complete-milestone when unit is exhausted in-session (#5662)", async () => {
     base = makeBase();
     openDatabase(join(base, ".gsd", "gsd.db"));
@@ -303,6 +321,7 @@ describe("complete phase dispatch guard (#5683)", () => {
     assert.equal(result?.level, "warning");
     assert.match(result?.reason ?? "", /closeout-consistency-blocked/);
     assert.match(result?.reason ?? "", /latest milestone validation is "absent"/);
+    assert.match(result?.reason ?? "", /\/gsd validate-milestone M001/);
   });
 });
 

package/src/resources/extensions/gsd/tests/dispatch-history.test.ts

@@ -326,3 +326,105 @@ test("rehydrate degrades to an empty window without a scope or ledger", () => {
   assert.equal(noDb.rehydrate(), 0);
   assert.equal(noDb.getRecentWindow().length, 0);
 });
+
+// ─── Session-scoped rehydration (#852) ───────────────────────────────────────
+//
+// Without session scoping, two consecutive finalize-retry failures from a
+// PREVIOUS session persist in unit_dispatches and are loaded into the
+// DispatchHistory window on the NEXT session's start() → rehydrate() call.
+// The first advance's recordDispatch fills the window (matchingCount >=
+// STUCK_WINDOW_SIZE) and detectStuck Rule 1 fires immediately, killing
+// auto-mode before any new unit runs. The resolveTraceId option scopes
+// rehydrate() to the current session so only that session's dispatches
+// populate the window.
+
+test("#852: rehydrate with resolveTraceId ignores prior-session entries (empty window on fresh session)", (t) => {
+  const f = makeLedgerFixture(t);
+
+  // Prior session: six consecutive finalize-retry failures for the same unit.
+  // recordDispatchClaim uses the trace_id from the fixture's claim() helper
+  // (random per-iteration). We insert them directly so we control the trace_id.
+  for (let i = 0; i < STUCK_WINDOW_SIZE; i++) {
+    const claim = recordDispatchClaim({
+      traceId: "prior-session-trace-id",
+      workerId: f.worker,
+      milestoneLeaseToken: f.token,
+      milestoneId: "M001",
+      unitType: "discuss-milestone",
+      unitId: "M001",
+    });
+    assert.equal(claim.ok, true);
+    if (!claim.ok) return;
+    markFailed(claim.dispatchId, { errorSummary: "finalize-retry" });
+  }
+
+  // Unscoped rehydrate loads all prior entries — the window is full.
+  const unscopedHistory = createDispatchHistory({ resolveScopeId: () => f.base });
+  unscopedHistory.rehydrate();
+  assert.equal(
+    unscopedHistory.getRecentWindow().length,
+    STUCK_WINDOW_SIZE,
+    "unscoped rehydrate sees prior-session entries",
+  );
+
+  // New session: rehydrate scoped to a fresh trace_id that has never been
+  // written to unit_dispatches → 0 rows → the window stays empty.
+  const freshTraceId = "new-session-trace-id-never-in-db";
+  const freshHistory = createDispatchHistory({
+    resolveScopeId: () => f.base,
+    resolveTraceId: () => freshTraceId,
+  });
+  const count = freshHistory.rehydrate();
+  assert.equal(count, 0, "session-scoped rehydrate excludes prior-session entries");
+  assert.equal(freshHistory.getRecentWindow().length, 0);
+
+  // The first dispatch of the new session should not trigger stuck (window is
+  // empty, so Rule 1/2/3/4 cannot fire on a single-entry window).
+  freshHistory.recordDispatch("discuss-milestone", "M001");
+  assert.equal(
+    freshHistory.detectStuck(),
+    null,
+    "first dispatch in new session must not trigger stuck detection",
+  );
+});
+
+test("#852: rehydrate with resolveTraceId still includes current-session entries", (t) => {
+  const f = makeLedgerFixture(t);
+  const currentTraceId = "current-session-trace";
+
+  // Prior session entry (different trace_id).
+  const oldClaim = recordDispatchClaim({
+    traceId: "old-session-trace",
+    workerId: f.worker,
+    milestoneLeaseToken: f.token,
+    milestoneId: "M001",
+    unitType: "plan-milestone",
+    unitId: "M001",
+  });
+  assert.equal(oldClaim.ok, true);
+  if (oldClaim.ok) markFailed(oldClaim.dispatchId, { errorSummary: "finalize-retry" });
+
+  // Current session entries (matching trace_id).
+  for (let i = 0; i < 2; i++) {
+    const claim = recordDispatchClaim({
+      traceId: currentTraceId,
+      workerId: f.worker,
+      milestoneLeaseToken: f.token,
+      milestoneId: "M001",
+      unitType: "plan-milestone",
+      unitId: "M001",
+    });
+    assert.equal(claim.ok, true);
+    if (!claim.ok) return;
+    markFailed(claim.dispatchId, { errorSummary: "finalize-retry" });
+  }
+
+  // Scoped to current session: only the 2 current entries are loaded.
+  const history = createDispatchHistory({
+    resolveScopeId: () => f.base,
+    resolveTraceId: () => currentTraceId,
+  });
+  const count = history.rehydrate();
+  assert.equal(count, 2, "session-scoped rehydrate includes current-session entries");
+  assert.equal(history.getRecentWindow().length, 2);
+});