@opengsd/gsd-pi 1.3.0-dev.72e3af2a → 1.3.0-dev.738160b9

package/dist/resources/extensions/gsd/memory-backfill.js

@@ -33,8 +33,8 @@ import { logWarning } from "./workflow-logger.js";
  *   decision is checked individually; only decisions whose id is already
  *   present in the memory store are skipped. A user-authored memory with
  *   their own `sourceDecisionId` does NOT abort the backfill.
- * - Best-effort: never throws. Logs and returns 0 on failure so a broken
- *   backfill cannot block agent startup.
+ * - Best-effort: never throws. Failed memory inserts are logged and skipped;
+ *   setup/read failures log and return 0 so backfill cannot block startup.
  * - Full migration (ADR-013 Stage 2a): both active and superseded rows are
  *   migrated. `structured_fields.superseded_by` preserves the supersedes
  *   chain so the DECISIONS.md projection regen can source from memories
@@ -117,25 +117,32 @@ export function backfillDecisionsToMemories() {
                 continue;
             }
             const content = synthesizeDecisionMemoryContent(row);
-            const id = createMemory({
-                category: "architecture",
-                content,
-                scope: row.scope || "project",
-                confidence: 0.85,
-                structuredFields: {
-                    sourceDecisionId: row.id,
-                    when_context: row.when_context,
-                    scope: row.scope,
-                    decision: row.decision,
-                    choice: row.choice,
-                    rationale: row.rationale,
-                    made_by: row.made_by,
-                    revisable: row.revisable,
-                    superseded_by: row.superseded_by,
-                },
-            });
-            if (id)
-                written += 1;
+            try {
+                const id = createMemory({
+                    category: "architecture",
+                    content,
+                    scope: row.scope || "project",
+                    confidence: 0.85,
+                    structuredFields: {
+                        sourceDecisionId: row.id,
+                        when_context: row.when_context,
+                        scope: row.scope,
+                        decision: row.decision,
+                        choice: row.choice,
+                        rationale: row.rationale,
+                        made_by: row.made_by,
+                        revisable: row.revisable,
+                        superseded_by: row.superseded_by,
+                    },
+                });
+                if (id)
+                    written += 1;
+            }
+            catch (rowErr) {
+                const message = rowErr instanceof Error ? rowErr.message : String(rowErr);
+                logWarning("memory-backfill", `decisions->memories backfill skipped ${row.id}: ${message}`);
+                continue;
+            }
         }
         if (healed > 0) {
             logWarning("memory-backfill", `decisions->memories drift healed: ${healed} row${healed === 1 ? "" : "s"} updated superseded_by`);

package/dist/resources/extensions/gsd/metrics.js

@@ -17,7 +17,7 @@ import { join } from "node:path";
 import { openSync, closeSync, unlinkSync, statSync, writeFileSync } from "node:fs";
 import { gsdRoot } from "./paths.js";
 import { getAndClearSkills } from "./skill-telemetry.js";
-import { loadJsonFile, loadJsonFileOrNull, saveJsonFile } from "./json-persistence.js";
+import { loadJsonFile, loadJsonFileOrNull, saveJsonFileCompact } from "./json-persistence.js";
 import { parseUnitId } from "./unit-id.js";
 import { buildAuditEnvelope, emitUokAuditEvent } from "./uok/audit.js";
 import { isUnifiedAuditEnabled } from "./uok/audit-toggle.js";
@@ -636,7 +636,7 @@ export function pruneMetricsLedger(base, keepCount) {
         return 0;
     const removed = disk.units.length - keepCount;
     disk.units = keepNewestUnits(disk.units, keepCount);
-    saveJsonFile(metricsPath(base), disk);
+    saveJsonFileCompact(metricsPath(base), disk);
     // Keep the in-memory ledger in sync if it is loaded for this session.
     if (ledger) {
         ledger.units = keepNewestUnits(ledger.units, keepCount);
@@ -799,7 +799,7 @@ function saveLedger(base, data) {
                 : dataUnits;
             merged.sort(compareUnitsByTime);
             data.units = keepNewestUnits(merged);
-            saveJsonFile(path, data);
+            saveJsonFileCompact(path, data);
         }
         finally {
             releaseLock(lockPath);
@@ -813,6 +813,6 @@ function saveLedger(base, data) {
         // read-merge-write sequence without mutual exclusion.
         logWarning("fs", "saveLedger: lock not acquired — falling back to direct write (no merge)");
         data.units = keepNewestUnits(data.units);
-        saveJsonFile(path, data);
+        saveJsonFileCompact(path, data);
     }
 }

package/dist/resources/extensions/gsd/migrate-external.js

@@ -110,6 +110,7 @@ export function migrateToExternalState(basePath) {
         }
         // Copy contents to external dir, skipping worktrees/
         const entries = readdirSync(migratingPath, { withFileTypes: true });
+        const copyFailures = [];
         for (const entry of entries) {
             if (entry.name === "worktrees")
                 continue; // worktrees stay local
@@ -123,10 +124,18 @@ export function migrateToExternalState(basePath) {
                     cpSync(src, dst, { force: true });
                 }
             }
-            catch {
-                // Non-fatal: continue with other files
+            catch (copyErr) {
+                copyFailures.push(`${entry.name}: ${getErrorMessage(copyErr)}`);
             }
         }
+        if (copyFailures.length > 0) {
+            try {
+                rmSync(localGsd, { force: true });
+            }
+            catch { /* may not exist */ }
+            renameSync(migratingPath, localGsd);
+            return { migrated: false, error: `Migration copy failed: ${copyFailures.join("; ")}` };
+        }
         // Create symlink .gsd -> external path
         symlinkSync(externalPath, localGsd, "junction");
         // Verify the symlink resolves correctly before removing the backup (#1377).

package/dist/resources/extensions/gsd/orphan-stash-audit.js

@@ -26,16 +26,78 @@ function _isAlreadyRestoredApplyError(err) {
     return /already exists, no checkout/i.test(message);
 }
 export { _isAlreadyRestoredApplyError };
+function gitOutput(basePath, args) {
+    return execFileSync("git", args, {
+        cwd: basePath,
+        stdio: ["ignore", "pipe", "pipe"],
+        encoding: "utf-8",
+        env: GIT_NO_PROMPT_ENV,
+    });
+}
+function listStashUntrackedPaths(basePath, stashRef) {
+    try {
+        return gitOutput(basePath, ["ls-tree", "-r", "-z", "--name-only", `${stashRef}^3`]).split("\0").filter(Boolean);
+    }
+    catch {
+        return null;
+    }
+}
+function listStashTrackedPaths(basePath, stashRef) {
+    try {
+        return gitOutput(basePath, ["diff", "--name-only", "-z", `${stashRef}^1`, stashRef]).split("\0").filter(Boolean);
+    }
+    catch {
+        return null;
+    }
+}
+function readWorkingTreeStatus(basePath) {
+    try {
+        return gitOutput(basePath, ["status", "--porcelain", "-z", "--untracked-files=all"])
+            .split("\0")
+            .filter(Boolean)
+            .map((entry) => ({ code: entry.slice(0, 2), path: entry.slice(3) }));
+    }
+    catch {
+        return null;
+    }
+}
+function isAlreadyRestoredUntrackedStatus(basePath, stashRef, statusEntries) {
+    if (statusEntries.length === 0 || statusEntries.some((entry) => entry.code !== "??"))
+        return false;
+    const stashTrackedPaths = listStashTrackedPaths(basePath, stashRef);
+    if (!stashTrackedPaths || stashTrackedPaths.length > 0)
+        return false;
+    const stashUntrackedPaths = listStashUntrackedPaths(basePath, stashRef);
+    if (!stashUntrackedPaths || stashUntrackedPaths.length === 0)
+        return false;
+    const stashUntrackedPathSet = new Set(stashUntrackedPaths);
+    const workingTreeUntrackedPathSet = new Set(statusEntries.map((entry) => entry.path));
+    // "Already restored" requires the working tree's untracked paths to match the
+    // stash's untracked paths exactly, in BOTH directions:
+    //   1. every current untracked path comes from the stash (no unexplained user
+    //      work that an apply would clobber), AND
+    //   2. every stash untracked path is already present in the working tree.
+    // Without (2), a partial restore (where only some stash files were recovered)
+    // would be misread as fully restored: the audit would no-op without applying
+    // or warning, leaving the remaining pre-merge files missing.
+    return (statusEntries.every((entry) => stashUntrackedPathSet.has(entry.path)) &&
+        stashUntrackedPaths.every((path) => workingTreeUntrackedPathSet.has(path)));
+}
+function manualApplyWarning(stashRef, milestoneId, reason) {
+    return (`Pre-merge stash ${stashRef} for milestone ${milestoneId} not auto-applied: ${reason}; ` +
+        `run \`git stash apply ${stashRef}\` manually to restore your pre-merge changes.`);
+}
 /**
  * Audit `git stash list` for orphaned `gsd-preflight-stash:M00x:*` entries.
  *
  * The matching merge code in `phases.ts` previously skipped the postflight
  * pop whenever `mergeAndExit` threw, leaking the user's pre-merge working
- * tree into the stash list. For every preflight-stash entry whose milestone
- * is now complete (per the supplied callback), `git stash apply` is invoked —
+ * tree into the stash list. Completed-milestone stashes are only auto-applied
+ * when the working tree is clean and the stash does not modify tracked files.
+ * Dirty trees and tracked-file stashes are left untouched with a manual
+ * recovery warning. When auto-apply is safe, `git stash apply` is invoked —
  * NOT `pop`. The stash entry stays in the list so the user retains a backup
- * if the apply produces unexpected merge results. Idempotent across repeated
- * startup runs.
+ * if the apply produces unexpected merge results.
  *
  * Failures are best-effort: a list error (no repo, git unavailable) returns
  * an empty result. An apply error becomes a warning the user sees alongside
@@ -45,12 +107,7 @@ export function auditOrphanedPreflightStashes(basePath, isMilestoneComplete) {
     const result = { applied: [], warnings: [] };
     let listOutput;
     try {
-        listOutput = execFileSync("git", ["stash", "list", "--format=%gd%x00%s"], {
-            cwd: basePath,
-            stdio: ["ignore", "pipe", "pipe"],
-            encoding: "utf-8",
-            env: GIT_NO_PROMPT_ENV,
-        });
+        listOutput = gitOutput(basePath, ["stash", "list", "--format=%gd%x00%s"]);
     }
     catch {
         return result;
@@ -78,13 +135,32 @@ export function auditOrphanedPreflightStashes(basePath, isMilestoneComplete) {
         }
         if (!complete)
             continue;
+        const statusEntries = readWorkingTreeStatus(basePath);
+        if (!statusEntries) {
+            result.warnings.push(manualApplyWarning(ref, milestoneId, "could not verify working tree status"));
+            continue;
+        }
+        if (statusEntries.length > 0) {
+            if (isAlreadyRestoredUntrackedStatus(basePath, ref, statusEntries))
+                continue;
+            result.warnings.push(manualApplyWarning(ref, milestoneId, "working tree not clean"));
+            continue;
+        }
+        const trackedPaths = listStashTrackedPaths(basePath, ref);
+        if (trackedPaths === null) {
+            result.warnings.push(manualApplyWarning(ref, milestoneId, "could not inspect tracked paths in stash"));
+            continue;
+        }
+        if (trackedPaths.length > 0) {
+            // A retained tracked-file stash has no durable marker showing whether a
+            // clean tree needs first recovery or would be re-mutated by an old backup.
+            const preview = trackedPaths.slice(0, 5).join(", ");
+            const suffix = trackedPaths.length > 5 ? `, and ${trackedPaths.length - 5} more` : "";
+            result.warnings.push(manualApplyWarning(ref, milestoneId, `stash modifies tracked files (${preview}${suffix})`));
+            continue;
+        }
         try {
-            execFileSync("git", ["stash", "apply", "--quiet", ref], {
-                cwd: basePath,
-                stdio: ["ignore", "pipe", "pipe"],
-                encoding: "utf-8",
-                env: GIT_NO_PROMPT_ENV,
-            });
+            gitOutput(basePath, ["stash", "apply", "--quiet", ref]);
             result.applied.push({ milestoneId, stashRef: ref });
         }
         catch (err) {

package/dist/resources/extensions/gsd/prompts/plan-milestone.md

@@ -104,8 +104,8 @@ If the preference is off, ignore this section and plan every slice fully.
 
 If the roadmap has one slice, also plan S01 and its tasks inline:
 
-1. After `gsd_plan_milestone` returns, call `gsd_plan_slice` for S01 with full task breakdown.
-2. Use inlined **Slice Plan** and **Task Plan** templates for tool parameters.
+1. After `gsd_plan_milestone` returns, call `gsd_plan_slice` for S01 with slice metadata only; omit `tasks`.
+2. Then call `gsd_plan_task` once per S01 task. Use inlined **Slice Plan** and **Task Plan** templates for tool parameters.
 3. Keep simple slices lean. Omit Proof Level, Integration Closure, and Observability if all would be "none"; executable verification commands are enough.
 
 Do **not** write plan files manually; use DB-backed tools so state stays consistent.

package/dist/resources/extensions/gsd/prompts/plan-slice.md

@@ -45,8 +45,8 @@ If slice research is inlined, trust its architectural findings, but verify every
 6. Include Threat Surface (Q3), Requirement Impact (Q4), proof level, observability, integration closure, Failure Modes (Q5), Load Profile (Q6), and Negative Tests (Q7) only where applicable.
 7. Right-size tasks. Simple slices can be one task; split only when context, ownership, or verification boundaries justify it.
 8. Task `verify` commands must be safe, simple commands. Do not use shell pipes, redirects, semicolons, backticks, command substitution, output trimming, or grep regex alternation with `|`. If multiple checks are needed, create a small test file and run it with `node --test` or a package test script, or use separate simple commands joined only with `&&`. For absence checks, verify a pattern does not exist with `! grep -q 'pattern' file` or `! rg -q 'pattern' file`; do not use `grep -c` or `rg -c` to assert zero matches because count commands exit 1 when they find zero matches, and the verification gate treats that as failure.
-9. Each task needs the exact `gsd_plan_slice.tasks[]` shape: `taskId`, `title`, `description`, `estimate`, `files`, `verify`, `inputs`, `expectedOutput`, and optional `observabilityImpact`. `description` should contain the Why / Do / Done-when narrative. `files`, `inputs`, and `expectedOutput` must be JSON arrays of strings, even when there is only one path (for example, `"inputs": ["src/index.ts"]`, never `"inputs": "src/index.ts"`). Use paths relative to `{{workingDirectory}}`; do not put absolute paths to the original checkout or any directory outside `{{workingDirectory}}` in `files`, `inputs`, `expectedOutput`, or verification commands. **`expectedOutput` must only list files the task actually creates or overwrites on disk.** Do NOT include files the task merely reads, verifies, tests, or describes — those belong in `inputs`, `verify`, `description`, or slice success criteria. If a task is a pure verification or test task that produces no new files, `expectedOutput` must be `[]`; if it writes a test-result log or assertion output file, list only that concrete file path. A file that does not yet exist on disk and is needed as an `input` must be produced by an earlier task's `expectedOutput` — if no prior task creates it, add a task before this one that does. Never list GSD planning artifacts — anything under `.gsd/`, `.planning/`, or `.audits/`, or artifact names like `M001-CONTEXT.md` / `S01-PLAN.md` — in `inputs`, `files`, or `expectedOutput`: their content is preloaded as context, and they are written by workflow tools, not by tasks.
-10. Persist with `gsd_plan_slice` using `milestoneId`, `sliceId`, `goal`, optional `successCriteria`/`proofLevel`/`integrationClosure`/`observabilityImpact`, and `tasks`. `gsd_plan_slice` handles task persistence transactionally and renders `{{outputPath}}` plus task plans; do not call `gsd_plan_task`. The DB-backed tool is the canonical write path. Do **not** rely on direct `PLAN.md` writes as the source of truth.
+9. Each task persisted with `gsd_plan_task` needs the exact shape: `milestoneId`, `sliceId`, `taskId`, `title`, `description`, `estimate`, `files`, `verify`, `inputs`, `expectedOutput`, and optional `observabilityImpact`. `description` should contain the Why / Do / Done-when narrative. Any npm package name in a task description's install/add instructions (`npm install`, `yarn add`, `pnpm add`) or in `require('...')` or `import ... from '...'` code examples is subject to pre-execution registry validation; reference only packages that exist on the public npm registry, and remove or correct any package name that is not real. `files`, `inputs`, and `expectedOutput` must be JSON arrays of strings, even when there is only one path (for example, `"inputs": ["src/index.ts"]`, never `"inputs": "src/index.ts"`). Use paths relative to `{{workingDirectory}}`; do not put absolute paths to the original checkout or any directory outside `{{workingDirectory}}` in `files`, `inputs`, `expectedOutput`, or verification commands. **`expectedOutput` must only list files the task actually creates or overwrites on disk.** Do NOT include files the task merely reads, verifies, tests, or describes — those belong in `inputs`, `verify`, `description`, or slice success criteria. If a task is a pure verification or test task that produces no new files, `expectedOutput` must be `[]`; if it writes a test-result log or assertion output file, list only that concrete file path. A file that does not yet exist on disk and is needed as an `input` must be produced by an earlier task's `expectedOutput` — if no prior task creates it, add a task before this one that does. Never list GSD planning artifacts — anything under `.gsd/`, `.planning/`, or `.audits/`, or artifact names like `M001-CONTEXT.md` / `S01-PLAN.md` — in `inputs`, `files`, or `expectedOutput`: their content is preloaded as context, and they are written by workflow tools, not by tasks.
+10. Persist incrementally through DB-backed tools. First call `gsd_plan_slice` with `milestoneId`, `sliceId`, `goal`, and optional `successCriteria`/`proofLevel`/`integrationClosure`/`observabilityImpact`; omit `tasks` for this metadata call. Then call `gsd_plan_task` once per task, using the task shape above. Each successful tool call saves progress and re-renders `{{outputPath}}` from DB. The DB-backed tools are the canonical write path. Do **not** rely on direct `PLAN.md` writes as the source of truth.
 11. Self-audit before finishing: goal/demo closure, requirement coverage, deliverable coverage audit (cross-check every file listed in CONTEXT.md `## Scope` / `### In Scope` against task `files` or `expectedOutput`), locked decisions, concrete paths, dependency order, wiring, scope size, proof truthfulness, feature completeness, and quality gates. Quality gates: non-trivial slices/tasks include specific Q3-Q7 coverage where applicable.
 12. If planning creates structural decisions, call `gsd_decision_save` for each; the tool persists the decision and regenerates `.gsd/DECISIONS.md`.
 13. {{commitInstruction}}
@@ -55,6 +55,6 @@ The slice directory already exists. Do not mkdir.
 
 **Autonomous execution:** no human is available. Do not call `ask_user_questions` or `secure_env_collect`; make reasonable assumptions and document them.
 
-**You MUST call `gsd_plan_slice` to persist planning state before finishing, unless the stale-path safety rule above stops the unit before safe planning can occur.**
+**You MUST call `gsd_plan_slice` and then `gsd_plan_task` once for each planned task before finishing, unless the stale-path safety rule above stops the unit before safe planning can occur.**
 
 When done, say: "Slice {{sliceId}} planned." Say this exactly once — if you already said it in a prior message, do not repeat it.

package/dist/resources/extensions/gsd/root-write-leak-guard.js

@@ -4,9 +4,15 @@ import { execFileSync } from "node:child_process";
 import { createHash } from "node:crypto";
 import { existsSync, readFileSync, statSync } from "node:fs";
 import { join } from "node:path";
+import { GSD_RUNTIME_PATTERNS } from "./gitignore.js";
 const MAX_SYNC_FINGERPRINT_BYTES = 1_500_000_000;
+const ROOT_RUNTIME_PATH_PREFIXES = Array.from(new Set(GSD_RUNTIME_PATTERNS.map((pattern) => {
+    const path = pattern.replace(/\/+$/, "");
+    const slash = path.indexOf("/");
+    return slash === -1 ? path : path.slice(0, slash);
+})));
 function isRootRuntimePath(path) {
-    return path === ".gsd" || path.startsWith(".gsd/");
+    return ROOT_RUNTIME_PATH_PREFIXES.some((prefix) => path === prefix || path.startsWith(`${prefix}/`));
 }
 function fileFingerprint(rootPath, relPath) {
     const absPath = join(rootPath, relPath);

package/dist/resources/extensions/gsd/safety/destructive-guard.js

@@ -20,14 +20,21 @@ const DESTRUCTIVE_PATTERNS = [
     { pattern: /\baws\s+\w+\s+(delete|create|put|remove|terminate)\b/i, label: "AWS mutation" },
     { pattern: /\bkubectl\s+(delete|apply)\b/i, label: "kubectl mutation" },
 ];
+function stripQuotedAndComments(command) {
+    return command
+        .replace(/"(?:[^"\\]|\\.)*"/g, '""')
+        .replace(/'(?:[^'\\]|\\.)*'/g, "''")
+        .replace(/(^|\s)#.*$/g, "$1");
+}
 /**
  * Classify a bash command for destructive operations.
  * Returns the list of matched destructive pattern labels.
  */
 export function classifyCommand(command) {
+    const commandToClassify = stripQuotedAndComments(command);
     const labels = [];
     for (const { pattern, label } of DESTRUCTIVE_PATTERNS) {
-        if (pattern.test(command)) {
+        if (pattern.test(commandToClassify)) {
             // Deduplicate labels (e.g., two force-push patterns)
             if (!labels.includes(label))
                 labels.push(label);

package/dist/resources/extensions/gsd/safety/evidence-collector.js

@@ -27,10 +27,14 @@ const EXECUTION_TOOL_NAMES = new Set([
 const MCP_EXECUTION_TOOL_RE = /^mcp__.+__gsd_(?:uat_)?exec(?:_search)?$/;
 // ─── Module State ───────────────────────────────────────────────────────────
 let unitEvidence = [];
+let lastWritePath = null;
+let lastWriteSig = null;
 // ─── Public API ─────────────────────────────────────────────────────────────
 /** Reset all evidence for a new unit. Call at unit start. */
 export function resetEvidence() {
     unitEvidence = [];
+    lastWritePath = null;
+    lastWriteSig = null;
 }
 /** Get a read-only view of all evidence collected for the current unit. */
 export function getEvidence() {
@@ -95,10 +99,15 @@ function isEvidenceArray(data) {
 export function saveEvidenceToDisk(basePath, milestoneId, sliceId, taskId) {
     try {
         const path = evidencePath(basePath, milestoneId, sliceId, taskId);
+        const body = JSON.stringify(unitEvidence, null, 2) + "\n";
+        if (path === lastWritePath && body === lastWriteSig)
+            return;
         mkdirSync(dirname(path), { recursive: true });
         const tmp = `${path}.tmp.${randomBytes(4).toString("hex")}`;
-        writeFileSync(tmp, JSON.stringify(unitEvidence, null, 2) + "\n", "utf-8");
+        writeFileSync(tmp, body, "utf-8");
         renameSync(tmp, path);
+        lastWritePath = path;
+        lastWriteSig = body;
     }
     catch {
         // Non-fatal — don't let persistence failures break unit execution
@@ -112,6 +121,8 @@ export function saveEvidenceToDisk(basePath, milestoneId, sliceId, taskId) {
  */
 export function loadEvidenceFromDisk(basePath, milestoneId, sliceId, taskId) {
     try {
+        lastWritePath = null;
+        lastWriteSig = null;
         const path = evidencePath(basePath, milestoneId, sliceId, taskId);
         if (!existsSync(path))
             return;
@@ -136,6 +147,10 @@ export function clearEvidenceFromDisk(basePath, milestoneId, sliceId, taskId) {
         if (existsSync(path)) {
             unlinkSync(path);
         }
+        if (path === lastWritePath) {
+            lastWritePath = null;
+            lastWriteSig = null;
+        }
     }
     catch {
         // Non-fatal

package/dist/resources/extensions/gsd/safety/file-change-validator.js

@@ -44,8 +44,11 @@ export function validateFileChanges(basePath, expectedOutput, plannedFiles, file
     const actualFiles = getChangedFilesFromLastCommit(basePath);
     if (!actualFiles)
         return null;
-    // Filter out .gsd/ internal files — only validate project source files
-    const projectFiles = actualFiles.filter(f => !f.startsWith(".gsd/") && !f.startsWith(".gsd\\"));
+    // Filter out GSD-internal paths — only validate project source files.
+    const projectFiles = actualFiles.filter((f) => !f.startsWith(".gsd/") &&
+        !f.startsWith(".gsd\\") &&
+        !f.startsWith(".gsd-backups/") &&
+        !f.startsWith(".gsd-backups\\"));
     // Normalize expected paths (strip leading ./ or /)
     const normalizedExpected = new Set([...allExpected].map((f) => normalizePlannedFileReference(f).replace(/^\.\//, "").replace(/^\//, "")));
     // Build allowlist matchers once (dot: true so patterns like `**/.hidden` work).

package/dist/resources/extensions/gsd/tools/complete-milestone.js

@@ -13,7 +13,7 @@ import { existsSync } from "node:fs";
 import { transaction, getMilestone, getMilestoneSlices, getSliceTasks, getLatestAssessmentByScope, updateMilestoneStatus, } from "../gsd-db.js";
 import { clearPathCache, relMilestoneFile } from "../paths.js";
 import { resolveCanonicalMilestoneRoot } from "../worktree-manager.js";
-import { isClosedStatus } from "../status-guards.js";
+import { isClosedStatus, isDeferredStatus } from "../status-guards.js";
 import { saveFile, clearParseCache } from "../files.js";
 import { invalidateStateCache } from "../state.js";
 import { stripIdPrefix } from "../workflow-projections.js";
@@ -118,7 +118,7 @@ export async function handleCompleteMilestone(params, basePath) {
             guardError = `no slices found for milestone ${params.milestoneId}`;
             return;
         }
-        const incompleteSlices = slices.filter(s => !isClosedStatus(s.status));
+        const incompleteSlices = slices.filter(s => !isClosedStatus(s.status) && !isDeferredStatus(s.status));
         if (incompleteSlices.length > 0) {
             const incompleteIds = incompleteSlices.map(s => `${s.id} (status: ${s.status})`).join(", ");
             guardError = `incomplete slices: ${incompleteIds}`;
@@ -126,6 +126,8 @@ export async function handleCompleteMilestone(params, basePath) {
         }
         // Deep check: verify all tasks in all slices are complete
         for (const slice of slices) {
+            if (isDeferredStatus(slice.status))
+                continue;
             const tasks = getSliceTasks(params.milestoneId, slice.id);
             const incompleteTasks = tasks.filter(t => !isClosedStatus(t.status));
             if (incompleteTasks.length > 0) {

package/dist/resources/extensions/gsd/tools/plan-slice.js

@@ -28,9 +28,13 @@ function validateRepositoryTargetIds(field, value) {
     return deduped;
 }
 function validateTasks(value) {
-    if (!Array.isArray(value) || value.length === 0) {
-        throw new Error("tasks must be a non-empty array");
+    if (value === undefined)
+        return undefined;
+    if (!Array.isArray(value)) {
+        throw new Error("tasks must be an array");
     }
+    if (value.length === 0)
+        return undefined;
     const seen = new Set();
     return value.map((entry, index) => {
         if (!entry || typeof entry !== "object") {
@@ -129,7 +133,7 @@ function validateReferencedRepositories(params, registry, defaultTargets) {
     };
     for (const id of params.targetRepositories ?? defaultTargets)
         noteMissing(id);
-    for (const task of params.tasks) {
+    for (const task of params.tasks ?? []) {
         for (const id of task.targetRepositories ?? params.targetRepositories ?? defaultTargets)
             noteMissing(id);
     }
@@ -141,7 +145,7 @@ function resolveAllowedRootsForPathScope(params, registry, defaultTargets) {
     const requested = new Set();
     for (const id of params.targetRepositories ?? defaultTargets)
         requested.add(id);
-    for (const task of params.tasks) {
+    for (const task of params.tasks ?? []) {
         for (const id of task.targetRepositories ?? params.targetRepositories ?? defaultTargets)
             requested.add(id);
     }
@@ -153,7 +157,7 @@ function resolveAllowedRootsForPathScope(params, registry, defaultTargets) {
     return roots.length > 0 ? roots : [registry.projectRoot];
 }
 function toTaskRows(params, defaultTargets) {
-    return params.tasks.map((task, index) => ({
+    return (params.tasks ?? []).map((task, index) => ({
         milestone_id: params.milestoneId,
         slice_id: params.sliceId,
         id: task.taskId,
@@ -230,19 +234,21 @@ export async function handlePlanSlice(rawParams, basePath) {
         return { error: `validation failed: ${message}` };
     }
     const defaultTargets = defaultRepositoryTargets(repositoryRegistry);
+    const taskPayload = params.tasks ?? [];
+    const hasTaskPayload = taskPayload.length > 0;
     const repoValidationError = validateReferencedRepositories(params, repositoryRegistry, defaultTargets);
     if (repoValidationError) {
         return { error: `validation failed: ${repoValidationError}` };
     }
     const allowedAbsoluteRoots = resolveAllowedRootsForPathScope(params, repositoryRegistry, defaultTargets);
-    const pathOnlyError = validatePathOnlyPlanningFields(params.tasks.map((task, index) => ({
+    const pathOnlyError = validatePathOnlyPlanningFields(taskPayload.map((task, index) => ({
         field: `tasks[${index}].expectedOutput`,
         values: task.expectedOutput,
     })));
     if (pathOnlyError) {
         return { error: `validation failed: ${pathOnlyError}` };
     }
-    const pathScopeError = validatePlanningPathScope(basePath, params.tasks.flatMap((task, index) => [
+    const pathScopeError = validatePlanningPathScope(basePath, taskPayload.flatMap((task, index) => [
         { field: `tasks[${index}].files`, values: task.files },
         { field: `tasks[${index}].inputs`, values: task.inputs },
         { field: `tasks[${index}].expectedOutput`, values: task.expectedOutput },
@@ -279,15 +285,17 @@ export async function handlePlanSlice(rawParams, basePath) {
                 guardError = `cannot re-plan slice ${params.sliceId}: it is already complete — use gsd_slice_reopen first`;
                 return;
             }
-            const newTaskIds = new Set(params.tasks.map((task) => task.taskId));
+            const newTaskIds = new Set(taskPayload.map((task) => task.taskId));
             const existingTasks = getSliceTasks(params.milestoneId, params.sliceId);
-            omittedTaskIds = existingTasks
-                .filter((task) => !newTaskIds.has(task.id))
-                .map((task) => task.id);
-            for (const task of existingTasks) {
-                if (!newTaskIds.has(task.id) && isClosedStatus(task.status)) {
-                    guardError = `cannot remove completed task ${task.id}`;
-                    return;
+            if (hasTaskPayload) {
+                omittedTaskIds = existingTasks
+                    .filter((task) => !newTaskIds.has(task.id))
+                    .map((task) => task.id);
+                for (const task of existingTasks) {
+                    if (!newTaskIds.has(task.id) && isClosedStatus(task.status)) {
+                        guardError = `cannot remove completed task ${task.id}`;
+                        return;
+                    }
                 }
             }
             if (isDeferredStatus(parentSlice.status)) {
@@ -301,34 +309,36 @@ export async function handlePlanSlice(rawParams, basePath) {
                 observabilityImpact: params.observabilityImpact,
                 targetRepositories: params.targetRepositories ?? defaultTargets,
             });
-            for (const taskId of omittedTaskIds) {
-                deleteTask(params.milestoneId, params.sliceId, taskId);
-            }
-            const existingTaskById = new Map(existingTasks.map((task) => [task.id, task]));
-            for (const task of params.tasks) {
-                const planning = {
-                    title: task.title,
-                    description: task.description,
-                    estimate: task.estimate,
-                    files: task.files,
-                    verify: task.verify,
-                    inputs: task.inputs,
-                    expectedOutput: task.expectedOutput,
-                    observabilityImpact: task.observabilityImpact ?? "",
-                    fullPlanMd: task.fullPlanMd,
-                    targetRepositories: task.targetRepositories ?? params.targetRepositories ?? defaultTargets,
-                };
-                const existingTask = existingTaskById.get(task.taskId);
-                if (!existingTask || !isClosedStatus(existingTask.status)) {
-                    insertTask({
-                        id: task.taskId,
-                        sliceId: params.sliceId,
-                        milestoneId: params.milestoneId,
+            if (hasTaskPayload) {
+                for (const taskId of omittedTaskIds) {
+                    deleteTask(params.milestoneId, params.sliceId, taskId);
+                }
+                const existingTaskById = new Map(existingTasks.map((task) => [task.id, task]));
+                for (const task of taskPayload) {
+                    const planning = {
                         title: task.title,
-                        status: "pending",
-                    });
+                        description: task.description,
+                        estimate: task.estimate,
+                        files: task.files,
+                        verify: task.verify,
+                        inputs: task.inputs,
+                        expectedOutput: task.expectedOutput,
+                        observabilityImpact: task.observabilityImpact ?? "",
+                        fullPlanMd: task.fullPlanMd,
+                        targetRepositories: task.targetRepositories ?? params.targetRepositories ?? defaultTargets,
+                    };
+                    const existingTask = existingTaskById.get(task.taskId);
+                    if (!existingTask || !isClosedStatus(existingTask.status)) {
+                        insertTask({
+                            id: task.taskId,
+                            sliceId: params.sliceId,
+                            milestoneId: params.milestoneId,
+                            title: task.title,
+                            status: "pending",
+                        });
+                    }
+                    upsertTaskPlanning(params.milestoneId, params.sliceId, task.taskId, planning);
                 }
-                upsertTaskPlanning(params.milestoneId, params.sliceId, task.taskId, planning);
             }
             // Seed quality gate rows inside the transaction — all-or-nothing with
             // the plan data so a crash can't leave orphaned gates without tasks.
@@ -337,7 +347,7 @@ export async function handlePlanSlice(rawParams, basePath) {
                 insertGateRow({ milestoneId: params.milestoneId, sliceId: params.sliceId, gateId: gid, scope: "slice" });
             }
             const taskGates = resolveTaskGates(gateEvaluation);
-            for (const task of params.tasks) {
+            for (const task of taskPayload) {
                 for (const gid of taskGates) {
                     insertGateRow({ milestoneId: params.milestoneId, sliceId: params.sliceId, gateId: gid, scope: "task", taskId: task.taskId });
                 }
@@ -360,8 +370,13 @@ export async function handlePlanSlice(rawParams, basePath) {
             const artifactPath = relative(gsdProjectionRoot(basePath), taskPlanPath).replace(/\\/g, "/");
             deleteArtifactByPath(artifactPath);
         }
-        const renderResult = await renderPlanFromDb(basePath, params.milestoneId, params.sliceId);
-        setSliceSketchFlag(params.milestoneId, params.sliceId, false);
+        const sliceTasks = getSliceTasks(params.milestoneId, params.sliceId);
+        const renderResult = sliceTasks.length === 0
+            ? { planPath: "", taskPlanPaths: [] }
+            : await renderPlanFromDb(basePath, params.milestoneId, params.sliceId);
+        if (sliceTasks.length > 0) {
+            setSliceSketchFlag(params.milestoneId, params.sliceId, false);
+        }
         invalidateStateCache();
         clearParseCache();
         // ── Post-mutation hook: manifest, event log ─────────────────────────