@opengsd/gsd-pi 1.2.0-dev.fb12b103 → 1.2.0-dev.fbdca60b

package/src/resources/extensions/gsd/tests/user-input-boundary.test.ts

@@ -1,173 +0,0 @@
-import test from "node:test";
-import assert from "node:assert/strict";
-
-import * as userInputBoundary from "../user-input-boundary.ts";
-import {
-  isAwaitingUserInput,
-  messageHasPendingAskUserQuestionsTool,
-  shouldPauseForUserApprovalQuestion,
-} from "../user-input-boundary.ts";
-
-test("lastAssistantText extracts the latest assistant text block content", () => {
-  const lastAssistantText = (userInputBoundary as {
-    lastAssistantText?: (messages: unknown[] | null | undefined) => string;
-  }).lastAssistantText;
-
-  assert.equal(typeof lastAssistantText, "function");
-  assert.equal(
-    lastAssistantText?.([
-      { role: "assistant", content: "Older message" },
-      {
-        role: "assistant",
-        content: [
-          { type: "text", text: "First line" },
-          { type: "text", text: "Second line" },
-        ],
-      },
-    ]),
-    "First line\nSecond line",
-  );
-  assert.equal(lastAssistantText?.(null), "");
-});
-
-test("lastAssistantText includes thinking blocks so rate-limit notices are not dropped", () => {
-  const lastAssistantText = (userInputBoundary as {
-    lastAssistantText?: (messages: unknown[] | null | undefined) => string;
-  }).lastAssistantText;
-
-  assert.equal(typeof lastAssistantText, "function");
-  // Turn with only a thinking block (no text block) — must not return ""
-  const result = lastAssistantText?.([
-    {
-      role: "assistant",
-      content: [
-        { type: "thinking", thinking: "You've hit your limit · resets in 2h" },
-      ],
-    },
-  ]);
-  assert.ok(result?.includes("You've hit your limit"), `expected rate-limit text, got: ${JSON.stringify(result)}`);
-});
-
-test("isAwaitingUserInput does not trigger on thinking-block question marks", () => {
-  // A thinking block with a question mark must NOT pause auto-mode —
-  // it's internal reasoning, not a user-visible prompt.
-  const messages = [
-    {
-      role: "assistant",
-      content: [
-        { type: "thinking", thinking: "Should I skip research? Let me check the config." },
-      ],
-    },
-  ];
-  assert.equal(isAwaitingUserInput(messages), false);
-  assert.equal(shouldPauseForUserApprovalQuestion("discuss-project", messages), false);
-});
-
-test("isAwaitingUserInput does not trigger on thinking-block approval phrases", () => {
-  // A thinking block with approval phrases must NOT pause auto-mode.
-  const messages = [
-    {
-      role: "assistant",
-      content: [
-        { type: "thinking", thinking: "The user confirmed and approved the plan. Should I proceed?" },
-      ],
-    },
-  ];
-  assert.equal(isAwaitingUserInput(messages), false);
-  assert.equal(shouldPauseForUserApprovalQuestion("discuss-requirements", messages), false);
-});
-
-test("messageHasPendingAskUserQuestionsTool detects in-flight structured question tools", () => {
-  // state: "running" with no externalResult → still in-flight
-  assert.equal(
-    messageHasPendingAskUserQuestionsTool({
-      role: "assistant",
-      content: [
-        { type: "text", text: "Which direction?" },
-        { type: "toolCall", name: "mcp__gsd-workflow__ask_user_questions", state: "running" },
-      ],
-    }),
-    true,
-  );
-
-  // no state, no externalResult — streaming block that hasn't completed yet
-  assert.equal(
-    messageHasPendingAskUserQuestionsTool({
-      role: "assistant",
-      content: [
-        { type: "toolCall", name: "ask_user_questions" },
-      ],
-    }),
-    true,
-  );
-
-  // state: "completed" — legacy state-based completion
-  assert.equal(
-    messageHasPendingAskUserQuestionsTool({
-      role: "assistant",
-      content: [
-        { type: "toolCall", name: "ask_user_questions", state: "completed" },
-      ],
-    }),
-    false,
-  );
-
-  // externalResult present — Claude Code signals completion via externalResult, not state
-  assert.equal(
-    messageHasPendingAskUserQuestionsTool({
-      role: "assistant",
-      content: [
-        { type: "toolCall", name: "ask_user_questions", externalResult: { content: [], isError: false } },
-      ],
-    }),
-    false,
-  );
-  assert.equal(
-    messageHasPendingAskUserQuestionsTool({
-      role: "assistant",
-      content: [
-        {
-          type: "toolCall",
-          name: "ask_user_questions",
-          externalResult: { content: [{ type: "text", text: "answer" }], isError: false },
-        },
-      ],
-    }),
-    false,
-  );
-
-  // serverToolUse shape (claude-code-cli MCP path) — no externalResult → in-flight
-  assert.equal(
-    messageHasPendingAskUserQuestionsTool({
-      role: "assistant",
-      content: [
-        { type: "serverToolUse", name: "mcp__gsd-workflow__ask_user_questions" },
-      ],
-    }),
-    true,
-  );
-  // serverToolUse shape — externalResult present → completed
-  assert.equal(
-    messageHasPendingAskUserQuestionsTool({
-      role: "assistant",
-      content: [
-        { type: "serverToolUse", name: "ask_user_questions", externalResult: { content: [], isError: false } },
-      ],
-    }),
-    false,
-  );
-});
-
-test("isAwaitingUserInput still triggers on text-block question marks when thinking is also present", () => {
-  // When thinking + text are both present and the text asks a question, it should still pause.
-  const messages = [
-    {
-      role: "assistant",
-      content: [
-        { type: "thinking", thinking: "Internal reasoning without questions." },
-        { type: "text", text: "Does this look correct?" },
-      ],
-    },
-  ];
-  assert.equal(isAwaitingUserInput(messages), true);
-});

package/src/resources/extensions/gsd/user-input-boundary.ts

@@ -1,216 +0,0 @@
-const USER_APPROVAL_UNIT_TYPES = new Set([
-  "discuss-project",
-  "discuss-requirements",
-  "discuss-milestone",
-  "research-decision",
-]);
-
-const REMOTE_QUESTION_FAILURE_RE =
-  /(?:Remote (?:auth failed|questions failed|channel configured but returned no result|questions timed out|questions timed out or failed)|Failed to send questions via)/i;
-
-const APPROVAL_WAIT_RE =
-  /\bwait(?:ing)?\s+for\s+(?:your\s+)?(?:confirmation|approval|input|response|answer)\b/i;
-
-const APPROVAL_QUESTION_RE =
-  /\b(?:confirm|confirmation|approve|approval|approved|captured|correct|correctly|happy\s+with|ready\s+to\s+(?:write|save|proceed|ship)|(?:want|need)\s+to\s+adjust|should\s+I\s+(?:write|save|proceed)|do\s+you\s+want\s+me\s+to\s+(?:write|save|proceed)|ship\s+it)\b/i;
-
-const APPROVAL_RIGHT_QUESTION_RE =
-  /\b(?:does|do|is|are|was|were|did)\b[^\n?]{0,120}\bright\b/i;
-
-const APPROVAL_CHANGE_QUESTION_RE =
-  /\b(?:anything\s+else|anything|something)\s+to\s+(?:adjust|add|remove|reclassify)\b/i;
-
-const RESEARCH_DECISION_QUESTION_RE =
-  /\b(?:research|skip)\b/i;
-
-function extractVisibleTextFromMessage(msg: unknown): string {
-  if (!msg || typeof msg !== "object") return "";
-  const content = (msg as { content?: unknown }).content;
-  if (typeof content === "string") return content;
-  if (!Array.isArray(content)) return "";
-  const parts: string[] = [];
-  for (const block of content) {
-    if (!block || typeof block !== "object") continue;
-    const typed = block as { type?: unknown; text?: unknown };
-    if (typed.type === "text" && typeof typed.text === "string") {
-      parts.push(typed.text);
-    }
-    // thinking blocks intentionally excluded — they are internal reasoning, not user-visible
-  }
-  return parts.join("\n");
-}
-
-function extractTextFromMessage(msg: unknown): string {
-  if (!msg || typeof msg !== "object") return "";
-  const content = (msg as { content?: unknown }).content;
-  if (typeof content === "string") return content;
-  if (!Array.isArray(content)) return "";
-  const parts: string[] = [];
-  for (const block of content) {
-    if (!block || typeof block !== "object") continue;
-    const typed = block as { type?: unknown; text?: unknown; thinking?: unknown };
-    if (typed.type === "text" && typeof typed.text === "string") {
-      parts.push(typed.text);
-    }
-    if (typed.type === "thinking" && typeof typed.thinking === "string") {
-      parts.push(typed.thinking);
-    }
-  }
-  return parts.join("\n");
-}
-
-export function lastAssistantText(messages: unknown[] | null | undefined): string {
-  if (!Array.isArray(messages)) return "";
-  for (let i = messages.length - 1; i >= 0; i--) {
-    const msg = messages[i];
-    if (!msg || typeof msg !== "object") continue;
-    if ((msg as { role?: unknown }).role !== "assistant") continue;
-    const text = extractTextFromMessage(msg).trim();
-    if (text) return text;
-  }
-  return "";
-}
-
-function lastAssistantVisibleText(messages: unknown[] | null | undefined): string {
-  if (!Array.isArray(messages)) return "";
-  for (let i = messages.length - 1; i >= 0; i--) {
-    const msg = messages[i];
-    if (!msg || typeof msg !== "object") continue;
-    if ((msg as { role?: unknown }).role !== "assistant") continue;
-    const text = extractVisibleTextFromMessage(msg).trim();
-    if (text) return text;
-  }
-  return "";
-}
-
-function anyMessageMatches(messages: unknown[] | undefined, pattern: RegExp): boolean {
-  if (!Array.isArray(messages)) return false;
-  return messages.some((msg) => {
-    if (!msg || typeof msg !== "object") return false;
-    if ((msg as { role?: unknown }).role === "user") return false;
-    return pattern.test(extractVisibleTextFromMessage(msg));
-  });
-}
-
-function hasApprovalQuestion(text: string): boolean {
-  for (let i = 0; i < text.length; i++) {
-    if (text[i] !== "?") continue;
-    const previousBreak = Math.max(
-      text.lastIndexOf("\n", i),
-      text.lastIndexOf(".", i),
-      text.lastIndexOf("!", i),
-      text.lastIndexOf("?", i - 1),
-    );
-    const fragment = text.slice(previousBreak + 1, i + 1);
-    if (APPROVAL_QUESTION_RE.test(fragment)) return true;
-    if (APPROVAL_RIGHT_QUESTION_RE.test(fragment)) return true;
-    if (APPROVAL_CHANGE_QUESTION_RE.test(fragment)) return true;
-  }
-  return false;
-}
-
-function hasResearchDecisionQuestion(text: string): boolean {
-  for (let i = 0; i < text.length; i++) {
-    if (text[i] !== "?") continue;
-    const previousBreak = Math.max(
-      text.lastIndexOf("\n", i),
-      text.lastIndexOf(".", i),
-      text.lastIndexOf("!", i),
-      text.lastIndexOf("?", i - 1),
-    );
-    const fragment = text.slice(previousBreak + 1, i + 1);
-    if (RESEARCH_DECISION_QUESTION_RE.test(fragment)) return true;
-  }
-  return false;
-}
-
-export function approvalGateIdForUnit(
-  unitType: string | undefined,
-  unitId?: string | null,
-): string | null {
-  if (!unitType) return null;
-  if (unitType === "discuss-project") return "depth_verification_project_confirm";
-  if (unitType === "discuss-requirements") return "depth_verification_requirements_confirm";
-  if (unitType === "research-decision") return "depth_verification_research_decision_confirm";
-  if (unitType === "discuss-milestone") {
-    const safeUnitId = typeof unitId === "string" && /^[A-Za-z0-9_-]+$/.test(unitId)
-      ? unitId
-      : "milestone";
-    return `depth_verification_${safeUnitId}_confirm`;
-  }
-  return null;
-}
-
-const CHANGE_REQUEST_RESPONSE_RE =
-  /\b(?:no|nope|nah|not\s+yet|don't|do\s+not|change|add|remove|reclassify|adjust|clarify|missing|instead|but|however|wait|hold)\b/i;
-
-const APPROVAL_RESPONSE_RE =
-  /^(?:y|yes|yeah|yep|approve|approved|confirm|confirmed|correct|right|looks\s+(?:good|right)|sounds\s+good|all\s+good|ok|okay|go\s+ahead|proceed|write\s+it|save\s+it|do\s+it)\b/i;
-
-const RESEARCH_DECISION_RESPONSE_RE =
-  /^(?:research|run\s+research|do\s+research|skip|skip\s+research|no\s+research)\b/i;
-
-export function isExplicitApprovalResponse(
-  input: string | undefined,
-  pendingGateId?: string | null,
-): boolean {
-  const text = input?.trim() ?? "";
-  if (!text) return false;
-  if (pendingGateId?.includes("research_decision")) {
-    return RESEARCH_DECISION_RESPONSE_RE.test(text);
-  }
-  if (CHANGE_REQUEST_RESPONSE_RE.test(text)) return false;
-  return APPROVAL_RESPONSE_RE.test(text);
-}
-
-export function isAwaitingUserInput(messages: unknown[] | undefined): boolean {
-  if (anyMessageMatches(messages, /ask_user_questions was cancelled before receiving a response/i)) return true;
-  if (anyMessageMatches(messages, REMOTE_QUESTION_FAILURE_RE)) return true;
-  const text = lastAssistantVisibleText(messages);
-  if (!text) return false;
-  if (APPROVAL_WAIT_RE.test(text)) return true;
-  const lines = text.split(/\r?\n/).map((line) => line.trim()).filter(Boolean);
-  if (lines.some((line) => line.endsWith("?"))) return true;
-  return hasApprovalQuestion(text);
-}
-
-export function isAwaitingApprovalBoundary(messages: unknown[] | undefined): boolean {
-  if (anyMessageMatches(messages, /ask_user_questions was cancelled before receiving a response/i)) return true;
-  if (anyMessageMatches(messages, REMOTE_QUESTION_FAILURE_RE)) return true;
-  const text = lastAssistantVisibleText(messages);
-  if (!text) return false;
-  if (APPROVAL_WAIT_RE.test(text)) return true;
-  return hasApprovalQuestion(text);
-}
-
-/** True when an assistant message already has an in-flight ask_user_questions tool call. */
-export function messageHasPendingAskUserQuestionsTool(message: unknown): boolean {
-  if (!message || typeof message !== "object") return false;
-  const content = (message as { content?: unknown }).content;
-  if (!Array.isArray(content)) return false;
-  return content.some((block) => {
-    if (!block || typeof block !== "object") return false;
-    // Claude Code marks completion by attaching externalResult, not by setting state.
-    // Streaming blocks often carry no state; serverToolUse is the claude-code-cli MCP path.
-    const tool = block as { type?: string; name?: string; state?: string; externalResult?: unknown };
-    if (tool.type !== "toolCall" && tool.type !== "serverToolUse") return false;
-    const name = String(tool.name ?? "").toLowerCase();
-    if (!name.includes("ask_user_questions")) return false;
-    if (tool.externalResult !== undefined) return false;
-    return tool.state !== "completed" && tool.state !== "done";
-  });
-}
-
-export function shouldPauseForUserApprovalQuestion(
-  unitType: string | undefined,
-  messages: unknown[] | undefined,
-): boolean {
-  if (!unitType || !USER_APPROVAL_UNIT_TYPES.has(unitType)) return false;
-  if (anyMessageMatches(messages, /ask_user_questions was cancelled before receiving a response/i)) return true;
-  if (anyMessageMatches(messages, REMOTE_QUESTION_FAILURE_RE)) return true;
-  const text = lastAssistantVisibleText(messages);
-  if (!text) return false;
-  if (APPROVAL_WAIT_RE.test(text)) return true;
-  if (unitType === "research-decision") return hasResearchDecisionQuestion(text);
-  return hasApprovalQuestion(text);
-}

package/src/resources/skills/gsd-browser/SKILL.md

@@ -1,41 +0,0 @@
----
-name: gsd-browser
-description: "Use gsd-browser for browser automation and UAT: navigating local apps, inspecting pages, clicking or filling controls, taking screenshots, asserting UI behavior, collecting console/network diagnostics, visual diffing, and creating evidence bundles. Prefer this over legacy Playwright browser tooling when both are available."
-allowed-tools: Bash(gsd-browser:*), Bash(gsd-browser *)
----
-
-# gsd-browser
-
-Use `gsd-browser` as the default browser surface for automated UAT and real UI verification.
-
-## MCP First
-
-When MCP tools are available, prefer the `gsd-browser` server:
-
-- Discovery: `browser_snapshot_refs`, `browser_find`, `browser_get_accessibility_tree`
-- Actions: `browser_act`, `browser_batch`, `browser_click_ref`, `browser_fill_ref`
-- Verification: `browser_assert`, `browser_screenshot`, `browser_visual_diff`
-- Diagnostics: `browser_get_console_logs`, `browser_get_network_logs`, `browser_debug_bundle`
-
-If the host namespaces MCP tools, use names like `mcp__gsd-browser__browser_snapshot_refs`.
-
-## CLI Fallback
-
-The daemon starts automatically on first browser command.
-
-```bash
-gsd-browser navigate http://localhost:3000
-gsd-browser snapshot
-gsd-browser click-ref @v1:e1
-gsd-browser wait-for --condition network_idle
-gsd-browser assert --checks '[{"kind":"url_contains","text":"dashboard"}]'
-gsd-browser screenshot --output /tmp/gsd-browser-uat.png --format png
-```
-
-After any navigation, submit, or dynamic DOM change, take a fresh snapshot before using refs again. Refs are versioned, such as `@v1:e1` and `@v2:e3`, and old refs can become stale.
-
-Use `--json` when parsing output programmatically. Use named sessions for parallel or project-specific work:
-
-```bash
-gsd-browser --session gsd-pi navigate http://localhost:3000
-```