@opengsd/gsd-pi 1.2.0-dev.844675c9 → 1.2.0-dev.b1abb545

package/dist/resources/extensions/gsd/bootstrap/register-hooks.js

@@ -7,11 +7,12 @@ import { isToolCallEventType } from "@gsd/pi-coding-agent";
 import { ALWAYS_PRESERVED_SHIM_TOOL_NAMES } from "@gsd/pi-ai";
 import { updateSnapshot } from "../ecosystem/gsd-extension-api.js";
 import { buildMilestoneFileName, clearPathCache, milestonesDir, resolveMilestonePath, resolveSliceFile, resolveSlicePath } from "../paths.js";
-import { canonicalToolName, clearDiscussionFlowState, isDepthConfirmationAnswer, isMilestoneDepthVerified, isQueuePhaseActive, markApprovalGateVerified, markDepthVerified, resetWriteGateState, shouldBlockContextWrite, shouldBlockPlanningUnit, shouldBlockQueueExecution, shouldBlockWorktreeWrite, isGateQuestionId, setPendingGate, clearPendingGate, getPendingGate, shouldBlockPendingGate, shouldBlockPendingGateBash, extractDepthVerificationMilestoneId } from "./write-gate.js";
+import { applyAskUserQuestionsGateResult, canonicalToolName, clearDiscussionFlowState, formatPendingAskUserQuestionsGateMessage, isMilestoneDepthVerified, isQueuePhaseActive, markApprovalGateVerified, markDepthVerified, resetWriteGateState, shouldBlockContextWrite, shouldBlockPlanningUnit, shouldBlockQueueExecution, shouldBlockWorktreeWrite, isGateQuestionId, setPendingGate, clearPendingGate, getPendingGate, shouldBlockPendingGate, shouldBlockPendingGateBash, extractDepthVerificationMilestoneId } from "./write-gate.js";
 import { resolveManifest } from "../unit-context-manifest.js";
 import { isBlockedStateFile, isBashWriteToStateFile, BLOCKED_WRITE_ERROR } from "../write-intercept.js";
 import { loadFile, saveFile, formatContinue } from "../files.js";
-import { clearAutoCompletionStopInProgress, clearToolInvocationError, getAutoRuntimeSnapshot, getSourceObservationStore, isAutoActive, isAutoCompletionStopInProgress, isAutoPaused, markToolEnd, markToolStart, recordToolInvocationError, } from "../auto-runtime-state.js";
+import { clearAutoCompletionStopInProgress, clearToolInvocationError, getAutoRuntimeSnapshot, getSourceObservationStore, isAutoActive, isAutoCompletionStopInProgress, isAutoPaused, isInteractiveElicitationInFlight, markToolEnd, markToolStart, recordAutoToolSurfaceSnapshot, recordToolInvocationError, } from "../auto-runtime-state.js";
+import { applyProviderPayloadPolicy } from "../provider-payload-policy.js";
 import { checkToolCallLoop, resetToolCallLoopGuard } from "./tool-call-loop-guard.js";
 import { maybePauseAutoForApprovalGate, resetPendingGatePauseGuard } from "./pending-gate-pause.js";
 import { saveActivityLog } from "../activity-log.js";
@@ -22,16 +23,18 @@ import { logWarning as safetyLogWarning } from "../workflow-logger.js";
 import { installNotifyInterceptor } from "./notify-interceptor.js";
 import { initNotificationStore } from "../notification-store.js";
 import { initNotificationWidget } from "../notification-widget.js";
+import { notifyPreferenceDiagnostics } from "../preferences-diagnostics.js";
 import { resolveWorktreeProjectRoot } from "../worktree-root.js";
 import { extractSubagentAgentClasses } from "./subagent-input.js";
-import { approvalGateIdForUnit, isExplicitApprovalResponse, shouldPauseForUserApprovalQuestion } from "../user-input-boundary.js";
+import { approvalGateIdForUnit, isExplicitApprovalResponse, messageHasPendingAskUserQuestionsTool, shouldPauseForUserApprovalQuestion, } from "../user-input-boundary.js";
 import { applyUnitSkillVisibility, unitHasSkillManifest } from "../skill-scope.js";
 import { getGuidedUnitContext } from "../guided-unit-context.js";
 import { registerPlanMilestoneSchemaRecovery } from "./plan-milestone-schema-recovery.js";
-import { AUTO_UNIT_SCOPED_TOOLS, RUN_UAT_BROWSER_TOOL_NAMES, isWorkflowAliasTool } from "../auto-unit-tool-scope.js";
+import { AUTO_UNIT_SCOPED_TOOLS, RUN_UAT_BROWSER_TOOL_NAMES, canonicalWorkflowToolName, isWorkflowAliasTool } from "../auto-unit-tool-scope.js";
 import { filterToolsForProvider } from "../model-router.js";
+import { mcpToolMatchesBaseName } from "../mcp-tool-name.js";
 import { RUN_UAT_READ_ONLY_TOOL_NAMES, RUN_UAT_WORKFLOW_TOOL_NAMES } from "../tool-presentation-plan.js";
-import { injectSourceContextBlockIntoPayload, supportsSourceObservationsForUnit } from "../source-observations.js";
+import { supportsSourceObservationsForUnit } from "../source-observations.js";
 let approvalQuestionAbortInFlight = false;
 async function loadWelcomeScreenModule() {
     const candidates = [];
@@ -165,15 +168,19 @@ function resolveScopedToolNames(activeToolNames, requestedToolNames) {
     const resolved = new Set();
     for (const requested of requestedToolNames) {
         const scopedMatches = [];
+        const aliasFallbacks = [];
         for (const activeName of activeToolNames) {
-            if (!activeName.startsWith("mcp__"))
-                continue;
-            const toolSeparator = activeName.indexOf("__", "mcp__".length);
-            if (toolSeparator < 0)
-                continue;
-            if (activeName.slice(toolSeparator + 2) === requested) {
+            if (mcpToolMatchesBaseName(activeName, requested)) {
                 scopedMatches.push(activeName);
             }
+            else if (isWorkflowAliasTool(activeName) && canonicalWorkflowToolName(activeName) === requested) {
+                aliasFallbacks.push(activeName);
+            }
+        }
+        // Only use alias as fallback when canonical is absent — not directly and not via MCP scoping.
+        // Prevents the alias from resurfacing alongside the canonical when both are in the active set.
+        if (!exact.has(requested) && scopedMatches.length === 0) {
+            scopedMatches.push(...aliasFallbacks);
         }
         if (requested.startsWith("browser_") && scopedMatches.length > 0) {
             for (const match of scopedMatches)
@@ -214,7 +221,7 @@ export function buildRunUatGsdToolSet(activeToolNames, registeredToolNames = act
         ...RUN_UAT_BROWSER_TOOL_NAMES,
     ]);
     const resolved = [...new Set(scoped)];
-    const unresolved = RUN_UAT_WORKFLOW_TOOL_NAMES.filter((tool) => !resolved.some((name) => name === tool || (name.startsWith("mcp__") && name.endsWith(`__${tool}`))));
+    const unresolved = RUN_UAT_WORKFLOW_TOOL_NAMES.filter((tool) => !resolved.some((name) => name === tool || mcpToolMatchesBaseName(name, tool)));
     if (unresolved.length > 0) {
         safetyLogWarning("bootstrap", `buildRunUatGsdToolSet: required run-uat workflow tool(s) not found in active/registered surface: ${unresolved.join(", ")}. Session may lack gsd-workflow MCP connection.`);
     }
@@ -271,7 +278,17 @@ function applyMinimalGsdToolSurface(pi) {
         return;
     const dash = getAutoRuntimeSnapshot();
     if (dash.active && dash.currentUnit) {
-        pi.setActiveTools(buildMinimalAutoGsdToolSet(pi.getActiveTools(), dash.currentUnit.type, resolveRegisteredToolNames(pi, pi.getActiveTools())));
+        const currentToolNames = pi.getActiveTools();
+        const registeredToolNames = resolveRegisteredToolNames(pi, currentToolNames);
+        const scopedToolNames = buildMinimalAutoGsdToolSet(currentToolNames, dash.currentUnit.type, registeredToolNames);
+        recordAutoToolSurfaceSnapshot({
+            source: "runtime-scope",
+            unitType: dash.currentUnit.type,
+            modelFacingToolNames: scopedToolNames,
+            registeredToolNames,
+            scopedToolNames,
+        });
+        pi.setActiveTools(scopedToolNames);
         return;
     }
     if (!isGeneralGsdToolScopingRequested())
@@ -286,6 +303,13 @@ export function scopeGsdWorkflowToolsForDispatch(pi, unitType) {
     const scoped = unitType
         ? buildMinimalAutoGsdToolSet(current, unitType, registeredToolNames)
         : buildMinimalGsdWorkflowToolSet(current, registeredToolNames);
+    recordAutoToolSurfaceSnapshot({
+        source: "dispatch-scope",
+        unitType,
+        modelFacingToolNames: scoped,
+        registeredToolNames,
+        scopedToolNames: scoped,
+    });
     const toolsChanged = !(scoped.length === current.length && scoped.every((name, index) => name === current[index]));
     const canScopeSkills = unitHasSkillManifest(unitType) && pi.getVisibleSkills && pi.setVisibleSkills;
     if (!toolsChanged && !canScopeSkills) {
@@ -540,6 +564,7 @@ function initSessionNotifications(ctx) {
     initNotificationStore(resolveNotificationStoreBasePath(contextBasePath(ctx)));
     installNotifyInterceptor(ctx);
     initNotificationWidget(ctx);
+    notifyPreferenceDiagnostics(ctx, contextBasePath(ctx), { surface: "session-start" });
 }
 async function prepareWorkflowMcpForHookContext(ctx, basePath) {
     // Skip MCP auto-prep when running inside an auto-worktree. The worktree
@@ -803,6 +828,20 @@ export function registerHooks(pi, ecosystemHandlers) {
     pi.on("message_update", async (event, ctx) => {
         if (approvalQuestionAbortInFlight)
             return;
+        // If the model asked via ask_user_questions, that in-flight elicitation IS
+        // the human boundary. Arming the pause/gate here (and emitting the "waiting
+        // for your approval - pausing" notice) would tear it down and trigger the
+        // foreground self-cancel/re-ask loop. The marker is set only by the
+        // claude-code-cli SDK elicitation handler and is ungated, so it is true in
+        // foreground; under the native-TUI provider it is always false and this path
+        // runs unchanged (#cc-elicitation-self-cancel).
+        if (isInteractiveElicitationInFlight())
+            return;
+        // Prose with "?" can stream before the MCP tool/elicitation starts. When the
+        // structured ask_user_questions call is already in the partial message, the
+        // tool IS the human boundary — do not arm the text-based approval pause.
+        if (messageHasPendingAskUserQuestionsTool(event.message))
+            return;
         const dash = getAutoRuntimeSnapshot();
         if (dash.active)
             return;
@@ -1071,77 +1110,32 @@ export function registerHooks(pi, ecosystemHandlers) {
         const basePath = contextBasePath(ctx);
         const milestoneId = await getDiscussionMilestoneIdFor(basePath);
         const details = event.details;
-        // ── Discussion gate enforcement: handle gate question responses ──
-        // If the result is cancelled or has no response, the pending gate stays active
-        // so the model is blocked from non-read-only tools until it re-asks.
-        // If the user responded at all (even "needs adjustment"), clear the pending gate
-        // because the user engaged — the prompt handles the re-ask-after-adjustment flow.
         const questions = event.input?.questions ?? [];
-        const currentPendingGate = getPendingGate(basePath);
-        if (currentPendingGate) {
-            if (details?.cancelled || !details?.response) {
-                // Gate stays pending. Direct the agent to the most reliable recovery
-                // path — re-calling ask_user_questions with the same gate id — without
-                // misrepresenting the plain-text path. The plain-text path also works
-                // (isExplicitApprovalResponse on the next before_agent_start clears
-                // the gate when the user replies with an approval keyword), but the
-                // structured re-ask is more deterministic and gives the user a clear UI.
-                resetToolCallLoopGuard();
-                const interrupted = details?.interrupted === true;
-                if (ctx) {
-                    await maybePauseAutoForApprovalGate(ctx, pi, true, interrupted
-                        ? "Depth confirmation was interrupted — pausing auto-mode until you respond."
-                        : "Depth confirmation is waiting for your answer — pausing auto-mode.");
-                }
-                return {
-                    content: [{
-                            type: "text",
-                            text: [
-                                `Waiting for depth confirmation on gate "${currentPendingGate}".`,
-                                interrupted
-                                    ? "The confirmation question was interrupted before a response was recorded."
-                                    : "No user response was received for the confirmation question.",
-                                "Do not infer approval from earlier or prior messages.",
-                                "Do not proceed, write files, save artifacts, or call other tools.",
-                                `Re-call ask_user_questions with the same gate question id ("${currentPendingGate}") and wait for the user's response.`,
-                            ].join(" "),
-                        }],
-                };
-            }
-            else {
-                const pendingQuestion = questions.find((question) => question?.id === currentPendingGate);
-                if (pendingQuestion) {
-                    const answer = details.response?.answers?.[currentPendingGate];
-                    if (isDepthConfirmationAnswer(answer?.selected, pendingQuestion.options)) {
-                        markApprovalGateVerified(currentPendingGate, basePath);
-                        const milestoneIdFromGate = extractDepthVerificationMilestoneId(currentPendingGate);
-                        if (milestoneIdFromGate)
-                            markDepthVerified(milestoneIdFromGate, basePath);
-                        clearPendingGate(basePath);
-                        clearDeferredApprovalGate(basePath);
-                    }
-                }
+        const gateResult = applyAskUserQuestionsGateResult({
+            basePath,
+            questions,
+            details,
+            fallbackMilestoneId: milestoneId,
+        });
+        if (gateResult.status === "waiting") {
+            resetToolCallLoopGuard();
+            if (ctx) {
+                await maybePauseAutoForApprovalGate(ctx, pi, true, gateResult.interrupted
+                    ? "Depth confirmation was interrupted — pausing auto-mode until you respond."
+                    : "Depth confirmation is waiting for your answer — pausing auto-mode.");
             }
+            return {
+                content: [{
+                        type: "text",
+                        text: formatPendingAskUserQuestionsGateMessage(gateResult.pendingGateId, gateResult.interrupted),
+                    }],
+            };
+        }
+        if (gateResult.status === "verified") {
+            clearDeferredApprovalGate(basePath);
         }
         if (details?.cancelled || !details?.response)
             return;
-        for (const question of questions) {
-            if (typeof question.id === "string" && question.id.includes("depth_verification")) {
-                // Only unlock the gate if the user selected the first option (confirmation).
-                // Cross-references against the question's defined options to reject free-form "Other" text.
-                const answer = details.response?.answers?.[question.id];
-                const inferredMilestoneId = extractDepthVerificationMilestoneId(question.id) ?? milestoneId;
-                if (isDepthConfirmationAnswer(answer?.selected, question.options)) {
-                    if (currentPendingGate && question.id !== currentPendingGate)
-                        break;
-                    markApprovalGateVerified(question.id, basePath);
-                    markDepthVerified(inferredMilestoneId, basePath);
-                    clearPendingGate(basePath);
-                    clearDeferredApprovalGate(basePath);
-                }
-                break;
-            }
-        }
         if (!milestoneId)
             return;
         await saveDiscussionQuestionRound(basePath, milestoneId, questions, details);
@@ -1196,61 +1190,10 @@ export function registerHooks(pi, ecosystemHandlers) {
         const payload = event.payload;
         if (!payload || typeof payload !== "object")
             return;
-        // ── Context Management ──────────────────────────────────────────────
-        // Load preferences once for both masking and truncation.
-        try {
-            const { loadEffectiveGSDPreferences } = await import("../preferences.js");
-            const { createObservationMask, createResponsesInputObservationMask, truncateContextResultMessages, truncateResponsesInputResultItems, } = await import("../context-masker.js");
-            const prefs = loadEffectiveGSDPreferences();
-            const cmConfig = prefs?.preferences.context_management;
-            // Observation masking: replace old tool results with placeholders.
-            // Only active during auto-mode when context_management.observation_masking is enabled.
-            if (isAutoActive() && cmConfig?.observation_masking !== false) {
-                const keepTurns = cmConfig?.observation_mask_turns ?? 8;
-                const messages = payload.messages;
-                if (Array.isArray(messages)) {
-                    payload.messages = createObservationMask(keepTurns)(messages);
-                }
-                const input = payload.input;
-                if (Array.isArray(input)) {
-                    payload.input = createResponsesInputObservationMask(keepTurns)(input);
-                }
-            }
-            // Tool result truncation: cap individual tool result content length.
-            // Applies in ALL modes (auto + interactive) to prevent context bloat.
-            // In pi-ai format, toolResult messages have role: "toolResult" and content: TextContent[].
-            // Creates new objects to avoid mutating shared conversation state.
-            const maxChars = cmConfig?.tool_result_max_chars ?? 800;
-            const msgs = payload.messages;
-            if (Array.isArray(msgs)) {
-                payload.messages = truncateContextResultMessages(msgs, maxChars);
-            }
-            const input = payload.input;
-            if (Array.isArray(input)) {
-                payload.input = truncateResponsesInputResultItems(input, maxChars);
-            }
-        }
-        catch { /* non-fatal */ }
-        try {
-            if (isAutoActive()) {
-                const sourceContextBlock = getSourceObservationStore().renderActiveBlock();
-                if (sourceContextBlock) {
-                    const nextPayload = injectSourceContextBlockIntoPayload(payload, sourceContextBlock);
-                    Object.assign(payload, nextPayload);
-                }
-            }
-        }
-        catch { /* non-fatal */ }
-        // ── Service Tier ────────────────────────────────────────────────────
-        const modelId = event.model?.id;
-        if (!modelId)
-            return payload;
-        const { getEffectiveServiceTier, supportsServiceTier } = await import("../service-tier.js");
-        const tier = getEffectiveServiceTier();
-        if (!tier || !supportsServiceTier(modelId))
-            return payload;
-        payload.service_tier = tier;
-        return payload;
+        return applyProviderPayloadPolicy({
+            payload,
+            modelId: event.model?.id,
+        });
     });
     // Capability-aware model routing hook (ADR-004)
     // Extensions can override model selection by returning { modelId: "..." }
@@ -1282,16 +1225,35 @@ export function registerHooks(pi, ecosystemHandlers) {
         const registeredToolNames = resolveRegisteredToolNames(pi, event.activeToolNames);
         const compatibleRegisteredToolNames = filterToolsForProvider(registeredToolNames, event.selectedModelApi, event.selectedModelProvider).compatible.filter((name) => !(dropAliases && isWorkflowAliasTool(name)));
         const guidedUnit = getGuidedUnitContext();
-        const requestScoped = buildRequestScopedGsdToolSet(guidedUnit?.unitType === "run-uat" ? aliasFilteredCompatible : providerCompatible, event.requestCustomMessages, guidedUnit?.unitType === "run-uat" ? compatibleRegisteredToolNames : registeredToolNames, guidedUnit?.unitType);
+        const requestRegisteredToolNames = guidedUnit?.unitType === "run-uat"
+            ? compatibleRegisteredToolNames
+            : registeredToolNames;
+        const requestScoped = buildRequestScopedGsdToolSet(guidedUnit?.unitType === "run-uat" ? aliasFilteredCompatible : providerCompatible, event.requestCustomMessages, requestRegisteredToolNames, guidedUnit?.unitType);
         if (requestScoped) {
+            recordAutoToolSurfaceSnapshot({
+                source: "provider-adjustment",
+                unitType: guidedUnit?.unitType,
+                modelFacingToolNames: requestScoped,
+                registeredToolNames: requestRegisteredToolNames,
+                scopedToolNames: requestScoped,
+            });
             return { toolNames: requestScoped };
         }
         const dash = getAutoRuntimeSnapshot();
         if (dash.active && dash.currentUnit) {
+            const registeredForUnit = dash.currentUnit.type === "run-uat"
+                ? compatibleRegisteredToolNames
+                : resolveRegisteredToolNames(pi, event.activeToolNames);
+            const scopedToolNames = buildMinimalAutoGsdToolSet(dash.currentUnit.type === "run-uat" ? aliasFilteredCompatible : providerCompatible, dash.currentUnit.type, registeredForUnit);
+            recordAutoToolSurfaceSnapshot({
+                source: "provider-adjustment",
+                unitType: dash.currentUnit.type,
+                modelFacingToolNames: scopedToolNames,
+                registeredToolNames: registeredForUnit,
+                scopedToolNames,
+            });
             return {
-                toolNames: buildMinimalAutoGsdToolSet(dash.currentUnit.type === "run-uat" ? aliasFilteredCompatible : providerCompatible, dash.currentUnit.type, dash.currentUnit.type === "run-uat"
-                    ? compatibleRegisteredToolNames
-                    : resolveRegisteredToolNames(pi, event.activeToolNames)),
+                toolNames: scopedToolNames,
             };
         }
         if (isGeneralGsdToolScopingRequested()) {

package/dist/resources/extensions/gsd/bootstrap/write-gate.js

@@ -3,6 +3,7 @@ import { copyFileSync, existsSync, lstatSync, mkdirSync, readFileSync, readlinkS
 import { isAbsolute, join, relative, resolve, sep } from "node:path";
 import { minimatch } from "minimatch";
 import { GSD_PHASE_SCOPE_DISPLAY_REASON, shouldBlockAutoUnitToolCall } from "../auto-unit-tool-scope.js";
+import { stripMcpToolPrefix } from "../mcp-tool-name.js";
 import { getIsolationMode } from "../preferences.js";
 import { compileSubagentPermissionContract } from "../unit-context-manifest.js";
 import { logWarning } from "../workflow-logger.js";
@@ -102,10 +103,7 @@ const GATE_SAFE_TOOLS = new Set([
     "ask_user_questions",
 ]);
 export function canonicalToolName(toolName) {
-    if (!toolName.startsWith("mcp__"))
-        return toolName;
-    const toolSeparator = toolName.indexOf("__", "mcp__".length);
-    return toolSeparator >= 0 ? toolName.slice(toolSeparator + 2) : toolName;
+    return stripMcpToolPrefix(toolName);
 }
 /**
  * Persistence is ON by default (opt-out).
@@ -385,6 +383,67 @@ export function isDepthConfirmationAnswer(selected, options) {
     // Returning false prevents any free-form string from unlocking the gate.
     return false;
 }
+function findGateQuestion(questions, gateId) {
+    return questions.find((question) => question?.id === gateId);
+}
+function readSelectedGateAnswer(details, questionId) {
+    return details.response?.answers?.[questionId]?.selected;
+}
+function verifyAnsweredGate(basePath, question, fallbackMilestoneId) {
+    const gateId = typeof question.id === "string" ? question.id : "";
+    const milestoneId = extractDepthVerificationMilestoneId(gateId) ?? fallbackMilestoneId ?? null;
+    markApprovalGateVerified(gateId, basePath);
+    markDepthVerified(milestoneId, basePath);
+    clearPendingGate(basePath);
+    return { status: "verified", gateId, milestoneId };
+}
+export function applyAskUserQuestionsGateResult(options) {
+    const { basePath, questions, details, fallbackMilestoneId } = options;
+    const currentPendingGate = getPendingGate(basePath);
+    if (currentPendingGate) {
+        if (details.cancelled || !details.response) {
+            return {
+                status: "waiting",
+                pendingGateId: currentPendingGate,
+                interrupted: details.interrupted === true,
+            };
+        }
+        const pendingQuestion = findGateQuestion(questions, currentPendingGate);
+        if (pendingQuestion) {
+            const selected = readSelectedGateAnswer(details, currentPendingGate);
+            if (isDepthConfirmationAnswer(selected, pendingQuestion.options)) {
+                return verifyAnsweredGate(basePath, pendingQuestion, fallbackMilestoneId);
+            }
+            return { status: "answered", gateId: currentPendingGate };
+        }
+    }
+    if (details.cancelled || !details.response)
+        return { status: "not-gate" };
+    for (const question of questions) {
+        if (typeof question.id !== "string" || !isGateQuestionId(question.id))
+            continue;
+        const selected = readSelectedGateAnswer(details, question.id);
+        if (!isDepthConfirmationAnswer(selected, question.options)) {
+            return { status: "answered", gateId: question.id };
+        }
+        if (currentPendingGate && question.id !== currentPendingGate) {
+            return { status: "answered", gateId: currentPendingGate };
+        }
+        return verifyAnsweredGate(basePath, question, fallbackMilestoneId);
+    }
+    return { status: "not-gate" };
+}
+export function formatPendingAskUserQuestionsGateMessage(pendingGateId, interrupted) {
+    return [
+        `Waiting for depth confirmation on gate "${pendingGateId}".`,
+        interrupted
+            ? "The confirmation question was interrupted before a response was recorded."
+            : "No user response was received for the confirmation question.",
+        "Do not infer approval from earlier or prior messages.",
+        "Do not proceed, write files, save artifacts, or call other tools.",
+        `Re-call ask_user_questions with the same gate question id ("${pendingGateId}") and wait for the user's response.`,
+    ].join(" ");
+}
 export function shouldBlockContextWrite(toolName, inputPath, milestoneId, _queuePhaseActive, basePath = process.cwd()) {
     if (toolName !== "write")
         return { block: false };

package/dist/resources/extensions/gsd/closeout-consistency-gate.js

@@ -1,7 +1,10 @@
 // Project/App: gsd-pi
 // File Purpose: Shared DB-backed guard for milestone closeout finalization.
-import { getDbPath, getLatestAssessmentByScope, getMilestone, getMilestoneSlices, getPendingGates, getSliceTasks, isDbAvailable, refreshOpenDatabaseFromDisk, } from "./gsd-db.js";
+import { dirname } from "node:path";
+import { getLatestAssessmentByScope, getMilestone, getMilestoneSlices, getPendingGates, getSliceTasks, isDbAvailable, } from "./gsd-db.js";
+import { getWorkflowDatabasePath, refreshWorkflowDatabaseFromDisk, } from "./db-workspace.js";
 import { isClosedStatus } from "./status-guards.js";
+import { closeQualityGatesFromEvidence } from "./quality-gate-closure.js";
 export const CLOSEOUT_CONSISTENCY_BLOCKED_REASON = "closeout-consistency-blocked";
 function blocked(reason, message) {
     return {
@@ -14,22 +17,30 @@ function blocked(reason, message) {
 function isFileBackedDbPath(path) {
     return Boolean(path && path !== ":memory:");
 }
+function artifactBasePathFromDb() {
+    const dbPath = getWorkflowDatabasePath();
+    if (!isFileBackedDbPath(dbPath))
+        return undefined;
+    return dirname(dirname(dbPath));
+}
 export function checkCloseoutConsistencyGate(milestoneId, options = {}) {
     if (!isDbAvailable()) {
         return blocked("db-unavailable", `Closeout consistency blocked for ${milestoneId}: canonical DB is unavailable.`);
     }
-    if (options.refreshFromDisk && isFileBackedDbPath(getDbPath()) && !refreshOpenDatabaseFromDisk()) {
+    if (options.refreshFromDisk && isFileBackedDbPath(getWorkflowDatabasePath()) && !refreshWorkflowDatabaseFromDisk()) {
         return blocked("db-refresh-failed", `Closeout consistency blocked for ${milestoneId}: canonical DB refresh failed.`);
     }
     const milestone = getMilestone(milestoneId);
     if (!milestone) {
         return blocked("milestone-missing", `Closeout consistency blocked for ${milestoneId}: milestone is missing from canonical DB.`);
     }
-    if (!isClosedStatus(milestone.status)) {
+    if (!isClosedStatus(milestone.status) && !options.allowOpenMilestone) {
         return blocked("milestone-open", `Closeout consistency blocked for ${milestoneId}: canonical DB milestone status is "${milestone.status}".`);
     }
+    const validation = milestone.status === "skipped"
+        ? null
+        : getLatestAssessmentByScope(milestoneId, "milestone-validation");
     if (milestone.status !== "skipped") {
-        const validation = getLatestAssessmentByScope(milestoneId, "milestone-validation");
         if (validation?.status !== "pass") {
             return blocked("validation-not-pass", `Closeout consistency blocked for ${milestoneId}: latest milestone validation is "${validation?.status ?? "absent"}".`);
         }
@@ -38,6 +49,12 @@ export function checkCloseoutConsistencyGate(milestoneId, options = {}) {
     if (slices.length === 0 && milestone.status !== "skipped") {
         return blocked("slice-missing", `Closeout consistency blocked for ${milestoneId}: no slices exist in canonical DB.`);
     }
+    if (milestone.status !== "skipped") {
+        closeQualityGatesFromEvidence(milestoneId, {
+            artifactBasePath: options.artifactBasePath ?? artifactBasePathFromDb(),
+            milestoneValidationPassed: validation?.status === "pass",
+        });
+    }
     for (const slice of slices) {
         if (!isClosedStatus(slice.status)) {
             return blocked("slice-open", `Closeout consistency blocked for ${milestoneId}: slice ${slice.id} status is "${slice.status}".`);

package/dist/resources/extensions/gsd/codebase-generator.js

@@ -330,15 +330,19 @@ export function ensureCodebaseMapFresh(basePath, options, ensureOptions) {
     const ttlMs = ensureOptions?.ttlMs ?? DEFAULT_REFRESH_TTL_MS;
     const force = ensureOptions?.force === true;
     const now = Date.now();
+    // Enumerate files and compute fingerprint before the TTL check so that
+    // file changes are always detected, even within the TTL window.
+    const existing = readCodebaseMap(basePath);
+    const listed = enumerateFiles(basePath, resolved.excludes, resolved.maxFiles);
+    const fingerprint = computeCodebaseFingerprint(listed.files, resolved, listed.truncated);
+    // TTL short-circuit: only bypass regeneration when the fingerprint matches,
+    // confirming that no tracked files changed since the last check.
     if (!force && ttlMs > 0) {
         const cached = freshnessCache.get(cacheKey);
-        if (cached && now - cached.checkedAt < ttlMs) {
+        if (cached && now - cached.checkedAt < ttlMs && cached.result.fingerprint === fingerprint) {
             return cached.result;
         }
     }
-    const existing = readCodebaseMap(basePath);
-    const listed = enumerateFiles(basePath, resolved.excludes, resolved.maxFiles);
-    const fingerprint = computeCodebaseFingerprint(listed.files, resolved, listed.truncated);
     const cacheAndReturn = (result) => {
         freshnessCache.set(cacheKey, { checkedAt: now, result });
         return result;

package/dist/resources/extensions/gsd/commands/handlers/auto.js

@@ -3,6 +3,7 @@ import { resolve } from "node:path";
 import { enableDebug } from "../../debug-logger.js";
 import { isAutoActive, isAutoPaused, pauseAuto, startAutoDetached, stopAuto, stopAutoRemote } from "../../auto.js";
 import { handleRate } from "../../commands-rate.js";
+import { notifyPreferenceDiagnostics } from "../../preferences-diagnostics.js";
 import { setSessionModelOverride } from "../../session-model-override.js";
 import { guardRemoteSession, projectRoot } from "../context.js";
 import { findMilestoneIds } from "../../milestone-id-utils.js";
@@ -82,6 +83,7 @@ export async function handleAutoCommand(trimmed, ctx, pi) {
         const basePath = projectRoot();
         if (await hasUnresolvedCloseoutBlocker(ctx, basePath))
             return true;
+        notifyPreferenceDiagnostics(ctx, basePath, { surface: "auto-preflight" });
         // Validate the milestone target exists and is not already complete.
         if (milestoneId) {
             const allIds = findMilestoneIds(basePath);
@@ -109,6 +111,7 @@ export async function handleAutoCommand(trimmed, ctx, pi) {
         const basePath = projectRoot();
         if (await hasUnresolvedCloseoutBlocker(ctx, basePath))
             return true;
+        notifyPreferenceDiagnostics(ctx, basePath, { surface: "auto-preflight" });
         // Validate the milestone target exists and is not already complete.
         if (milestoneId) {
             const allIds = findMilestoneIds(basePath);

package/dist/resources/extensions/gsd/commands-handlers.js

@@ -19,6 +19,7 @@ import { isAutoActive, checkRemoteAutoSession } from "./auto.js";
 import { getAutoWorktreePath } from "./auto-worktree.js";
 import { currentDirectoryRoot, projectRoot } from "./commands/context.js";
 import { loadPrompt } from "./prompt-loader.js";
+import { buildClaudeRuntimeFloorAdvisory } from "../../shared/claude-runtime-floor.js";
 import { isPnpmInstall } from "../../shared/package-manager-detection.js";
 import { buildDoctorHealIssuePayload, buildDoctorHealSummary, buildWorkflowDispatchContent, } from "./workflow-protocol.js";
 import { restoreGsdWorkflowTools, scopeGsdWorkflowToolsForDispatch, } from "./bootstrap/register-hooks.js";
@@ -52,6 +53,21 @@ function resolveInstallCommand(pkg) {
         return `pnpm add -g ${pkg}`;
     return `npm install -g ${pkg}`;
 }
+function notifyClaudeRuntimeFloorAdvisory(ctx) {
+    let advisory = null;
+    try {
+        advisory = buildClaudeRuntimeFloorAdvisory({
+            agentDir: join(gsdHome(), "agent"),
+            cwd: process.cwd(),
+        });
+    }
+    catch {
+        return;
+    }
+    if (advisory) {
+        ctx.ui.notify(advisory, "warning");
+    }
+}
 async function fetchLatestVersionForCommand(registryUrl = UPDATE_REGISTRY_URL) {
     const controller = new AbortController();
     const timeout = setTimeout(() => controller.abort(), UPDATE_FETCH_TIMEOUT_MS);
@@ -458,6 +474,8 @@ export async function handleUpdate(ctx, args = "") {
     }
     if (current && compareSemverLocal(latest, current) <= 0) {
         ctx.ui.notify(`Already up to date (${formatCommandVersion(current)}).`, "info");
+        if (!browserUpdate)
+            notifyClaudeRuntimeFloorAdvisory(ctx);
         return;
     }
     ctx.ui.notify(`Updating: ${formatCommandVersion(current)} → v${latest}...`, "info");
@@ -472,6 +490,8 @@ export async function handleUpdate(ctx, args = "") {
             ? `Updated gsd-browser to v${latest}. Restart your GSD session to use the new browser automation version.` +
                 (pathReady ? "" : "\nNote: Ensure the npm global bin directory is on your PATH so MCP automation uses the updated binary.")
             : `Updated to v${latest}. Restart your GSD session to use the new version.`, "info");
+        if (!browserUpdate)
+            notifyClaudeRuntimeFloorAdvisory(ctx);
     }
     catch {
         ctx.ui.notify(`Update failed. Try manually: ${installCmd}`, "error");

package/dist/resources/extensions/gsd/commands-inspect.js

@@ -3,9 +3,7 @@
  *
  * Contains: InspectData type, formatInspectOutput, handleInspect
  */
-import { existsSync } from "node:fs";
-import { join } from "node:path";
-import { gsdRoot } from "./paths.js";
+import { isWorkflowDatabaseOpen, openExistingWorkflowDatabase, } from "./db-workspace.js";
 import { logWarning } from "./workflow-logger.js";
 import { getErrorMessage } from "./error-utils.js";
 export function formatInspectOutput(data) {
@@ -34,11 +32,9 @@ export function formatInspectOutput(data) {
 }
 export async function handleInspect(ctx) {
     try {
-        const { isDbAvailable, _getAdapter, openDatabase } = await import("./gsd-db.js");
-        if (!isDbAvailable()) {
-            const gsdDir = gsdRoot(process.cwd());
-            const dbPath = join(gsdDir, "gsd.db");
-            if (!existsSync(gsdDir) || !existsSync(dbPath) || !openDatabase(dbPath)) {
+        const { _getAdapter } = await import("./gsd-db.js");
+        if (!isWorkflowDatabaseOpen()) {
+            if (!openExistingWorkflowDatabase(process.cwd()).ok) {
                 ctx.ui.notify("No GSD database available. Run /gsd auto to create one.", "info");
                 return;
             }