@opengsd/gsd-pi 1.2.0-dev.844675c9 → 1.2.0-dev.955e4da0

package/dist/resources/extensions/gsd/closeout-recovery.js

@@ -2,12 +2,13 @@
 // File Purpose: Closeout git failure discovery, retry, and manual resolution helpers.
 import { execFileSync } from "node:child_process";
 import { existsSync, realpathSync } from "node:fs";
-import { isAbsolute, join, resolve } from "node:path";
+import { isAbsolute, resolve } from "node:path";
 import { GIT_NO_PROMPT_ENV } from "./git-constants.js";
 import { runTurnGitAction } from "./git-service.js";
 import { _getAdapter, upsertTurnGitTransaction } from "./gsd-db.js";
 import { probeGitConflictState } from "./git-conflict-state.js";
 import { parseUnitId } from "./unit-id.js";
+import { worktreePathFor } from "./worktree-placement.js";
 function parseMetadata(value) {
     if (typeof value !== "string" || !value.trim())
         return {};
@@ -121,7 +122,7 @@ export function resolveCloseoutRecoveryBasePath(projectRoot, record) {
     const parsed = parseUnitId(record.unitId);
     const milestoneId = parsed.milestone ?? (/^M\d+(?:-[a-z0-9]{6})?/.exec(record.unitId)?.[0] ?? "");
     if (milestoneId) {
-        const worktreePath = existingRealPath(join(projectRoot, ".gsd", "worktrees", milestoneId));
+        const worktreePath = existingRealPath(worktreePathFor(projectRoot, milestoneId));
         if (worktreePath)
             return worktreePath;
     }

package/dist/resources/extensions/gsd/codebase-generator.js

@@ -330,15 +330,19 @@ export function ensureCodebaseMapFresh(basePath, options, ensureOptions) {
     const ttlMs = ensureOptions?.ttlMs ?? DEFAULT_REFRESH_TTL_MS;
     const force = ensureOptions?.force === true;
     const now = Date.now();
+    // Enumerate files and compute fingerprint before the TTL check so that
+    // file changes are always detected, even within the TTL window.
+    const existing = readCodebaseMap(basePath);
+    const listed = enumerateFiles(basePath, resolved.excludes, resolved.maxFiles);
+    const fingerprint = computeCodebaseFingerprint(listed.files, resolved, listed.truncated);
+    // TTL short-circuit: only bypass regeneration when the fingerprint matches,
+    // confirming that no tracked files changed since the last check.
     if (!force && ttlMs > 0) {
         const cached = freshnessCache.get(cacheKey);
-        if (cached && now - cached.checkedAt < ttlMs) {
+        if (cached && now - cached.checkedAt < ttlMs && cached.result.fingerprint === fingerprint) {
             return cached.result;
         }
     }
-    const existing = readCodebaseMap(basePath);
-    const listed = enumerateFiles(basePath, resolved.excludes, resolved.maxFiles);
-    const fingerprint = computeCodebaseFingerprint(listed.files, resolved, listed.truncated);
     const cacheAndReturn = (result) => {
         freshnessCache.set(cacheKey, { checkedAt: now, result });
         return result;

package/dist/resources/extensions/gsd/commands/catalog.js

@@ -1,7 +1,8 @@
 import { existsSync, readFileSync, readdirSync } from "node:fs";
-import { join, resolve } from "node:path";
+import { join } from "node:path";
 import { loadRegistry } from "../workflow-templates.js";
 import { gsdHome } from "../gsd-home.js";
+import { resolveWorktreeProjectRoot } from "../worktree-root.js";
 import { VISUAL_BRIEF_MODES } from "../../visual-brief/prompts.js";
 export const GSD_COMMAND_DESCRIPTION = "GSD — Git Ship Done: /gsd help|start|templates|next|auto|stop|pause|status|widget|visualize|brief|report|queue|quick|discuss|capture|triage|dispatch|verdict|history|undo|undo-task|reset-slice|rate|skip|export|cleanup|closeout|rebuild|model|mode|prefs|config|keys|hooks|run-hook|skill-health|doctor|debug|logs|forensics|changelog|migrate|remote|steer|knowledge|memory|new-milestone|new-project|parallel|cmux|park|unpark|init|setup|onboarding|inspect|extensions|update|upgrade|fast|mcp|rethink|workflow|codebase|notifications|ship|do|usage|context|session-report|backlog|pr-branch|add-tests|scan|language|worktree|eval-review";
 export const TOP_LEVEL_SUBCOMMANDS = [
@@ -380,70 +381,13 @@ function getExtensionCompletions(prefix, action) {
         return [];
     }
 }
-function normalizePathForCompare(path) {
-    return path.replaceAll("\\", "/").replace(/\/+$/, "");
-}
-function findWorktreeSegment(normalizedPath) {
-    const directMarker = "/.gsd/worktrees/";
-    const directIdx = normalizedPath.indexOf(directMarker);
-    if (directIdx !== -1) {
-        return { gsdIdx: directIdx, afterWorktrees: directIdx + directMarker.length };
-    }
-    const symlinkMatch = normalizedPath.match(/\/\.gsd\/projects\/[a-f0-9]+\/worktrees\//);
-    if (symlinkMatch?.index !== undefined) {
-        return { gsdIdx: symlinkMatch.index, afterWorktrees: symlinkMatch.index + symlinkMatch[0].length };
-    }
-    return null;
-}
-function resolveProjectRootFromGitFile(worktreePath) {
-    try {
-        let dir = worktreePath;
-        for (let i = 0; i < 30; i++) {
-            const gitPath = join(dir, ".git");
-            if (existsSync(gitPath)) {
-                const content = readFileSync(gitPath, "utf8").trim();
-                if (content.startsWith("gitdir: ")) {
-                    const gitDir = resolve(dir, content.slice(8));
-                    const dotGitDir = resolve(gitDir, "..", "..");
-                    if (dotGitDir.endsWith(".git") || dotGitDir.endsWith(".git/") || dotGitDir.endsWith(".git\\")) {
-                        return resolve(dotGitDir, "..");
-                    }
-                    const commonDirPath = join(gitDir, "commondir");
-                    if (existsSync(commonDirPath)) {
-                        const commonDir = readFileSync(commonDirPath, "utf8").trim();
-                        return resolve(resolve(gitDir, commonDir), "..");
-                    }
-                }
-                break;
-            }
-            const parent = resolve(dir, "..");
-            if (parent === dir)
-                break;
-            dir = parent;
-        }
-    }
-    catch {
-        // Completion must stay best-effort.
-    }
-    return null;
-}
 function resolveProjectRootForCompletion(basePath) {
+    // Completion honors GSD_PROJECT_ROOT unconditionally (worker processes may
+    // complete from any cwd); resolveWorktreeProjectRoot only honors it for
+    // worktree paths.
     if (process.env.GSD_PROJECT_ROOT)
         return process.env.GSD_PROJECT_ROOT;
-    const normalizedPath = normalizePathForCompare(basePath);
-    const segment = findWorktreeSegment(normalizedPath);
-    if (!segment)
-        return basePath;
-    const separator = basePath.includes("\\") ? "\\" : "/";
-    const gsdMarker = `${separator}.gsd${separator}`;
-    const gsdIdx = basePath.indexOf(gsdMarker);
-    const candidate = gsdIdx !== -1 ? basePath.slice(0, gsdIdx) : basePath.slice(0, segment.gsdIdx);
-    const normalizedGsdHome = normalizePathForCompare(gsdHome());
-    const candidateGsdPath = normalizePathForCompare(join(candidate, ".gsd"));
-    if (candidateGsdPath === normalizedGsdHome || candidateGsdPath.startsWith(`${normalizedGsdHome}/`)) {
-        return resolveProjectRootFromGitFile(basePath) ?? basePath;
-    }
-    return candidate;
+    return resolveWorktreeProjectRoot(basePath);
 }
 export function getGsdArgumentCompletions(prefix) {
     const hasTrailingSpace = prefix.endsWith(" ");

package/dist/resources/extensions/gsd/commands/handlers/auto.js

@@ -3,6 +3,7 @@ import { resolve } from "node:path";
 import { enableDebug } from "../../debug-logger.js";
 import { isAutoActive, isAutoPaused, pauseAuto, startAutoDetached, stopAuto, stopAutoRemote } from "../../auto.js";
 import { handleRate } from "../../commands-rate.js";
+import { notifyPreferenceDiagnostics } from "../../preferences-diagnostics.js";
 import { setSessionModelOverride } from "../../session-model-override.js";
 import { guardRemoteSession, projectRoot } from "../context.js";
 import { findMilestoneIds } from "../../milestone-id-utils.js";
@@ -82,6 +83,7 @@ export async function handleAutoCommand(trimmed, ctx, pi) {
         const basePath = projectRoot();
         if (await hasUnresolvedCloseoutBlocker(ctx, basePath))
             return true;
+        notifyPreferenceDiagnostics(ctx, basePath, { surface: "auto-preflight" });
         // Validate the milestone target exists and is not already complete.
         if (milestoneId) {
             const allIds = findMilestoneIds(basePath);
@@ -109,6 +111,7 @@ export async function handleAutoCommand(trimmed, ctx, pi) {
         const basePath = projectRoot();
         if (await hasUnresolvedCloseoutBlocker(ctx, basePath))
             return true;
+        notifyPreferenceDiagnostics(ctx, basePath, { surface: "auto-preflight" });
         // Validate the milestone target exists and is not already complete.
         if (milestoneId) {
             const allIds = findMilestoneIds(basePath);

package/dist/resources/extensions/gsd/commands-handlers.js

@@ -19,6 +19,7 @@ import { isAutoActive, checkRemoteAutoSession } from "./auto.js";
 import { getAutoWorktreePath } from "./auto-worktree.js";
 import { currentDirectoryRoot, projectRoot } from "./commands/context.js";
 import { loadPrompt } from "./prompt-loader.js";
+import { buildClaudeRuntimeFloorAdvisory } from "../../shared/claude-runtime-floor.js";
 import { isPnpmInstall } from "../../shared/package-manager-detection.js";
 import { buildDoctorHealIssuePayload, buildDoctorHealSummary, buildWorkflowDispatchContent, } from "./workflow-protocol.js";
 import { restoreGsdWorkflowTools, scopeGsdWorkflowToolsForDispatch, } from "./bootstrap/register-hooks.js";
@@ -52,6 +53,21 @@ function resolveInstallCommand(pkg) {
         return `pnpm add -g ${pkg}`;
     return `npm install -g ${pkg}`;
 }
+function notifyClaudeRuntimeFloorAdvisory(ctx) {
+    let advisory = null;
+    try {
+        advisory = buildClaudeRuntimeFloorAdvisory({
+            agentDir: join(gsdHome(), "agent"),
+            cwd: process.cwd(),
+        });
+    }
+    catch {
+        return;
+    }
+    if (advisory) {
+        ctx.ui.notify(advisory, "warning");
+    }
+}
 async function fetchLatestVersionForCommand(registryUrl = UPDATE_REGISTRY_URL) {
     const controller = new AbortController();
     const timeout = setTimeout(() => controller.abort(), UPDATE_FETCH_TIMEOUT_MS);
@@ -458,6 +474,8 @@ export async function handleUpdate(ctx, args = "") {
     }
     if (current && compareSemverLocal(latest, current) <= 0) {
         ctx.ui.notify(`Already up to date (${formatCommandVersion(current)}).`, "info");
+        if (!browserUpdate)
+            notifyClaudeRuntimeFloorAdvisory(ctx);
         return;
     }
     ctx.ui.notify(`Updating: ${formatCommandVersion(current)} → v${latest}...`, "info");
@@ -472,6 +490,8 @@ export async function handleUpdate(ctx, args = "") {
             ? `Updated gsd-browser to v${latest}. Restart your GSD session to use the new browser automation version.` +
                 (pathReady ? "" : "\nNote: Ensure the npm global bin directory is on your PATH so MCP automation uses the updated binary.")
             : `Updated to v${latest}. Restart your GSD session to use the new version.`, "info");
+        if (!browserUpdate)
+            notifyClaudeRuntimeFloorAdvisory(ctx);
     }
     catch {
         ctx.ui.notify(`Update failed. Try manually: ${installCmd}`, "error");

package/dist/resources/extensions/gsd/commands-inspect.js

@@ -3,9 +3,7 @@
  *
  * Contains: InspectData type, formatInspectOutput, handleInspect
  */
-import { existsSync } from "node:fs";
-import { join } from "node:path";
-import { gsdRoot } from "./paths.js";
+import { isWorkflowDatabaseOpen, openExistingWorkflowDatabase, } from "./db-workspace.js";
 import { logWarning } from "./workflow-logger.js";
 import { getErrorMessage } from "./error-utils.js";
 export function formatInspectOutput(data) {
@@ -34,11 +32,9 @@ export function formatInspectOutput(data) {
 }
 export async function handleInspect(ctx) {
     try {
-        const { isDbAvailable, _getAdapter, openDatabase } = await import("./gsd-db.js");
-        if (!isDbAvailable()) {
-            const gsdDir = gsdRoot(process.cwd());
-            const dbPath = join(gsdDir, "gsd.db");
-            if (!existsSync(gsdDir) || !existsSync(dbPath) || !openDatabase(dbPath)) {
+        const { _getAdapter } = await import("./gsd-db.js");
+        if (!isWorkflowDatabaseOpen()) {
+            if (!openExistingWorkflowDatabase(process.cwd()).ok) {
                 ctx.ui.notify("No GSD database available. Run /gsd auto to create one.", "info");
                 return;
             }

package/dist/resources/extensions/gsd/commands-maintenance.js

@@ -9,6 +9,7 @@ import { deriveState } from "./state.js";
 import { gsdProjectionRoot, gsdRoot } from "./paths.js";
 import { nativeBranchList, nativeDetectMainBranch, nativeBranchListMerged, nativeBranchDelete, nativeForEachRef, nativeUpdateRef } from "./native-git-bridge.js";
 import { logWarning } from "./workflow-logger.js";
+import { backupWorkflowDatabaseSnapshot, refreshWorkflowDatabaseFromDisk } from "./db-workspace.js";
 export async function handleCleanupBranches(ctx, basePath) {
     let branches;
     try {
@@ -511,7 +512,7 @@ async function confirmRecover(ctx, args, markdown, beforeDb, dataLoss) {
  * Prints counts of recovered items and the resulting project phase.
  */
 export async function handleRecover(ctx, basePath, args = "") {
-    const { isDbAvailable: dbAvailable, clearEngineHierarchy, transaction: dbTransaction, backupDatabaseSnapshot } = await import("./gsd-db.js");
+    const { isDbAvailable: dbAvailable, clearEngineHierarchy, transaction: dbTransaction } = await import("./gsd-db.js");
     const { migrateHierarchyToDb } = await import("./md-importer.js");
     const { invalidateStateCache } = await import("./state.js");
     const { countDbHierarchy, countMarkdownHierarchy, recoverWouldDeleteDbRows } = await import("./migration-auto-check.js");
@@ -531,7 +532,7 @@ export async function handleRecover(ctx, basePath, args = "") {
         return;
     try {
         // 0. Snapshot the DB before the destructive clear so recover is reversible.
-        const backupPath = backupDatabaseSnapshot("pre-recover");
+        const backupPath = backupWorkflowDatabaseSnapshot("pre-recover");
         // 1. Delete + re-populate inside a single transaction for atomicity.
         //    clearEngineHierarchy() uses transaction() internally but transaction()
         //    is re-entrant, so wrapping in dbTransaction() keeps the whole
@@ -655,6 +656,49 @@ function parseRebuildTarget(args) {
         return "database";
     return "usage";
 }
+/**
+ * Re-render markdown planning projections from the authoritative DB.
+ *
+ * Quarantines open-unit SUMMARY files that contradict DB status before
+ * rendering. Safe to call after milestone merge/transition or during startup
+ * self-heal when the DB holds rows markdown lacks.
+ */
+export async function rebuildMarkdownProjectionsFromDb(basePath) {
+    const { deleteArtifactByPath } = await import("./gsd-db.js");
+    const { detectArtifactDbDrift } = await import("./state-reconciliation/drift/artifact-db.js");
+    const { renderAllFromDb } = await import("./markdown-renderer.js");
+    const { invalidateStateCache } = await import("./state.js");
+    invalidateStateCache();
+    refreshWorkflowDatabaseFromDisk();
+    const state = await deriveState(basePath);
+    const drifts = detectArtifactDbDrift(state, { basePath, state });
+    const stamp = new Date().toISOString().replace(/[:.]/g, "-");
+    const quarantined = [];
+    const seen = new Set();
+    for (const drift of drifts) {
+        if (drift.kind !== "artifact-db-status-divergence")
+            continue;
+        if (drift.artifactType !== "SUMMARY" || !drift.artifactPath)
+            continue;
+        const absPath = resolveDiskArtifactPath(basePath, drift.artifactPath);
+        if (seen.has(absPath) || !existsSync(absPath))
+            continue;
+        seen.add(absPath);
+        const artifactDbPath = artifactPathForDb(basePath, absPath);
+        const target = quarantineProjectionFile(basePath, absPath, stamp);
+        deleteArtifactByPath(artifactDbPath);
+        quarantined.push(target);
+    }
+    const rendered = await renderAllFromDb(basePath);
+    invalidateStateCache();
+    return {
+        rendered: rendered.rendered,
+        skipped: rendered.skipped,
+        errors: rendered.errors,
+        quarantined: quarantined.length,
+        quarantinedPaths: quarantined,
+    };
+}
 /**
  * `gsd rebuild markdown` — Re-render markdown projections from the authoritative DB.
  *
@@ -663,10 +707,7 @@ function parseRebuildTarget(args) {
  * under `.gsd/quarantine/projections/` before DB projections are rendered.
  */
 export async function handleRebuild(ctx, basePath, args = "") {
-    const { isDbAvailable: dbAvailable, deleteArtifactByPath } = await import("./gsd-db.js");
-    const { detectArtifactDbDrift } = await import("./state-reconciliation/drift/artifact-db.js");
-    const { renderAllFromDb } = await import("./markdown-renderer.js");
-    const { invalidateStateCache } = await import("./state.js");
+    const { isDbAvailable: dbAvailable } = await import("./gsd-db.js");
     const target = parseRebuildTarget(args);
     if (target === "usage") {
         ctx.ui.notify([
@@ -690,53 +731,32 @@ export async function handleRebuild(ctx, basePath, args = "") {
         return;
     }
     try {
-        invalidateStateCache();
-        const state = await deriveState(basePath);
-        const drifts = detectArtifactDbDrift(state, { basePath, state });
-        const stamp = new Date().toISOString().replace(/[:.]/g, "-");
-        const quarantined = [];
-        const seen = new Set();
-        for (const drift of drifts) {
-            if (drift.kind !== "artifact-db-status-divergence")
-                continue;
-            if (drift.artifactType !== "SUMMARY" || !drift.artifactPath)
-                continue;
-            const absPath = resolveDiskArtifactPath(basePath, drift.artifactPath);
-            if (seen.has(absPath) || !existsSync(absPath))
-                continue;
-            seen.add(absPath);
-            const artifactDbPath = artifactPathForDb(basePath, absPath);
-            const target = quarantineProjectionFile(basePath, absPath, stamp);
-            deleteArtifactByPath(artifactDbPath);
-            quarantined.push(target);
-        }
-        const rendered = await renderAllFromDb(basePath);
-        invalidateStateCache();
+        const result = await rebuildMarkdownProjectionsFromDb(basePath);
         const lines = [
             "gsd rebuild markdown: rebuilt markdown projections from the canonical DB",
-            `  Rendered:    ${rendered.rendered}`,
-            `  Skipped:     ${rendered.skipped}`,
-            `  Quarantined: ${quarantined.length}`,
+            `  Rendered:    ${result.rendered}`,
+            `  Skipped:     ${result.skipped}`,
+            `  Quarantined: ${result.quarantined}`,
         ];
-        if (rendered.errors.length > 0) {
-            lines.push(`  Errors:      ${rendered.errors.length}`);
-            for (const err of rendered.errors.slice(0, 5)) {
+        if (result.errors.length > 0) {
+            lines.push(`  Errors:      ${result.errors.length}`);
+            for (const err of result.errors.slice(0, 5)) {
                 lines.push(`    - ${err}`);
             }
-            if (rendered.errors.length > 5) {
-                lines.push(`    - ${rendered.errors.length - 5} more`);
+            if (result.errors.length > 5) {
+                lines.push(`    - ${result.errors.length - 5} more`);
             }
         }
-        if (quarantined.length > 0) {
+        if (result.quarantined > 0) {
             lines.push("", "  Quarantine:");
-            for (const target of quarantined.slice(0, 5)) {
+            for (const target of result.quarantinedPaths.slice(0, 5)) {
                 lines.push(`    - ${target}`);
             }
-            if (quarantined.length > 5) {
-                lines.push(`    - ${quarantined.length - 5} more`);
+            if (result.quarantined > 5) {
+                lines.push(`    - ${result.quarantined - 5} more`);
             }
         }
-        ctx.ui.notify(lines.join("\n"), rendered.errors.length > 0 ? "warning" : "success");
+        ctx.ui.notify(lines.join("\n"), result.errors.length > 0 ? "warning" : "success");
     }
     catch (err) {
         const msg = err instanceof Error ? err.message : String(err);

package/dist/resources/extensions/gsd/commands-ship.js

@@ -10,7 +10,7 @@ import { nativeGetCurrentBranch, nativeDetectMainBranch } from "./native-git-bri
 import { formatDuration } from "../shared/format-utils.js";
 import { parseEvalReviewFrontmatter } from "./eval-review-schema.js";
 import { currentDirectoryRoot } from "./commands/context.js";
-import { buildPrEvidence } from "./pr-evidence.js";
+import { buildPullRequestEvidence } from "./pull-request-process.js";
 function git(basePath, args) {
     return execFileSync("git", args, { cwd: basePath, encoding: "utf-8" }).trim();
 }
@@ -140,7 +140,7 @@ function generatePRContent(basePath, milestoneId, milestoneTitle) {
             metrics.push(`**Models:** ${byModel.map((m) => `${m.model} (${m.units} units)`).join(", ")}`);
         }
     }
-    return buildPrEvidence({
+    return buildPullRequestEvidence({
         milestoneId,
         milestoneTitle,
         changeType: "feat",

package/dist/resources/extensions/gsd/commands-verdict.js

@@ -1,11 +1,14 @@
 // Project/App: gsd-pi
 // File Purpose: Handles manual milestone validation verdict overrides.
 import { loadFile } from "./files.js";
-import { resolveMilestoneFile } from "./paths.js";
+import { gsdProjectionRoot, resolveMilestoneFile } from "./paths.js";
+import { resolveCanonicalMilestoneRoot } from "./worktree-manager.js";
+import { join } from "node:path";
 import { deriveState } from "./state.js";
 import { executeValidateMilestone } from "./tools/workflow-tool-executors.js";
 import { ensureDbOpen } from "./bootstrap/dynamic-tools.js";
 import { getLatestAssessmentByScope } from "./gsd-db.js";
+import { checkpointWorkflowDatabase } from "./db-workspace.js";
 import { VALIDATION_VERDICTS, extractVerdict, isValidMilestoneVerdict, } from "./verdict-parser.js";
 const USAGE = 'Usage: /gsd verdict <pass|needs-attention|needs-remediation> [--milestone Mxxx] [--rationale "..."]';
 function tokenize(raw) {
@@ -86,8 +89,14 @@ export function parseValidationFile(content) {
     };
 }
 async function loadExistingValidation(basePath, milestoneId) {
+    const canonicalBase = resolveCanonicalMilestoneRoot(basePath, milestoneId);
+    const canonicalValidationPath = join(gsdProjectionRoot(canonicalBase), "milestones", milestoneId, `${milestoneId}-VALIDATION.md`);
+    const canonicalContent = await loadFile(canonicalValidationPath);
+    if (canonicalContent) {
+        return { content: canonicalContent, source: canonicalValidationPath };
+    }
     const validationPath = resolveMilestoneFile(basePath, milestoneId, "VALIDATION");
-    if (validationPath) {
+    if (validationPath && validationPath !== canonicalValidationPath) {
         const content = await loadFile(validationPath);
         if (content)
             return { content, source: validationPath };
@@ -157,6 +166,7 @@ export async function handleVerdict(rawArgs, ctx, basePath) {
         ctx.ui.notify(msg, "error");
         return;
     }
+    checkpointWorkflowDatabase();
     const prevVerdict = current.verdict ?? "unknown";
     const effectiveVerdict = extractEffectiveVerdict(result.details, parsed.verdict);
     if (effectiveVerdict !== parsed.verdict) {