@opengsd/gsd-path 1.6.1 → 1.7.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +34 -0
- package/DOCS.md +27 -1
- package/FULL.md +2 -1
- package/HOOKS.md +38 -4
- package/QUICK.md +1 -1
- package/README.md +20 -29
- package/RUNTIME.md +5 -3
- package/WORKFLOW.md +9 -2
- package/package.json +1 -1
- package/scripts/_common.py +76 -2
- package/scripts/archive_milestone.py +129 -7
- package/scripts/build_recovery.py +25 -2
- package/scripts/build_state.py +333 -8
- package/scripts/check_handoffs.py +437 -30
- package/scripts/check_task_briefs.py +135 -11
- package/scripts/discussion_validate.py +46 -10
- package/scripts/dispatch_driver.py +28 -3
- package/scripts/git_guard.py +44 -4
- package/scripts/guard_hook.py +456 -9
- package/scripts/install.py +34 -4
- package/scripts/integration.py +196 -39
- package/scripts/isolation.py +1015 -37
- package/scripts/lean_verification.py +33 -14
- package/scripts/loop_run.py +9 -4
- package/scripts/members.py +17 -3
- package/scripts/pipeline_diagnose.py +104 -1
- package/scripts/pipeline_state.py +10 -2
- package/scripts/runtime_store.py +88 -3
- package/scripts/state_checkpoint.py +15 -0
- package/scripts/status_runtime.py +73 -2
- package/scripts/workflow_run.py +10 -3
- package/scripts/worktree_paths.py +45 -0
- package/skills/gsd-path/BUILD.md +5 -1
- package/skills/gsd-path/DEFINE.md +2 -1
- package/skills/gsd-path/PLAN.md +10 -0
- package/skills/gsd-path/SHIP.md +43 -9
- package/skills/gsd-path/SKILL.md +16 -1
- package/skills/gsd-path/references/build-native.md +20 -3
- package/skills/gsd-path/references/coder.md +6 -3
- package/skills/gsd-path/references/reviewer-final.md +10 -0
- package/skills/gsd-path/references/reviewer-wave.md +61 -22
- package/skills/gsd-path/references/reviewer.md +8 -6
- package/skills/gsd-path/references/runtime-selection.md +36 -0
- package/skills/gsd-path/references/spec-probes.md +19 -1
- package/skills/gsd-path/scripts/_common.py +76 -2
- package/skills/gsd-path/scripts/archive_milestone.py +129 -7
- package/skills/gsd-path/scripts/build_recovery.py +25 -2
- package/skills/gsd-path/scripts/build_state.py +333 -8
- package/skills/gsd-path/scripts/check_handoffs.py +437 -30
- package/skills/gsd-path/scripts/check_task_briefs.py +135 -11
- package/skills/gsd-path/scripts/discussion_validate.py +46 -10
- package/skills/gsd-path/scripts/dispatch_driver.py +28 -3
- package/skills/gsd-path/scripts/git_guard.py +44 -4
- package/skills/gsd-path/scripts/integration.py +196 -39
- package/skills/gsd-path/scripts/isolation.py +1015 -37
- package/skills/gsd-path/scripts/lean_verification.py +33 -14
- package/skills/gsd-path/scripts/loop_run.py +9 -4
- package/skills/gsd-path/scripts/members.py +17 -3
- package/skills/gsd-path/scripts/pipeline_state.py +10 -2
- package/skills/gsd-path/scripts/state_checkpoint.py +15 -0
- package/skills/gsd-path/scripts/status_runtime.py +73 -2
- package/skills/gsd-path/scripts/workflow_run.py +10 -3
- package/skills/gsd-path/scripts/worktree_paths.py +45 -0
- package/skills/gsd-path/templates/intent.md +5 -3
- package/skills/gsd-path/templates/task.md +8 -1
- package/skills/gsd-path/templates/wave-review.md +24 -8
- package/skills/gsd-path-build/SKILL.md +5 -1
- package/skills/gsd-path-build/references/build-native.md +20 -3
- package/skills/gsd-path-build/references/coder.md +6 -3
- package/skills/gsd-path-build/references/reviewer-final.md +10 -0
- package/skills/gsd-path-build/references/reviewer-wave.md +61 -22
- package/skills/gsd-path-build/references/reviewer.md +8 -6
- package/skills/gsd-path-build/references/runtime-selection.md +36 -0
- package/skills/gsd-path-build/references/spec-probes.md +19 -1
- package/skills/gsd-path-build/scripts/_common.py +76 -2
- package/skills/gsd-path-build/scripts/archive_milestone.py +129 -7
- package/skills/gsd-path-build/scripts/build_recovery.py +25 -2
- package/skills/gsd-path-build/scripts/build_state.py +333 -8
- package/skills/gsd-path-build/scripts/check_handoffs.py +437 -30
- package/skills/gsd-path-build/scripts/check_task_briefs.py +135 -11
- package/skills/gsd-path-build/scripts/discussion_validate.py +46 -10
- package/skills/gsd-path-build/scripts/dispatch_driver.py +28 -3
- package/skills/gsd-path-build/scripts/integration.py +196 -39
- package/skills/gsd-path-build/scripts/isolation.py +1015 -37
- package/skills/gsd-path-build/scripts/loop_run.py +9 -4
- package/skills/gsd-path-build/scripts/members.py +17 -3
- package/skills/gsd-path-build/scripts/pipeline_state.py +10 -2
- package/skills/gsd-path-build/scripts/state_checkpoint.py +15 -0
- package/skills/gsd-path-build/scripts/workflow_run.py +10 -3
- package/skills/gsd-path-build/scripts/worktree_paths.py +45 -0
- package/skills/gsd-path-build/templates/task.md +8 -1
- package/skills/gsd-path-build/templates/wave-review.md +24 -8
- package/skills/gsd-path-decide/references/runtime-selection.md +36 -0
- package/skills/gsd-path-decide/scripts/_common.py +76 -2
- package/skills/gsd-path-decide/scripts/archive_milestone.py +129 -7
- package/skills/gsd-path-decide/scripts/build_recovery.py +25 -2
- package/skills/gsd-path-decide/scripts/check_handoffs.py +437 -30
- package/skills/gsd-path-decide/scripts/check_task_briefs.py +135 -11
- package/skills/gsd-path-decide/scripts/discussion_validate.py +46 -10
- package/skills/gsd-path-decide/scripts/integration.py +196 -39
- package/skills/gsd-path-decide/scripts/isolation.py +1015 -37
- package/skills/gsd-path-decide/scripts/loop_run.py +9 -4
- package/skills/gsd-path-decide/scripts/members.py +17 -3
- package/skills/gsd-path-decide/scripts/pipeline_state.py +10 -2
- package/skills/gsd-path-decide/scripts/state_checkpoint.py +15 -0
- package/skills/gsd-path-decide/scripts/worktree_paths.py +45 -0
- package/skills/gsd-path-define/SKILL.md +2 -1
- package/skills/gsd-path-define/references/runtime-selection.md +36 -0
- package/skills/gsd-path-define/references/spec-probes.md +19 -1
- package/skills/gsd-path-define/scripts/_common.py +76 -2
- package/skills/gsd-path-define/scripts/archive_milestone.py +129 -7
- package/skills/gsd-path-define/scripts/build_recovery.py +25 -2
- package/skills/gsd-path-define/scripts/check_handoffs.py +437 -30
- package/skills/gsd-path-define/scripts/check_task_briefs.py +135 -11
- package/skills/gsd-path-define/scripts/discussion_validate.py +46 -10
- package/skills/gsd-path-define/scripts/integration.py +196 -39
- package/skills/gsd-path-define/scripts/isolation.py +1015 -37
- package/skills/gsd-path-define/scripts/loop_run.py +9 -4
- package/skills/gsd-path-define/scripts/members.py +17 -3
- package/skills/gsd-path-define/scripts/pipeline_state.py +10 -2
- package/skills/gsd-path-define/scripts/state_checkpoint.py +15 -0
- package/skills/gsd-path-define/scripts/worktree_paths.py +45 -0
- package/skills/gsd-path-define/templates/intent.md +5 -3
- package/skills/gsd-path-discuss/references/runtime-selection.md +36 -0
- package/skills/gsd-path-discuss/scripts/_common.py +76 -2
- package/skills/gsd-path-discuss/scripts/loop_run.py +9 -4
- package/skills/gsd-path-discuss/scripts/worktree_paths.py +45 -0
- package/skills/gsd-path-docs-audit/references/runtime-selection.md +36 -0
- package/skills/gsd-path-docs-audit/scripts/_common.py +76 -2
- package/skills/gsd-path-docs-audit/scripts/archive_milestone.py +129 -7
- package/skills/gsd-path-docs-audit/scripts/build_recovery.py +25 -2
- package/skills/gsd-path-docs-audit/scripts/check_handoffs.py +437 -30
- package/skills/gsd-path-docs-audit/scripts/check_task_briefs.py +135 -11
- package/skills/gsd-path-docs-audit/scripts/discussion_validate.py +46 -10
- package/skills/gsd-path-docs-audit/scripts/integration.py +196 -39
- package/skills/gsd-path-docs-audit/scripts/isolation.py +1015 -37
- package/skills/gsd-path-docs-audit/scripts/loop_run.py +9 -4
- package/skills/gsd-path-docs-audit/scripts/members.py +17 -3
- package/skills/gsd-path-docs-audit/scripts/pipeline_state.py +10 -2
- package/skills/gsd-path-docs-audit/scripts/state_checkpoint.py +15 -0
- package/skills/gsd-path-docs-audit/scripts/worktree_paths.py +45 -0
- package/skills/gsd-path-forensics/references/runtime-selection.md +36 -0
- package/skills/gsd-path-forensics/scripts/_common.py +76 -2
- package/skills/gsd-path-forensics/scripts/loop_run.py +9 -4
- package/skills/gsd-path-forensics/scripts/pipeline_diagnose.py +104 -1
- package/skills/gsd-path-forensics/scripts/worktree_paths.py +45 -0
- package/skills/gsd-path-inspect/references/runtime-selection.md +36 -0
- package/skills/gsd-path-inspect/scripts/_common.py +76 -2
- package/skills/gsd-path-inspect/scripts/archive_milestone.py +129 -7
- package/skills/gsd-path-inspect/scripts/build_recovery.py +25 -2
- package/skills/gsd-path-inspect/scripts/check_handoffs.py +437 -30
- package/skills/gsd-path-inspect/scripts/check_task_briefs.py +135 -11
- package/skills/gsd-path-inspect/scripts/discussion_validate.py +46 -10
- package/skills/gsd-path-inspect/scripts/integration.py +196 -39
- package/skills/gsd-path-inspect/scripts/isolation.py +1015 -37
- package/skills/gsd-path-inspect/scripts/loop_run.py +9 -4
- package/skills/gsd-path-inspect/scripts/members.py +17 -3
- package/skills/gsd-path-inspect/scripts/pipeline_state.py +10 -2
- package/skills/gsd-path-inspect/scripts/state_checkpoint.py +15 -0
- package/skills/gsd-path-inspect/scripts/workflow_run.py +10 -3
- package/skills/gsd-path-inspect/scripts/worktree_paths.py +45 -0
- package/skills/gsd-path-loop/references/runtime-selection.md +36 -0
- package/skills/gsd-path-loop/scripts/_common.py +76 -2
- package/skills/gsd-path-loop/scripts/loop_run.py +9 -4
- package/skills/gsd-path-loop/scripts/worktree_paths.py +45 -0
- package/skills/gsd-path-migrate/references/runtime-selection.md +36 -0
- package/skills/gsd-path-migrate/scripts/_common.py +76 -2
- package/skills/gsd-path-migrate/scripts/loop_run.py +9 -4
- package/skills/gsd-path-plan/SKILL.md +10 -0
- package/skills/gsd-path-plan/references/runtime-selection.md +36 -0
- package/skills/gsd-path-plan/references/spec-probes.md +19 -1
- package/skills/gsd-path-plan/scripts/_common.py +76 -2
- package/skills/gsd-path-plan/scripts/archive_milestone.py +129 -7
- package/skills/gsd-path-plan/scripts/build_recovery.py +25 -2
- package/skills/gsd-path-plan/scripts/check_handoffs.py +437 -30
- package/skills/gsd-path-plan/scripts/check_task_briefs.py +135 -11
- package/skills/gsd-path-plan/scripts/discussion_validate.py +46 -10
- package/skills/gsd-path-plan/scripts/integration.py +196 -39
- package/skills/gsd-path-plan/scripts/isolation.py +1015 -37
- package/skills/gsd-path-plan/scripts/loop_run.py +9 -4
- package/skills/gsd-path-plan/scripts/members.py +17 -3
- package/skills/gsd-path-plan/scripts/pipeline_state.py +10 -2
- package/skills/gsd-path-plan/scripts/state_checkpoint.py +15 -0
- package/skills/gsd-path-plan/scripts/workflow_run.py +10 -3
- package/skills/gsd-path-plan/scripts/worktree_paths.py +45 -0
- package/skills/gsd-path-plan/templates/task.md +8 -1
- package/skills/gsd-path-research/references/runtime-selection.md +36 -0
- package/skills/gsd-path-research/scripts/_common.py +76 -2
- package/skills/gsd-path-research/scripts/archive_milestone.py +129 -7
- package/skills/gsd-path-research/scripts/build_recovery.py +25 -2
- package/skills/gsd-path-research/scripts/check_handoffs.py +437 -30
- package/skills/gsd-path-research/scripts/check_task_briefs.py +135 -11
- package/skills/gsd-path-research/scripts/discussion_validate.py +46 -10
- package/skills/gsd-path-research/scripts/integration.py +196 -39
- package/skills/gsd-path-research/scripts/isolation.py +1015 -37
- package/skills/gsd-path-research/scripts/loop_run.py +9 -4
- package/skills/gsd-path-research/scripts/members.py +17 -3
- package/skills/gsd-path-research/scripts/pipeline_state.py +10 -2
- package/skills/gsd-path-research/scripts/state_checkpoint.py +15 -0
- package/skills/gsd-path-research/scripts/worktree_paths.py +45 -0
- package/skills/gsd-path-roadmap/references/runtime-selection.md +36 -0
- package/skills/gsd-path-roadmap/scripts/_common.py +76 -2
- package/skills/gsd-path-roadmap/scripts/archive_milestone.py +129 -7
- package/skills/gsd-path-roadmap/scripts/build_recovery.py +25 -2
- package/skills/gsd-path-roadmap/scripts/check_handoffs.py +437 -30
- package/skills/gsd-path-roadmap/scripts/check_task_briefs.py +135 -11
- package/skills/gsd-path-roadmap/scripts/discussion_validate.py +46 -10
- package/skills/gsd-path-roadmap/scripts/integration.py +196 -39
- package/skills/gsd-path-roadmap/scripts/isolation.py +1015 -37
- package/skills/gsd-path-roadmap/scripts/loop_run.py +9 -4
- package/skills/gsd-path-roadmap/scripts/members.py +17 -3
- package/skills/gsd-path-roadmap/scripts/pipeline_state.py +10 -2
- package/skills/gsd-path-roadmap/scripts/state_checkpoint.py +15 -0
- package/skills/gsd-path-roadmap/scripts/worktree_paths.py +45 -0
- package/skills/gsd-path-ship/SKILL.md +43 -9
- package/skills/gsd-path-ship/references/reviewer-final.md +10 -0
- package/skills/gsd-path-ship/references/reviewer-wave.md +61 -22
- package/skills/gsd-path-ship/references/reviewer.md +8 -6
- package/skills/gsd-path-ship/references/runtime-selection.md +36 -0
- package/skills/gsd-path-ship/references/spec-probes.md +19 -1
- package/skills/gsd-path-ship/scripts/_common.py +76 -2
- package/skills/gsd-path-ship/scripts/archive_milestone.py +129 -7
- package/skills/gsd-path-ship/scripts/build_recovery.py +25 -2
- package/skills/gsd-path-ship/scripts/build_state.py +333 -8
- package/skills/gsd-path-ship/scripts/check_handoffs.py +437 -30
- package/skills/gsd-path-ship/scripts/check_task_briefs.py +135 -11
- package/skills/gsd-path-ship/scripts/discussion_validate.py +46 -10
- package/skills/gsd-path-ship/scripts/integration.py +196 -39
- package/skills/gsd-path-ship/scripts/isolation.py +1015 -37
- package/skills/gsd-path-ship/scripts/lean_verification.py +33 -14
- package/skills/gsd-path-ship/scripts/loop_run.py +9 -4
- package/skills/gsd-path-ship/scripts/members.py +17 -3
- package/skills/gsd-path-ship/scripts/pipeline_state.py +10 -2
- package/skills/gsd-path-ship/scripts/state_checkpoint.py +15 -0
- package/skills/gsd-path-ship/scripts/workflow_run.py +10 -3
- package/skills/gsd-path-ship/scripts/worktree_paths.py +45 -0
- package/skills/gsd-path-ship/templates/wave-review.md +24 -8
- package/skills/gsd-path-undo/references/runtime-selection.md +36 -0
- package/skills/gsd-path-undo/scripts/_common.py +76 -2
- package/skills/gsd-path-undo/scripts/loop_run.py +9 -4
- package/skills/gsd-path-undo/scripts/worktree_paths.py +45 -0
- package/skills/path/BUILD.md +5 -1
- package/skills/path/DEFINE.md +2 -1
- package/skills/path/PLAN.md +10 -0
- package/skills/path/SHIP.md +43 -9
- package/skills/path/SKILL.md +16 -1
- package/skills/path/references/build-native.md +20 -3
- package/skills/path/references/coder.md +6 -3
- package/skills/path/references/reviewer-final.md +10 -0
- package/skills/path/references/reviewer-wave.md +61 -22
- package/skills/path/references/reviewer.md +8 -6
- package/skills/path/references/runtime-selection.md +36 -0
- package/skills/path/references/spec-probes.md +19 -1
- package/skills/path/scripts/_common.py +76 -2
- package/skills/path/scripts/archive_milestone.py +129 -7
- package/skills/path/scripts/build_recovery.py +25 -2
- package/skills/path/scripts/build_state.py +333 -8
- package/skills/path/scripts/check_handoffs.py +437 -30
- package/skills/path/scripts/check_task_briefs.py +135 -11
- package/skills/path/scripts/discussion_validate.py +46 -10
- package/skills/path/scripts/dispatch_driver.py +28 -3
- package/skills/path/scripts/git_guard.py +44 -4
- package/skills/path/scripts/integration.py +196 -39
- package/skills/path/scripts/isolation.py +1015 -37
- package/skills/path/scripts/lean_verification.py +33 -14
- package/skills/path/scripts/loop_run.py +9 -4
- package/skills/path/scripts/members.py +17 -3
- package/skills/path/scripts/pipeline_state.py +10 -2
- package/skills/path/scripts/state_checkpoint.py +15 -0
- package/skills/path/scripts/status_runtime.py +73 -2
- package/skills/path/scripts/workflow_run.py +10 -3
- package/skills/path/scripts/worktree_paths.py +45 -0
- package/skills/path/templates/intent.md +5 -3
- package/skills/path/templates/task.md +8 -1
- package/skills/path/templates/wave-review.md +24 -8
|
@@ -530,10 +530,15 @@ def run_shell(command: str, timeout: float) -> tuple[Optional[int], str]:
|
|
|
530
530
|
except subprocess.TimeoutExpired as drained:
|
|
531
531
|
stdout = drained.stdout or expired.stdout or b""
|
|
532
532
|
stderr = drained.stderr or expired.stderr or b""
|
|
533
|
-
|
|
534
|
-
|
|
535
|
-
|
|
536
|
-
|
|
533
|
+
# Windows communicate() reads in threads that hold each pipe's lock,
|
|
534
|
+
# so close() would block until an orphaned grandchild (bash forks
|
|
535
|
+
# commands it runs from a script file) exits; leave them to the
|
|
536
|
+
# daemon reader threads there.
|
|
537
|
+
if os.name != "nt":
|
|
538
|
+
if process.stdout:
|
|
539
|
+
process.stdout.close()
|
|
540
|
+
if process.stderr:
|
|
541
|
+
process.stderr.close()
|
|
537
542
|
process.kill()
|
|
538
543
|
process.wait(timeout=5)
|
|
539
544
|
output = stdout.decode("utf-8", errors="replace") + stderr.decode("utf-8", errors="replace")
|
|
@@ -34,9 +34,17 @@ MEMBERS_FILE = "MEMBERS.md"
|
|
|
34
34
|
MARKER_SCHEMA = "gsd-path/member/v1"
|
|
35
35
|
MARKER_KEYS = {"schema", "coordinator", "project", "name"}
|
|
36
36
|
NAME_RE = re.compile(r"^[a-z0-9][a-z0-9-]*$")
|
|
37
|
-
FIELDS = ("Checkout", "Remote", "Integration")
|
|
37
|
+
FIELDS = ("Checkout", "Remote", "Integration", "Prepare")
|
|
38
|
+
# The first three are required; Prepare (isolate provisioning, #463) and
|
|
39
|
+
# Default branch are optional.
|
|
40
|
+
REQUIRED_FIELDS = ("Checkout", "Remote", "Integration")
|
|
38
41
|
# Optional: `add` records it one time; a row without it means main.
|
|
39
42
|
DEFAULT_BRANCH_FIELD = "Default branch"
|
|
43
|
+
# Optional: a shell command run inside each fresh member isolate before any
|
|
44
|
+
# Verify (#463). It provisions what a bare worktree lacks — submodules from
|
|
45
|
+
# the primary checkout's object store, gitignored build inputs — and must
|
|
46
|
+
# copy, never link, outside the isolate (#462).
|
|
47
|
+
PREPARE_FIELD = "Prepare"
|
|
40
48
|
INTEGRATIONS = ("default", "direct", "pull-request")
|
|
41
49
|
GITHUB_REMOTE_RE = re.compile(
|
|
42
50
|
r"(?:https://github\.com/|git@github\.com:|ssh://git@github\.com/)([^/\s]+)/([^/\s]+)"
|
|
@@ -206,10 +214,15 @@ def read_members(coordinator: Path) -> list[dict[str, str]]:
|
|
|
206
214
|
return []
|
|
207
215
|
if path.is_symlink() or not path.is_file():
|
|
208
216
|
raise MembersError("MEMBERS.md must be a regular file")
|
|
217
|
+
return parse_members(path.read_text(encoding="utf-8"))
|
|
218
|
+
|
|
219
|
+
|
|
220
|
+
def parse_members(text: str) -> list[dict[str, str]]:
|
|
221
|
+
"""Parse MEMBERS.md text."""
|
|
209
222
|
members: list[dict[str, str]] = []
|
|
210
223
|
current: Optional[dict[str, str]] = None
|
|
211
224
|
preamble: list[str] = []
|
|
212
|
-
for number, line in enumerate(
|
|
225
|
+
for number, line in enumerate(text.splitlines(), 1):
|
|
213
226
|
if line.startswith("## "):
|
|
214
227
|
name = line[3:].strip()
|
|
215
228
|
if not NAME_RE.fullmatch(name):
|
|
@@ -241,7 +254,7 @@ def read_members(coordinator: Path) -> list[dict[str, str]]:
|
|
|
241
254
|
if len(set(names)) != len(names):
|
|
242
255
|
raise MembersError("MEMBERS.md repeats a member name")
|
|
243
256
|
for member in members:
|
|
244
|
-
missing = [field for field in
|
|
257
|
+
missing = [field for field in REQUIRED_FIELDS if not member.get(field.lower())]
|
|
245
258
|
if missing:
|
|
246
259
|
raise MembersError(f"MEMBERS.md member {member['name']} lacks {', '.join(missing)}")
|
|
247
260
|
if member["integration"] not in INTEGRATIONS:
|
|
@@ -510,6 +523,7 @@ def render(members: Sequence[dict[str, str]]) -> str:
|
|
|
510
523
|
f"Checkout: {member['checkout']}\n"
|
|
511
524
|
f"Remote: {member['remote']}\n"
|
|
512
525
|
f"Integration: {member['integration']}\n"
|
|
526
|
+
+ (f"{PREPARE_FIELD}: {member['prepare']}\n" if "prepare" in member else "")
|
|
513
527
|
# A row that never had the field keeps none, so old rows are not rewritten.
|
|
514
528
|
+ (f"{DEFAULT_BRANCH_FIELD}: {member['default_branch']}\n" if "default_branch" in member else "")
|
|
515
529
|
for member in members
|
|
@@ -1407,6 +1407,12 @@ def _route_state(repo: Path, project_dir: str = ".project") -> dict[str, object]
|
|
|
1407
1407
|
mode="milestone" if status == "done" else "normal",
|
|
1408
1408
|
reason=f"state is {phase}/{status}",
|
|
1409
1409
|
)
|
|
1410
|
+
if phase == "plan" and status == "blocked":
|
|
1411
|
+
return _route_result(
|
|
1412
|
+
state,
|
|
1413
|
+
"block",
|
|
1414
|
+
reason="plan is blocked; resolve the correction or user decision named by the plan gate before resuming",
|
|
1415
|
+
)
|
|
1410
1416
|
if phase == "plan" and status != "done":
|
|
1411
1417
|
return _route_result(state, "run-phase", phase="plan", reason=f"state is {phase}/{status}")
|
|
1412
1418
|
if phase == "plan":
|
|
@@ -2373,9 +2379,9 @@ def main(argv: Optional[Sequence[str]] = None) -> int:
|
|
|
2373
2379
|
args.project_dir,
|
|
2374
2380
|
)
|
|
2375
2381
|
elif args.command == "approve" and (args.defer_checkpoint or args.patch):
|
|
2376
|
-
if args.expected_head is not None:
|
|
2382
|
+
if args.defer_checkpoint and args.expected_head is not None:
|
|
2377
2383
|
raise PipelineStateError(
|
|
2378
|
-
"--expected-head is not accepted with --defer-checkpoint
|
|
2384
|
+
"--expected-head is not accepted with --defer-checkpoint"
|
|
2379
2385
|
)
|
|
2380
2386
|
result = state_checkpoint.defer_approval(
|
|
2381
2387
|
args.repo,
|
|
@@ -2384,6 +2390,8 @@ def main(argv: Optional[Sequence[str]] = None) -> int:
|
|
|
2384
2390
|
args.milestone,
|
|
2385
2391
|
args.patch,
|
|
2386
2392
|
)
|
|
2393
|
+
if args.expected_head is not None:
|
|
2394
|
+
result["expected_head_accepted"] = args.expected_head
|
|
2387
2395
|
elif args.command == "approve":
|
|
2388
2396
|
if args.expected_head is None:
|
|
2389
2397
|
raise PipelineStateError(
|
|
@@ -458,6 +458,21 @@ def _validate_plan_briefs(repo: Path, kind: str, project_dir: str) -> None:
|
|
|
458
458
|
if head.returncode != 0:
|
|
459
459
|
# Pre-Git approval defers base-dependent checks to build.
|
|
460
460
|
return
|
|
461
|
+
if project_dir == ".project":
|
|
462
|
+
# Unsupported .project entries must surface at approval, before build,
|
|
463
|
+
# where removing them is cheapest (#466). Like the checkpoint, judge
|
|
464
|
+
# each git-visible entry by whether it still exists in the worktree.
|
|
465
|
+
project = repo / ".project"
|
|
466
|
+
unsupported = sorted(
|
|
467
|
+
name
|
|
468
|
+
for name in pipeline_state._common.git_visible_entries(project) - PROJECT_ENTRIES
|
|
469
|
+
if (project / name).exists() or (project / name).is_symlink()
|
|
470
|
+
)
|
|
471
|
+
if unsupported:
|
|
472
|
+
raise PipelineStateError(
|
|
473
|
+
"unsupported .project artifacts: " + ", ".join(unsupported)
|
|
474
|
+
+ "; remove or relocate them before approving the plan"
|
|
475
|
+
)
|
|
461
476
|
if __package__:
|
|
462
477
|
from .check_task_briefs import BriefError, _member_bases, plan_validation_bases, validate_task_briefs
|
|
463
478
|
else:
|
|
@@ -7,11 +7,13 @@ import sys
|
|
|
7
7
|
# Runtime helpers must not modify their immutable installation.
|
|
8
8
|
sys.dont_write_bytecode = True
|
|
9
9
|
|
|
10
|
+
import contextlib
|
|
10
11
|
import hashlib
|
|
11
12
|
import json
|
|
12
13
|
import os
|
|
13
14
|
import tempfile
|
|
14
15
|
from pathlib import Path
|
|
16
|
+
from typing import Optional
|
|
15
17
|
|
|
16
18
|
if __package__:
|
|
17
19
|
from . import _common
|
|
@@ -22,7 +24,39 @@ else:
|
|
|
22
24
|
from scripts import _common
|
|
23
25
|
|
|
24
26
|
|
|
27
|
+
# Run-scoped cache for read-only consumers (#469): recovery resolves a
|
|
28
|
+
# placement per task, and each resolution lists the whole worktree registry
|
|
29
|
+
# and re-reads the placement receipt. Within one read-only run none of that
|
|
30
|
+
# can change, so the listing and the derived workspace answer once. Flows
|
|
31
|
+
# that create, move, or retire worktrees never enter this scope.
|
|
32
|
+
_PLACEMENT_CACHE: Optional[dict] = None
|
|
33
|
+
|
|
34
|
+
|
|
35
|
+
@contextlib.contextmanager
|
|
36
|
+
def readonly_placement_cache():
|
|
37
|
+
global _PLACEMENT_CACHE
|
|
38
|
+
if _PLACEMENT_CACHE is not None: # already inside a read-only run
|
|
39
|
+
yield
|
|
40
|
+
return
|
|
41
|
+
_PLACEMENT_CACHE = {"porcelain": {}, "workspace": {}}
|
|
42
|
+
try:
|
|
43
|
+
yield
|
|
44
|
+
finally:
|
|
45
|
+
_PLACEMENT_CACHE = None
|
|
46
|
+
|
|
47
|
+
|
|
25
48
|
def _worktree_list_porcelain(primary: Path) -> tuple[str, bool]:
|
|
49
|
+
if _PLACEMENT_CACHE is not None:
|
|
50
|
+
key = str(primary)
|
|
51
|
+
if key in _PLACEMENT_CACHE["porcelain"]:
|
|
52
|
+
return _PLACEMENT_CACHE["porcelain"][key] # type: ignore[index]
|
|
53
|
+
output = _worktree_list_porcelain_uncached(primary)
|
|
54
|
+
_PLACEMENT_CACHE["porcelain"][key] = output
|
|
55
|
+
return output
|
|
56
|
+
return _worktree_list_porcelain_uncached(primary)
|
|
57
|
+
|
|
58
|
+
|
|
59
|
+
def _worktree_list_porcelain_uncached(primary: Path) -> tuple[str, bool]:
|
|
26
60
|
try:
|
|
27
61
|
if __package__:
|
|
28
62
|
from . import pipeline_git as pg
|
|
@@ -58,6 +92,17 @@ def _identity(path: Path) -> str:
|
|
|
58
92
|
|
|
59
93
|
|
|
60
94
|
def _workspace(primary: Path, pin: bool) -> Path:
|
|
95
|
+
if _PLACEMENT_CACHE is not None and not pin:
|
|
96
|
+
key = str(primary)
|
|
97
|
+
if key in _PLACEMENT_CACHE["workspace"]:
|
|
98
|
+
return _PLACEMENT_CACHE["workspace"][key] # type: ignore[index]
|
|
99
|
+
workspace = _workspace_uncached(primary, False)
|
|
100
|
+
_PLACEMENT_CACHE["workspace"][key] = workspace
|
|
101
|
+
return workspace
|
|
102
|
+
return _workspace_uncached(primary, pin)
|
|
103
|
+
|
|
104
|
+
|
|
105
|
+
def _workspace_uncached(primary: Path, pin: bool) -> Path:
|
|
61
106
|
common = Path(_git(primary, "rev-parse", "--git-common-dir"))
|
|
62
107
|
common = (primary / common).resolve()
|
|
63
108
|
identity = _identity(primary)
|
|
@@ -69,7 +69,8 @@ so the position is unchanged. Then:
|
|
|
69
69
|
task logs prove it is the immediately preceding `ship/blocked` finding
|
|
70
70
|
set, the approved patch tasks copied every finding verbatim, and those tasks
|
|
71
71
|
are now done; otherwise it blocks. Git history preserves the superseded
|
|
72
|
-
finding, while final review itself still creates no pre-ship commit
|
|
72
|
+
finding, while final review itself still creates no pre-ship commit
|
|
73
|
+
(`isolation.py checkpoint` refuses a `build:` checkpoint at `ship/active`).
|
|
73
74
|
2. Derive a stable numbered list of cross-wave integration risks from
|
|
74
75
|
interfaces and flows that span waves. List only genuine risks that could
|
|
75
76
|
plausibly fail; never pad the list. Include PLAN.md's project Verify as
|
|
@@ -89,7 +90,14 @@ so the position is unchanged. Then:
|
|
|
89
90
|
head and holds the exact output; there is no reusable ledger entry.
|
|
90
91
|
Single-repo re-entry at the same command and commit reuses the execution,
|
|
91
92
|
including a failed one, and finishes interrupted collection without running
|
|
92
|
-
the command again.
|
|
93
|
+
the command again. The one exception is an owner-diagnosed host failure (for
|
|
94
|
+
example a host toolchain version the project does not pin): re-run
|
|
95
|
+
`workflow_run.py prepare-final` with `--rerun` to retire the recorded
|
|
96
|
+
execution, run the command again, and append a second ledger entry marked
|
|
97
|
+
`rerun` — the failed entry stays as history. Product failures never take
|
|
98
|
+
`--rerun`; they go through the patch plan. The sidecar inherits the
|
|
99
|
+
orchestrator environment, PATH included, by design: the Verify must run the
|
|
100
|
+
project's own toolchain, so a host/PATH mismatch is a host failure.
|
|
93
101
|
Missing legacy output requires evidence reconciliation, not a blind rerun.
|
|
94
102
|
Any non-zero result stops this step; preserve its stderr and diagnose through
|
|
95
103
|
the bundled forensics contract. Do not launch reviewers while project Verify
|
|
@@ -145,7 +153,8 @@ so the position is unchanged. Then:
|
|
|
145
153
|
verdict `met` with a non-`none` Check or Reference, and every criterion
|
|
146
154
|
listed in PLAN.md's Surface contract requires a matching `Surface` field
|
|
147
155
|
and a non-`none` Check. A non-zero exit is
|
|
148
|
-
`ship/blocked`; never rerun project Verify to repair the evidence
|
|
156
|
+
`ship/blocked`; never rerun project Verify to repair the evidence (a
|
|
157
|
+
host-caused command failure uses the `prepare-final --rerun` route above).
|
|
149
158
|
6. Redispatch one complete corrected brief for a missing or invalid reviewer
|
|
150
159
|
artifact under the same logical task name, following the runtime dispatch
|
|
151
160
|
contract. Before dispatch, record the invalid destination's exact SHA-256.
|
|
@@ -274,7 +283,16 @@ The persisted `STATE.archive` field is the transaction identity.
|
|
|
274
283
|
`awaiting-merge`, report the member PR
|
|
275
284
|
link, stop, and rerun the same command after the user merges it; never
|
|
276
285
|
merge a member PR yourself. When it returns `integrated`, keep its `body`
|
|
277
|
-
for the ship commit below.
|
|
286
|
+
for the ship commit below. When it refuses with
|
|
287
|
+
`member reviewed HEAD reached <default> outside Path`, the member's work
|
|
288
|
+
was already published past its reviewed HEAD by an earlier user-approved
|
|
289
|
+
step: present the member, its reviewed HEAD, and the live default-branch
|
|
290
|
+
tip, and ask the user whether to adopt that landing. Only on an explicit
|
|
291
|
+
user approval rerun the same command with
|
|
292
|
+
`--adopt-landed-member <member>=<live tip SHA>`; the helper then publishes
|
|
293
|
+
the bound branch and an `adopted-landing` milestone tag at that tip and
|
|
294
|
+
makes no merge. A mismatched or stale SHA is refused, and a later rerun
|
|
295
|
+
validates the adoption without the flag.
|
|
278
296
|
5. Only after preflight passes, record shipment through the journaled helper;
|
|
279
297
|
for a program it atomically replaces both ROADMAP.md and STATE.md, setting
|
|
280
298
|
the current entry to `Status: shipped` with the exact `Archive:` pointer:
|
|
@@ -329,7 +347,13 @@ The persisted `STATE.archive` field is the transaction identity.
|
|
|
329
347
|
`build/rebase-adoption.json`) may advance the ref from the adopted head
|
|
330
348
|
to its immediate, canonical `.project/`-only ship child under an exact-SHA
|
|
331
349
|
lease after the helper proves the clean ship state, receipt, and archived
|
|
332
|
-
tasks
|
|
350
|
+
tasks, and a strict ancestor of the ship commit — a build task may have
|
|
351
|
+
legitimately pushed the bound branch as a deploy pin (#464) — is adopted
|
|
352
|
+
only after the user approves, by rerunning with
|
|
353
|
+
`integrate --adopt-published-bound <live 40-hex SHA>`; the helper requires
|
|
354
|
+
the SHA to equal the live tip exactly and fast-forwards under the same
|
|
355
|
+
exact lease, and direct integration only. Every other value blocks. If
|
|
356
|
+
origin/main advances
|
|
333
357
|
after the local merge but rejects the push, a retry may discard and
|
|
334
358
|
rebuild only the unpublished canonical merge and tag under the helper's
|
|
335
359
|
existing recovery checks.
|
|
@@ -416,10 +440,15 @@ Run this recovery setup from a separate checkout, outside the closed primary
|
|
|
416
440
|
worktree's guard.
|
|
417
441
|
|
|
418
442
|
1. Create separate disposable trust and validation checkouts from the same
|
|
419
|
-
published origin and
|
|
420
|
-
|
|
421
|
-
|
|
422
|
-
|
|
443
|
+
published origin and its default branch (checking out `STATE.branch` when
|
|
444
|
+
it still exists; a rebase-merged pull request may have deleted it). This
|
|
445
|
+
separation is required because an explicit runtime upgrade changes the
|
|
446
|
+
trust checkout's declaration and launcher, while archive validation
|
|
447
|
+
requires a clean checkout. Never use the primary worktree for either role.
|
|
448
|
+
A rebase-merged milestone additionally needs the original ship commits to
|
|
449
|
+
resolve — use a checkout that fetched and retained them (the primary
|
|
450
|
+
always does; a clone that never fetched the bound branch does not), and a
|
|
451
|
+
checkout whose originals were collected cannot carry a full validation.
|
|
423
452
|
2. From the trusted fixed GSD Path checkout, preview and then explicitly upgrade only the
|
|
424
453
|
disposable trust checkout's managed trust anchor:
|
|
425
454
|
|
|
@@ -447,6 +476,11 @@ worktree's guard.
|
|
|
447
476
|
python3 -B <verified-runtime>/archive_milestone.py validate-integrated --repo <validation-root> --slug <STATE.milestone>
|
|
448
477
|
```
|
|
449
478
|
|
|
479
|
+
When the validation checkout is on the default branch after the milestone
|
|
480
|
+
closed (the bound branch is gone), pass `--historical`; a rebase-merged
|
|
481
|
+
landing is then accepted only through the milestone tag's Ship/Landing
|
|
482
|
+
pair plus a re-proven rebase replay.
|
|
483
|
+
|
|
450
484
|
4. A pass restores the normal shipped handoff without another commit or
|
|
451
485
|
publication action. Remove only the disposable checkouts. A failure is a
|
|
452
486
|
new validation finding: report it with the primary worktree's archived
|
|
@@ -1,6 +1,16 @@
|
|
|
1
1
|
## Final integration mode
|
|
2
2
|
|
|
3
3
|
Use only final-review.md. Treat INTENT.md success criteria as the rubric.
|
|
4
|
+
To locate each task's authoritative accepted evidence instead of joining
|
|
5
|
+
task Logs, ledger rows, and gap artifacts by hand, run
|
|
6
|
+
`python3 <absolute build_state.py> evidence-manifest --repo
|
|
7
|
+
<absolute primary> --project-dir .project --head <reviewed HEAD>`:
|
|
8
|
+
it classifies every task as `ledger`, `log-only`, `rejected`,
|
|
9
|
+
`superseded`, or `missing` and names the receipt, and reports the member
|
|
10
|
+
project Verify as `gap-embedded` only from a passing `final-gap-1.md` at
|
|
11
|
+
the reviewed HEAD — a
|
|
12
|
+
`log-only` task is accepted through its retained isolated-Verify Log, and
|
|
13
|
+
an absent ledger row is explained, never treated as data loss.
|
|
4
14
|
Each `### SCn —` heading must have every word of the criterion in INTENT.md
|
|
5
15
|
`## Success criteria`: join indented continuation lines and sub-bullets
|
|
6
16
|
with a single space. You can keep or remove the `- ` markers of the
|
|
@@ -8,19 +8,45 @@ tasks in this wave as the rubric. For each task:
|
|
|
8
8
|
Never infer either SHA from task ids, branch position, or nearby history.
|
|
9
9
|
2. Fail a missing, malformed, or invalid SHA. Inspect the commit with
|
|
10
10
|
`git show --format=fuller --stat --patch <commit> --`.
|
|
11
|
-
3.
|
|
12
|
-
|
|
13
|
-
|
|
14
|
-
|
|
15
|
-
|
|
16
|
-
|
|
17
|
-
|
|
18
|
-
|
|
19
|
-
|
|
20
|
-
|
|
21
|
-
|
|
22
|
-
|
|
11
|
+
3. Select the inspection mode your brief supplies and record it — never
|
|
12
|
+
improvise a third:
|
|
13
|
+
- **Reconstructed product** (default): the brief supplies a verify
|
|
14
|
+
sidecar at `base`. In it, apply only the complete binary patch from
|
|
15
|
+
`commit^..commit` for the task's declared product files and inspect
|
|
16
|
+
the diff. Use the orchestrator's recorded isolated Verify output in
|
|
17
|
+
that task's Log as the Verify evidence.
|
|
18
|
+
- **Immutable patch**: the brief supplies one later combined checkout
|
|
19
|
+
with report-write authority only. Inspect the immutable objects
|
|
20
|
+
directly — `git show`/`git diff` on the recorded commits — and prove
|
|
21
|
+
the identity before judging: (a) the landing commit's parent
|
|
22
|
+
`commit^` equals the task file's recorded `base` (or the patch's
|
|
23
|
+
resulting blobs at `base` equal the landing commit's blobs for the
|
|
24
|
+
declared files), and (b) any file judged from the combined checkout
|
|
25
|
+
has its blob there equal to the landing commit's blob at that path.
|
|
26
|
+
Without both identities the review blocks: a mismatch means the
|
|
27
|
+
supplied checkout is not the reviewed product.
|
|
28
|
+
In both modes: do not re-run the task Verify command or PLAN.md's
|
|
29
|
+
project Verify; re-run a command only when the recorded output plus
|
|
30
|
+
the diff cannot check the criterion. Never use the primary worktree
|
|
31
|
+
or branch tip as task evidence. Do not create or remove Git worktrees
|
|
32
|
+
yourself.
|
|
33
|
+
4. Mark `pass` or `fail`. Before the evidence separator (` — `), name the
|
|
34
|
+
criterion (see Review file format below): copy the complete task
|
|
35
|
+
acceptance or interface criterion verbatim, or — on a `pass` line only —
|
|
36
|
+
cite the criterion by its stable id in the task's numbered acceptance or
|
|
37
|
+
interface list (`T012/AC3`, `T012/IF2`) together with the evidence. A
|
|
38
|
+
`fail` line always copies the criterion verbatim: finding grouping binds
|
|
39
|
+
that text to the task. Give the observed result, `file:line`, and
|
|
23
40
|
concrete fix direction for each failure.
|
|
41
|
+
5. Account for every claim. Each acceptance criterion (`T012/AC3`) and
|
|
42
|
+
interface bullet (`T012/IF2`) of the task must appear in its
|
|
43
|
+
section as an evidence reference, a finding, or an explicitly
|
|
44
|
+
authorized disposition — a bare line naming the id with
|
|
45
|
+
`disposition: <authority and date> (<Cn>): <reason>`, where `Cn` is a
|
|
46
|
+
numbered INTENT.md correction. No citation, or a `Cn` that
|
|
47
|
+
`## Corrections` does not define, fails the gate. One observation may
|
|
48
|
+
support several claims when each is identified by its id. The wave gate
|
|
49
|
+
rejects a review that leaves a claim unaccounted for.
|
|
24
50
|
|
|
25
51
|
A Log entry `orchestrator regression Verify of <task id> retired: superseded
|
|
26
52
|
by <task id>` is not evidence: judge the superseding task's acceptance
|
|
@@ -30,8 +56,12 @@ criteria. The same applies to the entry `orchestrator regression Verify of
|
|
|
30
56
|
Then check each INTENT.md success criterion owned by a task in this wave
|
|
31
57
|
against that same isolated product. In each `### SCn —` heading, copy the
|
|
32
58
|
complete criterion text from INTENT.md `## Success criteria` (see Review
|
|
33
|
-
file format below).
|
|
34
|
-
|
|
59
|
+
file format below). Write the headings in ascending SC id order (SC2 before
|
|
60
|
+
SC4), and separate the id from the text with an em dash (—). Mark `pass`
|
|
61
|
+
or `fail` with evidence; a failed owned SC blocks the wave. Under a `pass`
|
|
62
|
+
SC, record each subclaim a numbered INTENT.md correction excludes as
|
|
63
|
+
`- Excluded by <Cn>: <subclaim>`; the gate rejects an exclusion under a
|
|
64
|
+
failing SC or one that cites an undefined correction. Omit the Intent coverage section when no task in the wave owns
|
|
35
65
|
an SC. When INTENT.md `## Edge coverage` or `## Prohibitions` has rows for
|
|
36
66
|
an owned SC, judge it against those rulings too: cite each `held-out` edge
|
|
37
67
|
id with its held-out test's recorded output and each `judgment` prohibition
|
|
@@ -40,8 +70,12 @@ fails the SC.
|
|
|
40
70
|
|
|
41
71
|
Allow changed paths only in the task's `files` plus its assigned task file.
|
|
42
72
|
Within the task file, allow orchestrator-owned `base`, `worktree`,
|
|
43
|
-
`task_branch`, `status`, and `agent` fields
|
|
44
|
-
entries; block contract-body changes
|
|
73
|
+
`task_branch`, `status`, and `agent` fields — and, on a member task,
|
|
74
|
+
`member_base` — plus append-only Log entries; block contract-body changes
|
|
75
|
+
in the task commit. `base` names the task's starting commit in the
|
|
76
|
+
coordinator repository; `member_base` names the starting commit in the
|
|
77
|
+
member repository from which the member task branch and isolate were
|
|
78
|
+
created. Warn on disabled tests
|
|
45
79
|
or Verify commands that cannot fail unless either defeats a criterion. Set the
|
|
46
80
|
wave verdict to `pass` only when every task passes and every owned INTENT
|
|
47
81
|
success criterion for the wave passes.
|
|
@@ -65,10 +99,14 @@ criterion text does not match. Apply the rules before you write the file.
|
|
|
65
99
|
`- ❌ ` for fail. Each task section and each `### SCn —` block needs one
|
|
66
100
|
or more lines with the marker of its own verdict. A failed task needs a
|
|
67
101
|
`- ❌ ` criterion line, also when other text describes the failure.
|
|
68
|
-
- **Criterion text.** In a
|
|
69
|
-
copy every word of the criterion. Join wrapped lines and
|
|
70
|
-
one space. You can keep or remove the `- ` markers of
|
|
71
|
-
A changed, added, removed or moved word does not
|
|
102
|
+
- **Criterion text.** In a `### SCn —` heading and on every `- ❌ ` fail
|
|
103
|
+
line, copy every word of the criterion. Join wrapped lines and
|
|
104
|
+
sub-bullets with one space. You can keep or remove the `- ` markers of
|
|
105
|
+
the sub-bullets. A changed, added, removed or moved word does not
|
|
106
|
+
match. On a `- ✅ ` pass line, name the criterion either by copying it
|
|
107
|
+
verbatim or by citing its stable id in the task's numbered acceptance
|
|
108
|
+
or interface list (`T001/AC1`, `T001/IF2`) together with the evidence;
|
|
109
|
+
the wave gate does not compare pass-line criterion text.
|
|
72
110
|
- **Angle brackets.** Text such as `<b>` or `<path>` outside backticks reads
|
|
73
111
|
as an unfilled template placeholder and is rejected. Write literal markup
|
|
74
112
|
and code in backticks inside a sentence, for example: the output has
|
|
@@ -116,8 +154,9 @@ runtime checks freshness and derives the final view from these records.
|
|
|
116
154
|
## Deep review lenses
|
|
117
155
|
|
|
118
156
|
A `deep` wave spawns two independent reviewers in parallel, each with a fresh
|
|
119
|
-
context and its own
|
|
120
|
-
|
|
157
|
+
context and its own isolated workspace at the recorded review base (a verify
|
|
158
|
+
sidecar in reconstructed mode, or the supplied combined checkout in immutable
|
|
159
|
+
mode). Every Wave mode rule above applies to both lenses.
|
|
121
160
|
|
|
122
161
|
- **Contract** — logical task name
|
|
123
162
|
`review_wave_<wave>_cycle_<cycle>_contract`; stages
|
|
@@ -5,16 +5,18 @@ Verify written GSD Path expectations and block failures. Never fix code.
|
|
|
5
5
|
## Brief contract
|
|
6
6
|
|
|
7
7
|
- Require the mode, all inputs, exact canonical output path, applicable
|
|
8
|
-
template, repository root
|
|
9
|
-
|
|
10
|
-
|
|
11
|
-
|
|
8
|
+
template, and repository root by absolute path. Wave mode also requires
|
|
9
|
+
the absolute INTENT.md path and names the inspection mode: a verify
|
|
10
|
+
sidecar root for reconstructed-product review, or one combined checkout
|
|
11
|
+
with report-write authority for immutable-patch review. The brief must
|
|
12
|
+
also name the staged output path under that workspace.
|
|
12
13
|
- Read AGENTS.md and the template before reviewing.
|
|
13
|
-
- Write only the exact assigned review output under the supplied
|
|
14
|
+
- Write only the exact assigned review output under the supplied workspace
|
|
14
15
|
at its staged `.project/review/` path. The orchestrator validates and
|
|
15
16
|
atomically transfers that file to the canonical primary `.project/review/`
|
|
16
17
|
path after collection. Temporary patch/test effects are allowed solely
|
|
17
|
-
inside supplied sidecars
|
|
18
|
+
inside supplied sidecars; an immutable-mode combined checkout carries
|
|
19
|
+
report-write authority only. Never edit a product path or any other
|
|
18
20
|
primary-worktree path. Stop on a missing input or template.
|
|
19
21
|
|
|
20
22
|
## Load the assigned mode
|
|
@@ -20,6 +20,42 @@ references to bundled copies of those helpers. Other skill helpers, templates,
|
|
|
20
20
|
and role briefs remain in the installed skill bundle. Pass `-B` to Python helper
|
|
21
21
|
invocations so execution does not create bytecode in the runtime store.
|
|
22
22
|
|
|
23
|
+
When the runtime enforcing an active task cannot finish it, one narrowly
|
|
24
|
+
authorized recovery exists:
|
|
25
|
+
`python3 -B <absolute isolation.py> runtime-hotfix --repo <absolute primary>
|
|
26
|
+
--task-id <id> --runtime <64-hex runtime digest printed by runtime_store.py publish>
|
|
27
|
+
--authorized-by <the owner ruling>` validates the replacement runtime,
|
|
28
|
+
re-runs that task's Verify in a fresh sidecar at the recorded base under the
|
|
29
|
+
replacement pin, and records the receipt twice: a Log line in the task file
|
|
30
|
+
naming the task, base, and both runtime digests, and an identical blob behind
|
|
31
|
+
the local ref `refs/gsd-path/runtime-hotfix/<task>-<base>`. Only a Log line
|
|
32
|
+
whose exact twin that ref holds later admits `.gsd-path/runtime.json` into that
|
|
33
|
+
task's landing, and only when the pin names exactly the receipt's runtime; any
|
|
34
|
+
other task, base, a Log line alone, or a bare mention authorizes nothing, and a
|
|
35
|
+
failing re-run refuses the hotfix. Limits: the command serves only a serial
|
|
36
|
+
task working in the primary and refuses parallel or member tasks; the ref is
|
|
37
|
+
local repository state, so a clone without it cannot land the pin and the
|
|
38
|
+
proof fails closed. The guard applies two rules to agent shell commands. It
|
|
39
|
+
denies any command where `runtime-hotfix` directly follows `isolation.py`, stdin
|
|
40
|
+
`-`, or an `isolation` module operand (`-m isolation`, `-Bm isolation`,
|
|
41
|
+
`-misolation`). It also denies every Git command with a word, including global
|
|
42
|
+
`-c` options and inline variable assignments, that contains `refs/gsd-path/` or
|
|
43
|
+
`runtime-hotfix`. This deliberately blocks read-only uses such as
|
|
44
|
+
`git log refs/gsd-path/<ref>` or `git log --grep runtime-hotfix`, and commit
|
|
45
|
+
messages or branch names that contain `runtime-hotfix`. Limits: it cannot see a copied or renamed
|
|
46
|
+
`isolation.py`, a refspec stored in a Git config file, a ref write made from
|
|
47
|
+
inside another program, a direct edit of files under `.git/`, or shell
|
|
48
|
+
expansion that splits both protected words, such as
|
|
49
|
+
`refs/gs{d,}-path/task-authorizations/<task>`.
|
|
50
|
+
|
|
51
|
+
Publishing a runtime to the shared store is project-free:
|
|
52
|
+
`python3 -B <absolute runtime_store.py> publish --source <absolute package root>`
|
|
53
|
+
verifies and publishes the content-addressed runtime, printing its version,
|
|
54
|
+
digest, and store path as JSON; `--provenance` records a note in that output
|
|
55
|
+
only. Publication alone neither authorizes execution nor changes a project's
|
|
56
|
+
trusted runtime — a project runs the bytes only when its own pin names that
|
|
57
|
+
digest.
|
|
58
|
+
|
|
23
59
|
The selected runtime is authoritative for each helper in its `manifest.json`;
|
|
24
60
|
this includes `review_findings.py` and `task_context.py`. A selected runtime
|
|
25
61
|
that was published before a helper became a runtime file does not list that
|
|
@@ -96,6 +96,23 @@ Present the kept items with a recommended ruling and record each as a row:
|
|
|
96
96
|
Work that affects no person directly records a single row instead, and no
|
|
97
97
|
other: `| N1 | all | none | dismissed | <why no person is affected> |`.
|
|
98
98
|
|
|
99
|
+
## Absence criteria
|
|
100
|
+
|
|
101
|
+
A criterion that claims absence ("X does not exist", "no X anywhere",
|
|
102
|
+
"never Y"), including one written from a prohibition, has no end until it
|
|
103
|
+
says where to look. Each review can look somewhere new, so the build loops
|
|
104
|
+
to the cycle cap. Every absence criterion states:
|
|
105
|
+
|
|
106
|
+
- the search space: the files, surfaces, or artifacts to check;
|
|
107
|
+
- the check: the command or observation that covers that space;
|
|
108
|
+
- the absent result: the output that counts as absent.
|
|
109
|
+
|
|
110
|
+
When one is missing, propose a bounded form in the same question round as
|
|
111
|
+
the edges, recommended form first, and amend the criterion after the user
|
|
112
|
+
rules. Do not choose the search space yourself: a narrower space is a scope
|
|
113
|
+
ruling. Under pre-approval, an unbounded absence criterion is a required
|
|
114
|
+
answer: stop and ask.
|
|
115
|
+
|
|
99
116
|
## INTENT.md tables
|
|
100
117
|
|
|
101
118
|
```markdown
|
|
@@ -131,7 +148,8 @@ rechecked; a near-miss heading fails the gate rather than switching it off.
|
|
|
131
148
|
the owning task's Approach so the coder knows the line.
|
|
132
149
|
- **Review.** A row pins the reading of its criterion. A reviewer does not
|
|
133
150
|
pass a reading that contradicts a ruling in either table, and cites each
|
|
134
|
-
held-out edge and judgment prohibition id with its evidence.
|
|
151
|
+
held-out edge and judgment prohibition id with its evidence. An absence
|
|
152
|
+
criterion is judged over its stated search space only.
|
|
135
153
|
- **Final review.** A criterion that carries a held-out edge or a judgment
|
|
136
154
|
prohibition is `met` only when its Check, Observed, or Reference cites
|
|
137
155
|
every such id with the evidence: the held-out test's recorded passing
|