@opengsd/gsd-core 1.9.1 → 1.11.0

package/scripts/lint-command-contract.cjs

@@ -9,6 +9,9 @@
  *   3. allowed-tools: block present, non-empty, all entries from CANONICAL_TOOLS
  *   4. execution_context @-refs: every @-reference resolves to an existing file on disk
  *   5. execution_context @-refs: each appears on its own line (no trailing prose)
+ *   6. every gsd-core/workflows/*.md file is reachable from at least one
+ *      commands/agents/skills loader, transitively through gsd-core/**
+ *      (repo-level check, runs once — not per command file)
  *
  * Exit 0 = clean. Exit 1 = violations (with diagnostics).
  */
@@ -18,7 +21,17 @@
 const fs   = require('fs');
 const path = require('path');
 
-const ROOT          = path.join(__dirname, '..');
+function resolveRoot(argv) {
+  const idx = argv.indexOf('--root');
+  if (idx === -1) return path.join(__dirname, '..');
+  const value = argv[idx + 1];
+  if (!value) {
+    throw new Error('lint-command-contract: --root requires a directory argument');
+  }
+  return path.resolve(value);
+}
+
+const ROOT          = resolveRoot(process.argv.slice(2));
 const COMMANDS_DIR  = path.join(ROOT, 'commands', 'gsd');
 const GSD_ROOT      = path.join(ROOT, 'gsd-core');
 
@@ -26,10 +39,57 @@ const {
   CANONICAL_TOOLS,
   parseFrontmatter,
   executionContextRefs: extractExecutionContextRefs,
+  unreachableWorkflows,
 } = require('./command-contract-helpers.cjs');
 
 const { runMain } = require('./lib/cli-exit.cjs');
 
+// ─── rule 6: repo-level workflow reachability ─────────────────────────────────
+
+function walkMarkdownFiles(dir, acc) {
+  let entries;
+  try {
+    entries = fs.readdirSync(dir, { withFileTypes: true });
+  } catch (e) {
+    return acc;
+  }
+  for (const entry of entries) {
+    const full = path.join(dir, entry.name);
+    if (entry.isDirectory()) {
+      walkMarkdownFiles(full, acc);
+    } else if (entry.isFile() && entry.name.endsWith('.md')) {
+      acc.push(full);
+    }
+  }
+  return acc;
+}
+
+function toGsdRelative(absPath) {
+  return path.relative(GSD_ROOT, absPath).split(path.sep).join('/');
+}
+
+function checkWorkflowReachability() {
+  const loaderFiles = [
+    ...walkMarkdownFiles(path.join(ROOT, 'commands'), []),
+    ...walkMarkdownFiles(path.join(ROOT, 'agents'), []),
+    ...walkMarkdownFiles(path.join(ROOT, 'skills'), []),
+  ];
+  const loaderContents = loaderFiles.map(f => fs.readFileSync(f, 'utf-8'));
+
+  const gsdFileAbsPaths = walkMarkdownFiles(GSD_ROOT, []);
+  const gsdFiles = new Map();
+  for (const abs of gsdFileAbsPaths) {
+    gsdFiles.set(toGsdRelative(abs), fs.readFileSync(abs, 'utf-8'));
+  }
+
+  const workflowAbsPaths = walkMarkdownFiles(path.join(GSD_ROOT, 'workflows'), []);
+  const workflowPaths = workflowAbsPaths.map(toGsdRelative);
+
+  const unreachable = unreachableWorkflows(loaderContents, gsdFiles, workflowPaths);
+
+  return { workflowCount: workflowPaths.length, unreachable };
+}
+
 // ─── check one file ───────────────────────────────────────────────────────────
 
 function check(filePath) {
@@ -88,27 +148,50 @@ function main() {
     .map(f => path.join(COMMANDS_DIR, f));
 
   const results = commandFiles.map(check).filter(Boolean);
+  const { workflowCount, unreachable } = checkWorkflowReachability();
+
+  let ok = true;
 
   if (results.length === 0) {
     console.log(
       `ok lint-command-contract: ${commandFiles.length} command files checked, 0 violations`,
     );
-    return 0;
+  } else {
+    ok = false;
+    const total = results.reduce((n, r) => n + r.violations.length, 0);
+    process.stderr.write(
+      `\nERROR lint-command-contract: ${total} violation(s) across ${results.length} file(s)\n\n`,
+    );
+    for (const r of results) {
+      process.stderr.write(`  ${r.file}\n`);
+      for (const v of r.violations) {
+        process.stderr.write(`    - ${v}\n`);
+      }
+      process.stderr.write('\n');
+    }
+    process.stderr.write('See docs/adr/0002-command-contract-validation-module.md for the contract spec.\n\n');
   }
 
-  const total = results.reduce((n, r) => n + r.violations.length, 0);
-  process.stderr.write(
-    `\nERROR lint-command-contract: ${total} violation(s) across ${results.length} file(s)\n\n`,
-  );
-  for (const r of results) {
-    process.stderr.write(`  ${r.file}\n`);
-    for (const v of r.violations) {
-      process.stderr.write(`    - ${v}\n`);
+  if (unreachable.length === 0) {
+    console.log(
+      `ok lint-command-contract: ${workflowCount} workflow files, ${workflowCount} reachable, 0 unreachable`,
+    );
+  } else {
+    ok = false;
+    process.stderr.write(
+      `\nERROR lint-command-contract: ${unreachable.length} unreachable workflow file(s) of ${workflowCount}\n\n`,
+    );
+    for (const p of unreachable) {
+      process.stderr.write(`  gsd-core/${p}\n`);
     }
-    process.stderr.write('\n');
+    process.stderr.write(
+      '\nEach file above ships to every runtime but is never referenced by any command,\n' +
+      'agent, or skill loader (directly or transitively). Either wire it to a loader\n' +
+      'or delete it — removing a command must sweep its orphaned workflow.\n\n',
+    );
   }
-  process.stderr.write('See docs/adr/0002-command-contract-validation-module.md for the contract spec.\n\n');
-  return 1;
+
+  return ok ? 0 : 1;
 }
 
 runMain(main);

package/scripts/lint-compiled-artifact-sync.cjs

@@ -43,7 +43,12 @@ const REASON = Object.freeze({
 });
 
 function git(args) {
-  return execFileSync('git', args, { cwd: REPO_ROOT, encoding: 'utf8' });
+  // -c safe.directory=REPO_ROOT: containerized CI checkouts are frequently
+  // owned by a different uid than the one running the test process, and git
+  // refuses to operate at all on such a repo ("detected dubious ownership")
+  // unless explicitly trusted. Scoped per-invocation (not written to any
+  // config file) so this never widens trust beyond this one call.
+  return execFileSync('git', ['-c', `safe.directory=${REPO_ROOT}`, ...args], { cwd: REPO_ROOT, encoding: 'utf8' });
 }
 
 /**