@opengsd/gsd-core 1.9.1 → 1.10.0

package/.claude-plugin/marketplace.json

@@ -9,7 +9,7 @@
     {
       "name": "gsd-core",
       "description": "GSD Core is a meta-prompting, context engineering, and spec-driven development system for AI coding agents.",
-      "version": "1.9.1",
+      "version": "1.10.0",
       "source": "./",
       "author": {
         "name": "open-gsd",

package/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "gsd-core",
   "displayName": "GSD Core",
-  "version": "1.9.1",
+  "version": "1.10.0",
   "description": "GSD Core is a meta-prompting, context engineering, and spec-driven development system for AI coding agents.",
   "author": {
     "name": "open-gsd",
@@ -19,6 +19,5 @@
     "gsd"
   ],
   "commands": "./commands/gsd/",
-  "skills": "./skills/",
-  "hooks": "./hooks/hooks.json"
+  "skills": "./skills/"
 }

package/.opencode/plugins/gsd-core.js

@@ -563,7 +563,14 @@ const GsdCorePlugin = async ({ directory } = {}) => {
         handleHookResult(r, output);
       }
 
-      // 4. gsd-workflow-guard.js — workflow advisory + git-force-add block
+      // 4. gsd-write-guard.js — hard-block catastrophic shrink of curated
+      //    .planning/ artifacts (ROADMAP.md, milestones/*-ROADMAP.md, STATE.md)
+      if (claudeTool === "Write") {
+        const r = runHook("gsd-write-guard.js", prePayload());
+        handleHookResult(r, output);
+      }
+
+      // 5. gsd-workflow-guard.js — workflow advisory + git-force-add block
       //    (covers Write/Edit/MultiEdit AND Bash force-add detection)
       if (isWriteLike || claudeTool === "Bash") {
         const r = runHook("gsd-workflow-guard.js", prePayload());

package/agents/gsd-code-fixer.md

@@ -252,6 +252,17 @@ USE_WORKTREES=$(node -e '
 branch=$(git branch --show-current)
 test -n "$branch" || { echo "Detached HEAD is not supported for review-fix (#2686)"; exit 1; }
 
+# #2647 defense-in-depth: padded_phase is interpolated into a worktree PATH
+# and a git BRANCH NAME below. The orchestrator (code-review-fix.md) already
+# validates it as ^[0-9]+(\.[0-9]+)?$, but this agent prompt is a literal bash
+# contract any caller can spawn — validate at the SINK too, so a future caller
+# that forgets cannot turn ${padded_phase} into a path-traversal or branch-name
+# injection. Reject anything that is not digits + an optional single dotted
+# numeric suffix (e.g. '02' or '36.14'); reject '../', spaces, shell metachars.
+if ! [[ "$padded_phase" =~ ^[0-9]+(\.[0-9]+)?$ ]]; then
+  echo "Invalid padded_phase for review-fix: '$padded_phase' (expected e.g. '02' or '36.14')"; exit 1
+fi
+
 # Recovery-sentinel handling (#2839):
 # Path is ${phase_dir}/.review-fix-recovery-pending.json. If it already exists,
 # a previous run was interrupted between fix commits and `git worktree remove`.
@@ -303,7 +314,20 @@ if [ "$USE_WORKTREES" = "false" ]; then
   reviewfix_branch="$branch"
   echo "workflow.use_worktrees=false — editing/committing in the main checkout (no worktree)."
 else
-  wt=$(mktemp -d "/tmp/sv-${padded_phase}-reviewfix-XXXXXX")
+  # #2647: create the worktree INSIDE the repo under the same `.claude/worktrees/`
+  # dir the harness-managed executor worktrees already use. An absolute `/tmp`
+  # path landed outside the project tree (outside the agent session's permission
+  # allowlist → every Read inside prompted; on Windows/Git Bash mktemp also
+  # produced an un-removable short `C:/mvwtNN` path to dodge MAX_PATH). A
+  # repo-relative path inherits the repository's existing permission scope, is
+  # valid and short on Windows as well as POSIX, and is covered by the single
+  # `.gitignore` rule for `.claude/` (`.gitignore:12`). Uniqueness across
+  # concurrent runs for the same phase comes from the PID (`$$`) + epoch suffix
+  # (replacing mktemp's XXXXXX). `$main_repo` is resolved the same way the
+  # cleanup tail below resolves it (`git worktree list --porcelain` first line).
+  main_repo="$(git worktree list --porcelain | awk '/^worktree / { sub(/^worktree /, ""); print; exit }')"
+  wt="$main_repo/.claude/worktrees/rf-${padded_phase}-$$-$(date +%s)"
+  mkdir -p "$wt"
 
   # Create a temp branch from the current branch tip so the worktree
   # attaches to that NEW branch rather than the user's currently-checked-out
@@ -338,7 +362,7 @@ Concrete steps:
 1. Parse `padded_phase` and `phase_dir` from the `<config>` block (needed for the path and for the sentinel location).
 2. Resolve the current branch: `branch=$(git branch --show-current)`. If empty (detached HEAD), print an error and exit — detached-HEAD state is not supported; commits made in a detached-HEAD worktree would not advance the branch.
 3. **Recovery check (#2839, #2990):** If `${phase_dir}/.review-fix-recovery-pending.json` already exists, a prior run was interrupted. Parse the JSON, attempt to remove the orphan worktree it points at (best-effort, with `--force`), and delete the stale `reviewfix_branch` (best-effort, with `git branch -D`), then delete the stale sentinel before continuing. This makes a re-run of `/gsd:code-review --fix` self-healing.
-4. Create a unique worktree path: `wt=$(mktemp -d "/tmp/sv-${padded_phase}-reviewfix-XXXXXX")`. The `mktemp` suffix ensures concurrent runs for the same phase do not collide.
+4. Create a unique worktree path **inside the repo**: `main_repo="$(git worktree list --porcelain | awk '/^worktree / { sub(/^worktree /, ""); print; exit }')"` then `wt="$main_repo/.claude/worktrees/rf-${padded_phase}-$$-$(date +%s)"` + `mkdir -p "$wt"`. The path lives under the same `.claude/worktrees/` dir the harness-managed executor worktrees use (already gitignored via `.claude/`, already in the session's permission scope), and the `$$`-PID + epoch suffix ensures concurrent runs for the same phase do not collide (#2647 — an absolute `/tmp` path landed outside the project tree and prompted on every read).
 5. Run `git worktree add -b "$reviewfix_branch" "$wt" "$branch"` — this creates a NEW branch (`gsd-reviewfix/${padded_phase}-$$`) starting from the current branch tip and attaches the worktree to that new branch. Attaching to a new branch (rather than `$branch` directly) is what allows the worktree to coexist with the user's checkout — git refuses to check out the same branch in two worktrees by default (#2990). Commits made inside the worktree advance `$reviewfix_branch`; the cleanup tail fast-forwards `$branch` to `$reviewfix_branch` so the user's branch ends up with the agent's commits.
 6. **Write the recovery sentinel** at `${phase_dir}/.review-fix-recovery-pending.json` containing `{worktree_path, branch, reviewfix_branch, padded_phase, started_at}`. Doing this AFTER `git worktree add` ensures the sentinel only ever points at a real worktree. The sentinel includes `reviewfix_branch` so recovery can clean both the orphan worktree AND its temp branch.
 7. All subsequent file reads, edits, and commits happen inside `$wt` (which is on `$reviewfix_branch`, not `$branch`).
@@ -636,7 +660,7 @@ _Iteration: {N}_
 
 <critical_rules>
 
-**ALWAYS run inside the isolated worktree** — set up via `branch=$(git branch --show-current)` + `wt=$(mktemp -d "/tmp/sv-${padded_phase}-reviewfix-XXXXXX")` + `git worktree add -b "$reviewfix_branch" "$wt" "$branch"` at the very start (see `setup_worktree` step). Using `mktemp` ensures concurrent runs do not collide. Attaching to a NEW branch `$reviewfix_branch` (not `$branch` directly) is required because git refuses to check out the same branch in two worktrees by default — `$branch` is already checked out in the user's main repo (#2990). Commits advance `$reviewfix_branch`; the cleanup tail fast-forwards `$branch` to `$reviewfix_branch` so the user's branch ends up with the agent's commits. Every file read, edit, and commit must happen inside `$wt`. Run the four-step cleanup tail when done (treat it as a finally block) — but only when a worktree was actually created; when `workflow.use_worktrees` is `false` the cleanup early-exits (no worktree to remove). If `git worktree add` fails, exit with an error rather than force-removing a path another run may hold. This prevents racing the foreground session on the shared main working tree (#2686).
+**ALWAYS run inside the isolated worktree** — set up via `branch=$(git branch --show-current)` + `main_repo="$(git worktree list --porcelain | awk '/^worktree / { sub(/^worktree /, ""); print; exit }')"` + `wt="$main_repo/.claude/worktrees/rf-${padded_phase}-$$-$(date +%s)"` + `mkdir -p "$wt"` + `git worktree add -b "$reviewfix_branch" "$wt" "$branch"` at the very start (see `setup_worktree` step). The worktree path is repo-relative under `.claude/worktrees/` (the same dir the harness-managed executor worktrees use — gitignored via `.claude/`, inside the session's permission scope); the `$$`-PID + epoch suffix ensures concurrent runs do not collide (#2647 — a hardcoded `/tmp` path landed outside the project tree and prompted on every read). Attaching to a NEW branch `$reviewfix_branch` (not `$branch` directly) is required because git refuses to check out the same branch in two worktrees by default — `$branch` is already checked out in the user's main repo (#2990). Commits advance `$reviewfix_branch`; the cleanup tail fast-forwards `$branch` to `$reviewfix_branch` so the user's branch ends up with the agent's commits. Every file read, edit, and commit must happen inside `$wt`. Run the four-step cleanup tail when done (treat it as a finally block) — but only when a worktree was actually created; when `workflow.use_worktrees` is `false` the cleanup early-exits (no worktree to remove). If `git worktree add` fails, exit with an error rather than force-removing a path another run may hold. This prevents racing the foreground session on the shared main working tree (#2686).
 
 **#2825 — honor `workflow.use_worktrees`.** Before creating a worktree, read the
 `workflow.use_worktrees` config flag (the documented opt-out — same key the four sibling writer

package/agents/gsd-debugger.md

@@ -168,73 +168,20 @@ try {
 
 <investigation_techniques>
 
-## Binary Search / Divide and Conquer
+## Technique Catalog
 
-**When:** Large codebase, long execution path, many possible failure points.
+Full step-by-step bodies for every technique below: @gsd-core/references/debugger-techniques.md
 
-**How:** Cut problem space in half repeatedly until you isolate the issue.
-
-1. Identify boundaries (where works, where fails)
-2. Add logging/testing at midpoint
-3. Determine which half contains the bug
-4. Repeat until you find exact line
-
-**Example:** API returns wrong data
-- Test: Data leaves database correctly? YES
-- Test: Data reaches frontend correctly? NO
-- Test: Data leaves API route correctly? YES
-- Test: Data survives serialization? NO
-- **Found:** Bug in serialization layer (4 tests eliminated 90% of code)
-
-## Rubber Duck Debugging
-
-**When:** Stuck, confused, mental model doesn't match reality.
-
-**How:** Explain the problem out loud in complete detail.
-
-Write or say:
-1. "The system should do X"
-2. "Instead it does Y"
-3. "I think this is because Z"
-4. "The code path is: A -> B -> C -> D"
-5. "I've verified that..." (list what you tested)
-6. "I'm assuming that..." (list assumptions)
-
-Often you'll spot the bug mid-explanation: "Wait, I never verified that B returns what I think it does."
-
-## Delta Debugging
-
-**When:** Large change set is suspected (many commits, a big refactor, or a complex feature that broke something). Also when "comment out everything" is too slow.
-
-**How:** Binary search over the change space — not just the code, but the commits, configs, and inputs.
-
-**Over commits (use git bisect):**
-Already covered under Git Bisect. But delta debugging extends it: after finding the breaking commit, delta-debug the commit itself — identify which of its N changed files/lines actually causes the failure.
-
-**Over code (systematic elimination):**
-1. Identify the boundary: a known-good state (commit, config, input) vs the broken state
-2. List all differences between good and bad states
-3. Split the differences in half. Apply only half to the good state.
-4. If broken: bug is in the applied half. If not: bug is in the other half.
-5. Repeat until you have the minimal change set that causes the failure.
-
-**Over inputs:**
-1. Find a minimal input that triggers the bug (strip out unrelated data fields)
-2. The minimal input reveals which code path is exercised
-
-**When to use:**
-- "This worked yesterday, something changed" → delta debug commits
-- "Works with small data, fails with real data" → delta debug inputs
-- "Works without this config change, fails with it" → delta debug config diff
-
-**Example:** 40-file commit introduces bug
-```
-Split into two 20-file halves.
-Apply first 20: still works → bug in second half.
-Split second half into 10+10.
-Apply first 10: broken → bug in first 10.
-... 6 splits later: single file isolated.
-```
+- **Binary Search / Divide and Conquer** — halve the search space until the fault localizes.
+- **Rubber Duck Debugging** — reconstruct the mental model aloud; the gap is the bug.
+- **Delta Debugging** — shrink a failing input to its minimal failing core.
+- **Minimal Reproduction** — strip everything not required to reproduce.
+- **Working Backwards** — start at the symptom and walk causality in reverse.
+- **Differential Debugging** — compare a working case against a failing one.
+- **Observability First** — add instrumentation before forming further hypotheses.
+- **Comment Out Everything** — reduce to nothing, restore until the fault returns.
+- **Git Bisect** — binary-search history for the introducing commit.
+- **Follow the Indirection** — trace each hop when the fault hides behind a layer.
 
 ## Structured Reasoning Checkpoint
 
@@ -268,187 +215,6 @@ reasoning_checkpoint:
 
 If you cannot fill all seven fields with specific, concrete answers — you do not have a confirmed root cause yet. Return to investigation_loop.
 
-## Minimal Reproduction
-
-**When:** Complex system, many moving parts, unclear which part fails.
-
-**How:** Strip away everything until smallest possible code reproduces the bug.
-
-1. Copy failing code to new file
-2. Remove one piece (dependency, function, feature)
-3. Test: Does it still reproduce? YES = keep removed. NO = put back.
-4. Repeat until bare minimum
-5. Bug is now obvious in stripped-down code
-6. **Shrinking (input-space bugs)** — when the bug triggers on a class of inputs, wrap it in a property (fast-check for JS/TS, Hypothesis for Python) and let the shrinker auto-minimize the counterexample; store the **minimized** input as the regression seed. See `gsd-core/references/debugger-repro-hardening.md`.
-
-**Example:**
-```jsx
-// Start: 500-line React component with 15 props, 8 hooks, 3 contexts
-// End after stripping:
-function MinimalRepro() {
-  const [count, setCount] = useState(0);
-
-  useEffect(() => {
-    setCount(count + 1); // Bug: infinite loop, missing dependency array
-  });
-
-  return <div>{count}</div>;
-}
-// The bug was hidden in complexity. Minimal reproduction made it obvious.
-```
-
-## Working Backwards
-
-**When:** You know correct output, don't know why you're not getting it.
-
-**How:** Start from desired end state, trace backwards.
-
-1. Define desired output precisely
-2. What function produces this output?
-3. Test that function with expected input - does it produce correct output?
-   - YES: Bug is earlier (wrong input)
-   - NO: Bug is here
-4. Repeat backwards through call stack
-5. Find divergence point (where expected vs actual first differ)
-
-**Example:** UI shows "User not found" when user exists
-```
-Trace backwards:
-1. UI displays: user.error → Is this the right value to display? YES
-2. Component receives: user.error = "User not found" → Correct? NO, should be null
-3. API returns: { error: "User not found" } → Why?
-4. Database query: SELECT * FROM users WHERE id = 'undefined' → AH!
-5. FOUND: User ID is 'undefined' (string) instead of a number
-```
-
-## Differential Debugging
-
-**When:** Something used to work and now doesn't. Works in one environment but not another.
-
-**Time-based (worked, now doesn't):**
-- What changed in code since it worked?
-- What changed in environment? (Node version, OS, dependencies)
-- What changed in data?
-- What changed in configuration?
-
-**Environment-based (works in dev, fails in prod):**
-- Configuration values
-- Environment variables
-- Network conditions (latency, reliability)
-- Data volume
-- Third-party service behavior
-
-**Process:** List differences, test each in isolation, find the difference that causes failure.
-
-**Example:** Works locally, fails in CI
-```
-Differences:
-- Node version: Same ✓
-- Environment variables: Same ✓
-- Timezone: Different! ✗
-
-Test: Set local timezone to UTC (like CI)
-Result: Now fails locally too
-FOUND: Date comparison logic assumes local timezone
-```
-
-## Observability First
-
-**When:** Always. Before making any fix.
-
-**Add visibility before changing behavior:**
-
-```javascript
-// Strategic logging (useful):
-console.log('[handleSubmit] Input:', { email, password: '***' });
-console.log('[handleSubmit] Validation result:', validationResult);
-console.log('[handleSubmit] API response:', response);
-
-// Assertion checks:
-console.assert(user !== null, 'User is null!');
-console.assert(user.id !== undefined, 'User ID is undefined!');
-
-// Timing measurements:
-console.time('Database query');
-const result = await db.query(sql);
-console.timeEnd('Database query');
-
-// Stack traces at key points:
-console.log('[updateUser] Called from:', new Error().stack);
-```
-
-**Workflow:** Add logging -> Run code -> Observe output -> Form hypothesis -> Then make changes.
-
-## Comment Out Everything
-
-**When:** Many possible interactions, unclear which code causes issue.
-
-**How:**
-1. Comment out everything in function/file
-2. Verify bug is gone
-3. Uncomment one piece at a time
-4. After each uncomment, test
-5. When bug returns, you found the culprit
-
-**Example:** Some middleware breaks requests, but you have 8 middleware functions
-```javascript
-app.use(helmet()); // Uncomment, test → works
-app.use(cors()); // Uncomment, test → works
-app.use(compression()); // Uncomment, test → works
-app.use(bodyParser.json({ limit: '50mb' })); // Uncomment, test → BREAKS
-// FOUND: Body size limit too high causes memory issues
-```
-
-## Git Bisect
-
-**When:** Feature worked in past, broke at unknown commit.
-
-**How:** Binary search through git history.
-
-```bash
-git bisect start
-git bisect bad              # Current commit is broken
-git bisect good abc123      # This commit worked
-# Git checks out middle commit
-git bisect bad              # or good, based on testing
-# Repeat until culprit found
-```
-
-100 commits between working and broken: ~7 tests to find exact breaking commit.
-
-## Follow the Indirection
-
-**When:** Code constructs paths, URLs, keys, or references from variables — and the constructed value might not point where you expect.
-
-**The trap:** You read code that builds a path like `path.join(configDir, 'hooks')` and assume it's correct because it looks reasonable. But you never verified that the constructed path matches where another part of the system actually writes/reads.
-
-**How:**
-1. Find the code that **produces** the value (writer/installer/creator)
-2. Find the code that **consumes** the value (reader/checker/validator)
-3. Trace the actual resolved value in both — do they agree?
-4. Check every variable in the path construction — where does each come from? What's its actual value at runtime?
-
-**Common indirection bugs:**
-- Path A writes to `dir/sub/hooks/` but Path B checks `dir/hooks/` (directory mismatch)
-- Config value comes from cache/template that wasn't updated
-- Variable is derived differently in two places (e.g., one adds a subdirectory, the other doesn't)
-- Template placeholder (`{{VERSION}}`) not substituted in all code paths
-
-**Example:** Stale hook warning persists after update
-```
-Check code says:  hooksDir = path.join(configDir, 'hooks')
-                  configDir = ~/.claude
-                  → checks ~/.claude/hooks/
-
-Installer says:   hooksDest = path.join(targetDir, 'hooks')
-                  targetDir = ~/.claude/gsd-core
-                  → writes to ~/.claude/gsd-core/hooks/
-
-MISMATCH: Checker looks in wrong directory → hooks "not found" → reported as stale
-```
-
-**The discipline:** Never assume a constructed path is correct. Resolve it to its actual value and verify the other side agrees. When two systems share a resource (file, directory, key), trace the full path in both.
-
 ## Technique Selection (routed by bug class)
 
 Classify the failure first (Phase 1.75), then route by class — not by ad-hoc

package/agents/gsd-executor.md

@@ -26,10 +26,12 @@ When you need library or framework documentation, check in this order:
 
 1. If Context7 MCP tools (`mcp__context7__*, mcp__plugin_context7_context7__*`) are available in your environment, use them:
    - Resolve library ID: `mcp__context7__resolve-library-id` with `libraryName`
-   - Fetch docs: `mcp__context7__get-library-docs` with `context7CompatibleLibraryId` and `topic`
+   - Fetch docs: `mcp__context7__query-docs` with `libraryId` (the ID from step 1) and `query`
 
-2. If Context7 MCP is not available (upstream bug anthropics/claude-code#13898 strips MCP
-   tools from agents with a `tools:` frontmatter restriction), use the CLI fallback via Bash:
+2. If Context7 MCP is not available (custom subagents cannot see project-scoped
+   `.mcp.json` servers — they only inherit user-scoped `~/.claude/mcp.json`, so a
+   context7 server configured at the project scope is invisible to spawned
+   agents), use the CLI fallback via Bash:
 
    Step 1 — Resolve library ID:
    ```bash
@@ -498,8 +500,8 @@ if [ -f .git ]; then  # worktree
   # Positive allow-list: HEAD must be on a per-agent branch (`agent-<id>` or
   # legacy `worktree-agent-<id>`). This catches feature/* and any other
   # arbitrary branch that the deny-list would silently allow (#2924, #1995).
-  if ! echo "$ACTUAL_BRANCH" | grep -Eq '^(worktree-)?agent-[A-Za-z0-9._/-]+$'; then
-    echo "FATAL: refusing to commit — worktree HEAD '$ACTUAL_BRANCH' is not in the agent-* / worktree-agent-* namespace." >&2
+  if ! echo "$ACTUAL_BRANCH" | grep -Eq '^((worktree-)?agent-|worktree-wf_)[A-Za-z0-9._/-]+$'; then
+    echo "FATAL: refusing to commit — worktree HEAD '$ACTUAL_BRANCH' is not in the agent-* / worktree-agent-* / worktree-wf_* namespace." >&2
     echo "Agent commits must live on per-agent branches; surface as blocker (#2924)." >&2
     exit 1
   fi

package/agents/gsd-integration-checker.md

@@ -94,6 +94,9 @@ For each phase, extract what it provides and what it should consume.
 **From SUMMARYs, extract:**
 
 ```bash
+# #2962: zsh aborts the block on an unmatched for-list glob (nomatch); bash passes it through. nullglob both.
+shopt -s nullglob 2>/dev/null; setopt NULL_GLOB 2>/dev/null
+
 # Key exports from each phase
 for summary in .planning/phases/*/*-SUMMARY.md; do
   echo "=== $summary ==="

package/agents/gsd-plan-checker.md

@@ -714,6 +714,9 @@ Extract from init JSON: `phase_dir`, `phase_number`, `has_plans`, `plan_count`.
 Orchestrator provides CONTEXT.md content in the verification prompt. If provided, parse for locked decisions, discretion areas, deferred ideas.
 
 ```bash
+# #2962: zsh aborts the block on an unmatched for-list glob (nomatch); bash passes it through. nullglob both.
+shopt -s nullglob 2>/dev/null; setopt NULL_GLOB 2>/dev/null
+
 gsd_run query phase.list-plans "$phase_number"
 # Research / brief artifacts (deterministic listing)
 gsd_run query phase.list-artifacts "$phase_number" --type research
@@ -735,6 +738,9 @@ done
 Use `gsd-tools query` to validate plan structure:
 
 ```bash
+# #2962: zsh aborts the block on an unmatched for-list glob (nomatch); bash passes it through. nullglob both.
+shopt -s nullglob 2>/dev/null; setopt NULL_GLOB 2>/dev/null
+
 for plan in "$PHASE_DIR"/*-PLAN.md; do
   echo "=== $plan ==="
   PLAN_STRUCTURE=$(gsd_run query verify.plan-structure "$plan")
@@ -820,6 +826,9 @@ Inspect `tasks` in the JSON; open the PLAN in the editor for prose-level review.
 ## Step 6: Verify Dependency Graph
 
 ```bash
+# #2962: zsh aborts the block on an unmatched for-list glob (nomatch); bash passes it through. nullglob both.
+shopt -s nullglob 2>/dev/null; setopt NULL_GLOB 2>/dev/null
+
 for plan in "$PHASE_DIR"/*-PLAN.md; do
   grep "depends_on:" "$plan"
 done

package/agents/gsd-planner.md

@@ -374,7 +374,7 @@ Output: [Artifacts created]
 |-----------|----------|-----------|----------|-------------|-----------------|
 | T-{phase}-01 | {S/T/R/I/D/E} | {function/endpoint/file} | {critical\|high\|medium\|low} | mitigate | {specific mitigation action} |
 | T-{phase}-02 | {category} | {component} | low | accept | {rationale for acceptance} |
-| T-{phase}-SC | Tampering | npm/pip/cargo installs | high | mitigate | slopcheck + blocking human checkpoint for [ASSUMED]/[SUS] |
+| T-{phase}-SC | Tampering | npm/pip/cargo installs | high | mitigate | package-legitimacy gate + blocking human checkpoint for [ASSUMED]/[SUS] |
 </threat_model>
 
 <verification>
@@ -869,18 +869,15 @@ Include all frontmatter fields.
 </step>
 
 <step name="validate_plan">
-Validate each created PLAN.md using `gsd-tools query`:
+`$SCHEMA`: `plan-gap-closure` in gap_closure mode, else `plan`. `gap_closure` must be literal lowercase `true`.
 
 ```bash
-VALID=$(gsd_run query frontmatter.validate "$PLAN_PATH" --schema plan)
+VALID=$(gsd_run query frontmatter.validate "$PLAN_PATH" --schema "$SCHEMA")
 ```
 
-Returns JSON: `{ valid, missing, present, schema }`
+Returns JSON: `{ valid, missing, present, invalidValue, schema }`
 
-**If `valid=false`:** Fix missing required fields before proceeding.
-
-Required plan frontmatter fields:
-- `phase`, `plan`, `type`, `wave`, `depends_on`, `files_modified`, `autonomous`, `must_haves`
+**If `valid=false`:** `missing` = absent fields, `invalidValue` = present but wrong-valued. Fix either before proceeding.
 
 Also validate plan structure:
 

package/agents/gsd-roadmapper.md

@@ -560,9 +560,27 @@ If gaps found, include in draft for user decision.
 
 Write files first, then return. This ensures artifacts persist even if context is lost.
 
-1. **Write ROADMAP.md** using output format
-
-2. **Write STATE.md** using output format
+**Arm the write-guard sentinel before each curated write, when the target already exists.** On a
+`/gsd:new-milestone` run `.planning/ROADMAP.md` and `.planning/STATE.md` still hold the *outgoing*
+milestone's content, and the replacement carries only the new milestone's phases — a legitimate,
+intentional shrink that the `gsd-write-guard` PreToolUse hook (#2255) hard-blocks on curated
+`.planning/` artifacts. A hook inherits the *runtime's* environment, so no per-step env var can reach
+it; the hatch is a **single-use sentinel file the guard itself consumes**. It is path-bound and
+single-use, so arm it immediately before each Write — one arming can never cover both files. On a
+`/gsd:new-project` run neither target exists, the guard exempts the write (ENOENT), and the `[ -f ]`
+test skips the arming so no unconsumed token is left on disk.
+
+1. **Write ROADMAP.md** using output format — arm first, then Write:
+
+   ```bash
+   [ -f .planning/ROADMAP.md ] && printf '.planning/ROADMAP.md\n' > .planning/.gsd-allow-shrink
+   ```
+
+2. **Write STATE.md** using output format — arm first, then Write:
+
+   ```bash
+   [ -f .planning/STATE.md ] && printf '.planning/STATE.md\n' > .planning/.gsd-allow-shrink
+   ```
 
 3. **Update REQUIREMENTS.md traceability section**
 

package/agents/gsd-verifier.md

@@ -285,46 +285,16 @@ grep -r "$artifact_name" "${search_path:-src/}" --include="*.ts" --include="*.ts
 
 ## Step 4b: Data-Flow Trace (Level 4)
 
-Artifacts that pass Levels 1-3 (exist, substantive, wired) can still be hollow if their data source produces empty or hardcoded values. Level 4 traces upstream from the artifact to verify real data flows through the wiring.
+Trace each rendered value back to a real data source. Full procedure and shell
+recipes: @gsd-core/references/verifier-wiring-patterns.md
 
-**When to run:** For each artifact that passes Level 3 (WIRED) and renders dynamic data (components, pages, dashboards — not utilities or configs).
+Flag any value whose chain terminates in a static return, a hardcoded literal, or
+a mock rather than a real query.
 
-**How:**
-
-1. **Identify the data variable** — what state/prop does the artifact render?
-
-```bash
-# Find state variables that are rendered in JSX/TSX
-grep -n -E "useState|useQuery|useSWR|useStore|props\." "$artifact" 2>/dev/null
-```
-
-2. **Trace the data source** — where does that variable get populated?
-
-```bash
-# Find the fetch/query that populates the state
-grep -n -A 5 "set${STATE_VAR}\|${STATE_VAR}\s*=" "$artifact" 2>/dev/null | grep -E "fetch|axios|query|store|dispatch|props\."
-```
-
-3. **Verify the source produces real data** — does the API/store return actual data or static/empty values?
-
-```bash
-# Check the API route or data source for real DB queries vs static returns
-grep -n -E "prisma\.|db\.|query\(|findMany|findOne|select|FROM" "$source_file" 2>/dev/null
-# Flag: static returns with no query
-grep -n -E "return.*json\(\s*\[\]|return.*json\(\s*\{\}" "$source_file" 2>/dev/null
-```
-
-4. **Check for disconnected props** — props passed to child components that are hardcoded empty at the call site
-
-```bash
-# Find where the component is used and check prop values
-grep -r -A 3 "<${COMPONENT_NAME}" "${search_path:-src/}" --include="*.tsx" 2>/dev/null | grep -E "=\{(\[\]|\{\}|null|''|\"\")\}"
-```
-
-**Data-flow status:**
+**Data-flow status vocabulary:**
 
-| Data Source | Produces Real Data | Status |
-| ---------- | ------------------ | ------ |
+| Data source | Flows | Status |
+| ----------- | ----- | ------ |
 | DB query found | Yes | ✓ FLOWING |
 | Fetch exists, static fallback only | No | ⚠️ STATIC |
 | No data source found | N/A | ✗ DISCONNECTED |
@@ -359,41 +329,15 @@ For each link:
 
 **Fallback patterns** (if must_haves.key_links not defined in PLAN):
 
-### Pattern: Component → API
+### Wiring patterns
 
-```bash
-grep -E "fetch\(['\"].*$api_path|axios\.(get|post).*$api_path" "$component" 2>/dev/null
-grep -A 5 "fetch\|axios" "$component" | grep -E "await|\.then|setData|setState" 2>/dev/null
-```
-
-Status: WIRED (call + response handling) | PARTIAL (call, no response use) | NOT_WIRED (no call)
-
-### Pattern: API → Database
-
-```bash
-grep -E "prisma\.$model|db\.$model|$model\.(find|create|update|delete)" "$route" 2>/dev/null
-grep -E "return.*json.*\w+|res\.json\(\w+" "$route" 2>/dev/null
-```
-
-Status: WIRED (query + result returned) | PARTIAL (query, static return) | NOT_WIRED (no query)
-
-### Pattern: Form → Handler
-
-```bash
-grep -E "onSubmit=\{|handleSubmit" "$component" 2>/dev/null
-grep -A 10 "onSubmit.*=" "$component" | grep -E "fetch|axios|mutate|dispatch" 2>/dev/null
-```
-
-Status: WIRED (handler + API call) | STUB (only logs/preventDefault) | NOT_WIRED (no handler)
-
-### Pattern: State → Render
-
-```bash
-grep -E "useState.*$state_var|\[$state_var," "$component" 2>/dev/null
-grep -E "\{.*$state_var.*\}|\{$state_var\." "$component" 2>/dev/null
-```
+Verify each link below; full per-pattern procedures and shell recipes:
+@gsd-core/references/verifier-wiring-patterns.md
 
-Status: WIRED (state displayed) | NOT_WIRED (state exists, not rendered)
+- **Component → API** — the component actually calls the endpoint it claims.
+- **API → Database** — the endpoint issues a real query, not a static return.
+- **Form → Handler** — submission reaches a handler that persists.
+- **State → Render** — state changes actually reach the rendered output.
 
 ## Step 6: Check Requirements Coverage