@opengsd/gsd-core 1.8.0 → 1.9.1

package/scripts/release-notes/format-github-release-notes.cjs

@@ -8,9 +8,9 @@ const { runMain, ExitError } = require('../lib/cli-exit.cjs');
 const { classifyBucket } = require('./conventional-title.cjs');
 
 /**
- * Classify a What's-Changed bullet line into 'Feature', 'Fix', or 'Enhancement'.
+ * Classify a What's-Changed bullet line into 'Feature', 'Fix', 'Enhancement', or 'Internal'.
  * @param {string} bulletLine - Full bullet line including the leading `* ` or `- ` marker.
- * @returns {'Feature'|'Fix'|'Enhancement'}
+ * @returns {'Feature'|'Fix'|'Enhancement'|'Internal'}
  */
 function classifyTitle(bulletLine) {
   // Strip leading `* ` or `- ` marker
@@ -83,7 +83,11 @@ function formatReleaseNotes({ generatedBody, version, prerelease, packageName })
       const category = classifyTitle(trimmed);
       if (category === 'Feature') featureBullets.push(trimmed);
       else if (category === 'Fix') fixBullets.push(trimmed);
-      else enhancementBullets.push(trimmed);
+      else if (category === 'Internal') {
+        // #2716: non-user-facing work (test/chore/ci/docs/refactor/perf/revert)
+        // is omitted from the user-facing "What's Changed" section entirely.
+        continue;
+      } else enhancementBullets.push(trimmed);
       continue;
     }
 

package/scripts/validate-registry.cjs

@@ -3,11 +3,13 @@
 
 /**
  * scripts/validate-registry.cjs — CLI validator for the third-party
- * discoverability catalogs (issue #2182):
+ * discoverability catalogs (issue #2182, plus #2904):
  *
  *   - docs/registries/capabilities.json  ("GSD Community Capability Registry")
  *   - docs/registries/eos.json           ("GSD EoS Registry", PR2 — optional
  *     until that JSON file ships)
+ *   - docs/registries/reviewers.json     ("GSD Reviewer Lane Registry",
+ *     issue #2904 — optional until that JSON file ships)
  *
  * Validates each source's JSON array against the closed schema in
  * scripts/registry-schema.cjs (validateEntries). Human-readable errors go to
@@ -33,14 +35,15 @@ const { validateEntries } = require('./registry-schema.cjs');
 // a subprocess against isolated temp-fixture directories via `cwd`.
 const SOURCES = [
   { file: 'capabilities.json', type: 'capability' },
-  { file: 'eos.json', type: 'eos' },
+  { file: 'eos.json', type: 'eos', optional: true },
+  { file: 'reviewers.json', type: 'reviewer', optional: true },
 ];
 
 /**
  * Load + validate a single registry JSON file.
  *
  * @param {string} jsonPath  absolute path to the registry JSON file
- * @param {'capability'|'eos'} type
+ * @param {'capability'|'eos'|'reviewer'} type
  * @returns {{ok: boolean, errors: Array<{index: number, id?: string, field: string, reason: string}>}}
  */
 function validateFile(jsonPath, type) {
@@ -81,10 +84,11 @@ function main() {
   const results = [];
   let anyFailed = false;
 
-  for (const { file, type } of SOURCES) {
+  for (const { file, type, optional } of SOURCES) {
     const jsonPath = path.join(registriesDir, file);
-    // eos.json is optional until PR2 ships it — skip silently when absent.
-    if (type === 'eos' && !fs.existsSync(jsonPath)) continue;
+    // eos.json (pre-PR2) and reviewers.json (issue #2904) are optional until
+    // their source JSON ships — skip silently when absent.
+    if (optional && !fs.existsSync(jsonPath)) continue;
 
     const verdict = validateFile(jsonPath, type);
     results.push({ file, type, ok: verdict.ok, errors: verdict.errors });

package/scripts/workflow-size.cjs

@@ -5,10 +5,13 @@
  *
  * Single source of truth for measuring workflow `.md` file sizes in bytes.
  *
- * Shared by `tests/workflow-size-budget.test.cjs` (the CI guard) and
- * `scripts/update-size-baseline.cjs` (the baseline generator) so the two can
- * never disagree on HOW a file is measured.  A divergence between the generator
- * and the guard would silently mis-record the baseline (issue #1074).
+ * Shared by `tests/workflow-size-budget.test.cjs` / `tests/agent-size-budget.test.cjs`
+ * (the tier hard-cap guards), `tests/helpers/emitted-runtime.cjs`'s `currentSizes()`
+ * (the differential attribution check's size ratchet, ADR-2719 Phase 4), and
+ * `scripts/gen-emitted-baseline.cjs` (the baseline publisher) so none of them can
+ * disagree on HOW a file is measured (issue #1074). `scripts/update-size-baseline.cjs`,
+ * the original third consumer, was removed by #2724 along with the per-file baseline
+ * it generated.
  */
 
 const fs = require('fs');
@@ -19,11 +22,16 @@ const WORKFLOWS_DIR = path.join(__dirname, '..', 'gsd-core', 'workflows');
 /**
  * Byte size of a file, counted as on an LF (Unix) checkout.
  *
- * The size budget is calibrated against `wc -c` on a Unix (LF) checkout, but
- * these `.md` files have no `eol=lf` in `.gitattributes`, so Windows checks
- * them out as CRLF.  Counting raw on-disk bytes there adds one byte per line,
- * a Windows-only false positive that diverges from the LF calibration basis
+ * The size budget is calibrated against `wc -c` on a Unix (LF) checkout.
+ * Counting raw on-disk bytes on a CRLF checkout adds one byte per line, a
+ * Windows-only false positive that diverges from the LF calibration basis
  * (issue #683).  Stripping CR yields the same LF byte count on every platform.
+ *
+ * `.gitattributes:2` (`* text=auto eol=lf`, added in #1088) now normalizes these
+ * files to LF on checkout everywhere, so the CRLF case should not arise from a
+ * normal clone — but this stays unconditional because it also covers a working
+ * tree produced some other way (an unpacked archive, an editor that rewrites
+ * line endings, a checkout predating that attribute).
  * This is still a raw byte count (not a trailing-newline-stripping line count).
  *
  * @param {string} filePath - Absolute or relative path to the file.

package/skills/gsd-plan-review-convergence/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: gsd-plan-review-convergence
 description: "Cross-AI plan convergence - replan until review concerns are resolved."
-argument-hint: "<phase> [--codex] [--gemini] [--claude] [--opencode] [--ollama] [--lm-studio] [--llama-cpp] [--agy] [--text] [--ws <name>] [--all] [--max-cycles N]"
+argument-hint: "<phase> [--gemini] [--claude] [--codex] [--coderabbit] [--opencode] [--qwen] [--cursor] [--antigravity] [--agy] [--ollama] [--lm-studio] [--llama-cpp] [--kimi-code] [--text] [--ws <name>] [--all] [--max-cycles N]"
 allowed-tools:
   - Read
   - Write
@@ -44,10 +44,14 @@ Phase number: extracted from $ARGUMENTS (required)
 - `--gemini` — Use Gemini CLI as reviewer
 - `--agy` / `--antigravity` — Use Antigravity CLI as reviewer (successor to the discontinued Gemini CLI)
 - `--claude` — Use Claude CLI as reviewer (separate session)
+- `--coderabbit` — Use CodeRabbit as reviewer (reviews the working-tree diff, not the source tree)
 - `--opencode` — Use OpenCode as reviewer
+- `--qwen` — Use Qwen Code CLI as reviewer (Alibaba Qwen models)
+- `--cursor` — Use Cursor agent as reviewer
 - `--ollama` — Use local Ollama server as reviewer (OpenAI-compatible, default host `http://localhost:11434`; configure model via `review.models.ollama`)
 - `--lm-studio` — Use local LM Studio server as reviewer (OpenAI-compatible, default host `http://localhost:1234`; configure model via `review.models.lm_studio`)
 - `--llama-cpp` — Use local llama.cpp server as reviewer (OpenAI-compatible, default host `http://localhost:8080`; configure model via `review.models.llama_cpp`)
+- `--kimi-code` — Use Kimi Code CLI as reviewer (Moonshot AI)
 - `--all` — Use all available CLIs and running local model servers
 - `--max-cycles N` — Maximum replan→review cycles (default: 3)
 

package/vscode/package.json

@@ -2,7 +2,7 @@
   "name": "gsd-core-vscode",
   "displayName": "GSD Core",
   "description": "GSD orchestration engine embedded in VS Code (ADR-1239 IDE profile).",
-  "version": "1.8.0",
+  "version": "1.9.1",
   "publisher": "opengsd",
   "engines": {
     "vscode": "^1.105.0"

package/scripts/gen-golden-install-parity-zcode.cjs

@@ -1,77 +0,0 @@
-#!/usr/bin/env node
-'use strict';
-/**
- * Standalone golden-fixture generator for tests/golden-install-parity.
- *
- * This is a BUILD-TIME generation script — NOT a test run. It imports the
- * canonical buildParityManifest builder from tests/helpers/install-shared.cjs
- * (issue #2266 — single source of truth shared with
- * tests/golden-install-parity.test.cjs) and captures the zcode fixture so the
- * parity test (which the gsd-test gate runs) has a committed artifact to
- * compare against. The authoritative test gate remains `gsd-test run`, never
- * a local `node --test`.
- *
- * Usage: node scripts/gen-golden-install-parity-zcode.cjs
- */
-const fs = require('node:fs');
-const path = require('node:path');
-const { execFileSync } = require('node:child_process');
-
-const ROOT = path.resolve(__dirname, '..');
-// buildParityManifest (and its exclusion constants) is the canonical single
-// source of truth in tests/helpers/install-shared.cjs (issue #2266) — the
-// generator no longer keeps its own inline copy, which had drifted from the
-// test harness's copy (missing the realpath/`<HOME>` normalization) and
-// mis-generated the claude-local fixture (#2100).
-const { runMinimalInstall, RUNTIME_META, buildParityManifest, BUILD_SCRIPT } = require(path.join(ROOT, 'tests', 'helpers', 'install-shared.cjs'));
-const FIXTURE_DIR = path.join(ROOT, 'tests', 'fixtures', 'golden-install-parity');
-
-function cleanup(root) {
-  try { fs.rmSync(root, { recursive: true, force: true }); } catch { /* best effort */ }
-}
-
-// Regenerate the fixture for every runtime in RUNTIME_META. Needed when a
-// SHARED gsd-core payload file (e.g. model-catalog.json, capability-registry)
-// changes content — its hash appears in every runtime's manifest, so all
-// fixtures must be recaptured together. Usage:
-//   node scripts/gen-golden-install-parity-zcode.cjs [runtime ...]
-// With no args, regenerates ALL runtimes. With args, only the named runtimes.
-const targets = process.argv.slice(2).length > 0 ? process.argv.slice(2) : Object.keys(RUNTIME_META);
-fs.mkdirSync(FIXTURE_DIR, { recursive: true });
-
-// Build hooks/dist before capturing so fixtures are complete even in a clean
-// checkout (hooks/dist is gitignored + built; DEFECT.HOOKS-DIST-SCOPED-CI). The
-// test harness's before() hook does the same; without it a fresh checkout omits
-// every hooks/* path and this generator silently writes short fixtures.
-execFileSync(process.execPath, [BUILD_SCRIPT], { stdio: 'pipe' });
-
-for (const runtime of targets) {
-  if (!Object.prototype.hasOwnProperty.call(RUNTIME_META, runtime)) {
-    process.stderr.write(`[gen] unknown runtime '${runtime}' (not in RUNTIME_META) — skipping\n`);
-    continue;
-  }
-  const { configDir, root } = runMinimalInstall({ runtime, scope: 'global' });
-  let actual;
-  try {
-    actual = buildParityManifest(configDir, root);
-  } finally {
-    cleanup(root);
-  }
-  const fixturePath = path.join(FIXTURE_DIR, `${runtime}.json`);
-  fs.writeFileSync(fixturePath, JSON.stringify(actual, null, 2) + '\n', 'utf8');
-  process.stdout.write(`[gen] ${runtime}: wrote ${Object.keys(actual).length} file hashes -> ${fixturePath}\n`);
-}
-
-// Also regenerate the claude LOCAL legacy-layout fixture (claude-local.json).
-// This layout is distinct from the global install (commands/gsd-*.md +
-// agents/gsd-*.md) and has its own parity assertion in the test harness.
-const { configDir: localConfigDir, root: localRoot } = runMinimalInstall({ runtime: 'claude', scope: 'local' });
-let localActual;
-try {
-  localActual = buildParityManifest(localConfigDir, localRoot);
-} finally {
-  cleanup(localRoot);
-}
-const localFixturePath = path.join(FIXTURE_DIR, 'claude-local.json');
-fs.writeFileSync(localFixturePath, JSON.stringify(localActual, null, 2) + '\n', 'utf8');
-process.stdout.write(`[gen] claude-local: wrote ${Object.keys(localActual).length} file hashes -> ${localFixturePath}\n`);

package/scripts/update-size-baseline.cjs

@@ -1,68 +0,0 @@
-#!/usr/bin/env node
-'use strict';
-
-/**
- * @file update-size-baseline.cjs
- *
- * Regenerates the committed per-file workflow size baseline
- * (`tests/workflow-size-baseline.json`) from the current workflow files.
- *
- * Run via `npm run size:baseline` whenever a workflow file legitimately grows
- * or shrinks.  Growth must still be justified in the PR; this script only
- * records the new reality so the CI guard (issue #1074) can diff against it.
- *
- * Idempotent: running it twice with no file changes produces no diff.
- */
-
-const fs = require('fs');
-const path = require('path');
-const { measureMdFiles, WORKFLOWS_DIR } = require('./workflow-size.cjs');
-
-const BASELINE_PATH = path.join(__dirname, '..', 'tests', 'workflow-size-baseline.json');
-const AGENTS_DIR = path.join(__dirname, '..', 'agents');
-const AGENT_BASELINE_PATH = path.join(__dirname, '..', 'tests', 'agent-size-baseline.json');
-const isGsdAgent = (f) => f.startsWith('gsd-');
-
-/**
- * Serialize a size map to the on-disk baseline format: keys sorted, 2-space
- * indent, trailing newline (so the file is a stable, minimal-diff artifact).
- *
- * @param {Object<string, number>} sizes
- * @returns {string}
- */
-function serializeBaseline(sizes) {
-  const sorted = {};
-  for (const key of Object.keys(sizes).sort()) sorted[key] = sizes[key];
-  return JSON.stringify(sorted, null, 2) + '\n';
-}
-
-/**
- * Write a baseline file from the measured `.md` sizes in a directory.
- *
- * @param {object} [opts]
- * @param {string} [opts.dir]       - Directory to measure (default: workflows).
- * @param {string} [opts.outPath]   - Baseline file to write (default: workflow).
- * @param {function(string): boolean} [opts.predicate] - Filename filter.
- * @returns {{ outPath: string, count: number, content: string }}
- */
-function generateBaseline({ dir = WORKFLOWS_DIR, outPath = BASELINE_PATH, predicate } = {}) {
-  const sizes = measureMdFiles(dir, predicate);
-  const content = serializeBaseline(sizes);
-  fs.writeFileSync(outPath, content);
-  return { outPath, count: Object.keys(sizes).length, content };
-}
-
-if (require.main === module) {
-  const targets = [
-    { label: 'workflow', dir: WORKFLOWS_DIR, outPath: BASELINE_PATH },
-    { label: 'agent', dir: AGENTS_DIR, outPath: AGENT_BASELINE_PATH, predicate: isGsdAgent },
-  ];
-  for (const t of targets) {
-    const { outPath, count } = generateBaseline(t);
-    process.stdout.write(
-      `Wrote ${count} ${t.label} sizes to ${path.relative(process.cwd(), outPath)}\n`
-    );
-  }
-}
-
-module.exports = { generateBaseline, serializeBaseline, BASELINE_PATH, AGENT_BASELINE_PATH };