@opengsd/gsd-core 1.7.0-rc.5 → 1.7.0

package/gsd-core/bin/lib/phase.cjs

@@ -38,7 +38,7 @@ const phaseLocatorMod = require("./phase-locator.cjs");
 const { findPhaseInternal, getArchivedPhaseDirs } = phaseLocatorMod;
 // eslint-disable-next-line @typescript-eslint/no-require-imports -- roadmap-parser.cjs is an export= CommonJS module
 const roadmapParserMod = require("./roadmap-parser.cjs");
-const { stripShippedMilestones, extractCurrentMilestone, getMilestonePhaseFilter } = roadmapParserMod;
+const { stripShippedMilestones, extractCurrentMilestone, getMilestonePhaseFilter, currentMilestoneRawRanges, withPhaseSection } = roadmapParserMod;
 // eslint-disable-next-line @typescript-eslint/no-require-imports -- planning-workspace.cjs is an export= CommonJS module
 const planningWorkspace = require("./planning-workspace.cjs");
 // eslint-disable-next-line @typescript-eslint/no-require-imports -- frontmatter.cjs is an export= CommonJS module
@@ -49,6 +49,8 @@ const shell_command_projection_cjs_1 = require("./shell-command-projection.cjs")
 const runtime_slash_cjs_1 = require("./runtime-slash.cjs");
 const clock_cjs_1 = require("./clock.cjs");
 const state_transition_cjs_1 = require("./state-transition.cjs");
+const markdown_table_cjs_1 = require("./markdown-table.cjs");
+const markdown_sectionizer_cjs_1 = require("./markdown-sectionizer.cjs");
 // eslint-disable-next-line @typescript-eslint/no-require-imports -- uat-predicate.cjs is an export= CommonJS module
 const uatPredicate = require("./uat-predicate.cjs");
 const { evaluateUatPassed } = uatPredicate;
@@ -67,6 +69,43 @@ const looksLikePlanFile = (f) => /\.md$/i.test(f) &&
     /PLAN/i.test(f) &&
     !PLAN_OUTLINE_RE.test(f) &&
     !PLAN_PRE_BOUNCE_RE.test(f);
+/**
+ * Scope an `updateTableCell` call to the `## Traceability` (or
+ * `## Traceability Status`) heading's own section — up to the next H1/H2
+ * heading — instead of handing it the WHOLE REQUIREMENTS.md content.
+ *
+ * F1 (#2245 review, BLOCKER): `updateTableCell` binds to the FIRST GFM table
+ * found in whatever text it is given. The shipped requirements template
+ * (gsd-core/templates/requirements.md) puts an `## Out of Scope` table
+ * (`| Feature | Reason |`, no `Status` column) BEFORE `## Traceability` — so
+ * an unscoped whole-file call targets the Out-of-Scope table instead, fails
+ * with `{ok:false, reason:'unknown column: Status'}`, and the real
+ * Traceability row is never flipped, while the checkbox surface still flips
+ * and the command reports success (the #2140 silent-divergence class one
+ * level deeper). Mirrors `editProgressHeadingSlice` below, which scopes
+ * `## Progress` writes to that heading's own slice for the same reason.
+ *
+ * Falls back to running `updateTableCell` against the whole `text` when no
+ * `## Traceability` heading exists — matching the previous (unscoped)
+ * behaviour for a REQUIREMENTS.md whose traceability table sits under some
+ * other heading, or with no heading at all (never worse than before this fix).
+ */
+function updateTraceabilityCell(text, match, column, newValue) {
+    const headingMatch = text.match(/^##[ \t]+Traceability(?:[ \t]+Status)?\b/im);
+    if (!headingMatch || headingMatch.index === undefined) {
+        return (0, markdown_table_cjs_1.updateTableCell)(text, match, column, newValue);
+    }
+    const headingOffset = headingMatch.index;
+    const before = text.slice(0, headingOffset);
+    const fromHeading = text.slice(headingOffset);
+    const nextHeadingOffset = fromHeading.search(/\n#{1,2}[ \t]/);
+    const scoped = nextHeadingOffset >= 0 ? fromHeading.slice(0, nextHeadingOffset) : fromHeading;
+    const after = nextHeadingOffset >= 0 ? fromHeading.slice(nextHeadingOffset) : '';
+    const result = (0, markdown_table_cjs_1.updateTableCell)(scoped, match, column, newValue);
+    if (!result.ok)
+        return result;
+    return { ok: true, value: before + result.value + after };
+}
 function describeNonCanonicalPlans(dirFiles, matchedFiles) {
     const matched = new Set(matchedFiles);
     const offenders = dirFiles.filter((f) => looksLikePlanFile(f) && !matched.has(f));
@@ -313,9 +352,21 @@ function cmdFindPhase(cwd, phase, raw) {
                 .filter((e) => e.isDirectory())
                 .map((e) => e.name)
                 .sort((a, b) => comparePhaseNum(a, b));
-            const match = dirs.find((d) => phaseTokenMatches(d, normalized));
-            if (!match)
+            // #2237: fail loud when multiple directories match the same bare phase
+            // number — prevents cross-project file writes when unrelated projects
+            // share a .planning/phases/ tree.
+            const matches = dirs.filter((d) => phaseTokenMatches(d, normalized));
+            if (matches.length === 0)
                 continue;
+            if (matches.length > 1) {
+                output({
+                    ...notFound,
+                    ambiguous_matches: matches,
+                    warning: `Phase ${normalized} is ambiguous: ${matches.length} directories match (${matches.map(m => `"${m}"`).join(', ')}). Set a distinct project_code in .planning/config.json to scope resolution.`,
+                }, raw, '');
+                return;
+            }
+            const match = matches[0];
             const dirMatch = match.match(new RegExp(`^${OPTIONAL_PROJECT_CODE_PREFIX_SOURCE}(${PHASE_NUMBER_TOKEN_SOURCE})-?(.*)`, 'i')) || match.match(new RegExp(`^(${PHASE_NUMBER_TOKEN_SOURCE})-?(.*)`, 'i'));
             const phaseNumber = dirMatch ? dirMatch[1] : normalized;
             const phaseName = dirMatch && dirMatch[2] ? dirMatch[2] : null;
@@ -760,8 +811,27 @@ function cmdPhaseInsert(cwd, afterPhase, description, raw) {
         const phasesDir = node_path_1.default.join(planningDir(cwd), 'phases');
         const normalizedBase = normalizePhaseName(afterPhase);
         const decimalSet = new Set();
-        try {
-            const entries = node_fs_1.default.readdirSync(phasesDir, { withFileTypes: true });
+        // #2245 audit: existsSync-guarded, mirroring cmdPhaseNextDecimal's identical
+        // scan above — a missing phasesDir (no decimal sub-phases yet) is the
+        // expected, silent case (empty decimalSet). A readdirSync failure once the
+        // dir is confirmed to EXIST is a genuine anomaly; swallowing it used to let
+        // `phase insert` proceed with an incomplete decimalSet and risk writing a
+        // decimal phase number that collides with an existing on-disk directory
+        // the scan simply never saw — surfaced loud instead, like the sibling.
+        if (node_fs_1.default.existsSync(phasesDir)) {
+            // Initialized (not just declared) so TS's definite-assignment check is
+            // satisfied without relying on control-flow narrowing through error()'s
+            // `never` return, which TS does not propagate through a destructured
+            // module-property function reference — error() still halts the process
+            // before `dirs` below is ever computed from this placeholder value.
+            let entries = [];
+            try {
+                entries = node_fs_1.default.readdirSync(phasesDir, { withFileTypes: true });
+            }
+            catch (e) {
+                const msg = e instanceof Error ? e.message : String(e);
+                error(`Failed to scan phase directories for existing decimal phases: ${msg}`);
+            }
             const dirs = entries.filter((e) => e.isDirectory()).map((e) => e.name);
             const decimalPattern = new RegExp(`^${OPTIONAL_PROJECT_CODE_PREFIX_SOURCE}${escapeRegex(normalizedBase)}\\.(\\d+)`);
             for (const dir of dirs) {
@@ -770,9 +840,6 @@ function cmdPhaseInsert(cwd, afterPhase, description, raw) {
                     decimalSet.add(parseInt(dm[1], 10));
             }
         }
-        catch {
-            /* intentionally empty */
-        }
         const rmPhasePattern = new RegExp(`#{2,4}\\s*Phase\\s+${phaseMarkdownRegexSource(normalizedBase)}\\.(\\d+)${OPTIONAL_PHASE_TAG_SOURCE}\\s*:`, 'gi');
         let rmMatch;
         while ((rmMatch = rmPhasePattern.exec(rawContent)) !== null) {
@@ -940,19 +1007,186 @@ function decrementRoadmapPaddedPhaseNumber(raw, removedInt) {
         return raw;
     return String(num - 1).padStart(raw.length, '0');
 }
+/**
+ * Return the RAW text of the `dataRowIndex`-th data row line (0-based, in
+ * file order — header and delimiter rows excluded) of the FIRST GFM table
+ * found in `sectionText`, or `null` when the table or that row doesn't exist.
+ *
+ * F8 (#2245 review, nit) support helper: addresses a table row by its
+ * STRUCTURAL position rather than by matching its (possibly non-unique)
+ * trimmed cell content — see the Progress-ordinal renumber's padding-recovery
+ * use below for why content-matching is unsafe here (two rows with identical
+ * trimmed Phase text, or a row whose already-rewritten new value coincides
+ * with another row's pre-edit text, would otherwise resolve to the wrong line).
+ */
+function findDataRowLine(sectionText, dataRowIndex) {
+    const lines = sectionText.split(/\r?\n/);
+    let headerIdx = -1;
+    for (let i = 0; i < lines.length; i++) {
+        const trimmed = lines[i].trim();
+        if (trimmed.startsWith('|') && trimmed.indexOf('|', 1) !== -1) {
+            headerIdx = i;
+            break;
+        }
+    }
+    if (headerIdx === -1)
+        return null;
+    let seen = -1;
+    for (let i = headerIdx + 2; i < lines.length; i++) {
+        if (!lines[i].trim().startsWith('|'))
+            break;
+        seen += 1;
+        if (seen === dataRowIndex)
+            return lines[i];
+    }
+    return null;
+}
 function updateRoadmapAfterPhaseRemoval(roadmapPath, targetPhase, isDecimal, removedInt, cwd) {
     withPlanningLock(cwd, () => {
         let content = node_fs_1.default.readFileSync(roadmapPath, 'utf-8');
         const escaped = escapeRegex(targetPhase);
-        content = content.replace(new RegExp(`\\n?(?<h>#{2,4})\\s*Phase\\s+${escaped}${OPTIONAL_PHASE_TAG_SOURCE}\\s*:[\\s\\S]*?(?=\\n\\k<h>(?!#)\\s+Phase\\s+[^\\n:]+\\s*:|$)`, 'i'), '');
+        // SECTION-DELETION (not a section-body edit) — removes the phase's ENTIRE
+        // detail section INCLUDING its own heading line. Migrated onto deleteSection
+        // (ADR-2143 §4 / markdown-sectionizer T7): it locates the target heading via
+        // tokenizeHeadings + this predicate, then splices out the range from that
+        // heading's own start through the next heading of the SAME-OR-HIGHER level —
+        // whatever that heading's text is. This fixes a data-loss bug in the prior
+        // hand-rolled regex, whose lookahead only recognised ANOTHER "Phase N:"
+        // heading as a stop boundary: removing the LAST phase in a roadmap left no
+        // such heading to stop at, so the lazy `[\s\S]*?` scan ran to EOF and swept
+        // away everything after it — including a trailing `## Progress` heading and
+        // its tracking table.
+        const phaseHeadingRe = new RegExp(`^Phase\\s+${escaped}${OPTIONAL_PHASE_TAG_SOURCE}\\s*:`, 'i');
+        content = (0, markdown_sectionizer_cjs_1.deleteSection)(content, (h) => h.level >= 2 && h.level <= 4 && phaseHeadingRe.test(h.text));
         content = content.replace(new RegExp(`\\n?-\\s*\\[[ x]\\]\\s*.*Phase\\s+${escaped}${OPTIONAL_PHASE_TAG_SOURCE}[:\\s][^\\n]*`, 'gi'), '');
-        content = content.replace(new RegExp(`\\n?\\|\\s*${escaped}\\.?\\s[^|]*\\|[^\\n]*`, 'gi'), '');
+        // ROW-DELETION (not a cell update) — removes the WHOLE Progress-table row
+        // for a removed phase via deleteTableRow (ADR-2143 §7 row-removal sibling
+        // of updateTableCell). Scoped to the `## Progress` section — mirroring
+        // deriveProgressFromRoadmap's read-side scoping (phase-lifecycle.cts) —
+        // so a same-numbered row in an earlier, unrelated table (e.g. a
+        // `| Phase | Requirements | Count |` table preceding `## Progress`,
+        // #2012) is never touched. Matches the row by its FIRST cell only: for an
+        // integer removal, a zero-pad-insensitive leading-integer comparison
+        // (`01.`, `1.`, `1 `, bare `1` all match phase 1; a decimal sub-phase
+        // cell like `2.5` never matches an integer removal); for a decimal
+        // removal, the exact decimal token. This replaces the prior regex's
+        // `\.?\s` requirement, which silently left a COMPACT unpadded row (e.g.
+        // `|2|0/2|Planned|-|`) undeleted — its closing `|` follows the digit with
+        // no whitespace to match (#2245 audit) — and which was also unscoped to
+        // any particular table.
+        const progressHeadingMatch = content.match(/^##[ \t]+Progress\b/im);
+        if (progressHeadingMatch && progressHeadingMatch.index !== undefined) {
+            const headingOffset = progressHeadingMatch.index;
+            const before = content.slice(0, headingOffset);
+            const fromHeading = content.slice(headingOffset);
+            const nextHeadingOffset = fromHeading.search(/\n#{1,2}[ \t]/);
+            const progressSection = nextHeadingOffset >= 0 ? fromHeading.slice(0, nextHeadingOffset) : fromHeading;
+            const rest = nextHeadingOffset >= 0 ? fromHeading.slice(nextHeadingOffset) : '';
+            const matchRemovedProgressRow = (row) => {
+                const firstCellRaw = (Object.values(row)[0] ?? '').trim();
+                if (isDecimal) {
+                    return new RegExp(`^${escaped}\\.?(?:\\s|$)`, 'i').test(firstCellRaw);
+                }
+                const leadingMatch = firstCellRaw.match(/^0*(\d+)(\.\d+)?/);
+                if (!leadingMatch || leadingMatch[2])
+                    return false;
+                return parseInt(leadingMatch[1], 10) === removedInt;
+            };
+            const deleteResult = (0, markdown_table_cjs_1.deleteTableRow)(progressSection, matchRemovedProgressRow);
+            if (deleteResult.ok) {
+                content = before + deleteResult.value + rest;
+            }
+        }
         if (!isDecimal) {
             // #1729: fold an optional pre-colon ( ) tag into the suffix capture so it
             // is re-emitted verbatim — a tagged later phase still gets renumbered.
             content = content.replace(/(#{2,4}\s*Phase\s+)(\d+(?:\.\d+)?)((?:\s*\([^)\n]{0,200}\))?\s*:)/gi, (_match, prefix, num, suffix) => `${prefix}${decrementRoadmapPhaseToken(num, removedInt)}${suffix}`);
             content = content.replace(/(-\s*\[[ x]\]\s*.*?Phase\s+)(\d+)(\s*:|\s+)/gi, (_match, prefix, num, suffix) => `${prefix}${decrementRoadmapPhaseNumber(num, removedInt)}${suffix}`);
-            content = content.replace(/(\|\s*)(\d+)(\.\s)/g, (_match, prefix, num, suffix) => `${prefix}${decrementRoadmapPhaseNumber(num, removedInt)}${suffix}`);
+            // ORDINAL-RENUMBER — CELL EDIT (not row-deletion) — migrated onto
+            // updateTableCell (ADR-2143 §7, sibling of the deleteTableRow scoping
+            // directly above). The prior whole-document regex
+            // `/(\|\s*)(\d+)(\.\s)/g` rewrote ANY `| N. ` cell anywhere in the
+            // file — including a same-shaped cell in an UNRELATED, earlier table
+            // (e.g. a `| Phase | Requirements | Count |` table, or a decoy table,
+            // preceding `## Progress`; #2245-class scoping defect, same family as
+            // the row-delete fix above). Scoped here to the `## Progress` section
+            // only, mirroring that same section-slice-then-splice-back pattern.
+            //
+            // Loops because updateTableCell only rewrites the FIRST matching row
+            // per call. `processedOrdinalRows` tracks by row INDEX (stable across
+            // iterations — this only edits cell content, it never inserts/deletes
+            // rows) so an already-decremented row's new value — which may still
+            // numerically exceed `removedInt` — is never re-selected and
+            // decremented a second time (matching on the row's CURRENT value alone,
+            // without this guard, would keep re-firing on each pass).
+            //
+            // `phaseCellShapeRe` is the exact digit+dot-space shape the old regex
+            // required: a decimal sub-phase ordinal like `2.5` (no whitespace
+            // between the dot and the next character) never matches it, so it is
+            // left untouched — identical decimal-safety to the prior behaviour.
+            //
+            // updateTableCell hands the callback the TRIMMED, UNESCAPED cell value
+            // only, so the row's original leading/trailing alignment padding is
+            // recovered by a narrow, anchored lookup within that row's OWN raw
+            // line — addressed by ROW INDEX (`matchedRowIndex`, via
+            // `findDataRowLine`), not by searching the whole section for content
+            // matching the trimmed value (F8 #2245 review: two rows with identical
+            // trimmed Phase text, or a row whose already-rewritten new value
+            // coincides with another row's pre-edit text, would otherwise resolve
+            // to the WRONG row's padding — the first/leftmost content match found).
+            // The lookup searches for `escapeCell(current)` (F3 #2245 review: the
+            // ESCAPED form, e.g. `Foo \| Bar`) — the raw line always carries the
+            // escaped form, so searching for the unescaped `current` would
+            // silently fail to find an escaped-pipe cell's own line — preserving
+            // every other byte of the row (ADR-2143 §7 byte-parity) while only the
+            // digits actually change.
+            const ordinalHeadingMatch = content.match(/^##[ \t]+Progress\b/im);
+            if (ordinalHeadingMatch && ordinalHeadingMatch.index !== undefined) {
+                const ordinalHeadingOffset = ordinalHeadingMatch.index;
+                const ordinalBefore = content.slice(0, ordinalHeadingOffset);
+                const ordinalFromHeading = content.slice(ordinalHeadingOffset);
+                const ordinalNextHeadingOffset = ordinalFromHeading.search(/\n#{1,2}[ \t]/);
+                let ordinalSection = ordinalNextHeadingOffset >= 0
+                    ? ordinalFromHeading.slice(0, ordinalNextHeadingOffset)
+                    : ordinalFromHeading;
+                const ordinalRest = ordinalNextHeadingOffset >= 0 ? ordinalFromHeading.slice(ordinalNextHeadingOffset) : '';
+                const phaseCellShapeRe = /^(\d+)(\.\s)/;
+                const processedOrdinalRows = new Set();
+                let matchedRowIndex = null;
+                for (;;) {
+                    matchedRowIndex = null;
+                    const cellResult = (0, markdown_table_cjs_1.updateTableCell)(ordinalSection, (row, index) => {
+                        if (processedOrdinalRows.has(index))
+                            return false;
+                        const m = phaseCellShapeRe.exec(row['Phase'] ?? '');
+                        if (!m)
+                            return false;
+                        const num = parseInt(m[1], 10);
+                        if (!Number.isInteger(num) || num <= removedInt || num === 999)
+                            return false;
+                        processedOrdinalRows.add(index);
+                        matchedRowIndex = index;
+                        return true;
+                    }, 'Phase', (current) => {
+                        const m = phaseCellShapeRe.exec(current);
+                        if (!m)
+                            return current;
+                        const decremented = decrementRoadmapPhaseNumber(m[1], removedInt);
+                        const newContent = `${decremented}${m[2]}${current.slice(m[0].length)}`;
+                        const targetLine = matchedRowIndex === null ? null : findDataRowLine(ordinalSection, matchedRowIndex);
+                        const padMatch = targetLine
+                            ? new RegExp(`^[ \\t]*\\|(\\s*)${escapeRegex((0, markdown_table_cjs_1.escapeCell)(current))}(\\s*)\\|`).exec(targetLine)
+                            : null;
+                        const leadPad = padMatch ? padMatch[1] : ' ';
+                        const trailPad = padMatch ? padMatch[2] : ' ';
+                        return `${leadPad}${(0, markdown_table_cjs_1.escapeCell)(newContent)}${trailPad}`;
+                    });
+                    if (!cellResult.ok)
+                        break;
+                    ordinalSection = cellResult.value;
+                }
+                content = ordinalBefore + ordinalSection + ordinalRest;
+            }
             content = content.replace(/(?<![0-9-])(\d{2})-(\d{2})(?=(?:(?:-[A-Za-z][A-Za-z0-9-]*)?-(?:PLAN|SUMMARY)\.md)|(?![0-9-]))/g, (_match, phaseNum, planNum) => `${decrementRoadmapPaddedPhaseNumber(phaseNum, removedInt)}-${planNum}`);
             content = content.replace(/(\*\*Depends on\*\*\s*:\s*Phase\s+)(\d+(?:\.\d+)?)\b/gi, (_match, prefix, num) => `${prefix}${decrementRoadmapPhaseToken(num, removedInt)}`);
             content = content.replace(/(Depends on:\*\*\s*Phase\s+)(\d+(?:\.\d+)?)\b/gi, (_match, prefix, num) => `${prefix}${decrementRoadmapPhaseToken(num, removedInt)}`);
@@ -990,8 +1224,18 @@ function cmdPhaseRemove(cwd, targetPhase, options, raw) {
         renamedDirs = renamed.renamedDirs;
         renamedFiles = renamed.renamedFiles;
     }
-    catch {
-        /* intentionally empty */
+    catch (e) {
+        // #2245 audit (was ERROR-HIDING): renameDecimalPhases/renameIntegerPhases
+        // rename subsequent phase directories ON DISK one at a time — a mid-loop
+        // failure leaves SOME directories already renumbered and others not, with
+        // no way to recover which (the callee's own renamedDirs/renamedFiles never
+        // reach this scope when it throws). Silently swallowing this and falling
+        // through to updateRoadmapAfterPhaseRemoval below used to rewrite
+        // ROADMAP.md's phase numbers assuming the ENTIRE renumbering succeeded,
+        // permanently desyncing ROADMAP.md from the actual (partially-renamed)
+        // on-disk directory names. Surface loud instead of compounding it.
+        const msg = e instanceof Error ? e.message : String(e);
+        error(`Failed to renumber phase directories after removing phase ${targetPhase}: ${msg}`);
     }
     updateRoadmapAfterPhaseRemoval(roadmapPath, targetPhase, isDecimal, parseInt(normalized, 10), cwd);
     const statePath = node_path_1.default.join(planningDir(cwd), 'STATE.md');
@@ -1085,7 +1329,7 @@ function cmdPhaseComplete(cwd, phaseNum, raw) {
     const roadmapPath = node_path_1.default.join(planningDir(cwd), 'ROADMAP.md');
     const statePath = node_path_1.default.join(planningDir(cwd), 'STATE.md');
     const phasesDir = node_path_1.default.join(planningDir(cwd), 'phases');
-    const today = clock_cjs_1.realClock.today();
+    const today = clock_cjs_1.realClock.localToday();
     const phaseInfoRaw = findPhaseInternal(cwd, phaseNum);
     if (!phaseInfoRaw) {
         error(`Phase ${phaseNum} not found`);
@@ -1130,7 +1374,11 @@ function cmdPhaseComplete(cwd, phaseNum, raw) {
         }
     }
     catch {
-        /* intentionally empty */
+        /* best-effort (#2245 audit): this is an ADVISORY pre-scan of UAT/
+         * VERIFICATION files for `warnings` in the phase-complete output — the
+         * actual completion GATE is readVerificationStatus below (a separate
+         * mechanism). A readdirSync/readFileSync failure here just means fewer
+         * warnings are surfaced this run, not a blocked or corrupted completion. */
     }
     let nextPhaseNum = null;
     let nextPhaseName = null;
@@ -1153,50 +1401,143 @@ function cmdPhaseComplete(cwd, phaseNum, raw) {
                 // so completing an already-checked phase (idempotent re-run) checked the
                 // wrong phase's box. Mirrors the tight pattern used by phase-insert
                 // (`]\\s*(?:\\*\\*)?Phase`).
-                const checkboxPattern = new RegExp(`(-\\s*\\[)[ ](\\]\\s*(?:\\*\\*)?\\s*Phase\\s+${phaseEscaped}${OPTIONAL_PHASE_TAG_SOURCE}[:\\s][^\\n]*)`, 'i');
-                roadmapContent = roadmapContent.replace(checkboxPattern, `$1x$2 (completed ${today})`);
-                const tableRowPattern = new RegExp(`^(\\|\\s*${phaseEscaped}\\.?\\s[^|]*(?:\\|[^\\n]*))$`, 'im');
-                // Scope the Progress-row search to the ## Progress section so the regex
-                // doesn't bind to an earlier table (e.g. | Phase | Requirements | Count |)
-                // whose rows also start with the phase number. (#2012)
-                const updateProgressRow = (fullRow) => {
-                    const cells = fullRow.split('|').slice(1, -1);
-                    const dateShape = /^\d{4}-\d{2}-\d{2}$/;
-                    if (cells.length === 5) {
-                        cells[2] = ` ${summaryCount}/${planCount} `;
-                        cells[3] = ' Complete    ';
-                        // Preserve only a valid ISO date (#1161: idempotent; self-heal garbage)
-                        const existingDate5 = cells[4].trim();
-                        cells[4] = dateShape.test(existingDate5) ? cells[4] : ` ${today} `;
-                    }
-                    else if (cells.length === 4) {
-                        cells[1] = ` ${summaryCount}/${planCount} `;
-                        cells[2] = ' Complete    ';
-                        // Preserve only a valid ISO date (#1161: idempotent; self-heal garbage)
-                        const existingDate4 = cells[3].trim();
-                        cells[3] = dateShape.test(existingDate4) ? cells[3] : ` ${today} `;
+                // #2067/#2200: line-anchored (^, optional leading indent) so an
+                // inline / backticked prose literal cannot match. Milestone-scoped below
+                // (mutateMilestonePhase) so a Backlog entry or a same-numbered shipped-
+                // milestone phase cannot be flipped either.
+                // ADR-2143 §4 note / #2245 audit: this is the phase-LIST checkbox — it
+                // lives in the milestone's `- [ ] Phase N: …` checklist, OUTSIDE any
+                // `### Phase N` detail section, so there is no section for
+                // withPhaseSection to bind to. Migrated onto the sectionizer's
+                // `updateBullet` bullet-write seam: the pattern itself is unchanged,
+                // only the "find the right line, splice it back" plumbing moved off a
+                // whole-slice `.replace()` onto the seam. Applied per single physical
+                // line by updateBullet, so the pattern no longer needs the `m` flag
+                // (it never sees more than one line at a time); see
+                // planCountBodyPattern below for the sites that were migrated onto
+                // withPhaseSection instead.
+                //
+                // #2245 review Fix 6: this is behaviour-preserving for GSD-GENERATED
+                // inputs (the only shape ROADMAP.md ever actually has), NOT byte-parity
+                // across every conceivable input. `updateBullet` is fence-aware — a
+                // checkbox-shaped line inside a fenced (``` / ~~~) code block is never
+                // offered to `match`/`transform` — whereas the retired whole-slice
+                // `.replace()` had no such fence tracking and would have flipped a
+                // bullet-shaped line inside a fence too. That divergence has no live
+                // bug because a GSD-authored ROADMAP.md milestone checklist never puts
+                // its own `- [ ] Phase N: …` entries inside a fenced code block, but it
+                // is a real (and correct) behavioural difference on pathological input.
+                const checkboxPattern = new RegExp(`^[ \\t]*(-\\s*\\[)[ ](\\]\\s*(?:\\*\\*)?\\s*Phase\\s+${phaseEscaped}${OPTIONAL_PHASE_TAG_SOURCE}[:\\s][^\\n]*)`, 'i');
+                // Progress table row: update Plans Complete/Status/Completed columns BY
+                // COLUMN NAME (handles 4- or 5-column RoadmapProgress tables) via the
+                // markdown-table seam (ADR-2143 §7) — supersedes the prior ordinal
+                // cells[]-index regex. Applied inside mutateMilestonePhase below (per
+                // milestone window), further scoped to the ## Progress heading within
+                // that window so the row lookup doesn't bind to an earlier table (e.g.
+                // | Phase | Requirements | Count |) whose rows also start with the
+                // phase number (#2012).
+                // #2245 Blocker 4: optional dot must be followed by whitespace-or-end,
+                // not dot-OR-whitespace-OR-end as alternatives — the prior form let a
+                // bare "." satisfy the whole lookahead, so completing phase "2"
+                // over-matched a decimal sub-phase row like "2.5 Extra". Matches "2",
+                // "2.", "2 Alpha"; rejects "2.5 Extra".
+                const phaseCellRe = new RegExp(`^${phaseEscaped}\\.?(?:\\s|$)`, 'i');
+                const rowMatch = (row) => phaseCellRe.test((row['Phase'] ?? '').trim());
+                const dateShape = /^\d{4}-\d{2}-\d{2}$/;
+                /**
+                 * Within `text` (already scoped to one milestone window by the
+                 * caller), scope further to the `## Progress` heading section (up to
+                 * the next `#`/`##` heading) when present, run `edit` against just
+                 * that slice, and splice the result back — falling back to the whole
+                 * `text` when no `## Progress` heading exists (mirrors phase-
+                 * lifecycle.cjs's deriveProgressFromRoadmap read-side scoping).
+                 */
+                const editProgressHeadingSlice = (text, edit) => {
+                    const progressMatch = text.match(/^##[ \t]+Progress\b/im);
+                    if (!progressMatch || progressMatch.index === undefined) {
+                        return edit(text);
                     }
-                    return '|' + cells.join('|') + '|';
+                    const headingOffset = progressMatch.index;
+                    const beforeHeading = text.slice(0, headingOffset);
+                    const fromHeading = text.slice(headingOffset);
+                    const nextHeading = fromHeading.search(/\n#{1,2}[ \t]/);
+                    const scoped = nextHeading >= 0 ? fromHeading.slice(0, nextHeading) : fromHeading;
+                    const after = nextHeading >= 0 ? fromHeading.slice(nextHeading) : '';
+                    return beforeHeading + edit(scoped) + after;
                 };
-                const progressIdx = roadmapContent.indexOf('## Progress');
-                if (progressIdx >= 0) {
-                    const beforeProgress = roadmapContent.slice(0, progressIdx);
-                    const progressSection = roadmapContent.slice(progressIdx);
-                    roadmapContent = beforeProgress + progressSection.replace(tableRowPattern, updateProgressRow);
+                // ADR-2143 §4: the plan-count write is now routed through
+                // withPhaseSection (see mutateMilestonePhase below), which hands this
+                // pattern ONLY phase N's own detail-section body — so the pattern no
+                // longer needs its own `#{2,4}\s*Phase\s+N` anchor + skip-ahead-past-
+                // interior-headings lookahead; the section boundary itself confines
+                // the match (the #2067/#2200 boundary-crossing class is now
+                // structurally impossible for this site rather than regex-enforced).
+                const planCountBodyPattern = /(\*\*Plans:\*\*\s*)[^\n]+/i;
+                const phaseInfoSummaries = phaseInfo['summaries'];
+                // #2200: apply the phase-checkbox flip, the plan-count write, and the
+                // per-plan checkbox flips ONLY within the current milestone's region(s)
+                // (primary section + optional Phase Details section). A bullet/heading in
+                // a shipped milestone, a Backlog section, or a backticked prose literal is
+                // outside the window and stays untouched. With no versioned active
+                // milestone, fall back to whole-content mutation (prior behaviour).
+                const mutateMilestonePhase = (slice) => {
+                    let s = slice;
+                    s = (0, markdown_sectionizer_cjs_1.updateBullet)(s, (_bulletText, rawLine) => checkboxPattern.test(rawLine), (rawLine) => rawLine.replace(checkboxPattern, `$1x$2 (completed ${today})`));
+                    s = editProgressHeadingSlice(s, (scoped) => {
+                        let text = scoped;
+                        const plansResult = (0, markdown_table_cjs_1.updateTableCell)(text, rowMatch, 'Plans Complete', ` ${summaryCount}/${planCount} `);
+                        if (plansResult.ok)
+                            text = plansResult.value;
+                        const statusResult = (0, markdown_table_cjs_1.updateTableCell)(text, rowMatch, 'Status', ' Complete    ');
+                        if (statusResult.ok)
+                            text = statusResult.value;
+                        // Preserve only a valid ISO date (#1161: idempotent; self-heal
+                        // garbage). Ragged-tolerant (#2245 Blocker 2): decide via the
+                        // CURRENT Completed cell inside a single updateTableCell callback
+                        // (its own tolerant row scan) rather than gating on
+                        // findTableWithColumns (which requires the WHOLE table to parse —
+                        // a ragged SIBLING row elsewhere used to silently no-op this
+                        // row's date stamp too).
+                        const completedResult = (0, markdown_table_cjs_1.updateTableCell)(text, rowMatch, 'Completed', (current) => dateShape.test(current.trim()) ? current : ` ${today} `);
+                        if (completedResult.ok)
+                            text = completedResult.value;
+                        return text;
+                    });
+                    // ADR-2143 §4: the plan-count write and the per-plan checkbox flips
+                    // are both scoped to phase N's OWN detail section via
+                    // withPhaseSection — the edit callback below only ever sees that
+                    // section's body, so neither regex can escape into a sibling
+                    // phase's section, a shipped milestone, or a Backlog entry.
+                    s = withPhaseSection(s, phaseNum, (body) => {
+                        let b = body.replace(planCountBodyPattern, `$1${summaryCount}/${planCount} plans complete`);
+                        for (const summaryFile of phaseInfoSummaries) {
+                            const planId = summaryFile.replace('-SUMMARY.md', '').replace('SUMMARY.md', '');
+                            if (!planId)
+                                continue;
+                            const planEscaped = escapeRegex(planId);
+                            const planCheckboxPattern = new RegExp(`(-\\s*\\[) (\\]\\s*(?:\\*\\*)?${planEscaped}(?:\\*\\*)?)`, 'i');
+                            b = b.replace(planCheckboxPattern, '$1x$2');
+                        }
+                        return b;
+                    });
+                    return s;
+                };
+                const milestoneRanges = currentMilestoneRawRanges(roadmapContent, cwd);
+                if (milestoneRanges) {
+                    // Splice later windows first so an earlier window's offsets are not
+                    // shifted by a length-changing mutation in a later window.
+                    const windows = [milestoneRanges.details, milestoneRanges.primary]
+                        .filter((w) => w !== null)
+                        .sort((a, b) => b.start - a.start);
+                    for (const w of windows) {
+                        roadmapContent =
+                            roadmapContent.slice(0, w.start)
+                                + mutateMilestonePhase(roadmapContent.slice(w.start, w.end))
+                                + roadmapContent.slice(w.end);
+                    }
                 }
                 else {
-                    roadmapContent = roadmapContent.replace(tableRowPattern, updateProgressRow);
-                }
-                const planCountPattern = new RegExp(`(#{2,4}\\s*Phase\\s+${phaseEscaped}(?:(?!\\n#{1,4}\\s)[\\s\\S])*?\\*\\*Plans:\\*\\*\\s*)[^\\n]+`, 'i');
-                roadmapContent = roadmapContent.replace(planCountPattern, `$1${summaryCount}/${planCount} plans complete`);
-                const phaseInfoSummaries = phaseInfo['summaries'];
-                for (const summaryFile of phaseInfoSummaries) {
-                    const planId = summaryFile.replace('-SUMMARY.md', '').replace('SUMMARY.md', '');
-                    if (!planId)
-                        continue;
-                    const planEscaped = escapeRegex(planId);
-                    const planCheckboxPattern = new RegExp(`(-\\s*\\[) (\\]\\s*(?:\\*\\*)?${planEscaped}(?:\\*\\*)?)`, 'i');
-                    roadmapContent = (roadmapContent).replace(planCheckboxPattern, '$1x$2');
+                    roadmapContent = mutateMilestonePhase(roadmapContent);
                 }
                 writes.push({
                     filePath: roadmapPath,
@@ -1221,7 +1562,24 @@ function cmdPhaseComplete(cwd, phaseNum, raw) {
                         for (const reqId of reqIds) {
                             const reqEscaped = escapeRegex(reqId);
                             reqContent = reqContent.replace(new RegExp(`(-\\s*\\[)[ ](\\]\\s*\\*\\*${reqEscaped}\\*\\*)`, 'gi'), '$1x$2');
-                            reqContent = reqContent.replace(new RegExp(`(\\|\\s*${reqEscaped}\\s*\\|[^|]+\\|)\\s*(?:Pending|In Progress)\\s*(\\|)`, 'gi'), '$1 Complete $2');
+                            // Traceability row: | <REQ-ID> | Phase N | Pending|In Progress | ->
+                            // ... Complete | via the markdown-table seam (ADR-2143 §7). Match the
+                            // row by its FIRST cell's value (the requirement-ID column) regardless
+                            // of that column's HEADER name — real tables head it `REQ-ID`, others
+                            // `Requirement` (#2769/#2203); this mirrors the prior regex's first-cell
+                            // `\|\s*<id>\s*\|` anchor, not a by-name lookup. Object.values(row) is in
+                            // header order, so [0] is the first column. Case-insensitive.
+                            const reqRowMatch = (row) => (Object.values(row)[0] ?? '').trim().toLowerCase() === reqId.toLowerCase();
+                            // Ragged-tolerant (#2245 Blocker 2): drive the write purely off
+                            // updateTableCell's own tolerant row scan — a DIFFERENT
+                            // requirement's row elsewhere in the same table having a
+                            // mismatched cell count must never silently no-op THIS
+                            // requirement's write. The "only flip Pending/In Progress ->
+                            // Complete" gate is folded into the newValue callback so one
+                            // updateTableCell call both probes and writes.
+                            const reqUpdate = updateTraceabilityCell(reqContent, reqRowMatch, 'Status', (current) => /^(?:pending|in progress)$/i.test(current.trim()) ? ' Complete ' : current);
+                            if (reqUpdate.ok)
+                                reqContent = reqUpdate.value;
                         }
                     }
                     // #1159 (Defect B): collect requirement IDs only from ACTIVE sections.
@@ -1283,7 +1641,11 @@ function cmdPhaseComplete(cwd, phaseNum, raw) {
                         ? reqContent.slice(traceabilityHeadingMatch.index)
                         : '';
                     const tableReqIds = new Set();
-                    const tableRowPat = /^\|\s*([A-Z][A-Z0-9]*-\d+)\s*\|/gm;
+                    // #2203: match REQ-IDs in any pipe-delimited cell (not just the first
+                    // column) so a traceability table that leads with a status column (e.g.
+                    // | ☐ | REQ-01 | …) is parsed correctly instead of reporting every row
+                    // as missing.
+                    const tableRowPat = /\|\s*([A-Z][A-Z0-9]*-\d+)\s*\|/g;
                     let tableMatch;
                     while ((tableMatch = tableRowPat.exec(traceabilitySection)) !== null) {
                         tableReqIds.add(tableMatch[1]);
@@ -1319,7 +1681,13 @@ function cmdPhaseComplete(cwd, phaseNum, raw) {
                 }
             }
             catch {
-                /* intentionally empty */
+                /* best-effort (#2245 audit): stage 1 of a deliberate 3-stage
+                 * cascading fallback for locating the next phase (disk dirs → roadmap
+                 * headings/checkboxes → lowest-outstanding-checkbox override, #2028
+                 * below). A disk-scan failure here is indistinguishable from "found
+                 * nothing on disk" and correctly falls through to stage 2, which
+                 * derives the same information independently from ROADMAP.md content
+                 * — not a silent data-loss path. */
             }
             if (isLastPhase && roadmapContent !== null) {
                 try {
@@ -1355,10 +1723,13 @@ function cmdPhaseComplete(cwd, phaseNum, raw) {
                     }
                 }
                 catch {
-                    /* intentionally empty */
+                    /* best-effort (#2245 audit): stage 2 of the next-phase cascade
+                     * (see stage 1's comment above) — a failure here just leaves
+                     * isLastPhase as stage 1 left it; stage 3 (#2028) below runs next
+                     * regardless and provides a further, independent override. */
                 }
             }
-            // #2028: don't stamp "Milestone complete" when a LOWER-numbered phase is
+            // #2028: don't stamp "All phases complete" when a LOWER-numbered phase is
             // still outstanding. The two blocks above only clear isLastPhase when a
             // HIGHER-numbered phase exists, so completing the numerically-highest phase
             // out of order (e.g. Phase 10 before Phase 9) wrongly read as milestone-end.
@@ -1396,7 +1767,11 @@ function cmdPhaseComplete(cwd, phaseNum, raw) {
                     }
                 }
                 catch {
-                    /* intentionally empty */
+                    /* best-effort (#2245 audit): stage 3 (#2028) of the next-phase
+                     * cascade — a failure here simply leaves isLastPhase/nextPhaseNum
+                     * as stages 1-2 already determined them; this stage only ever
+                     * overrides toward "not last" when it finds a genuinely lower
+                     * outstanding phase, never the reverse. */
                 }
             }
             if (node_fs_1.default.existsSync(statePath)) {