@opengsd/gsd-core 1.7.0-rc.4 → 1.7.0-rc.6

package/gsd-core/bin/lib/runtime-config-adapter-registry.cjs

@@ -21,17 +21,30 @@
  *     false for codex / copilot / kilo / cursor / windsurf / trae / cline / kimi (legacy exclusion list).
  *     true for all other runtimes.
  * - `finishPermissionWriter` names the finishInstall-phase dedicated config writer:
- *     'opencode' → writes BOTH shared settings AND its own permissions file.
- *     'kilo'     → writes only its own permissions file.
- *     null       → no dedicated permission writer.
+ *     'opencode'    → writes BOTH shared settings AND its own permissions file.
+ *     'kilo'        → writes only its own permissions file.
+ *     'antigravity' → writes BOTH shared settings.json permissions.allow AND a
+ *                      standalone mcp_config.json MCP companion profile (#2096
+ *                      Phase B Upgrades 1+2).
+ *     null          → no dedicated permission writer.
  */
 // eslint-disable-next-line @typescript-eslint/no-require-imports
 const { runtimes } = require('./capability-registry.cjs');
 /** Valid sandboxTier enum values — mirrors the gen-capability-registry validator vocabulary. */
 const VALID_SANDBOX_TIERS = new Set(['none', 'codex-agent-sandbox']);
-/** The complete set of 16 supported runtimes for config-adapter dispatch. */
+/**
+ * The complete set of 16 supported runtimes for config-adapter dispatch.
+ *
+ * Excludes runtimes whose installSurface is 'none' (#2103 — e.g. VS Code): a
+ * 'none' installSurface means the runtime has NO CLI install surface at all
+ * (Marketplace/VSIX-distributed, never dispatched through
+ * install()/finishInstall()), so it is not a "config-adapter runtime" by
+ * definition. This keeps this set in lockstep with bin/install.js's
+ * `allRuntimes` (see tests/issue-57-runtime-install-no-drift.test.cjs) without
+ * needing a separate hand-kept exclusion list.
+ */
 const ALLOWED_CONFIG_RUNTIMES = new Set(Object.entries(runtimes)
-    .filter(([, cap]) => cap && cap.runtime && typeof cap.runtime['installSurface'] === 'string')
+    .filter(([, cap]) => cap && cap.runtime && typeof cap.runtime['installSurface'] === 'string' && cap.runtime['installSurface'] !== 'none')
     .map(([id]) => id));
 /** All valid installSurface values. */
 const INSTALL_SURFACES = Object.freeze([
@@ -41,6 +54,7 @@ const INSTALL_SURFACES = Object.freeze([
     'cline-rules',
     'cursor-hooks-json',
     'profile-marker-only',
+    'none',
 ]);
 /**
  * Resolve the config adapter intent for a given runtime.

package/gsd-core/bin/lib/runtime-homes.cjs

@@ -38,6 +38,7 @@ exports.resolveConfigHomeFromDescriptor = resolveConfigHomeFromDescriptor;
 exports.resolveAntigravityGlobalDir = resolveAntigravityGlobalDir;
 exports.detectAntigravityDirAmbiguity = detectAntigravityDirAmbiguity;
 exports.resolveKimiGlobalDir = resolveKimiGlobalDir;
+exports.resolveKimiHooksTomlDir = resolveKimiHooksTomlDir;
 exports.getGlobalConfigDir = getGlobalConfigDir;
 exports.resolveSkillsBaseFromDescriptor = resolveSkillsBaseFromDescriptor;
 exports.getGlobalSkillsBase = getGlobalSkillsBase;
@@ -255,6 +256,27 @@ function resolveKimiGlobalDir(opts = {}) {
         probeExists: 'skills',
     }, { env, home, existsSync: existsSyncFn });
 }
+/**
+ * Resolve the directory holding Kimi CLI's OWN native config.toml (the file
+ * Kimi itself reads for providers/models/hooks/etc — see
+ * moonshotai.github.io/kimi-cli/en/configuration/data-locations.html and
+ * .../reference/kimi-command.html). Default `~/.kimi`, overridden by
+ * `KIMI_SHARE_DIR` per Kimi's own upstream env-var (NOT `KIMI_CONFIG_DIR`,
+ * which is a GSD-installer write-location override for the unrelated generic
+ * Agent-Skills root resolved by resolveKimiGlobalDir above).
+ *
+ * This is deliberately a SEPARATE directory from GSD's kimi configHome
+ * (~/.config/agents): Kimi's own docs confirm the Agent-Skills search path is
+ * independent of KIMI_SHARE_DIR ("This variable does not affect Agent Skills
+ * search paths, which are handled separately"). #2095 Upgrade 1 writes GSD's
+ * native [[hooks]] entries into `<this dir>/config.toml`, never into the
+ * skills configDir.
+ */
+function resolveKimiHooksTomlDir(opts = {}) {
+    const env = opts.env ?? process.env;
+    const home = opts.home ?? node_os_1.default.homedir();
+    return resolveConfigHomeFromDescriptor({ kind: 'dot-home', name: '.kimi', env: ['KIMI_SHARE_DIR'] }, { env, home });
+}
 /**
  * Return the global config base directory for the given runtime.
  * Respects the same env-var overrides as bin/install.js getGlobalDir().
@@ -296,6 +318,14 @@ function getGlobalSkillsBase(runtime) {
     const runtimeEntry = getRegistry().runtimes[runtime];
     const descriptor = runtimeEntry?.runtime;
     const globalSkillsKind = descriptor?.artifactLayout?.global?.find((entry) => entry.kind === 'skills');
+    // ADR-1239 upgrade 3 (#2088): honor a skills-kind `home` override (e.g. Codex
+    // → $HOME/.agents/skills, independent of $CODEX_HOME) so the reported skills
+    // root matches where the installer actually writes (the artifact layout /
+    // _resolveSkillsRootDir). Without this, `--skills-root` and the sync-skills
+    // workflow would look under configHome/skills while skills live under ~/.agents.
+    if (globalSkillsKind?.home && globalSkillsKind?.destSubpath) {
+        return node_path_1.default.join(node_os_1.default.homedir(), globalSkillsKind.home, globalSkillsKind.destSubpath);
+    }
     if (descriptor?.configHome && globalSkillsKind?.destSubpath) {
         return resolveSkillsBaseFromDescriptor(descriptor.configHome, { env: process.env, home: node_os_1.default.homedir(), existsSync: node_fs_1.default.existsSync }, globalSkillsKind.destSubpath);
     }