@opengsd/gsd-core 1.5.0-rc.5 → 1.5.0

package/hooks/dist/gsd-worktree-path-guard.js

@@ -71,6 +71,17 @@ process.stdin.on('end', () => {
       process.exit(0); // main repo, submodule, or separate-git-dir — no-op
     }
 
+    // #1342: Only enforce inside a GSD-managed isolated executor worktree. Those
+    // are always on a `worktree-agent-*` branch (the positive allow-list enforced
+    // by worktree-branch-check.md, #2924). A manually-created linked worktree (plain
+    // non-GSD work, e.g. Claude Code plan-mode) is on the user's own branch, so the
+    // guard must be a no-op there. Detached HEAD / error → not GSD-managed → no-op.
+    const branchResult = git(['symbolic-ref', '--short', 'HEAD'], cwd);
+    const branch = branchResult.status === 0 && branchResult.stdout ? branchResult.stdout.trim() : '';
+    if (!/^worktree-agent-[A-Za-z0-9._/-]+$/.test(branch)) {
+      process.exit(0); // not a GSD-managed executor worktree — no-op
+    }
+
     // Get the raw --show-toplevel output for the worktree (cwd).
     // We keep it raw (not path.resolve'd) to compare directly with the
     // file's toplevel — same git binary, same format, no normalization needed.
@@ -110,15 +121,9 @@ process.stdin.on('end', () => {
 
     if (!checkDir) {
       // Walked to root without finding any directory — path is synthetic.
-      // Block conservatively.
-      const output = {
-        decision: 'block',
-        reason:
-          `Worktree path guard: '${filePath}' has no existing ancestor directory — ` +
-          `cannot verify it is inside the worktree '${wtTopRaw}'. Use a relative path instead.`,
-      };
-      process.stdout.write(JSON.stringify(output));
-      process.exit(2);
+      // A path with no existing ancestor is not the #260 main-repo vector;
+      // #260 is caught by the different-git-root branch below. Fail open. (#1342)
+      process.exit(0);
     }
 
     // Ask git for the toplevel of the file's location.
@@ -130,15 +135,26 @@ process.stdin.on('end', () => {
     const fileTopResult = git(['rev-parse', '--show-toplevel'], checkDir);
 
     if (fileTopResult.status !== 0 || !fileTopResult.stdout) {
-      // checkDir is not inside any git repo → cannot be inside the worktree.
-      const output = {
-        decision: 'block',
-        reason:
-          `Worktree path guard: '${filePath}' is not inside any git repository — ` +
-          `it cannot be inside the worktree at '${wtTopRaw}'. Use a relative path instead.`,
-      };
-      process.stdout.write(JSON.stringify(output));
-      process.exit(2);
+      // The target's location is not a git work tree. Two sub-cases:
+      //  - Inside a .git directory (e.g. /main-repo/.git/config or .git/hooks/*)
+      //    → an absolute write into a repository's internals; still a #260-class
+      //    escape (and dangerous) → BLOCK.
+      //  - Truly outside all git repositories (e.g. ~/.claude/plans/) → not the
+      //    main-repo vector → fail open. (#1342)
+      const insideGitDir = git(['rev-parse', '--is-inside-git-dir'], checkDir);
+      if (insideGitDir.status === 0 && insideGitDir.stdout && insideGitDir.stdout.trim() === 'true') {
+        const output = {
+          decision: 'block',
+          reason:
+            `Worktree path guard: '${filePath}' is inside a git internal (.git) directory, ` +
+            `not the active worktree at '${wtTopRaw}'. Writing to repository internals via an ` +
+            `absolute path is not permitted from an isolated executor worktree. Use a relative path.`,
+        };
+        process.stdout.write(JSON.stringify(output));
+        process.exit(2);
+      }
+      // Outside all git repositories — fail open (#1342).
+      process.exit(0);
     }
 
     const fileTopRaw = fileTopResult.stdout.trim();

package/hooks/gsd-worktree-path-guard.js

@@ -71,6 +71,17 @@ process.stdin.on('end', () => {
       process.exit(0); // main repo, submodule, or separate-git-dir — no-op
     }
 
+    // #1342: Only enforce inside a GSD-managed isolated executor worktree. Those
+    // are always on a `worktree-agent-*` branch (the positive allow-list enforced
+    // by worktree-branch-check.md, #2924). A manually-created linked worktree (plain
+    // non-GSD work, e.g. Claude Code plan-mode) is on the user's own branch, so the
+    // guard must be a no-op there. Detached HEAD / error → not GSD-managed → no-op.
+    const branchResult = git(['symbolic-ref', '--short', 'HEAD'], cwd);
+    const branch = branchResult.status === 0 && branchResult.stdout ? branchResult.stdout.trim() : '';
+    if (!/^worktree-agent-[A-Za-z0-9._/-]+$/.test(branch)) {
+      process.exit(0); // not a GSD-managed executor worktree — no-op
+    }
+
     // Get the raw --show-toplevel output for the worktree (cwd).
     // We keep it raw (not path.resolve'd) to compare directly with the
     // file's toplevel — same git binary, same format, no normalization needed.
@@ -110,15 +121,9 @@ process.stdin.on('end', () => {
 
     if (!checkDir) {
       // Walked to root without finding any directory — path is synthetic.
-      // Block conservatively.
-      const output = {
-        decision: 'block',
-        reason:
-          `Worktree path guard: '${filePath}' has no existing ancestor directory — ` +
-          `cannot verify it is inside the worktree '${wtTopRaw}'. Use a relative path instead.`,
-      };
-      process.stdout.write(JSON.stringify(output));
-      process.exit(2);
+      // A path with no existing ancestor is not the #260 main-repo vector;
+      // #260 is caught by the different-git-root branch below. Fail open. (#1342)
+      process.exit(0);
     }
 
     // Ask git for the toplevel of the file's location.
@@ -130,15 +135,26 @@ process.stdin.on('end', () => {
     const fileTopResult = git(['rev-parse', '--show-toplevel'], checkDir);
 
     if (fileTopResult.status !== 0 || !fileTopResult.stdout) {
-      // checkDir is not inside any git repo → cannot be inside the worktree.
-      const output = {
-        decision: 'block',
-        reason:
-          `Worktree path guard: '${filePath}' is not inside any git repository — ` +
-          `it cannot be inside the worktree at '${wtTopRaw}'. Use a relative path instead.`,
-      };
-      process.stdout.write(JSON.stringify(output));
-      process.exit(2);
+      // The target's location is not a git work tree. Two sub-cases:
+      //  - Inside a .git directory (e.g. /main-repo/.git/config or .git/hooks/*)
+      //    → an absolute write into a repository's internals; still a #260-class
+      //    escape (and dangerous) → BLOCK.
+      //  - Truly outside all git repositories (e.g. ~/.claude/plans/) → not the
+      //    main-repo vector → fail open. (#1342)
+      const insideGitDir = git(['rev-parse', '--is-inside-git-dir'], checkDir);
+      if (insideGitDir.status === 0 && insideGitDir.stdout && insideGitDir.stdout.trim() === 'true') {
+        const output = {
+          decision: 'block',
+          reason:
+            `Worktree path guard: '${filePath}' is inside a git internal (.git) directory, ` +
+            `not the active worktree at '${wtTopRaw}'. Writing to repository internals via an ` +
+            `absolute path is not permitted from an isolated executor worktree. Use a relative path.`,
+        };
+        process.stdout.write(JSON.stringify(output));
+        process.exit(2);
+      }
+      // Outside all git repositories — fail open (#1342).
+      process.exit(0);
     }
 
     const fileTopRaw = fileTopResult.stdout.trim();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@opengsd/gsd-core",
-  "version": "1.5.0-rc.5",
+  "version": "1.5.0",
   "description": "GSD Core is a meta-prompting, context engineering, and spec-driven development system for AI coding agents.",
   "bin": {
     "gsd-core": "bin/install.js",
@@ -62,7 +62,7 @@
     "eslint-plugin-no-only-tests": "^3.4.0",
     "fast-check": "^4.8.0",
     "globals": "^16.5.0",
-    "js-yaml": "^4.1.1",
+    "js-yaml": "^4.2.0",
     "typescript": "^6.0.3",
     "typescript-eslint": "^8.60.0"
   },

package/scripts/ci-prepare-test-scope.cjs

@@ -16,13 +16,37 @@ const path = require('path');
 
 const { ExitError, runMain } = require('./lib/cli-exit.cjs');
 
-const scope = process.env.TEST_SCOPE || '';
-const targeted = process.env.TARGETED_TESTS || '';
-const windows = process.env.WINDOWS_TESTS || '';
+// Suite sentinels understood by run-tests.cjs (scripts/run-tests.cjs SUITES).
+// A sentinel resolves to its live file set at run time, so — unlike an explicit
+// filename — it can never reference a since-deleted test file.
+const SUITE_SENTINELS = ['all', 'unit', 'integration', 'install', 'security', 'slow'];
 
-const FALLBACK = 'tests/command-contract.test.cjs tests/commands.test.cjs tests/core.test.cjs tests/package-manifest.test.cjs';
+// Fast smoke set used when scope detection yields no targeted tests. Each entry
+// MUST resolve via run-tests.cjs: an existing repo-relative test file or a
+// SUITE_SENTINELS token. A stale filename here (a test deleted by a refactor)
+// is exactly what broke CI in #1329 — `tests/core.test.cjs`, deleted in #1291,
+// was still listed and crashed every scoped lane that hit this fallback. The
+// parity guard in tests/bug-641-files-from-suite-token.test.cjs fails the
+// moment an entry stops resolving; resolveSelection() filters at write time so
+// a stale entry degrades instead of crashing the lane.
+const FALLBACK = [
+  'tests/command-contract.test.cjs',
+  'tests/commands.test.cjs',
+  'tests/package-manifest.test.cjs',
+];
 
-function main() {
+// Last-resort selector when every FALLBACK entry has been deleted: the whole
+// unit suite, resolved live by run-tests.cjs (the #408/#641 sentinel path).
+const FALLBACK_SENTINEL = 'unit';
+
+// An entry is runnable if it is a suite sentinel or an existing file under root.
+function isResolvable(entry, root) {
+  return SUITE_SENTINELS.includes(entry) || fs.existsSync(path.join(root, entry));
+}
+
+// Resolve the scoped test selection for the lane. Pure (no I/O beyond the
+// existence probe under `root`) so it can be unit-tested directly.
+function resolveSelection({ scope, targeted, windows, root }) {
   let selected;
   if (scope === 'windows') {
     selected = windows;
@@ -32,20 +56,38 @@ function main() {
     throw new ExitError(1, `::error::Unknown test scope: ${scope}`);
   }
 
-  // Trim and fall back to default set if empty.
-  if (!selected.trim()) {
-    selected = FALLBACK;
+  // Detected list passes through verbatim: affected-tests-lib.cjs already filters
+  // deleted files, and the list may legitimately carry a suite sentinel.
+  const detected = (selected || '').split(/\s+/).filter(Boolean);
+  if (detected.length > 0) {
+    return detected;
   }
 
-  // Split on whitespace, filter blanks, join with newlines.
-  const lines = selected.split(/\s+/).filter(Boolean);
-  const content = lines.join('\n') + '\n';
+  // Empty detection → smoke fallback, existence-filtered so a stale entry can
+  // never crash the scoped lane (#1329). If nothing survives, use the unit
+  // sentinel, which run-tests.cjs always resolves.
+  const survivors = FALLBACK.filter((f) => isResolvable(f, root));
+  return survivors.length > 0 ? survivors : [FALLBACK_SENTINEL];
+}
 
-  const outPath = path.join(process.cwd(), '.ci-selected-tests.txt');
-  fs.writeFileSync(outPath, content, 'utf-8');
+function main() {
+  const root = process.cwd();
+  const lines = resolveSelection({
+    scope: process.env.TEST_SCOPE || '',
+    targeted: process.env.TARGETED_TESTS || '',
+    windows: process.env.WINDOWS_TESTS || '',
+    root,
+  });
+
+  const content = lines.join('\n') + '\n';
+  fs.writeFileSync(path.join(root, '.ci-selected-tests.txt'), content, 'utf-8');
 
   process.stdout.write('Scoped tests:\n');
   process.stdout.write(content);
 }
 
-runMain(main);
+if (require.main === module) {
+  runMain(main);
+}
+
+module.exports = { FALLBACK, FALLBACK_SENTINEL, SUITE_SENTINELS, resolveSelection, main };

package/scripts/diff-touches-shipped-paths.cjs

@@ -12,11 +12,10 @@
  *   - package.json (always included by `npm pack`, regardless of `files`)
  *   - every entry in package.json `files`, treated as either an exact
  *     file match or a directory prefix (matching `npm pack` semantics).
- *   - CI-gating test paths: `tests/<anything>` plus
- *     `sdk/src/<anything>/<name>.test.<ts|cjs|mjs|js>` and `.spec.` variants
- *     — these don't ship in the tarball, but they gate the hotfix-branch
- *     test job. A test fixture update that aligns with a cherry-picked
- *     production fix MUST be pickable or CI fails on the hotfix run.
+ *   - CI-gating test paths: `tests/<anything>` — these don't ship in the
+ *     tarball, but they gate the hotfix-branch test job. A test fixture
+ *     update that aligns with a cherry-picked production fix MUST be
+ *     pickable or CI fails on the hotfix run.
  *     #3621 — root cause of the v1.42.3 hotfix red CI.
  *
  * `package-lock.json` is intentionally NOT considered shipped — `npm pack`
@@ -65,12 +64,7 @@ function loadShipPrefixes(pkgPath) {
 // in hotfix.yml, this lets `test(####):` fixture-alignment commits be
 // cherry-picked alongside their production counterparts.
 function isCiGating(diffPath) {
-  if (diffPath.startsWith('tests/')) return true;
-  // SDK vitest specs live next to source. Production source ships via
-  // sdk/dist/ (already in package.json `files`); the test files are what's
-  // missing from that surface.
-  if (diffPath.startsWith('sdk/src/') && /\.(test|spec)\.(ts|cjs|mjs|js)$/.test(diffPath)) return true;
-  return false;
+  return diffPath.startsWith('tests/');
 }
 
 function isShipped(diffPath, shipPrefixes) {

package/scripts/run-tests.cjs

@@ -461,6 +461,7 @@ function main() {
   // them so the local runner matches CI; tests that need them set them explicitly.
   delete process.env.GSD_PROJECT;
   delete process.env.GSD_WORKSTREAM;
+  delete process.env.CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS;
 
   // Log selected files to stderr for CI / harness-test visibility.
   // node:test default reporter doesn't echo filenames, so this gives