@opengsd/gsd-core 1.3.0 → 1.3.1

package/gsd-core/bin/lib/installer-migrations.cjs

@@ -175,16 +175,46 @@ function migrationChecksum(migration) {
     };
     return `sha256:${sha256Text(JSON.stringify(serializable))}`;
 }
-function assertAppliedMigrationChecksums(applied, migrations) {
+// Rewrite the stored checksum of any already-applied entry whose id drifted, so the
+// drift is reconciled durably and not re-detected on every subsequent run (issue #670).
+// Returns the number of entries actually changed (so callers know whether a write is needed).
+function reconcileDriftedChecksums(appliedEntries, checksumDrift) {
+    if (!Array.isArray(checksumDrift) || checksumDrift.length === 0)
+        return 0;
+    const reconcile = new Map(checksumDrift.map((d) => [d.id, d.currentChecksum]));
+    let changed = 0;
+    for (let i = 0; i < appliedEntries.length; i++) {
+        const existing = appliedEntries[i];
+        if (existing && typeof existing.id === 'string' && reconcile.has(existing.id)) {
+            const next = reconcile.get(existing.id);
+            if (existing.checksum !== next) {
+                appliedEntries[i] = { ...existing, checksum: next };
+                changed += 1;
+            }
+        }
+    }
+    return changed;
+}
+function collectAppliedChecksumDrift(applied, migrations) {
+    const drift = [];
     for (const migration of migrations) {
         const entry = applied.get(migration.id);
         if (!entry || !entry.checksum)
             continue;
-        const checksum = migrationChecksum(migration);
-        if (entry.checksum !== checksum) {
-            throw new Error(`applied migration checksum changed for ${migration.id}; create a new fix-forward migration id`);
+        const currentChecksum = migrationChecksum(migration);
+        if (entry.checksum !== currentChecksum) {
+            // An already-applied migration is never re-run (it is filtered out of `pending`),
+            // so a checksum drift here is functionally inert. A prior release may have edited a
+            // shipped migration body (see issue #670). Surface it for reconciliation instead of
+            // hard-aborting the user's upgrade.
+            drift.push({
+                id: migration.id,
+                storedChecksum: entry.checksum,
+                currentChecksum,
+            });
         }
     }
+    return drift;
 }
 function migrationMatchesContext(migration, { runtime, scope }) {
     if (Array.isArray(migration.runtimes) && migration.runtimes.length > 0) {
@@ -387,7 +417,7 @@ function planInstallerMigrations({ configDir, runtime = null, scope = null, migr
     const validatedMigrations = migrations.map((migration) => (0, installer_migration_authoring_cjs_1.validateInstallerMigrationRecord)(migration));
     const scopedMigrations = validatedMigrations.filter((migration) => migrationMatchesContext(migration, { runtime, scope }));
     const applied = appliedMigrationEntries(state);
-    assertAppliedMigrationChecksums(applied, scopedMigrations);
+    const checksumDrift = collectAppliedChecksumDrift(applied, scopedMigrations);
     const pending = scopedMigrations.filter((migration) => !applied.has(migration.id));
     const actions = [];
     const blocked = [];
@@ -474,6 +504,7 @@ function planInstallerMigrations({ configDir, runtime = null, scope = null, migr
         pendingMigrations: pending,
         actions,
         blocked,
+        checksumDrift,
     };
 }
 function uniqueActionMigrationIds(actions) {
@@ -630,6 +661,7 @@ function applyInstallerMigrationPlan({ configDir, plan, now = () => new Date().t
         const state = readInstallState(configDir);
         const applied = appliedMigrationIds(state);
         const nextApplied = [...state.appliedMigrations];
+        reconcileDriftedChecksums(nextApplied, plan.checksumDrift);
         const actionsByMigrationId = new Map();
         for (const action of plan.actions) {
             if (action.migrationId && !actionsByMigrationId.has(action.migrationId)) {
@@ -684,30 +716,36 @@ function applyInstallerMigrationPlan({ configDir, plan, now = () => new Date().t
     }
 }
 function markPendingMigrationsApplied({ configDir, plan, now = () => new Date().toISOString(), }) {
-    if (!plan || !Array.isArray(plan.pendingMigrationIds) || plan.pendingMigrationIds.length === 0) {
+    if (!plan)
+        return [];
+    const hasPending = Array.isArray(plan.pendingMigrationIds) && plan.pendingMigrationIds.length > 0;
+    const hasDrift = Array.isArray(plan.checksumDrift) && plan.checksumDrift.length > 0;
+    if (!hasPending && !hasDrift)
         return [];
-    }
     const appliedAt = now();
     const state = readInstallState(configDir);
     const applied = appliedMigrationIds(state);
-    const checksumsByMigrationId = new Map();
-    for (const migration of plan.pendingMigrations || []) {
-        checksumsByMigrationId.set(migration.id, migrationChecksum(migration));
-    }
     const nextApplied = [...state.appliedMigrations];
+    const reconciledCount = reconcileDriftedChecksums(nextApplied, plan.checksumDrift);
     const newlyApplied = [];
-    for (const id of plan.pendingMigrationIds) {
-        if (applied.has(id))
-            continue;
-        nextApplied.push({
-            id,
-            appliedAt,
-            journal: null,
-            checksum: checksumsByMigrationId.get(id) || null,
-        });
-        newlyApplied.push(id);
+    if (hasPending) {
+        const checksumsByMigrationId = new Map();
+        for (const migration of plan.pendingMigrations || []) {
+            checksumsByMigrationId.set(migration.id, migrationChecksum(migration));
+        }
+        for (const id of plan.pendingMigrationIds) {
+            if (applied.has(id))
+                continue;
+            nextApplied.push({
+                id,
+                appliedAt,
+                journal: null,
+                checksum: checksumsByMigrationId.get(id) || null,
+            });
+            newlyApplied.push(id);
+        }
     }
-    if (newlyApplied.length > 0) {
+    if (newlyApplied.length > 0 || reconciledCount > 0) {
         writeInstallState(configDir, {
             schemaVersion: 1,
             appliedMigrations: nextApplied,
@@ -776,6 +814,7 @@ module.exports = {
     applyInstallerMigrationPlan,
     classifyArtifact,
     discoverInstallerMigrations,
+    migrationChecksum,
     planInstallerMigrations,
     readInstallManifest,
     readInstallState,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@opengsd/gsd-core",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "description": "GSD Core is a meta-prompting, context engineering, and spec-driven development system for AI coding agents.",
   "bin": {
     "gsd-core": "bin/install.js",