@opengsd/gsd-core 1.20.0 → 1.21.0

package/gsd-core/bin/lib/stale-bake-guard.cjs

@@ -25,6 +25,7 @@ const capabilityRegistry = require('./capability-registry.cjs');
 const { hostBehaviorsFor } = require('./runtime-name-policy.cjs');
 const { resolveConfigHomeFromDescriptor } = require('./runtime-homes.cjs');
 const { resolveActiveRuntime } = require('./runtime-slash.cjs');
+const { readConfigFileBounded } = require('./config-file-read.cjs');
 
 /**
  * Runtimes whose agent config is static frontmatter/TOML baked at install time,
@@ -226,7 +227,9 @@ function _readRuntimeConfig(cwd, { fsStatSync = fs.statSync } = {}) {
     const candidate = path.join(probe, '.planning', 'config.json');
     try {
       fsStatSync(candidate);
-      const raw = fs.readFileSync(candidate, 'utf8');
+      // Bounded read (#5759): a FIFO/device/oversized config throws and is walked past like a
+      // missing one; null (raced away after the stat) makes JSON.parse('') throw into the same catch.
+      const raw = readConfigFileBounded(candidate) ?? '';
       const parsed = JSON.parse(raw);
       if (parsed && typeof parsed === 'object') return parsed;
       return {};

package/gsd-core/bin/lib/state-transition.cjs

@@ -31,6 +31,8 @@ exports.applyPreserveWhenUnchanged = applyPreserveWhenUnchanged;
 exports.applyStatePreservation = applyStatePreservation;
 exports.transitionCore = transitionCore;
 exports.sliceCurrentPositionSection = sliceCurrentPositionSection;
+exports.readPlanPosition = readPlanPosition;
+exports.readRecordedPlanTotal = readRecordedPlanTotal;
 exports.isStatePastPhase = isStatePastPhase;
 // eslint-disable-next-line @typescript-eslint/no-require-imports
 const frontmatter = require("./frontmatter.cjs");
@@ -42,7 +44,7 @@ const roadmap_progress_cjs_1 = require("./roadmap-progress.cjs");
 const pattern_cjs_1 = require("./pattern.cjs");
 // eslint-disable-next-line @typescript-eslint/no-require-imports -- phase-id.cjs is an export= CommonJS module
 const phaseIdMod = require("./phase-id.cjs");
-const { comparePhaseNum } = phaseIdMod;
+const { comparePhaseNum, parsePhaseFromProse } = phaseIdMod;
 // #4129: the completion-ratio kernel for the resync-arm ratchet's percent
 // (planning-scope's SCOPE — state-document's own dependency, no cycle here:
 // state-document never imports this module).
@@ -1261,6 +1263,94 @@ function planNumberFrom(digits) {
     const n = Number(digits);
     return Number.isSafeInteger(n) ? n : null;
 }
+/**
+ * The one plan-position parse: legacy pair first, then the hybrid, then
+ * compound. `advancePlanCore` and `readPlanPosition` both consume it, so the
+ * precedence is decided in exactly one place (#5786).
+ *
+ * These branches decide ONE thing: which numbers the position is read from.
+ * They deliberately do not record which FIELD supplied them, because the
+ * advance write path writes every spelling back from its own raw text (#3791
+ * review round 6, B1/M1).
+ *
+ * Every branch reads its numbers out of an ANCHORED match's capture groups.
+ * Nothing here calls parseInt on a raw field value, so a value the grammar
+ * does not fully describe cannot half-parse into a plausible number.
+ */
+function parsePlanFields(content) {
+    const legacyPlan = (0, state_document_cjs_1.stateExtractField)(content, 'Current Plan');
+    const legacyTotal = (0, state_document_cjs_1.stateExtractField)(content, 'Total Plans in Phase');
+    const planField = (0, state_document_cjs_1.stateExtractField)(content, 'Plan');
+    const legacyNMatch = legacyPlan ? PLAN_SHAPE_N.exec(legacyPlan) : null;
+    const legacyNofMMatch = legacyPlan ? PLAN_SHAPE_N_OF_M.exec(legacyPlan) : null;
+    const totalNMatch = legacyTotal ? PLAN_SHAPE_N.exec(legacyTotal) : null;
+    const planNofMMatch = planField ? PLAN_SHAPE_N_OF_M.exec(planField) : null;
+    const planNMatch = planField ? PLAN_SHAPE_N.exec(planField) : null;
+    let current = null;
+    let total = null;
+    if (legacyPlan && legacyTotal && (legacyNMatch || legacyNofMMatch) && totalNMatch) {
+        // Legacy pair wins whenever both fields are present and both are readable,
+        // even if the Current Plan value also carries an "of M" — the explicit
+        // sibling field is the stated intent, so it supplies the total.
+        current = planNumberFrom((legacyNMatch ?? legacyNofMMatch)[1]);
+        total = planNumberFrom(totalNMatch[1]);
+    }
+    else if (legacyNofMMatch) {
+        // Hybrid: legacy field name, compound value, no readable Total Plans
+        // sibling. Written by hand (and by agents) often enough to be worth
+        // reading — #3784.
+        current = planNumberFrom(legacyNofMMatch[1]);
+        total = planNumberFrom(legacyNofMMatch[2]);
+    }
+    else if (planNofMMatch) {
+        current = planNumberFrom(planNofMMatch[1]);
+        total = planNumberFrom(planNofMMatch[2]);
+    }
+    // No branch for a bare `Plan: N` paired with a `Total Plans in Phase: M`
+    // sibling and no `Current Plan` at all (#3791 review round 6, M2). A revision
+    // of this PR accepted it; base did not (its `else if (planField)` arm had no
+    // `of M` match and errored via NaN), and it is out of #3784's scope, which is
+    // the hybrid `Current Plan: N of M`. It cannot be given the schema-row +
+    // forcing-test coupling the other shapes have, either: `Plan` is body-only,
+    // `buildStateFrontmatter` never reads it into frontmatter, so there is no
+    // `current_*` key to hang a row on. An accepted shape with no schema row and
+    // no forcing test is exactly the drift this diff is otherwise built to
+    // prevent, so the shape is refused and named in the error instead.
+    return { legacyPlan, planField, legacyNMatch, legacyNofMMatch, planNofMMatch, planNMatch, current, total };
+}
+/**
+ * Read the recorded plan position out of a STATE.md document through the one
+ * plan-position grammar, or `null` when no readable position is recorded
+ * (`Plan: 1 of ?`, `Total Plans in Phase: TBD`, no field at all). #5786.
+ */
+function readPlanPosition(content) {
+    const { current, total } = parsePlanFields(content);
+    return current === null || total === null ? null : { current, total };
+}
+/**
+ * The plan total a STATE.md document records, for the `init --validate`
+ * plan-count check: a readable `Total Plans in Phase` first, else the
+ * of-M total read straight from the plan fields: `Current Plan`'s of-M is
+ * tried first, then `Plan`'s, and convertibility is checked per field (an
+ * unconvertible `Current Plan` M falls through to `Plan`'s M), unlike
+ * `parsePlanFields`, which commits to the first matching field. The fallback
+ * does not go through the legacy pair, so an unconvertible `Total Plans in
+ * Phase` beside `Current Plan: N of M` still yields M. `null` when neither
+ * yields a convertible M. #5786.
+ */
+function readRecordedPlanTotal(content) {
+    // An explicit `Total Plans in Phase` wins over an `of M` in either plan field.
+    const raw = (0, state_document_cjs_1.stateExtractField)(content, 'Total Plans in Phase');
+    const match = raw ? PLAN_SHAPE_N.exec(raw) : null;
+    const t = match ? planNumberFrom(match[1]) : null;
+    if (t !== null)
+        return t;
+    const { legacyNofMMatch, planNofMMatch } = parsePlanFields(content);
+    const fromCurrentPlan = legacyNofMMatch ? planNumberFrom(legacyNofMMatch[2]) : null;
+    if (fromCurrentPlan !== null)
+        return fromCurrentPlan;
+    return planNofMMatch ? planNumberFrom(planNofMMatch[2]) : null;
+}
 /**
  * Advance the leading integer of a written plan value, preserving everything
  * the author wrote around it: the zero-padding width ("04" -> "05") and any
@@ -1483,47 +1573,7 @@ function advancePlanCore(content, deps) {
     // `planSourceField`/`planRawValue` pair here and then wrote the OTHER
     // spelling from this one's numbers, which is precisely how a field ended up
     // holding a value nothing had derived for it.
-    const legacyPlan = (0, state_document_cjs_1.stateExtractField)(content, 'Current Plan');
-    const legacyTotal = (0, state_document_cjs_1.stateExtractField)(content, 'Total Plans in Phase');
-    const planField = (0, state_document_cjs_1.stateExtractField)(content, 'Plan');
-    // Every branch below reads its numbers out of an ANCHORED match's capture
-    // groups. Nothing here calls parseInt on a raw field value, so a value the
-    // grammar does not fully describe cannot half-parse into a plausible number.
-    const legacyNMatch = legacyPlan ? PLAN_SHAPE_N.exec(legacyPlan) : null;
-    const legacyNofMMatch = legacyPlan ? PLAN_SHAPE_N_OF_M.exec(legacyPlan) : null;
-    const totalNMatch = legacyTotal ? PLAN_SHAPE_N.exec(legacyTotal) : null;
-    const planNofMMatch = planField ? PLAN_SHAPE_N_OF_M.exec(planField) : null;
-    const planNMatch = planField ? PLAN_SHAPE_N.exec(planField) : null;
-    let parsedCurrent = null;
-    let parsedTotal = null;
-    if (legacyPlan && legacyTotal && (legacyNMatch || legacyNofMMatch) && totalNMatch) {
-        // Legacy pair wins whenever both fields are present and both are readable,
-        // even if the Current Plan value also carries an "of M" — the explicit
-        // sibling field is the stated intent, so it supplies the total.
-        parsedCurrent = planNumberFrom((legacyNMatch ?? legacyNofMMatch)[1]);
-        parsedTotal = planNumberFrom(totalNMatch[1]);
-    }
-    else if (legacyNofMMatch) {
-        // Hybrid: legacy field name, compound value, no readable Total Plans
-        // sibling. Written by hand (and by agents) often enough to be worth
-        // reading — #3784.
-        parsedCurrent = planNumberFrom(legacyNofMMatch[1]);
-        parsedTotal = planNumberFrom(legacyNofMMatch[2]);
-    }
-    else if (planNofMMatch) {
-        parsedCurrent = planNumberFrom(planNofMMatch[1]);
-        parsedTotal = planNumberFrom(planNofMMatch[2]);
-    }
-    // No branch for a bare `Plan: N` paired with a `Total Plans in Phase: M`
-    // sibling and no `Current Plan` at all (#3791 review round 6, M2). A revision
-    // of this PR accepted it; base did not (its `else if (planField)` arm had no
-    // `of M` match and errored via NaN), and it is out of #3784's scope, which is
-    // the hybrid `Current Plan: N of M`. It cannot be given the schema-row +
-    // forcing-test coupling the other shapes have, either: `Plan` is body-only,
-    // `buildStateFrontmatter` never reads it into frontmatter, so there is no
-    // `current_*` key to hang a row on. An accepted shape with no schema row and
-    // no forcing test is exactly the drift this diff is otherwise built to
-    // prevent, so the shape is refused and named in the error instead.
+    const { legacyPlan, planField, legacyNMatch, legacyNofMMatch, planNofMMatch, planNMatch, current: parsedCurrent, total: parsedTotal, } = parsePlanFields(content);
     if (parsedCurrent === null || parsedTotal === null) {
         return { content: reassemble(body), updated: [], data: { error: true } };
     }
@@ -1724,8 +1774,10 @@ function nextPhaseWording(disk) {
  * position; the caller combines this with "the phase is already complete in
  * ROADMAP.md" so a first-time out-of-order completion (#2028) still
  * transitions. An unparseable or absent current phase is "not past".
+ * #5676: under `milestone-prefixed` the id is the whole `M-NN` (`3-02`, not `3`); that read goes
+ * through `parsePhaseFromProse` (the #5626 grammar owner), so the two cannot drift.
  */
-function isStatePastPhase(content, phaseNum, sourcePath) {
+function isStatePastPhase(content, phaseNum, sourcePath, convention) {
     const fm = extractFrontmatter(content, sourcePath);
     const fromFm = fm['current_phase'];
     let raw = typeof fromFm === 'string' || typeof fromFm === 'number' ? String(fromFm) : null;
@@ -1734,10 +1786,15 @@ function isStatePastPhase(content, phaseNum, sourcePath) {
         raw = (0, state_document_cjs_1.stateExtractField)(body, 'Current Phase') || (0, state_document_cjs_1.stateExtractField)(body, 'Phase') || null;
     }
     // `Phase 4` / `phase 4 of 9` name phase 4 as surely as `4 of 9` does.
-    const m = raw === null ? null : /^\s*(?:phase\s+)?(\d+(?:\.\d+)*)/i.exec(raw);
-    if (!m)
+    let id = null;
+    if (raw !== null) {
+        id = convention === 'milestone-prefixed'
+            ? parsePhaseFromProse(raw, 'milestone-prefixed').phase
+            : (/^\s*(?:phase\s+)?(\d+(?:\.\d+)*)/i.exec(raw)?.[1] ?? null);
+    }
+    if (id === null)
         return false;
-    return comparePhaseNum(m[1], String(phaseNum)) > 0;
+    return comparePhaseNum(id, String(phaseNum)) > 0;
 }
 /**
  * Apply a `completePhase` transition to STATE.md content.