@opengsd/gsd-core 1.18.0 → 1.20.0

package/gsd-core/bin/lib/health-diagnostic-rules/phase-structure.cjs

@@ -42,7 +42,7 @@
  */
 // eslint-disable-next-line @typescript-eslint/no-require-imports
 const healthDiagnosticMod = require("../health-diagnostic-types.cjs");
-const { SEVERITY, adviseRemedy } = healthDiagnosticMod;
+const { SEVERITY, REMEDY_ACTION, REMEDY_RISK, adviseRemedy } = healthDiagnosticMod;
 // eslint-disable-next-line @typescript-eslint/no-require-imports
 const validateMod = require("../validate.cjs");
 // #612: `isPhaseDirName` is the convention-SELECTED shape test wrapping
@@ -54,14 +54,20 @@ const validateMod = require("../validate.cjs");
 const { isPhaseDirName } = validateMod;
 // eslint-disable-next-line @typescript-eslint/no-require-imports
 const phaseIdMod = require("../phase-id.cjs");
-const { extractPhaseToken, normalizePhaseName, comparePhaseNum } = phaseIdMod;
+const { extractPhaseToken, normalizePhaseName, phaseKeyFromDir, comparePhaseNum } = phaseIdMod;
 // #5060: the Phase Status Module owns the status-label ladder.
 const phase_status_cjs_1 = require("../phase-status.cjs");
+// #5291: W030 asks whether a raw report status has a known repair. The lookup is
+// a pure read of a frozen table, so `check` stays free of ambient I/O (§8.1 rule 1).
+const verification_cjs_1 = require("../verification.cjs");
 // ─── W005 — phase directory doesn't follow NN-name format (verify.cts:1893-1902) ─
 function checkW005(snapshot) {
     const diagnostics = [];
+    const context = snapshot.directoryContext ?? phaseIdMod.phaseDirectoryContext(snapshot.config.value ?? {}, '', snapshot.roadmapDeclaredPhases.value.map(({ phaseId }) => phaseId));
     for (const name of snapshot.phaseDirs.value) {
-        if (!isPhaseDirName(name, snapshot.phaseIdConvention)) {
+        const custom = snapshot.phaseIdConvention === 'bracket' ? null : phaseIdMod.customPhaseQuery(name, context);
+        const owner = custom && phaseIdMod.customDirectoryOwner(name, custom);
+        if (!owner && !isPhaseDirName(name, snapshot.phaseIdConvention)) {
             diagnostics.push({
                 code: 'W005',
                 severity: SEVERITY.WARNING,
@@ -74,17 +80,18 @@ function checkW005(snapshot) {
 }
 // ─── W023 — phase directories collide on normalized key (verify.cts:1904-1950) ─
 //
-// Groups `snapshot.phaseDirs.value` by `normalizePhaseName(extractPhaseToken(name))`
-// — the exact same two owners (`phase-id.cjs`) the original `verify.cts:1917-1918`
-// call site uses, relocated verbatim rather than reimplemented. Sorted with
-// `comparePhaseNum` + a `localeCompare` tiebreak, mirroring
+// Groups directories by the canonical identity owner, preserving recorded
+// custom IDs instead of collapsing their shared token prefixes. Sorted with
+// contextual `comparePhaseNum` + a `localeCompare` tiebreak, mirroring
 // `verify.cts:1930-1932`'s deterministic-output rationale. See the file-level
 // comment for the disclosed "described" fidelity reduction.
 function checkW023(snapshot) {
+    const context = snapshot.directoryContext;
     const groups = new Map();
     for (const name of snapshot.phaseDirs.value) {
-        const token = extractPhaseToken(name);
-        const key = normalizePhaseName(token);
+        const key = context?.phaseNaming === 'custom'
+            ? phaseKeyFromDir(name, undefined, context)
+            : normalizePhaseName(extractPhaseToken(name));
         const list = groups.get(key);
         if (list)
             list.push(name);
@@ -98,7 +105,7 @@ function checkW023(snapshot) {
             continue;
         const described = dirs
             .slice()
-            .sort((a, b) => comparePhaseNum(a, b) || String(a).localeCompare(String(b)))
+            .sort((a, b) => comparePhaseNum(a, b, context) || String(a).localeCompare(String(b)))
             .map((d) => {
             const phase = phaseByDir.get(d);
             const plans = phase ? phase.planCount : 0;
@@ -174,11 +181,21 @@ function checkW030(snapshot) {
         const invalid = phase.verificationStatusError;
         if (!invalid)
             continue;
+        // #5291: a KNOWN legacy status is repairable (rewritten to its closed-set
+        // equivalent, original kept in `legacy_status`); any other value has no
+        // mapping and keeps the advise-only remedy — it stays refused.
+        const target = (0, verification_cjs_1.legacyStatusRepairTarget)(invalid.rawStatus);
         diagnostics.push({
             code: 'W030',
             severity: SEVERITY.WARNING,
             message: `Phase ${phase.dir}: ${invalid.message}`,
-            remedy: adviseRemedy('Set the report frontmatter `status` to one of passed | gaps_found | human_needed, or delete the report and re-run the phase verification'),
+            remedy: target === null
+                ? adviseRemedy('Set the report frontmatter `status` to one of passed | gaps_found | human_needed, or delete the report and re-run the phase verification')
+                : {
+                    action: REMEDY_ACTION.REPAIR_VERIFICATION_STATUS,
+                    risk: REMEDY_RISK.NONE,
+                    args: { file: invalid.file, from: invalid.rawStatus, to: target },
+                },
         });
     }
     return diagnostics;
@@ -217,7 +234,9 @@ const RULES = [
         code: 'W030',
         severity: SEVERITY.WARNING,
         description: 'Phase verification report status is outside the closed set',
-        repairable: false,
+        // #5291: repairable per finding — a KNOWN legacy status (`pass_with_caveats`)
+        // is rewritten by `--repair`; any other value stays advise-only.
+        repairable: true,
         check: checkW030,
     },
 ];

package/gsd-core/bin/lib/health-diagnostic-rules/roadmap-disk-consistency.cjs

@@ -104,7 +104,7 @@ const planningScopeMod = require("../planning-scope.cjs");
 const { SCOPE } = planningScopeMod;
 // eslint-disable-next-line @typescript-eslint/no-require-imports
 const phaseIdMod = require("../phase-id.cjs");
-const { matchPhaseDirs, normalizePhaseName, extractPhaseToken, isSentinelPhaseId, isSentinelPhaseDir } = phaseIdMod;
+const { matchPhaseDirs, phaseLookupQuery, extractPhaseToken, isSentinelPhaseId, isSentinelPhaseDir } = phaseIdMod;
 // eslint-disable-next-line @typescript-eslint/no-require-imports
 const validateMod = require("../validate.cjs");
 const { phaseVariants } = validateMod;
@@ -116,7 +116,7 @@ const { phaseVariants } = validateMod;
  * does the roadmap claim, for W007) call this — one matcher, reused, per the
  * file-level comment.
  */
-function dirsForPhase(dirs, phaseId, convention) {
+function dirsForPhase(dirs, phaseId, convention, directoryContext) {
     // #612: `convention` reaches BOTH operands of this pairing or it pairs
     // nothing. The phases come from a bracket-aware heading scan and the dirs
     // from a bracket-aware disk scan, so a convention-less selector here leaves
@@ -125,7 +125,7 @@ function dirsForPhase(dirs, phaseId, convention) {
     // disk" AND every bracket directory reads as unclaimed. `matchPhaseDirs`
     // forwards it to its primary `phaseTokenMatches`; handed nothing it is
     // byte-identical, so no legacy repo's pairing changes.
-    const canonical = matchPhaseDirs(dirs, normalizePhaseName(phaseId), convention).matches;
+    const canonical = matchPhaseDirs(dirs, phaseLookupQuery(phaseId, directoryContext), convention, undefined, directoryContext).matches;
     if (canonical.length > 0)
         return canonical;
     // Bug 2 (#3309 W006/W007 migration cluster, found while fixing the
@@ -187,6 +187,7 @@ function checkW006(snapshot) {
         return [];
     const dirs = snapshot.allPhaseDirNames.value;
     const convention = snapshot.phaseIdConvention;
+    const directoryContext = snapshot.directoryContext ?? phaseIdMod.phaseDirectoryContext(snapshot.config.value ?? {}, '', snapshot.roadmapDeclaredPhases.value.map(({ phaseId }) => phaseId));
     const archivedTokens = new Set(snapshot.archivedPhaseTokens.value);
     // No separate scope guard: `roadmapSentinelPhaseTokens` and
     // `roadmapDeclaredPhases` are produced by ONE builder call
@@ -219,7 +220,7 @@ function checkW006(snapshot) {
         // not change its result.
         if (sentinelTokens.has(phaseId) || isSentinelPhaseId(phaseId))
             continue;
-        if (dirsForPhase(dirs, phaseId, convention).length > 0)
+        if (dirsForPhase(dirs, phaseId, convention, directoryContext).length > 0)
             continue;
         // Bug 1 (#3309 W006/W007 migration cluster): a phase whose ONLY
         // directory lives under a milestone archive
@@ -247,10 +248,10 @@ function checkW006(snapshot) {
 // ─── W007 — an on-disk phase directory has no matching ROADMAP entry ──────
 // (verify.cts:2086-2101)
 /** Every directory in `dirs` that ANY declared roadmap phase resolves to. */
-function computeClaimedDirs(dirs, declaredPhases, convention) {
+function computeClaimedDirs(dirs, declaredPhases, convention, directoryContext) {
     const claimed = new Set();
     for (const { phaseId } of declaredPhases) {
-        for (const dir of dirsForPhase(dirs, phaseId, convention))
+        for (const dir of dirsForPhase(dirs, phaseId, convention, directoryContext))
             claimed.add(dir);
     }
     return claimed;
@@ -261,7 +262,8 @@ function checkW007(snapshot) {
         return [];
     const dirs = snapshot.allPhaseDirNames.value;
     const convention = snapshot.phaseIdConvention;
-    const claimedDirs = computeClaimedDirs(dirs, snapshot.roadmapDeclaredPhases.value, convention);
+    const directoryContext = snapshot.directoryContext ?? phaseIdMod.phaseDirectoryContext(snapshot.config.value ?? {}, '', snapshot.roadmapDeclaredPhases.value.map(({ phaseId }) => phaseId));
+    const claimedDirs = computeClaimedDirs(dirs, snapshot.roadmapDeclaredPhases.value, convention, directoryContext);
     const diagnostics = [];
     for (const dirName of dirs) {
         // `extractPhaseToken` is the phase-id.cts owner `PHASE_TOKEN_FROM_DIR_RE`

package/gsd-core/bin/lib/health-diagnostic-rules/state-consistency.cjs

@@ -46,7 +46,7 @@ const healthDiagnosticMod = require("../health-diagnostic-types.cjs");
 const { SEVERITY, adviseRemedy } = healthDiagnosticMod;
 // eslint-disable-next-line @typescript-eslint/no-require-imports
 const phaseIdMod = require("../phase-id.cjs");
-const { getMilestoneFromPhaseId, matchPhaseDirs, normalizePhaseName, extractPhaseToken, PHASE_NUMBER_TOKEN_SOURCE } = phaseIdMod;
+const { getMilestoneFromPhaseId, matchPhaseDirs, phaseLookupQuery, extractPhaseToken, PHASE_NUMBER_TOKEN_SOURCE } = phaseIdMod;
 // eslint-disable-next-line @typescript-eslint/no-require-imports -- the single owner of the persisted status vocabulary
 const stateDocumentMod = require("../state-document.cjs");
 const { normalizeStateStatus } = stateDocumentMod;
@@ -332,8 +332,8 @@ const RULE_W026 = {
         // field's own doc comment on `PlanningSnapshot` for why
         // `roadmapDeclaredPhases`'s `milestone` attribution is the wrong fit).
         const unstarted = [];
+        const directoryContext = snapshot.directoryContext ?? phaseIdMod.phaseDirectoryContext(snapshot.config.value ?? {}, '', snapshot.currentMilestoneRoadmapPhaseIds.value);
         for (const phaseId of snapshot.currentMilestoneRoadmapPhaseIds.value) {
-            const normalized = normalizePhaseName(phaseId);
             // `allPhaseDirNames` — every directory under `phases/`, UNWINDOWED by
             // ROADMAP-declaration membership — mirrors the original's own
             // unwindowed `phaseDirNames2` (`verify.cts:2372-2382`, a direct
@@ -346,7 +346,7 @@ const RULE_W026 = {
             // moved the read onto the shared selector; the convention rides along,
             // since the selector's primary match IS the `phaseTokenMatches` call this
             // line used to make directly.
-            const hasDirectory = matchPhaseDirs(snapshot.allPhaseDirNames.value, normalized, snapshot.phaseIdConvention).matches.length > 0;
+            const hasDirectory = matchPhaseDirs(snapshot.allPhaseDirNames.value, phaseLookupQuery(phaseId, directoryContext), snapshot.phaseIdConvention, undefined, directoryContext).matches.length > 0;
             if (!hasDirectory)
                 unstarted.push(phaseId);
         }

package/gsd-core/bin/lib/health-diagnostic-types.cjs

@@ -38,6 +38,10 @@ const REMEDY_ACTION = Object.freeze({
     ADD_NYQUIST_KEY: 'addNyquistKey',
     ADD_AI_INTEGRATION_PHASE_KEY: 'addAiIntegrationPhaseKey',
     BACKFILL_MILESTONES: 'backfillMilestones',
+    // #5291: rewrite a KNOWN legacy verification `status` (W030) to its closed-set
+    // equivalent, keeping the original in `legacy_status`. Per-finding: only
+    // emitted when the raw value has a mapping; every other W030 stays ADVISE.
+    REPAIR_VERIFICATION_STATUS: 'repairVerificationStatus',
     // §8.3 rule 5 — every non-repairable finding's `fix` string becomes an
     // ADVISE payload; ADVISE never acts, only describes.
     ADVISE: 'advise',

package/gsd-core/bin/lib/health-diagnostic.cjs

@@ -118,6 +118,9 @@ const { getMilestoneInfo } = roadmapParserMod;
 const stateMod = require("./state.cjs");
 const { writeStateMd, assertVerificationReportsReadable } = stateMod;
 // eslint-disable-next-line @typescript-eslint/no-require-imports
+const verificationMod = require("./verification.cjs");
+const { repairLegacyVerificationStatus } = verificationMod;
+// eslint-disable-next-line @typescript-eslint/no-require-imports
 const frontmatter = require("./frontmatter.cjs");
 const { extractFrontmatter } = frontmatter;
 // eslint-disable-next-line @typescript-eslint/no-require-imports
@@ -252,9 +255,27 @@ function computeMissingMilestoneVersions(milestonesArchiveDir, milestonesPath) {
  * shape, collapsed to one seam here since every case now shares one
  * caller).
  */
-function runRepairAction(cwd, action, paths) {
+function runRepairAction(cwd, action, paths, args = {}) {
     const { rootBase, configPath, statePath, milestonesPath, milestonesArchiveDir } = paths;
     switch (action) {
+        case REMEDY_ACTION.REPAIR_VERIFICATION_STATUS: {
+            // #5291: the report path comes from the finding's own remedy args, not
+            // from user input; `repairLegacyVerificationStatus` re-verifies that it is
+            // a report contained in its phase directory before it writes a byte.
+            const file = typeof args['file'] === 'string' ? args['file'] : '';
+            if (file === '')
+                return { success: false, error: 'no report path on the finding' };
+            const repaired = repairLegacyVerificationStatus(file);
+            if (!repaired.ok)
+                return { success: false, error: repaired.reason };
+            return {
+                success: true,
+                path: node_path_1.default.relative(cwd, file).split(node_path_1.default.sep).join('/'),
+                detail: repaired.legacyStatusKept
+                    ? `status ${repaired.from} -> ${repaired.to}; the report's existing legacy_status was left as it was`
+                    : `status ${repaired.from} -> ${repaired.to}; original kept as legacy_status`,
+            };
+        }
         case REMEDY_ACTION.CREATE_CONFIG:
         case REMEDY_ACTION.RESET_CONFIG: {
             (0, shell_command_projection_cjs_1.platformWriteSync)(configPath, JSON.stringify(defaultConfigPayload(), null, 2));
@@ -390,6 +411,34 @@ function applyRepairs(cwd, diagnostics, repair, backfill) {
     const refused = [];
     const details = [];
     const paths = repairPaths(cwd);
+    // #5291: a legacy-status repair is the CURE for the refusal the pre-check
+    // below enforces, so it runs first (a report edit is its only write and it
+    // validates its own target); the pre-check then sees the repaired reports.
+    const statusRepairs = new Set();
+    if (repair) {
+        for (const diagnostic of diagnostics) {
+            const { remedy, code } = diagnostic;
+            if (remedy.action !== REMEDY_ACTION.REPAIR_VERIFICATION_STATUS || remedy.risk === REMEDY_RISK.DESTRUCTIVE)
+                continue;
+            statusRepairs.add(diagnostic);
+            try {
+                const outcome = runRepairAction(cwd, remedy.action, paths, remedy.args);
+                details.push({
+                    code,
+                    action: remedy.action,
+                    success: outcome.success,
+                    ...(outcome.path ? { path: outcome.path } : {}),
+                    ...(outcome.detail ? { detail: outcome.detail } : {}),
+                    ...(outcome.error ? { error: outcome.error } : {}),
+                });
+                if (outcome.success)
+                    applied.push(code);
+            }
+            catch (err) {
+                details.push({ code, action: remedy.action, success: false, error: err instanceof Error ? err.message : String(err) });
+            }
+        }
+    }
     // #5118 (no write before the error): a requested REGENERATE_STATE rewrites
     // STATE.md from every phase's report and throws on one whose `status` is
     // outside the closed set — but other repairs in the SAME run (config,
@@ -411,6 +460,8 @@ function applyRepairs(cwd, diagnostics, repair, backfill) {
         const { remedy, code } = diagnostic;
         if (remedy.action === REMEDY_ACTION.ADVISE)
             continue;
+        if (statusRepairs.has(diagnostic))
+            continue;
         const requested = remedy.action === REMEDY_ACTION.BACKFILL_MILESTONES ? repair || backfill : repair;
         if (!requested)
             continue;

package/gsd-core/bin/lib/host-integration.cjs

@@ -620,7 +620,7 @@ function hookEventSurfaceFor(hookEvents) {
 // event subset (imperative hosts' extension API). They are not the same thing.
 //
 // Values are documentation-sourced (ADR-1239 §research): OpenCode ~25 plugin
-// events (session/tool/file/permission); pi ~30 fine-grained extension events;
+// events (session/tool/file/permission); pi 41 fine-grained extension events (pi 1.3.0);
 // 'none' = the host exposes no extension surface and the engine owns the bus
 // (VS Code). Declarative hosts (no plugin API) do not set `extensionEvents`.
 // OpenCode's plugin event surface (ADR-1239 §research; ~25 documented events,
@@ -655,11 +655,13 @@ const EXTENSION_EVENT_SURFACES = Object.freeze({
         'pre_gateway_dispatch', 'pre_approval_request',
         'transform_tool_result',
     ]),
-    // #2102 Stage 2 — pi's real ExtensionAPI event vocabulary (~30 fine-grained
-    // extension events; documentation-sourced, ADR-1239 §research). Replaces the
-    // placeholder single-event ['tool_call'] surface — the Stage 1 value only
-    // covered the one event pi/gsd.cjs happened to bind at the time, not the
-    // full declared surface.
+    // pi's real ExtensionAPI event vocabulary: the 41 `on(event: "...")` overloads
+    // declared by pi 1.3.0 (@earendil-works/pi-coding-agent
+    // dist/core/extensions/types.d.ts, sourceCommit 71023aec15, #5557). #2102
+    // Stage 2 declared the first 30 from pi.dev prose; the last 11 on the final
+    // row group were added when the host's own declarations were read. The
+    // pi.dev extensions page lists a lossy subset (it omits session_before_compact,
+    // which pi/gsd.cjs binds), so the type declarations are the source of truth.
     pi: Object.freeze([
         'session_start', 'project_trust', 'resources_discover', 'input',
         'before_agent_start', 'agent_start', 'message_start', 'message_update',
@@ -669,6 +671,11 @@ const EXTENSION_EVENT_SURFACES = Object.freeze({
         'session_before_switch', 'session_shutdown', 'session_before_fork',
         'session_info_changed', 'session_before_compact', 'session_compact',
         'session_before_tree', 'session_tree', 'thinking_level_select', 'model_select',
+        // Added in pi 1.3.0 (#5557):
+        'agent_before_settle', 'agent_settled', 'before_provider_headers',
+        'cache_warming_decision', 'context_with_system', 'mcp_servers_change',
+        'provider_stream_event', 'session_compact_failed', 'ui_prompt_end',
+        'ui_prompt_start', 'user_bash',
     ]),
     none: Object.freeze([]),
 });