@opengsd/gsd-core 1.16.0 → 1.18.0

package/scripts/diagnose-windows-spawn-watcher.cjs

@@ -0,0 +1,317 @@
+'use strict';
+
+/**
+ * #5473 — a job-long watcher for the Windows conformance tier's bounded-child stalls.
+ *
+ * In one Windows run (job 39083981500) three different tests each hit their
+ * bound EXACTLY: the #4784 `sh -c 'printf | sed | head -1'` at 10 s, an
+ * `echo | grep | awk` bash pipeline at 5 s, and `npm ls` through cmd.exe at 30 s.
+ * Measured inside the tier, a bare `bash` starts in ~35 ms, Defender real-time
+ * protection is off, and 2,407 pipeline calls under 6-way concurrency never
+ * stalled past 2 s. So the stall is rare and does not reproduce on demand. This
+ * watcher runs beside the whole test step on the same VM and writes down, with a
+ * UTC wall-clock timestamp, every moment the VM itself stops making progress:
+ *
+ *   - `loop-gap`: this process's own timer fired more than LOOP_GAP_MS late
+ *     (the whole VM, or at least this process, was not scheduled);
+ *   - `probe-slow`: a probe child (the #4784 sh pipeline, or `cmd /c exit`)
+ *     took more than PROBE_SLOW_MS, or hit its bound;
+ *   - `procs`: a snapshot of the live node/sh/bash/cmd/npm/git processes (name,
+ *     parent, age, CPU time so far, and the *.test.cjs names in their
+ *     arguments), taken after either anomaly and every two minutes, so a stall
+ *     can be lined up with what else was running in the chunk. Earlier red
+ *     `next`s (see defaultMaxUnmeasuredPerChunk in scripts/run-tests.cjs) lost
+ *     whole chunks at 600000 ms with zero failing tests; the periodic snapshots
+ *     show which test file a killed chunk was inside and whether it was idle.
+ *
+ * Timestamps are ISO UTC, the same clock as the lines in the job log, so a
+ * failing test's end time minus its duration can be lined up against these
+ * events: a stall that is the VM freezing shows up here at the same instant; a
+ * stall that is only that one child hanging does not.
+ *
+ *   node scripts/diagnose-windows-spawn-watcher.cjs start [dir]   spawn detached, return at once
+ *   node scripts/diagnose-windows-spawn-watcher.cjs report [dir]  stop it, print and summarize the events
+ *
+ * `dir` defaults to RUNNER_TEMP/spawn-watcher. No environment variable or value
+ * is read into the report. TEMPORARY: delete
+ * with scripts/diagnose-validate-commit-*.cjs once #5473 is resolved.
+ */
+
+const fs = require('node:fs');
+const path = require('node:path');
+const { spawn } = require('node:child_process');
+const { ExitError, runMain } = require('./lib/cli-exit.cjs');
+
+const TICK_MS = 250;
+const LOOP_GAP_MS = 750;
+// The watcher must not become the load it is looking for: a stall that shows up once in
+// thousands of calls is easy to shift with extra spawn churn, so probes are sparse (one
+// sh and one cmd every 5 s, about 480 pairs over a 40 minute job) and the CIM query,
+// the heavy part, runs every 5 minutes plus at most once a minute after an anomaly.
+const PROBE_EVERY_MS = 5000;
+const PROBE_BOUND_MS = 15_000;
+const PROBE_SLOW_MS = 1500;
+const MAX_LIFETIME_MS = 40 * 60_000;
+const PIPELINE = "printf '%s\\n' x | sed -n 's/x/y/p' | head -1";
+
+const REPORT_WAIT_MS = 20_000;
+const EVENTS_FILE = 'events.log';
+const STOP_FILE = 'stop';
+const SUMMARY_FILE = 'summary.json';
+
+/** One event line: `<ISO UTC> <kind> <ms> <detail>`. */
+function formatEvent(at, kind, ms, detail) {
+  return `${new Date(at).toISOString()} ${kind} ${ms} ${detail}`;
+}
+
+const SHELL_NAMES = new Set(['sh', 'bash', 'cmd']);
+const LINGER_AGE_S = 30;
+
+/**
+ * One compact line for a process snapshot. `rows` are `{pid, ppid, name, born, cpuMs, cmd}`
+ * (born = epoch ms, cmd = the command line). Only what identifies the work is kept: the
+ * process name, its age, its CPU time so far, and the `*.test.cjs` file names in its
+ * arguments (the node:test chunk children carry them). Nothing else from a command line
+ * is reported, because the job environment carries tokens and a report is public.
+ */
+function formatProcs(rows, now) {
+  return rows
+    .map((r) => {
+      const tests = [...new Set(String(r.cmd || '').match(/[\w.-]+\.test\.cjs/g) || [])].slice(0, 3);
+      const age = Math.max(0, Math.round((now - r.born) / 1000));
+      const cpu = Math.round(r.cpuMs / 1000);
+      // A shell that outlives every bound the tests set is the signature of a descendant
+      // still holding a spawnSync stdio pipe: node's timer then reports ETIMEDOUT at the
+      // exact bound although the direct child already exited (node src/spawn_sync.cc).
+      const lingering = SHELL_NAMES.has(r.name) && age > LINGER_AGE_S ? ' LINGERING' : '';
+      return `${r.name}#${r.pid}<${r.ppid} age ${age}s cpu ${cpu}s${lingering}${tests.length ? ` [${tests.join(' ')}]` : ''}`;
+    })
+    .join(' | ');
+}
+
+/** Inverse of formatEvent; null for a line that is not an event. */
+function parseEvent(line) {
+  const m = /^(\d{4}-\d{2}-\d{2}T[\d:.]+Z) (loop-gap|probe-slow|probe-error|procs) (\d+) (.*)$/.exec(line);
+  if (!m) return null;
+  return { at: m[1], kind: m[2], ms: Number(m[3]), detail: m[4] };
+}
+
+/** Counts and extremes per kind, over parsed events. */
+function summarizeEvents(events) {
+  const out = {};
+  for (const e of events) {
+    const s = out[e.kind] || (out[e.kind] = { count: 0, maxMs: 0 });
+    s.count += 1;
+    if (e.ms > s.maxMs) s.maxMs = e.ms;
+  }
+  return out;
+}
+
+/** Percentile (0..1) of numbers, nearest-rank on a sorted copy; null when empty. */
+function percentile(values, p) {
+  if (values.length === 0) return null;
+  const sorted = [...values].sort((a, b) => a - b);
+  return sorted[Math.min(sorted.length - 1, Math.floor(p * sorted.length))];
+}
+
+/**
+ * Run one probe child. `onDone(label, ms, timedOut, started, error)`: `error` is the spawn
+ * error code (or the thrown message) when the probe never ran, else null. A probe that
+ * never ran must not look like a fast success, so callers keep it out of the latencies.
+ */
+function probe(label, bin, args, onDone) {
+  const started = Date.now();
+  let timedOut = false;
+  let settled = false;
+  let timer = null;
+  const finish = (error) => {
+    if (settled) return;
+    settled = true;
+    clearTimeout(timer);
+    onDone(label, Date.now() - started, timedOut, started, error || null);
+  };
+  let child;
+  try {
+    child = spawn(bin, args, { stdio: ['ignore', 'pipe', 'pipe'], windowsHide: true });
+  } catch (e) {
+    finish(`threw ${e && e.code ? e.code : 'error'}`);
+    return;
+  }
+  timer = setTimeout(() => { timedOut = true; try { child.kill('SIGKILL'); } catch { /* gone */ } finish(); }, PROBE_BOUND_MS);
+  child.stdout.resume();
+  child.stderr.resume();
+  child.on('error', (e) => finish(`spawn ${e && e.code ? e.code : 'error'}`));
+  child.on('close', () => finish());
+}
+
+const PS_PROCS = "Get-CimInstance Win32_Process | Where-Object { $_.Name -match '^(node|sh|bash|cmd|npm|git)\\.exe$' } | ForEach-Object { [pscustomobject]@{ pid = $_.ProcessId; ppid = $_.ParentProcessId; name = $_.Name -replace '\\.exe$', ''; born = [int64](([datetime]$_.CreationDate).ToUniversalTime() - [datetime]'1970-01-01').TotalMilliseconds; cpuMs = [int64](($_.KernelModeTime + $_.UserModeTime) / 10000); cmd = $_.CommandLine } } | ConvertTo-Json -Compress";
+const SNAPSHOT_EVERY_MS = 300_000;
+const SNAPSHOT_COOLDOWN_MS = 60_000;
+const SNAPSHOT_BOUND_MS = 30_000;
+
+/** Snapshot the live node/sh/bash/cmd/npm/git processes; calls back with the compact line. */
+function snapshotProcs(onDone) {
+  const started = Date.now();
+  let out = '';
+  let err = '';
+  let child;
+  try {
+    child = spawn('powershell', ['-NoProfile', '-NonInteractive', '-Command', PS_PROCS], { stdio: ['ignore', 'pipe', 'pipe'], windowsHide: true });
+  } catch (e) {
+    onDone(Date.now() - started, `snapshot unavailable (threw ${e && e.code ? e.code : 'error'})`);
+    return;
+  }
+  const timer = setTimeout(() => { try { child.kill('SIGKILL'); } catch { /* gone */ } }, SNAPSHOT_BOUND_MS);
+  child.stdout.on('data', (d) => { out += d; });
+  // PowerShell's own error text carries no command lines; a short head tells a failure from a timeout.
+  child.stderr.on('data', (d) => { if (err.length < 200) err += d; });
+  child.on('error', (e) => { clearTimeout(timer); onDone(Date.now() - started, `snapshot unavailable (spawn ${e && e.code ? e.code : 'error'})`); });
+  child.on('close', (code, signal) => {
+    clearTimeout(timer);
+    let rows = [];
+    try { const parsed = JSON.parse(out); rows = Array.isArray(parsed) ? parsed : [parsed]; } catch { /* no rows */ }
+    // The watcher's own process and its probe/snapshot children are not what we are lining up against.
+    rows = rows.filter((r) => r.pid !== process.pid && r.ppid !== process.pid);
+    const why = signal ? `killed ${signal}` : `exit ${code}`;
+    onDone(
+      Date.now() - started,
+      rows.length ? `${rows.length} procs: ${formatProcs(rows, Date.now())}` : `snapshot unavailable (${why}${err ? `: ${err.replace(/\s+/g, ' ').trim().slice(0, 200)}` : ''})`,
+    );
+  });
+}
+
+function run(dir) {
+  const eventsPath = path.join(dir, EVENTS_FILE);
+  const record = (at, kind, ms, detail) => {
+    try { fs.appendFileSync(eventsPath, `${formatEvent(at, kind, ms, detail)}\n`); } catch { /* dir gone: nothing to do */ }
+  };
+  let lastSnapshotAt = 0;
+  let snapshotting = false;
+  const takeSnapshot = (why) => {
+    const now = Date.now();
+    if (snapshotting || now - lastSnapshotAt < SNAPSHOT_COOLDOWN_MS) return;
+    snapshotting = true;
+    lastSnapshotAt = now;
+    snapshotProcs((ms, detail) => { snapshotting = false; record(Date.now(), 'procs', ms, `${why}: ${detail}`); });
+  };
+  const snapshotTimer = setInterval(() => takeSnapshot('periodic'), SNAPSHOT_EVERY_MS);
+  const lifetimeEnd = Date.now() + MAX_LIFETIME_MS;
+  const probeMs = { sh: [], cmd: [] };
+  let probeCount = 0;
+  let last = Date.now();
+
+  const tick = setInterval(() => {
+    const now = Date.now();
+    const late = now - last - TICK_MS;
+    if (late > LOOP_GAP_MS) { record(now, 'loop-gap', late, `timer fired ${late}ms late`); takeSnapshot('after loop-gap'); }
+    last = now;
+    if (now > lifetimeEnd || fs.existsSync(path.join(dir, STOP_FILE))) finishRun();
+  }, TICK_MS);
+
+  const probeErrors = { sh: 0, cmd: 0 };
+  const onProbe = (label, ms, timedOut, started, error) => {
+    if (error) {
+      probeErrors[label] += 1;
+      record(Date.now(), 'probe-error', ms, `${label} never ran: ${error}`);
+      return;
+    }
+    probeCount += 1;
+    probeMs[label].push(ms);
+    if (ms > PROBE_SLOW_MS || timedOut) {
+      record(Date.now(), 'probe-slow', ms, `${label} started ${new Date(started).toISOString()}${timedOut ? ' hit the bound' : ''}`);
+      takeSnapshot('after probe-slow');
+    }
+  };
+
+  let probing = true;
+  let loopTimer = null;
+  // Run the two probes one after the other, then wait out the rest of the interval.
+  const loop = () => {
+    if (!probing) return;
+    const cycleStart = Date.now();
+    probe('sh', 'sh', ['-c', PIPELINE], (l, ms, to, st, er) => {
+      onProbe(l, ms, to, st, er);
+      probe('cmd', 'cmd', ['/c', 'exit', '0'], (l2, ms2, to2, st2, er2) => {
+        onProbe(l2, ms2, to2, st2, er2);
+        loopTimer = setTimeout(loop, Math.max(0, PROBE_EVERY_MS - (Date.now() - cycleStart)));
+      });
+    });
+  };
+  loop();
+
+  function finishRun() {
+    probing = false;
+    clearInterval(tick);
+    clearInterval(snapshotTimer);
+    clearTimeout(loopTimer);
+    const summary = {
+      probes: probeCount,
+      sh: { n: probeMs.sh.length, errors: probeErrors.sh, median: percentile(probeMs.sh, 0.5), p99: percentile(probeMs.sh, 0.99), max: percentile(probeMs.sh, 1) },
+      cmd: { n: probeMs.cmd.length, errors: probeErrors.cmd, median: percentile(probeMs.cmd, 0.5), p99: percentile(probeMs.cmd, 0.99), max: percentile(probeMs.cmd, 1) },
+    };
+    // Write then rename, so report never sees the file before its content has landed.
+    try {
+      const target = path.join(dir, SUMMARY_FILE);
+      fs.writeFileSync(`${target}.tmp`, JSON.stringify(summary));
+      fs.renameSync(`${target}.tmp`, target);
+    } catch { /* best effort */ }
+    // No process.exit (ADR-3889): every timer is cleared above, so the process ends when the
+    // probe or snapshot child still in flight (each bounded) has exited; report has already
+    // been released by the summary file, so nothing waits on this.
+  }
+}
+
+function start(dir) {
+  fs.mkdirSync(dir, { recursive: true });
+  const child = spawn(process.execPath, [__filename, 'run', dir], { detached: true, stdio: 'ignore', windowsHide: true });
+  child.unref();
+}
+
+function report(dir) {
+  try { fs.writeFileSync(path.join(dir, STOP_FILE), ''); } catch { /* start never ran */ }
+  // The stop file is only seen on the watcher's 250ms tick, so a VM stall longer than this
+  // wait (the very case under study) leaves no summary: say so below instead of "crashed".
+  const deadline = Date.now() + REPORT_WAIT_MS;
+  while (!fs.existsSync(path.join(dir, SUMMARY_FILE)) && Date.now() < deadline) {
+    Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, 100);
+  }
+  let events = [];
+  try {
+    events = fs.readFileSync(path.join(dir, EVENTS_FILE), 'utf8').split('\n').map(parseEvent).filter(Boolean);
+  } catch { /* no events file: nothing recorded */ }
+  let summary = null;
+  try { summary = JSON.parse(fs.readFileSync(path.join(dir, SUMMARY_FILE), 'utf8')); } catch { /* watcher did not finish */ }
+  const lines = [
+    '### #5473 Windows spawn-stall watcher (whole test step, same VM)',
+    '',
+    summary
+      ? `probes: ${summary.probes} ; sh pipeline median ${summary.sh.median} / p99 ${summary.sh.p99} / max ${summary.sh.max} ms (n=${summary.sh.n}, never ran ${summary.sh.errors}) ; cmd /c exit median ${summary.cmd.median} / p99 ${summary.cmd.p99} / max ${summary.cmd.max} ms (n=${summary.cmd.n}, never ran ${summary.cmd.errors})`
+      : `watcher summary missing after ${REPORT_WAIT_MS / 1000}s: it either crashed or was stalled past the wait (the events below show which: a stall leaves loop-gap/probe-slow lines up to the last tick)`,
+    `events: ${JSON.stringify(summarizeEvents(events))}`,
+    '',
+    ...events.map((e) => `- ${e.at} ${e.kind} ${e.ms}ms ${e.detail}`),
+  ];
+  const text = lines.join('\n');
+  process.stdout.write(`${text}\n`);
+  if (process.env.GITHUB_STEP_SUMMARY) {
+    try { fs.appendFileSync(process.env.GITHUB_STEP_SUMMARY, `${text}\n`); } catch { /* best effort */ }
+  }
+}
+
+// CONTRIBUTING forbids `${{ }}` inside a workflow `run:` block, so the workflow
+// passes no directory: GitHub sets RUNNER_TEMP itself, and start and report agree on it here.
+function defaultDir() {
+  return path.join(process.env.RUNNER_TEMP || require('node:os').tmpdir(), 'spawn-watcher');
+}
+
+function main() {
+  const [, , mode, dirArg] = process.argv;
+  if (!['start', 'run', 'report'].includes(mode)) {
+    throw new ExitError(2, 'usage: diagnose-windows-spawn-watcher.cjs start|report [dir]');
+  }
+  ({ start, run, report })[mode](path.resolve(dirArg || defaultDir()));
+}
+
+if (require.main === module) runMain(main);
+
+module.exports = { formatEvent, formatProcs, parseEvent, summarizeEvents, percentile, LOOP_GAP_MS, PROBE_SLOW_MS };

package/scripts/docs-guard-registry.cjs

@@ -338,12 +338,14 @@ const DOCS_GUARD_TESTS = {
   // (no-pending-3212-markers.test.cjs:37-46), which includes all of docs/ —
   // cannot be resolved to a fixed docs/ path set.
   'tests/no-pending-3212-markers.test.cjs': ['*'],
+  'tests/pause-work-improvements.test.cjs': ['docs/zh-CN/references/git-integration.md'],
   'tests/phase6-capability-docs.test.cjs': ['docs/how-to/develop-a-capability.md', 'docs/README.md'],
   'tests/phase6-review-capabilities.test.cjs': [
     'docs/reference/review-verification-capabilities.md',
     'docs/how-to/develop-a-capability.md',
     'docs/README.md',
   ],
+  'tests/plan-authoring-verification-gaps.test.cjs': ['docs/reference/plan-md.md'],
   'tests/plan-checker-coupling.test.cjs': ['docs/AGENTS.md'],
   'tests/plan-phase-drift-guard.test.cjs': [
     'docs/CONFIGURATION.md',

package/scripts/gen-capability-registry.cjs

@@ -38,6 +38,7 @@ const { getWiredKinds } = require('./gen-loop-host-contract.cjs');
 
 // Capability validator — shared runtime-callable module extracted per ADR-1244 D2.
 const capValidator = require('../gsd-core/bin/lib/capability-validator.cjs');
+const { transformContentToHyphen, readCmdNames } = require('./fix-slash-commands.cjs');
 // Destructure only what the generator's own function bodies reference directly.
 // Everything else is re-exported from capValidator in module.exports below.
 const {
@@ -795,7 +796,12 @@ function serializeRegistry(registry, capMap) {
   lines.push('};');
   lines.push('');
 
-  return lines.join('\n');
+  // #4859: capability descriptions and fragment `inline` text are compiled into this
+  // file and printed verbatim — the install-time conversion of markdown artifacts never
+  // reaches them — so the colon form `/gsd:<cmd>` (the repo-source spelling, which no
+  // install route registers) is rewritten to the hyphen form here. Same-length rewrite,
+  // restricted to known command names, so `/gsd:section` and other tokens are untouched.
+  return transformContentToHyphen(lines.join('\n'), readCmdNames());
 }
 
 // ─── --check diff helper ──────────────────────────────────────────────────────

package/scripts/gen-loop-host-contract.cjs

@@ -85,6 +85,9 @@ const ROLE_TO_AGENT = {
   checker:    'gsd-plan-checker',
   executor:   'gsd-executor',
   verifier:   'gsd-verifier',
+  // #4790 — the built-in source-code reviewer the code-review skill dispatches one hop below
+  // `execute:post`. Admitting the role is what lets a capability contribution name it.
+  'code-reviewer': 'gsd-code-reviewer',
 };
 
 // #4740 — Role → family mapping. Three families: orchestration, planning,
@@ -94,7 +97,7 @@ const ROLE_TO_AGENT = {
 const ROLE_FAMILY = {
   orchestrator: 'orchestration',
   researcher: 'planning', planner: 'planning', checker: 'planning',
-  executor: 'execution', verifier: 'execution',
+  executor: 'execution', verifier: 'execution', 'code-reviewer': 'execution',
 };
 const EXPECTED_FAMILY_BY_STEP = {
   discuss: 'orchestration',

package/scripts/lib/macos-conformance-tier.generated.cjs

@@ -46,6 +46,7 @@ module.exports = {
   "tests/codex-config-hooks.test.cjs",
   "tests/codex-config-install.test.cjs",
   "tests/codex-config.test.cjs",
+  "tests/command-arguments-block.test.cjs",
   "tests/commands.platform.test.cjs",
   "tests/commit-docs-bypass.test.cjs",
   "tests/commit-files-deletion.test.cjs",
@@ -71,6 +72,7 @@ module.exports = {
   "tests/execute-phase-decimal-arithmetic.test.cjs",
   "tests/executed-plan.test.cjs",
   "tests/executor-mvp-tdd-section.test.cjs",
+  "tests/executor-sequential-linked-worktree.test.cjs",
   "tests/external-job.test.cjs",
   "tests/failing-direction.test.cjs",
   "tests/fallow-runner.test.cjs",
@@ -80,6 +82,7 @@ module.exports = {
   "tests/gap-checker.property.test.cjs",
   "tests/gate-api-coverage-verify-pre-escape.test.cjs",
   "tests/gate-codebase-drift.unit.test.cjs",
+  "tests/gate-predicate.unit.test.cjs",
   "tests/gate-tdd-red-evidence-containment.test.cjs",
   "tests/gate-ui-plan.unit.test.cjs",
   "tests/gate-verify-command-paths.unit.test.cjs",
@@ -104,6 +107,7 @@ module.exports = {
   "tests/hooks-crash-policy.test.cjs",
   "tests/hooks-opt-in.test.cjs",
   "tests/host-integration.test.cjs",
+  "tests/in-tier-commit-hook-timing.test.cjs",
   "tests/init-manager.test.cjs",
   "tests/install-minimal-hooks.test.cjs",
   "tests/install-path-detection.test.cjs",
@@ -143,7 +147,11 @@ module.exports = {
   "tests/nsegment-phase-grammar.test.cjs",
   "tests/observability/event.test.cjs",
   "tests/onboard-command.test.cjs",
+  "tests/opencode-generations.smoke.test.cjs",
+  "tests/opencode-install-notices.test.cjs",
+  "tests/opencode-parity-hooks.test.cjs",
   "tests/opencode-plugin-adapter.test.cjs",
+  "tests/opencode-uninstall-roundtrip.test.cjs",
   "tests/pause-work-context-detection.test.cjs",
   "tests/pause-work-improvements.test.cjs",
   "tests/perf-317-context-monitor-fs.test.cjs",
@@ -155,6 +163,7 @@ module.exports = {
   "tests/phase-status.test.cjs",
   "tests/phase.platform.test.cjs",
   "tests/phase.test.cjs",
+  "tests/plan-authoring-verification-gaps.test.cjs",
   "tests/plan-count-single-owner.test.cjs",
   "tests/plan-document.test.cjs",
   "tests/plan-phase-stall-detection.test.cjs",
@@ -177,6 +186,7 @@ module.exports = {
   "tests/quick-batch-command-router.stdin.test.cjs",
   "tests/quick-batch.test.cjs",
   "tests/quick-branching.test.cjs",
+  "tests/quick-commit-boundary.test.cjs",
   "tests/quick-research.test.cjs",
   "tests/reapply-verify-hunks.test.cjs",
   "tests/refactor-1390-t3-characterization.test.cjs",
@@ -184,6 +194,7 @@ module.exports = {
   "tests/response-language-coverage.test.cjs",
   "tests/retired-artifact-cleanup.test.cjs",
   "tests/review-build-prompt-optional-sections.test.cjs",
+  "tests/review-lane-invocation.test.cjs",
   "tests/review-lane-runner.test.cjs",
   "tests/review-lane-windows-spawn-resolution.test.cjs",
   "tests/review-parallel-lanes.test.cjs",
@@ -207,11 +218,13 @@ module.exports = {
   "tests/shared-hooks-dir-resolution.test.cjs",
   "tests/shell-command-projection-dispatch.test.cjs",
   "tests/shipped-reference-cites.test.cjs",
+  "tests/skill-manifest.test.cjs",
   "tests/spawn-liveness-banner.test.cjs",
   "tests/state-document.test.cjs",
   "tests/state-transition.test.cjs",
   "tests/state.platform.test.cjs",
   "tests/state.test.cjs",
+  "tests/tdd-mode.platform.test.cjs",
   "tests/todos-workstream-scope.test.cjs",
   "tests/tracer-bullet.test.cjs",
   "tests/uat-complete-session.test.cjs",

package/scripts/lib/platform-conformance-tier.generated.cjs

@@ -24,6 +24,7 @@ module.exports = {
   "tests/capability-ledger.test.cjs",
   "tests/capability-lifecycle.test.cjs",
   "tests/capability-loader.test.cjs",
+  "tests/capability-lock-lazy-self-probe-5327.test.cjs",
   "tests/capability-lock-mkdir-failure-3987.test.cjs",
   "tests/capability-probe-fallback.test.cjs",
   "tests/capability-source.test.cjs",
@@ -39,6 +40,7 @@ module.exports = {
   "tests/check-tdd-review-checkpoint-e2e.test.cjs",
   "tests/check-ui-safety-gate.test.cjs",
   "tests/check-update-config-dir.test.cjs",
+  "tests/check-update-fail-open.test.cjs",
   "tests/chunked-planning-parallel.test.cjs",
   "tests/ci-docs-guard-registry.test.cjs",
   "tests/ci-rebase-check.test.cjs",
@@ -51,11 +53,14 @@ module.exports = {
   "tests/code-review-pipeline-regression.test.cjs",
   "tests/code-review-tier3-files-override-scoping.test.cjs",
   "tests/code-review.test.cjs",
+  "tests/code-reviewer-contribution.test.cjs",
   "tests/codex-config-agents.test.cjs",
   "tests/codex-config-hooks.test.cjs",
   "tests/codex-config-install.test.cjs",
   "tests/codex-config.test.cjs",
   "tests/codex-inherit-smoke.test.cjs",
+  "tests/codex-windows-shim-node-resolution.test.cjs",
+  "tests/command-arguments-block.test.cjs",
   "tests/command-routing-hub.test.cjs",
   "tests/commands.platform.test.cjs",
   "tests/commit-files-deletion.test.cjs",
@@ -70,6 +75,7 @@ module.exports = {
   "tests/config.platform.test.cjs",
   "tests/configured-entrypoint-validation.test.cjs",
   "tests/context-drift.test.cjs",
+  "tests/context-monitor-host-contract.test.cjs",
   "tests/copilot-install.test.cjs",
   "tests/copilot-upgrades.test.cjs",
   "tests/core-utils.test.cjs",
@@ -77,6 +83,8 @@ module.exports = {
   "tests/cursor-hooks.test.cjs",
   "tests/cursor-subagent-isolation.test.cjs",
   "tests/debug-session-management.test.cjs",
+  "tests/defaults-json-fallback.test.cjs",
+  "tests/diagnose-windows-spawn-watcher.test.cjs",
   "tests/dispatch-identity.test.cjs",
   "tests/dispatcher.test.cjs",
   "tests/drift-detection.test.cjs",
@@ -89,12 +97,14 @@ module.exports = {
   "tests/emitted-provenance.test.cjs",
   "tests/ensure-runtime-build.test.cjs",
   "tests/eslint-rules.test.cjs",
+  "tests/execute-phase-cross-block-state.test.cjs",
   "tests/execute-phase-decimal-arithmetic.test.cjs",
   "tests/execute-phase-worktree-guard.test.cjs",
   "tests/execute-plan-update-codebase-map-diff-base.test.cjs",
   "tests/execute-wave-post-gate-pipeline-e2e.test.cjs",
   "tests/executed-plan.test.cjs",
   "tests/executor-mvp-tdd-section.test.cjs",
+  "tests/executor-sequential-linked-worktree.test.cjs",
   "tests/external-descriptor-confinement.test.cjs",
   "tests/failing-direction.test.cjs",
   "tests/fallow-runner.test.cjs",
@@ -107,6 +117,7 @@ module.exports = {
   "tests/gate-consumer-exit-awareness.test.cjs",
   "tests/gate-decision-coverage-verify-stderr.test.cjs",
   "tests/gate-exit.test.cjs",
+  "tests/gate-predicate.unit.test.cjs",
   "tests/gate-tdd-red-evidence-containment.test.cjs",
   "tests/gate-tdd-review-checkpoint-hardening.test.cjs",
   "tests/gate-tdd-review-checkpoint.unit.test.cjs",
@@ -141,6 +152,8 @@ module.exports = {
   "tests/hooks-crash-policy.test.cjs",
   "tests/hooks-opt-in.test.cjs",
   "tests/host-integration.test.cjs",
+  "tests/in-tier-msys-fork-stress.test.cjs",
+  "tests/in-tier-sh-pipeline-timing.test.cjs",
   "tests/init-manager.test.cjs",
   "tests/install-minimal-hooks.test.cjs",
   "tests/install-nested-layout.test.cjs",
@@ -176,6 +189,7 @@ module.exports = {
   "tests/mcp-catalog.test.cjs",
   "tests/milestone-archive.test.cjs",
   "tests/milestone-window-single-owner.test.cjs",
+  "tests/milestone.test.cjs",
   "tests/model-resolver.test.cjs",
   "tests/mutation-workflow-base-ref.test.cjs",
   "tests/new-milestone-clear-phases.test.cjs",
@@ -195,7 +209,13 @@ module.exports = {
   "tests/nsegment-phase-grammar.test.cjs",
   "tests/onboard-command.test.cjs",
   "tests/opencode-command-dir-plural.test.cjs",
+  "tests/opencode-config-jsonc.test.cjs",
+  "tests/opencode-generations.smoke.test.cjs",
+  "tests/opencode-install-notices.test.cjs",
+  "tests/opencode-parity-hooks.test.cjs",
   "tests/opencode-plugin-adapter.test.cjs",
+  "tests/opencode-statusline-plugin.test.cjs",
+  "tests/opencode-uninstall-roundtrip.test.cjs",
   "tests/overlay-repo-helpers.test.cjs",
   "tests/packaging-shipped-scripts-require-only-shipped.test.cjs",
   "tests/path-replacement.test.cjs",
@@ -235,6 +255,7 @@ module.exports = {
   "tests/quick-batch-command-router.stdin.test.cjs",
   "tests/quick-batch.test.cjs",
   "tests/quick-branching.test.cjs",
+  "tests/quick-commit-boundary.test.cjs",
   "tests/quick-research.test.cjs",
   "tests/quick-review-scope-tip-bound.test.cjs",
   "tests/read-guard.test.cjs",
@@ -248,6 +269,7 @@ module.exports = {
   "tests/retired-artifact-cleanup.test.cjs",
   "tests/review-build-prompt-optional-sections.test.cjs",
   "tests/review-default-reviewers-config.test.cjs",
+  "tests/review-lane-invocation.test.cjs",
   "tests/review-lane-runner.test.cjs",
   "tests/review-lane-windows-spawn-resolution.test.cjs",
   "tests/review-model-config.test.cjs",
@@ -283,6 +305,9 @@ module.exports = {
   "tests/slug-derivation-drift-guard.test.cjs",
   "tests/state-todos-render.test.cjs",
   "tests/state.platform.test.cjs",
+  "tests/subject-first-line.platform.test.cjs",
+  "tests/tdd-mode.platform.test.cjs",
+  "tests/tdd-review-checkpoint-cross-plan.test.cjs",
   "tests/teams-status.test.cjs",
   "tests/test-gate-watch-mode.test.cjs",
   "tests/todos-workstream-scope.test.cjs",
@@ -312,5 +337,6 @@ module.exports = {
   "tests/worktree-cleanup.test.cjs",
   "tests/worktree-safety.test.cjs",
   "tests/worktree.test.cjs",
+  "tests/xtrace-phase-timing.platform.test.cjs",
   ],
 };

package/scripts/lint-phase-arg-assignment.cjs

@@ -93,10 +93,10 @@ const SHELL_INFO_STRINGS = new Set(['bash', 'sh', 'shell']);
 const CANONICAL_FORMS = Object.freeze({
   /** `/gsd:secure-phase 4` — the phase is the whole argument string, minus a `--ws <name>` pair. */
   positional:
-    'PHASE_ARG=$(echo "$ARGUMENTS" | sed -E \'s/--ws[[:space:]]+[A-Za-z0-9._-]+//g\' | xargs)',
+    'PHASE_ARG=$(echo "$GSD_ARGS" | sed -E \'s/--ws[[:space:]]+[A-Za-z0-9._-]+//g\' | xargs)',
   /** `/gsd:review --phase 4 --codex` — the phase is the value of a named flag. */
   phaseFlag:
-    'PHASE_ARG=$(echo "$ARGUMENTS" | sed -nE \'s/.*--phase[[:space:]]+([A-Za-z0-9._-]+).*/\\1/p\')',
+    'PHASE_ARG=$(echo "$GSD_ARGS" | sed -nE \'s/.*--phase[[:space:]]+([A-Za-z0-9._-]+).*/\\1/p\')',
   /** Skill dispatch passes the phase as `$1` (`Skill(skill="gsd-code-review", args="4")`). */
   firstPositional: 'PHASE_ARG="${1}"',
 });

package/scripts/lint-workflow-shellcheck-baseline.json

@@ -384,6 +384,21 @@
     "code": "2086",
     "message": "Double quote to prevent globbing and word splitting."
   },
+  {
+    "file": "gsd-core/workflows/execute-phase/steps/code-review-disposition.md",
+    "code": "2317",
+    "message": "Command appears to be unreachable. Check usage (or ignore if invoked indirectly)."
+  },
+  {
+    "file": "gsd-core/workflows/execute-phase/steps/code-review-disposition.md",
+    "code": "2317",
+    "message": "Command appears to be unreachable. Check usage (or ignore if invoked indirectly)."
+  },
+  {
+    "file": "gsd-core/workflows/execute-phase/steps/code-review-disposition.md",
+    "code": "2317",
+    "message": "Command appears to be unreachable. Check usage (or ignore if invoked indirectly)."
+  },
   {
     "file": "gsd-core/workflows/execute-phase/steps/executor-isolation-dispatch.md",
     "code": "2016",
@@ -690,7 +705,7 @@
     "message": "Double quote to prevent globbing and word splitting."
   },
   {
-    "file": "gsd-core/workflows/plan-phase.md",
+    "file": "gsd-core/workflows/plan-phase/steps/auto-advance-check.md",
     "code": "2235",
     "message": "Use { ..; } instead of (..) to avoid subshell overhead."
   },
@@ -1108,20 +1123,5 @@
     "file": "gsd-core/workflows/verify-work/steps/mvp-uat-framing.md",
     "code": "2086",
     "message": "Double quote to prevent globbing and word splitting."
-  },
-  {
-    "file": "gsd-core/workflows/execute-phase/steps/code-review-disposition.md",
-    "code": "2317",
-    "message": "Command appears to be unreachable. Check usage (or ignore if invoked indirectly)."
-  },
-  {
-    "file": "gsd-core/workflows/execute-phase/steps/code-review-disposition.md",
-    "code": "2317",
-    "message": "Command appears to be unreachable. Check usage (or ignore if invoked indirectly)."
-  },
-  {
-    "file": "gsd-core/workflows/execute-phase/steps/code-review-disposition.md",
-    "code": "2317",
-    "message": "Command appears to be unreachable. Check usage (or ignore if invoked indirectly)."
   }
 ]

package/scripts/mutation-matrix.cjs

@@ -480,7 +480,9 @@ const COVERED = {
   // dependency of something else under test.
   'adr-parser': {
     cjs: 'gsd-core/bin/lib/adr-parser.cjs',
-    minScore: 68,
+    // CI (2026-10-13, #5227 PR): measured 73.24% after the list-entry splitter tests. Floor =
+    // floor(73.24) - 1 = 72.
+    minScore: 72,
   },
   'config-schema': {
     cjs: 'gsd-core/bin/lib/config-schema.cjs',