@opengsd/gsd-core 1.14.0 → 1.16.0

package/gsd-core/bin/lib/verify-command-grounding.cjs

@@ -32,6 +32,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 const node_fs_1 = __importDefault(require("node:fs"));
 const node_path_1 = __importDefault(require("node:path"));
 const markdown_sectionizer_cjs_1 = require("./markdown-sectionizer.cjs");
+const security_cjs_1 = require("./security.cjs");
 // eslint-disable-next-line @typescript-eslint/no-require-imports -- phase-id.cjs is an export= CommonJS module
 const phaseIdMod = require("./phase-id.cjs");
 const { stripProjectCodePrefix, extractPhaseToken, comparePhaseNum } = phaseIdMod;
@@ -380,6 +381,25 @@ function splitSegments(cmd) {
         .map(s => s.trim())
         .filter(s => s.length > 0);
 }
+/**
+ * Decode entity-escaped ampersands (`&` → `&`) — #4730, the grounding
+ * gate's share of the #3611 defect. Planners emit `<automated>` bodies with
+ * `&amp;&amp;` as the chain operator, and the executing agent reads the
+ * decoded (rendered) form. Without this decode, `splitSegments` cuts
+ * `&amp;&amp;` at its semicolons and a `cd` target absorbs the trailing
+ * `&amp` fragment (`rawTarget: "src &amp"`), reporting an existing directory
+ * as a `missing_dir` blocker. Applied to the command text inside
+ * `resolveVerifyCommandTarget` — before any segment splitting or target
+ * resolution, after `result.command` has captured the text verbatim — so the
+ * escaped and literal forms of the same command produce identical verdicts.
+ * Kept module-private beside `splitSegments`, mirroring the sibling
+ * `src/verify.cts`'s own private `decodeEntityAmps` (#3611): the two gates
+ * are separate modules that independently parse `<automated>` text, and
+ * neither imports the other.
+ */
+function decodeEntityAmps(s) {
+    return s.replace(/&amp;/g, '&');
+}
 /** Strip a single matching pair of surrounding quotes, if present. */
 function stripQuotes(s) {
     if (s.length >= 2) {
@@ -438,6 +458,16 @@ function stripLeadingDotSlash(s) {
  * without touching the filesystem. A climb that names a concrete sibling (e.g.
  * `cd ../../frontend`, the exact #2401 shape) still names something checkable
  * and falls through to the normal filesystem probe below.
+ *
+ * An ABSOLUTE target outside the project root takes the same `outside_root`
+ * exit (#4767). It is more ambiguous across worktrees, not less: it is pinned
+ * to exactly one checkout, and when a planner copies the orchestrator's cwd
+ * into `<automated>` that checkout is the main tree — so under worktree
+ * isolation the command exists, runs, and passes against code the worktree
+ * changed and the main tree did not. Existence is therefore not evidence for
+ * an absolute target outside the root, and the filesystem is not consulted.
+ * Containment goes through `tryWithinRootLexical` (#4636) — lexical because the
+ * probe is read-only and must not depend on the target existing.
  */
 function isPureAncestorClimb(rel) {
     if (rel.length === 0)
@@ -501,7 +531,10 @@ function resolveVerifyCommandTarget(command, options) {
     if (typeof command !== 'string')
         return result;
     result.command = command;
-    const trimmed = command.trim();
+    // #4730: decode entity-escaped ampersands BEFORE segment splitting (see
+    // decodeEntityAmps) so the chain operator is visible to the splitter and
+    // the verdict matches what the executing agent's decoded form grounds to.
+    const trimmed = decodeEntityAmps(command.trim());
     if (trimmed === '')
         return result;
     // Nyquist "MISSING — Wave 0 must create …" sentinel; Dimension 8 owns it.
@@ -550,7 +583,18 @@ function resolveVerifyCommandTarget(command, options) {
     result.form = form;
     result.rawTarget = rawTarget;
     result.target = target;
-    if (!isAbs) {
+    if (isAbs) {
+        // #4767: an absolute target outside projectRoot is `outside_root`, same
+        // as the bare climb — see isPureAncestorClimb's doc for why existence is
+        // not evidence here and the filesystem is deliberately not consulted.
+        if ((0, security_cjs_1.tryWithinRootLexical)(target, base) === null) {
+            result.status = 'ok';
+            result.severity = 'warning';
+            result.reason = 'outside_root';
+            return result;
+        }
+    }
+    else {
         const rel = node_path_1.default.relative(base, target);
         if (isPureAncestorClimb(rel)) {
             result.status = 'ok';

package/gsd-core/bin/lib/verify-command-router.cjs

@@ -11,6 +11,9 @@ const command_aliases_cjs_1 = require("./command-aliases.cjs");
 // eslint-disable-next-line @typescript-eslint/no-require-imports
 const cjsCommandRouterAdapter = require("./cjs-command-router-adapter.cjs");
 const { routeCjsCommandFamily } = cjsCommandRouterAdapter;
+// eslint-disable-next-line @typescript-eslint/no-require-imports
+const checkCommandRouter = require("./check-command-router.cjs");
+const { routeCheckCommand } = checkCommandRouter;
 // ─── Implementation ───────────────────────────────────────────────────────────
 function routeVerifyCommand({ verify, args, cwd, raw, error }) {
     routeCjsCommandFamily({
@@ -26,17 +29,25 @@ function routeVerifyCommand({ verify, args, cwd, raw, error }) {
             commits: () => verify.cmdVerifyCommits(cwd, args.slice(2), raw),
             artifacts: () => verify.cmdVerifyArtifacts(cwd, args[2], raw),
             'key-links': () => verify.cmdVerifyKeyLinks(cwd, args[2], raw),
+            // The three drift verbs are the `drift` capability's gates (#5219, ADR-5057 §4): each is one gate
+            // module (src/gate-{schema,codebase,context}-drift.cts) that the check router formats; this
+            // surface hands them to it. `--skip` is this surface's bypass of the schema gate (it reads no
+            // GSD_SKIP_SCHEMA_CHECK), carried to the gate as the env flag the check router reads.
             'schema-drift': () => {
                 const rest = args.slice(2);
                 const skipFlag = rest.includes('--skip');
-                const phaseArg = rest.find((arg) => !arg.startsWith('-'));
-                verify.cmdVerifySchemaDrift(cwd, phaseArg, skipFlag, raw);
+                const phaseArg = rest.find((arg) => !arg.startsWith('-')) ?? '';
+                routeCheckCommand({
+                    args: ['check', 'verify-schema-drift', phaseArg],
+                    cwd,
+                    raw,
+                    env: skipFlag ? { GSD_SKIP_SCHEMA_CHECK: 'true' } : {},
+                });
             },
-            // verify codebase-drift dispatches direct to CJS — drift is out-of-seam
-            // per ADR/PRD 3524 §3 / L160 (CJS-only by design). Routing through
-            // recursive dispatch would re-enter this router path.
-            'codebase-drift': () => verify.cmdVerifyCodebaseDrift(cwd, raw),
-            'context-drift': () => verify.cmdVerifyContextDrift(cwd, args[2], raw),
+            // verify codebase-drift and context-drift are the same gate modules `check verify-<name>`
+            // runs (#5219, ADR-5057 §4): this surface hands them to the check router, which formats them.
+            'codebase-drift': () => routeCheckCommand({ args: ['check', 'verify-codebase-drift'], cwd, raw }),
+            'context-drift': () => routeCheckCommand({ args: ['check', 'verify-context-drift', args[2] ?? ''], cwd, raw }),
         },
     });
 }