@opengsd/gsd-core 1.10.0 → 1.11.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.claude-plugin/marketplace.json +1 -1
- package/.claude-plugin/plugin.json +1 -1
- package/agents/gsd-debug-session-manager.md +11 -0
- package/agents/gsd-doc-synthesizer.md +2 -4
- package/agents/gsd-executor.md +5 -5
- package/agents/gsd-mempalace-curator.md +5 -2
- package/agents/gsd-phase-researcher.md +20 -1
- package/agents/gsd-plan-checker.md +37 -0
- package/agents/gsd-planner.md +44 -46
- package/agents/gsd-user-profiler.md +3 -0
- package/agents/gsd-verifier.md +12 -3
- package/bin/install.js +841 -971
- package/bin/lib/ui-safety-gate.cjs +2 -0
- package/commands/gsd/code-review.md +1 -1
- package/commands/gsd/execute-phase.md +1 -1
- package/commands/gsd/map-codebase.md +1 -1
- package/commands/gsd/mempalace-capture.md +1 -1
- package/commands/gsd/mempalace-recall.md +1 -1
- package/commands/gsd/new-milestone.md +1 -1
- package/commands/gsd/quick.md +1 -1
- package/commands/gsd/review-backlog.md +2 -1
- package/commands/gsd/verify-work.md +1 -1
- package/gsd-core/bin/gsd-tools.cjs +469 -88
- package/gsd-core/bin/lib/active-workstream-store.cjs +138 -22
- package/gsd-core/bin/lib/agent-install-check.cjs +230 -32
- package/gsd-core/bin/lib/api-coverage.cjs +3 -5
- package/gsd-core/bin/lib/artifacts.cjs +3 -0
- package/gsd-core/bin/lib/assumption-delta.cjs +2 -4
- package/gsd-core/bin/lib/audit-command-router.cjs +9 -2
- package/gsd-core/bin/lib/audit.cjs +876 -240
- package/gsd-core/bin/lib/broken-windows.cjs +1 -1
- package/gsd-core/bin/lib/capability-consent.cjs +149 -15
- package/gsd-core/bin/lib/capability-lifecycle.cjs +45 -0
- package/gsd-core/bin/lib/capability-registry.cjs +575 -101
- package/gsd-core/bin/lib/capability-source.cjs +92 -0
- package/gsd-core/bin/lib/capability-trust.cjs +444 -25
- package/gsd-core/bin/lib/capability-validator.cjs +495 -22
- package/gsd-core/bin/lib/capability-writer.cjs +3 -2
- package/gsd-core/bin/lib/check-command-router.cjs +71 -37
- package/gsd-core/bin/lib/claude-orchestration.cjs +56 -3
- package/gsd-core/bin/lib/codex-agent-toml.cjs +329 -0
- package/gsd-core/bin/lib/command-aliases.cjs +22 -0
- package/gsd-core/bin/lib/command-roster.cjs +44 -1
- package/gsd-core/bin/lib/commands.cjs +651 -86
- package/gsd-core/bin/lib/commonjs-marker.cjs +12 -6
- package/gsd-core/bin/lib/complexity-trigger.cjs +1172 -0
- package/gsd-core/bin/lib/config-loader.cjs +75 -0
- package/gsd-core/bin/lib/config.cjs +10 -1
- package/gsd-core/bin/lib/core-utils.cjs +127 -29
- package/gsd-core/bin/lib/decisions.cjs +23 -0
- package/gsd-core/bin/lib/fallow-runner.cjs +20 -44
- package/gsd-core/bin/lib/frontmatter.cjs +155 -20
- package/gsd-core/bin/lib/gap-checker.cjs +68 -7
- package/gsd-core/bin/lib/git-base-branch.cjs +102 -0
- package/gsd-core/bin/lib/gsd2-import.cjs +10 -1
- package/gsd-core/bin/lib/health-diagnostic-rules/agent-install.cjs +101 -0
- package/gsd-core/bin/lib/health-diagnostic-rules/config-validation.cjs +348 -0
- package/gsd-core/bin/lib/health-diagnostic-rules/consistency.cjs +145 -0
- package/gsd-core/bin/lib/health-diagnostic-rules/install-surface-shadowing.cjs +98 -0
- package/gsd-core/bin/lib/health-diagnostic-rules/milestone-archive-hygiene.cjs +100 -0
- package/gsd-core/bin/lib/health-diagnostic-rules/phase-structure.cjs +222 -0
- package/gsd-core/bin/lib/health-diagnostic-rules/roadmap-disk-consistency.cjs +265 -0
- package/gsd-core/bin/lib/health-diagnostic-rules/root-existence.cjs +161 -0
- package/gsd-core/bin/lib/health-diagnostic-rules/state-consistency.cjs +303 -0
- package/gsd-core/bin/lib/health-diagnostic-rules/worktree-health.cjs +173 -0
- package/gsd-core/bin/lib/health-diagnostic-types.cjs +68 -0
- package/gsd-core/bin/lib/health-diagnostic.cjs +431 -0
- package/gsd-core/bin/lib/host-runtime-detection.cjs +134 -0
- package/gsd-core/bin/lib/init.cjs +321 -129
- package/gsd-core/bin/lib/install-effort-resolver.cjs +73 -30
- package/gsd-core/bin/lib/install-engine.cjs +745 -258
- package/gsd-core/bin/lib/install-fs-adapter.cjs +262 -0
- package/gsd-core/bin/lib/install-model-override-resolver.cjs +203 -0
- package/gsd-core/bin/lib/install-profiles.cjs +134 -57
- package/gsd-core/bin/lib/install-scope.cjs +270 -0
- package/gsd-core/bin/lib/install-shadow-report.cjs +385 -0
- package/gsd-core/bin/lib/installed-surface-resolver.cjs +381 -0
- package/gsd-core/bin/lib/installer-migrations.cjs +138 -31
- package/gsd-core/bin/lib/io.cjs +10 -0
- package/gsd-core/bin/lib/markdown-sectionizer.cjs +2 -1
- package/gsd-core/bin/lib/markdown-table.cjs +133 -20
- package/gsd-core/bin/lib/milestone-lock.cjs +248 -0
- package/gsd-core/bin/lib/milestone.cjs +754 -70
- package/gsd-core/bin/lib/model-catalog.cjs +59 -1
- package/gsd-core/bin/lib/model-resolver.cjs +183 -40
- package/gsd-core/bin/lib/normalize-test-command.cjs +1 -1
- package/gsd-core/bin/lib/pattern.cjs +122 -0
- package/gsd-core/bin/lib/phase-estimation.cjs +1 -1
- package/gsd-core/bin/lib/phase-id.cjs +444 -36
- package/gsd-core/bin/lib/phase-lifecycle.cjs +28 -3
- package/gsd-core/bin/lib/phase-locator.cjs +125 -18
- package/gsd-core/bin/lib/phase.cjs +646 -143
- package/gsd-core/bin/lib/plan-dependency-graph.cjs +72 -1
- package/gsd-core/bin/lib/plan-drift-guard.cjs +120 -0
- package/gsd-core/bin/lib/plan-scan.cjs +86 -2
- package/gsd-core/bin/lib/planning-scope.cjs +31 -0
- package/gsd-core/bin/lib/planning-snapshot.cjs +890 -0
- package/gsd-core/bin/lib/planning-workspace.cjs +56 -6
- package/gsd-core/bin/lib/probe-core.cjs +1 -1
- package/gsd-core/bin/lib/profile-output.cjs +1 -1
- package/gsd-core/bin/lib/refactor-trigger-command-router.cjs +740 -0
- package/gsd-core/bin/lib/retired-artifact-cleanup.cjs +11 -6
- package/gsd-core/bin/lib/review-lane-descriptor.cjs +13 -4
- package/gsd-core/bin/lib/review-lane-invocation.cjs +30 -0
- package/gsd-core/bin/lib/review-lane-runner.cjs +421 -66
- package/gsd-core/bin/lib/review-reviewer-selection.cjs +13 -18
- package/gsd-core/bin/lib/roadmap-command-router.cjs +34 -0
- package/gsd-core/bin/lib/roadmap-parser.cjs +943 -184
- package/gsd-core/bin/lib/roadmap-upgrade.cjs +37 -10
- package/gsd-core/bin/lib/roadmap.cjs +385 -94
- package/gsd-core/bin/lib/runtime-artifact-conversion.cjs +608 -46
- package/gsd-core/bin/lib/runtime-artifact-install-plan.cjs +14 -2
- package/gsd-core/bin/lib/runtime-artifact-layout.cjs +426 -55
- package/gsd-core/bin/lib/runtime-config-adapter-registry.cjs +3 -2
- package/gsd-core/bin/lib/runtime-homes.cjs +69 -3
- package/gsd-core/bin/lib/runtime-hooks-surface.cjs +115 -3
- package/gsd-core/bin/lib/runtime-name-policy.cjs +3 -1
- package/gsd-core/bin/lib/runtime-slash.cjs +27 -9
- package/gsd-core/bin/lib/security.cjs +104 -5
- package/gsd-core/bin/lib/shell-command-projection.cjs +275 -3
- package/gsd-core/bin/lib/smart-entry.cjs +142 -22
- package/gsd-core/bin/lib/state-command-router.cjs +5 -1
- package/gsd-core/bin/lib/state-document.cjs +152 -8
- package/gsd-core/bin/lib/state-transition.cjs +371 -117
- package/gsd-core/bin/lib/state.cjs +1794 -357
- package/gsd-core/bin/lib/surface.cjs +23 -9
- package/gsd-core/bin/lib/text-lines.cjs +80 -0
- package/gsd-core/bin/lib/token-scanner.cjs +76 -0
- package/gsd-core/bin/lib/uat-predicate.cjs +9 -3
- package/gsd-core/bin/lib/uat.cjs +399 -56
- package/gsd-core/bin/lib/ui-frontend-evidence.cjs +157 -0
- package/gsd-core/bin/lib/ui-safety-gate.cjs +14 -5
- package/gsd-core/bin/lib/unusable-input.cjs +24 -0
- package/gsd-core/bin/lib/update-context.cjs +8 -2
- package/gsd-core/bin/lib/user-artifact-staging.cjs +705 -0
- package/gsd-core/bin/lib/validate.cjs +20 -6
- package/gsd-core/bin/lib/vendor/README.md +37 -0
- package/gsd-core/bin/lib/vendor/re2js.cjs +6480 -0
- package/gsd-core/bin/lib/vendor/re2js.d.cts +938 -0
- package/gsd-core/bin/lib/verification-command-router.cjs +2 -1
- package/gsd-core/bin/lib/verification.cjs +258 -8
- package/gsd-core/bin/lib/verify.cjs +368 -888
- package/gsd-core/bin/lib/workstream-inventory-builder.cjs +53 -32
- package/gsd-core/bin/lib/workstream-inventory.cjs +63 -10
- package/gsd-core/bin/lib/workstream.cjs +2 -2
- package/gsd-core/bin/lib/worktree-safety.cjs +176 -9
- package/gsd-core/bin/shared/config-defaults.manifest.json +1 -0
- package/gsd-core/bin/shared/config-schema.manifest.json +7 -1
- package/gsd-core/references/agent-contracts.md +43 -26
- package/gsd-core/references/checkpoints.md +2 -2
- package/gsd-core/references/context-budget.md +1 -1
- package/gsd-core/references/dispatch-isolation-gate.md +138 -0
- package/gsd-core/references/doc-conflict-engine.md +1 -1
- package/gsd-core/references/execute-mvp-tdd.md +3 -3
- package/gsd-core/references/execute-phase-between-wave-reset.md +6 -2
- package/gsd-core/references/execute-phase-context-guard.md +1 -1
- package/gsd-core/references/execute-phase-response-language.md +1 -1
- package/gsd-core/references/execute-phase-wave-guard.md +6 -2
- package/gsd-core/references/gate-prompts.md +1 -1
- package/gsd-core/references/git-planning-commit.md +2 -1
- package/gsd-core/references/loop-hook-dispatch.md +39 -2
- package/gsd-core/references/model-profiles.md +12 -4
- package/gsd-core/references/mvp-concepts.md +9 -9
- package/gsd-core/references/planner-guidance.md +3 -9
- package/gsd-core/references/planner-preconditions.md +1 -1
- package/gsd-core/references/planner-reviews.md +1 -1
- package/gsd-core/references/planning-config.md +8 -6
- package/gsd-core/references/revision-loop.md +1 -1
- package/gsd-core/references/specless-probe-fallback.md +1 -1
- package/gsd-core/references/universal-anti-patterns.md +3 -3
- package/gsd-core/references/verifier-phase-gates.md +192 -0
- package/gsd-core/references/verify-mvp-mode.md +1 -1
- package/gsd-core/references/workstream-flag.md +22 -6
- package/gsd-core/templates/discussion-log.md +1 -1
- package/gsd-core/templates/phase-prompt.md +2 -4
- package/gsd-core/templates/state.md +4 -4
- package/gsd-core/templates/verification-report.md +9 -1
- package/gsd-core/workflows/ai-integration-phase.md +9 -11
- package/gsd-core/workflows/autonomous.md +1 -1
- package/gsd-core/workflows/cleanup.md +62 -3
- package/gsd-core/workflows/code-review/steps/structural-pre-pass.md +13 -3
- package/gsd-core/workflows/code-review-fix.md +37 -10
- package/gsd-core/workflows/code-review.md +38 -12
- package/gsd-core/workflows/complete-milestone.md +141 -18
- package/gsd-core/workflows/debug.md +7 -5
- package/gsd-core/workflows/diagnose-issues.md +35 -9
- package/gsd-core/workflows/discuss-phase/modes/chain.md +2 -1
- package/gsd-core/workflows/discuss-phase/modes/default.md +1 -1
- package/gsd-core/workflows/discuss-phase-assumptions.md +2 -1
- package/gsd-core/workflows/edit-phase.md +26 -1
- package/gsd-core/workflows/eval-review.md +3 -5
- package/gsd-core/workflows/execute-phase/steps/executor-isolation-dispatch.md +31 -6
- package/gsd-core/workflows/execute-phase/steps/per-plan-executor-routing.md +77 -0
- package/gsd-core/workflows/execute-phase/steps/per-plan-worktree-gate.md +2 -0
- package/gsd-core/workflows/execute-phase.md +38 -50
- package/gsd-core/workflows/execute-plan.md +36 -4
- package/gsd-core/workflows/explore.md +131 -4
- package/gsd-core/workflows/fast.md +10 -2
- package/gsd-core/workflows/health.md +73 -4
- package/gsd-core/workflows/import.md +4 -4
- package/gsd-core/workflows/ingest-docs.md +5 -5
- package/gsd-core/workflows/mvp-phase.md +6 -3
- package/gsd-core/workflows/new-milestone.md +14 -9
- package/gsd-core/workflows/new-project.md +14 -14
- package/gsd-core/workflows/next.md +12 -0
- package/gsd-core/workflows/plan-phase.md +41 -17
- package/gsd-core/workflows/plan-review-convergence.md +50 -2
- package/gsd-core/workflows/progress.md +34 -6
- package/gsd-core/workflows/quick/steps/plan-checker-loop.md +4 -4
- package/gsd-core/workflows/quick/steps/quick-verification.md +27 -6
- package/gsd-core/workflows/quick/steps/research-phase.md +2 -2
- package/gsd-core/workflows/quick.md +35 -15
- package/gsd-core/workflows/review.md +26 -5
- package/gsd-core/workflows/secure-phase.md +1 -1
- package/gsd-core/workflows/session-report.md +2 -1
- package/gsd-core/workflows/settings.md +66 -2
- package/gsd-core/workflows/ship.md +104 -44
- package/gsd-core/workflows/spec-phase.md +30 -12
- package/gsd-core/workflows/sync-skills.md +63 -8
- package/gsd-core/workflows/transition.md +46 -11
- package/gsd-core/workflows/ui-phase.md +5 -5
- package/gsd-core/workflows/ui-review.md +2 -2
- package/gsd-core/workflows/update.md +1 -1
- package/gsd-core/workflows/validate-phase.md +1 -1
- package/gsd-core/workflows/verify-work.md +9 -7
- package/hooks/dist/gsd-agent-isolation-guard.js +103 -14
- package/hooks/dist/gsd-check-update-worker.js +56 -13
- package/hooks/dist/gsd-check-update.js +19 -1
- package/hooks/dist/gsd-cursor-pre-tool.js +0 -3
- package/hooks/dist/gsd-cursor-subagent-start.js +77 -2
- package/hooks/dist/gsd-cursor-subagent-stop.js +3 -2
- package/hooks/dist/gsd-prompt-guard.js +21 -20
- package/hooks/dist/gsd-read-injection-scanner.js +38 -24
- package/hooks/dist/gsd-statusline.js +18 -0
- package/hooks/dist/gsd-update-banner.js +22 -1
- package/hooks/dist/gsd-workflow-guard.js +134 -36
- package/hooks/dist/lib/git-cmd.js +92 -59
- package/hooks/dist/lib/injection-patterns.js +45 -0
- package/hooks/dist/lib/isolation-deny-reason.js +39 -0
- package/hooks/dist/lib/isolation-sentinel.js +9 -0
- package/hooks/gsd-agent-isolation-guard.js +103 -14
- package/hooks/gsd-check-update-worker.js +56 -13
- package/hooks/gsd-check-update.js +19 -1
- package/hooks/gsd-cursor-pre-tool.js +0 -3
- package/hooks/gsd-cursor-subagent-start.js +77 -2
- package/hooks/gsd-cursor-subagent-stop.js +3 -2
- package/hooks/gsd-prompt-guard.js +21 -20
- package/hooks/gsd-read-injection-scanner.js +38 -24
- package/hooks/gsd-statusline.js +18 -0
- package/hooks/gsd-update-banner.js +22 -1
- package/hooks/gsd-workflow-guard.js +134 -36
- package/hooks/lib/git-cmd.js +92 -59
- package/hooks/lib/injection-patterns.js +45 -0
- package/hooks/lib/isolation-deny-reason.js +39 -0
- package/hooks/lib/isolation-sentinel.js +9 -0
- package/package.json +21 -9
- package/pi/gsd.cjs +19 -5
- package/scripts/baselines/planning-prompt-drift-baseline.json +4 -0
- package/scripts/baselines/planning-snapshot-bypass-baseline.json +12 -0
- package/scripts/baselines/unreachable-guard-drift-baseline.json +4 -0
- package/scripts/changeset/lint.cjs +60 -5
- package/scripts/check-alias-drift.cjs +7 -43
- package/scripts/check-contract-drift.cjs +297 -0
- package/scripts/ci-test-scope.cjs +19 -2
- package/scripts/command-contract-helpers.cjs +903 -1
- package/scripts/gen-adr-index.cjs +728 -38
- package/scripts/gen-capability-registry.cjs +3 -15
- package/scripts/gen-context-index.cjs +2 -11
- package/scripts/gen-health-docs.cjs +390 -0
- package/scripts/gen-inventory-manifest.cjs +50 -4
- package/scripts/gen-loop-host-contract.cjs +4 -24
- package/scripts/gen-registry.cjs +3 -14
- package/scripts/lib/alias-drift-families.cjs +46 -0
- package/scripts/lib/drift-scan.cjs +278 -0
- package/scripts/lint-allow-test-rule-refs.allowlist.json +1 -26
- package/scripts/lint-allow-test-rule-refs.effective-ceiling.json +4 -0
- package/scripts/lint-allow-test-rule-refs.unverified-ceiling.json +3 -0
- package/scripts/lint-canary-version-leak.cjs +73 -0
- package/scripts/lint-command-contract.cjs +96 -13
- package/scripts/lint-completion-predicate-drift.cjs +933 -0
- package/scripts/lint-completion-ratio-drift.cjs +214 -0
- package/scripts/lint-default-flip-documentation.cjs +193 -0
- package/scripts/lint-eslint-glob-coverage.allowlist.json +34 -0
- package/scripts/lint-eslint-glob-coverage.cjs +340 -0
- package/scripts/lint-frontmatter-scalar-broad-grep.cjs +237 -0
- package/scripts/lint-health-diagnostic-rule-table.cjs +404 -0
- package/scripts/lint-hooks-runtime-build-seam.cjs +262 -0
- package/scripts/lint-milestone-window-drift.cjs +468 -0
- package/scripts/lint-phase-enumeration-drift.cjs +479 -0
- package/scripts/lint-plan-count-drift.cjs +318 -0
- package/scripts/lint-planning-artifact-writer-drift.cjs +398 -0
- package/scripts/lint-planning-prompt-drift.cjs +434 -0
- package/scripts/lint-planning-snapshot-bypass-drift.cjs +544 -0
- package/scripts/lint-regression-test-names.cjs +15 -13
- package/scripts/lint-removed-but-needed.cjs +320 -0
- package/scripts/lint-state-field-drift.cjs +805 -0
- package/scripts/lint-state-write-path-drift.cjs +1045 -0
- package/scripts/lint-test-file-count.allowlist.json +21 -10
- package/scripts/lint-unreachable-guard-drift.cjs +843 -0
- package/scripts/lint-vendored-deps.cjs +124 -0
- package/scripts/pr-changed-files.cjs +63 -0
- package/scripts/pr-template-policy.cjs +14 -4
- package/scripts/prompt-injection-scan.sh +25 -0
- package/scripts/require-issue-link-policy.cjs +192 -0
- package/scripts/state-write-path-drift-baseline.json +19 -0
- package/scripts/sync-runtime-launcher.cjs +2 -4
- package/skills/gsd-autonomous/SKILL.md +0 -1
- package/skills/gsd-code-review/SKILL.md +1 -1
- package/skills/gsd-execute-phase/SKILL.md +1 -2
- package/skills/gsd-map-codebase/SKILL.md +1 -1
- package/skills/gsd-mempalace-capture/SKILL.md +1 -1
- package/skills/gsd-mempalace-recall/SKILL.md +1 -1
- package/skills/gsd-new-milestone/SKILL.md +1 -1
- package/skills/gsd-next/SKILL.md +0 -1
- package/skills/gsd-plan-phase/SKILL.md +0 -1
- package/skills/gsd-progress/SKILL.md +0 -1
- package/skills/gsd-quick/SKILL.md +1 -1
- package/skills/gsd-review-backlog/SKILL.md +2 -1
- package/skills/gsd-stats/SKILL.md +0 -1
- package/skills/gsd-verify-work/SKILL.md +1 -1
- package/vscode/package.json +1 -1
- package/gsd-core/workflows/discovery-phase.md +0 -298
- package/gsd-core/workflows/plan-milestone-gaps.md +0 -281
- package/gsd-core/workflows/verify-phase.md +0 -574
- package/scripts/affected-tests-lib.cjs +0 -554
- package/scripts/lint-allow-test-rule-refs.cjs +0 -162
- package/scripts/run-affected-tests.cjs +0 -7
- package/scripts/run-tests.cjs +0 -1051
|
@@ -36,7 +36,7 @@ Configuration options for `.planning/` directory behavior.
|
|
|
36
36
|
| `git.quick_branch_template` | `null` | Optional branch template for quick-task runs |
|
|
37
37
|
| `workflow.use_worktrees` | `true` | Whether executor agents run in isolated git worktrees. Set to `false` to disable worktrees — agents execute sequentially on the main working tree instead. Recommended for solo developers or when worktree merges cause issues. Note: if your branch is ahead of `origin/HEAD` (a diverged milestone or feature branch), GSD auto-degrades to sequential and prints a warning; set `worktree.baseRef:"head"` in `.claude/settings.local.json` to restore parallel execution. See the branch-divergence note below. |
|
|
38
38
|
| `workflow.subagent_timeout` | `300000` | Timeout in milliseconds for parallel subagent tasks (e.g. codebase mapping). Increase for large codebases or slower models. Default: 300000 (5 minutes). |
|
|
39
|
-
| `workflow.test_command` | `null` | Custom shell command run as the regression/test gate by
|
|
39
|
+
| `workflow.test_command` | `null` | Custom shell command run as the regression/test gate by execute-phase, audit-fix, and post-merge-gate. When unset, GSD auto-detects (Makefile / package.json / Cargo.toml / go.mod / pyproject.toml). Example: `npm test`. |
|
|
40
40
|
| `workflow.build_command` | `null` | Custom shell command run as the build gate by the post-merge gate. When unset, the build step is skipped/auto-detected. Example: `npm run build`. |
|
|
41
41
|
| `workflow.inline_plan_threshold` | `2` | Plans with this many tasks or fewer execute inline (Pattern C) instead of spawning a subagent. Avoids ~14K token spawn overhead for small plans. Set to `0` to always spawn subagents. |
|
|
42
42
|
| `manager.flags.discuss` | `""` | Flags passed to `/gsd:discuss-phase` when dispatched from manager (e.g. `"--auto --analyze"`) |
|
|
@@ -76,6 +76,8 @@ if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi
|
|
|
76
76
|
|
|
77
77
|
**Auto-detection:** If `.planning/` is gitignored, `commit_docs` is automatically `false` regardless of config.json. This prevents git errors when users have `.planning/` in `.gitignore`.
|
|
78
78
|
|
|
79
|
+
**Per-phase override:** `phase_commit_docs.<phase-id>` (e.g. `phase_commit_docs.03`) overrides `commit_docs` for one phase only, and wins over both the explicit config value and gitignore auto-detection — see `docs/CONFIGURATION.md#per-phase-override-phase_commit_docs` for the full precedence chain and examples.
|
|
80
|
+
|
|
79
81
|
**Commit via CLI (handles checks automatically):**
|
|
80
82
|
|
|
81
83
|
```bash
|
|
@@ -266,7 +268,7 @@ Set via `workflow.*` namespace in config.json (e.g., `"workflow": { "research":
|
|
|
266
268
|
| `workflow.skip_discuss` | boolean | `false` | `true`, `false` | Skip discuss phase entirely |
|
|
267
269
|
| `workflow.use_worktrees` | boolean | `true` | `true`, `false` | Run executor agents in isolated git worktrees |
|
|
268
270
|
| `workflow.subagent_timeout` | number | `300000` | Any positive integer (ms) | Timeout for parallel subagent tasks (default: 5 minutes) |
|
|
269
|
-
| `workflow.test_command` | string\|null | `null` | Any shell command | Regression/test gate command run by
|
|
271
|
+
| `workflow.test_command` | string\|null | `null` | Any shell command | Regression/test gate command run by execute-phase, audit-fix, and post-merge-gate. Unset → GSD auto-detects (Makefile / package.json / Cargo.toml / go.mod / pyproject.toml). |
|
|
270
272
|
| `workflow.build_command` | string\|null | `null` | Any shell command | Build gate command run by the post-merge gate. Unset → build step auto-detected/skipped. |
|
|
271
273
|
| `workflow.mvp_mode` | boolean | `false` | `true`, `false` | Persist the MVP-mode flag in config so every phase defaults to MVP framing without requiring `--mvp` on the CLI. Resolved via the chain: `--mvp` CLI flag → ROADMAP.md `**Mode:** mvp` field → this config value → `false`. When `true`, the planner, executor, verifier, and discovery surfaces (progress, stats, graphify) all treat the phase as an MVP vertical slice (UI → API → DB) of one user-visible capability. |
|
|
272
274
|
| `workflow.context_guard_mode` | string | `"warn"` | `"auto"`, `"warn"`, `"off"` | Context exhaustion guard mode for `execute-phase`. Before each wave, the orchestrator self-assesses context pressure using degradation signals from `context-budget.md`. `"warn"` (default): emit a warning and recommend `/gsd:pause-work` when POOR tier is detected. `"auto"`: automatically invoke `/gsd:pause-work` before the next wave when POOR tier is detected. `"off"`: disable the guard. The guard is heuristic — no programmatic context-% API exists. |
|
|
@@ -275,7 +277,7 @@ Set via `workflow.*` namespace in config.json (e.g., `"workflow": { "research":
|
|
|
275
277
|
| `workflow.code_review_command` | string\|null | `null` | Any shell command | External code-review command integrated into `/gsd:ship`. The diff is piped to the command via stdin; the command must output JSON with a `verdict` field (`"APPROVED"` or `"REVISE"`). Non-zero exit or `"REVISE"` verdict blocks the ship workflow. When unset, the built-in review flow runs. Example: `my-review-tool --review`. |
|
|
276
278
|
| `workflow.inline_plan_threshold` | number | `2` | `0`–`10` | Plans with ≤N tasks execute inline instead of spawning a subagent |
|
|
277
279
|
| `workflow.code_review` | boolean | `true` | `true`, `false` | Enable built-in code review step in the ship workflow |
|
|
278
|
-
| `workflow.code_review_depth` | string | `"standard"` | `"
|
|
280
|
+
| `workflow.code_review_depth` | string | `"standard"` | `"quick"`, `"standard"`, `"deep"` | Depth level for code review analysis in the ship workflow |
|
|
279
281
|
| `workflow._auto_chain_active` | boolean | `false` | `true`, `false` | Internal: tracks whether autonomous chaining is active |
|
|
280
282
|
| `workflow.security_enforcement` | boolean | `true` | `true`, `false` | Enable threat-model-anchored security verification via `/gsd:secure-phase`. When `false`, security checks are skipped entirely |
|
|
281
283
|
| `workflow.security_asvs_level` | number | `1` | `1`, `2`, `3` | OWASP ASVS verification level. Level 1 = opportunistic, Level 2 = standard, Level 3 = comprehensive. Scales both planner threat-disposition rigor (which threats must be mitigated vs. accepted) and auditor verification depth (grep-level → boundary-placement check → full data-flow trace). See `gsd-core/references/security-asvs-levels.md`. |
|
|
@@ -362,7 +364,7 @@ Set via `manager.*` namespace (e.g., `"manager": { "flags": { "discuss": "--auto
|
|
|
362
364
|
|-----|------|---------|----------------|-------------|
|
|
363
365
|
| `parallelization` | boolean\|object | `true` | `true`, `false`, `{ "enabled": true }` | Enable parallel wave execution; object form allows additional sub-keys |
|
|
364
366
|
| `model_overrides` | object\|null | `null` | `{ "<agent-type>": "<model-id>" }` | Override model selection per agent type |
|
|
365
|
-
| `agent_skills` | object | `{}` | `{ "<agent-type>": "<skill-set>" }` | Assign skill sets to specific agent types |
|
|
367
|
+
| `agent_skills` | object | `{}` | `{ "<agent-type>": "<skill-set>" }` or `{ "<agent-type>": ["<skill-set>", "<skill-set>", ...] }` | Assign skill sets to specific agent types. Each value is a single skill-set path (string) or an array of skill-set paths — the array form assigns multiple skill sets to one agent type. Paths cannot be comma-joined into one string; each path must be its own array element |
|
|
366
368
|
| `sub_repos` | array | `[]` | Array of relative path strings | Child directories with independent `.git` repos (auto-detected) |
|
|
367
369
|
|
|
368
370
|
### Planning Fields
|
|
@@ -380,7 +382,7 @@ These can be set at top level or nested under `planning.*` (e.g., `"planning": {
|
|
|
380
382
|
|
|
381
383
|
Several config fields affect each other or trigger special behavior:
|
|
382
384
|
|
|
383
|
-
1. **`commit_docs`
|
|
385
|
+
1. **`commit_docs` resolution chain** -- Four tiers, highest wins: (1) `phase_commit_docs.<phase-id>` for the phase being committed, (2) an explicit `commit_docs` (or `planning.commit_docs`) value in config.json, (3) `.gitignore` auto-detection (`.planning/` in `.gitignore` resolves to `false`), (4) the manifest default (`true`). Precedence: per-phase → explicit config → gitignore auto-detect → default.
|
|
384
386
|
|
|
385
387
|
2. **`branching_strategy` controls branch templates** -- The `phase_branch_template` and `milestone_branch_template` fields are only used when `branching_strategy` is set to `"phase"` or `"milestone"` respectively. When `branching_strategy` is `"none"`, all template fields are ignored.
|
|
386
388
|
|
|
@@ -396,7 +398,7 @@ Several config fields affect each other or trigger special behavior:
|
|
|
396
398
|
|
|
397
399
|
8. **`sub_repos` auto-sync** -- On every config load, GSD scans for child directories with `.git` and updates the `sub_repos` array if the filesystem has changed. Legacy `multiRepo: true` is automatically migrated to a detected `sub_repos` array.
|
|
398
400
|
|
|
399
|
-
9. **`workflow.use_worktrees` and branch divergence** -- When `use_worktrees` is `true` (default), executor worktrees are forked from `origin/HEAD` -- by the host's own harness on `dispatch.isolation: harness-worktree` runtimes (Claude Code, Cursor), or by GSD itself on `orchestrator-worktree` runtimes (Codex, OpenCode, Kimi, Kimi Code). The divergence behavior below is identical either way, because the fork base is a property of the repository rather than of whoever creates the worktree. If your current branch has commits that `origin/HEAD` does not (for example an unmerged milestone or feature branch), GSD automatically degrades to sequential execution for that run and prints a one-line `⚠ Worktree base mismatch` warning. To restore parallel execution permanently, set `worktree.baseRef:"head"` in `.claude/settings.local.json` (run `node gsd-tools.cjs worktree set-baseref`). This makes the harness fork worktrees from the live HEAD instead of `origin/HEAD`. Both fresh installs and upgrades of GSD Core set this automatically (no-clobber) when `use_worktrees` is enabled; you can also run the command manually at any time. Setting `workflow.use_worktrees: false` is the alternative if worktrees are not needed at all.
|
|
401
|
+
9. **`workflow.use_worktrees` and branch divergence** -- When `use_worktrees` is `true` (default), executor worktrees are forked from `origin/HEAD` -- by the host's own harness on `dispatch.isolation: harness-worktree` runtimes (Claude Code, Cursor), or by GSD itself on `orchestrator-worktree` runtimes (Codex, OpenCode, Kimi, Kimi Code). The divergence behavior below is identical either way, because the fork base is a property of the repository rather than of whoever creates the worktree. If your current branch has commits that `origin/HEAD` does not (for example an unmerged milestone or feature branch), GSD automatically degrades to sequential execution for that run and prints a one-line `⚠ Worktree base mismatch` warning. To restore parallel execution permanently, set `worktree.baseRef:"head"` in `.claude/settings.local.json` (run `node gsd-tools.cjs worktree set-baseref`). This makes the harness fork worktrees from the live HEAD instead of `origin/HEAD`. Both fresh installs and upgrades of GSD Core set this automatically (no-clobber) when `use_worktrees` is enabled; you can also run the command manually at any time. Setting `workflow.use_worktrees: false` is the alternative if worktrees are not needed at all. On a runtime whose declared `dispatch.isolation` is `none`, an explicit `true` is a config the execution workflows fail closed on; `/gsd:health` reports it as warning `W025` and `/gsd:settings` offers to repair it (#2486).
|
|
400
402
|
|
|
401
403
|
---
|
|
402
404
|
|
|
@@ -70,7 +70,7 @@ issues. You must reduce the count or the loop will terminate.
|
|
|
70
70
|
If issues persist after 3 revision cycles:
|
|
71
71
|
|
|
72
72
|
1. Present remaining issues to the user
|
|
73
|
-
2. Use gate prompt (pattern: yes-no from `references/gate-prompts.md`):
|
|
73
|
+
2. Use gate prompt (pattern: yes-no from `gsd-core/references/gate-prompts.md`):
|
|
74
74
|
question: "Issues remain after 3 revision attempts. Proceed with current output?"
|
|
75
75
|
header: "Proceed?"
|
|
76
76
|
options:
|
|
@@ -127,7 +127,7 @@ verification: backstop }` in `must_haves.truths`, NOT a prose note (the verifier
|
|
|
127
127
|
deterministically on the `verification: backstop` field; a parenthetical is unparseable — the #1110
|
|
128
128
|
fragility; flat scalar `verification:` key, never a nested object, ADR-550 #1278). A `backstop` truth
|
|
129
129
|
the verifier cannot confirm with explicit evidence abstains → `human_needed` (reason
|
|
130
|
-
`insufficient_spec`), never a silent pass (#1154; `references/honest-verifier.md`). **Never
|
|
130
|
+
`insufficient_spec`), never a silent pass (#1154; `gsd-core/references/honest-verifier.md`). **Never
|
|
131
131
|
auto-dismiss** (a wrong dismissal is the exact silent failure this eliminates). An `unclassified` row
|
|
132
132
|
stays **`unresolved`** (#1110) — never auto-resolved with backstop — and is surfaced to the planner as a flagged
|
|
133
133
|
assumption. Pass `$COVERAGE` (+ the gate's `$SPECLESS_FALLBACK_DISABLED` note) into the gsd-planner
|
|
@@ -8,7 +8,7 @@ Rules that apply to ALL workflows and agents. Individual workflows may have addi
|
|
|
8
8
|
|
|
9
9
|
1. **Never** read agent definition files (`agents/*.md`) -- `subagent_type` auto-loads them. Reading agent definitions into the orchestrator wastes context for content automatically injected into subagent sessions.
|
|
10
10
|
2. **Never** inline large files into subagent prompts -- tell agents to read files from disk instead. Agents have their own context windows.
|
|
11
|
-
3. **Read depth scales with context window** -- check `context_window` in `.planning/config.json`. At < 500000: read only frontmatter, status fields, or summaries. At >= 500000 (1M model): full body reads permitted when content is needed for inline decisions. See `references/context-budget.md` for the complete table.
|
|
11
|
+
3. **Read depth scales with context window** -- check `context_window` in `.planning/config.json`. At < 500000: read only frontmatter, status fields, or summaries. At >= 500000 (1M model): full body reads permitted when content is needed for inline decisions. See `gsd-core/references/context-budget.md` for the complete table.
|
|
12
12
|
4. **Delegate** heavy work to subagents -- the orchestrator routes, it does not build, analyze, research, investigate, or verify.
|
|
13
13
|
5. **Proactive pause warning**: If you have already consumed significant context (large file reads, multiple subagent results), warn the user: "Context budget is getting heavy. Consider checkpointing progress."
|
|
14
14
|
|
|
@@ -26,7 +26,7 @@ Rules that apply to ALL workflows and agents. Individual workflows may have addi
|
|
|
26
26
|
|
|
27
27
|
## Questioning Anti-Patterns
|
|
28
28
|
|
|
29
|
-
Reference: `references/questioning.md` for the full anti-pattern list.
|
|
29
|
+
Reference: `gsd-core/references/questioning.md` for the full anti-pattern list.
|
|
30
30
|
|
|
31
31
|
12. **Do not** walk through checklists -- checklist walking (asking items one by one from a list) is the #1 anti-pattern. Instead, use progressive depth: start broad, dig where interesting.
|
|
32
32
|
13. **Do not** use corporate speak -- avoid jargon like "stakeholder alignment", "synergize", "deliverables". Use plain language.
|
|
@@ -59,5 +59,5 @@ Reference: `references/questioning.md` for the full anti-pattern list.
|
|
|
59
59
|
|
|
60
60
|
## iOS / Apple Platform Rules
|
|
61
61
|
|
|
62
|
-
28. **NEVER use `Package.swift` + `.executableTarget` (or `.target`) as the primary build system for iOS apps.** SPM executable targets produce macOS CLI binaries, not iOS `.app` bundles. They cannot be installed on iOS devices or submitted to the App Store. Use XcodeGen (`project.yml` + `xcodegen generate`) to create a proper `.xcodeproj`. See `references/ios-scaffold.md` for the full pattern.
|
|
62
|
+
28. **NEVER use `Package.swift` + `.executableTarget` (or `.target`) as the primary build system for iOS apps.** SPM executable targets produce macOS CLI binaries, not iOS `.app` bundles. They cannot be installed on iOS devices or submitted to the App Store. Use XcodeGen (`project.yml` + `xcodegen generate`) to create a proper `.xcodeproj`. See `gsd-core/references/ios-scaffold.md` for the full pattern.
|
|
63
63
|
29. **Verify SwiftUI API availability before use.** Many SwiftUI APIs require a specific minimum iOS version (e.g., `NavigationSplitView` is iOS 16+, `List(selection:)` with multi-select and `@Observable` require iOS 17). If a plan uses an API that exceeds the declared `IPHONEOS_DEPLOYMENT_TARGET`, raise the deployment target or add `#available` guards.
|
|
@@ -0,0 +1,192 @@
|
|
|
1
|
+
# Verifier Phase Gates
|
|
2
|
+
|
|
3
|
+
> Loaded eagerly by `agents/gsd-verifier.md` (`<required_reading>`). Carries the three
|
|
4
|
+
> verification-time gates that lived in the retired `verify-phase` workflow
|
|
5
|
+
> (#1892 / epic #1891 F7): decision-coverage validation (#2492), the test-quality audit,
|
|
6
|
+
> and infrastructure-phase human-verification scoping (#2504) — plus the backstop-abstention
|
|
7
|
+
> reporting contract (#3206). Run each gate at its named
|
|
8
|
+
> agent step; `gsd_run` is the launcher shim defined in the agent's own Step 1 block.
|
|
9
|
+
|
|
10
|
+
## verify_decisions — Decision Coverage Gate (run after Step 6, requirements coverage)
|
|
11
|
+
|
|
12
|
+
<step name="verify_decisions">
|
|
13
|
+
**Decision coverage validation gate (issue #2492).**
|
|
14
|
+
|
|
15
|
+
After requirements coverage, also check that each trackable CONTEXT.md
|
|
16
|
+
`<decisions>` entry shows up somewhere in the shipped artifacts (plans,
|
|
17
|
+
SUMMARY.md, files modified by the phase, or recent commit subjects on the
|
|
18
|
+
phase branch).
|
|
19
|
+
|
|
20
|
+
This gate is **non-blocking / warning only** by deliberate asymmetry with
|
|
21
|
+
the plan-phase translation gate. The plan-phase gate already blocked at
|
|
22
|
+
translation time, so by the time verification runs every decision has
|
|
23
|
+
either been translated or explicitly deferred. This gate's job is to
|
|
24
|
+
surface decisions that *were* translated but vanished during execution —
|
|
25
|
+
that's a soft signal because "honors a decision" is a fuzzy substring
|
|
26
|
+
heuristic, and we don't want a paraphrase miss to fail an otherwise good
|
|
27
|
+
phase.
|
|
28
|
+
|
|
29
|
+
**Skip if** `workflow.context_coverage_gate` is explicitly set to `false`
|
|
30
|
+
(absent key = enabled). Also skip cleanly when CONTEXT.md is missing or has
|
|
31
|
+
no `<decisions>` block.
|
|
32
|
+
|
|
33
|
+
```bash
|
|
34
|
+
GATE_CFG=$(gsd_run query config-get workflow.context_coverage_gate 2>/dev/null || echo "true")
|
|
35
|
+
if [ "$GATE_CFG" != "false" ]; then
|
|
36
|
+
CONTEXT_PATH=$(ls "${PHASE_DIR}"/*-CONTEXT.md 2>/dev/null | head -1) # #2962: not a for-glob (zsh aborts)
|
|
37
|
+
DECISION_RESULT=$(gsd_run query check.decision-coverage-verify "${PHASE_DIR}" "${CONTEXT_PATH}")
|
|
38
|
+
fi
|
|
39
|
+
```
|
|
40
|
+
|
|
41
|
+
The handler returns JSON `{ skipped, blocking: false, total, honored,
|
|
42
|
+
not_honored: [...], message }`.
|
|
43
|
+
|
|
44
|
+
**Reporting:** Append the handler's `message` (a `### Decision Coverage`
|
|
45
|
+
section) to VERIFICATION.md regardless of outcome — even when all
|
|
46
|
+
decisions are honored, recording the count helps reviewers spot drift over
|
|
47
|
+
time. Set `decision_coverage` in the verification result to
|
|
48
|
+
`{honored, total, not_honored: [...]}` so downstream tooling can read it.
|
|
49
|
+
|
|
50
|
+
**Status impact:** none. The decision gate does NOT influence the
|
|
51
|
+
`gaps_found` / `human_needed` / `passed` decision tree in Step 9. Its
|
|
52
|
+
findings are warnings the user reviews and may act on by re-opening the
|
|
53
|
+
phase or by acknowledging the decision was abandoned intentionally.
|
|
54
|
+
</step>
|
|
55
|
+
|
|
56
|
+
## audit_test_quality (run after Step 7b, alongside anti-patterns)
|
|
57
|
+
|
|
58
|
+
<step name="audit_test_quality">
|
|
59
|
+
**Verify that tests PROVE what they claim to prove.**
|
|
60
|
+
|
|
61
|
+
This step catches test-level deceptions that pass all prior checks: files exist, are substantive, are wired, and tests pass — but the tests don't actually validate the requirement.
|
|
62
|
+
|
|
63
|
+
**1. Identify requirement-linked test files**
|
|
64
|
+
|
|
65
|
+
From PLAN and SUMMARY files, map each requirement to the test files that are supposed to prove it.
|
|
66
|
+
|
|
67
|
+
**2. Disabled test scan**
|
|
68
|
+
|
|
69
|
+
For ALL test files linked to requirements, search for disabled/skipped patterns:
|
|
70
|
+
|
|
71
|
+
```bash
|
|
72
|
+
grep -rn -E "it\.skip|describe\.skip|test\.skip|xit\(|xdescribe\(|xtest\(|@pytest\.mark\.skip|@unittest\.skip|#\[ignore\]|\.pending|it\.todo|test\.todo" "$TEST_FILE"
|
|
73
|
+
```
|
|
74
|
+
|
|
75
|
+
**Rule:** A disabled test linked to a requirement = requirement NOT tested.
|
|
76
|
+
- 🛑 BLOCKER if the disabled test is the only test proving that requirement
|
|
77
|
+
- ⚠️ WARNING if other active tests also cover the requirement
|
|
78
|
+
|
|
79
|
+
**3. Circular test detection**
|
|
80
|
+
|
|
81
|
+
Search for scripts/utilities that generate expected values by running the system under test:
|
|
82
|
+
|
|
83
|
+
```bash
|
|
84
|
+
grep -rn -E "writeFileSync|writeFile|fs\.write|open\(.*w\)" "$TEST_DIRS"
|
|
85
|
+
```
|
|
86
|
+
|
|
87
|
+
For each match, check if it also imports the system/service/module being tested. If a script both imports the system-under-test AND writes expected output values → CIRCULAR.
|
|
88
|
+
|
|
89
|
+
**Circular test indicators:**
|
|
90
|
+
- Script imports a service AND writes to fixture files
|
|
91
|
+
- Expected values have comments like "computed from engine", "captured from baseline"
|
|
92
|
+
- Script filename contains "capture", "baseline", "generate", "snapshot" in test context
|
|
93
|
+
- Expected values were added in the same commit as the test assertions
|
|
94
|
+
|
|
95
|
+
**Rule:** A test comparing system output against values generated by the same system is circular. It proves consistency, not correctness.
|
|
96
|
+
|
|
97
|
+
**4. Expected value provenance** (for comparison/parity/migration requirements)
|
|
98
|
+
|
|
99
|
+
When a requirement demands comparison with an external source ("identical to X", "matches Y", "same output as Z"):
|
|
100
|
+
|
|
101
|
+
- Is the external source actually invoked or referenced in the test pipeline?
|
|
102
|
+
- Do fixture files contain data sourced from the external system?
|
|
103
|
+
- Or do all expected values come from the new system itself or from mathematical formulas?
|
|
104
|
+
|
|
105
|
+
**Provenance classification:**
|
|
106
|
+
- VALID: Expected value from external/legacy system output, manual capture, or independent oracle
|
|
107
|
+
- PARTIAL: Expected value from mathematical derivation (proves formula, not system match)
|
|
108
|
+
- CIRCULAR: Expected value from the system being tested
|
|
109
|
+
- UNKNOWN: No provenance information — treat as SUSPECT
|
|
110
|
+
|
|
111
|
+
**5. Assertion strength**
|
|
112
|
+
|
|
113
|
+
For each test linked to a requirement, classify the strongest assertion:
|
|
114
|
+
|
|
115
|
+
| Level | Examples | Proves |
|
|
116
|
+
|-------|---------|--------|
|
|
117
|
+
| Existence | `toBeDefined()`, `!= null` | Something returned |
|
|
118
|
+
| Type | `typeof x === 'number'` | Correct shape |
|
|
119
|
+
| Status | `code === 200` | No error |
|
|
120
|
+
| Value | `toEqual(expected)`, `toBeCloseTo(x)` | Specific value |
|
|
121
|
+
| Behavioral | Multi-step workflow assertions | End-to-end correctness |
|
|
122
|
+
|
|
123
|
+
If a requirement demands value-level or behavioral-level proof and the test only has existence/type/status assertions → INSUFFICIENT.
|
|
124
|
+
|
|
125
|
+
**6. Coverage quantity**
|
|
126
|
+
|
|
127
|
+
If a requirement specifies a quantity of test cases (e.g., "30 calculations"), check if the actual number of active (non-skipped) test cases meets the requirement.
|
|
128
|
+
|
|
129
|
+
**Reporting — add to VERIFICATION.md:**
|
|
130
|
+
|
|
131
|
+
```markdown
|
|
132
|
+
### Test Quality Audit
|
|
133
|
+
|
|
134
|
+
| Test File | Linked Req | Active | Skipped | Circular | Assertion Level | Verdict |
|
|
135
|
+
|-----------|-----------|--------|---------|----------|-----------------|---------|
|
|
136
|
+
|
|
137
|
+
**Disabled tests on requirements:** {N} → {BLOCKER if any req has ONLY disabled tests}
|
|
138
|
+
**Circular patterns detected:** {N} → {BLOCKER if any}
|
|
139
|
+
**Insufficient assertions:** {N} → {WARNING}
|
|
140
|
+
```
|
|
141
|
+
|
|
142
|
+
**Impact on status:** Any BLOCKER from test quality audit → overall status = `gaps_found` (Step 9 rule 1), regardless of other checks passing.
|
|
143
|
+
</step>
|
|
144
|
+
|
|
145
|
+
## identify_human_verification — infrastructure/foundation scoping (apply at Step 8)
|
|
146
|
+
|
|
147
|
+
**First: determine if this is an infrastructure/foundation phase.**
|
|
148
|
+
|
|
149
|
+
Infrastructure and foundation phases — code foundations, database schema, internal APIs, data models, build tooling, CI/CD, internal service integrations — have no user-facing elements by definition. For these phases:
|
|
150
|
+
|
|
151
|
+
- Do NOT invent artificial manual steps (e.g., "manually run git commits", "manually invoke methods", "manually check database state").
|
|
152
|
+
- Mark human verification as **N/A** with rationale: "Infrastructure/foundation phase — no user-facing elements to test manually."
|
|
153
|
+
- Set `human_verification: []` and do **not** produce a `human_needed` status solely due to lack of user-facing features.
|
|
154
|
+
- Only add human verification items if the phase goal or success criteria explicitly describe something a user would interact with (UI, CLI command output visible to end users, external service UX).
|
|
155
|
+
- **Exception — behavior-unverified truths still count.** A truth marked ⚠️ PRESENT_BEHAVIOR_UNVERIFIED (a state transition or a cancellation/cleanup/ordering invariant with no test exercising it) is a behavioral-evidence gap, not an artificial user-facing step. Record it in `behavior_unverified_items` and emit a human-verification item for it **even on an infrastructure/foundation phase** — these invariants are exactly where infra phases hide runtime state leaks. Such a truth drives `human_needed`; the auto-pass-UAT shortcut applies only to the absence of user-facing UX, never to a behavior-unverified invariant. The same carve-out covers an **abstained non-inferable truth** (⚠️ `insufficient_spec`, § Backstop abstention below) — an insufficient-spec gap is an evidence gap, not a user-facing step, so it too still emits its human-verification item and drives `human_needed` on an infrastructure phase.
|
|
156
|
+
|
|
157
|
+
**How to determine if a phase is infrastructure/foundation:**
|
|
158
|
+
- Phase goal or name contains: "foundation", "infrastructure", "schema", "database", "internal API", "data model", "scaffolding", "pipeline", "tooling", "CI", "migrations", "service layer", "backend", "core library"
|
|
159
|
+
- Phase success criteria describe only technical artifacts (files exist, tests pass, schema is valid) with no user interaction required
|
|
160
|
+
- There is no UI, CLI output visible to end users, or real-time behavior to observe
|
|
161
|
+
|
|
162
|
+
**If the phase IS infrastructure/foundation:** auto-pass UAT — skip the human verification items list entirely, **except any ⚠️ PRESENT_BEHAVIOR_UNVERIFIED or abstained ⚠️ `insufficient_spec` truth (see exception above), which still emits a human-verification item and drives `human_needed`.** Only when no such excepted truth exists, log:
|
|
163
|
+
|
|
164
|
+
```markdown
|
|
165
|
+
## Human Verification
|
|
166
|
+
|
|
167
|
+
N/A — Infrastructure/foundation phase with no user-facing elements.
|
|
168
|
+
All acceptance criteria are verifiable programmatically.
|
|
169
|
+
```
|
|
170
|
+
|
|
171
|
+
**If the phase IS user-facing:** only flag items that genuinely require a human — per the Step 8 always/uncertain lists already in the agent. Do not invent steps.
|
|
172
|
+
|
|
173
|
+
## Backstop abstention — reporting contract (#3206, companion to agent Step 3 item 5b)
|
|
174
|
+
|
|
175
|
+
When a non-inferable (`verification: backstop`) truth abstains for lack of explicit evidence:
|
|
176
|
+
|
|
177
|
+
- **Never silent, never a hard halt.** *Interactive:* the abstained item routes to the end-of-phase
|
|
178
|
+
human checkpoint. *Autonomous (AFK):* it produces a prominent `unverified — held-out test
|
|
179
|
+
recommended` flag and the completion line reads "complete with N unverified non-inferable checks";
|
|
180
|
+
the run neither silently passes the blind spot nor hard-halts.
|
|
181
|
+
- **Distinguishable reason.** The abstain disposition carries `reason: insufficient_spec` so its
|
|
182
|
+
`human_needed` outcome is never conflated with an ordinary manual-UAT `human_needed`.
|
|
183
|
+
- **Infrastructure phases included.** This rides the same carve-out as ⚠️ PRESENT_BEHAVIOR_UNVERIFIED
|
|
184
|
+
in the infrastructure-phase gate above: an abstention is an evidence gap, not a user-facing step,
|
|
185
|
+
so the infra auto-pass-UAT shortcut never absorbs it.
|
|
186
|
+
|
|
187
|
+
Full protocol and rationale: `gsd-core/references/honest-verifier.md`.
|
|
188
|
+
|
|
189
|
+
## Lazy references
|
|
190
|
+
|
|
191
|
+
- **Per-stack verification patterns:** before Step 4 (artifact verification) on an unfamiliar stack, Read `~/.claude/gsd-core/references/verification-patterns.md` — the grep catalog for React/Next.js components, API routes, database schema, and the universal stub patterns. Read it lazily (only the sections for the stack under verification); it is too large to load wholesale on every run.
|
|
192
|
+
- **Canonical report shape:** the emitted VERIFICATION.md follows `@~/.claude/gsd-core/templates/verification-report.md` — the template whose Guidelines and row shapes `src/uat.cts` treats as canonical when consuming verification output.
|
|
@@ -17,7 +17,7 @@ The framing fires when:
|
|
|
17
17
|
- The phase under verification has `**Mode:** mvp` in ROADMAP.md (parsed via `gsd-tools query roadmap.get-phase --pick mode`).
|
|
18
18
|
- AND the phase has a user-story-formatted goal (set by `/gsd mvp-phase` per Phase 2): "As a [user role], I want to [capability], so that [outcome]."
|
|
19
19
|
|
|
20
|
-
If the phase has `mode: mvp` but the goal is NOT in user-story format, the verifier surfaces this as a discrepancy and asks the user to run `/gsd mvp-phase` to reformat the goal — same pattern as the planner agent under MVP_MODE (per `references/planner-mvp-mode.md`).
|
|
20
|
+
If the phase has `mode: mvp` but the goal is NOT in user-story format, the verifier surfaces this as a discrepancy and asks the user to run `/gsd mvp-phase` to reformat the goal — same pattern as the planner agent under MVP_MODE (per `gsd-core/references/planner-mvp-mode.md`).
|
|
21
21
|
|
|
22
22
|
## Generated UAT script structure under MVP mode
|
|
23
23
|
|
|
@@ -9,8 +9,12 @@ parallel milestone work by multiple Claude Code instances on the same codebase.
|
|
|
9
9
|
|
|
10
10
|
1. `--ws <name>` flag (explicit, highest priority)
|
|
11
11
|
2. `GSD_WORKSTREAM` environment variable (per-instance)
|
|
12
|
-
3. Session-scoped active workstream pointer in temp storage (per runtime session / terminal)
|
|
13
|
-
|
|
12
|
+
3. Session-scoped active workstream pointer in temp storage (per runtime session / terminal),
|
|
13
|
+
when that pointer exists and is non-blank
|
|
14
|
+
4. `.planning/active-workstream` file — consulted whenever step 3 has nothing to say: either
|
|
15
|
+
there is no session identity at all, or there is one but it has never pointed at a
|
|
16
|
+
workstream. A session that already has its own pointer (step 3) is never overridden by
|
|
17
|
+
this step, even if that pointer is stale.
|
|
14
18
|
5. `null` — flat mode (no workstreams)
|
|
15
19
|
|
|
16
20
|
## Why session-scoped pointers exist
|
|
@@ -20,16 +24,22 @@ Claude/Codex instances are active on the same repo at the same time. One session
|
|
|
20
24
|
silently repoint another session's `STATE.md`, `ROADMAP.md`, and phase paths.
|
|
21
25
|
|
|
22
26
|
GSD now prefers a session-scoped pointer keyed by runtime/session identity
|
|
23
|
-
(`GSD_SESSION_KEY`, `CODEX_THREAD_ID`, `
|
|
27
|
+
(`GSD_SESSION_KEY`, `CODEX_THREAD_ID`, `CLAUDE_CODE_SESSION_ID`,
|
|
28
|
+
`CLAUDE_CODE_SSE_PORT`, terminal session IDs,
|
|
24
29
|
or the controlling TTY). This keeps concurrent sessions isolated while preserving
|
|
25
30
|
legacy compatibility for runtimes that do not expose a stable session key.
|
|
26
31
|
|
|
32
|
+
A session that has never set its own pointer inherits `.planning/active-workstream`
|
|
33
|
+
(step 4) rather than silently falling back to flat mode — this does not weaken the
|
|
34
|
+
isolation guarantee above: inheritance only fires when a session's own pointer is
|
|
35
|
+
absent, and a session that has ever set one is never repointed by the shared file.
|
|
36
|
+
|
|
27
37
|
## Session Identity Resolution
|
|
28
38
|
|
|
29
39
|
When GSD resolves the session-scoped pointer in step 3 above, it uses this order:
|
|
30
40
|
|
|
31
41
|
1. Explicit runtime/session env vars such as `GSD_SESSION_KEY`, `CODEX_THREAD_ID`,
|
|
32
|
-
`CLAUDE_SESSION_ID`, `CLAUDE_CODE_SSE_PORT`, `OPENCODE_SESSION_ID`,
|
|
42
|
+
`CLAUDE_SESSION_ID`, `CLAUDE_CODE_SESSION_ID`, `CLAUDE_CODE_SSE_PORT`, `OPENCODE_SESSION_ID`,
|
|
33
43
|
`GEMINI_SESSION_ID`, `CURSOR_SESSION_ID`, `WINDSURF_SESSION_ID`,
|
|
34
44
|
`TERM_SESSION_ID`, `WT_SESSION`, `TMUX_PANE`, and `ZELLIJ_SESSION_NAME`
|
|
35
45
|
2. `TTY` or `SSH_TTY` if the shell/runtime already exposes the terminal path
|
|
@@ -47,7 +57,13 @@ routing hot path.
|
|
|
47
57
|
|
|
48
58
|
Session-scoped pointers are intentionally lightweight and best-effort:
|
|
49
59
|
|
|
50
|
-
- Clearing a workstream for one session removes only that session's pointer file
|
|
60
|
+
- Clearing a workstream for one session removes only that session's pointer file.
|
|
61
|
+
This returns that session to step 4 of Resolution Priority above — it goes back
|
|
62
|
+
to **inheriting** `.planning/active-workstream` (if a marker exists there), not
|
|
63
|
+
to flat mode. A cleared session with no marker present resolves to `null`; a
|
|
64
|
+
cleared session with a marker present resolves to whatever that marker names.
|
|
65
|
+
To force flat mode for a cleared session, remove the shared marker file, or use
|
|
66
|
+
an explicit override such as `--ws` / `GSD_WORKSTREAM` on the command in question.
|
|
51
67
|
- If that was the last pointer for the repo, GSD also removes the now-empty
|
|
52
68
|
per-project temp directory
|
|
53
69
|
- If sibling session pointers still exist, the temp directory is left in place
|
|
@@ -76,7 +92,7 @@ This ensures workstream scope chains automatically through the workflow:
|
|
|
76
92
|
├── config.json # Shared
|
|
77
93
|
├── milestones/ # Shared
|
|
78
94
|
├── codebase/ # Shared
|
|
79
|
-
├── active-workstream #
|
|
95
|
+
├── active-workstream # Shared marker; inherited when a session has no pointer of its own
|
|
80
96
|
└── workstreams/
|
|
81
97
|
├── feature-a/ # Workstream A
|
|
82
98
|
│ ├── STATE.md
|
|
@@ -4,7 +4,7 @@ Template for `.planning/phases/XX-name/{phase_num}-DISCUSSION-LOG.md` — audit
|
|
|
4
4
|
|
|
5
5
|
**Purpose:** Software audit trail for decision-making. Captures all options considered, not just the selected one. Separate from CONTEXT.md which is the implementation artifact consumed by downstream agents.
|
|
6
6
|
|
|
7
|
-
**NOT for LLM consumption.** This file should never be referenced in `<
|
|
7
|
+
**NOT for LLM consumption.** This file should never be referenced in `<required_reading>` blocks or agent prompts.
|
|
8
8
|
|
|
9
9
|
## Format
|
|
10
10
|
|
|
@@ -187,7 +187,7 @@ autonomous: true
|
|
|
187
187
|
|
|
188
188
|
# Plan 02 - Protected features (needs auth)
|
|
189
189
|
wave: 2
|
|
190
|
-
depends_on: ["01"]
|
|
190
|
+
depends_on: ["01-01"]
|
|
191
191
|
files_modified: [src/features/dashboard.ts]
|
|
192
192
|
autonomous: true
|
|
193
193
|
```
|
|
@@ -199,7 +199,7 @@ Plan 02 in Wave 2 waits for Plan 01 in Wave 1 - genuine dependency on auth types
|
|
|
199
199
|
```yaml
|
|
200
200
|
# Plan 03 - UI with verification
|
|
201
201
|
wave: 3
|
|
202
|
-
depends_on: ["01", "02"]
|
|
202
|
+
depends_on: ["01-01", "01-02"]
|
|
203
203
|
files_modified: [src/components/Dashboard.tsx]
|
|
204
204
|
autonomous: false # Has checkpoint:human-verify
|
|
205
205
|
```
|
|
@@ -606,5 +606,3 @@ Task completion ≠ Goal achievement. A task "create chat component" can complet
|
|
|
606
606
|
4. Verification subagent checks must_haves against codebase
|
|
607
607
|
5. Gaps found → fix plans created → execute → re-verify
|
|
608
608
|
6. All must_haves pass → phase complete
|
|
609
|
-
|
|
610
|
-
See `~/.claude/gsd-core/workflows/verify-phase.md` for verification logic.
|
|
@@ -79,11 +79,11 @@ None yet.
|
|
|
79
79
|
|
|
80
80
|
## Deferred Items
|
|
81
81
|
|
|
82
|
-
Items acknowledged and
|
|
82
|
+
Items acknowledged and deferred at milestone close, most recent first:
|
|
83
83
|
|
|
84
|
-
| Category | Item | Status | Deferred At |
|
|
85
|
-
|
|
86
|
-
| *(none)* | | | |
|
|
84
|
+
| Category | Item | Status | Deferred At | Milestone |
|
|
85
|
+
|----------|------|--------|-------------|-----------|
|
|
86
|
+
| *(none)* | | | | |
|
|
87
87
|
|
|
88
88
|
## Session Continuity
|
|
89
89
|
|
|
@@ -18,6 +18,10 @@ behavior_unverified_items: # Only if behavior_unverified > 0 — the truths abov
|
|
|
18
18
|
test: "What to trigger"
|
|
19
19
|
expected: "What state must hold afterward"
|
|
20
20
|
why_human: "Why presence checks can't see it"
|
|
21
|
+
coincidental_reliance_items: # Only if a ✓ VERIFIED truth holds incidentally — emitted regardless of overall status (survives gaps_found)
|
|
22
|
+
- truth: "Observable truth that holds incidentally"
|
|
23
|
+
reason: undeclared-precondition | incidental-ordering | fixture-only
|
|
24
|
+
harden: "Precondition/ordering to declare or enforce"
|
|
21
25
|
---
|
|
22
26
|
|
|
23
27
|
# Phase {X}: {Name} Verification Report
|
|
@@ -35,7 +39,8 @@ behavior_unverified_items: # Only if behavior_unverified > 0 — the truths abov
|
|
|
35
39
|
| 1 | {truth from must_haves} | ✓ VERIFIED | {what confirmed it} |
|
|
36
40
|
| 2 | {truth from must_haves} | ✗ FAILED | {what's wrong} |
|
|
37
41
|
| 3 | {truth from must_haves} | ⚠️ PRESENT_BEHAVIOR_UNVERIFIED | {present + wired; transition/invariant not exercised by a test — see Human Verification} |
|
|
38
|
-
| 4 | {truth from must_haves} |
|
|
42
|
+
| 4 | {truth from must_haves} | ✓ VERIFIED (coincidental-reliance) | {holds, but incidentally — see coincidental_reliance_items} |
|
|
43
|
+
| 5 | {truth from must_haves} | ? UNCERTAIN | {why can't verify} |
|
|
39
44
|
|
|
40
45
|
**Score:** {N}/{M} truths verified ({P} present, behavior-unverified)
|
|
41
46
|
|
|
@@ -176,6 +181,9 @@ None — all verifiable items checked programmatically.
|
|
|
176
181
|
**Per-truth states (Observable Truths `Status` column):**
|
|
177
182
|
- `✓ VERIFIED` — supporting artifacts pass all checks; for a behavior-dependent truth, a behavioral test exercised the asserted behavior
|
|
178
183
|
- `⚠️ PRESENT_BEHAVIOR_UNVERIFIED` — present + wired, but a state transition or cancellation/cleanup/ordering invariant was not exercised by any test. Counts toward `behavior_unverified`, routes to human verification, and is *excluded* from the verified score. Per-truth only — on its own the overall `status:` becomes `human_needed` (unless a higher-precedence `gaps_found` also applies); the item is preserved in `behavior_unverified_items` regardless.
|
|
184
|
+
- `✓ VERIFIED (coincidental-reliance)` — an **advisory** qualifier on a truth that *is* verified but holds for an incidental reason rather than a guaranteed one (#1955): `undeclared-precondition` (state nothing in the phase's artifacts or a declared prerequisite guarantees), `incidental-ordering` (an order or side effect nothing in the code enforces), or `fixture-only` (the test's own setup establishes the precondition; the production path has no equivalent). The base `✓ VERIFIED` token is kept verbatim and leading, so it counts toward the verified score exactly as before — the advisory changes no score and no status, and never produces a human-verification item. Each flagged truth is listed in `coincidental_reliance_items` with the reason and what to harden. Not applied to a truth that never reached `✓ VERIFIED`, nor to a `PASSED (override)` truth.
|
|
185
|
+
|
|
186
|
+
**Filling this column — apply the reliance check to every `✓ VERIFIED` truth before writing the row.** Ask why the truth holds and classify the evidence you already recorded, not your confidence in it. Flag it when the evidence names one of the three reasons above. Do NOT flag: a precondition the code establishes or explicitly defaults; ordering the code enforces (await, explicit sequencing); a fixture merely supplying input the real caller also supplies; unease naming no specific state, ordering, or fixture. The check is endogenous and so weaker than an exogenous tag (`gsd-core/references/honest-verifier.md`) — which is why it is advisory and never a gate. The usual fix is to promote the hidden assumption into a declared precondition.
|
|
179
187
|
- `✗ FAILED` — artifact missing, stub, or unwired
|
|
180
188
|
- `? UNCERTAIN` — can't verify programmatically
|
|
181
189
|
|
|
@@ -112,10 +112,10 @@ Select the right AI framework for Phase {phase_number}: {phase_name}
|
|
|
112
112
|
Goal: {phase_goal}
|
|
113
113
|
</objective>
|
|
114
114
|
|
|
115
|
-
<
|
|
115
|
+
<required_reading>
|
|
116
116
|
{context_path if exists}
|
|
117
117
|
{requirements_path if exists}
|
|
118
|
-
</
|
|
118
|
+
</required_reading>
|
|
119
119
|
|
|
120
120
|
<phase_context>
|
|
121
121
|
Phase: {phase_number} — {phase_name}
|
|
@@ -161,10 +161,10 @@ Before editing, verify the section you are about to write is still a template pl
|
|
|
161
161
|
<objective>
|
|
162
162
|
</objective>
|
|
163
163
|
|
|
164
|
-
<
|
|
164
|
+
<required_reading>
|
|
165
165
|
{ai_spec_path}
|
|
166
166
|
{context_path if exists}
|
|
167
|
-
</
|
|
167
|
+
</required_reading>
|
|
168
168
|
|
|
169
169
|
<input>
|
|
170
170
|
framework: {primary_framework}
|
|
@@ -196,11 +196,11 @@ Before editing, verify the section you are about to write is still a template pl
|
|
|
196
196
|
<objective>
|
|
197
197
|
</objective>
|
|
198
198
|
|
|
199
|
-
<
|
|
199
|
+
<required_reading>
|
|
200
200
|
{ai_spec_path}
|
|
201
201
|
{context_path if exists}
|
|
202
202
|
{requirements_path if exists}
|
|
203
|
-
</
|
|
203
|
+
</required_reading>
|
|
204
204
|
|
|
205
205
|
<input>
|
|
206
206
|
system_type: {system_type}
|
|
@@ -227,11 +227,11 @@ Write Sections 5, 6, and 7 of AI-SPEC.md
|
|
|
227
227
|
AI-SPEC.md now contains domain context (Section 1b) — use it as your rubric starting point.
|
|
228
228
|
</objective>
|
|
229
229
|
|
|
230
|
-
<
|
|
230
|
+
<required_reading>
|
|
231
231
|
{ai_spec_path}
|
|
232
232
|
{context_path if exists}
|
|
233
233
|
{requirements_path if exists}
|
|
234
|
-
</
|
|
234
|
+
</required_reading>
|
|
235
235
|
|
|
236
236
|
<input>
|
|
237
237
|
system_type: {system_type}
|
|
@@ -258,10 +258,8 @@ Read the completed AI-SPEC.md. Check that:
|
|
|
258
258
|
|
|
259
259
|
## 11. Commit
|
|
260
260
|
|
|
261
|
-
**If `commit_docs` is true:**
|
|
262
261
|
```bash
|
|
263
|
-
|
|
264
|
-
git commit -m "docs({phase_slug}): generate AI-SPEC.md — {primary_framework} + domain context + eval strategy"
|
|
262
|
+
gsd_run query commit "docs({phase_slug}): generate AI-SPEC.md — {primary_framework} + domain context + eval strategy" --files "${AI_SPEC_FILE}"
|
|
265
263
|
```
|
|
266
264
|
|
|
267
265
|
## 12. Display Completion
|
|
@@ -781,7 +781,7 @@ When any phase operation fails or a blocker is detected, present 3 options via A
|
|
|
781
781
|
2. **"Skip this phase"** — Mark phase as skipped, continue to the next incomplete phase
|
|
782
782
|
3. **"Stop autonomous mode"** — Display summary of progress so far and exit cleanly
|
|
783
783
|
|
|
784
|
-
**On "Fix and retry":** Loop back to the failed step within execute_phase. If the same step fails again after retry, re-present these options.
|
|
784
|
+
**On "Fix and retry":** Loop back to the failed step within execute_phase. Track the retry count per phase + step (`RETRY_COUNT`, kept in memory for the run). If the same step fails again after retry, re-present these options. **Retry ceiling (#3210):** once the same phase step has failed 3 "Fix and retry" attempts, do NOT re-present the options — escalate to a terminal `needs_human` halt: display `Phase {N} ⛔ {Name} — needs_human`, list the unmet items (the blocker description from each attempt), append/update a `## Needs Human` section in STATE.md (`| ${PHASE_NUM} | needs_human | resolve blocker, then /gsd:autonomous --from ${PHASE_NUM} |`), and stop autonomous mode with the standard stopped-summary banner. A blocker that survives 3 fix attempts is an operator gate, not an executable gap — retrying it again just burns hours.
|
|
785
785
|
|
|
786
786
|
**On "Skip this phase":** Log `Phase {N} ⏭ {Name} — Skipped by user` and proceed to iterate.
|
|
787
787
|
|