@opengeoweb/workspace 9.4.1 → 9.6.0

package/index.esm.js

@@ -4,7 +4,7 @@ import { syncGroupsTypes, syncGroupsActions, layerActions, mapStoreActions, uiAc
 import { createApiInstance, createNonAuthApiInstance, getApi, createFakeApiInstance, ApiProvider, useApiContext } from '@opengeoweb/api';
 import { getLeaves, MosaicContext, getAndAssertNodeAtPathExists, createBalancedTreeFromLeaves, MosaicWindow, Mosaic } from 'react-mosaic-component';
 import { debounce, takeEvery, takeLatest, all, put, delay, call, select, takeLeading } from 'redux-saga/effects';
-import { isAxiosError, getAxiosErrorMessage, withEggs, ConfirmationServiceProvider, useConfirmationDialog, CustomIconButton, AlertBanner, CustomTooltip, SearchHighlight, ToggleMenu, getHeight, usePrevious, ToolContainer, CustomToggleButton, ConfirmationDialog } from '@opengeoweb/shared';
+import { isAxiosError, getAxiosErrorMessage, withEggs, ConfirmationServiceProvider, useConfirmationDialog, CustomIconButton, AlertBanner, CustomTooltip, SearchHighlight, ToggleMenu, getHeight, usePrevious, renderCounter, ToolContainer, CustomToggleButton, ConfirmationDialog } from '@opengeoweb/shared';
 import { snackbarActions, SnackbarWrapperConnect } from '@opengeoweb/snackbar';
 import * as React from 'react';
 import React__default, { useCallback } from 'react';
@@ -6204,6 +6204,7 @@ var ViewPresetMenu = function ViewPresetMenu(_ref) {
   }, /*#__PURE__*/React__default.createElement(ViewPresetMenuListConnect, {
     panelId: panelId
   }));
+  renderCounter.count(ViewPresetMenu.name);
   return /*#__PURE__*/React__default.createElement("div", null, hideBackdrop ?
   // Enable hiding backdrop from snapshot tests
   toolContainer : ( /*#__PURE__*/React__default.createElement(Backdrop, {
@@ -6482,6 +6483,15 @@ var WorkspaceViewTitleConnect = function WorkspaceViewTitleConnect(_ref) {
   var title = (workspaceView === null || workspaceView === void 0 ? void 0 : workspaceView.title) || MAPPRESET_ACTIVE_TITLE;
   var viewScope = workspaceView === null || workspaceView === void 0 ? void 0 : workspaceView.scope;
   var fullTitle = getPresetTitle(title, hasMapPresetChanges, isNewActive);
+  // TODO: https://gitlab.com/opengeoweb/opengeoweb/-/issues/4546
+  // This component renders on every change in the mapstate.
+  // This is because selectors like mapSelectors.getMapPreset are used in the component.
+  // The data from this selector is not used during a render, so it is wasting renders.
+  // The data is need only in the callback functions - not the component itself
+  // To prevent unneeded renders, this code should be rewritten by using refs, or move the logic to sagas.
+  // You can use the renderCounter to check the nubmer of renders.
+  // Also check https://xam-react-coe.medium.com/react-useselector-without-re-render-225686bee3f
+  renderCounter.count(WorkspaceViewTitleConnect.name);
   return /*#__PURE__*/React.createElement(React.Fragment, null, /*#__PURE__*/React.createElement(CustomIconButton, {
     "data-testid": "open-viewpresets",
     sx: {
@@ -7204,8 +7214,7 @@ var WorkspaceMenuButton = function WorkspaceMenuButton(_ref) {
  * Copyright 2023 - Koninklijk Nederlands Meteorologisch Instituut (KNMI)
  * Copyright 2023 - Finnish Meteorological Institute (FMI)
  * */
-var WorkspaceMenuButtonConnect = function WorkspaceMenuButtonConnect(_ref) {
-  var workspaceId = _ref.workspaceId;
+var WorkspaceMenuButtonConnect = function WorkspaceMenuButtonConnect() {
   var dispatch = useDispatch();
   var setListDialogOpen = React__default.useCallback(function (isListDialogOpen) {
     dispatch(workspaceListActions.toggleWorkspaceDialog({
@@ -7215,13 +7224,6 @@ var WorkspaceMenuButtonConnect = function WorkspaceMenuButtonConnect(_ref) {
   var isWorkspaceListDialogOpen = useSelector(function (store) {
     return getIsWorkspaceListDialogOpen(store);
   });
-  React__default.useEffect(function () {
-    // open workspaceDialog on mount if needed
-    if (workspaceId === undefined || workspaceId === 'emptyMap' || workspaceId === '') {
-      setListDialogOpen(true);
-    }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [setListDialogOpen]);
   return /*#__PURE__*/React__default.createElement(WorkspaceMenuButton, {
     showMenu: isWorkspaceListDialogOpen,
     onToggleDialog: setListDialogOpen
@@ -7353,9 +7355,7 @@ var WorkspaceTab = function WorkspaceTab(_ref) {
       alignItems: 'center'
     },
     "data-testid": "workspaceTab"
-  }, /*#__PURE__*/React.createElement(WorkspaceMenuButtonConnect, {
-    workspaceId: workspaceId
-  }), /*#__PURE__*/React.createElement(WorkspaceOptionsConnect, {
+  }, /*#__PURE__*/React.createElement(WorkspaceMenuButtonConnect, null), /*#__PURE__*/React.createElement(WorkspaceOptionsConnect, {
     title: title,
     activeTab: activeTab,
     workspaceId: workspaceId

package/package.json

@@ -1,12 +1,44 @@
 {
   "name": "@opengeoweb/workspace",
-  "version": "9.4.1",
+  "version": "9.6.0",
   "description": "GeoWeb Workspace library for the opengeoweb project",
   "license": "Apache-2.0",
   "repository": {
     "type": "git",
     "url": "git@gitlab.com:opengeoweb/opengeoweb.git"
   },
+  "dependencies": {
+    "react-redux": "^8.1.3",
+    "@opengeoweb/shared": "*",
+    "@mui/material": "5.12.0",
+    "@opengeoweb/form-fields": "*",
+    "@opengeoweb/store": "*",
+    "@opengeoweb/api": "*",
+    "react-hook-form": "7.47.0",
+    "@opengeoweb/core": "*",
+    "@opengeoweb/theme": "*",
+    "@reduxjs/toolkit": "^1.9.7",
+    "@opengeoweb/timeseries": "*",
+    "@opengeoweb/authentication": "*",
+    "@opengeoweb/snackbar": "*",
+    "react-window": "^1.8.10",
+    "@mui/system": "^5.15.1",
+    "redux-saga": "^1.2.3",
+    "react-mosaic-component": "^6.1.0",
+    "lodash": "^4.17.21",
+    "@emotion/react": "^11.11.1",
+    "@redux-eggs/core": "^2.2.0",
+    "@redux-eggs/redux-toolkit": "^2.2.0",
+    "@redux-eggs/saga-extension": "^2.2.0",
+    "immer": "^9.0.21",
+    "axios": "1.5.0",
+    "@opengeoweb/taf": "*",
+    "@opengeoweb/sigmet-airmet": "*",
+    "@opengeoweb/warnings": "*"
+  },
+  "peerDependencies": {
+    "react": "18"
+  },
   "module": "./index.esm.js",
   "type": "module",
   "main": "./index.esm.js"

package/src/lib/components/WorkspaceMenu/WorkspaceMenuButtonConnect.d.ts

@@ -1,6 +1,2 @@
 import React from 'react';
-interface WorkspaceMenuButtonConnectProps {
-    workspaceId: string;
-}
-export declare const WorkspaceMenuButtonConnect: React.FC<WorkspaceMenuButtonConnectProps>;
-export {};
+export declare const WorkspaceMenuButtonConnect: React.FC;

package/src/lib/store/workspace/selectors.d.ts

@@ -142,9 +142,7 @@ export declare const getWorkspaceData: ((state: AppStore & import("@opengeoweb/s
 }> & {
     clearCache: () => void;
 };
-export declare const getViewPresetToSendToBackend: ((state: AppStore & import("@opengeoweb/store").CoreAppStore, viewId: string | (string & {
-    sourceId: string;
-})) => {
+export declare const getViewPresetToSendToBackend: ((state: any, viewId: any) => {
     id: string | undefined;
     scope: import("./types").PresetScope;
     title: string;

package/src/lib/storyUtils/StoryWrapper.d.ts

@@ -1,11 +1,18 @@
 import { Theme } from '@mui/material';
 import React from 'react';
+interface WorkspaceAppProps {
+    isSnapshot?: boolean;
+    workspaceId?: string;
+    shouldShowListOnOpen?: boolean;
+}
+export declare const WorkspaceApp: ({ isSnapshot, workspaceId, shouldShowListOnOpen, }: WorkspaceAppProps) => React.ReactElement;
 interface StoryWrapperProps {
     theme?: Theme;
     isSnapshot?: boolean;
     createApi?: () => void;
     workspaceId?: string;
     isLoggedIn?: boolean;
+    shouldShowListOnOpen?: boolean;
 }
-export declare const StoryWrapper: ({ theme, isSnapshot, createApi, workspaceId, isLoggedIn, }: StoryWrapperProps) => React.ReactElement;
+export declare const StoryWrapper: ({ theme, isSnapshot, createApi, workspaceId, isLoggedIn, shouldShowListOnOpen, }: StoryWrapperProps) => React.ReactElement;
 export {};