@opengeoweb/workspace 9.4.0 → 9.5.0

package/index.esm.js

@@ -4,7 +4,7 @@ import { syncGroupsTypes, syncGroupsActions, layerActions, mapStoreActions, uiAc
 import { createApiInstance, createNonAuthApiInstance, getApi, createFakeApiInstance, ApiProvider, useApiContext } from '@opengeoweb/api';
 import { getLeaves, MosaicContext, getAndAssertNodeAtPathExists, createBalancedTreeFromLeaves, MosaicWindow, Mosaic } from 'react-mosaic-component';
 import { debounce, takeEvery, takeLatest, all, put, delay, call, select, takeLeading } from 'redux-saga/effects';
-import { isAxiosError, getAxiosErrorMessage, withEggs, ConfirmationServiceProvider, useConfirmationDialog, CustomIconButton, AlertBanner, CustomTooltip, SearchHighlight, ToggleMenu, getHeight, usePrevious, ToolContainer, CustomToggleButton, ConfirmationDialog } from '@opengeoweb/shared';
+import { isAxiosError, getAxiosErrorMessage, withEggs, ConfirmationServiceProvider, useConfirmationDialog, CustomIconButton, AlertBanner, CustomTooltip, SearchHighlight, ToggleMenu, getHeight, usePrevious, renderCounter, ToolContainer, CustomToggleButton, ConfirmationDialog } from '@opengeoweb/shared';
 import { snackbarActions, SnackbarWrapperConnect } from '@opengeoweb/snackbar';
 import * as React from 'react';
 import React__default, { useCallback } from 'react';
@@ -6204,6 +6204,7 @@ var ViewPresetMenu = function ViewPresetMenu(_ref) {
   }, /*#__PURE__*/React__default.createElement(ViewPresetMenuListConnect, {
     panelId: panelId
   }));
+  renderCounter.count(ViewPresetMenu.name);
   return /*#__PURE__*/React__default.createElement("div", null, hideBackdrop ?
   // Enable hiding backdrop from snapshot tests
   toolContainer : ( /*#__PURE__*/React__default.createElement(Backdrop, {
@@ -6482,6 +6483,15 @@ var WorkspaceViewTitleConnect = function WorkspaceViewTitleConnect(_ref) {
   var title = (workspaceView === null || workspaceView === void 0 ? void 0 : workspaceView.title) || MAPPRESET_ACTIVE_TITLE;
   var viewScope = workspaceView === null || workspaceView === void 0 ? void 0 : workspaceView.scope;
   var fullTitle = getPresetTitle(title, hasMapPresetChanges, isNewActive);
+  // TODO: https://gitlab.com/opengeoweb/opengeoweb/-/issues/4546
+  // This component renders on every change in the mapstate.
+  // This is because selectors like mapSelectors.getMapPreset are used in the component.
+  // The data from this selector is not used during a render, so it is wasting renders.
+  // The data is need only in the callback functions - not the component itself
+  // To prevent unneeded renders, this code should be rewritten by using refs, or move the logic to sagas.
+  // You can use the renderCounter to check the nubmer of renders.
+  // Also check https://xam-react-coe.medium.com/react-useselector-without-re-render-225686bee3f
+  renderCounter.count(WorkspaceViewTitleConnect.name);
   return /*#__PURE__*/React.createElement(React.Fragment, null, /*#__PURE__*/React.createElement(CustomIconButton, {
     "data-testid": "open-viewpresets",
     sx: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@opengeoweb/workspace",
-  "version": "9.4.0",
+  "version": "9.5.0",
   "description": "GeoWeb Workspace library for the opengeoweb project",
   "license": "Apache-2.0",
   "repository": {

package/src/lib/store/workspace/selectors.d.ts

@@ -142,9 +142,7 @@ export declare const getWorkspaceData: ((state: AppStore & import("@opengeoweb/s
 }> & {
     clearCache: () => void;
 };
-export declare const getViewPresetToSendToBackend: ((state: AppStore & import("@opengeoweb/store").CoreAppStore, viewId: string | (string & {
-    sourceId: string;
-})) => {
+export declare const getViewPresetToSendToBackend: ((state: any, viewId: any) => {
     id: string | undefined;
     scope: import("./types").PresetScope;
     title: string;