@openfin/remote-adapter 46.100.64 → 46.100.66

package/out/remote-adapter.js

@@ -758,6 +758,45 @@ class AsyncRetryableLazy {
     }
 }
 
+/**
+ * The default FDC3 user channels advertised by the Interop Broker.
+ */
+const defaultColorChannels = {
+    'fdc3.channel.1': { name: 'Channel 1', color: 'red', glyph: '1' },
+    'fdc3.channel.2': { name: 'Channel 2', color: 'orange', glyph: '2' },
+    'fdc3.channel.3': { name: 'Channel 3', color: 'yellow', glyph: '3' },
+    'fdc3.channel.4': { name: 'Channel 4', color: 'green', glyph: '4' },
+    'fdc3.channel.5': { name: 'Channel 5', color: 'cyan', glyph: '5' },
+    'fdc3.channel.6': { name: 'Channel 6', color: 'blue', glyph: '6' },
+    'fdc3.channel.7': { name: 'Channel 7', color: 'magenta', glyph: '7' },
+    'fdc3.channel.8': { name: 'Channel 8', color: 'purple', glyph: '8' }
+};
+const legacyColorChannelIds = {
+    red: 'fdc3.channel.1',
+    orange: 'fdc3.channel.2',
+    yellow: 'fdc3.channel.3',
+    green: 'fdc3.channel.4',
+    teal: 'fdc3.channel.5',
+    blue: 'fdc3.channel.6',
+    pink: 'fdc3.channel.7',
+    // Legacy indigo (workspace) and purple (core) intentionally converge on the same FDC3 purple channel.
+    indigo: 'fdc3.channel.8',
+    purple: 'fdc3.channel.8'
+};
+/**
+ * Converts a legacy color-named channel ID to its canonical FDC3 user-channel ID.
+ * The removed legacy gray channel resolves to no channel.
+ */
+function normalizeColorChannelId(colorChannelId) {
+    if (colorChannelId === 'gray') {
+        return undefined;
+    }
+    if (Object.prototype.hasOwnProperty.call(legacyColorChannelIds, colorChannelId)) {
+        return legacyColorChannelIds[colorChannelId];
+    }
+    return colorChannelId;
+}
+
 var __classPrivateFieldSet$k = (undefined && undefined.__classPrivateFieldSet) || function (receiver, state, value, kind, f) {
     if (kind === "m") throw new TypeError("Private method is not writable");
     if (kind === "a" && !f) throw new TypeError("Private accessor was defined without a setter");
@@ -770,50 +809,7 @@ var __classPrivateFieldGet$l = (undefined && undefined.__classPrivateFieldGet) |
     return kind === "m" ? f : kind === "a" ? f.call(receiver) : f ? f.value : state.get(receiver);
 };
 var _InteropBroker_fdc3Info, _InteropBroker_contextGroups, _InteropBroker_providerPromise;
-const defaultContextGroups = [
-    {
-        id: 'green',
-        displayMetadata: {
-            color: '#00CC88',
-            name: 'green'
-        }
-    },
-    {
-        id: 'purple',
-        displayMetadata: {
-            color: '#8C61FF',
-            name: 'purple'
-        }
-    },
-    {
-        id: 'orange',
-        displayMetadata: {
-            color: '#FF8C4C',
-            name: 'orange'
-        }
-    },
-    {
-        id: 'red',
-        displayMetadata: {
-            color: '#FF5E60',
-            name: 'red'
-        }
-    },
-    {
-        id: 'pink',
-        displayMetadata: {
-            color: '#FF8FB8',
-            name: 'pink'
-        }
-    },
-    {
-        id: 'yellow',
-        displayMetadata: {
-            color: '#E9FF8F',
-            name: 'yellow'
-        }
-    }
-];
+const defaultContextGroups = Object.entries(defaultColorChannels).map(([id, displayMetadata]) => ({ id, displayMetadata }));
 /**
  * {@link https://developers.openfin.co/of-docs/docs/enable-color-linking}
  *
@@ -843,17 +839,19 @@ const defaultContextGroups = [
  *          "interopBrokerConfiguration": {
  *              "contextGroups": [
  *                  {
- *                      "id": "green",
+ *                      "id": "fdc3.channel.4",
  *                      "displayMetadata": {
- *                          "color": "#00CC88",
- *                          "name": "green"
+ *                          "color": "green",
+ *                          "name": "Channel 4",
+ *                          "glyph": "4"
  *                      }
  *                  },
  *                  {
- *                      "id": "purple",
+ *                      "id": "fdc3.channel.8",
  *                      "displayMetadata": {
- *                          "color": "#8C61FF",
- *                          "name": "purple"
+ *                          "color": "purple",
+ *                          "name": "Channel 8",
+ *                          "glyph": "8"
  *                      }
  *                  },
  *              ]
@@ -1016,9 +1014,13 @@ class InteropBroker extends Base {
         this.wire.sendAction('interop-broker-set-context-for-group').catch((e) => {
             // don't expose, analytics-only call
         });
-        const contextGroupState = this.contextGroupsById.get(contextGroupId);
+        const normalizedContextGroupId = this.normalizeContextGroupId(contextGroupId);
+        if (normalizedContextGroupId === undefined) {
+            return;
+        }
+        const contextGroupState = this.contextGroupsById.get(normalizedContextGroupId);
         if (!contextGroupState) {
-            throw new Error(`Unable to set context for context group that isn't in the context group mapping: ${contextGroupId}.`);
+            throw new Error(`Unable to set context for context group that isn't in the context group mapping: ${normalizedContextGroupId}.`);
         }
         const contextIntegrityCheckResult = InteropBroker.checkContextIntegrity(context);
         if (contextIntegrityCheckResult.isValid === false) {
@@ -1026,8 +1028,8 @@ class InteropBroker extends Base {
         }
         const broadcastedContextType = context.type;
         contextGroupState.set(broadcastedContextType, context);
-        this.lastContextMap.set(contextGroupId, broadcastedContextType);
-        const clientsInSameContextGroup = Array.from(this.interopClients.values()).filter((connectedClient) => connectedClient.contextGroupId === contextGroupId);
+        this.lastContextMap.set(normalizedContextGroupId, broadcastedContextType);
+        const clientsInSameContextGroup = Array.from(this.interopClients.values()).filter((connectedClient) => connectedClient.contextGroupId === normalizedContextGroupId);
         clientsInSameContextGroup.forEach((client) => {
             for (const [, handlerInfo] of client.contextHandlers) {
                 if (InteropBroker.isContextTypeCompatible(broadcastedContextType, handlerInfo.contextType)) {
@@ -1073,10 +1075,20 @@ class InteropBroker extends Base {
      * @param joinContextGroupOptions - Id of the Context Group and identity of the entity to join to the group.
      * @param senderIdentity - Identity of the client sender.
      */
-    async joinContextGroup({ contextGroupId, target }, senderIdentity) {
+    async joinContextGroup({ contextGroupId: requestedContextGroupId, target }, senderIdentity) {
         this.wire.sendAction('interop-broker-join-context-group').catch((e) => {
             // don't expose, analytics-only call
         });
+        const contextGroupId = this.normalizeContextGroupId(requestedContextGroupId);
+        if (contextGroupId === undefined) {
+            if (target) {
+                await this.removeFromContextGroup({ target }, senderIdentity);
+            }
+            else {
+                await this.removeClientFromContextGroup(senderIdentity);
+            }
+            return;
+        }
         if (this.sessionContextGroupMap.has(contextGroupId)) {
             throw new Error(BROKER_ERRORS.joinSessionContextGroupWithJoinContextGroup);
         }
@@ -1118,10 +1130,15 @@ class InteropBroker extends Base {
      * @param addClientToContextGroupOptions - Contains the contextGroupId
      * @param clientIdentity - Identity of the client sender.
      */
-    async addClientToContextGroup({ contextGroupId }, clientIdentity) {
+    async addClientToContextGroup({ contextGroupId: requestedContextGroupId }, clientIdentity) {
         this.wire.sendAction('interop-broker-add-client-to-context-group').catch((e) => {
             // don't expose, analytics-only call
         });
+        const contextGroupId = this.normalizeContextGroupId(requestedContextGroupId);
+        if (contextGroupId === undefined) {
+            await this.removeClientFromContextGroup(clientIdentity);
+            return;
+        }
         const clientSubscriptionState = this.getClientState(clientIdentity);
         if (!clientSubscriptionState) {
             throw new Error(`Client with Identity: ${clientIdentity.uuid} ${clientIdentity.name} not in Client State Map`);
@@ -1220,6 +1237,9 @@ class InteropBroker extends Base {
             clientState.contextGroupId = undefined;
         }
         await this.setCurrentContextGroupInClientOptions(clientIdentity, null);
+        if (previousContextGroupId === undefined) {
+            return;
+        }
         // All settled will suppress uncaught exceptions. We don't want to await this because it could
         // result in the operation hanging.
         Promise.allSettled(this.channel.publish('client-changed-context-group', {
@@ -1257,7 +1277,11 @@ class InteropBroker extends Base {
         this.wire.sendAction('interop-broker-get-info-for-context-group').catch((e) => {
             // don't expose, analytics-only call
         });
-        return this.getContextGroups().find((contextGroup) => contextGroup.id === contextGroupId);
+        const normalizedContextGroupId = this.normalizeContextGroupId(contextGroupId);
+        if (normalizedContextGroupId === undefined) {
+            return undefined;
+        }
+        return this.getContextGroups().find((contextGroup) => contextGroup.id === normalizedContextGroupId);
     }
     // Used by platform windows to get all clients for a context group.
     /**
@@ -1273,8 +1297,12 @@ class InteropBroker extends Base {
         this.wire.sendAction('interop-broker-get-all-clients-in-context-group').catch((e) => {
             // don't expose, analytics-only call
         });
+        const normalizedContextGroupId = this.normalizeContextGroupId(contextGroupId);
+        if (normalizedContextGroupId === undefined) {
+            return [];
+        }
         const clientsInContextGroup = Array.from(this.interopClients.values())
-            .filter((connectedClient) => connectedClient.contextGroupId === contextGroupId)
+            .filter((connectedClient) => connectedClient.contextGroupId === normalizedContextGroupId)
             .map((subscriptionState) => {
             return subscriptionState.clientIdentity;
         });
@@ -1721,8 +1749,9 @@ class InteropBroker extends Base {
     }
     // Used to restore interop broker state in snapshots.
     applySnapshot(snapshot, options) {
-        const contextGroupStates = snapshot?.interopSnapshotDetails?.contextGroupStates;
-        if (contextGroupStates) {
+        const incomingContextGroupStates = snapshot?.interopSnapshotDetails?.contextGroupStates;
+        if (incomingContextGroupStates) {
+            const contextGroupStates = this.normalizeContextGroupStates(incomingContextGroupStates);
             if (!options?.closeExistingWindows) {
                 this.updateExistingClients(contextGroupStates);
             }
@@ -1867,6 +1896,23 @@ class InteropBroker extends Base {
         });
         return newObject;
     }
+    normalizeContextGroupStates(incomingContextGroupStates) {
+        const normalizedContextGroupStates = {};
+        for (const [contextGroupId, contexts] of Object.entries(incomingContextGroupStates)) {
+            const normalizedContextGroupId = this.normalizeContextGroupId(contextGroupId);
+            if (normalizedContextGroupId !== undefined) {
+                normalizedContextGroupStates[normalizedContextGroupId] = {
+                    ...normalizedContextGroupStates[normalizedContextGroupId],
+                    ...contexts
+                };
+            }
+        }
+        return normalizedContextGroupStates;
+    }
+    normalizeContextGroupId(contextGroupId) {
+        const usesDefaultColorChannels = Object.keys(defaultColorChannels).every((defaultContextGroupId) => this.contextGroupsById.has(defaultContextGroupId));
+        return usesDefaultColorChannels ? normalizeColorChannelId(contextGroupId) : contextGroupId;
+    }
     // Util to check a client identity.
     static hasEndpointId(target) {
         return target.endpointId !== undefined;
@@ -1930,8 +1976,14 @@ class InteropBroker extends Base {
                 clientIdentity
             };
             // Only allow the client to join a contextGroup that actually exists.
-            if (payload?.currentContextGroup && this.contextGroupsById.has(payload.currentContextGroup)) {
-                clientSubscriptionState.contextGroupId = payload?.currentContextGroup;
+            const currentContextGroup = payload?.currentContextGroup
+                ? this.normalizeContextGroupId(payload.currentContextGroup)
+                : undefined;
+            if (currentContextGroup && this.contextGroupsById.has(currentContextGroup)) {
+                clientSubscriptionState.contextGroupId = currentContextGroup;
+                if (currentContextGroup !== payload.currentContextGroup) {
+                    await this.setCurrentContextGroupInClientOptions(clientIdentity, currentContextGroup);
+                }
             }
             this.interopClients.set(clientIdentity.endpointId, clientSubscriptionState);
         });
@@ -2179,6 +2231,26 @@ function isNewConnectConfig(config) {
     return hasUuid(config) && hasRuntimeVersion(config);
 }
 
+const V8Error = Error;
+function isCallSiteArray(stack) {
+    if (!Array.isArray(stack) || stack.length === 0) {
+        return Array.isArray(stack);
+    }
+    const first = stack[0];
+    return typeof first === 'object' && first !== null && typeof first.getFileName === 'function';
+}
+function isStackFrameLine(line) {
+    return /^\s*at\s/.test(line) || line.includes('@');
+}
+/**
+ * Split a native `error.stack` string into frames and drop the dummy Error header plus `framesToRemove` frames.
+ * Safari/Firefox ignore V8's Error.prepareStackTrace, so `.stack` stays a string and `.slice(n)` would cut characters.
+ */
+function stackStringToFrames(stack, framesToRemove) {
+    const lines = stack.split('\n').filter((line) => line.length > 0);
+    const start = lines[0] !== undefined && !isStackFrameLine(lines[0]) ? 1 : 0;
+    return lines.slice(start + framesToRemove);
+}
 class DisconnectedError extends Error {
     constructor(readyState) {
         super(`Expected websocket state OPEN but found ${readyState}`);
@@ -2215,17 +2287,17 @@ class DeserializedError extends Error {
 class RuntimeError extends Error {
     static trimEndCallSites(err, takeUntilRegex) {
         // save original props
-        const length = Error.stackTraceLimit;
+        const length = V8Error.stackTraceLimit;
         // eslint-disable-next-line no-underscore-dangle
-        const _prepareStackTrace = Error.prepareStackTrace;
+        const _prepareStackTrace = V8Error.prepareStackTrace;
         // This will be called when we access the `stack` property
-        Error.prepareStackTrace = (_, stack) => stack;
+        V8Error.prepareStackTrace = (_, stack) => stack;
         // in channel errors, the error was already serialized so we need to handle both string and CallSite[]
         const isString = typeof err.stack === 'string';
         const stack = (isString ? err.stack?.split('\n') : err.stack) ?? [];
         // restore original props
-        Error.prepareStackTrace = _prepareStackTrace;
-        Error.stackTraceLimit = length;
+        V8Error.prepareStackTrace = _prepareStackTrace;
+        V8Error.stackTraceLimit = length;
         // stack is optional in non chromium contexts
         if (stack.length) {
             const newStack = [];
@@ -2247,31 +2319,47 @@ class RuntimeError extends Error {
         }
     }
     static getCallSite(callsToRemove = 0) {
-        const length = Error.stackTraceLimit;
+        const length = V8Error.stackTraceLimit;
         const realCallsToRemove = callsToRemove + 1; // remove this call;
-        Error.stackTraceLimit = length + realCallsToRemove;
+        const limit = typeof length === 'number' && Number.isFinite(length) ? length : 10;
         // eslint-disable-next-line no-underscore-dangle
-        const _prepareStackTrace = Error.prepareStackTrace;
-        // This will be called when we access the `stack` property
-        Error.prepareStackTrace = (_, stack) => stack;
-        // stack is optional in non chromium contexts
-        const stack = new Error().stack?.slice(realCallsToRemove) ?? [];
-        Error.prepareStackTrace = _prepareStackTrace;
-        Error.stackTraceLimit = length;
-        return stack;
+        const _prepareStackTrace = V8Error.prepareStackTrace;
+        try {
+            V8Error.stackTraceLimit = limit + realCallsToRemove;
+            // V8 only: accessing `.stack` invokes this and returns CallSite[]. Safari/Firefox ignore it.
+            V8Error.prepareStackTrace = (_, stack) => stack;
+            const rawStack = new Error().stack;
+            if (Array.isArray(rawStack)) {
+                return rawStack.slice(realCallsToRemove);
+            }
+            if (typeof rawStack === 'string' && rawStack.length > 0) {
+                return stackStringToFrames(rawStack, realCallsToRemove);
+            }
+            return [];
+        }
+        finally {
+            V8Error.prepareStackTrace = _prepareStackTrace;
+            V8Error.stackTraceLimit = length;
+        }
     }
     static prepareStackTrace(err, callSites) {
-        if (typeof Error.prepareStackTrace === 'function') {
-            return Error.prepareStackTrace(err, callSites);
-        }
-        // TODO: this is just a first iteration, we can make this "nicer" at some point
-        // const EXCLUSIONS = ['IpcRenderer', 'Object.onMessage', 'Transport.onmessage', 'MessageReceiver.onmessage'];
-        let stackTrace = `${err.name || 'Error'}: ${err.message || ''}\n`;
-        stackTrace += callSites
-            .map((line) => `    at ${line}`)
-            // .filter((line) => !EXCLUSIONS.some((l) => line.includes(l)))
-            .join('\n');
-        return stackTrace;
+        const header = `${err.name || 'Error'}: ${err.message || ''}`;
+        const frames = typeof callSites === 'string' ? stackStringToFrames(callSites, 0) : callSites;
+        if (!Array.isArray(frames) || frames.length === 0) {
+            return header;
+        }
+        if (isCallSiteArray(frames)) {
+            const prepare = V8Error.prepareStackTrace;
+            // Only V8 CallSite[] may be passed to a user-supplied Error.prepareStackTrace.
+            if (typeof prepare === 'function') {
+                return prepare(err, frames);
+            }
+            // TODO: this is just a first iteration, we can make this "nicer" at some point
+            // const EXCLUSIONS = ['IpcRenderer', 'Object.onMessage', 'Transport.onmessage', 'MessageReceiver.onmessage'];
+            return `${header}\n${frames.map((line) => `    at ${line}`).join('\n')}`;
+        }
+        // Native Safari/Firefox frames already include their engine's format (`func@file:line:col`).
+        return `${header}\n${frames.join('\n')}`;
     }
     /*
 
@@ -15113,7 +15201,7 @@ class InteropClient extends Base {
      *
      * getLastFocusedView()
      *     .then(lastFocusedViewIdentity => {
-     *         joinViewToContextGroup('red', lastFocusedViewIdentity)
+     *         joinViewToContextGroup('fdc3.channel.1', lastFocusedViewIdentity)
      *     })
      * ```
      */
@@ -15163,7 +15251,7 @@ class InteropClient extends Base {
      *
      * @example
      * ```js
-     * fin.me.interop.getAllClientsInContextGroup('red')
+     * fin.me.interop.getAllClientsInContextGroup('fdc3.channel.1')
      *     .then(clientsInContextGroup => {
      *         console.log(clientsInContextGroup)
      *     })
@@ -15187,7 +15275,7 @@ class InteropClient extends Base {
      *
      * @example
      * ```js
-     * fin.me.interop.getInfoForContextGroup('red')
+     * fin.me.interop.getInfoForContextGroup('fdc3.channel.1')
      *     .then(contextGroupInfo => {
      *         console.log(contextGroupInfo.displayMetadata.name)
      *         console.log(contextGroupInfo.displayMetadata.color)
@@ -15276,12 +15364,12 @@ class InteropClient extends Base {
      *
      * @example
      * ```js
-     * await fin.me.interop.joinContextGroup('yellow');
+     * await fin.me.interop.joinContextGroup('fdc3.channel.3');
      * await fin.me.interop.setContext({ type: 'instrument', id: { ticker: 'FOO' }});
      * const currentContext = await fin.me.interop.getCurrentContext();
      *
      * // with a specific context
-     * await fin.me.interop.joinContextGroup('yellow');
+     * await fin.me.interop.joinContextGroup('fdc3.channel.3');
      * await fin.me.interop.setContext({ type: 'country', id: { ISOALPHA3: 'US' }});
      * await fin.me.interop.setContext({ type: 'instrument', id: { ticker: 'FOO' }});
      * const currentContext = await fin.me.interop.getCurrentContext('country');
@@ -15918,15 +16006,18 @@ class FDC3ModuleBase {
     async joinChannel(channelId) {
         this.wire.recordAnalytic('fdc3-join-channel');
         try {
+            const contextGroup = await this.client.getInfoForContextGroup(channelId);
+            if (!contextGroup) {
+                console.error(`No User Channel was found with the ID "${channelId}". If this is an App Channel, use getOrCreateChannel instead.`);
+                throw new Error(ChannelError.NoChannelFound);
+            }
             return await this.client.joinContextGroup(channelId);
         }
         catch (error) {
-            if (error.message === BROKER_ERRORS.joinSessionContextGroupWithJoinContextGroup) {
-                console.error('The Channel you have tried to join is an App Channel. Custom Channels can only be defined by the Interop Broker through code or manifest configuration. Please use getOrCreateChannel.');
-            }
-            else {
-                console.error(error.message);
+            if (error.message === ChannelError.NoChannelFound) {
+                throw new Error(ChannelError.NoChannelFound);
             }
+            console.error(error.message);
             if (error.message.startsWith('Attempting to join a context group that does not exist')) {
                 throw new Error(ChannelError.NoChannelFound);
             }
@@ -16606,7 +16697,7 @@ class InteropModule extends Base {
      * @example
      * ```js
      * const interopConfig = {
-     *     currentContextGroup: 'green'
+     *     currentContextGroup: 'fdc3.channel.4'
      * }
      *
      * const interopBroker = await fin.Interop.init('openfin');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openfin/remote-adapter",
-  "version": "46.100.64",
+  "version": "46.100.66",
   "description": "Establish intermachine runtime connections using webRTC.",
   "license": "SEE LICENSE IN LICENSE.md",
   "private": false,
@@ -16,7 +16,7 @@
   "dependencies": {
     "es-toolkit": "^1.39.3",
     "tslib": "2.8.1",
-    "@openfin/core": "46.100.64"
+    "@openfin/core": "46.100.66"
   },
   "scripts": {
     "prebuild": "rimraf ./out",