@openfeed/sdk-js 1.3.2 → 1.3.3

package/.releases/CHANGELOG-1.3.3.md

@@ -0,0 +1,10 @@
+# Changelog
+
+All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
+
+### [1.3.2](https://github.com/openfeed-org/sdk-js/compare/1.3.1...1.3.2) (2025-01-23)
+
+
+### Bug Fixes
+
+* address issues with subscription type and error subscription messages, expand tests ([8c82453](https://github.com/openfeed-org/sdk-js/commit/8c82453f18435418b30d1f5c37a6106bb1e50a65))

package/CHANGELOG.md

@@ -2,9 +2,9 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
-### [1.3.2](https://github.com/openfeed-org/sdk-js/compare/1.3.1...1.3.2) (2025-01-23)
+### [1.3.3](https://github.com/openfeed-org/sdk-js/compare/1.3.2...1.3.3) (2025-03-28)
 
 
 ### Bug Fixes
 
-* address issues with subscription type and error subscription messages, expand tests ([8c82453](https://github.com/openfeed-org/sdk-js/commit/8c82453f18435418b30d1f5c37a6106bb1e50a65))
+* take a better approach when identifying subscription responses - use correlation ([d841c79](https://github.com/openfeed-org/sdk-js/commit/d841c7996c068b10675e20832c413c4da466996a))

package/dist/generated/version.d.ts

@@ -1 +1 @@
-export declare const version = "1.3.2";
+export declare const version = "1.3.3";

package/dist/index.js

@@ -8600,7 +8600,7 @@ class OpenFeedConnection {
     }
   }
 }
-const version = "1.3.2";
+const version = "1.3.3";
 const getClientVersion = async (clientId) => {
   var _a, _b, _c, _d, _e, _f;
   let platformDescription;
@@ -8856,29 +8856,33 @@ class OpenFeedListeners {
         return res ?? [void 0, void 0];
       };
       const includesSymbolSubscription = (arr, item) => {
-        return arr.some(([symbol, type]) => symbol === item[0] && type === item[1]);
+        return arr.some(([symbol, correlationId]) => symbol === item[0] && correlationId === item[1]);
       };
       if (message.subscriptionResponse) {
-        const { marketId, symbol, unsubscribe, status, subscriptionType } = message.subscriptionResponse;
+        const { marketId, symbol, unsubscribe, status, correlationId } = message.subscriptionResponse;
+        const corIdStr = correlationId.toString();
         if (marketId !== Long.ZERO) {
           [def, symbols] = getInstrumentDefinition(marketId);
           if ((status == null ? void 0 : status.result) === Result.SUCCESS) {
-            const currentEntry = [symbol, subscriptionType];
+            const currentEntry = [symbol, corIdStr];
             if (!unsubscribe) {
               if (!symbols) {
                 symbols = [currentEntry];
               } else if (!includesSymbolSubscription(symbols, currentEntry)) {
                 symbols = [...symbols, currentEntry];
               }
+              this.instrumentByMarketId.set(marketId.toString(), [def, symbols]);
             } else {
+              let symbolsToSave;
               if (symbols) {
-                symbols = symbols.filter(([s, t]) => !(s === symbol && t === subscriptionType));
+                symbolsToSave = symbols.filter(([s, t]) => !(s === symbol && t === corIdStr));
               }
-              if (!symbols) {
+              if (!(symbolsToSave == null ? void 0 : symbolsToSave.length)) {
                 this.instrumentByMarketId.delete(marketId.toString());
+              } else {
+                this.instrumentByMarketId.set(marketId.toString(), [def, symbolsToSave]);
               }
             }
-            this.instrumentByMarketId.set(marketId.toString(), [def, symbols]);
           }
         }
       } else if (message.instrumentDefinition) {

package/dist/node.js

@@ -10825,19 +10825,19 @@ var Result = /* @__PURE__ */ ((Result2) => {
   Result2[Result2["UNRECOGNIZED"] = -1] = "UNRECOGNIZED";
   return Result2;
 })(Result || {});
-var SubscriptionType = /* @__PURE__ */ ((SubscriptionType3) => {
-  SubscriptionType3[SubscriptionType3["ALL"] = 0] = "ALL";
-  SubscriptionType3[SubscriptionType3["QUOTE"] = 1] = "QUOTE";
-  SubscriptionType3[SubscriptionType3["QUOTE_PARTICIPANT"] = 2] = "QUOTE_PARTICIPANT";
-  SubscriptionType3[SubscriptionType3["DEPTH_PRICE"] = 3] = "DEPTH_PRICE";
-  SubscriptionType3[SubscriptionType3["DEPTH_ORDER"] = 4] = "DEPTH_ORDER";
-  SubscriptionType3[SubscriptionType3["TRADES"] = 5] = "TRADES";
-  SubscriptionType3[SubscriptionType3["CUMULATIVE_VOLUME"] = 6] = "CUMULATIVE_VOLUME";
-  SubscriptionType3[SubscriptionType3["OHLC"] = 7] = "OHLC";
-  SubscriptionType3[SubscriptionType3["OHLC_NON_REGULAR"] = 8] = "OHLC_NON_REGULAR";
-  SubscriptionType3[SubscriptionType3["SETTLEMENT"] = 9] = "SETTLEMENT";
-  SubscriptionType3[SubscriptionType3["UNRECOGNIZED"] = -1] = "UNRECOGNIZED";
-  return SubscriptionType3;
+var SubscriptionType = /* @__PURE__ */ ((SubscriptionType2) => {
+  SubscriptionType2[SubscriptionType2["ALL"] = 0] = "ALL";
+  SubscriptionType2[SubscriptionType2["QUOTE"] = 1] = "QUOTE";
+  SubscriptionType2[SubscriptionType2["QUOTE_PARTICIPANT"] = 2] = "QUOTE_PARTICIPANT";
+  SubscriptionType2[SubscriptionType2["DEPTH_PRICE"] = 3] = "DEPTH_PRICE";
+  SubscriptionType2[SubscriptionType2["DEPTH_ORDER"] = 4] = "DEPTH_ORDER";
+  SubscriptionType2[SubscriptionType2["TRADES"] = 5] = "TRADES";
+  SubscriptionType2[SubscriptionType2["CUMULATIVE_VOLUME"] = 6] = "CUMULATIVE_VOLUME";
+  SubscriptionType2[SubscriptionType2["OHLC"] = 7] = "OHLC";
+  SubscriptionType2[SubscriptionType2["OHLC_NON_REGULAR"] = 8] = "OHLC_NON_REGULAR";
+  SubscriptionType2[SubscriptionType2["SETTLEMENT"] = 9] = "SETTLEMENT";
+  SubscriptionType2[SubscriptionType2["UNRECOGNIZED"] = -1] = "UNRECOGNIZED";
+  return SubscriptionType2;
 })(SubscriptionType || {});
 var SymbolType = /* @__PURE__ */ ((SymbolType2) => {
   SymbolType2[SymbolType2["BARCHART"] = 0] = "BARCHART";
@@ -12233,7 +12233,7 @@ var OpenFeedConnection = class {
 };
 
 // generated/version.ts
-var version = "1.3.2";
+var version = "1.3.3";
 
 // src/utilities/client_version.ts
 var getClientVersion = async (clientId) => {
@@ -12497,29 +12497,33 @@ var OpenFeedListeners = class {
       return res ?? [void 0, void 0];
     };
     const includesSymbolSubscription = (arr, item) => {
-      return arr.some(([symbol, type]) => symbol === item[0] && type === item[1]);
+      return arr.some(([symbol, correlationId]) => symbol === item[0] && correlationId === item[1]);
     };
     if (message.subscriptionResponse) {
-      const { marketId, symbol, unsubscribe, status, subscriptionType } = message.subscriptionResponse;
+      const { marketId, symbol, unsubscribe, status, correlationId } = message.subscriptionResponse;
+      const corIdStr = correlationId.toString();
       if (marketId !== long_default.ZERO) {
         [def, symbols] = getInstrumentDefinition(marketId);
         if ((status == null ? void 0 : status.result) === 1 /* SUCCESS */) {
-          const currentEntry = [symbol, subscriptionType];
+          const currentEntry = [symbol, corIdStr];
           if (!unsubscribe) {
             if (!symbols) {
               symbols = [currentEntry];
             } else if (!includesSymbolSubscription(symbols, currentEntry)) {
               symbols = [...symbols, currentEntry];
             }
+            this.instrumentByMarketId.set(marketId.toString(), [def, symbols]);
           } else {
+            let symbolsToSave;
             if (symbols) {
-              symbols = symbols.filter(([s, t]) => !(s === symbol && t === subscriptionType));
+              symbolsToSave = symbols.filter(([s, t]) => !(s === symbol && t === corIdStr));
             }
-            if (!symbols) {
+            if (!(symbolsToSave == null ? void 0 : symbolsToSave.length)) {
               this.instrumentByMarketId.delete(marketId.toString());
+            } else {
+              this.instrumentByMarketId.set(marketId.toString(), [def, symbolsToSave]);
             }
           }
-          this.instrumentByMarketId.set(marketId.toString(), [def, symbols]);
         }
       }
     } else if (message.instrumentDefinition) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@openfeed/sdk-js",
-    "version": "1.3.2",
+    "version": "1.3.3",
     "description": "JavaScript SDK for Barchart OpenFeed",
     "main": "dist/node.js",
     "browser": "dist/index.js",