@openedx/frontend-base 1.0.0-alpha.0 → 1.0.0-alpha.10

package/config/eslint/base.eslint.config.js

@@ -31,7 +31,6 @@ module.exports = tseslint.config(eslint.configs.recommended, ...tseslint.configs
             ...globals.browser,
             ...globals.node,
             ...globals.jest,
-            PARAGON_THEME: 'readonly',
             newrelic: 'readonly',
         },
     },
@@ -79,6 +78,7 @@ module.exports = tseslint.config(eslint.configs.recommended, ...tseslint.configs
                 caughtErrors: 'none',
             }],
         '@typescript-eslint/no-empty-function': 'off',
+        '@typescript-eslint/prefer-nullish-coalescing': 'off',
         '@stylistic/semi': ['error', 'always', { omitLastInOneLineBlock: true, omitLastInOneLineClassBody: true }],
         '@stylistic/quotes': ['error', 'single', {
                 avoidEscape: true,

package/config/jest/jest.config.js

@@ -9,6 +9,7 @@ module.exports = {
     moduleNameMapper: {
         '\\.(css|scss)$': require.resolve('identity-obj-proxy'),
         'site.config': path.resolve(process.cwd(), './site.config.test.tsx'),
+        '^@src/(.*)$': '<rootDir>/src/$1',
     },
     collectCoverageFrom: [
         'src/**/*.{js,jsx,ts,tsx}',

package/config/types.js

@@ -12,8 +12,6 @@ var ConfigTypes;
 })(ConfigTypes || (exports.ConfigTypes = ConfigTypes = {}));
 var CommandTypes;
 (function (CommandTypes) {
-    CommandTypes["RELEASE"] = "release";
-    CommandTypes["PACK"] = "pack";
     CommandTypes["LINT"] = "lint";
     CommandTypes["TEST"] = "test";
     CommandTypes["BUILD"] = "build";

package/config/webpack/common-config/all/getStylesheetRule.js

@@ -87,7 +87,7 @@ function getStyleUseConfig(mode) {
                     ],
                     // Silences compiler deprecation warnings.  They mostly come from bootstrap and/or paragon.
                     quietDeps: true,
-                    silenceDeprecations: ['abs-percent', 'color-functions', 'import', 'mixed-decls', 'global-builtin', 'legacy-js-api'],
+                    silenceDeprecations: ['abs-percent', 'color-functions', 'import', 'global-builtin', 'legacy-js-api'],
                 },
             },
         },

package/config/webpack/plugins/html-webpack-new-relic-plugin/test/HtmlWebpackNewRelicPlugin.test.js

@@ -0,0 +1,66 @@
+"use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+const fs_1 = __importDefault(require("fs"));
+const html_webpack_plugin_1 = __importDefault(require("html-webpack-plugin"));
+const path_1 = __importDefault(require("path"));
+const webpack_1 = __importDefault(require("webpack"));
+const HtmlWebpackNewRelicPlugin_1 = __importDefault(require("../HtmlWebpackNewRelicPlugin"));
+const OUTPUT_DIR = path_1.default.join(__dirname, './dist');
+describe('HtmlWebpackNewRelicPlugin', () => {
+    const testPluginOptions = {
+        accountID: '121212',
+        agentID: '343434',
+        trustKey: '565656',
+        licenseKey: '123456',
+        applicationID: '654321',
+    };
+    afterEach(() => {
+        if (fs_1.default.existsSync(OUTPUT_DIR)) {
+            fs_1.default.rmSync(OUTPUT_DIR, { recursive: true, force: true });
+        }
+    });
+    it('should append new relic script to body', done => {
+        (0, webpack_1.default)({
+            entry: path_1.default.resolve(__dirname, 'fixtures', 'entry.js'),
+            output: {
+                path: path_1.default.resolve(__dirname, './dist'),
+            },
+            plugins: [
+                new html_webpack_plugin_1.default(),
+                new HtmlWebpackNewRelicPlugin_1.default(testPluginOptions),
+            ],
+        }, (err) => {
+            const htmlFile = path_1.default.resolve(OUTPUT_DIR, 'index.html');
+            expect(err).toBeNull();
+            expect(fs_1.default.existsSync(htmlFile)).toBe(true);
+            const file = fs_1.default.readFileSync(path_1.default.resolve(OUTPUT_DIR, htmlFile), { encoding: 'utf-8' }, (error, data) => data.toString());
+            Object.entries(testPluginOptions).forEach(([optionName, optionValue]) => {
+                expect(file.indexOf(`${optionName}:"${optionValue}"`)).toBeGreaterThan(-1);
+            });
+            done();
+        });
+    });
+    describe('when its missing configuration variables', () => {
+        function testMissingOption(missingOptionName) {
+            it(`should throw error if ${missingOptionName} is missing`, done => {
+                const compiler = (0, webpack_1.default)({
+                    entry: path_1.default.resolve(__dirname, 'fixtures', 'entry.js'),
+                    output: {
+                        path: path_1.default.resolve(__dirname, '../dist'),
+                    },
+                    plugins: [new html_webpack_plugin_1.default()],
+                });
+                const optionsMissingOne = { ...testPluginOptions };
+                delete optionsMissingOne[missingOptionName];
+                expect(() => compiler.options.plugins.push(new HtmlWebpackNewRelicPlugin_1.default(optionsMissingOne))).toThrow(`${missingOptionName} argument is required`);
+                done();
+            });
+        }
+        Object.keys(testPluginOptions).forEach((key) => {
+            testMissingOption(key);
+        });
+    });
+});

package/config/webpack/webpack.config.build.js

@@ -9,13 +9,9 @@ const path_1 = __importDefault(require("path"));
 const webpack_bundle_analyzer_1 = require("webpack-bundle-analyzer");
 const webpack_remove_empty_scripts_1 = __importDefault(require("webpack-remove-empty-scripts"));
 const common_config_1 = require("./common-config");
-const ParagonWebpackPlugin_1 = __importDefault(require("./plugins/paragon-webpack-plugin/ParagonWebpackPlugin"));
 const getLocalAliases_1 = __importDefault(require("./utils/getLocalAliases"));
 const getPublicPath_1 = __importDefault(require("./utils/getPublicPath"));
 const getResolvedSiteConfigPath_1 = __importDefault(require("./utils/getResolvedSiteConfigPath"));
-const paragonUtils_1 = require("./utils/paragonUtils");
-const paragonThemeCss = (0, paragonUtils_1.getParagonThemeCss)(process.cwd());
-const brandThemeCss = (0, paragonUtils_1.getParagonThemeCss)(process.cwd(), { isBrandOverride: true });
 const aliases = (0, getLocalAliases_1.default)();
 const resolvedSiteConfigPath = (0, getResolvedSiteConfigPath_1.default)('site.config.build.tsx');
 const config = {
@@ -23,8 +19,6 @@ const config = {
     devtool: 'source-map',
     entry: {
         app: path_1.default.resolve(process.cwd(), 'node_modules/@openedx/frontend-base/shell/site'),
-        ...(0, paragonUtils_1.getParagonEntryPoints)(paragonThemeCss),
-        ...(0, paragonUtils_1.getParagonEntryPoints)(brandThemeCss),
     },
     output: {
         filename: '[name].[chunkhash].js',
@@ -36,6 +30,7 @@ const config = {
         alias: {
             ...aliases,
             'site.config': resolvedSiteConfigPath,
+            '@src': path_1.default.resolve(process.cwd(), 'src'),
         },
         extensions: ['.js', '.jsx', '.ts', '.tsx'],
     },
@@ -51,10 +46,6 @@ const config = {
         runtimeChunk: 'single',
         splitChunks: {
             chunks: 'all',
-            cacheGroups: {
-                ...(0, paragonUtils_1.getParagonCacheGroups)(paragonThemeCss),
-                ...(0, paragonUtils_1.getParagonCacheGroups)(brandThemeCss),
-            },
         },
         minimizer: (0, common_config_1.getImageMinimizer)(),
     },
@@ -65,7 +56,6 @@ const config = {
         // See: https://www.npmjs.com/package/webpack-remove-empty-scripts#usage-with-mini-css-extract-plugin
         new webpack_remove_empty_scripts_1.default(),
         // Writes the extracted CSS from each entry to a file in the output directory.
-        new ParagonWebpackPlugin_1.default(),
         new mini_css_extract_plugin_1.default({
             filename: '[name].[chunkhash].css',
         }),

package/config/webpack/webpack.config.dev.js

@@ -9,20 +9,14 @@ const mini_css_extract_plugin_1 = __importDefault(require("mini-css-extract-plug
 const path_1 = __importDefault(require("path"));
 const webpack_remove_empty_scripts_1 = __importDefault(require("webpack-remove-empty-scripts"));
 const common_config_1 = require("./common-config");
-const ParagonWebpackPlugin_1 = __importDefault(require("./plugins/paragon-webpack-plugin/ParagonWebpackPlugin"));
 const getLocalAliases_1 = __importDefault(require("./utils/getLocalAliases"));
 const getPublicPath_1 = __importDefault(require("./utils/getPublicPath"));
 const getResolvedSiteConfigPath_1 = __importDefault(require("./utils/getResolvedSiteConfigPath"));
-const paragonUtils_1 = require("./utils/paragonUtils");
-const paragonThemeCss = (0, paragonUtils_1.getParagonThemeCss)(process.cwd());
-const brandThemeCss = (0, paragonUtils_1.getParagonThemeCss)(process.cwd(), { isBrandOverride: true });
 const aliases = (0, getLocalAliases_1.default)();
 const resolvedSiteConfigPath = (0, getResolvedSiteConfigPath_1.default)('site.config.dev.tsx');
 const config = {
     entry: {
         app: path_1.default.resolve(process.cwd(), 'node_modules/@openedx/frontend-base/shell/site'),
-        ...(0, paragonUtils_1.getParagonEntryPoints)(paragonThemeCss),
-        ...(0, paragonUtils_1.getParagonEntryPoints)(brandThemeCss),
     },
     output: {
         path: path_1.default.resolve(process.cwd(), './dist'),
@@ -32,6 +26,7 @@ const config = {
         alias: {
             ...aliases,
             'site.config': resolvedSiteConfigPath,
+            '@src': path_1.default.resolve(process.cwd(), 'src'),
         },
         extensions: ['.js', '.jsx', '.ts', '.tsx'],
     },
@@ -47,10 +42,6 @@ const config = {
     optimization: {
         splitChunks: {
             chunks: 'all',
-            cacheGroups: {
-                ...(0, paragonUtils_1.getParagonCacheGroups)(paragonThemeCss),
-                ...(0, paragonUtils_1.getParagonCacheGroups)(brandThemeCss),
-            },
         },
         minimizer: (0, common_config_1.getImageMinimizer)(),
     },
@@ -60,7 +51,6 @@ const config = {
         // This helps to clean up the final bundle application
         // See: https://www.npmjs.com/package/webpack-remove-empty-scripts#usage-with-mini-css-extract-plugin
         new webpack_remove_empty_scripts_1.default(),
-        new ParagonWebpackPlugin_1.default(),
         // Writes the extracted CSS from each entry to a file in the output directory.
         new mini_css_extract_plugin_1.default({
             filename: '[name].css',
@@ -72,5 +62,9 @@ const config = {
     // This configures webpack-dev-server which serves bundles from memory and provides live
     // reloading.
     devServer: (0, common_config_1.getDevServer)(),
+    // Limit the number of watched files to avoid `inotify` resource starvation.
+    watchOptions: {
+        ignored: /node_modules/
+    }
 };
 exports.default = config;

package/config/webpack/webpack.config.dev.shell.js

@@ -11,21 +11,15 @@ const path_1 = __importDefault(require("path"));
 const react_refresh_typescript_1 = __importDefault(require("react-refresh-typescript"));
 const webpack_remove_empty_scripts_1 = __importDefault(require("webpack-remove-empty-scripts"));
 const common_config_1 = require("./common-config");
-const ParagonWebpackPlugin_1 = __importDefault(require("./plugins/paragon-webpack-plugin/ParagonWebpackPlugin"));
 const html_webpack_plugin_1 = __importDefault(require("html-webpack-plugin"));
 const getLocalAliases_1 = __importDefault(require("./utils/getLocalAliases"));
 const getPublicPath_1 = __importDefault(require("./utils/getPublicPath"));
 const getResolvedSiteConfigPath_1 = __importDefault(require("./utils/getResolvedSiteConfigPath"));
-const paragonUtils_1 = require("./utils/paragonUtils");
-const paragonThemeCss = (0, paragonUtils_1.getParagonThemeCss)(process.cwd());
-const brandThemeCss = (0, paragonUtils_1.getParagonThemeCss)(process.cwd(), { isBrandOverride: true });
 const aliases = (0, getLocalAliases_1.default)();
 const resolvedSiteConfigPath = (0, getResolvedSiteConfigPath_1.default)('shell/site.config.dev.tsx');
 const config = {
     entry: {
         app: path_1.default.resolve(process.cwd(), 'shell/site'),
-        ...(0, paragonUtils_1.getParagonEntryPoints)(paragonThemeCss),
-        ...(0, paragonUtils_1.getParagonEntryPoints)(brandThemeCss),
     },
     output: {
         path: path_1.default.resolve(process.cwd(), './dist'),
@@ -35,6 +29,7 @@ const config = {
         alias: {
             ...aliases,
             'site.config': resolvedSiteConfigPath,
+            '@src': path_1.default.resolve(process.cwd(), 'src'),
         },
         extensions: ['.js', '.jsx', '.ts', '.tsx'],
     },
@@ -77,10 +72,6 @@ const config = {
     optimization: {
         splitChunks: {
             chunks: 'all',
-            cacheGroups: {
-                ...(0, paragonUtils_1.getParagonCacheGroups)(paragonThemeCss),
-                ...(0, paragonUtils_1.getParagonCacheGroups)(brandThemeCss),
-            },
         },
         minimizer: (0, common_config_1.getImageMinimizer)(),
     },
@@ -90,7 +81,6 @@ const config = {
         // This helps to clean up the final bundle application
         // See: https://www.npmjs.com/package/webpack-remove-empty-scripts#usage-with-mini-css-extract-plugin
         new webpack_remove_empty_scripts_1.default(),
-        new ParagonWebpackPlugin_1.default(),
         // Writes the extracted CSS from each entry to a file in the output directory.
         new mini_css_extract_plugin_1.default({
             filename: '[name].css',
@@ -106,5 +96,9 @@ const config = {
     // This configures webpack-dev-server which serves bundles from memory and provides live
     // reloading.
     devServer: (0, common_config_1.getDevServer)(),
+    // Limit the number of watched files to avoid `inotify` resource starvation.
+    watchOptions: {
+        ignored: /node_modules/
+    }
 };
 exports.default = config;

package/package.json

@@ -1,11 +1,18 @@
 {
   "name": "@openedx/frontend-base",
-  "version": "1.0.0-alpha.0",
+  "version": "1.0.0-alpha.10",
   "description": "Build tools, setup and config for frontend apps",
   "publishConfig": {
     "access": "public"
   },
   "main": "index.ts",
+  "files": [
+    "/config",
+    "/runtime",
+    "/tools/dist",
+    "/shell",
+    "/types.ts"
+  ],
   "bin": {
     "intl-imports.js": "tools/dist/cli/scripts/intl-imports.js",
     "openedx": "tools/dist/cli/openedx.js",
@@ -79,6 +86,7 @@
     "image-minimizer-webpack-plugin": "3.8.3",
     "jest": "^29.7.0",
     "jest-environment-jsdom": "^29.7.0",
+    "jest-localstorage-mock": "^2.4.26",
     "jwt-decode": "^3.1.2",
     "localforage": "^1.10.0",
     "localforage-memoryStorageDriver": "^0.9.2",
@@ -94,7 +102,7 @@
     "postcss-rtlcss": "^5.5.0",
     "prop-types": "^15.8.1",
     "react-dev-utils": "12.0.1",
-    "react-focus-on": "^3.9.4",
+    "react-focus-on": "<3.10.0",
     "react-intl": "^6.6.6",
     "react-refresh": "0.16.0",
     "react-refresh-typescript": "^2.0.9",
@@ -139,7 +147,7 @@
     "nodemon": "^3.1.4"
   },
   "peerDependencies": {
-    "@openedx/paragon": "^22.20.2",
+    "@openedx/paragon": "^23.4.5",
     "@tanstack/react-query": "^5.81.2",
     "react": "^18.3.1",
     "react-dom": "^18.3.1",

package/runtime/__mocks__/file.js

@@ -0,0 +1 @@
+export default 'FileMock';

package/runtime/__mocks__/svg.js

@@ -0,0 +1 @@
+export default 'SvgURL';

package/runtime/__mocks__/universal-cookie.js

@@ -0,0 +1,6 @@
+const mockCookiesImplementation = {
+  get: jest.fn(),
+  remove: jest.fn(),
+};
+
+module.exports = () => mockCookiesImplementation;

package/runtime/analytics/interface.test.js

@@ -0,0 +1,242 @@
+import {
+  configureAnalytics,
+  identifyAnonymousUser,
+  identifyAuthenticatedUser,
+  sendPageEvent,
+  sendTrackEvent,
+  sendTrackingLogEvent,
+  SegmentAnalyticsService,
+} from './index';
+
+const eventType = 'test.event';
+const eventData = {
+  testShallow: 'test-shallow',
+  testObject: {
+    testDeep: 'test-deep',
+  },
+};
+const testUserId = 99;
+const mockLoggingService = {
+  logError: jest.fn(),
+  logInfo: jest.fn(),
+};
+// The actual ApiClient is a function, so while this feels weird, it accurately models the real
+// thing.
+const mockAuthApiClient = () => {
+};
+mockAuthApiClient.post = jest.fn().mockResolvedValue(undefined);
+
+// SegmentAnalyticsService inserts a script before the first script element
+// in the document. Add one here.
+document.body.innerHTML = '<script id="stub" />';
+
+describe('Analytics', () => {
+  let service;
+  let userIdFunction;
+
+  beforeEach(() => {
+    window.analytics = [];
+  });
+
+  function afterConfigure() {
+    mockLoggingService.logError.mockReset();
+    mockAuthApiClient.post.mockReset();
+    mockAuthApiClient.post.mockResolvedValue(undefined);
+    window.analytics.identify = jest.fn();
+    window.analytics.page = jest.fn();
+    window.analytics.track = jest.fn();
+    window.analytics.reset = jest.fn();
+    userIdFunction = jest.fn();
+    window.analytics.user = jest.fn(() => ({
+      id: userIdFunction,
+    }));
+    window.analytics.ready = jest.fn((callback) => {
+      if (callback) {
+        callback();
+      }
+    });
+  }
+
+  describe('with valid segmentKey', () => {
+    beforeEach(() => {
+      service = configureAnalytics(SegmentAnalyticsService, {
+        loggingService: mockLoggingService,
+        httpClient: mockAuthApiClient,
+        config: {
+          lmsBaseUrl: 'https://example.com',
+          segmentKey: 'test-key',
+        },
+      });
+
+      afterConfigure();
+
+      expect(global.analytics.invoked).toBe(true);
+      expect(service.segmentInitialized).toBe(true);
+    });
+
+    describe('analytics sendTrackingLogEvent', () => {
+      it('posts expected data when successful', () => {
+        expect.assertions(6);
+        return sendTrackingLogEvent(eventType, eventData)
+          .then(() => {
+            expect(mockAuthApiClient.post.mock.calls.length).toEqual(1);
+            expect(mockAuthApiClient.post.mock.calls[0][0]).toEqual('https://example.com/event');
+            const expectedData = 'event_type=test.event&event=%7B%22test_shallow%22%3A%22test-shallow%22%2C%22test_object%22%3A%7B%22test_deep%22%3A%22test-deep%22%7D%7D&page=http%3A%2F%2Flocalhost%2F';
+            expect(mockAuthApiClient.post.mock.calls[0][1]).toEqual(expectedData);
+            const config = mockAuthApiClient.post.mock.calls[0][2];
+            expect(config.headers['Content-Type']).toEqual('application/x-www-form-urlencoded');
+          });
+      });
+
+      it('calls loggingService.logError on error', () => {
+        mockAuthApiClient.post.mockRejectedValue('test-error');
+        expect.assertions(4);
+        return sendTrackingLogEvent(eventType, eventData)
+          .then(() => {
+            expect(mockLoggingService.logError.mock.calls.length).toBe(1);
+            expect(mockLoggingService.logError).toBeCalledWith('test-error');
+          });
+      });
+    });
+
+    describe('analytics identifyAuthenticatedUser', () => {
+      it('calls Segment identify on success', () => {
+        const testTraits = { anything: 'Yay!' };
+        identifyAuthenticatedUser(testUserId, testTraits);
+
+        expect(window.analytics.identify.mock.calls.length).toBe(1);
+        expect(window.analytics.identify).toBeCalledWith(testUserId, testTraits);
+      });
+
+      it('throws error if userId is not supplied', () => {
+        expect(() => identifyAuthenticatedUser(null))
+          .toThrowError(new Error('UserId is required for identifyAuthenticatedUser.'));
+      });
+    });
+
+    describe('analytics identifyAnonymousUser', () => {
+      it('does not call segment reset for no previous segment user', () => {
+        window.analytics.user = () => ({ id: () => null });
+        const testTraits = { anything: 'Yay!' };
+        identifyAnonymousUser(testTraits);
+
+        expect(window.analytics.reset.mock.calls.length).toBe(0);
+      });
+
+      it('calls segment reset for a previous segment user', () => {
+        window.analytics.user = () => ({ id: () => 7 });
+        const testTraits = { anything: 'Yay!' };
+        identifyAnonymousUser(testTraits);
+
+        expect(window.analytics.reset.mock.calls.length).toBe(1);
+      });
+    });
+
+    function testSendPageAfterIdentify(identifyFunction) {
+      identifyFunction();
+
+      const testCategory = 'test-category';
+      const testName = 'test-name';
+      const testProperties = { anything: 'Yay!' };
+      sendPageEvent(testCategory, testName, testProperties);
+
+      expect(window.analytics.page.mock.calls.length).toBe(1);
+      expect(window.analytics.page).toBeCalledWith(testCategory, testName, testProperties);
+    }
+
+    describe('analytics send Page event', () => {
+      it('calls Segment page on success after identifyAuthenticatedUser', () => {
+        const userId = 1;
+        testSendPageAfterIdentify(() => identifyAuthenticatedUser(userId));
+      });
+
+      it('calls Segment page on success after identifyAnonymousUser', () => {
+        testSendPageAfterIdentify(identifyAnonymousUser);
+      });
+
+      it('fails if page called with no identify', () => {
+        sendPageEvent();
+
+        expect(mockLoggingService.logError.mock.calls.length).toBe(1);
+        expect(mockLoggingService.logError).toBeCalledWith('Identify must be called before other tracking events.');
+      });
+    });
+
+    function testSendTrackEventAfterIdentify(identifyFunction) {
+      identifyFunction();
+
+      const testName = 'test-name';
+      const testProperties = { anything: 'Yay!' };
+      sendTrackEvent(testName, testProperties);
+
+      expect(window.analytics.track.mock.calls.length).toBe(1);
+      expect(window.analytics.track).toBeCalledWith(testName, testProperties);
+    }
+
+    describe('analytics send Track event', () => {
+      it('calls Segment track on success after identifyAuthenticatedUser', () => {
+        const userId = 1;
+        testSendTrackEventAfterIdentify(() => identifyAuthenticatedUser(userId));
+      });
+
+      it('calls Segment track on success after identifyAnonymousUser', () => {
+        testSendTrackEventAfterIdentify(identifyAnonymousUser);
+      });
+
+      it('fails if track called with no identify', () => {
+        sendTrackEvent();
+
+        expect(mockLoggingService.logError.mock.calls.length).toBe(1);
+        expect(mockLoggingService.logError).toBeCalledWith('Identify must be called before other tracking events.');
+      });
+    });
+  });
+
+  describe('with invalid segmentKey', () => {
+    beforeEach(() => {
+      service = configureAnalytics(SegmentAnalyticsService, {
+        loggingService: mockLoggingService,
+        httpClient: mockAuthApiClient,
+        config: {
+          lmsBaseUrl: 'https://example.com',
+          segmentKey: '',
+        },
+      });
+
+      afterConfigure();
+    });
+
+    it('should not initialize Segment analytics', () => {
+      expect(global.analytics.invoked).toBeFalsy();
+      expect(service.segmentInitialized).toBe(false);
+    });
+
+    it('should not call segment track in sendTrackEvent', () => {
+      sendTrackEvent();
+      expect(window.analytics.track).not.toHaveBeenCalled();
+    });
+
+    it('should not call segment page in sendPageEvent', () => {
+      sendPageEvent();
+      expect(window.analytics.page).not.toHaveBeenCalled();
+    });
+
+    it('should not call ready, user, reset, or identify in identifyAnonymousUser', () => {
+      identifyAnonymousUser();
+
+      expect(window.analytics.ready).not.toHaveBeenCalled();
+      expect(window.analytics.user).not.toHaveBeenCalled();
+      expect(userIdFunction).not.toHaveBeenCalled();
+      expect(window.analytics.reset).not.toHaveBeenCalled();
+      expect(window.analytics.identify).not.toHaveBeenCalled();
+      expect(service.hasIdentifyBeenCalled).toBe(false);
+    });
+
+    it('should not call identify in identifyAuthenticatedUser', () => {
+      identifyAuthenticatedUser(testUserId);
+
+      expect(window.analytics.identify).not.toHaveBeenCalled();
+      expect(service.hasIdentifyBeenCalled).toBe(false);
+    });
+  });
+});