@opendaw/studio-core 0.0.130 → 0.0.132

package/dist/ui/clipboard/types/DevicesClipboardHandler.test.js

@@ -195,9 +195,10 @@ describe("DevicesClipboardHandler", () => {
             .map(pointer => pointer.box);
         const mandatoryDeps = Array.from(boxGraph.dependenciesOf(deviceBox, {
             alwaysFollowMandatory: true,
+            stopAtResources: true,
             excludeBox: (dep) => dep.ephemeral || DeviceBoxUtils.isDeviceBox(dep)
                 || dep.name === RootBox.ClassName
-        }).boxes).filter(dep => !isDefined(dep.resource));
+        }).boxes).filter(dep => dep.resource !== "preserved");
         const preserved = [deviceBox, ...ownedChildren].flatMap(root => Array.from(boxGraph.dependenciesOf(root, {
             alwaysFollowMandatory: true,
             excludeBox: (dep) => dep.ephemeral || DeviceBoxUtils.isDeviceBox(dep)
@@ -215,6 +216,7 @@ describe("DevicesClipboardHandler", () => {
                     trackContent.push(regionPointer.box);
                     const regionDeps = Array.from(boxGraph.dependenciesOf(regionPointer.box, {
                         alwaysFollowMandatory: true,
+                        stopAtResources: true,
                         excludeBox: (dep) => dep.ephemeral
                             || isInstanceOf(dep, TrackBox)
                             || DeviceBoxUtils.isDeviceBox(dep)
@@ -232,7 +234,7 @@ describe("DevicesClipboardHandler", () => {
             return true;
         });
     };
-    const makePasteMapper = (targetAudioUnit, replaceInstrument) => ({
+    const makePasteMapper = (targetAudioUnit, replaceInstrument, hasInstrument = true) => ({
         mapPointer: (pointer) => {
             if (pointer.pointerType === Pointers.InstrumentHost && replaceInstrument) {
                 return Option.wrap(targetAudioUnit.input.address);
@@ -243,7 +245,7 @@ describe("DevicesClipboardHandler", () => {
             if (pointer.pointerType === Pointers.MIDIEffectHost) {
                 return Option.wrap(targetAudioUnit.midiEffects.address);
             }
-            if (pointer.pointerType === Pointers.TrackCollection && replaceInstrument) {
+            if (pointer.pointerType === Pointers.TrackCollection) {
                 return Option.wrap(targetAudioUnit.tracks.address);
             }
             if (pointer.pointerType === Pointers.Automation && replaceInstrument) {
@@ -251,7 +253,18 @@ describe("DevicesClipboardHandler", () => {
             }
             return Option.None;
         },
-        excludeBox: (box) => !replaceInstrument && (DeviceBoxUtils.isInstrumentDeviceBox(box) || isInstanceOf(box, TrackBox))
+        excludeBox: (box) => {
+            if (replaceInstrument) {
+                return false;
+            }
+            if (DeviceBoxUtils.isInstrumentDeviceBox(box)) {
+                return true;
+            }
+            if (isInstanceOf(box, TrackBox)) {
+                return hasInstrument;
+            }
+            return false;
+        }
     });
     // ─────────────────────────────────────────────────────────
     // Audio effect paste
@@ -284,6 +297,113 @@ describe("DevicesClipboardHandler", () => {
         });
     });
     // ─────────────────────────────────────────────────────────
+    // Audio effect with automation: copy scope + paste round-trip
+    // ─────────────────────────────────────────────────────────
+    describe("audio effect with automation", () => {
+        it("includes ValueEventCollectionBox when copying effect with automation events", () => {
+            const audioUnit = createAudioUnit(source);
+            const effect = addAudioEffect(source, audioUnit, "Comp", 0);
+            const autoTrack = addAutomationTrack(source, audioUnit, effect.threshold, 0);
+            addValueRegion(source, autoTrack, 0, 960);
+            const deps = collectDeviceDependencies(effect, source.boxGraph);
+            expect(deps.filter(box => isInstanceOf(box, TrackBox)).length).toBe(1);
+            expect(deps.filter(box => isInstanceOf(box, ValueRegionBox)).length).toBe(1);
+            expect(deps.filter(box => isInstanceOf(box, ValueEventCollectionBox)).length).toBe(1);
+        });
+        it("includes mirror regions on different tracks of the same device", () => {
+            const audioUnit = createAudioUnit(source);
+            const effect = addAudioEffect(source, audioUnit, "Comp", 0);
+            const trackA = addAutomationTrack(source, audioUnit, effect.threshold, 0);
+            const trackB = addAutomationTrack(source, audioUnit, effect.ratio, 1);
+            const regionA = addValueRegion(source, trackA, 0, 960);
+            const sharedEvents = regionA.events.targetVertex.unwrap().box;
+            let regionB;
+            source.boxGraph.beginTransaction();
+            regionB = ValueRegionBox.create(source.boxGraph, UUID.generate(), box => {
+                box.regions.refer(trackB.regions);
+                box.events.refer(sharedEvents.owners);
+                box.position.setValue(0);
+                box.duration.setValue(960);
+            });
+            source.boxGraph.endTransaction();
+            const deps = collectDeviceDependencies(effect, source.boxGraph);
+            const regions = deps.filter(box => isInstanceOf(box, ValueRegionBox));
+            expect(regions.length).toBe(2);
+            expect(regions).toContain(regionA);
+            expect(regions).toContain(regionB);
+            expect(deps.filter(box => isInstanceOf(box, ValueEventCollectionBox)).length).toBe(1);
+            expect(deps.filter(box => isInstanceOf(box, TrackBox)).length).toBe(2);
+        });
+        it("does not pull in regions from unrelated devices that mirror the same collection", () => {
+            const audioUnitA = createAudioUnit(source, 1);
+            const effectA = addAudioEffect(source, audioUnitA, "CompA", 0);
+            const trackA = addAutomationTrack(source, audioUnitA, effectA.threshold, 0);
+            const regionA = addValueRegion(source, trackA, 0, 960);
+            const sharedEvents = regionA.events.targetVertex.unwrap().box;
+            const audioUnitB = createAudioUnit(source, 2);
+            const effectB = addAudioEffect(source, audioUnitB, "CompB", 0);
+            const trackB = addAutomationTrack(source, audioUnitB, effectB.threshold, 0);
+            source.boxGraph.beginTransaction();
+            const unrelatedRegion = ValueRegionBox.create(source.boxGraph, UUID.generate(), box => {
+                box.regions.refer(trackB.regions);
+                box.events.refer(sharedEvents.owners);
+                box.position.setValue(0);
+                box.duration.setValue(960);
+            });
+            source.boxGraph.endTransaction();
+            const deps = collectDeviceDependencies(effectA, source.boxGraph);
+            const regions = deps.filter(box => isInstanceOf(box, ValueRegionBox));
+            expect(regions).toContain(regionA);
+            expect(regions).not.toContain(unrelatedRegion);
+            const tracks = deps.filter(box => isInstanceOf(box, TrackBox));
+            expect(tracks).toContain(trackA);
+            expect(tracks).not.toContain(trackB);
+        });
+        it("round-trip paste of effect with automation events does not throw", () => {
+            const sourceAU = createAudioUnit(source);
+            const effect = addAudioEffect(source, sourceAU, "Comp", 0);
+            const autoTrack = addAutomationTrack(source, sourceAU, effect.threshold, 0);
+            addValueRegion(source, autoTrack, 0, 960);
+            const deps = collectDeviceDependencies(effect, source.boxGraph);
+            const data = ClipboardUtils.serializeBoxes([effect, ...deps]);
+            const targetAU = createAudioUnit(target);
+            const editing = new BoxEditing(target.boxGraph);
+            expect(() => {
+                editing.modify(() => {
+                    ClipboardUtils.deserializeBoxes(data, target.boxGraph, makePasteMapper(targetAU, false, false));
+                });
+            }).not.toThrow();
+            const pastedEffects = targetAU.audioEffects.pointerHub.incoming()
+                .filter(pointer => isInstanceOf(pointer.box, CompressorDeviceBox));
+            expect(pastedEffects.length).toBe(1);
+            const pastedTracks = targetAU.tracks.pointerHub.filter(Pointers.TrackCollection)
+                .filter(pointer => isInstanceOf(pointer.box, TrackBox));
+            expect(pastedTracks.length).toBe(1);
+        });
+        it("pasted automation track targets the pasted device's parameter", () => {
+            const sourceAU = createAudioUnit(source);
+            const effect = addAudioEffect(source, sourceAU, "Comp", 0);
+            const autoTrack = addAutomationTrack(source, sourceAU, effect.threshold, 0);
+            addValueRegion(source, autoTrack, 0, 960);
+            const deps = collectDeviceDependencies(effect, source.boxGraph);
+            const data = ClipboardUtils.serializeBoxes([effect, ...deps]);
+            const targetAU = createAudioUnit(target);
+            const editing = new BoxEditing(target.boxGraph);
+            editing.modify(() => {
+                ClipboardUtils.deserializeBoxes(data, target.boxGraph, makePasteMapper(targetAU, false, false));
+            });
+            const pastedEffect = targetAU.audioEffects.pointerHub.incoming()
+                .filter(pointer => isInstanceOf(pointer.box, CompressorDeviceBox))
+                .map(pointer => pointer.box)[0];
+            const pastedTrack = targetAU.tracks.pointerHub.filter(Pointers.TrackCollection)
+                .filter(pointer => isInstanceOf(pointer.box, TrackBox))
+                .map(pointer => pointer.box)[0];
+            expect(pastedTrack).toBeDefined();
+            const targetVertex = pastedTrack.target.targetVertex.unwrap();
+            expect(targetVertex.box).toBe(pastedEffect);
+        });
+    });
+    // ─────────────────────────────────────────────────────────
     // Instrument paste
     // ─────────────────────────────────────────────────────────
     describe("paste instrument", () => {

package/dist/ysync/YService.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"YService.d.ts","sourceRoot":"","sources":["../../src/ysync/YService.ts"],"names":[],"mappings":"AAAA,OAAO,EAAS,MAAM,EAAyC,MAAM,kBAAkB,CAAA;AAKvF,OAAO,EAAC,OAAO,EAAE,UAAU,EAAmB,MAAM,YAAY,CAAA;AAGhE,OAAO,EAAC,iBAAiB,EAAC,MAAM,aAAa,CAAA;AAI7C,yBAAiB,QAAQ,CAAC;IAMtB,KAAY,UAAU,GAAG;QAAE,OAAO,EAAE,OAAO,CAAC;QAAC,QAAQ,EAAE,iBAAiB,CAAA;KAAE,CAAA;IAEnE,MAAM,eAAe,GAAU,YAAY,MAAM,CAAC,OAAO,CAAC,EAC3B,KAAK,UAAU,EACf,UAAU,MAAM,KAAG,OAAO,CAAC,UAAU,CA+D1E,CAAA;CACJ"}
+{"version":3,"file":"YService.d.ts","sourceRoot":"","sources":["../../src/ysync/YService.ts"],"names":[],"mappings":"AAAA,OAAO,EAAS,MAAM,EAAyC,MAAM,kBAAkB,CAAA;AAKvF,OAAO,EAAC,OAAO,EAAE,UAAU,EAAmB,MAAM,YAAY,CAAA;AAGhE,OAAO,EAAC,iBAAiB,EAAC,MAAM,aAAa,CAAA;AAI7C,yBAAiB,QAAQ,CAAC;IAMtB,KAAY,UAAU,GAAG;QAAE,OAAO,EAAE,OAAO,CAAC;QAAC,QAAQ,EAAE,iBAAiB,CAAA;KAAE,CAAA;IAEnE,MAAM,eAAe,GAAU,YAAY,MAAM,CAAC,OAAO,CAAC,EAC3B,KAAK,UAAU,EACf,UAAU,MAAM,KAAG,OAAO,CAAC,UAAU,CA0D1E,CAAA;CACJ"}

package/dist/ysync/YService.js

@@ -46,9 +46,6 @@ export var YService;
                 conflict: () => project.invalid()
             });
             project.own(sync);
-            // TODO Remove this cast at some point
-            const editing = project.editing;
-            editing.disable();
             return { project, provider };
         }
         else {
@@ -75,8 +72,6 @@ export var YService;
             boxGraph.endTransaction();
             project.follow(userInterfaceBox);
             project.own(sync);
-            const editing = project.editing;
-            editing.disable();
             return { project, provider };
         }
     };

package/dist/ysync/YSync.d.ts

@@ -8,6 +8,7 @@ export type Construct<T> = {
 };
 export declare class YSync<T> implements Terminable {
     #private;
+    static debugging: boolean;
     /** @internal */
     static isEmpty(doc: Y.Doc): boolean;
     static populateRoom<T>({ boxGraph, boxes }: Construct<T>): Promise<YSync<T>>;

package/dist/ysync/YSync.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"YSync.d.ts","sourceRoot":"","sources":["../../src/ysync/YSync.ts"],"names":[],"mappings":"AAAA,OAAO,EASH,QAAQ,EAER,UAAU,EAGb,MAAM,kBAAkB,CAAA;AACzB,OAAO,EAAa,QAAQ,EAA2D,MAAM,kBAAkB,CAAA;AAE/G,OAAO,KAAK,CAAC,MAAM,KAAK,CAAA;AAIxB,MAAM,MAAM,SAAS,CAAC,CAAC,IAAI;IACvB,QAAQ,EAAE,QAAQ,CAAC,CAAC,CAAC,CAAC;IACtB,KAAK,EAAE,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAA;IACrB,QAAQ,CAAC,EAAE,QAAQ,CAAC,OAAO,CAAC,CAAA;CAC/B,CAAA;AAED,qBAAa,KAAK,CAAC,CAAC,CAAE,YAAW,UAAU;;IACvC,gBAAgB;IAChB,MAAM,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC,GAAG,GAAG,OAAO;WAItB,YAAY,CAAC,CAAC,EAAE,EAAC,QAAQ,EAAE,KAAK,EAAC,EAAE,SAAS,CAAC,CAAC,CAAC,GAAG,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;WAcnE,QAAQ,CAAC,CAAC,EAAE,EAAC,QAAQ,EAAE,KAAK,EAAC,EAAE,SAAS,CAAC,CAAC,CAAC,GAAG,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;gBAqChE,EAAC,QAAQ,EAAE,KAAK,EAAE,QAAQ,EAAC,EAAE,SAAS,CAAC,CAAC,CAAC;IASrD,SAAS,IAAI,IAAI;CA4LpB"}
+{"version":3,"file":"YSync.d.ts","sourceRoot":"","sources":["../../src/ysync/YSync.ts"],"names":[],"mappings":"AAAA,OAAO,EAUH,QAAQ,EAER,UAAU,EAIb,MAAM,kBAAkB,CAAA;AACzB,OAAO,EAEH,QAAQ,EAOX,MAAM,kBAAkB,CAAA;AAEzB,OAAO,KAAK,CAAC,MAAM,KAAK,CAAA;AAIxB,MAAM,MAAM,SAAS,CAAC,CAAC,IAAI;IACvB,QAAQ,EAAE,QAAQ,CAAC,CAAC,CAAC,CAAC;IACtB,KAAK,EAAE,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAA;IACrB,QAAQ,CAAC,EAAE,QAAQ,CAAC,OAAO,CAAC,CAAA;CAC/B,CAAA;AAED,qBAAa,KAAK,CAAC,CAAC,CAAE,YAAW,UAAU;;IACvC,MAAM,CAAC,SAAS,EAAE,OAAO,CAAQ;IAEjC,gBAAgB;IAChB,MAAM,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC,GAAG,GAAG,OAAO;WAItB,YAAY,CAAC,CAAC,EAAE,EAAC,QAAQ,EAAE,KAAK,EAAC,EAAE,SAAS,CAAC,CAAC,CAAC,GAAG,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;WAcnE,QAAQ,CAAC,CAAC,EAAE,EAAC,QAAQ,EAAE,KAAK,EAAC,EAAE,SAAS,CAAC,CAAC,CAAC,GAAG,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;gBAqChE,EAAC,QAAQ,EAAE,KAAK,EAAE,QAAQ,EAAC,EAAE,SAAS,CAAC,CAAC,CAAC;IASrD,SAAS,IAAI,IAAI;CAiOpB"}

package/dist/ysync/YSync.js

@@ -1,7 +1,9 @@
-import { asDefined, asInstanceOf, assert, EmptyExec, isUndefined, Option, panic, Terminable, Terminator, UUID } from "@opendaw/lib-std";
+import { asDefined, asInstanceOf, assert, EmptyExec, isInstanceOf, isUndefined, Option, panic, Terminable, Terminator, tryCatch, UUID } from "@opendaw/lib-std";
+import { optimizeUpdates } from "@opendaw/lib-box";
 import { YMapper } from "./YMapper";
 import * as Y from "yjs";
 export class YSync {
+    static debugging = false;
     /** @internal */
     static isEmpty(doc) {
         return doc.getMap("boxes").size === 0;
@@ -62,45 +64,51 @@ export class YSync {
     terminate() { this.#terminator.terminate(); }
     #setupYjs() {
         const eventHandler = (events, { origin, local }) => {
-            const originLabel = typeof origin === "string" ? origin : "WebsocketProvider";
+            const originLabel = typeof origin === "string" ? origin : "Unkown Origin";
             const isOwnOrigin = typeof origin === "string" && origin.startsWith("[openDAW]");
             const isHistoryReplay = typeof origin === "string" && origin.startsWith("[history]");
-            console.debug(`got ${events.length} ${local ? "local" : "external"} updates from '${originLabel}', isHistoryReplay: ${isHistoryReplay}`);
+            console.debug(`got ${events.length} ${local ? "local" : "external"} updates from '${originLabel}', isHistoryReplay: ${isHistoryReplay}, isOwnOrigin: ${isOwnOrigin}`);
             if (isOwnOrigin || (local && !isHistoryReplay)) {
                 return;
             }
             this.#boxGraph.beginTransaction();
-            for (const event of events) {
-                const path = this.#normalizePath(event.path);
-                const keys = event.changes.keys;
-                for (const [key, change] of keys.entries()) {
-                    if (change.action === "add") {
-                        assert(path.length === 0, "'Add' cannot have a path");
-                        this.#createBox(key);
-                    }
-                    else if (change.action === "update") {
-                        if (path.length === 0) {
-                            continue;
+            const result = tryCatch(() => {
+                for (const event of events) {
+                    const path = this.#normalizePath(event.path);
+                    const keys = event.changes.keys;
+                    for (const [key, change] of keys.entries()) {
+                        if (YSync.debugging) {
+                            console.debug(`${change.action} on ${path}:${key}`);
+                        }
+                        if (change.action === "add") {
+                            assert(path.length === 0, "'Add' cannot have a path");
+                            this.#createBox(key);
+                        }
+                        else if (change.action === "update") {
+                            if (path.length === 0) {
+                                continue;
+                            }
+                            assert(path.length >= 2, "Invalid path: must have at least 2 elements (uuid, 'fields').");
+                            this.#updateValue(path, key);
+                        }
+                        else if (change.action === "delete") {
+                            assert(path.length === 0, "'Delete' cannot have a path");
+                            this.#deleteBox(key);
                         }
-                        assert(path.length >= 2, "Invalid path: must have at least 2 elements (uuid, 'fields').");
-                        this.#updateValue(path, key);
-                    }
-                    else if (change.action === "delete") {
-                        assert(path.length === 0, "'Delete' cannot have a path");
-                        this.#deleteBox(key);
                     }
                 }
-            }
-            try {
                 this.#ignoreUpdates = true;
                 this.#boxGraph.endTransaction();
                 this.#ignoreUpdates = false;
-                // TODO Only in DEV-MODE
-                //  this.#boxGraph.verifyPointers()
-            }
-            catch (reason) {
-                this.terminate();
-                return panic(reason);
+            });
+            if (result.status === "failure") {
+                this.#ignoreUpdates = false;
+                if (this.#boxGraph.inTransaction()) {
+                    this.#boxGraph.abortTransaction();
+                }
+                console.warn(`[YSync] Transaction rejected, rolling back:`, result.error);
+                this.#rollbackTransaction(events);
+                return;
             }
             const highLevelConflict = this.#conflict.mapOr(check => check(), false);
             if (highLevelConflict) {
@@ -137,13 +145,9 @@ export class YSync {
         return path.slice(prefix.length);
     }
     #updateValue(path, key) {
-        console.debug(`#updateValue`, path, key);
-        const vertexOption = this.#boxGraph.findVertex(YMapper.pathToAddress(path, key));
-        if (vertexOption.isEmpty()) {
-            console.debug(`Vertex at '${path}' does not exist. Ignoring.`);
-            return;
-        }
-        const vertex = vertexOption.unwrap("Could not find field");
+        const address = YMapper.pathToAddress(path, key);
+        const vertex = this.#boxGraph.findVertex(address)
+            .unwrap(`Vertex at '${address.toString()}' does not exist.`);
         const [uuidAsString, fieldsKey, ...fieldKeys] = path;
         const targetMap = YMapper.findMap(this.#boxes
             .get(String(uuidAsString))
@@ -158,17 +162,11 @@ export class YSync {
         });
     }
     #deleteBox(key) {
-        const optBox = this.#boxGraph.findBox(UUID.parse(key));
-        if (optBox.isEmpty()) {
-            console.debug(`Box '${key}' has already been deleted. Ignoring.`);
-        }
-        else {
-            const box = optBox.unwrap();
-            // It is possible that Yjs have swallowed the pointer releases since they were 'inside' the box.
-            box.outgoingEdges().forEach(([pointer]) => pointer.defer());
-            box.incomingEdges().forEach(pointer => pointer.defer());
-            this.#boxGraph.unstageBox(box);
-        }
+        const box = this.#boxGraph.findBox(UUID.parse(key))
+            .unwrap(`Box '${key}' does not exist.`);
+        box.outgoingEdges().forEach(([pointer]) => pointer.defer());
+        box.incomingEdges().forEach(pointer => pointer.defer());
+        this.#boxGraph.unstageBox(box);
     }
     #rollbackTransaction(events) {
         console.debug(`rollback ${events.length} events...`);
@@ -202,51 +200,96 @@ export class YSync {
     #setupOpenDAW() {
         return Terminable.many(this.#boxGraph.subscribeTransaction({
             onBeginTransaction: EmptyExec,
-            onEndTransaction: () => {
-                if (this.#ignoreUpdates) {
-                    this.#updates.length = 0;
+            onEndTransaction: (rolledBack) => {
+                const pending = this.#updates.splice(0);
+                if (this.#ignoreUpdates || rolledBack) {
                     return;
                 }
-                this.#getDoc().transact(() => this.#updates.forEach(update => {
-                    /**
-                     * TRANSFER CHANGES FROM OPENDAW TO YJS
-                     */
-                    if (update.type === "new") {
-                        const uuid = update.uuid;
-                        const key = UUID.toString(uuid);
-                        const box = this.#boxGraph.findBox(uuid).unwrap();
-                        this.#boxes.set(key, YMapper.createBoxMap(box));
-                    }
-                    else if (update.type === "primitive") {
-                        const key = UUID.toString(update.address.uuid);
-                        const boxObject = asDefined(this.#boxes.get(key), "Could not find box");
-                        const { address: { fieldKeys }, newValue } = update;
-                        let field = boxObject.get("fields");
-                        for (let i = 0; i < fieldKeys.length - 1; i++) {
-                            field = asDefined(field.get(String(fieldKeys[i])), `No field at '${fieldKeys[i]}'`);
-                        }
-                        field.set(String(fieldKeys[fieldKeys.length - 1]), newValue);
-                    }
-                    else if (update.type === "pointer") {
-                        const key = UUID.toString(update.address.uuid);
-                        const boxObject = asDefined(this.#boxes.get(key), "Could not find box");
-                        const { address: { fieldKeys }, newAddress } = update;
-                        let field = boxObject.get("fields");
-                        for (let i = 0; i < fieldKeys.length - 1; i++) {
-                            field = asDefined(field.get(String(fieldKeys[i])), `No field at '${fieldKeys[i]}'`);
-                        }
-                        field.set(String(fieldKeys[fieldKeys.length - 1]), newAddress.mapOr(address => address.toString(), null));
-                    }
-                    else if (update.type === "delete") {
-                        this.#boxes.delete(UUID.toString(update.uuid));
-                    }
-                }), "[openDAW] updates");
-                this.#updates.length = 0;
+                const optimized = optimizeUpdates(pending);
+                if (optimized.length === 0) {
+                    return;
+                }
+                const result = tryCatch(() => this.#getDoc()
+                    .transact(() => optimized.forEach(update => this.#applyUpdate(update)), "[openDAW] updates"));
+                if (result.status === "failure") {
+                    console.error("[YSync] flush failed, dropping updates", {
+                        count: optimized.length,
+                        error: result.error
+                    });
+                    throw result.error;
+                }
             }
         }), this.#boxGraph.subscribeToAllUpdatesImmediate({
             onUpdate: (update) => this.#updates.push(update)
         }));
     }
+    /**
+     * TRANSFER ONE CHANGE FROM OPENDAW TO YJS
+     */
+    #applyUpdate(update) {
+        if (update.type === "new") {
+            const uuid = update.uuid;
+            const key = UUID.toString(uuid);
+            const optBox = this.#boxGraph.findBox(uuid);
+            if (optBox.isEmpty()) {
+                // Phantom box: created and removed in same transaction.
+                // optimizeUpdates should have filtered this, but guard in case.
+                return;
+            }
+            this.#boxes.set(key, YMapper.createBoxMap(optBox.unwrap()));
+        }
+        else if (update.type === "primitive") {
+            const key = UUID.toString(update.address.uuid);
+            const boxObject = this.#boxes.get(key);
+            if (!isInstanceOf(boxObject, Y.Map)) {
+                console.warn(`[YSync] primitive update skipped: box '${key}' missing`);
+                return;
+            }
+            const field = this.#resolveFieldMap(boxObject, key, update.address.fieldKeys);
+            if (field === undefined) {
+                return;
+            }
+            field.set(String(update.address.fieldKeys[update.address.fieldKeys.length - 1]), update.newValue);
+        }
+        else if (update.type === "pointer") {
+            const key = UUID.toString(update.address.uuid);
+            const boxObject = this.#boxes.get(key);
+            if (!isInstanceOf(boxObject, Y.Map)) {
+                console.warn(`[YSync] pointer update skipped: box '${key}' missing`);
+                return;
+            }
+            const field = this.#resolveFieldMap(boxObject, key, update.address.fieldKeys);
+            if (field === undefined) {
+                return;
+            }
+            field.set(String(update.address.fieldKeys[update.address.fieldKeys.length - 1]), update.newAddress.mapOr(address => address.toString(), null));
+        }
+        else if (update.type === "delete") {
+            this.#boxes.delete(UUID.toString(update.uuid));
+        }
+    }
+    /**
+     * Walks from the box map down to the Y.Map that owns `fieldKeys[last]`.
+     * Returns `undefined` (with a warning) instead of throwing if the path
+     * cannot be resolved — protects the yjs transaction from partial writes.
+     */
+    #resolveFieldMap(boxObject, key, fieldKeys) {
+        const fieldsValue = boxObject.get("fields");
+        if (!isInstanceOf(fieldsValue, Y.Map)) {
+            console.warn(`[YSync] box '${key}' missing 'fields' Y.Map; skipping update`);
+            return undefined;
+        }
+        let field = fieldsValue;
+        for (let i = 0; i < fieldKeys.length - 1; i++) {
+            const next = field.get(String(fieldKeys[i]));
+            if (!isInstanceOf(next, Y.Map)) {
+                console.warn(`[YSync] box '${key}' field path broken at '${fieldKeys[i]}'; skipping update`);
+                return undefined;
+            }
+            field = next;
+        }
+        return field;
+    }
     #getDoc() {
         return asDefined(this.#boxes.doc, "Y.Map is not connect to Y.Doc");
     }

package/dist/ysync/YSync.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=YSync.test.d.ts.map

package/dist/ysync/YSync.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"YSync.test.d.ts","sourceRoot":"","sources":["../../src/ysync/YSync.test.ts"],"names":[],"mappings":""}